Re: GitHub usernames as maintainers
On 2016-11-02 23:58, Clemens Lang wrote: > On Wed, Nov 02, 2016 at 06:45:21PM -0400, Brandon Allbery wrote: >> For me, it looks too much like an email address when combined with >> other things (e.g. "maintainers openmaintainer @foo"). > > I think that's a formatting problem. We could just as well print > https://github.com/neverpanic in the output of port info --maintainer, > which is (a) not ambiguous, and (b) clickable. Although clickable, from such an URL it is quite strange to deduce what to use in the CC field on tickets. Rainer ___ macports-dev mailing list macports-dev@lists.macosforge.org https://lists.macosforge.org/mailman/listinfo/macports-dev
Re: GitHub usernames as maintainers
On Wed, Nov 02, 2016 at 06:45:21PM -0400, Brandon Allbery wrote: > For me, it looks too much like an email address when combined with > other things (e.g. "maintainers openmaintainer @foo"). I think that's a formatting problem. We could just as well print https://github.com/neverpanic in the output of port info --maintainer, which is (a) not ambiguous, and (b) clickable. -- Clemens ___ macports-dev mailing list macports-dev@lists.macosforge.org https://lists.macosforge.org/mailman/listinfo/macports-dev
Re: GitHub usernames as maintainers
On Wed, Nov 2, 2016 at 6:42 PM, Clemens Lang wrote: > > When we were originally planning the transition to GitHub, I suggested > > that we allow an "@" syntax in the maintainers line for GitHub > > usernames (i.e. "maintainers @neverpanic" for Clemens). I don't > > remember right now why we then decided that wasn't a good idea. > > I think we should re-visit that decision. Maybe I'll find a couple of > minutes to implement this in base. If so, I'll send a PR for discussion. For me, it looks too much like an email address when combined with other things (e.g. "maintainers openmaintainer @foo"). -- brandon s allbery kf8nh sine nomine associates allber...@gmail.com ballb...@sinenomine.net unix, openafs, kerberos, infrastructure, xmonadhttp://sinenomine.net ___ macports-dev mailing list macports-dev@lists.macosforge.org https://lists.macosforge.org/mailman/listinfo/macports-dev
Re: GitHub usernames as maintainers
On Wed, Nov 02, 2016 at 05:27:30PM -0500, Ryan Schmidt wrote: > On Nov 2, 2016, at 1:49 AM, Mojca Miklavec wrote: > > It would be nice if "port info" would also print the github > > usernames of maintainers. > > When we were originally planning the transition to GitHub, I suggested > that we allow an "@" syntax in the maintainers line for GitHub > usernames (i.e. "maintainers @neverpanic" for Clemens). I don't > remember right now why we then decided that wasn't a good idea. I think we should re-visit that decision. Maybe I'll find a couple of minutes to implement this in base. If so, I'll send a PR for discussion. -- Clemens ___ macports-dev mailing list macports-dev@lists.macosforge.org https://lists.macosforge.org/mailman/listinfo/macports-dev
Re: GitHub usernames as maintainers
On Nov 2, 2016, at 1:49 AM, Mojca Miklavec wrote: > It would be nice if "port info" would also print the github usernames > of maintainers. When we were originally planning the transition to GitHub, I suggested that we allow an "@" syntax in the maintainers line for GitHub usernames (i.e. "maintainers @neverpanic" for Clemens). I don't remember right now why we then decided that wasn't a good idea. ___ macports-dev mailing list macports-dev@lists.macosforge.org https://lists.macosforge.org/mailman/listinfo/macports-dev
Re: GitHub usernames as maintainers
On 1 November 2016 at 19:57, Clemens Lang wrote: > On Tue, Nov 01, 2016 at 07:42:23PM +0100, Mojca Miklavec wrote: > >> At some point (rather sooner than later) we'll have to start adding >> GitHub usernames to Portfiles (we might have to extend the base to >> properly support that). > > I agree, especially because the GitHub username is now also valid in > Trac. At the moment, you'd get new tickets sent to your email address, > not your Trac account (unless a user notices the equivalence in the > auto-completion box). > >> And quite honestly I would also be in favour of asking committers to >> use the same MacPorts handle as their GitHub account name (and only >> keep the old ones as aliases). > > I like my handle, but I can see how it could lead to confusion. On the > other hand, the maintainer handles are bound to become less important in > the future anyway. If you want to reach a committer, there usually are > contact methods on their GitHub profile. You made your email public. Many accounts have no contact information available, so the only way to contact them is to: - open a random bogus ticket and mention their name as @username (but that most likely means sending a "public message") - figure out which repositories they have contributed to, clone the repository and find the email there None of that is really straightforward. And trying to matching a known email to the username is actually worse. When creating pull requests on GitHub (but also for tickets on Trac) we'll need that for both committers and non-committers. Trac has at least the nice auto-completion functionality that GitHub doesn't. It would be nice if "port info" would also print the github usernames of maintainers. Mojca ___ macports-dev mailing list macports-dev@lists.macosforge.org https://lists.macosforge.org/mailman/listinfo/macports-dev
Re: GitHub usernames as maintainers [Was: Re: [macports-ports] branch master updated: berkeleygw: Remove svn $Id$ line.]
On 2016-11-01 19:57, Clemens Lang wrote: > On Tue, Nov 01, 2016 at 07:42:23PM +0100, Mojca Miklavec wrote: >> At some point (rather sooner than later) we'll have to start adding >> GitHub usernames to Portfiles (we might have to extend the base to >> properly support that). > > I agree, especially because the GitHub username is now also valid in > Trac. At the moment, you'd get new tickets sent to your email address, > not your Trac account (unless a user notices the equivalence in the > auto-completion box). Should we get Trac to automatically replace email addresses with the corresponding username in the Owner and CC fields? >> And quite honestly I would also be in favour of asking committers to >> use the same MacPorts handle as their GitHub account name (and only >> keep the old ones as aliases). > > I like my handle, but I can see how it could lead to confusion. On the > other hand, the maintainer handles are bound to become less important in > the future anyway. If you want to reach a committer, there usually are > contact methods on their GitHub profile. Using GitHub usernames in the maintainer field has the downside that you can no longer reach port maintainers outside of GitHub or Trac. There is no requirement to have a public email address on the GitHub profile. We could add a mapping of GitHub username to MacPorts handle to the ports tree, but that would also only solve the problem for the developers team, not outside collaborators. Rainer ___ macports-dev mailing list macports-dev@lists.macosforge.org https://lists.macosforge.org/mailman/listinfo/macports-dev
GitHub usernames as maintainers [Was: Re: [macports-ports] branch master updated: berkeleygw: Remove svn $Id$ line.]
On Tue, Nov 01, 2016 at 07:42:23PM +0100, Mojca Miklavec wrote: > If someone submits a pull request for a maintained port, the > maintainer should probably be notified explicitly with @username. The > problem is that currently only Trac maintainers have access to that > mapping. It's not a set of data I'd like to keep forever. We're requesting people's non-public email addresses from GitHub to do the migration, not to implement arbitrary other features on top of that data. > At some point (rather sooner than later) we'll have to start adding > GitHub usernames to Portfiles (we might have to extend the base to > properly support that). I agree, especially because the GitHub username is now also valid in Trac. At the moment, you'd get new tickets sent to your email address, not your Trac account (unless a user notices the equivalence in the auto-completion box). > And quite honestly I would also be in favour of asking committers to > use the same MacPorts handle as their GitHub account name (and only > keep the old ones as aliases). I like my handle, but I can see how it could lead to confusion. On the other hand, the maintainer handles are bound to become less important in the future anyway. If you want to reach a committer, there usually are contact methods on their GitHub profile. -- Clemens ___ macports-dev mailing list macports-dev@lists.macosforge.org https://lists.macosforge.org/mailman/listinfo/macports-dev
