Re: Pull Requests for Work in Progress (WIP)

[Mojca Miklavec]

On 4 November 2016 at 18:55, Marko Käning wrote:
>
> Besides there is even a clearly visible RED "Work-In-Progress" label 
> available in the PR interface, which Mojca had spotted eventually.

I didn't spot it. I though it was useful and made it after this
discussion was started.

Mojca
___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev

Re: Pull Requests for Work in Progress (WIP)

[Marko Käning]

On 04 Nov 2016, at 02:19 , Arno Hautala  wrote:
> But, it occurs to me that one of the goals of moving
> to GitHub is greater collaboration and that is facilitated by inline
> comments on the pull request. Plus, a completed pull request is one
> comment away from a work in progress anyway.

+1


> The alternative to WiP pull requests is posting multiple comparison
> URLs to reference different lines of code that must be opened in
> different windows. Plus, those references will break as soon as any
> changes are made to the branch.

Exactly, I don’t think this is the way to go.

But let’s those decide who would have to deal (or not) with those red “WIP” 
badges in GitHub PR interface every now and then...

Well, if it is too much red noise in the PR interface then one would have to 
have these discussions directly on the contributors’ private forks of the 
macports-ports.
Downside there: If one decides to kill one of these repos all their comments to 
the relevant code are gone. So, that’s perhaps an argument more for keeping WIP 
PRs?
___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev

Re: Pull Requests for Work in Progress (WIP)

[Marko Käning]

Hi Rainer,

On 03 Nov 2016, at 18:57 , Sterling Smith  wrote:
> On Nov 3, 2016, at 10:47AM, Rainer Müller  wrote:
> 
>> On 2016-11-03 17:49, Sterling Smith wrote:
>>> The main question of procedure is: Should the main macports repo be
>>> used for proposing review of work in progress via pull requests?  If
>>> not, what is the proposed method?
>> 
>> I propose you put your changes on a branch, add the compare URL to a
>> ticket or send an email to macports-dev.
>> 
>> In the case you referred to, this would be:
>> 
>> https://github.com/mkae/macports-ports/compare/master...mkae:qtcurve_upgrade-for-Qt5
>> 
> The downside (as I see it) of using the compare URL, as opposed to a full 
> pull request, is that line by line comments are not available.

I think this is _downside_ enough to NOT use the approach suggested by you, 
because loosing the reviewing features (comments directly in the code) doesn’t 
make reviewers’ work easier, does it!

Besides there is even a clearly visible RED "Work-In-Progress" label available 
in the PR interface, which Mojca had spotted eventually.

But, hey, who am I to oppose such a decision if the core team of committers 
doesn’t think it’s a good idea?
Perhaps we should initiate a poll among the top 10 or even 20 committers, who 
are carrying the major load of reviewing/committing for MacPorts’ ports repo???

Greets,
Marko

___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev

Re: Pull Requests for Work in Progress (WIP)

[Arno Hautala]

>>> The main question of procedure is: Should the main macports repo be
>>> used for proposing review of work in progress via pull requests?  If
>>> not, what is the proposed method?
>>
>> I propose you put your changes on a branch, add the compare URL to a
>> ticket or send an email to macports-dev.
>>
> The downside (as I see it) of using the compare URL, as opposed to a full 
> pull request, is that line by line comments are not available.

I started out on the side of just keeping the pull request for a
completed work. But, it occurs to me that one of the goals of moving
to GitHub is greater collaboration and that is facilitated by inline
comments on the pull request. Plus, a completed pull request is one
comment away from a work in progress anyway.

The other side that I see is that this furthers the existing
separation where pull requests (and now work-in-progress discussions)
are on GitHub and ticket discussions are on Trac. Given that pull
requests are already on GitHub, I don't think this is a significant
issue.

The alternative to WiP pull requests is posting multiple comparison
URLs to reference different lines of code that must be opened in
different windows. Plus, those references will break as soon as any
changes are made to the branch.

-- 
arno  s  hautala/-|   a...@alum.wpi.edu

pgp b2c9d448
___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev

Re: Pull Requests for Work in Progress (WIP)

[Sterling Smith]

On Nov 3, 2016, at 10:47AM, Rainer Müller  wrote:

> On 2016-11-03 17:49, Sterling Smith wrote:
>> The main question of procedure is: Should the main macports repo be
>> used for proposing review of work in progress via pull requests?  If
>> not, what is the proposed method?
> 
> I propose you put your changes on a branch, add the compare URL to a
> ticket or send an email to macports-dev.
> 
> In the case you referred to, this would be:
> 
> https://github.com/mkae/macports-ports/compare/master...mkae:qtcurve_upgrade-for-Qt5
> 
The downside (as I see it) of using the compare URL, as opposed to a full pull 
request, is that line by line comments are not available.

-Sterling

___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev

Re: Pull Requests for Work in Progress (WIP)

[Rainer Müller]

On 2016-11-03 17:49, Sterling Smith wrote:
>  The main question of procedure is: Should the main macports repo be
> used for proposing review of work in progress via pull requests?  If
> not, what is the proposed method?

I propose you put your changes on a branch, add the compare URL to a
ticket or send an email to macports-dev.

In the case you referred to, this would be:

https://github.com/mkae/macports-ports/compare/master...mkae:qtcurve_upgrade-for-Qt5

Rainer
___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev

Pull Requests for Work in Progress (WIP)

[Sterling Smith]

Devs,

This thread is meant to continue comments starting with 
https://github.com/macports/macports-ports/pull/7#issuecomment-258057083

The main question of procedure is: Should the main macports repo be used for 
proposing review of work in progress via pull requests?  If not, what is the 
proposed method?

-Sterling

___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev