Re: Port ehcache Issue #60219
Thanks a lot Sir. I'll look into them. Thanks and Regards, Yours Sincerely, Saptarshi Mukherjee, A GSoC 2020 Aspirant. On Sun, Apr 5, 2020, 04:13 Ryan Schmidt wrote: > > > On Apr 3, 2020, at 14:56, SAPTARSHI MUKHERJEE wrote: > > > Thanks for the suggestions. However, having tried a pull request, I > unfortunately faced a build error on Azure Pipelines. As per my observation > on my local machine, there shouldn't have been an error, as the distfile > was fetched correctly, and the build statement mentioned explicitly to > prevent any error. Any suggestions for possible rectification or > identification of error would be highly appreciated. > > > > The link to the pull request committed is as follows: > https://github.com/macports/macports-ports/pull/6784. > > I added comments to the PR. > >
Re: Port ehcache Issue #60219
On Apr 3, 2020, at 14:56, SAPTARSHI MUKHERJEE wrote: > Thanks for the suggestions. However, having tried a pull request, I > unfortunately faced a build error on Azure Pipelines. As per my observation > on my local machine, there shouldn't have been an error, as the distfile was > fetched correctly, and the build statement mentioned explicitly to prevent > any error. Any suggestions for possible rectification or identification of > error would be highly appreciated. > > The link to the pull request committed is as follows: > https://github.com/macports/macports-ports/pull/6784. I added comments to the PR.
Re: Port ehcache Issue #60219
Hi, Thanks for the suggestions. However, having tried a pull request, I unfortunately faced a build error on Azure Pipelines. As per my observation on my local machine, there shouldn't have been an error, as the distfile was fetched correctly, and the build statement mentioned explicitly to prevent any error. Any suggestions for possible rectification or identification of error would be highly appreciated. The link to the pull request committed is as follows: https://github.com/macports/macports-ports/pull/6784. Thanks and Regards, Yours Sincerely, *Saptarshi Mukherjee,* *A GSoC 2020 Aspirant.* On Fri, Apr 3, 2020 at 10:37 PM Nils Breunese wrote: > Ryan Schmidt wrote: > > > On Apr 2, 2020, at 09:39, SAPTARSHI MUKHERJEE wrote: > > > >> Thanks again for assigning to me the issue #60219 related to port > ehcache. It helped me develop a much better understanding about a few > things related to the portfile and the ports. > >> > >> I've made the necessary changes that fetches the new jar file > appropriately, checks with updated checksum values correctly, and I've > removed the Kaffe dependency, replacing it with the Java Portgroup. It has > given expected results on testing, however following are few things that > I'd like to know:- > >> > >> 1) Does this port still need to depend on apache-ant? Facing an error > in apache-ant, I've removed the statement, which helped me get rid of the > build-related error. If the apache-ant still needs to be retained, I'll > have to look into it to fix the error that was like "Command failed : ant > clean dist". Please tell me if the dependency becomes redundant after > inclusion of Java portgroup or is still important. > > > > The Java portgroup doesn't mention anything about ant, so I don't know. > If the port builds in trace mode without a dependency on ant then I guess > it doesn't need it anymore. You can also consult any installation > documentation that this project might provide; hopefully they would tell > you what their dependencies are. > > The current Portfile for the EhCache library at > https://github.com/macports/macports-ports/blob/master/java/ehcache/Portfile > is for version 1.1, which is pretty ancient. According to > https://search.maven.org/artifact/net.sf.ehcache/ehcache EhCache 1.2 was > added to the Maven Central repository on April 26, 2006. So EhCache 1.1 > will be older than that. > > EhCache 2.x used Maven 2 to build: > https://www.ehcache.org/documentation/2.7/get-started/building.html > > According to https://www.ehcache.org/downloads/ the current version of > EhCache is 3.8.1. Looking at https://github.com/ehcache/ehcache3 EhCache > 3.x uses Gradle Wrapper to build from source. Running something like > `./gradlew build` should work, requiring only a Java Development Kit (JDK) > to be installed. If the new Portfile fetches a pre-built JAR using one of > the download links from https://www.ehcache.org/downloads/ then there is > nothing to build. > > I’m a Java developer myself and I actually wouldn’t know what Java > developer these days would use a package manager like MacPorts to install a > library. The popular Java build tools (Maven, Gradle) fetch their > dependencies from Maven repositories. > > According to `port echo depends:ehcache` there are no ports that depend on > the ehcache port that is currently in MacPorts, so I actually think it > would be better to remove a port like this from MacPorts. > > Nils. > >
Re: Port ehcache Issue #60219
Ryan Schmidt wrote: > On Apr 2, 2020, at 09:39, SAPTARSHI MUKHERJEE wrote: > >> Thanks again for assigning to me the issue #60219 related to port ehcache. >> It helped me develop a much better understanding about a few things related >> to the portfile and the ports. >> >> I've made the necessary changes that fetches the new jar file appropriately, >> checks with updated checksum values correctly, and I've removed the Kaffe >> dependency, replacing it with the Java Portgroup. It has given expected >> results on testing, however following are few things that I'd like to know:- >> >> 1) Does this port still need to depend on apache-ant? Facing an error in >> apache-ant, I've removed the statement, which helped me get rid of the >> build-related error. If the apache-ant still needs to be retained, I'll have >> to look into it to fix the error that was like "Command failed : ant clean >> dist". Please tell me if the dependency becomes redundant after inclusion of >> Java portgroup or is still important. > > The Java portgroup doesn't mention anything about ant, so I don't know. If > the port builds in trace mode without a dependency on ant then I guess it > doesn't need it anymore. You can also consult any installation documentation > that this project might provide; hopefully they would tell you what their > dependencies are. The current Portfile for the EhCache library at https://github.com/macports/macports-ports/blob/master/java/ehcache/Portfile is for version 1.1, which is pretty ancient. According to https://search.maven.org/artifact/net.sf.ehcache/ehcache EhCache 1.2 was added to the Maven Central repository on April 26, 2006. So EhCache 1.1 will be older than that. EhCache 2.x used Maven 2 to build: https://www.ehcache.org/documentation/2.7/get-started/building.html According to https://www.ehcache.org/downloads/ the current version of EhCache is 3.8.1. Looking at https://github.com/ehcache/ehcache3 EhCache 3.x uses Gradle Wrapper to build from source. Running something like `./gradlew build` should work, requiring only a Java Development Kit (JDK) to be installed. If the new Portfile fetches a pre-built JAR using one of the download links from https://www.ehcache.org/downloads/ then there is nothing to build. I’m a Java developer myself and I actually wouldn’t know what Java developer these days would use a package manager like MacPorts to install a library. The popular Java build tools (Maven, Gradle) fetch their dependencies from Maven repositories. According to `port echo depends:ehcache` there are no ports that depend on the ehcache port that is currently in MacPorts, so I actually think it would be better to remove a port like this from MacPorts. Nils.
Re: Port ehcache Issue #60219
On Apr 2, 2020, at 09:39, SAPTARSHI MUKHERJEE wrote: > Thanks again for assigning to me the issue #60219 related to port ehcache. It > helped me develop a much better understanding about a few things related to > the portfile and the ports. > > I've made the necessary changes that fetches the new jar file appropriately, > checks with updated checksum values correctly, and I've removed the Kaffe > dependency, replacing it with the Java Portgroup. It has given expected > results on testing, however following are few things that I'd like to know:- > > 1) Does this port still need to depend on apache-ant? Facing an error in > apache-ant, I've removed the statement, which helped me get rid of the > build-related error. If the apache-ant still needs to be retained, I'll have > to look into it to fix the error that was like "Command failed : ant clean > dist". Please tell me if the dependency becomes redundant after inclusion of > Java portgroup or is still important. The Java portgroup doesn't mention anything about ant, so I don't know. If the port builds in trace mode without a dependency on ant then I guess it doesn't need it anymore. You can also consult any installation documentation that this project might provide; hopefully they would tell you what their dependencies are. > 2) On running the command "sudo port test", when it enters the testing phase, > it says "Failed to test ehcache: ehcache has no tests turned on. see > 'test.run' in portfile(7)". I feel it is not related to the correctness of > the portfile code, but may please guide me in how I can get rid of this issue > and be able to test it successfully. I'm submitting the main.log for your > kind reference. "sudo port test" will not work unless you put "test.run yes" into the Portfile. Then "sudo port test" will build the project and then run whatever command is implied by test.cmd and test.args. The default values set by MacPorts may not be appropriate to this project; if not, you'll need to modify them to whatever values this project needs. You'd have to figure out what those are. This is all only if the project actually has tests and if you want to enable users to run them. As you say, that's not related to the ticket and is not required.
Port ehcache Issue #60219
Hi, Thanks again for assigning to me the issue #60219 related to port ehcache. It helped me develop a much better understanding about a few things related to the portfile and the ports. I've made the necessary changes that fetches the new jar file appropriately, checks with updated checksum values correctly, and I've removed the Kaffe dependency, replacing it with the Java Portgroup. It has given expected results on testing, however following are few things that I'd like to know:- 1) Does this port still need to depend on apache-ant? Facing an error in apache-ant, I've removed the statement, which helped me get rid of the build-related error. If the apache-ant still needs to be retained, I'll have to look into it to fix the error that was like *"Command failed : ant clean dist". *Please tell me if the dependency becomes redundant after inclusion of Java portgroup or is still important. 2) On running the command "sudo port test", when it enters the testing phase, it says "*Failed to test ehcache: ehcache has no tests turned on. see 'test.run' in portfile(7)*". I feel it is not related to the correctness of the portfile code, but may please guide me in how I can get rid of this issue and be able to test it successfully. I'm submitting the main.log for your kind reference. Thanks for all the assistance till now. I'd be highly grateful at your kind suggestions w.r.t. the above issues. With Warmest Regards, Yours Sincerely, *Saptarshi Mukherjee,* *A GSoC 2020 Aspirant.* main.log Description: Binary data
