[Mahara-contributors] [Bug 1826462] A change has been merged
Reviewed: https://reviews.mahara.org/9876 Committed: https://git.mahara.org/mahara/mahara/commit/b0ae8263d5b556b4c1b1e9ba711461e24af914b6 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:19.04_STABLE commit b0ae8263d5b556b4c1b1e9ba711461e24af914b6 Author: Evonne Cheung Date: Fri Apr 26 10:13:22 2019 +1200 Bug 1826462 Removing unread messages background color Removed unread messages background colour and made font bold instead. behatnotneeded Change-Id: Ibb06bf194b14ecd465dd4a772db3d57817b268ab (cherry picked from commit a6c0a5d69579a3707ccfd739187a8ab689b3dfba) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826462 Title: Unread messages shouldn't have background color Status in Mahara: Fix Committed Bug description: Follow-on from Bootstrap 4 upgrade When you have unread messages in your inbox, the background of the notifications has the primary theme color when it shouldn't be there. The text should be bold with no particular background. See https://manual.mahara.org/en/18.10/_images/inbox.png for what is expected. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826462/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826462] A patch has been submitted for review
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9876 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826462 Title: Unread messages shouldn't have background color Status in Mahara: Fix Committed Bug description: Follow-on from Bootstrap 4 upgrade When you have unread messages in your inbox, the background of the notifications has the primary theme color when it shouldn't be there. The text should be bold with no particular background. See https://manual.mahara.org/en/18.10/_images/inbox.png for what is expected. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826462/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826462] A change has been merged
Reviewed: https://reviews.mahara.org/9867 Committed: https://git.mahara.org/mahara/mahara/commit/a6c0a5d69579a3707ccfd739187a8ab689b3dfba Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit a6c0a5d69579a3707ccfd739187a8ab689b3dfba Author: Evonne Cheung Date: Fri Apr 26 10:13:22 2019 +1200 Bug 1826462 Removing unread messages background color Removed unread messages background colour and made font bold instead. behatnotneeded Change-Id: Ibb06bf194b14ecd465dd4a772db3d57817b268ab -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826462 Title: Unread messages shouldn't have background color Status in Mahara: Fix Committed Bug description: Follow-on from Bootstrap 4 upgrade When you have unread messages in your inbox, the background of the notifications has the primary theme color when it shouldn't be there. The text should be bold with no particular background. See https://manual.mahara.org/en/18.10/_images/inbox.png for what is expected. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826462/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826471] A patch has been submitted for review
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9875 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826471 Title: The warning background color should be a bit lighter for accessibility Status in Mahara: Fix Committed Bug description: The warning background color, e.g. the color you see when a portfolio has been submitted, is rather dark. It should be lightened a bit and the text color darkened. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826471/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826471] A change has been merged
Reviewed: https://reviews.mahara.org/9866 Committed: https://git.mahara.org/mahara/mahara/commit/85764620ca08731abea945a8059c60a370f57977 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 85764620ca08731abea945a8059c60a370f57977 Author: Evonne Cheung Date: Fri Apr 26 09:48:25 2019 +1200 Bug 1826471 Change Warning status colours for accessibility Changed the warning bg and text colour to higher contrast. behatnotneeded Change-Id: I41ad4a6074b7f8f6aebe446e87d2306b9ee668df -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826471 Title: The warning background color should be a bit lighter for accessibility Status in Mahara: Fix Committed Bug description: The warning background color, e.g. the color you see when a portfolio has been submitted, is rather dark. It should be lightened a bit and the text color darkened. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826471/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826471] A change has been merged
Reviewed: https://reviews.mahara.org/9875 Committed: https://git.mahara.org/mahara/mahara/commit/bb54965f9b0b0faa7ceb7ca47938b6239a99761b Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:19.04_STABLE commit bb54965f9b0b0faa7ceb7ca47938b6239a99761b Author: Evonne Cheung Date: Fri Apr 26 09:48:25 2019 +1200 Bug 1826471 Change Warning status colours for accessibility Changed the warning bg and text colour to higher contrast. behatnotneeded Change-Id: I41ad4a6074b7f8f6aebe446e87d2306b9ee668df (cherry picked from commit 85764620ca08731abea945a8059c60a370f57977) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826471 Title: The warning background color should be a bit lighter for accessibility Status in Mahara: Fix Committed Bug description: The warning background color, e.g. the color you see when a portfolio has been submitted, is rather dark. It should be lightened a bit and the text color darkened. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826471/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1798203] A change has been merged
Reviewed: https://reviews.mahara.org/9863 Committed: https://git.mahara.org/mahara/mahara/commit/2f09502049ae50ca06b6b1ffa4645bce0cb8def5 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:18.10_STABLE commit 2f09502049ae50ca06b6b1ffa4645bce0cb8def5 Author: Kevin Dibble Date: Mon Mar 25 16:48:28 2019 +1300 bug 1798203: Peer review prevents viewing objectionable content Updated view to allow the user admin to view content if it has reported objectionable content. behatnotneeded Change-Id: I277902b5a6121c5daaa6f692dcc391e9ef99caf8 (cherry picked from commit 39d4428671c8292bb2c3335d869278753608ef58) (cherry picked from commit e535179c3ea3bce35316f2eba5137b1822a3f568) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1798203 Title: Peer review role prevents site / institution admin from seeing all content on page during objectionable review Status in Mahara: Fix Committed Status in Mahara 18.10 series: Fix Committed Status in Mahara 19.04 series: Fix Committed Bug description: Bug Summary: Content author has a public portfolio page -> Another user reports objectionable material = author sees warning on page -> does not edit page but adds the site admin as a peer reviewer -> who can not see the page details but only the headings --- Environment tested: Master Browser tested: Chrome Preconditions: 1. Content author creates a portfolio page 2. Another site user reports objectionable material on the page Test Steps: 1. Content author does not change any content on the page 2. Content author shares the page with Site admin and assigns the role of peer for peer review 3. Content author notify site admin stuff has been changed 4. Site admin logs in and browses to the page with objectionable material Actual result: The site admin only sees headings on the page and cannot see the actual page content Expected result: Site admin should be able to see all page content even if they are assigned the role of peer for peer review or site admins should not be in the list of users that can do peer reviews To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1798203/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1800421] A change has been merged
Reviewed: https://reviews.mahara.org/9864 Committed: https://git.mahara.org/mahara/mahara/commit/2cd7a871f8ef7a837af91e951d3714434d1aceb1 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:18.10_STABLE commit 2cd7a871f8ef7a837af91e951d3714434d1aceb1 Author: Robert Lyon Date: Fri Apr 26 09:16:09 2019 +1200 Bug 1800421: Needing to use older SASS variables in backport otherwise 'make css' fails behatnotneeded Change-Id: I47e6fda1999e95adc561c6bdeeda5fe8246c765e Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1800421 Title: Page and peer instructions are not exported properly in HTML and Leap2A Status in Mahara: Fix Committed Status in Mahara 18.10 series: Fix Committed Status in Mahara 19.04 series: Fix Committed Bug description: When a portfolio is exported that has page instructions, they do not appear in the HTML or Leap2A export. Since they are part of the portfolio, they should be exported. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1800421/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1798203] Re: Peer review role prevents site / institution admin from seeing all content on page during objectionable review
** Changed in: mahara/18.10 Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1798203 Title: Peer review role prevents site / institution admin from seeing all content on page during objectionable review Status in Mahara: Fix Committed Status in Mahara 18.10 series: Fix Committed Status in Mahara 19.04 series: Fix Committed Bug description: Bug Summary: Content author has a public portfolio page -> Another user reports objectionable material = author sees warning on page -> does not edit page but adds the site admin as a peer reviewer -> who can not see the page details but only the headings --- Environment tested: Master Browser tested: Chrome Preconditions: 1. Content author creates a portfolio page 2. Another site user reports objectionable material on the page Test Steps: 1. Content author does not change any content on the page 2. Content author shares the page with Site admin and assigns the role of peer for peer review 3. Content author notify site admin stuff has been changed 4. Site admin logs in and browses to the page with objectionable material Actual result: The site admin only sees headings on the page and cannot see the actual page content Expected result: Site admin should be able to see all page content even if they are assigned the role of peer for peer review or site admins should not be in the list of users that can do peer reviews To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1798203/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826484] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/9872 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826484 Title: Remove the hove underline from Elasticsearch tabs Status in Mahara: In Progress Bug description: When you hover over the tabs on the Elasticsearch results list, sometimes an underline comes up moving the solid line a bit. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826484/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826484] [NEW] Remove the hove underline from Elasticsearch tabs
Public bug reported: When you hover over the tabs on the Elasticsearch results list, sometimes an underline comes up moving the solid line a bit. ** Affects: mahara Importance: Medium Status: In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826484 Title: Remove the hove underline from Elasticsearch tabs Status in Mahara: In Progress Bug description: When you hover over the tabs on the Elasticsearch results list, sometimes an underline comes up moving the solid line a bit. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826484/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826476] Re: Annotation block title doesn't pass accessibility
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826476 Title: Annotation block title doesn't pass accessibility Status in Mahara: Fix Committed Bug description: Follow-on from the Bootstrap 4 upgrade. When you place an annotation onto a page via the SmartEvidence matrix page, the title is greyed out. The background is too dark and doesn't pass contrast. The same goes for the greyed out institution name when you set up a group. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826476/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826476] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/9871 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826476 Title: Annotation block title doesn't pass accessibility Status in Mahara: In Progress Bug description: Follow-on from the Bootstrap 4 upgrade. When you place an annotation onto a page via the SmartEvidence matrix page, the title is greyed out. The background is too dark and doesn't pass contrast. The same goes for the greyed out institution name when you set up a group. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826476/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826476] [NEW] Annotation block title doesn't pass accessibility
Public bug reported: Follow-on from the Bootstrap 4 upgrade. When you place an annotation onto a page via the SmartEvidence matrix page, the title is greyed out. The background is too dark and doesn't pass contrast. The same goes for the greyed out institution name when you set up a group. ** Affects: mahara Importance: High Assignee: Evonne Cheung (evonne) Status: In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826476 Title: Annotation block title doesn't pass accessibility Status in Mahara: In Progress Bug description: Follow-on from the Bootstrap 4 upgrade. When you place an annotation onto a page via the SmartEvidence matrix page, the title is greyed out. The background is too dark and doesn't pass contrast. The same goes for the greyed out institution name when you set up a group. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826476/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826475] [NEW] Quotation mark icon in primary school theme on wall posts
Public bug reported: Wall posts in the primary school theme have a very light "quotation mark" icon halfway behind the user profile picture that should be removed. ** Affects: mahara Importance: Medium Assignee: Evonne Cheung (evonne) Status: Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826475 Title: Quotation mark icon in primary school theme on wall posts Status in Mahara: Fix Committed Bug description: Wall posts in the primary school theme have a very light "quotation mark" icon halfway behind the user profile picture that should be removed. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826475/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826475] Re: Quotation mark icon in primary school theme on wall posts
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826475 Title: Quotation mark icon in primary school theme on wall posts Status in Mahara: Fix Committed Bug description: Wall posts in the primary school theme have a very light "quotation mark" icon halfway behind the user profile picture that should be removed. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826475/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826475] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/9870 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826475 Title: Quotation mark icon in primary school theme on wall posts Status in Mahara: Fix Committed Bug description: Wall posts in the primary school theme have a very light "quotation mark" icon halfway behind the user profile picture that should be removed. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826475/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826474] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/9869 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826474 Title: langpack sync not working Status in Mahara: In Progress Status in Mahara 17.10 series: In Progress Status in Mahara 18.04 series: In Progress Status in Mahara 18.10 series: In Progress Status in Mahara 19.04 series: In Progress Bug description: Now we have a newer naming convention To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826474/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826292] Re: "Share with ..." search menu item has wrong hover color in "Modern", "Ocean" and "Primary school" themes
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826292 Title: "Share with ..." search menu item has wrong hover color in "Modern", "Ocean" and "Primary school" themes Status in Mahara: Fix Committed Bug description: Regression after upgrade to Bootstrap 4: When you are on the "Edit access" page in the "Modern", "Ocean" and "Primary school" themes, the group/friend/user search menu uses the wrong hover color (see screenshot). This may also be the case for the "Default" theme, but since it's green is similar to "Raw", I wasn't quite sure. To replicate: 1. Have 3 or more users on your site. 2. Create a page and go to "Share". 3. Select "Search for... user" and click in the "Search" box. Expected result: All users are shown and the active / hover color is the primary theme color. Actual result: The color is always green (see screenshot). The same goes for searching for a group and friend. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826292/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826474] [NEW] langpack sync not working
Public bug reported: Now we have a newer naming convention ** Affects: mahara Importance: High Assignee: Robert Lyon (robertl-9) Status: In Progress ** Affects: mahara/17.10 Importance: High Status: In Progress ** Affects: mahara/18.04 Importance: High Status: In Progress ** Affects: mahara/18.10 Importance: High Status: In Progress ** Affects: mahara/19.04 Importance: High Assignee: Robert Lyon (robertl-9) Status: In Progress ** Changed in: mahara Assignee: (unassigned) => Robert Lyon (robertl-9) ** Also affects: mahara/17.10 Importance: Undecided Status: New ** Also affects: mahara/19.04 Importance: High Assignee: Robert Lyon (robertl-9) Status: In Progress ** Also affects: mahara/18.10 Importance: Undecided Status: New ** Also affects: mahara/18.04 Importance: Undecided Status: New ** Changed in: mahara/18.10 Importance: Undecided => High ** Changed in: mahara/18.04 Importance: Undecided => High ** Changed in: mahara/17.10 Importance: Undecided => High ** Changed in: mahara/18.10 Status: New => In Progress ** Changed in: mahara/18.04 Status: New => In Progress ** Changed in: mahara/17.10 Status: New => In Progress ** Changed in: mahara/19.04 Milestone: None => 19.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826474 Title: langpack sync not working Status in Mahara: In Progress Status in Mahara 17.10 series: In Progress Status in Mahara 18.04 series: In Progress Status in Mahara 18.10 series: In Progress Status in Mahara 19.04 series: In Progress Bug description: Now we have a newer naming convention To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826474/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826292] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/9868 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826292 Title: "Share with ..." search menu item has wrong hover color in "Modern", "Ocean" and "Primary school" themes Status in Mahara: In Progress Bug description: Regression after upgrade to Bootstrap 4: When you are on the "Edit access" page in the "Modern", "Ocean" and "Primary school" themes, the group/friend/user search menu uses the wrong hover color (see screenshot). This may also be the case for the "Default" theme, but since it's green is similar to "Raw", I wasn't quite sure. To replicate: 1. Have 3 or more users on your site. 2. Create a page and go to "Share". 3. Select "Search for... user" and click in the "Search" box. Expected result: All users are shown and the active / hover color is the primary theme color. Actual result: The color is always green (see screenshot). The same goes for searching for a group and friend. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826292/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826471] Re: The warning background color should be a bit lighter for accessibility
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826471 Title: The warning background color should be a bit lighter for accessibility Status in Mahara: Fix Committed Bug description: The warning background color, e.g. the color you see when a portfolio has been submitted, is rather dark. It should be lightened a bit and the text color darkened. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826471/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826462] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/9867 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826462 Title: Unread messages shouldn't have background color Status in Mahara: Fix Committed Bug description: Follow-on from Bootstrap 4 upgrade When you have unread messages in your inbox, the background of the notifications has the primary theme color when it shouldn't be there. The text should be bold with no particular background. See https://manual.mahara.org/en/18.10/_images/inbox.png for what is expected. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826462/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826462] Re: Unread messages shouldn't have background color
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826462 Title: Unread messages shouldn't have background color Status in Mahara: Fix Committed Bug description: Follow-on from Bootstrap 4 upgrade When you have unread messages in your inbox, the background of the notifications has the primary theme color when it shouldn't be there. The text should be bold with no particular background. See https://manual.mahara.org/en/18.10/_images/inbox.png for what is expected. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826462/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826471] [NEW] The warning background color should be a bit lighter for accessibility
Public bug reported: The warning background color, e.g. the color you see when a portfolio has been submitted, is rather dark. It should be lightened a bit and the text color darkened. ** Affects: mahara Importance: High Assignee: Evonne Cheung (evonne) Status: In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826471 Title: The warning background color should be a bit lighter for accessibility Status in Mahara: In Progress Bug description: The warning background color, e.g. the color you see when a portfolio has been submitted, is rather dark. It should be lightened a bit and the text color darkened. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826471/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826471] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/9866 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826471 Title: The warning background color should be a bit lighter for accessibility Status in Mahara: In Progress Bug description: The warning background color, e.g. the color you see when a portfolio has been submitted, is rather dark. It should be lightened a bit and the text color darkened. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826471/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826462] Re: Unread messages shouldn't have background color
** Changed in: mahara Assignee: (unassigned) => Evonne Cheung (evonne) ** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826462 Title: Unread messages shouldn't have background color Status in Mahara: In Progress Bug description: Follow-on from Bootstrap 4 upgrade When you have unread messages in your inbox, the background of the notifications has the primary theme color when it shouldn't be there. The text should be bold with no particular background. See https://manual.mahara.org/en/18.10/_images/inbox.png for what is expected. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826462/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826292] Re: "Share with ..." search menu item has wrong hover color in "Modern", "Ocean" and "Primary school" themes
** Changed in: mahara Assignee: (unassigned) => Evonne Cheung (evonne) ** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826292 Title: "Share with ..." search menu item has wrong hover color in "Modern", "Ocean" and "Primary school" themes Status in Mahara: In Progress Bug description: Regression after upgrade to Bootstrap 4: When you are on the "Edit access" page in the "Modern", "Ocean" and "Primary school" themes, the group/friend/user search menu uses the wrong hover color (see screenshot). This may also be the case for the "Default" theme, but since it's green is similar to "Raw", I wasn't quite sure. To replicate: 1. Have 3 or more users on your site. 2. Create a page and go to "Share". 3. Select "Search for... user" and click in the "Search" box. Expected result: All users are shown and the active / hover color is the primary theme color. Actual result: The color is always green (see screenshot). The same goes for searching for a group and friend. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826292/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1825687] A change has been merged
Reviewed: https://reviews.mahara.org/9865 Committed: https://git.mahara.org/mahara/mahara/commit/7d585e15b5701a37c8af0414b858007edb1aa763 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:19.04_STABLE commit 7d585e15b5701a37c8af0414b858007edb1aa763 Author: Rebecca Blundell Date: Wed Apr 24 14:52:50 2019 +1200 Bug 1825687: Objectionable material reported option doesn't align Change padding for "Objectionable material reported" (class nolink) to be the same as other options in the "More options" menu on a page change flag icon from green to red for the owner of a page reported as objectionable. behatnotneeded Change-Id: I3e5a56e964eef1191d7ccf4ee5bbd68f87fa (cherry picked from commit 0521bf53c876fba6a5e8890a43b43860541eca29) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1825687 Title: "Objectionable material reported" option doesn't align in the menu Status in Mahara: Fix Committed Bug description: Follow-on from Bootstrap upgrade. When a page was reported as objectionable and the "More options" menu is opened, the icon and text "Objectionable material reported" don't align with the rest of the text (see screenshot). It should look like https://manual.mahara.org/en/18.10/_images/3_dots_expanded.png To replicate: 1. Create user A and user B. 2. User A creates a page. 3. User B marks the page as objectionable. 4. User B looks at the options in the "More options" menu via the "3 dots" button when viewing the page. Expected result: All options are aligned on the left with the icons below each other. Actual result: The "Objectionable material reported" option doesn't align. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1825687/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1825687] A change has been merged
Reviewed: https://reviews.mahara.org/9845 Committed: https://git.mahara.org/mahara/mahara/commit/0521bf53c876fba6a5e8890a43b43860541eca29 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 0521bf53c876fba6a5e8890a43b43860541eca29 Author: Rebecca Blundell Date: Wed Apr 24 14:52:50 2019 +1200 Bug 1825687: Objectionable material reported option doesn't align Change padding for "Objectionable material reported" (class nolink) to be the same as other options in the "More options" menu on a page change flag icon from green to red for the owner of a page reported as objectionable. behatnotneeded Change-Id: I3e5a56e964eef1191d7ccf4ee5bbd68f87fa -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1825687 Title: "Objectionable material reported" option doesn't align in the menu Status in Mahara: Fix Committed Bug description: Follow-on from Bootstrap upgrade. When a page was reported as objectionable and the "More options" menu is opened, the icon and text "Objectionable material reported" don't align with the rest of the text (see screenshot). It should look like https://manual.mahara.org/en/18.10/_images/3_dots_expanded.png To replicate: 1. Create user A and user B. 2. User A creates a page. 3. User B marks the page as objectionable. 4. User B looks at the options in the "More options" menu via the "3 dots" button when viewing the page. Expected result: All options are aligned on the left with the icons below each other. Actual result: The "Objectionable material reported" option doesn't align. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1825687/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1825687] A patch has been submitted for review
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9865 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1825687 Title: "Objectionable material reported" option doesn't align in the menu Status in Mahara: Fix Committed Bug description: Follow-on from Bootstrap upgrade. When a page was reported as objectionable and the "More options" menu is opened, the icon and text "Objectionable material reported" don't align with the rest of the text (see screenshot). It should look like https://manual.mahara.org/en/18.10/_images/3_dots_expanded.png To replicate: 1. Create user A and user B. 2. User A creates a page. 3. User B marks the page as objectionable. 4. User B looks at the options in the "More options" menu via the "3 dots" button when viewing the page. Expected result: All options are aligned on the left with the icons below each other. Actual result: The "Objectionable material reported" option doesn't align. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1825687/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1825687] Re: "Objectionable material reported" option doesn't align in the menu
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1825687 Title: "Objectionable material reported" option doesn't align in the menu Status in Mahara: Fix Committed Bug description: Follow-on from Bootstrap upgrade. When a page was reported as objectionable and the "More options" menu is opened, the icon and text "Objectionable material reported" don't align with the rest of the text (see screenshot). It should look like https://manual.mahara.org/en/18.10/_images/3_dots_expanded.png To replicate: 1. Create user A and user B. 2. User A creates a page. 3. User B marks the page as objectionable. 4. User B looks at the options in the "More options" menu via the "3 dots" button when viewing the page. Expected result: All options are aligned on the left with the icons below each other. Actual result: The "Objectionable material reported" option doesn't align. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1825687/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826462] Re: Unread messages shouldn't have background color
Screenshot is from the Default theme. Should be checked in other themes as well ** Attachment added: "notifications.png" https://bugs.launchpad.net/mahara/+bug/1826462/+attachment/5259115/+files/notifications.png -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826462 Title: Unread messages shouldn't have background color Status in Mahara: Confirmed Bug description: Follow-on from Bootstrap 4 upgrade When you have unread messages in your inbox, the background of the notifications has the primary theme color when it shouldn't be there. The text should be bold with no particular background. See https://manual.mahara.org/en/18.10/_images/inbox.png for what is expected. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826462/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826462] [NEW] Unread messages shouldn't have background color
Public bug reported: Follow-on from Bootstrap 4 upgrade When you have unread messages in your inbox, the background of the notifications has the primary theme color when it shouldn't be there. The text should be bold with no particular background. See https://manual.mahara.org/en/18.10/_images/inbox.png for what is expected. ** Affects: mahara Importance: High Status: Confirmed ** Tags: regression -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826462 Title: Unread messages shouldn't have background color Status in Mahara: Confirmed Bug description: Follow-on from Bootstrap 4 upgrade When you have unread messages in your inbox, the background of the notifications has the primary theme color when it shouldn't be there. The text should be bold with no particular background. See https://manual.mahara.org/en/18.10/_images/inbox.png for what is expected. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826462/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1759054] Re: datepicker not accessible by screen reader
** Changed in: mahara Milestone: 19.04.0 => 19.10.0 ** Also affects: mahara/19.04 Importance: Medium Assignee: Liam (liam-sharpe) Status: Incomplete ** Also affects: mahara/19.10 Importance: Undecided Status: New ** Changed in: mahara/19.10 Milestone: None => 19.10.0 ** Changed in: mahara/19.04 Milestone: 19.10.0 => 19.04.1 ** Changed in: mahara/19.10 Importance: Undecided => Medium ** Changed in: mahara/19.10 Status: New => Confirmed ** Changed in: mahara/19.04 Status: Incomplete => Confirmed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1759054 Title: datepicker not accessible by screen reader Status in Mahara: Confirmed Status in Mahara 19.04 series: Confirmed Status in Mahara 19.10 series: Confirmed Bug description: There are still a few issues that make datepicker not accessible: - when the datepicker field receives focus, the screen reader doesn't see the datepicker form has been displayed - when on the datepicker we press 'H' it changes to the timepicker form, but the screen reader doesn't see there has been a change - the text with instructions on how to change the time (hours or minutes) is not read by the sr - it doesn't say how to come back from the timepicker mode reported by Julius To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1759054/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1800421] A patch has been submitted for review
Patch for "18.10_STABLE" branch: https://reviews.mahara.org/9864 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1800421 Title: Page and peer instructions are not exported properly in HTML and Leap2A Status in Mahara: Fix Committed Status in Mahara 18.10 series: Fix Committed Status in Mahara 19.04 series: Fix Committed Bug description: When a portfolio is exported that has page instructions, they do not appear in the HTML or Leap2A export. Since they are part of the portfolio, they should be exported. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1800421/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1803101] Re: Error importing Leap2A w/ peer assessment
** Changed in: mahara/19.04
Milestone: 19.04.0 => 19.04.1
** Changed in: mahara/18.10
Milestone: 18.10.1 => 18.10.2
** Also affects: mahara/19.10
Importance: Undecided
Status: New
** Changed in: mahara/19.10
Milestone: None => 19.10.0
** Changed in: mahara/19.10
Status: New => In Progress
** Changed in: mahara/19.10
Importance: Undecided => High
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1803101
Title:
Error importing Leap2A w/ peer assessment
Status in Mahara:
In Progress
Status in Mahara 18.10 series:
Confirmed
Status in Mahara 19.04 series:
In Progress
Status in Mahara 19.10 series:
In Progress
Bug description:
I exported a simple portfolio page as Leap2A and got the error
messages below when importing it via the admin interface. The Leap2A
file is attached.
[WAR] 37 (lib/adodb/adodb-exceptions.inc.php:45) Array to string conversion
Call stack (most recent first):
log_message("Array to string conversion", 8, true, true,
"/home/kristina/code/mahara/htdocs/lib/adodb/adodb-...", 45) at
/home/kristina/code/mahara/htdocs/lib/errors.php:520
error(8, "Array to string conversion",
"/home/kristina/code/mahara/htdocs/lib/adodb/adodb-...", 45, array(size 7)) at
/home/kristina/code/mahara/htdocs/lib/adodb/adodb-exceptions.inc.php:45
ADODB_Exception->__construct("postgres8", "adodb_throw", -1, "ERROR: null
value in column "block" violates not-...", "INSERT INTO
"artefact_peer_assessment" ("assessmen...", array(size 3),
object(ADODB_postgres8)) at
/home/kristina/code/mahara/htdocs/lib/adodb/adodb-exceptions.inc.php:80
adodb_throw("postgres8", "adodb_throw", -1, "ERROR: null value in column
"block" violates not-...", "INSERT INTO "artefact_peer_assessment"
("assessmen...", array(size 3), object(ADODB_postgres8)) at
/home/kristina/code/mahara/htdocs/lib/adodb/adodb.inc.php:313
ADODB_TransMonitor("postgres8", "adodb_throw", -1, "ERROR: null value in
column "block" violates not-...", "INSERT INTO "artefact_peer_assessment"
("assessmen...", array(size 3), object(ADODB_postgres8)) at
/home/kristina/code/mahara/htdocs/lib/adodb/adodb.inc.php:1263
ADOConnection->_Execute("INSERT INTO "artefact_peer_assessment"
("assessmen...", array(size 3)) at
/home/kristina/code/mahara/htdocs/lib/adodb/adodb.inc.php:1223
ADOConnection->Execute("INSERT INTO "artefact_peer_assessment"
("assessmen...", array(size 3)) at
/home/kristina/code/mahara/htdocs/lib/dml.php:1102
insert_record("artefact_peer_assessment", object(stdClass)) at
/home/kristina/code/mahara/htdocs/artefact/peerassessment/lib.php:240
ArtefactTypePeerassessment->commit() at
/home/kristina/code/mahara/htdocs/artefact/peerassessment/import/leap/lib.php:180
LeapImportPeerassessment::import_using_strategy(object(SimpleXMLElement),
object(PluginImportLeap), 1, array(size 0)) at
/home/kristina/code/mahara/htdocs/lib/mahara.php:1813
call_static_method("LeapImportPeerassessment", "import_using_strategy",
object(SimpleXMLElement), object(PluginImportLeap), 1, array(size 0)) at
/home/kristina/code/mahara/htdocs/import/leap/lib.php:665
PluginImportLeap->import_from_load_mapping() at
/home/kristina/code/mahara/htdocs/import/leap/lib.php:188
PluginImportLeap->process() at
/home/kristina/code/mahara/htdocs/admin/users/add.php:348
adduser_submit(object(Pieform), array(size 24)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:542
Pieform->__construct(array(size 8)) at
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:164
Pieform::process(array(size 8)) at
/home/kristina/code/mahara/htdocs/lib/mahara.php:5258
pieform(array(size 8)) at
/home/kristina/code/mahara/htdocs/admin/users/add.php:156
[WAR] 37 (lib/errors.php:858) Failed to get a recordset: postgres8 error:
[-1: ERROR: null value in column "block" violates not-null constraint
DETAIL: Failing row contains (22, null, null, 11, 0).] in adodb_throw(INSERT
INTO "artefact_peer_assessment" ("assessment", "view", "private") VALUES (?, ?,
?), Array)Command was: INSERT INTO "artefact_peer_assessment" ("assessment",
"view", "private") VALUES (?, ?, ?) and values was
(assessment:22,view:11,private:0)
Call stack (most recent first):
log_message("Failed to get a recordset: postgres8 error: [-1: E...", 8,
true, true) at /home/kristina/code/mahara/htdocs/lib/errors.php:95
log_warn("Failed to get a recordset: postgres8 error: [-1: E...") at
/home/kristina/code/mahara/htdocs/lib/errors.php:858
SQLException->__construct("Failed to get a recordset: postgres8 error:
[-1: E...") at /home/kristina/code/mahara/htdocs/lib/dml.php:1105
[Mahara-contributors] [Bug 1825686] Re: Content chooser has different icon and text sizes
** Also affects: mahara/19.04 Importance: Medium Assignee: Liam (liam-sharpe) Status: In Progress ** Also affects: mahara/19.10 Importance: Undecided Status: New ** Changed in: mahara/19.04 Milestone: 19.04.0 => 19.04.1 ** Changed in: mahara/19.10 Milestone: None => 19.10.0 ** Changed in: mahara/19.10 Status: New => In Progress ** Changed in: mahara/19.10 Importance: Undecided => Medium -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1825686 Title: Content chooser has different icon and text sizes Status in Mahara: In Progress Status in Mahara 19.04 series: In Progress Status in Mahara 19.10 series: In Progress Bug description: Follow-on from the Bootstrap upgrade. When the content chooser on the page edit screen is displayed in tablet mode, the icon and text size is reduced though it shouldn't be. Additionally, when you are in icon-only mode, the fields in the sub menu do not extend all the way to the side. See the 18.10 screenshot for comparison to the 19.04 one. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1825686/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1798203] A change has been merged
Reviewed: https://reviews.mahara.org/9862 Committed: https://git.mahara.org/mahara/mahara/commit/e535179c3ea3bce35316f2eba5137b1822a3f568 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:19.04_STABLE commit e535179c3ea3bce35316f2eba5137b1822a3f568 Author: Kevin Dibble Date: Mon Mar 25 16:48:28 2019 +1300 bug 1798203: Peer review prevents viewing objectionable content Updated view to allow the user admin to view content if it has reported objectionable content. behatnotneeded Change-Id: I277902b5a6121c5daaa6f692dcc391e9ef99caf8 (cherry picked from commit 39d4428671c8292bb2c3335d869278753608ef58) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1798203 Title: Peer review role prevents site / institution admin from seeing all content on page during objectionable review Status in Mahara: Fix Committed Status in Mahara 18.10 series: In Progress Status in Mahara 19.04 series: Fix Committed Bug description: Bug Summary: Content author has a public portfolio page -> Another user reports objectionable material = author sees warning on page -> does not edit page but adds the site admin as a peer reviewer -> who can not see the page details but only the headings --- Environment tested: Master Browser tested: Chrome Preconditions: 1. Content author creates a portfolio page 2. Another site user reports objectionable material on the page Test Steps: 1. Content author does not change any content on the page 2. Content author shares the page with Site admin and assigns the role of peer for peer review 3. Content author notify site admin stuff has been changed 4. Site admin logs in and browses to the page with objectionable material Actual result: The site admin only sees headings on the page and cannot see the actual page content Expected result: Site admin should be able to see all page content even if they are assigned the role of peer for peer review or site admins should not be in the list of users that can do peer reviews To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1798203/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1798203] A patch has been submitted for review
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9862 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1798203 Title: Peer review role prevents site / institution admin from seeing all content on page during objectionable review Status in Mahara: Fix Committed Status in Mahara 18.10 series: In Progress Status in Mahara 19.04 series: Fix Committed Bug description: Bug Summary: Content author has a public portfolio page -> Another user reports objectionable material = author sees warning on page -> does not edit page but adds the site admin as a peer reviewer -> who can not see the page details but only the headings --- Environment tested: Master Browser tested: Chrome Preconditions: 1. Content author creates a portfolio page 2. Another site user reports objectionable material on the page Test Steps: 1. Content author does not change any content on the page 2. Content author shares the page with Site admin and assigns the role of peer for peer review 3. Content author notify site admin stuff has been changed 4. Site admin logs in and browses to the page with objectionable material Actual result: The site admin only sees headings on the page and cannot see the actual page content Expected result: Site admin should be able to see all page content even if they are assigned the role of peer for peer review or site admins should not be in the list of users that can do peer reviews To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1798203/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1798203] Re: Peer review role prevents site / institution admin from seeing all content on page during objectionable review
** Changed in: mahara/19.04 Milestone: None => 19.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1798203 Title: Peer review role prevents site / institution admin from seeing all content on page during objectionable review Status in Mahara: Fix Committed Status in Mahara 18.10 series: In Progress Status in Mahara 19.04 series: Fix Committed Bug description: Bug Summary: Content author has a public portfolio page -> Another user reports objectionable material = author sees warning on page -> does not edit page but adds the site admin as a peer reviewer -> who can not see the page details but only the headings --- Environment tested: Master Browser tested: Chrome Preconditions: 1. Content author creates a portfolio page 2. Another site user reports objectionable material on the page Test Steps: 1. Content author does not change any content on the page 2. Content author shares the page with Site admin and assigns the role of peer for peer review 3. Content author notify site admin stuff has been changed 4. Site admin logs in and browses to the page with objectionable material Actual result: The site admin only sees headings on the page and cannot see the actual page content Expected result: Site admin should be able to see all page content even if they are assigned the role of peer for peer review or site admins should not be in the list of users that can do peer reviews To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1798203/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1798203] A patch has been submitted for review
Patch for "18.10_STABLE" branch: https://reviews.mahara.org/9863 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1798203 Title: Peer review role prevents site / institution admin from seeing all content on page during objectionable review Status in Mahara: Fix Committed Status in Mahara 18.10 series: In Progress Status in Mahara 19.04 series: Fix Committed Bug description: Bug Summary: Content author has a public portfolio page -> Another user reports objectionable material = author sees warning on page -> does not edit page but adds the site admin as a peer reviewer -> who can not see the page details but only the headings --- Environment tested: Master Browser tested: Chrome Preconditions: 1. Content author creates a portfolio page 2. Another site user reports objectionable material on the page Test Steps: 1. Content author does not change any content on the page 2. Content author shares the page with Site admin and assigns the role of peer for peer review 3. Content author notify site admin stuff has been changed 4. Site admin logs in and browses to the page with objectionable material Actual result: The site admin only sees headings on the page and cannot see the actual page content Expected result: Site admin should be able to see all page content even if they are assigned the role of peer for peer review or site admins should not be in the list of users that can do peer reviews To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1798203/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1798203] Re: Peer review role prevents site / institution admin from seeing all content on page during objectionable review
** Also affects: mahara/18.10 Importance: Undecided Status: New ** Changed in: mahara/19.04 Status: In Progress => Fix Committed ** Changed in: mahara/18.10 Status: New => In Progress ** Changed in: mahara/18.10 Importance: Undecided => Medium ** Changed in: mahara/18.10 Milestone: None => 18.10.1 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1798203 Title: Peer review role prevents site / institution admin from seeing all content on page during objectionable review Status in Mahara: Fix Committed Status in Mahara 18.10 series: In Progress Status in Mahara 19.04 series: Fix Committed Bug description: Bug Summary: Content author has a public portfolio page -> Another user reports objectionable material = author sees warning on page -> does not edit page but adds the site admin as a peer reviewer -> who can not see the page details but only the headings --- Environment tested: Master Browser tested: Chrome Preconditions: 1. Content author creates a portfolio page 2. Another site user reports objectionable material on the page Test Steps: 1. Content author does not change any content on the page 2. Content author shares the page with Site admin and assigns the role of peer for peer review 3. Content author notify site admin stuff has been changed 4. Site admin logs in and browses to the page with objectionable material Actual result: The site admin only sees headings on the page and cannot see the actual page content Expected result: Site admin should be able to see all page content even if they are assigned the role of peer for peer review or site admins should not be in the list of users that can do peer reviews To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1798203/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1798203] A change has been merged
Reviewed: https://reviews.mahara.org/9656 Committed: https://git.mahara.org/mahara/mahara/commit/39d4428671c8292bb2c3335d869278753608ef58 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 39d4428671c8292bb2c3335d869278753608ef58 Author: Kevin Dibble Date: Mon Mar 25 16:48:28 2019 +1300 bug 1798203: Peer review prevents viewing objectionable content Updated view to allow the user admin to view content if it has reported objectionable content. behatnotneeded Change-Id: I277902b5a6121c5daaa6f692dcc391e9ef99caf8 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1798203 Title: Peer review role prevents site / institution admin from seeing all content on page during objectionable review Status in Mahara: Fix Committed Status in Mahara 18.10 series: In Progress Status in Mahara 19.04 series: Fix Committed Bug description: Bug Summary: Content author has a public portfolio page -> Another user reports objectionable material = author sees warning on page -> does not edit page but adds the site admin as a peer reviewer -> who can not see the page details but only the headings --- Environment tested: Master Browser tested: Chrome Preconditions: 1. Content author creates a portfolio page 2. Another site user reports objectionable material on the page Test Steps: 1. Content author does not change any content on the page 2. Content author shares the page with Site admin and assigns the role of peer for peer review 3. Content author notify site admin stuff has been changed 4. Site admin logs in and browses to the page with objectionable material Actual result: The site admin only sees headings on the page and cannot see the actual page content Expected result: Site admin should be able to see all page content even if they are assigned the role of peer for peer review or site admins should not be in the list of users that can do peer reviews To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1798203/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1825683] A change has been merged
Reviewed: https://reviews.mahara.org/9861 Committed: https://git.mahara.org/mahara/mahara/commit/89f99faccba9a4be15a481b7c8902d712f9fbdb1 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:19.04_STABLE commit 89f99faccba9a4be15a481b7c8902d712f9fbdb1 Author: Doris Tam Date: Tue Apr 23 10:52:07 2019 +1200 Bug 1825683: removal of border around wallposts to match the pre- existing layout additional: - removal of box shadow around wallposts on all themes - consistent colour card for private posts on all themes behatnotneeded Change-Id: I1dac9373f12f60bc82c4d93b24cf336aaa11f625 (cherry picked from commit a641ccd517dfa52e350f501549518fe17d1af981) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1825683 Title: Lines around wall post shouldn't be there Status in Mahara: Fix Committed Bug description: Follow-on from the Bootstrap upgrade Wall posts have lines around them making them look very boxy. These lines shouldn't be there. The posts should look like in Mahara 18.10 (see screenshot). To replicate: 1. Create user A and user B. 2. User A leaves messages on the wall of user B on her profile page. Expected result: The messages look like in Mahara 18.10 with minimal lines. Actual result: There is an outline around each message. Also click "View whole wall". The lines should disappear there as well. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1825683/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1825683] A patch has been submitted for review
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9861 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1825683 Title: Lines around wall post shouldn't be there Status in Mahara: Fix Committed Bug description: Follow-on from the Bootstrap upgrade Wall posts have lines around them making them look very boxy. These lines shouldn't be there. The posts should look like in Mahara 18.10 (see screenshot). To replicate: 1. Create user A and user B. 2. User A leaves messages on the wall of user B on her profile page. Expected result: The messages look like in Mahara 18.10 with minimal lines. Actual result: There is an outline around each message. Also click "View whole wall". The lines should disappear there as well. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1825683/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1825683] A change has been merged
Reviewed: https://reviews.mahara.org/9817 Committed: https://git.mahara.org/mahara/mahara/commit/a641ccd517dfa52e350f501549518fe17d1af981 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit a641ccd517dfa52e350f501549518fe17d1af981 Author: Doris Tam Date: Tue Apr 23 10:52:07 2019 +1200 Bug 1825683: removal of border around wallposts to match the pre- existing layout additional: - removal of box shadow around wallposts on all themes - consistent colour card for private posts on all themes behatnotneeded Change-Id: I1dac9373f12f60bc82c4d93b24cf336aaa11f625 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1825683 Title: Lines around wall post shouldn't be there Status in Mahara: Fix Committed Bug description: Follow-on from the Bootstrap upgrade Wall posts have lines around them making them look very boxy. These lines shouldn't be there. The posts should look like in Mahara 18.10 (see screenshot). To replicate: 1. Create user A and user B. 2. User A leaves messages on the wall of user B on her profile page. Expected result: The messages look like in Mahara 18.10 with minimal lines. Actual result: There is an outline around each message. Also click "View whole wall". The lines should disappear there as well. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1825683/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1825683] Re: Lines around wall post shouldn't be there
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1825683 Title: Lines around wall post shouldn't be there Status in Mahara: Fix Committed Bug description: Follow-on from the Bootstrap upgrade Wall posts have lines around them making them look very boxy. These lines shouldn't be there. The posts should look like in Mahara 18.10 (see screenshot). To replicate: 1. Create user A and user B. 2. User A leaves messages on the wall of user B on her profile page. Expected result: The messages look like in Mahara 18.10 with minimal lines. Actual result: There is an outline around each message. Also click "View whole wall". The lines should disappear there as well. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1825683/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1825599] A change has been merged
Reviewed: https://reviews.mahara.org/9814 Committed: https://git.mahara.org/mahara/mahara/commit/66a6ede8392e942e88141622fe5f422f19057249 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 66a6ede8392e942e88141622fe5f422f19057249 Author: Robert Lyon Date: Sun Apr 21 11:59:06 2019 +1200 Bug 1825599: Adding the pagination link styles via PHP We used to add them via js but some pagination instances do not use json update and so were not getting styled behatnotneeded Change-Id: Ibc225c34a730c8b14ea35a529ad4d350aa33fd56 Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1825599 Title: Paginator is missing styling in forum topic Status in Mahara: Fix Committed Bug description: When you are in a forum topic, the paginator does not display the correct styling (see screenshot) when there are 11+ forum posts in a forum topic. To replicate: 1. Create a group. 2. Create a topic in a forum with 10 replies to the topic so that the paginator at the bottom is displayed. Expected result: The paginator looks like it does everywhere. Actual result: Only the text is shown, but not the outline around it and the appropriate spacing. This should be checked in all themes to ensure the paginator is displayed correctly. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1825599/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1825599] Re: Paginator is missing styling in forum topic
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1825599 Title: Paginator is missing styling in forum topic Status in Mahara: Fix Committed Bug description: When you are in a forum topic, the paginator does not display the correct styling (see screenshot) when there are 11+ forum posts in a forum topic. To replicate: 1. Create a group. 2. Create a topic in a forum with 10 replies to the topic so that the paginator at the bottom is displayed. Expected result: The paginator looks like it does everywhere. Actual result: Only the text is shown, but not the outline around it and the appropriate spacing. This should be checked in all themes to ensure the paginator is displayed correctly. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1825599/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1825599] A patch has been submitted for review
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9860 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1825599 Title: Paginator is missing styling in forum topic Status in Mahara: Fix Committed Bug description: When you are in a forum topic, the paginator does not display the correct styling (see screenshot) when there are 11+ forum posts in a forum topic. To replicate: 1. Create a group. 2. Create a topic in a forum with 10 replies to the topic so that the paginator at the bottom is displayed. Expected result: The paginator looks like it does everywhere. Actual result: Only the text is shown, but not the outline around it and the appropriate spacing. This should be checked in all themes to ensure the paginator is displayed correctly. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1825599/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826285] A change has been merged
Reviewed: https://reviews.mahara.org/9841 Committed: https://git.mahara.org/mahara/mahara/commit/85c00edf0f2757a7b314e54f2a144fd237c5bee2 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 85c00edf0f2757a7b314e54f2a144fd237c5bee2 Author: Liam Date: Wed Apr 24 14:00:31 2019 +1200 Bug 1826285: Remove the focus color on inputs in the "Modern" theme behatnotneeded Change-Id: I701ea58238a8ac4789b55101c81f92dfcc30003a -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826285 Title: Modern theme has input focus color Status in Mahara: Fix Committed Bug description: The modern theme is the only theme with an input focus color background that makes it hard to read the text. This is to be removed. 1. Log in as a user and have the modern theme. 2. Place your cursor into the "Search user" box. Expected result: The background doesn't change. Actual result: A neon blue background is displayed. Patch at https://reviews.mahara.org/#/c/9841/ To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826285/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826285] A patch has been submitted for review
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9859 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826285 Title: Modern theme has input focus color Status in Mahara: Fix Committed Bug description: The modern theme is the only theme with an input focus color background that makes it hard to read the text. This is to be removed. 1. Log in as a user and have the modern theme. 2. Place your cursor into the "Search user" box. Expected result: The background doesn't change. Actual result: A neon blue background is displayed. Patch at https://reviews.mahara.org/#/c/9841/ To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826285/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826285] Re: Modern theme has input focus color
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826285 Title: Modern theme has input focus color Status in Mahara: Fix Committed Bug description: The modern theme is the only theme with an input focus color background that makes it hard to read the text. This is to be removed. 1. Log in as a user and have the modern theme. 2. Place your cursor into the "Search user" box. Expected result: The background doesn't change. Actual result: A neon blue background is displayed. Patch at https://reviews.mahara.org/#/c/9841/ To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826285/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1825599] A change has been merged
Reviewed: https://reviews.mahara.org/9860 Committed: https://git.mahara.org/mahara/mahara/commit/728abce996e056d6705a56ab6c777c57dff749d1 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:19.04_STABLE commit 728abce996e056d6705a56ab6c777c57dff749d1 Author: Robert Lyon Date: Sun Apr 21 11:59:06 2019 +1200 Bug 1825599: Adding the pagination link styles via PHP We used to add them via js but some pagination instances do not use json update and so were not getting styled behatnotneeded Change-Id: Ibc225c34a730c8b14ea35a529ad4d350aa33fd56 Signed-off-by: Robert Lyon (cherry picked from commit 66a6ede8392e942e88141622fe5f422f19057249) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1825599 Title: Paginator is missing styling in forum topic Status in Mahara: Fix Committed Bug description: When you are in a forum topic, the paginator does not display the correct styling (see screenshot) when there are 11+ forum posts in a forum topic. To replicate: 1. Create a group. 2. Create a topic in a forum with 10 replies to the topic so that the paginator at the bottom is displayed. Expected result: The paginator looks like it does everywhere. Actual result: Only the text is shown, but not the outline around it and the appropriate spacing. This should be checked in all themes to ensure the paginator is displayed correctly. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1825599/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1826285] A change has been merged
Reviewed: https://reviews.mahara.org/9859 Committed: https://git.mahara.org/mahara/mahara/commit/60025a0508696fdda630096cb21af6fffddc2784 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:19.04_STABLE commit 60025a0508696fdda630096cb21af6fffddc2784 Author: Liam Date: Wed Apr 24 14:00:31 2019 +1200 Bug 1826285: Remove the focus color on inputs in the "Modern" theme behatnotneeded Change-Id: I701ea58238a8ac4789b55101c81f92dfcc30003a (cherry picked from commit 85c00edf0f2757a7b314e54f2a144fd237c5bee2) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1826285 Title: Modern theme has input focus color Status in Mahara: Fix Committed Bug description: The modern theme is the only theme with an input focus color background that makes it hard to read the text. This is to be removed. 1. Log in as a user and have the modern theme. 2. Place your cursor into the "Search user" box. Expected result: The background doesn't change. Actual result: A neon blue background is displayed. Patch at https://reviews.mahara.org/#/c/9841/ To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1826285/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1825684] A change has been merged
Reviewed: https://reviews.mahara.org/9843 Committed: https://git.mahara.org/mahara/mahara/commit/67bf6341b1dfd7f7a93d0b44570afe6e8dbc9a06 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 67bf6341b1dfd7f7a93d0b44570afe6e8dbc9a06 Author: Liam Date: Wed Apr 24 14:30:13 2019 +1200 Bug #1825684: Active page in collection navigation needs to stand out more behatnotneeded Change-Id: Ica2ce36505958906e004e51bffa06affdfd8e59d -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1825684 Title: Active page in collection navigation needs to stand out more Status in Mahara: Fix Committed Bug description: Follow-on from Bootstrap upgrade When the collection navigation is used, the active page needs to stand out more, i.e. have the background displayed in the primary color like in 18.10 (see https://manual.mahara.org/en/18.10/_images/collection_result.png ). The current look in 19.04 is attached. To replicate: 1. Create a collection with 3 pages. 2. View the collection and click the collection drop-down menu. Expected result: The active page stands out with the primary color as background color and an appropriate text color. Actual result: The active page has the link color and can hardly be distinguished from the other pages. This needs to be checked in all themes. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1825684/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1825684] A change has been merged
Reviewed: https://reviews.mahara.org/9858 Committed: https://git.mahara.org/mahara/mahara/commit/f043d21829feb5bdb33b1c9448f48ec0058751ce Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:19.04_STABLE commit f043d21829feb5bdb33b1c9448f48ec0058751ce Author: Liam Date: Wed Apr 24 14:30:13 2019 +1200 Bug #1825684: Active page in collection navigation needs to stand out more behatnotneeded Change-Id: Ica2ce36505958906e004e51bffa06affdfd8e59d (cherry picked from commit 67bf6341b1dfd7f7a93d0b44570afe6e8dbc9a06) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1825684 Title: Active page in collection navigation needs to stand out more Status in Mahara: Fix Committed Bug description: Follow-on from Bootstrap upgrade When the collection navigation is used, the active page needs to stand out more, i.e. have the background displayed in the primary color like in 18.10 (see https://manual.mahara.org/en/18.10/_images/collection_result.png ). The current look in 19.04 is attached. To replicate: 1. Create a collection with 3 pages. 2. View the collection and click the collection drop-down menu. Expected result: The active page stands out with the primary color as background color and an appropriate text color. Actual result: The active page has the link color and can hardly be distinguished from the other pages. This needs to be checked in all themes. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1825684/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1825684] A patch has been submitted for review
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9858 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1825684 Title: Active page in collection navigation needs to stand out more Status in Mahara: Fix Committed Bug description: Follow-on from Bootstrap upgrade When the collection navigation is used, the active page needs to stand out more, i.e. have the background displayed in the primary color like in 18.10 (see https://manual.mahara.org/en/18.10/_images/collection_result.png ). The current look in 19.04 is attached. To replicate: 1. Create a collection with 3 pages. 2. View the collection and click the collection drop-down menu. Expected result: The active page stands out with the primary color as background color and an appropriate text color. Actual result: The active page has the link color and can hardly be distinguished from the other pages. This needs to be checked in all themes. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1825684/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1825684] Re: Active page in collection navigation needs to stand out more
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1825684 Title: Active page in collection navigation needs to stand out more Status in Mahara: Fix Committed Bug description: Follow-on from Bootstrap upgrade When the collection navigation is used, the active page needs to stand out more, i.e. have the background displayed in the primary color like in 18.10 (see https://manual.mahara.org/en/18.10/_images/collection_result.png ). The current look in 19.04 is attached. To replicate: 1. Create a collection with 3 pages. 2. View the collection and click the collection drop-down menu. Expected result: The active page stands out with the primary color as background color and an appropriate text color. Actual result: The active page has the link color and can hardly be distinguished from the other pages. This needs to be checked in all themes. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1825684/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1824054] A change has been merged
Reviewed: https://reviews.mahara.org/9790 Committed: https://git.mahara.org/mahara/mahara/commit/84fb194f47c83b74ef550deff7452ecdd46bf6db Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 84fb194f47c83b74ef550deff7452ecdd46bf6db Author: Liam Date: Wed Apr 17 12:16:04 2019 +1200 Bug #1824054: Removed access keys because they werent very helpful behatnotneeded Change-Id: I2952ae246a98ed91672cea9e1b47fc39b3e7cd7f -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1824054 Title: Pointless access keys used in the menus Status in Mahara: Fix Committed Bug description: Access keys are used to quickly jump around different pages using keyboard shortcuts (Alt+Shift+ on firefox). Since the navigation has changed a lot int he last few versions of Mahara, a lot of these access keys are now outdated and in some cases, obsolete. Access keys that control buttons that open and close submenus arent needed any longer as they dont actually link to any other pages. Only the ones like 'D' for Dashboard should stay as these link to other pages. The access key changes will also need to be updated in the user manual: c: content - No longer exists p: portfolio - now called pages and collections there are no longer separate admin and regular access keys as both menus are visible at all times To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1824054/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1824054] A patch has been submitted for review
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9857 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1824054 Title: Pointless access keys used in the menus Status in Mahara: Fix Committed Bug description: Access keys are used to quickly jump around different pages using keyboard shortcuts (Alt+Shift+ on firefox). Since the navigation has changed a lot int he last few versions of Mahara, a lot of these access keys are now outdated and in some cases, obsolete. Access keys that control buttons that open and close submenus arent needed any longer as they dont actually link to any other pages. Only the ones like 'D' for Dashboard should stay as these link to other pages. The access key changes will also need to be updated in the user manual: c: content - No longer exists p: portfolio - now called pages and collections there are no longer separate admin and regular access keys as both menus are visible at all times To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1824054/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1824054] A change has been merged
Reviewed: https://reviews.mahara.org/9857 Committed: https://git.mahara.org/mahara/mahara/commit/bfb9a2638f1303681e407de336aace7d34fe060e Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:19.04_STABLE commit bfb9a2638f1303681e407de336aace7d34fe060e Author: Liam Date: Wed Apr 17 12:16:04 2019 +1200 Bug #1824054: Removed access keys because they werent very helpful behatnotneeded Change-Id: I2952ae246a98ed91672cea9e1b47fc39b3e7cd7f (cherry picked from commit 84fb194f47c83b74ef550deff7452ecdd46bf6db) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1824054 Title: Pointless access keys used in the menus Status in Mahara: Fix Committed Bug description: Access keys are used to quickly jump around different pages using keyboard shortcuts (Alt+Shift+ on firefox). Since the navigation has changed a lot int he last few versions of Mahara, a lot of these access keys are now outdated and in some cases, obsolete. Access keys that control buttons that open and close submenus arent needed any longer as they dont actually link to any other pages. Only the ones like 'D' for Dashboard should stay as these link to other pages. The access key changes will also need to be updated in the user manual: c: content - No longer exists p: portfolio - now called pages and collections there are no longer separate admin and regular access keys as both menus are visible at all times To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1824054/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1824054] Re: Pointless access keys used in the menus
** Changed in: mahara Milestone: None => 19.04.0 ** Changed in: mahara Importance: Undecided => Medium ** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1824054 Title: Pointless access keys used in the menus Status in Mahara: Fix Committed Bug description: Access keys are used to quickly jump around different pages using keyboard shortcuts (Alt+Shift+ on firefox). Since the navigation has changed a lot int he last few versions of Mahara, a lot of these access keys are now outdated and in some cases, obsolete. Access keys that control buttons that open and close submenus arent needed any longer as they dont actually link to any other pages. Only the ones like 'D' for Dashboard should stay as these link to other pages. The access key changes will also need to be updated in the user manual: c: content - No longer exists p: portfolio - now called pages and collections there are no longer separate admin and regular access keys as both menus are visible at all times To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1824054/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1825600] A change has been merged
Reviewed: https://reviews.mahara.org/9856 Committed: https://git.mahara.org/mahara/mahara/commit/28cd29e7f5e7906c387ed402d4dc439b3927d129 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:19.04_STABLE commit 28cd29e7f5e7906c387ed402d4dc439b3927d129 Author: Doris Tam Date: Wed Apr 24 14:47:24 2019 +1200 Bug 1825600: Fix up colourization of delete buttons and messages This affects: - delete forum(interaction) - delete topic - delete forum post - delete group behatnotneeded Change-Id: I73f445bb2e26605c5e81313d5ad10039dcfb4353 (cherry picked from commit 3f2e90e664acb44356d3539a4cf75caf3d22ca02) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1825600 Title: Forum post deletion shows incorrect button color and post background Status in Mahara: Fix Committed Bug description: When you delete a forum post in a group, there are two styling issues (see screenshot): 1. The "Yes" button should only have the normal button color, i.e. grey, but not the primary button color. 2. The post that is deleted is shown below the deletion message. It has a red background when it shouldn't have one to make the post easier to read. To replicate: 1. Create a group and a forum topic. 2. Make a forum post. 3. Delete the forum post. Expected result: The "Yes" button has the standard grey button color, but not the class "btn-primary", and the forum post to be deleted is not shown with a red background. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1825600/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1825600] A patch has been submitted for review
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9856 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1825600 Title: Forum post deletion shows incorrect button color and post background Status in Mahara: Fix Committed Bug description: When you delete a forum post in a group, there are two styling issues (see screenshot): 1. The "Yes" button should only have the normal button color, i.e. grey, but not the primary button color. 2. The post that is deleted is shown below the deletion message. It has a red background when it shouldn't have one to make the post easier to read. To replicate: 1. Create a group and a forum topic. 2. Make a forum post. 3. Delete the forum post. Expected result: The "Yes" button has the standard grey button color, but not the class "btn-primary", and the forum post to be deleted is not shown with a red background. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1825600/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1825600] A change has been merged
Reviewed: https://reviews.mahara.org/9844 Committed: https://git.mahara.org/mahara/mahara/commit/3f2e90e664acb44356d3539a4cf75caf3d22ca02 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 3f2e90e664acb44356d3539a4cf75caf3d22ca02 Author: Doris Tam Date: Wed Apr 24 14:47:24 2019 +1200 Bug 1825600: Fix up colourization of delete buttons and messages This affects: - delete forum(interaction) - delete topic - delete forum post - delete group behatnotneeded Change-Id: I73f445bb2e26605c5e81313d5ad10039dcfb4353 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1825600 Title: Forum post deletion shows incorrect button color and post background Status in Mahara: Fix Committed Bug description: When you delete a forum post in a group, there are two styling issues (see screenshot): 1. The "Yes" button should only have the normal button color, i.e. grey, but not the primary button color. 2. The post that is deleted is shown below the deletion message. It has a red background when it shouldn't have one to make the post easier to read. To replicate: 1. Create a group and a forum topic. 2. Make a forum post. 3. Delete the forum post. Expected result: The "Yes" button has the standard grey button color, but not the class "btn-primary", and the forum post to be deleted is not shown with a red background. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1825600/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1825600] Re: Forum post deletion shows incorrect button color and post background
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1825600 Title: Forum post deletion shows incorrect button color and post background Status in Mahara: Fix Committed Bug description: When you delete a forum post in a group, there are two styling issues (see screenshot): 1. The "Yes" button should only have the normal button color, i.e. grey, but not the primary button color. 2. The post that is deleted is shown below the deletion message. It has a red background when it shouldn't have one to make the post easier to read. To replicate: 1. Create a group and a forum topic. 2. Make a forum post. 3. Delete the forum post. Expected result: The "Yes" button has the standard grey button color, but not the class "btn-primary", and the forum post to be deleted is not shown with a red background. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1825600/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
