[Mahara-contributors] [Bug 1844199] Re: Check skin before when copying a page

2019-09-16 Thread Kevin Dibble
** Changed in: mahara
 Assignee: (unassigned) => Kevin Dibble (digitalskill)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1844199

Title:
  Check skin before when copying a page

Status in Mahara:
  Confirmed

Bug description:
  When creating a site/group/institution page, we should not be allowing
  to choose from "My skins".

  When copying a page, there should be a check to see if the user that
  wants to copy has access to the skin. If not, the skin should not be
  included in the new page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1844199/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1838721] Re: Plans in copied pages are not copied

2019-09-08 Thread Kevin Dibble
Hi Kristina,

Typically when copying a page with a plan, its to have something similar
for the users to follow. Option 2 sounds the best to me - copy the plan
outline, but leave it for the new user to finalize.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1838721

Title:
  Plans in copied pages are not copied

Status in Mahara:
  Confirmed

Bug description:
  Mahara 19.04
  Os: Linux
  DB: Mysql
  Browser: Chrome

  When copying a page with a plan, the plans on the new page become orphaned.
  They are still listed - but no longer relate to anything.
  Should the user get a copy of the plan as well when coping pages with plans 
artifact?

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1838721/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1824742] Re: Match all tags checkbox not displayed correctly

2019-08-18 Thread Kevin Dibble
** Changed in: mahara
 Assignee: (unassigned) => Kevin Dibble (digitalskill)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1824742

Title:
  Match all tags checkbox not displayed correctly

Status in Mahara:
  Confirmed

Bug description:
  TITLE:  Match all tags checkbox not displayed correctly

  BUG SUMMARY: The Match all tags checkbox and help text is displayed To
  the right of the Sort by dropdown field and search button, It should
  be displayed below the Search/dropdown field

  ==

  Environment tested: Master
  Browser tested: Chrome

  PRECONDITIONS: 
   
  1) Mahara user exists (no roles)

  TEST STEPS: 
   
  1) Log in as Mahara user 
  2) Browse to the Pages and collection overview page (/view/index.php)
  3) Verify that the "Match all tags" checkbox is NOT displayed ✔
  4) Select the "Tags" option from the search/ dropdown box 
  The "Match all tags" checkbox is displayed ✔

  Expected Result: The "Match all tags" checkbox is displayed just below
  the search/ dropdown box

  Actual Result: The "Match all tags" checkbox is displayed to the right
  of the search button

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1824742/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1838721] [NEW] Plans in shared pages

2019-08-01 Thread Kevin Dibble
Public bug reported:

Mahara 19.04
Os: Linux
DB: Mysql
Browser: Chrome

When copying a page with a plan, the plans on the new page become orphaned.
They are still listed - but no longer relate to anything.
Should the user get a copy of the plan as well when coping pages with plans 
artifact?

** Affects: mahara
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1838721

Title:
  Plans in shared pages

Status in Mahara:
  New

Bug description:
  Mahara 19.04
  Os: Linux
  DB: Mysql
  Browser: Chrome

  When copying a page with a plan, the plans on the new page become orphaned.
  They are still listed - but no longer relate to anything.
  Should the user get a copy of the plan as well when coping pages with plans 
artifact?

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1838721/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1669128] Re: HTML export links to actual files rather than local files

2019-07-30 Thread Kevin Dibble
** Changed in: mahara
 Assignee: (unassigned) => Kevin Dibble (digitalskill)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1669128

Title:
  HTML export links to actual files rather than local files

Status in Mahara:
  Confirmed

Bug description:
  When you export a portfolio in HTML and have a file on a page, the
  file's link goes to the original location of the site whereas the
  download link goes to the local site.

  Therefore, if a user clicks the link, they often need to log into the
  original site or if the account was removed can't access their file.
  Whereas if they click to download the file, they can do so. The links
  should always go to the local file rather than the original location
  esp. since the file is saved in the HTML export.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1669128/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1818082] Re: Long delays after release of ePortfolio for archiving

2019-07-28 Thread Kevin Dibble
Hi Fiona,

The Release and archive of a portfolio it's tied to the Cron job.
Does your server team have the crop job running every 15 mins - or have they 
delayed it.

This is stated at:
https://wiki.mahara.org/index.php/System_Administrator%27s_Guide/Cron_Job

I note that this issue started since your upgrade. 
If the path or server changed - then the special job on the server called 
"CRON" needs to be updated as well.

Often during an upgrade - the cron gets overlooked.

Typically on Mahara (All versions i have used) any work due to be
released, gets released in seconds when cron runs.

To check this: submit work to a group - then release it, then manually
run CRON at:  https://[yourwebsite]/lib/cron.php?urlsecret=[your url
secret from the config.php file]

If the work gets released immediately - then see your server team about
the cron job... If not... then post back here and let me know.

** Changed in: mahara
 Assignee: (unassigned) => Kevin Dibble (digitalskill)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1818082

Title:
  Long delays after release of ePortfolio for archiving

Status in Mahara:
  New

Bug description:
  Since upgrading from 18.04 we have noticed a long delay for the group
  archiving process following the release of an ePortfolio from a group
  back to a student. It used to take 30mins for a 1 page eportfolio
  featuring 10 PDFs and 4 word documents to archive to LEAP2A. It is now
  taking more than 1 hour since we upgraded to 18.10.

  Interestingly we have found that the archiving is hanging for the
  first two submissions, but then if you submit a third ePortfolio and
  then release it that can hasten the first two into completing the
  archiving process. Upon checking the archived LEAP2A files they are
  fine.

  This is going to be a bit of a headache for us as students often
  accidentally submit before they are supposed to and 1 hour or more is
  a very long delay before they can resume work on their ePortfolio. As
  a result we are going to have to turn off archiving during submissions
  and then turn it on again in each group prior to ePortfolio release.

  Steps to complete:
  1. Student submits ePortfolio to a group which has archiving turned on.
  2. Academic releases ePortfolio back to student from the group.
  3. There is a long waiting period. Currently over 1 hour.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1818082/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1835688] Re: Authentication method not showing properly

2019-07-15 Thread Kevin Dibble
** Description changed:

  Version: Mahara 19.04
  Browser: chrome
  
- Steps to Replicate:
+ Steps to Replicate: (You will need two or more institutes in Mahara)
  1. Create a user on Moodle to access the site via the xml/rpc method.
  2. Login as that user - the account is created as expected.
+ 3. Add that user to a different institute in Mahara. (The user will be using 
the same auth, but will be added to a new institute)
  
  As the admin of Mahara.
  3. Find the user [maharawebsite]/admin/users/search.php
  4. Enter the user's name and it will list as expected -with correct 
authentication details
  
  5. Edit the user (Issue 1 - The form is not showing the correct details)
  Authentication method on the form is displayed as "internal" and a password 
is requested
  Change the authentication method to be the institute listed.
  
- 6: click save
+ 6 DONT click save - the users details will have changed and the
+ institute will have a new internal auth method.
+ 
+ 7. Go back and edit the user - and change the authentication back
+ 7: click save
  
  7: Search for the user again [maharawebsite]/admin/users/search.php -
- that user is now listed as "internal".
+ that user is still listed as "internal" with incorrect auth details.

** Changed in: mahara
 Assignee: (unassigned) => Kevin Dibble (digitalskill)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1835688

Title:
  Authentication method not showing properly

Status in Mahara:
  New

Bug description:
  Version: Mahara 19.04
  Browser: chrome

  Steps to Replicate: (You will need two or more institutes in Mahara)
  1. Create a user on Moodle to access the site via the xml/rpc method.
  2. Login as that user - the account is created as expected.
  3. Add that user to a different institute in Mahara. (The user will be using 
the same auth, but will be added to a new institute)

  As the admin of Mahara.
  3. Find the user [maharawebsite]/admin/users/search.php
  4. Enter the user's name and it will list as expected -with correct 
authentication details

  5. Edit the user (Issue 1 - The form is not showing the correct details)
  Authentication method on the form is displayed as "internal" and a password 
is requested
  Change the authentication method to be the institute listed.

  6 DONT click save - the users details will have changed and the
  institute will have a new internal auth method.

  7. Go back and edit the user - and change the authentication back
  7: click save

  7: Search for the user again [maharawebsite]/admin/users/search.php -
  that user is still listed as "internal" with incorrect auth details.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1835688/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1835688] [NEW] Authentication method not showing properly

2019-07-07 Thread Kevin Dibble
Public bug reported:

Version: Mahara 19.04
Browser: chrome

Steps to Replicate:
1. Create a user on Moodle to access the site via the xml/rpc method.
2. Login as that user - the account is created as expected.

As the admin of Mahara.
3. Find the user [maharawebsite]/admin/users/search.php
4. Enter the user's name and it will list as expected -with correct 
authentication details

5. Edit the user (Issue 1 - The form is not showing the correct details)
Authentication method on the form is displayed as "internal" and a password is 
requested
Change the authentication method to be the institute listed.

6: click save

7: Search for the user again [maharawebsite]/admin/users/search.php -
that user is now listed as "internal".

** Affects: mahara
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1835688

Title:
  Authentication method not showing properly

Status in Mahara:
  New

Bug description:
  Version: Mahara 19.04
  Browser: chrome

  Steps to Replicate:
  1. Create a user on Moodle to access the site via the xml/rpc method.
  2. Login as that user - the account is created as expected.

  As the admin of Mahara.
  3. Find the user [maharawebsite]/admin/users/search.php
  4. Enter the user's name and it will list as expected -with correct 
authentication details

  5. Edit the user (Issue 1 - The form is not showing the correct details)
  Authentication method on the form is displayed as "internal" and a password 
is requested
  Change the authentication method to be the institute listed.

  6: click save

  7: Search for the user again [maharawebsite]/admin/users/search.php -
  that user is now listed as "internal".

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1835688/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1834107] [NEW] timeline does not work in IE11

2019-06-24 Thread Kevin Dibble
Public bug reported:

Mahara: 19.04
Browser: IE 11

The timeline feature does not work in IE 11.
The ECMA 6 script in jtline.js is not compatible with IE 11.

** Affects: mahara
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1834107

Title:
  timeline does not work in IE11

Status in Mahara:
  New

Bug description:
  Mahara: 19.04
  Browser: IE 11

  The timeline feature does not work in IE 11.
  The ECMA 6 script in jtline.js is not compatible with IE 11.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1834107/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1833318] [NEW] Names not showing for collections in Group Portfolios

2019-06-18 Thread Kevin Dibble
Public bug reported:

OS: Linux
Browser: All
Version: Mahara 19.04

Steps:
1.) Create a Page for the group
2.) Create a collection in a group add pages and save
3.) View the group home page
4.) Under the section "Group portfolios" the names of collections are missing

** Affects: mahara
 Importance: Undecided
 Assignee: Kevin Dibble (digitalskill)
 Status: Confirmed

** Attachment added: "Screen Shot 2019-06-19 at 11.25.36 AM.png"
   
https://bugs.launchpad.net/bugs/1833318/+attachment/5271489/+files/Screen%20Shot%202019-06-19%20at%2011.25.36%20AM.png

** Changed in: mahara
   Status: New => Confirmed

** Changed in: mahara
 Assignee: (unassigned) => Kevin Dibble (digitalskill)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1833318

Title:
  Names not showing for collections in Group Portfolios

Status in Mahara:
  Confirmed

Bug description:
  OS: Linux
  Browser: All
  Version: Mahara 19.04

  Steps:
  1.) Create a Page for the group
  2.) Create a collection in a group add pages and save
  3.) View the group home page
  4.) Under the section "Group portfolios" the names of collections are missing

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1833318/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1833135] [NEW] sign off block does not record manager who verified

2019-06-17 Thread Kevin Dibble
Public bug reported:

When the manager verifies a portfolio or page on the "Sign off" block,
there is no record kept of that manager.

This makes it difficult for other managers to confirm who signed it off
when the page is submitted to a group for Assessment.

** Affects: mahara
 Importance: Undecided
 Status: New

** Description changed:

- When the manager verifies a portfolio or page, there is no record kept
- of that manager.
+ When the manager verifies a portfolio or page on the "Sign off" block,
+ there is no record kept of that manager.
  
  This makes it difficult for other managers to confirm who signed it off
  when the page is submitted to a group for Assessment.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1833135

Title:
  sign off block does not record manager who verified

Status in Mahara:
  New

Bug description:
  When the manager verifies a portfolio or page on the "Sign off" block,
  there is no record kept of that manager.

  This makes it difficult for other managers to confirm who signed it
  off when the page is submitted to a group for Assessment.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1833135/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1044878] Re: Make the info on copying text box more obvious

2019-05-22 Thread Kevin Dibble
I have updated the code now to show the message with the correct count
to bring back the text.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1044878

Title:
  Make the info on copying text box more obvious

Status in Mahara:
  In Progress

Bug description:
  The text for re-using a text box "If you edit the text of this block,
  it will also be changed in 1 other block(s) where it appears. Make a
  copy (link to make a copy)" is not obvious enough for some users and
  may be overlooked.

  Can it be made more prominent, e.g. via a pop-up window? Is it
  possible to link "Make a copy" still within a pop-up or would we have
  to think of a different solution?

  For the discussion, please see
  https://mahara.org/interaction/forum/topic.php?id=4827

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1044878/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1044878] Re: Make the info on copying text box more obvious

2019-05-21 Thread Kevin Dibble
I removed this message from showing functionality - as it does not
appear when selecting to use a block currently. Having it show would
cause an incorrect number to appear, so decided to keep current working
to not have it appear.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1044878

Title:
  Make the info on copying text box more obvious

Status in Mahara:
  In Progress

Bug description:
  The text for re-using a text box "If you edit the text of this block,
  it will also be changed in 1 other block(s) where it appears. Make a
  copy (link to make a copy)" is not obvious enough for some users and
  may be overlooked.

  Can it be made more prominent, e.g. via a pop-up window? Is it
  possible to link "Make a copy" still within a pop-up or would we have
  to think of a different solution?

  For the discussion, please see
  https://mahara.org/interaction/forum/topic.php?id=4827

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1044878/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1044878] Re: Make the info on copying text box more obvious

2019-05-14 Thread Kevin Dibble
The first issue - There is no initial counting when choosing to copy the note.
I'll create a new XHR call to get this number...

The 2nd issue is a seperate bug in Mahara around notes:
It can be re-created in any version of Mahara - add a note - choose to copy the 
note from another - then cancel. I'll address this with this patch.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1044878

Title:
  Make the info on copying text box more obvious

Status in Mahara:
  In Progress

Bug description:
  The text for re-using a text box "If you edit the text of this block,
  it will also be changed in 1 other block(s) where it appears. Make a
  copy (link to make a copy)" is not obvious enough for some users and
  may be overlooked.

  Can it be made more prominent, e.g. via a pop-up window? Is it
  possible to link "Make a copy" still within a pop-up or would we have
  to think of a different solution?

  For the discussion, please see
  https://mahara.org/interaction/forum/topic.php?id=4827

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1044878/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1529730] Re: Show full introduction from the profile

2019-05-09 Thread Kevin Dibble
The Engage -> People page was not updated to have this working. It was
only on the group members area.

Is this required for the Engage -> People page as well?

Cheers

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1529730

Title:
  Show full introduction from the profile

Status in Mahara:
  In Progress

Bug description:
  Mahara 15.10+

  When a user wrote an introduction and it is longer than a few
  characters, it is cut off. However, unless the user puts that
  introduction on their profile page, there is no place to see it fully.

  Therefore, when you are on the group members page or on "My friends"
  and "Find friends", it would be good to display the entire
  introduction. If people do tend to write a lot, then maybe we don't
  show the introduction directly on the page but only upon a click on
  it. Or have a link they can click to expand the introduction.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1529730/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1827014] Re: Ability to "retire" SmartEvidence frameworks

2019-04-30 Thread Kevin Dibble
** Changed in: mahara
 Assignee: (unassigned) => Kevin Dibble (digitalskill)

** Changed in: mahara
   Status: New => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1827014

Title:
  Ability to "retire" SmartEvidence frameworks

Status in Mahara:
  In Progress

Bug description:
  As curriculum develops and changes and institutions refine what they need 
from SmartEvidence, existing frameworks will become redundant as they are 
modified to meet new requirements. Currently any framework that even a single 
user has selected for inclusion in a portfolio cannot be deleted. If old 
frameworks could be "retired" so that while they still exist in the system they 
are not available/visible to users as a framework that can be chosen it will 
make the feature much more viable on a long term basis.
   
  Being able to modify or delete an in-use framework to correct an error would 
be useful, but this is the less drastic step of simply hiding an old version to 
make it unavailable to add to a collection.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1827014/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1817326] Re: Goals and skills - add file - after preview focus lost on the pop-up with my files

2019-04-30 Thread Kevin Dibble
** Changed in: mahara
   Status: New => In Progress

** Changed in: mahara
 Assignee: (unassigned) => Kevin Dibble (digitalskill)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1817326

Title:
  Goals and skills - add file - after preview focus lost on the pop-up
  with my files

Status in Mahara:
  In Progress

Bug description:
  I'am in Goals and skills.

  I add file, a new window open with my files, if  i click of one of
  them a preview pop-up open. If a click on the side, this pop close,
  but the focus was lost on the windows who display my files. The
  scrolling it's on the main page not on the first open pop-up (list of
  my files).

  If you want to reproduice the bug, you should have many files (+ 10)
  in your bank.

  I hope to be clear to explain the bug.

  Thank you

  
  - Mahara 18.10
  - Windows 10 (web server on linux)
  - Mysql Database
  - Google Chrome

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1817326/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1817326] Re: Goals and skills - add file - after preview focus lost on the pop-up with my files

2019-04-29 Thread Kevin Dibble
Modal in a Modal popup:
This issue does not affect 19.04.
 
In 18.10 the modal of the image preview is appearing inside another Modal. 
Clicking "Close" on the popup closes all Modals.

The second Modal inherits the size of the first modal box (rather than
sitting on the viewport) creating incorrect heights on the image that
appears - meaning that scrolling needs to occur to view the image if
scrolled down the page.

The fix would be to add the modal template call to the bottom of the
modal page for viewing files.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1817326

Title:
  Goals and skills - add file - after preview focus lost on the pop-up
  with my files

Status in Mahara:
  New

Bug description:
  I'am in Goals and skills.

  I add file, a new window open with my files, if  i click of one of
  them a preview pop-up open. If a click on the side, this pop close,
  but the focus was lost on the windows who display my files. The
  scrolling it's on the main page not on the first open pop-up (list of
  my files).

  If you want to reproduice the bug, you should have many files (+ 10)
  in your bank.

  I hope to be clear to explain the bug.

  Thank you

  
  - Mahara 18.10
  - Windows 10 (web server on linux)
  - Mysql Database
  - Google Chrome

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1817326/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1184947] Re: Cannot export with chinese file name

2019-04-03 Thread Kevin Dibble
Hi Steven,

Agree that this is not a mahara issue - but the language support on the server 
itself.
Are you happy for me to close this issue as invalid? 

** Changed in: mahara
   Status: In Progress => Invalid

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1184947

Title:
  Cannot export with chinese file name

Status in Mahara:
  Invalid

Bug description:
  I encounter export problem with any file (within the content -> file) with 
chinese file name:
  1. If I choose to export to LEAP2A, the file is missing in the exported file.
  2. If I choose to export to HTML, the file name become garbled.

  version: Mahara 1.7
  server OS: ubuntu 10.04
  php: 5.3.2.1.4.19
  database: mysql 5.1.69.0.0.10.04.1

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1184947/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1528118] Re: Preview collections on Export screen

2019-03-27 Thread Kevin Dibble
** Changed in: mahara
 Assignee: (unassigned) => Kevin Dibble (digitalskill)

** Changed in: mahara
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1528118

Title:
  Preview collections on Export screen

Status in Mahara:
  In Progress

Bug description:
  When you export pages, you can preview them. But you don't have that
  option for collections. There should be a collection preview link
  which takes you to the first page of the collection and ideally you
  can navigate through the other pages.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1528118/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1689312] Re: New username isn't checked for spaces when added to LDAP

2019-03-27 Thread Kevin Dibble
** Changed in: mahara
 Assignee: (unassigned) => Kevin Dibble (digitalskill)

** Changed in: mahara
   Status: Confirmed => Opinion

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1689312

Title:
  New username isn't checked for spaces when added to LDAP

Status in Mahara:
  Opinion

Bug description:
  Mahara version: 16.10.3

  When adding a new user, if you select an institution/authentication
  method with LDAP, the usersame is not being checked for
  leading/trailing spaces, and it isn't trimmed before being added to
  the database. Users can be created with usernames like " newuser ".

  If you try to do this with a non LDAP authentication method, it thows
  an error and will not continue (although the error message does not
  highlight the username field as the source of the error in this case).

  I've fixed it locally with trim() around the username value before
  it's put into the databse.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1689312/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1822022] [NEW] Dialog box close button not working

2019-03-27 Thread Kevin Dibble
Public bug reported:

This is a follow-on issue to bug 1806524

Database: Postgres, Mysql
Browser: Chrome, Firefox, Safari
OS: Mac

The dialog button no longer closes the dialog.
Update the javascript libraries to resolve

** Affects: mahara
 Importance: Undecided
 Assignee: Kevin Dibble (digitalskill)
 Status: In Progress

** Changed in: mahara
 Assignee: (unassigned) => Kevin Dibble (digitalskill)

** Changed in: mahara
   Status: New => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1822022

Title:
  Dialog box close button not working

Status in Mahara:
  In Progress

Bug description:
  This is a follow-on issue to bug 1806524

  Database: Postgres, Mysql
  Browser: Chrome, Firefox, Safari
  OS: Mac

  The dialog button no longer closes the dialog.
  Update the javascript libraries to resolve

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1822022/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1821267] Re: Email notice for submisisons and reports on submisisons

2019-03-27 Thread Kevin Dibble
** Changed in: mahara
 Assignee: (unassigned) => Kevin Dibble (digitalskill)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1821267

Title:
  Email notice for submisisons and reports on submisisons

Status in Mahara:
  In Progress

Bug description:
  Wishlist item:
  When a user submits a page or collection for marking - to send out an email 
notice to that user.

  A report to view all submissions and when they were marked and
  released

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1821267/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1529730] Re: Show full introduction from the profile

2019-03-27 Thread Kevin Dibble
** Changed in: mahara
 Assignee: (unassigned) => Kevin Dibble (digitalskill)

** Changed in: mahara
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1529730

Title:
  Show full introduction from the profile

Status in Mahara:
  In Progress

Bug description:
  Mahara 15.10+

  When a user wrote an introduction and it is longer than a few
  characters, it is cut off. However, unless the user puts that
  introduction on their profile page, there is no place to see it fully.

  Therefore, when you are on the group members page or on "My friends"
  and "Find friends", it would be good to display the entire
  introduction. If people do tend to write a lot, then maybe we don't
  show the introduction directly on the page but only upon a click on
  it. Or have a link they can click to expand the introduction.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1529730/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1184947] Re: Cannot export with chinese file name

2019-03-27 Thread Kevin Dibble
** Changed in: mahara
 Assignee: (unassigned) => Kevin Dibble (digitalskill)

** Changed in: mahara
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1184947

Title:
  Cannot export with chinese file name

Status in Mahara:
  In Progress

Bug description:
  I encounter export problem with any file (within the content -> file) with 
chinese file name:
  1. If I choose to export to LEAP2A, the file is missing in the exported file.
  2. If I choose to export to HTML, the file name become garbled.

  version: Mahara 1.7
  server OS: ubuntu 10.04
  php: 5.3.2.1.4.19
  database: mysql 5.1.69.0.0.10.04.1

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1184947/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1044878] Re: Make the info on copying text box more obvious

2019-03-27 Thread Kevin Dibble
** Changed in: mahara
 Assignee: (unassigned) => Kevin Dibble (digitalskill)

** Changed in: mahara
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1044878

Title:
  Make the info on copying text box more obvious

Status in Mahara:
  In Progress

Bug description:
  The text for re-using a text box "If you edit the text of this block,
  it will also be changed in 1 other block(s) where it appears. Make a
  copy (link to make a copy)" is not obvious enough for some users and
  may be overlooked.

  Can it be made more prominent, e.g. via a pop-up window? Is it
  possible to link "Make a copy" still within a pop-up or would we have
  to think of a different solution?

  For the discussion, please see
  https://mahara.org/interaction/forum/topic.php?id=4827

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1044878/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 655443] Re: Make block titles optional

2019-03-27 Thread Kevin Dibble
** Changed in: mahara
 Assignee: (unassigned) => Kevin Dibble (digitalskill)

** Changed in: mahara
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/655443

Title:
  Make block titles optional

Status in Mahara:
  In Progress

Bug description:
  In some blocks, like 'blog', the title defaults to the title of the
  blog if you leave the title blank, but others (like text box) let you
  have no title just by leaving it blank (and the view editor helpfully
  shows "[No title]").

  I think we need a "No title" checkbox for the blocks that don't
  already allow you to have no title by leaving the title blank.  Or
  maybe instead, a blank title should really mean 'no title' and there
  should be a checkbox on some of the blocks saying stuff like "use the
  blog's title".

  See some other discussion on
  https://bugs.launchpad.net/mahara/+bug/617159

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/655443/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1798203] Re: Peer review role prevents site / institution admin from seeing all content on page during objectionable review

2019-03-27 Thread Kevin Dibble
** Changed in: mahara/19.04
 Assignee: (unassigned) => Kevin Dibble (digitalskill)

** Changed in: mahara/19.04
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1798203

Title:
  Peer review role prevents site / institution admin from seeing all
  content on page during objectionable review

Status in Mahara:
  In Progress
Status in Mahara 19.04 series:
  In Progress

Bug description:
  Bug Summary: Content author has a public portfolio page -> Another user 
reports objectionable material = author sees warning on page -> does not edit 
page but adds the site admin as a peer reviewer -> who can not see the page 
details but only the headings 
  ---

  Environment tested: Master
  Browser tested: Chrome

  Preconditions:
  1. Content author creates a portfolio page 
  2. Another site user reports objectionable material on the page 

  Test Steps: 
  1. Content author does not change any content on the page
  2. Content author shares the page with Site admin and assigns the role of 
peer for peer review 
  3. Content author notify site admin stuff has been changed 
  4. Site admin logs in and browses to the page with objectionable material 

  Actual result: The site admin only sees headings on the page and
  cannot see the actual page content

  Expected result: Site admin should be able to see all page content
  even if they are assigned the role of peer for peer review or site
  admins should not be in the list of users that can do peer reviews

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1798203/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1184947] Re: Cannot export with chinese file name

2019-03-26 Thread Kevin Dibble
When creating a leap2a export - the file name gets appended with an id.
This is expected behavior as without this id before the file name, the
leap 2a cannot be re-imported.

So the 0-測試.txt is expected working.


The garbling of Chinese names is not to do with the import/export, but the 
language support on the server itself.
https://unix.stackexchange.com/questions/149348/how-to-display-chinese-characters-correctly-on-remote-red-hat-machine

Basically, this may be a problem of mismatch between your locale, which
is set to UTF-8, and the encoding of your Chineses character file, which
may be encoded in gbk, gb2312, gb18030, or Big-5.

The solution is to update the server to support different locale and
languages.

I would suggest to update the Mahara wiki for noting this to server
admins that need to support different languages and closing this issue
here.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1184947

Title:
  Cannot export with chinese file name

Status in Mahara:
  Confirmed

Bug description:
  I encounter export problem with any file (within the content -> file) with 
chinese file name:
  1. If I choose to export to LEAP2A, the file is missing in the exported file.
  2. If I choose to export to HTML, the file name become garbled.

  version: Mahara 1.7
  server OS: ubuntu 10.04
  php: 5.3.2.1.4.19
  database: mysql 5.1.69.0.0.10.04.1

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1184947/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1689312] Re: New username isn't checked for spaces when added to LDAP

2019-03-24 Thread Kevin Dibble
Really not sure which is the best solution.
1.) Force LDAP not to have spaces - which would break current installs.
2.) Add a special character in the username feature (Like Moodle) which 
existing users of Mahara will need to know before updating.
or 
3.) leave (not really broken - more of a data checking/ entry issue?)

LDAP usernames can contain spaces.
Putting in a trim feature would then break all existing users on Mahara where 
their LDAP has been set up to allow spaces. So - allowing spaces in LDAP 
username looks to be allowed for this very reason.

Moodle put in this solution:
$CFG->extendedusernamechars = true
To allow special characters in usernames (Which old LDAPS out there use). 
https://moodle.org/mod/forum/discuss.php?d=279500

As Mahara allows special characters once you choose LDAP - it already
resolves a Moodle issue.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1689312

Title:
  New username isn't checked for spaces when added to LDAP

Status in Mahara:
  Confirmed

Bug description:
  Mahara version: 16.10.3

  When adding a new user, if you select an institution/authentication
  method with LDAP, the usersame is not being checked for
  leading/trailing spaces, and it isn't trimmed before being added to
  the database. Users can be created with usernames like " newuser ".

  If you try to do this with a non LDAP authentication method, it thows
  an error and will not continue (although the error message does not
  highlight the username field as the source of the error in this case).

  I've fixed it locally with trim() around the username value before
  it's put into the databse.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1689312/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1821267] [NEW] Email notice for Submisisons and Reports on submisisons

2019-03-21 Thread Kevin Dibble
Public bug reported:

Wishlist item:
When a user submits a page or collection for marking - to send out an email 
notice to that user.

A report to view all submissions and when they were marked and released

** Affects: mahara
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1821267

Title:
  Email notice for Submisisons and Reports on submisisons

Status in Mahara:
  New

Bug description:
  Wishlist item:
  When a user submits a page or collection for marking - to send out an email 
notice to that user.

  A report to view all submissions and when they were marked and
  released

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1821267/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1819807] Re: Search box overlaps navigaiton icons on right side of page

2019-03-19 Thread Kevin Dibble
Thanks Liam,

It may have been a cache of 18.04 which has 163px for right when I was looking 
at 18.10.
It did it when I switched branches, but cannot seem to replicate.

This can be closed - invalid.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1819807

Title:
  Search box overlaps navigaiton icons on right side of page

Status in Mahara:
  Invalid

Bug description:
  Mahara version: Mahara 18.10.1testing
  Browser: Chrome, Safari, Firefox windows edge
  OS: Mac
  PHP: 7.0
  Database: Mysql 8

  Issue:
  Search box is set with a right margin of 193px, but the icons on the right 
take up more than that space.

  Solution:
  change the lines 38 and 39 in htdocs/theme/raw/layout/nav/_navbar.scss to 
  right: 25%;   
  margin: 0;

  The 25% value is to match the layout grid to keep the right icons
  clear.

  Patch file with the change attached (A recompile of the css is
  necessary to confirm the change)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1819807/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1819807] [NEW] Search box overlaps navigaiton icons on right side of page

2019-03-12 Thread Kevin Dibble
Public bug reported:

Mahara version: Mahara 18.10.1testing
Browser: Chrome, Safari, Firefox windows edge
OS: Mac
PHP: 7.0
Database: Mysql 8

Issue:
Search box is set with a right margin of 193px, but the icons on the right take 
up more than that space.

Solution:
change the lines 38 and 39 in htdocs/theme/raw/layout/nav/_navbar.scss to 
right: 25%;   
margin: 0;

The 25% value is to match the layout grid to keep the right icons clear.

Patch file with the change attached (A recompile of the css is necessary
to confirm the change)

** Affects: mahara
 Importance: Undecided
 Status: New

** Patch added: "css_patch.diff"
   
https://bugs.launchpad.net/bugs/1819807/+attachment/5245732/+files/css_patch.diff

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1819807

Title:
  Search box overlaps navigaiton icons on right side of page

Status in Mahara:
  New

Bug description:
  Mahara version: Mahara 18.10.1testing
  Browser: Chrome, Safari, Firefox windows edge
  OS: Mac
  PHP: 7.0
  Database: Mysql 8

  Issue:
  Search box is set with a right margin of 193px, but the icons on the right 
take up more than that space.

  Solution:
  change the lines 38 and 39 in htdocs/theme/raw/layout/nav/_navbar.scss to 
  right: 25%;   
  margin: 0;

  The 25% value is to match the layout grid to keep the right icons
  clear.

  Patch file with the change attached (A recompile of the css is
  necessary to confirm the change)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1819807/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1803101] Re: Error importing Leap2A w/ peer assessment

2019-03-12 Thread Kevin Dibble
Hi Team,

Attached is a patch - but it will need to be checked by the Mahara team
to make sure that using $this->id and $this->get('owner') are valid
options should the block id and user id not be present when creatign the
assessment block.

Issue:
The Table 'artefact_peer_assessment' has Foreign keys for assessment, block, 
usr, view, that cannot be empty.

artefact/peerassessment/lib.php line 254 creates the data object - but
'block' and 'usr' are null - db insert fails.

Changing this $data object to fill in these fields with its ID and Owner value 
succeeds:
 $data = (object)array(
'assessment'=> $this->get('id'),
'block' => $this->get('block') ? $this->get('block') : 
$this->id ,
'usr'   => $this->get('usr') ? $this->get('usr') : 
$this->get('owner'),
'view'  => $this->get('view'),
'private'   => ($this->get('private') ? 1 : 0),
);

Issue 2: Affects mysql 8:
Line 1252 in File htdocs/import/leap/lib.php uses the word "row" without 
backticks. As this is a reserved word - there is a second data point of failure 
here when doing imports.


** Patch added: "peerassessmentimport.diff"
   
https://bugs.launchpad.net/mahara/+bug/1803101/+attachment/5245731/+files/peerassessmentimport.diff

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1803101

Title:
  Error importing Leap2A w/ peer assessment

Status in Mahara:
  Incomplete
Status in Mahara 18.10 series:
  Confirmed
Status in Mahara 19.04 series:
  Incomplete

Bug description:
  I exported a simple portfolio page as Leap2A and got the error
  messages below when importing it via the admin interface. The Leap2A
  file is attached.

  [WAR] 37 (lib/adodb/adodb-exceptions.inc.php:45) Array to string conversion
  Call stack (most recent first):

  log_message("Array to string conversion", 8, true, true, 
"/home/kristina/code/mahara/htdocs/lib/adodb/adodb-...", 45) at 
/home/kristina/code/mahara/htdocs/lib/errors.php:520
  error(8, "Array to string conversion", 
"/home/kristina/code/mahara/htdocs/lib/adodb/adodb-...", 45, array(size 7)) at 
/home/kristina/code/mahara/htdocs/lib/adodb/adodb-exceptions.inc.php:45
  ADODB_Exception->__construct("postgres8", "adodb_throw", -1, "ERROR: null 
value in column "block" violates not-...", "INSERT INTO 
"artefact_peer_assessment" ("assessmen...", array(size 3), 
object(ADODB_postgres8)) at 
/home/kristina/code/mahara/htdocs/lib/adodb/adodb-exceptions.inc.php:80
  adodb_throw("postgres8", "adodb_throw", -1, "ERROR: null value in column 
"block" violates not-...", "INSERT INTO "artefact_peer_assessment" 
("assessmen...", array(size 3), object(ADODB_postgres8)) at 
/home/kristina/code/mahara/htdocs/lib/adodb/adodb.inc.php:313
  ADODB_TransMonitor("postgres8", "adodb_throw", -1, "ERROR: null value in 
column "block" violates not-...", "INSERT INTO "artefact_peer_assessment" 
("assessmen...", array(size 3), object(ADODB_postgres8)) at 
/home/kristina/code/mahara/htdocs/lib/adodb/adodb.inc.php:1263
  ADOConnection->_Execute("INSERT INTO "artefact_peer_assessment" 
("assessmen...", array(size 3)) at 
/home/kristina/code/mahara/htdocs/lib/adodb/adodb.inc.php:1223
  ADOConnection->Execute("INSERT INTO "artefact_peer_assessment" 
("assessmen...", array(size 3)) at 
/home/kristina/code/mahara/htdocs/lib/dml.php:1102
  insert_record("artefact_peer_assessment", object(stdClass)) at 
/home/kristina/code/mahara/htdocs/artefact/peerassessment/lib.php:240
  ArtefactTypePeerassessment->commit() at 
/home/kristina/code/mahara/htdocs/artefact/peerassessment/import/leap/lib.php:180
  LeapImportPeerassessment::import_using_strategy(object(SimpleXMLElement), 
object(PluginImportLeap), 1, array(size 0)) at 
/home/kristina/code/mahara/htdocs/lib/mahara.php:1813
  call_static_method("LeapImportPeerassessment", "import_using_strategy", 
object(SimpleXMLElement), object(PluginImportLeap), 1, array(size 0)) at 
/home/kristina/code/mahara/htdocs/import/leap/lib.php:665
  PluginImportLeap->import_from_load_mapping() at 
/home/kristina/code/mahara/htdocs/import/leap/lib.php:188
  PluginImportLeap->process() at 
/home/kristina/code/mahara/htdocs/admin/users/add.php:348
  adduser_submit(object(Pieform), array(size 24)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:542
  Pieform->__construct(array(size 8)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:164
  Pieform::process(array(size 8)) at 
/home/kristina/code/mahara/htdocs/lib/mahara.php:5258
  pieform(array(size 8)) at 
/home/kristina/code/mahara/htdocs/admin/users/add.php:156

  [WAR] 37 (lib/errors.php:858) Failed to get a recordset: postgres8 error: 

[Mahara-contributors] [Bug 1803101] Re: Error importing Leap2A w/ peer assessment

2019-03-10 Thread Kevin Dibble
Hi Team,

This issue seems to be around line 263 
in the file: mahara/htdocs/artefact/peerassessment/lib.php

There are FK_constraints on the table that require block and usr to be present.
however, in the file from Kristina Heoppner, block and usr is NULL when 
processing:
insert_record('artefact_peer_assessment', $data);

To test, do a 'var_dump($data); die();' above the insert_record line.

This seems to point to two possibilities:
Either the Export is missing block and user data (Export could be the issue)
OR
The import of peer-assessed items is out of order (Creating assessment before 
creating the block...)

Still looking into it, but this has been what I have found so far.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1803101

Title:
  Error importing Leap2A w/ peer assessment

Status in Mahara:
  Incomplete
Status in Mahara 18.10 series:
  Confirmed
Status in Mahara 19.04 series:
  Incomplete

Bug description:
  I exported a simple portfolio page as Leap2A and got the error
  messages below when importing it via the admin interface. The Leap2A
  file is attached.

  [WAR] 37 (lib/adodb/adodb-exceptions.inc.php:45) Array to string conversion
  Call stack (most recent first):

  log_message("Array to string conversion", 8, true, true, 
"/home/kristina/code/mahara/htdocs/lib/adodb/adodb-...", 45) at 
/home/kristina/code/mahara/htdocs/lib/errors.php:520
  error(8, "Array to string conversion", 
"/home/kristina/code/mahara/htdocs/lib/adodb/adodb-...", 45, array(size 7)) at 
/home/kristina/code/mahara/htdocs/lib/adodb/adodb-exceptions.inc.php:45
  ADODB_Exception->__construct("postgres8", "adodb_throw", -1, "ERROR: null 
value in column "block" violates not-...", "INSERT INTO 
"artefact_peer_assessment" ("assessmen...", array(size 3), 
object(ADODB_postgres8)) at 
/home/kristina/code/mahara/htdocs/lib/adodb/adodb-exceptions.inc.php:80
  adodb_throw("postgres8", "adodb_throw", -1, "ERROR: null value in column 
"block" violates not-...", "INSERT INTO "artefact_peer_assessment" 
("assessmen...", array(size 3), object(ADODB_postgres8)) at 
/home/kristina/code/mahara/htdocs/lib/adodb/adodb.inc.php:313
  ADODB_TransMonitor("postgres8", "adodb_throw", -1, "ERROR: null value in 
column "block" violates not-...", "INSERT INTO "artefact_peer_assessment" 
("assessmen...", array(size 3), object(ADODB_postgres8)) at 
/home/kristina/code/mahara/htdocs/lib/adodb/adodb.inc.php:1263
  ADOConnection->_Execute("INSERT INTO "artefact_peer_assessment" 
("assessmen...", array(size 3)) at 
/home/kristina/code/mahara/htdocs/lib/adodb/adodb.inc.php:1223
  ADOConnection->Execute("INSERT INTO "artefact_peer_assessment" 
("assessmen...", array(size 3)) at 
/home/kristina/code/mahara/htdocs/lib/dml.php:1102
  insert_record("artefact_peer_assessment", object(stdClass)) at 
/home/kristina/code/mahara/htdocs/artefact/peerassessment/lib.php:240
  ArtefactTypePeerassessment->commit() at 
/home/kristina/code/mahara/htdocs/artefact/peerassessment/import/leap/lib.php:180
  LeapImportPeerassessment::import_using_strategy(object(SimpleXMLElement), 
object(PluginImportLeap), 1, array(size 0)) at 
/home/kristina/code/mahara/htdocs/lib/mahara.php:1813
  call_static_method("LeapImportPeerassessment", "import_using_strategy", 
object(SimpleXMLElement), object(PluginImportLeap), 1, array(size 0)) at 
/home/kristina/code/mahara/htdocs/import/leap/lib.php:665
  PluginImportLeap->import_from_load_mapping() at 
/home/kristina/code/mahara/htdocs/import/leap/lib.php:188
  PluginImportLeap->process() at 
/home/kristina/code/mahara/htdocs/admin/users/add.php:348
  adduser_submit(object(Pieform), array(size 24)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:542
  Pieform->__construct(array(size 8)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:164
  Pieform::process(array(size 8)) at 
/home/kristina/code/mahara/htdocs/lib/mahara.php:5258
  pieform(array(size 8)) at 
/home/kristina/code/mahara/htdocs/admin/users/add.php:156

  [WAR] 37 (lib/errors.php:858) Failed to get a recordset: postgres8 error: 
[-1: ERROR:  null value in column "block" violates not-null constraint
  DETAIL:  Failing row contains (22, null, null, 11, 0).] in adodb_throw(INSERT 
INTO "artefact_peer_assessment" ("assessment", "view", "private") VALUES (?, ?, 
?), Array)Command was: INSERT INTO "artefact_peer_assessment" ("assessment", 
"view", "private") VALUES (?, ?, ?) and values was 
(assessment:22,view:11,private:0)
  Call stack (most recent first):

  log_message("Failed to get a recordset: postgres8 error: [-1: E...", 8, 
true, true) at /home/kristina/code/mahara/htdocs/lib/errors.php:95
  log_warn("Failed to get a 

[Mahara-contributors] [Bug 1788303] [NEW] logs Filling with error after upgrade

2018-08-21 Thread Kevin Dibble
Public bug reported:

Mahara 18.04.2 (Upgraded)

Mahara 17.04.2 Upgrading to 18.04.2
Brower: chrome
OS: Unbutu
PHP: 7.0

Logs on server filling up with this message:
[21-Aug-2018 16:18:56 Pacific/Auckland] [WAR] b1 (lib/mahara.php:2047) 
Undefined index: onview
  
etc


The 'on view' in the $logdata array has not been set when called at line 2047
Perhaps change to:
$commenttypeid = isset($logdata['onview'])? $logdata['onview'] : 0;
would resolve (unless this is a deeper logging issue) 


Code seems to be around when older versions of Mahara get upgraded:

lib/mahara.php:2047 
// Include the old time column as well to cater for
// older versions of Mahara getting upgraded.
// Their event_log table will have not gone
// through the table alters during this
// part of the upgrade.
// The date it changed was 2017090800.
$logentry->time = $logentry->ctime;

// find out who 'owns' the event
list ($ownerid, $ownertype) = event_find_owner_type($logentry);
$logentry->ownerid = $ownerid;
$logentry->ownertype = $ownertype;
insert_record('event_log', $logentry);
// If we are adding a comment to a page that is shared to a group
// we need to add a 'sharedcommenttogroup' event
if ($reftype == 'comment' && empty($logdata['group'])) {
if (!empty($logdata['onartefact'])) {
$commenttype = 'artefact';
$commenttypeid = $logdata['onartefact'];
$wheresql = " IN (SELECT view FROM {view_artefact} WHERE " . 
$commenttype . " = ?) ";
}
else {
$commenttype = 'view';
$commenttypeid = $logdata['onview'];
$wheresql = " = ? ";
}
if ($groupids = get_records_sql_array("SELECT \"group\" FROM 
{view_access}
WHERE view " . $wheresql . "
AND \"group\" IS NOT NULL", 
array($commenttypeid))) {
foreach ($groupids as $groupid) {
$logentry->event = 'sharedcommenttogroup';
$logentry->data = null;
$logentry->ownerid = $groupid->group;
$logentry->ownertype = 'group';
insert_record('event_log', $logentry);
}
}
}

** Affects: mahara
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1788303

Title:
  logs Filling with error after upgrade

Status in Mahara:
  New

Bug description:
  Mahara 18.04.2 (Upgraded)

  Mahara 17.04.2 Upgrading to 18.04.2
  Brower: chrome
  OS: Unbutu
  PHP: 7.0

  Logs on server filling up with this message:
  [21-Aug-2018 16:18:56 Pacific/Auckland] [WAR] b1 (lib/mahara.php:2047) 
Undefined index: onview

  etc

  
  The 'on view' in the $logdata array has not been set when called at line 2047
  Perhaps change to:
  $commenttypeid = isset($logdata['onview'])? $logdata['onview'] : 0;
  would resolve (unless this is a deeper logging issue) 

  
  Code seems to be around when older versions of Mahara get upgraded:

  lib/mahara.php:2047 
  // Include the old time column as well to cater for
  // older versions of Mahara getting upgraded.
  // Their event_log table will have not gone
  // through the table alters during this
  // part of the upgrade.
  // The date it changed was 2017090800.
  $logentry->time = $logentry->ctime;

  // find out who 'owns' the event
  list ($ownerid, $ownertype) = event_find_owner_type($logentry);
  $logentry->ownerid = $ownerid;
  $logentry->ownertype = $ownertype;
  insert_record('event_log', $logentry);
  // If we are adding a comment to a page that is shared to a group
  // we need to add a 'sharedcommenttogroup' event
  if ($reftype == 'comment' && empty($logdata['group'])) {
  if (!empty($logdata['onartefact'])) {
  $commenttype = 'artefact';
  $commenttypeid = $logdata['onartefact'];
  $wheresql = " IN (SELECT view FROM {view_artefact} WHERE " . 
$commenttype . " = ?) ";
  }
  else {
  $commenttype = 'view';
  $commenttypeid = $logdata['onview'];
  $wheresql = " = ? ";
  }
  if ($groupids = get_records_sql_array("SELECT \"group\" FROM 
{view_access}
  WHERE view " . $wheresql . "
  AND \"group\" IS NOT NULL", 

[Mahara-contributors] [Bug 1788300] [NEW] Group Collections Cannot be Copied

2018-08-21 Thread Kevin Dibble
Public bug reported:

Mahara 17.04.2  MySQL PHP 7.1   (OS - Linux (ubuntu))
Mahara 17.10.3  MySQL PHP 7.1   (OS - Linux (ubuntu))
Mahara 18.04.2  MySQL PHP 7.0   (OS - Linux (ubuntu))
Mahara 18.04.3  MySQL PHP 7.0   (OS - MAC)
Mahara Master Branch MySQL PHP 7.0  (OS - Linux (ubuntu))
Browser: Chrome / Firefox / Safari

Mahara 17.04.2
Collections created by the group are not shared.
1.  Create a Group page
2.  Create two pages in the group page
3.  Create a collection and add the pages
4.  Share the pages in the collection and allow copying
5.  On the group main page only the individual pages can be copied - the 
collections are not visible

Mahara 17.10.3 and Mahara 18.04.2 Have the same behavior:
Steps to reproduce:
1.  Create a Group page
2.  Create two pages in the group page
3.  Create a collection and add the pages
4.  Share the pages in the collection and allow copying
Note: The individual pages to copy are no longer present - just the 
collection link
5.  On the group main page - click Copy to copy the collection
6.  Expected result: The collection is copied
Actual Result: Page not found

Mahara 18.04.03 and Mahara Master Branch
Steps to reproduce:
1.  Create a Group page
2.  Create two pages in the group page
3.  Create a collection and add the pages
4.  Share the pages in the collection and allow copying
Note: The individual pages to copy are no longer present - just the 
collection link
5.  On the Group main page - click Copy to copy the collection
6.  Expected result: The collection is copied
Actual Result: PROFILE PAGE IS COPIED INSTEAD

** Affects: mahara
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1788300

Title:
  Group Collections Cannot be Copied

Status in Mahara:
  New

Bug description:
  Mahara 17.04.2  MySQL PHP 7.1   (OS - Linux (ubuntu))
  Mahara 17.10.3  MySQL PHP 7.1   (OS - Linux (ubuntu))
  Mahara 18.04.2  MySQL PHP 7.0   (OS - Linux (ubuntu))
  Mahara 18.04.3  MySQL PHP 7.0   (OS - MAC)
  Mahara Master Branch MySQL PHP 7.0  (OS - Linux (ubuntu))
  Browser: Chrome / Firefox / Safari

  Mahara 17.04.2
  Collections created by the group are not shared.
  1.  Create a Group page
  2.  Create two pages in the group page
  3.  Create a collection and add the pages
  4.  Share the pages in the collection and allow copying
  5.  On the group main page only the individual pages can be copied - the 
collections are not visible

  Mahara 17.10.3 and Mahara 18.04.2 Have the same behavior:
  Steps to reproduce:
  1.  Create a Group page
  2.  Create two pages in the group page
  3.  Create a collection and add the pages
  4.  Share the pages in the collection and allow copying
  Note: The individual pages to copy are no longer present - just the 
collection link
  5.  On the group main page - click Copy to copy the collection
  6.  Expected result: The collection is copied
  Actual Result: Page not found

  Mahara 18.04.03 and Mahara Master Branch
  Steps to reproduce:
  1.  Create a Group page
  2.  Create two pages in the group page
  3.  Create a collection and add the pages
  4.  Share the pages in the collection and allow copying
  Note: The individual pages to copy are no longer present - just the 
collection link
  5.  On the Group main page - click Copy to copy the collection
  6.  Expected result: The collection is copied
  Actual Result: PROFILE PAGE IS COPIED INSTEAD

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1788300/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1781844] Re: When pages are shared - users can delete blocks by accident

2018-07-29 Thread Kevin Dibble
Hi Mahara team, 
The commit has been created in Gerrit on its own branch for review:
https://reviews.mahara.org/#/c/9033/

Note:
If the Mac version of "xargs" is being run, this error will appear:
xargs: illegal option -- -

If "sed" on a mac is being run, this error will appear:
sed: illegal option -- r

Linux Sed and xargs are not the same as Mac ones... (silent moan into the void)
Commands for "sed" and "xargs" require that homebrew be installed and these 
commands be run:

brew install gnu-sed --with-default-names  (on a mac - sed is called
gsed, the --with-default-names option will make it run as "sed" as per
the makefile call)

brew install findutils --with-default-names (or brew reinstall findutils
--with-default-names) as the default xargs on a mac runs differently to
linux, and hombrew will install the "linux" version as gxargs - the
option --with-default-names will make it behave.

These little tips could be be added to the 
https://wiki.mahara.org/wiki/Developer_Area/Contributing_Code 
for those that code on mac.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1781844

Title:
  When pages are shared - users can delete blocks by accident

Status in Mahara:
  In Progress

Bug description:
  Mahara 18.04.02
  DB: Mysql
  OS: Ubuntu
  Browser: Chrome

  A lot of users in Mahara create (Template) pages to share out to
  users. This reduces the setup a new user will have to do to. There is
  an issue that on their personal copy, the blocks that were so
  carefully setup can be deleted.

  This patch creates a new column in the database called "lockblocks"
  that can be enabled/disabled on the share page.

  When the user copies the page, this setting is copied over and the
  "delete" icon is hidden from view should the lockblocks setting be
  enabled.

  To unset - the user can open the advanced options in the shared area
  and disable the lock blocks feature to enable the deletion of the
  blocks as per normal.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1781844/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1781844] Re: When pages are shared - users can delete blocks by accident

2018-07-29 Thread Kevin Dibble
Master branch patch - tested.

Still having issues updating via gerrit, will get these sorted. 
This is the patch based on the Mahara Master Branch.

** Patch added: "Master_patch.diff"
   
https://bugs.launchpad.net/mahara/+bug/1781844/+attachment/5169278/+files/Master_patch.diff

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1781844

Title:
  When pages are shared - users can delete blocks by accident

Status in Mahara:
  In Progress

Bug description:
  Mahara 18.04.02
  DB: Mysql
  OS: Ubuntu
  Browser: Chrome

  A lot of users in Mahara create (Template) pages to share out to
  users. This reduces the setup a new user will have to do to. There is
  an issue that on their personal copy, the blocks that were so
  carefully setup can be deleted.

  This patch creates a new column in the database called "lockblocks"
  that can be enabled/disabled on the share page.

  When the user copies the page, this setting is copied over and the
  "delete" icon is hidden from view should the lockblocks setting be
  enabled.

  To unset - the user can open the advanced options in the shared area
  and disable the lock blocks feature to enable the deletion of the
  blocks as per normal.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1781844/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1781844] Re: When pages are shared - users can delete blocks by accident

2018-07-25 Thread Kevin Dibble
Hi Kristina,

Attached is an updated patch with the bugs addressed and the working/ wording 
updated.
The settings area now features the lockblocks setting
Copying collections will respect the lockblock setting
Setting the lock block share for a collection will update all pages in the 
collection.

** Patch added: "Upgraded_lockblock_patch.diff"
   
https://bugs.launchpad.net/mahara/+bug/1781844/+attachment/5167925/+files/Upgraded_lockblock_patch.diff

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1781844

Title:
  When pages are shared - users can delete blocks by accident

Status in Mahara:
  In Progress

Bug description:
  Mahara 18.04.02
  DB: Mysql
  OS: Ubuntu
  Browser: Chrome

  A lot of users in Mahara create (Template) pages to share out to
  users. This reduces the setup a new user will have to do to. There is
  an issue that on their personal copy, the blocks that were so
  carefully setup can be deleted.

  This patch creates a new column in the database called "lockblocks"
  that can be enabled/disabled on the share page.

  When the user copies the page, this setting is copied over and the
  "delete" icon is hidden from view should the lockblocks setting be
  enabled.

  To unset - the user can open the advanced options in the shared area
  and disable the lock blocks feature to enable the deletion of the
  blocks as per normal.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1781844/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1781844] [NEW] When pages are shared - users can delete blocks by accident

2018-07-15 Thread Kevin Dibble
Public bug reported:

Mahara 18.04.02
DB: Mysql
OS: Ubuntu
Browser: Chrome

A lot of users in Mahara create (Template) pages to share out to users.
This reduces the setup a new user will have to do to. There is an issue
that on their personal copy, the blocks that were so carefully setup can
be deleted.

This patch creates a new column in the database called "lockblocks" that
can be enabled/disabled on the share page.

When the user copies the page, this setting is copied over and the
"delete" icon is hidden from view should the lockblocks setting be
enabled.

To unset - the user can open the advanced options in the shared area and
disable the lock blocks feature to enable the deletion of the blocks as
per normal.

** Affects: mahara
 Importance: Undecided
 Status: New


** Tags: blocks locking

** Patch added: "Mahara 18.04.02 Patch"
   https://bugs.launchpad.net/bugs/1781844/+attachment/5164006/+files/patch.diff

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1781844

Title:
  When pages are shared - users can delete blocks by accident

Status in Mahara:
  New

Bug description:
  Mahara 18.04.02
  DB: Mysql
  OS: Ubuntu
  Browser: Chrome

  A lot of users in Mahara create (Template) pages to share out to
  users. This reduces the setup a new user will have to do to. There is
  an issue that on their personal copy, the blocks that were so
  carefully setup can be deleted.

  This patch creates a new column in the database called "lockblocks"
  that can be enabled/disabled on the share page.

  When the user copies the page, this setting is copied over and the
  "delete" icon is hidden from view should the lockblocks setting be
  enabled.

  To unset - the user can open the advanced options in the shared area
  and disable the lock blocks feature to enable the deletion of the
  blocks as per normal.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1781844/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1763517] Re: Comments can't be deleted when work is submitted for marking

2018-04-16 Thread Kevin Dibble
Thanks Kristina,

My email address is: kevin.dib...@learningworks.co.nz

Cheers team,

Kevin

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1763517

Title:
  Comments can't be deleted when work is submitted for marking

Status in Mahara:
  In Progress

Bug description:
  Version:  Mahara 18.04.0
  Os: Mac
  Database: mysql
  Browser: chrome: Version 65.0.3325.181 (Official Build) (64-bit)

  Issue:
  When work is submitted for Marking, all comments and feedback during the 
marking process can be deleted by the user.

  Possible solution:
  While work is locked, to hide the delete comment form for annotation comments 
(Smart evidence feedback) and to check if work is in a submitted state before 
deleting page comments.

  Users can still show/hide comments from public as needed. Creators of
  comments can still edit them (during the edit timeframe), but will not
  be able to delete them while the page is under review.

  Attached is a patch with this possible solution.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1763517/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1763517] [NEW] Can delete markers comments when work is submitted for marking

2018-04-12 Thread Kevin Dibble
Public bug reported:

Version:  Mahara 18.04.0
Os: Mac
Database: mysql
Browser: chrome: Version 65.0.3325.181 (Official Build) (64-bit)

Issue:
When work is submitted for Marking, all comments and feedback during the 
marking process can be deleted by the user.

Possible solution:
While work is locked, to hide the delete comment form for annotation comments 
(Smart evidence feedback) and to check if work is in a submitted state before 
deleting page comments.

Users can still show/hide comments from public as needed. Creators of
comments can still edit them (during the edit timeframe), but will not
be able to delete them while the page is under review.

Attached is a patch with this possible solution.

** Affects: mahara
 Importance: Undecided
 Status: New

** Patch added: "comments_patch.diff"
   
https://bugs.launchpad.net/bugs/1763517/+attachment/5112908/+files/comments_patch.diff

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1763517

Title:
  Can delete markers comments when work is submitted for marking

Status in Mahara:
  New

Bug description:
  Version:  Mahara 18.04.0
  Os: Mac
  Database: mysql
  Browser: chrome: Version 65.0.3325.181 (Official Build) (64-bit)

  Issue:
  When work is submitted for Marking, all comments and feedback during the 
marking process can be deleted by the user.

  Possible solution:
  While work is locked, to hide the delete comment form for annotation comments 
(Smart evidence feedback) and to check if work is in a submitted state before 
deleting page comments.

  Users can still show/hide comments from public as needed. Creators of
  comments can still edit them (during the edit timeframe), but will not
  be able to delete them while the page is under review.

  Attached is a patch with this possible solution.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1763517/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1755331] Re: Cannot copy group pages when pagination is used

2018-03-27 Thread Kevin Dibble
Hi Kristina,

The patch works in creating pages from the group copy area when paginated into 
page 2 or higher.
This was tested locally on Mahara 17.10.3 version in:
php 7.0.16
php 7.1.2

cheers

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1755331

Title:
  Cannot copy group pages when pagination is used

Status in Mahara:
  Confirmed
Status in Mahara 17.04 series:
  Confirmed
Status in Mahara 17.10 series:
  Confirmed
Status in Mahara 18.04 series:
  Confirmed
Status in Mahara 18.10 series:
  In Progress

Bug description:
  Version: Mahara Version 17.10.0
  OS: Linux (Ubuntu)
  Database: MySQL
  Browser: Chrome

  Issue:
  Group pages are created that can be copied by group members

  Pages for users to copy that require they navigation to page 2 or higher of a 
shared list 
  (using the pagination at the bottom)
  Clicking Copy Reloads the page (the page is not copied)

  Page 1 is unaffected

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1755331/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1757330] [NEW] Export file Session Data not saved in PHP 7.1+

2018-03-20 Thread Kevin Dibble
Public bug reported:

Mahara 17.10.3 (alo occurs on Mahara 17.10.0)
Operating system: Ubuntu, apache2, PHP 7.1.8 (also occurs on PHP 7.1.15 and PHP 
7.1.3)
Database; MySQL
Browser: Chrome.

Exporting files in Mahara
/export/index.php

Export Either LEAP file or Standalone HTML
click Generate Export
in the iframe - the /export/download.php redirects back to the export/index.php 
file and nothing is downloaded - the progress iframe now shows the 
/export/index.php page.

Possible Cause:
Download.php (export/download.php) as this located at the bottom of the page (~ 
line 106)
$SESSION->set('exportfile', $exporter->get('exportdir') . $zipfile);

At the top of the page it checks to see if this session data exists - and if so 
- to force the download of the file.
line 17: 
if ($exportfile = $SESSION->get('exportfile')) {
$SESSION->set('exportdata', '');
$SESSION->set('exportfile', '');
require_once('file.php');
serve_file($exportfile, basename($exportfile), 'application/x-zip', 
array('lifetime' => 0, 'forcedownload' => true));
exit;
}

In PHP 7.1.3 and higher - the $SESSION->get('exportfile') is empty when
the JS redirect calls this page (from the print_export_footer function)
and the session data set at the bottom of the page is not present when
the page is being loaded to get the file. (loading the /export/index.php
again will empty the exportfile data).

The export works as expected in PHP 7, but fails in PHP 7.1+.

Is Mahara 7.1+ ready?

** Affects: mahara
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1757330

Title:
  Export file Session Data not saved in PHP 7.1+

Status in Mahara:
  New

Bug description:
  Mahara 17.10.3 (alo occurs on Mahara 17.10.0)
  Operating system: Ubuntu, apache2, PHP 7.1.8 (also occurs on PHP 7.1.15 and 
PHP 7.1.3)
  Database; MySQL
  Browser: Chrome.

  Exporting files in Mahara
  /export/index.php

  Export Either LEAP file or Standalone HTML
  click Generate Export
  in the iframe - the /export/download.php redirects back to the 
export/index.php file and nothing is downloaded - the progress iframe now shows 
the /export/index.php page.

  Possible Cause:
  Download.php (export/download.php) as this located at the bottom of the page 
(~ line 106)
  $SESSION->set('exportfile', $exporter->get('exportdir') . $zipfile);

  At the top of the page it checks to see if this session data exists - and if 
so - to force the download of the file.
  line 17: 
  if ($exportfile = $SESSION->get('exportfile')) {
  $SESSION->set('exportdata', '');
  $SESSION->set('exportfile', '');
  require_once('file.php');
  serve_file($exportfile, basename($exportfile), 'application/x-zip', 
array('lifetime' => 0, 'forcedownload' => true));
  exit;
  }

  In PHP 7.1.3 and higher - the $SESSION->get('exportfile') is empty
  when the JS redirect calls this page (from the print_export_footer
  function) and the session data set at the bottom of the page is not
  present when the page is being loaded to get the file. (loading the
  /export/index.php again will empty the exportfile data).

  The export works as expected in PHP 7, but fails in PHP 7.1+.

  Is Mahara 7.1+ ready?

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1757330/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1755331] [NEW] Cannot copy group pages when pagination is used

2018-03-12 Thread Kevin Dibble
Public bug reported:

Version: Mahara Version 17.10.0
OS: Linux (Ubuntu)
Database: MySQL
Browser: Chrome

Issue:
Group pages are created that can be copied by group members

Pages for users to copy that require they navigation to page 2 or higher of a 
shared list 
(using the pagination at the bottom)
Clicking Copy Reloads the page (the page is not copied)

Page 1 is unaffected

** Affects: mahara
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1755331

Title:
  Cannot copy group pages when pagination is used

Status in Mahara:
  New

Bug description:
  Version: Mahara Version 17.10.0
  OS: Linux (Ubuntu)
  Database: MySQL
  Browser: Chrome

  Issue:
  Group pages are created that can be copied by group members

  Pages for users to copy that require they navigation to page 2 or higher of a 
shared list 
  (using the pagination at the bottom)
  Clicking Copy Reloads the page (the page is not copied)

  Page 1 is unaffected

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1755331/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1749834] [NEW] Not showing username to users when "never display usernames" is set to no

2018-02-15 Thread Kevin Dibble
Public bug reported:

Operating system: Linux
PHP: 7
Mahara: 17.04.2
Database: MySQL
Browser: Chrome

Site config setting in Question:
Changed "Never show usernames" to "no" for site config

Expectaiton:
Users can now see usernames for other users

Actual Result:
Username does not appear when searching for users to share a page with (It only 
appears to admins and staff) 
The setting for this on the config page is that changing this setting does not 
affect admin and staff (which is true), however regardless of this setting - 
users cannot see a username appear in search areas when sharing portfolio items.

Possible Reason:
Searchlib.php Function search_user calls "display_name($result)" (located in 
lib/user.php)

User.php line 1125 - display_name takes 5 params - the last one of which
is $username which is set to false by default.

Lines 1134: 
$nousernames = get_config('nousernames');
$userto = get_user_for_display($userto);
$user   = get_user_for_display($user);

$addusername = ($username && empty($nousernames)) ||
!empty($userto->admin) || !empty($userto->staff);

As username is set to false when calling this function from a search,
the net result for normal users $addusername is always false.

Cheers

Kevin

** Affects: mahara
 Importance: Undecided
 Status: New


** Tags: search username

** Patch added: "user.php"
   https://bugs.launchpad.net/bugs/1749834/+attachment/5056180/+files/user.php

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1749834

Title:
  Not showing username to users when "never display usernames" is set to
  no

Status in Mahara:
  New

Bug description:
  Operating system: Linux
  PHP: 7
  Mahara: 17.04.2
  Database: MySQL
  Browser: Chrome

  Site config setting in Question:
  Changed "Never show usernames" to "no" for site config

  Expectaiton:
  Users can now see usernames for other users

  Actual Result:
  Username does not appear when searching for users to share a page with (It 
only appears to admins and staff) 
  The setting for this on the config page is that changing this setting does 
not affect admin and staff (which is true), however regardless of this setting 
- users cannot see a username appear in search areas when sharing portfolio 
items.

  Possible Reason:
  Searchlib.php Function search_user calls "display_name($result)" (located in 
lib/user.php)

  User.php line 1125 - display_name takes 5 params - the last one of
  which is $username which is set to false by default.

  Lines 1134: 
  $nousernames = get_config('nousernames');
  $userto = get_user_for_display($userto);
  $user   = get_user_for_display($user);

  $addusername = ($username && empty($nousernames)) ||
  !empty($userto->admin) || !empty($userto->staff);

  As username is set to false when calling this function from a search,
  the net result for normal users $addusername is always false.

  Cheers

  Kevin

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1749834/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp