[Mahara-contributors] [Bug 1240042] Re: Deleting background image crashes skin
** Changed in: mahara Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1240042 Title: Deleting background image crashes skin Status in Mahara ePortfolio: Fix Released Bug description: I was testing the new skins feature on Mahara Dev site and found that if I added an image to the skin for background, then later deleted the image from my file repository (I was switching to a different image), the skin becomes unavailable to re-edit because it couldn't find the original image - I had to delete the skin and start again from scratch. What I would expect to happen is that if a skin / theme image is deleted it should switch to the default (no image) or simply display an empty placeholder block to show that there was supposed to be an image file. Being locked out if the image is deleted from the backend makes this a nasty learning experience with the new feature! Regards, Gordon. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1240042/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1240042] Re: Deleting background image crashes skin
Hi Gordon, Thank you for testing out the skins feature in Mahara and thank you for submitting a skin on mahara.dev. Yes, there needs to be better handling of how skins behave if their background images are removed. I will try and make a patch to handle this scenario. Cheers Robert ** Changed in: mahara Importance: Undecided = Critical ** Changed in: mahara Status: New = In Progress ** Changed in: mahara Assignee: (unassigned) = Robert Lyon (robertl-9) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1240042 Title: Deleting background image crashes skin Status in Mahara ePortfolio: In Progress Bug description: I was testing the new skins feature on Mahara Dev site and found that if I added an image to the skin for background, then later deleted the image from my file repository (I was switching to a different image), the skin becomes unavailable to re-edit because it couldn't find the original image - I had to delete the skin and start again from scratch. What I would expect to happen is that if a skin / theme image is deleted it should switch to the default (no image) or simply display an empty placeholder block to show that there was supposed to be an image file. Being locked out if the image is deleted from the backend makes this a nasty learning experience with the new feature! Regards, Gordon. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1240042/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1240042] Re: Deleting background image crashes skin
I have added a patch for this problem: https://reviews.mahara.org/#/c/2613/ It checks to see if artefact actually exists before adding it to artefact chooser. if it doesn't exist anymore then ignores the value. On editing the skin and saving again the thumb image will be updated correctly. ** Changed in: mahara Milestone: None = 1.8.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1240042 Title: Deleting background image crashes skin Status in Mahara ePortfolio: In Progress Bug description: I was testing the new skins feature on Mahara Dev site and found that if I added an image to the skin for background, then later deleted the image from my file repository (I was switching to a different image), the skin becomes unavailable to re-edit because it couldn't find the original image - I had to delete the skin and start again from scratch. What I would expect to happen is that if a skin / theme image is deleted it should switch to the default (no image) or simply display an empty placeholder block to show that there was supposed to be an image file. Being locked out if the image is deleted from the backend makes this a nasty learning experience with the new feature! Regards, Gordon. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1240042/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1240042] Re: Deleting background image crashes skin
There is another bug here https://bugs.launchpad.net/mahara/+bug/1240244 looking into making this more robust by alerting a user before they delete the image that it is being used in a skin -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1240042 Title: Deleting background image crashes skin Status in Mahara ePortfolio: In Progress Bug description: I was testing the new skins feature on Mahara Dev site and found that if I added an image to the skin for background, then later deleted the image from my file repository (I was switching to a different image), the skin becomes unavailable to re-edit because it couldn't find the original image - I had to delete the skin and start again from scratch. What I would expect to happen is that if a skin / theme image is deleted it should switch to the default (no image) or simply display an empty placeholder block to show that there was supposed to be an image file. Being locked out if the image is deleted from the backend makes this a nasty learning experience with the new feature! Regards, Gordon. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1240042/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1240042] Re: Deleting background image crashes skin
** Changed in: mahara Status: In Progress = Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1240042 Title: Deleting background image crashes skin Status in Mahara ePortfolio: Fix Committed Bug description: I was testing the new skins feature on Mahara Dev site and found that if I added an image to the skin for background, then later deleted the image from my file repository (I was switching to a different image), the skin becomes unavailable to re-edit because it couldn't find the original image - I had to delete the skin and start again from scratch. What I would expect to happen is that if a skin / theme image is deleted it should switch to the default (no image) or simply display an empty placeholder block to show that there was supposed to be an image file. Being locked out if the image is deleted from the backend makes this a nasty learning experience with the new feature! Regards, Gordon. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1240042/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
