[Mahara-contributors] [Bug 1758181] Re: Extra div field when comments are turned off on page or artefact details page

2018-04-05 Thread Kristina Hoeppner
** Changed in: mahara
 Assignee: (unassigned) => Sarah Kirby (sarahkirby)

** Changed in: mahara
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1758181

Title:
  Extra div field when comments are turned off on page or artefact
  details page

Status in Mahara:
  In Progress

Bug description:
  Environment tested: Master
  Browser tested: MS Edge (Virtualbox)

  ===
  Manual Test Script
  ===

  1) user has a portfolio page with one resume field block that is set to 
retract on it 
  2) user views Page displayed 
  3) user clicks the details link just below the one resume field block
  4) user is redirected to a page only showing the one resume field block

  Actual result: Page is displayed with the one resume field block and
  is retracted.✔ Just under the block area is a very light grey
  background section on the page ✘

  
  Expected result: Light grey background section should not be displayed 
because this artefact cannot have a comment.

  NOTE: 
  - this also happens when you have a page that does not allow comments. (could 
be any page without comments)
  - this is visible in themes that have a background for the comment area 

  Catalyst QA

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1758181/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1742349] Re: External(Kaltura) video doesn't play when block is on auto-retract

2018-04-05 Thread Kristina Hoeppner
** Changed in: mahara
   Status: Confirmed => In Progress

** Changed in: mahara
Milestone: None => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1742349

Title:
  External(Kaltura) video doesn't play when block is on auto-retract

Status in Mahara:
  In Progress

Bug description:
  
  Hi,
  This one is similar to bug report - Bug #1565669
  Embedded Kaltura video in Mahara not displaying when the setting retractable 
is set to Automatically retract.
  The video will play when set to Retractable=Yes or Retractable=No.

  This one is similar to bug report - Bug #1565669

  
  Example Embed:
  https://cdnapisec.kaltura.com/p/2246991/sp/224699100/embedIframeJs/uiconf_id/38197461/partner_id/2246991?iframeembed=true&playerId=kaltura_player&entry_id=0_t2juqhe6&flashvars[streamerType]=auto&flashvars[localizationCode]=en&flashvars[leadWithHTML5]=true&flashvars[sideBarContainer.plugin]=true&flashvars[sideBarContainer.position]=left&flashvars[sideBarContainer.clickToClose]=true&flashvars[chapters.plugin]=true&flashvars[chapters.layout]=vertical&flashvars[chapters.thumbnailRotator]=false&flashvars[streamSelector.plugin]=true&flashvars[EmbedPlayer.SpinnerTarget]=videoHolder&flashvars[dualScreen.plugin]=true&&wid=0_lp5uyok9";
 width="400" height="285" allowfullscreen webkitallowfullscreen 
mozAllowFullScreen frameborder="0" title="Kaltura Player">

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1742349/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1760737] Re: simplesaml upgrade causes ext-pdo_sqlite error

2018-04-05 Thread Kristina Hoeppner
** Tags added: bite-sized

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1760737

Title:
  simplesaml upgrade causes ext-pdo_sqlite error

Status in Mahara:
  Confirmed

Bug description:
  Steps to reproduce:
  Upgrade to 18.04
  Go to admin -> extensions -> plugin administration
  Click on saml settings.
  You see an error message that you need to run make ssphp to upgrade saml.

  running make ssphp causes the following error:
  Your requirements could not be resolved to an installable set of packages.

Problem 1
  - The requested PHP extension ext-pdo_sqlite * is missing from your 
system. Install or enable PHP's pdo_sqlite extension.

  
  Installation failed, reverting ./composer.json to its original content.
  Makefile:64: recipe for target 'ssphp' failed
  make: *** [ssphp] Error 2

  apt-get install fails to find a package called any of the following:
  ext-pdo_sqlite
  php ext-pdo_sqlite
  php pdo_sqlite
  pdo_sqlite
  php7.0-ext-pdo_sqlite
  php7.0-pdo_sqlite

  On further investigation, it appears the Makefile is installing
  simplesaml with it's composer requirements, so perhaps this extension
  should not be included in the requirements.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1760737/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1761329] Re: behat test for user registration

2018-04-05 Thread Kristina Hoeppner
** Tags added: behat

** Changed in: mahara
   Status: New => Confirmed

** Changed in: mahara
   Importance: Undecided => Medium

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1761329

Title:
  behat test for user registration

Status in Mahara:
  Confirmed

Bug description:
  Update Existing Behat feature file
  
  Behat test: Settings > register_configuration.feature already exists - need 
to update behat test to include the following:

  # Check for conformation message
  Then I should be on "/register.php"

  And I should see "You have successfully submitted your application for
  registration. The institution administrator has been notified, and you
  will receive an email as soon as your application has been processed."

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1761329/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1759078] Re: User view page social media icons not displaying correctly on Tablet devices

2018-04-05 Thread Kristina Hoeppner
** Changed in: mahara
Milestone: 18.10.0 => None

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1759078

Title:
  User view page social media icons not displaying correctly on Tablet
  devices

Status in Mahara:
  Invalid

Bug description:
  Environment tested: Master
  Browser tested: 
  --- Samsung Galaxy tab 2 (real device)
  --- Surface pro Edge (real device)

  ===
  Manual Test Script
  ===

  Preconditions: 
  1) user has social media added to their profile 
  2) user has social media block added to their "User view" page 

  Steps to recreate:
  1) user logged in 
  2) user browse to User menu > 

  Actual result: Social media block contains incorrectly displayed
  social media icons and the link - see attached screen shot for details

  Expected result: social media icons are displayed like little buttons
  that link to their respective social media page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1759078/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1744797] Re: SAML plugin not working correctly with SimpleSamlPhp 1.15

2018-04-05 Thread Robert Lyon
Hi Yaju, what is set for your 'baseurlpath' in
htdocs/auth/saml/config/config.php ?

The default setting is:
 'baseurlpath'   => get_config('wwwroot') . 'auth/saml/sp/'

Is yours set to something else?

If so you can adjust your version of Makefile to suit

Cheers
Robert

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1744797

Title:
  SAML plugin not working correctly with SimpleSamlPhp 1.15

Status in Mahara:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released
Status in Mahara 17.04 series:
  Fix Released
Status in Mahara 17.10 series:
  Fix Released
Status in Mahara 18.04 series:
  Fix Committed

Bug description:
  There are couple of problems

  1) Plugin stop working and shows this error
   [SimpleSAML_Error_UnserializableException]: [ARRAY]: The option 'Format' is 
not a valid string value

  We used to set 'NameIDPolicy' to NULL, but we just need to not set
  this option any more

  2) The POST redirect to the IdP requires a special post.js file that
  exists in the extlib 'resources' section - we need to copy this to our
  sp section so the file can be accessed

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1744797/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1744789] A change has been merged

2018-04-05 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8784
Committed: 
https://git.mahara.org/mahara/mahara/commit/8a8b21e4014137680da34d00af76c608c3f8b222
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:18.04_STABLE

commit 8a8b21e4014137680da34d00af76c608c3f8b222
Author: Robert Lyon 
Date:   Thu Jan 18 10:43:37 2018 +1300

Security Bug 1744789: Remove bad code from wallpost post

We currently escape post content before submission
But we also need to do cleaning on php side incase hacker posts directly

Also needing to clean up annotations with bad html in their
descriptions and resume composite fields with bad html in their
descriptions

behatnotneeded

Change-Id: I8c7def1acad7b6692a96b2ba065c23abcd69cfb5
Signed-off-by: Robert Lyon 
(cherry picked from commit cff112250a5710b7a897e0f392a429cd29779ecc)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1744789

Title:
  Avoid relying on TinyMCE code stipping alone

Status in Mahara:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  TinyMCE will strip bad strings from input, eg 

[Mahara-contributors] [Bug 1744789] A change has been merged

2018-04-05 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8786
Committed: 
https://git.mahara.org/mahara/mahara/commit/4037f9bf730cfb995b89db11fe93d83b06bf6fc8
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:17.04_STABLE

commit 4037f9bf730cfb995b89db11fe93d83b06bf6fc8
Author: Robert Lyon 
Date:   Thu Jan 18 10:43:37 2018 +1300

Security Bug 1744789: Remove bad code from wallpost post

We currently escape post content before submission
But we also need to do cleaning on php side incase hacker posts directly

Also needing to clean up annotations with bad html in their
descriptions and resume composite fields with bad html in their
descriptions

behatnotneeded

Change-Id: I8c7def1acad7b6692a96b2ba065c23abcd69cfb5
Signed-off-by: Robert Lyon 
(cherry picked from commit cff112250a5710b7a897e0f392a429cd29779ecc)
(cherry picked from commit 8a8b21e4014137680da34d00af76c608c3f8b222)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1744789

Title:
  Avoid relying on TinyMCE code stipping alone

Status in Mahara:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  TinyMCE will strip bad strings from input, eg 

[Mahara-contributors] [Bug 1744789] A patch has been submitted for review

2018-04-05 Thread Mahara Bot
Patch for "17.10_STABLE" branch: https://reviews.mahara.org/8785

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1744789

Title:
  Avoid relying on TinyMCE code stipping alone

Status in Mahara:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  TinyMCE will strip bad strings from input, eg 

[Mahara-contributors] [Bug 1744789] A change has been merged

2018-04-05 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8787
Committed: 
https://git.mahara.org/mahara/mahara/commit/b0bdbc78e23ae0b5905fa50c6faed5803fdba6f4
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.10_STABLE

commit b0bdbc78e23ae0b5905fa50c6faed5803fdba6f4
Author: Robert Lyon 
Date:   Thu Jan 18 10:43:37 2018 +1300

Security Bug 1744789: Remove bad code from wallpost post

We currently escape post content before submission
But we also need to do cleaning on php side incase hacker posts directly

Also needing to clean up annotations with bad html in their
descriptions and resume composite fields with bad html in their
descriptions

behatnotneeded

Change-Id: I8c7def1acad7b6692a96b2ba065c23abcd69cfb5
Signed-off-by: Robert Lyon 
(cherry picked from commit cff112250a5710b7a897e0f392a429cd29779ecc)
(cherry picked from commit 8a8b21e4014137680da34d00af76c608c3f8b222)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1744789

Title:
  Avoid relying on TinyMCE code stipping alone

Status in Mahara:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  TinyMCE will strip bad strings from input, eg 

[Mahara-contributors] [Bug 1744789] A change has been merged

2018-04-05 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8785
Committed: 
https://git.mahara.org/mahara/mahara/commit/bc568169ba3fc7aae348fe8e4b190d1a3d691a74
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:17.10_STABLE

commit bc568169ba3fc7aae348fe8e4b190d1a3d691a74
Author: Robert Lyon 
Date:   Thu Jan 18 10:43:37 2018 +1300

Security Bug 1744789: Remove bad code from wallpost post

We currently escape post content before submission
But we also need to do cleaning on php side incase hacker posts directly

Also needing to clean up annotations with bad html in their
descriptions and resume composite fields with bad html in their
descriptions

behatnotneeded

Change-Id: I8c7def1acad7b6692a96b2ba065c23abcd69cfb5
Signed-off-by: Robert Lyon 
(cherry picked from commit cff112250a5710b7a897e0f392a429cd29779ecc)
(cherry picked from commit 8a8b21e4014137680da34d00af76c608c3f8b222)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1744789

Title:
  Avoid relying on TinyMCE code stipping alone

Status in Mahara:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  TinyMCE will strip bad strings from input, eg 

[Mahara-contributors] [Bug 1744789] A patch has been submitted for review

2018-04-05 Thread Mahara Bot
Patch for "16.10_STABLE" branch: https://reviews.mahara.org/8787

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1744789

Title:
  Avoid relying on TinyMCE code stipping alone

Status in Mahara:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  TinyMCE will strip bad strings from input, eg 

[Mahara-contributors] [Bug 1744789] A patch has been submitted for review

2018-04-05 Thread Mahara Bot
Patch for "17.04_STABLE" branch: https://reviews.mahara.org/8786

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1744789

Title:
  Avoid relying on TinyMCE code stipping alone

Status in Mahara:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  TinyMCE will strip bad strings from input, eg 

[Mahara-contributors] [Bug 1744789] Re: Avoid relying on TinyMCE code stipping alone

2018-04-05 Thread Robert Lyon
** Information type changed from Private Security to Public Security

** Changed in: mahara/18.04
   Status: In Progress => Fix Committed

** Changed in: mahara/17.10
   Status: Confirmed => Fix Committed

** Changed in: mahara/17.04
   Status: Confirmed => Fix Committed

** Changed in: mahara/16.10
   Status: Confirmed => Fix Committed

** Also affects: mahara/18.10
   Importance: Undecided
   Status: New

** Changed in: mahara/18.10
   Status: New => Fix Committed

** Changed in: mahara/18.10
   Importance: Undecided => High

** Changed in: mahara/18.10
Milestone: None => 18.10.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1744789

Title:
  Avoid relying on TinyMCE code stipping alone

Status in Mahara:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  TinyMCE will strip bad strings from input, eg 

[Mahara-contributors] [Bug 1749269] Re: Fixing for update user via webservices for 16.10

2018-04-05 Thread Cecilia Vela Gurovic
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1749269

Title:
  Fixing for update user via webservices for 16.10

Status in Mahara:
  Fix Released

Bug description:
  Originally we had a fix for this in Bug 1630764 - but the version that
  was merged for 17.04.0+ was different to the one merged in 16.10.

  The 17.04 version updated the profile info for 'firstname',
  'lastname', 'email', 'studentid', 'preferredname'

  Whereas the 16.10 version only updated the profile info for
  'studentid', 'preferredname'

  This bug is to fix up the 16.10 branch so it saves the profile info
  like 17.04+

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1749269/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1734194] Re: Infinite redirect loop caused by logged out user in usr_session table

2018-04-05 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1734194

Title:
  Infinite redirect loop caused by logged out user in usr_session table

Status in Mahara:
  Fix Released
Status in Mahara 16.10 series:
  Fix Released
Status in Mahara 17.04 series:
  Fix Released
Status in Mahara 17.10 series:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released

Bug description:
  The USER object contains the id of the user that is logged in and it
  matches up to the usr_session table so we know which session is
  matched to what user.

  When one is not logged in the USER object has id = 0

  If for some reason we end up with usr = 0 in the usr_session table we end up 
in an infinite loop
  because it tries to log out that dummy user but can't

  It should never end up in the usr_session table.

  So we need to do these things:
  1) When saving data to usr_session table never save if user id = 0, instead 
throw warning
  to avoid the problem

  2) When reading usr_session data in auth_setup() function to ignore fetching 
info for usr = 0
  to ignore bad data

  behatnotneeded

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1734194/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1732848] Re: images not displayed in shared page in tagged journal entries element

2018-04-05 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1732848

Title:
  images not displayed in shared page in tagged journal entries element

Status in Mahara:
  Fix Released
Status in Mahara 17.10 series:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released

Bug description:
  A journal entry with an inline image or an attachment is displayed on a page 
with a 'tagged journal entries' element.
  The page is shared with others (group or individual) and the images (or 
attachments) are not displayed to the share-e.
  Linked images (from another url) are displayed correctly.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1732848/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1726655] Re: Mahara logo is cut off at the bottom in IE 11

2018-04-05 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1726655

Title:
  Mahara logo is cut off at the bottom in IE 11

Status in Mahara:
  Fix Released
Status in Mahara 17.04 series:
  Fix Released
Status in Mahara 17.10 series:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released

Bug description:
  In IE the base of the Mahara logo is being hidden

  I believe it is due to the fact that the image has a height of 45px
  but the container it is in is floated and so lacks height.

  I tried adding 60px height to the containing  tag and it looked ok

  Will make a patch so people can test

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1726655/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1729423] Re: Can't choose which comment to make public

2018-04-05 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1729423

Title:
  Can't choose which comment to make public

Status in Mahara:
  Fix Released
Status in Mahara 17.04 series:
  Fix Released
Status in Mahara 17.10 series:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released

Bug description:
  I'm on 17.04.4

  There is multiple private comments on the same item(page or
  collections).

  Whenever i click on "make comment public" other than the first one,
  the first comment available on the page to be made public is made
  public or a request is sent if you're not allowed to. The "make
  comment public" appearing on each comment doesn't refer to the comment
  it is attached to but to the first comment with the link.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1729423/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1732328] Re: Interaction forum post indexer for elasticsearch is too short

2018-04-05 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1732328

Title:
  Interaction forum post indexer for elasticsearch is too short

Status in Mahara:
  Fix Released
Status in Mahara 17.10 series:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released

Bug description:
  It errors out when 'body' field length is longer than 32766 chars

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1732328/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1724415] Re: Compliance with EU GDPR privacy regulations

2018-04-05 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1724415

Title:
  Compliance with EU GDPR privacy regulations

Status in Mahara:
  Fix Released

Bug description:
  http://www.eugdpr.org/

  Stricter privacy will be enforced in May 2018 in the EU.

  We are going to look more closely into what is required in Mahara
  after the 17.10 release for Mahara 18.04.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1724415/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1731082] Re: internal media style.css missing from old_raw

2018-04-05 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1731082

Title:
  internal media style.css missing from old_raw

Status in Mahara:
  Fix Released
Status in Mahara 17.04 series:
  Fix Released
Status in Mahara 17.10 series:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released

Bug description:
  For 17.04, 17.10 and master

  need to place
  
htdocs/theme/raw/plugintype/artefact/file/blocktype/internalmedia/style/style.css

  in sass directory for raw and raw_old

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1731082/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1728473] Re: The page forgotpass.php should come with catcha feature to prevent abusing it

2018-04-05 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1728473

Title:
  The page forgotpass.php should come with catcha feature to prevent
  abusing it

Status in Mahara:
  Fix Released
Status in Mahara 16.10 series:
  Fix Released
Status in Mahara 17.04 series:
  Fix Released
Status in Mahara 17.10 series:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released

Bug description:
  Version: master

  Hi Maharians,

  In the page "Forgotten your username or password?", I would have a catcha 
form or similar feature to prevent the abuse.
  Also the error message should be generic such as "Sorry, invalid data." or 
"An email has been (will shortly be) sent to ... Please follow the instruction 
in it".

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1728473/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1732987] Re: Fix user input from direct get post usage

2018-04-05 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1732987

Title:
  Fix user input from direct get post usage

Status in Mahara:
  Fix Released
Status in Mahara 16.10 series:
  Fix Released
Status in Mahara 17.04 series:
  Fix Released
Status in Mahara 17.10 series:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released

Bug description:
  Makes sure the data is using valid utf8, invalid characters are discarded
  - avoid null chars and invalid unicode

  Also change direct $_GET and $_POST calls
  eg change
   isset($_POST['myparam']) to param_exists('myparam')
   $_POST['myparam'] = 'cats' to param_alpha('myparam', null)
  etc

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1732987/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1761037] Re: Installing a site doesn't update email correctly

2018-04-05 Thread Cecilia Vela Gurovic
** Changed in: mahara/16.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1761037

Title:
  Installing a site doesn't update email correctly

Status in Mahara:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  We added a bit of code that made sure that when we install a site it
  changes the admin email from ad...@example.org to the one supplied in
  all 3 places where we save email addresses - we save this directly to
  db.

  This is ok if we then log out before going to a place in Mahara where
  $USER->commit() is called

  But if we don't the $USER object still has ad...@example.org set so
  overwrites our change in the usr table.

  We need to commit this change via the USER object rather than update
  the usr table directly

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1761037/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1744797] Re: SAML plugin not working correctly with SimpleSamlPhp 1.15

2018-04-05 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1744797

Title:
  SAML plugin not working correctly with SimpleSamlPhp 1.15

Status in Mahara:
  Fix Released
Status in Mahara 16.10 series:
  Fix Released
Status in Mahara 17.04 series:
  Fix Released
Status in Mahara 17.10 series:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released

Bug description:
  There are couple of problems

  1) Plugin stop working and shows this error
   [SimpleSAML_Error_UnserializableException]: [ARRAY]: The option 'Format' is 
not a valid string value

  We used to set 'NameIDPolicy' to NULL, but we just need to not set
  this option any more

  2) The POST redirect to the IdP requires a special post.js file that
  exists in the extlib 'resources' section - we need to copy this to our
  sp section so the file can be accessed

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1744797/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1724603] Re: update_hierarchy_path in artefacts/lib.php hammers sql when copying collections

2018-04-05 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1724603

Title:
  update_hierarchy_path in artefacts/lib.php hammers sql when copying
  collections

Status in Mahara:
  Fix Released

Bug description:
  A teacher asked 40 students to copy a 15 page collection with numerous
  artefacts on each page, which crippled our mysql server.

  When testing it, even copying the collection once resulted in the web
  server timing out and raised the sql load incredibly.

  The code "update_hierarchy_path" in the artefact/lib.php on line 1423
  runs an sql query as below:

  `$sql = "UPDATE {artefact} SET path = ? || SUBSTR(path, ?) WHERE
  (path = ? OR path LIKE ? )";`

  The artefact table in Mahara does not index the `path` column, so
  whilst updating one artefact is not a major issue, but updating the
  path column for many artefacts hits the database massively.

  Indexing the path column (which is 1024 bytes) may not be a good
  solution long term, but either the query needs to be made more
  efficient or the column indexed.

  Mahara version 17.04_STABLE (updated about a month ago)
  Linux RHEL7
  MYSQL 5.6
  Browser is current chromium Version 61.0.3163.100 (but that is not relevant)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1724603/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1731330] Re: Delete button style/placement inconsistent

2018-04-05 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1731330

Title:
  Delete button style/placement inconsistent

Status in Mahara:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  For things that are editable/deletable we tend to have a convention of
  using a button group where the delete button is the right most button.

  But in some places we have the delete button the left button and or we
  don't use the button group

  Examples are:
  - Admin -> Institution list page
  - SmartEvidence list page

  We should tidy this up to be more consistent as that will help with
  User experience

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1731330/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1729140] Re: Configure icon only visible on hover in block config

2018-04-05 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1729140

Title:
  Configure icon only visible on hover in block config

Status in Mahara:
  Fix Released
Status in Mahara 17.10 series:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released

Bug description:
  Noticed this in Mahara 17.10 / master:

  When you are on the edit screen for a page that has the primary school
  theme, the configure icon is only shown on hover. It is white when not
  on hover (see screenshot).

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1729140/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1731067] Re: Some cron jobs cause elasticsearch queue to populate when it doesn't need to

2018-04-05 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1731067

Title:
  Some cron jobs cause elasticsearch queue to populate when it doesn't
  need to

Status in Mahara:
  Fix Released

Bug description:
  We only record certain information in elasticsearch but we queue
  things even if unrecorded information changes because we use
  triggers/procedures on the tables

  Example, when the recalculate_quota cron runs it works out what the
  user quota should be and then updates all the users in usr table that
  need fixing. This table has a trigger on it so all users needing
  updating are added to queue to be indexed.

  On a big site that can mean thousands of users being indexed. But we
  don't record quota in elasticsearch so we don't need to index this
  change.

  It would be good to be able to drop/add elasticsearch triggers during
  cron process for certain cron jobs like we do in upgrade.php script

  eg:
drop_elasticsearch_triggers();
... do cron job ...
create_elasticsearch_triggers();

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1731067/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1698251] Re: Improving gulp packages

2018-04-05 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1698251

Title:
  Improving gulp packages

Status in Mahara:
  Fix Released

Bug description:
  Update NPM packages in package.json, it was last updated in
  https://bugs.launchpad.net/mahara/+bug/1617143

  Investigate whether we still need blesscss, the reason that we added
  blesscss is because IE9 would only read up to certain number of
  selectors. Since we are officially support IE11+, we could possibly
  remove blesscss. If removal is sensible we can close
  https://bugs.launchpad.net/mahara/+bug/1560739 (?)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1698251/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1744789] Re: Avoid relying on TinyMCE code stipping alone

2018-04-05 Thread Cecilia Vela Gurovic
** Changed in: mahara/16.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1744789

Title:
  Avoid relying on TinyMCE code stipping alone

Status in Mahara:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  TinyMCE will strip bad strings from input, eg 

[Mahara-contributors] [Bug 1730497] Re: Missing stylesheet warning in notifications outbox

2018-04-05 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1730497

Title:
  Missing stylesheet warning in notifications outbox

Status in Mahara:
  Fix Released
Status in Mahara 17.10 series:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released

Bug description:
  When going to the outbox when not in production mode I see this error

   [DBG] f7 (lib/web.php:1278) Missing file in theme raw, plugindir
  module/multirecipientnotification: style.css

  This is a leftover mistake from Bug 1721623

  We need to remove the call to the removed stylesheet

  We also need to remove the stylesheet for raw_old as well as the
  styles are controlled by sass files now

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1730497/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1728815] Re: Upgrading from 15.10.2 to 17.10.0 causes unknown column 'i.logoxs' error

2018-04-05 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1728815

Title:
  Upgrading from 15.10.2 to 17.10.0 causes unknown column 'i.logoxs'
  error

Status in Mahara:
  Fix Released
Status in Mahara 17.10 series:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released

Bug description:
  Get the following error:
  [DBG] 39 (lib/db/upgrade.php:4229) Upgrade wall block and add wall 
notifications to default inbox block, referer: https://xyz.com
  [WAR] 39 (lib/errors.php:859) Failed to get a recordset: mysqli error: [1054: 
Unknown column 'i.logoxs' in 'field list'] in EXECUTE(", referer: 
https://xyz.com
  ...
  ...
* load_user_institutions("60") at 
/var/www/html/maharatest/auth/user.php:916, referer: https://xyz.com
* User->reset_institutions() at /var/www/html/maharatest/auth/user.php:119, 
referer: https://xyz.com
* User->find_by_id("60") at 
/var/www/html/maharatest/lib/embeddedimage.php:46, referer: https://xyz.com
* EmbeddedImage::prepare_embedded_images("Testmeeting f\xc3\xbcr Sonntag um 
20:00...", "wallpost", "51", null, "60") at 
/var/www/html/maharatest/blocktype/wall/db/upgrade.php:25, referer: 
https://xyz.com

  
  This is similar to the Bug 1717371 but in that case it was the root user 
trying to fetch institution info (so we could ignore that user) but in this 
case it is an actual user trying to fetch their institution info in the process 
of updating their wallposts to fix any embedded images.

  So we will need to make a more robust fix for this problem

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1728815/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1742579] Re: Update readme file to mention the max versions of things the version of mahara has been tested with

2018-04-05 Thread Cecilia Vela Gurovic
** Changed in: mahara/16.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1742579

Title:
  Update readme file to mention the max versions of things the version
  of mahara has been tested with

Status in Mahara:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed

Bug description:
  Because the release of a version of mahara is set in a point in time
  the version of things like PHP, MySQL, OS etc may become too new for
  Mahara to work with them correctly.

  So we need to indicate in the README.md file what things we've not yet
  tested with

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1742579/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1715776] Re: Update the chromedriver to 2.32 / selenium to 2.5.3

2018-04-05 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1715776

Title:
  Update the chromedriver to 2.32 / selenium to 2.5.3

Status in Mahara:
  Fix Released

Bug description:
  Update our behat system to run on newer versions of chromedriver /
  selenium standalone

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1715776/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1660237] Re: Remove "Mobile access token" from account settings

2018-04-05 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1660237

Title:
  Remove "Mobile access token" from account settings

Status in Mahara:
  Fix Released

Bug description:
  With Mahara 16.10 we introduced Mahara Mobile, the new mobile app for
  Mahara and with it the "App" settings that are managed on
  /module/mobileapi/apps.php

  We still show the "Mobile access tokens" on /account/index.php though
  and on /admin/site/options.php when a site has been upgraded to 16.10.
  These settings should be removed as they are confusing. Both
  MaharaDroid and Portfolio Up are not in active development and do not
  necessarily work with modern devices. Mahara Mobile allows any user to
  connect, not just with internal accounts.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1660237/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1752442] Re: Problems with group forums / topics

2018-04-05 Thread Cecilia Vela Gurovic
** Changed in: mahara/16.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1752442

Title:
  Problems with group forums / topics

Status in Mahara:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Released
Status in Mahara 17.04 series:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed

Bug description:
  In master:
  - the edit/delete buttons for a forum display to normal members (even though 
they can't edit/delete a forum)
  - the ability to subscribe / unsubscribe to a topic in a forum has gone away 
but the 'i' help still remains

  These need to be fixed up

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1752442/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1720264] Re: Missing string 'information' in Upgrade page

2018-04-05 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1720264

Title:
  Missing string 'information' in Upgrade page

Status in Mahara:
  Fix Released
Status in Mahara 17.10 series:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released

Bug description:
  A string 'information' is missing from install/upgrade

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1720264/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1731404] Re: Suspended / expired users select not working on Admin -> Users -> Suspended and expired users

2018-04-05 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1731404

Title:
  Suspended / expired users select not working on Admin -> Users ->
  Suspended and expired users

Status in Mahara:
  Fix Released
Status in Mahara 17.10 series:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released

Bug description:
  The results load fine on initial page load but fail when selecting the
  other list via select box / json call

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1731404/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1728472] Re: make htm/text strings for emai subject - personal information screen

2018-04-05 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1728472

Title:
  make htm/text strings for emai subject - personal information screen

Status in Mahara:
  Fix Released
Status in Mahara 17.10 series:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released

Bug description:
  need to make different html and text strings for the subject of email
  sent to user after adding a new email address to the personal
  information

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1728472/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1739331] Re: Upgrade simplesamlphp to version 1.15.0

2018-04-05 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1739331

Title:
  Upgrade simplesamlphp to version 1.15.0

Status in Mahara:
  Fix Released
Status in Mahara 16.10 series:
  Fix Released
Status in Mahara 17.04 series:
  Fix Released
Status in Mahara 17.10 series:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released

Bug description:
  Now that version 1.15 is out we should upgrade to it

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1739331/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1735585] Re: Problem with watchlist for a page

2018-04-05 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1735585

Title:
  Problem with watchlist for a page

Status in Mahara:
  Fix Released
Status in Mahara 16.10 series:
  Fix Released
Status in Mahara 17.04 series:
  Fix Released
Status in Mahara 17.10 series:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released

Bug description:
  Currently when a person adds a page to their watchlist and then later
  they or someone else views (but not changes) the page a row is added
  to the watchlist queue this is because we fire off the 'saveartefact'
  event on page viewing

  We should only fire the saveartefact event if actually changing
  something

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1735585/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1738898] Re: Elasticsearch not updating indexed items when access rules change

2018-04-05 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1738898

Title:
  Elasticsearch not updating indexed items when access rules change

Status in Mahara:
  Fix Released
Status in Mahara 16.10 series:
  Fix Released
Status in Mahara 17.04 series:
  Fix Released
Status in Mahara 17.10 series:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released

Bug description:
  When a page has it's access rules changed (but not other editing) the
  elasticsearch does not update the index for the items involved.

  There is an add_to_queue_access() function that is meant to check what
  pages have had their access changed since they were indexed. It was
  designed to catch the pages which have a start/stop date.

  But that is not quite sufficient.

  Problems:
  1) If a page is indexed and then later it's access rules are changed the page 
and it;s artefacts/blocks were not getting re-indexed to reflect the rule change

  - need the add_to_queue_access() a check for view_access rows whose
  'ctime' value is within the range being checked.

  2) If a page did get found with the add_to_queue_access() function it
  was still ignoring the blocktype 'text' and so was not updating the
  view_access rules for that

  - need to add a sql query to find these non-artefact items we want to
  index and them to the queue also

  3) Deleting of all the view_access rules for a page was not being picked up 
and so items
  were not being re-indexed

  - need to add items to queue when all access rules are removed from a view
  [this is not a problem if rules are changed as we delete all rules and add in 
new ones so can be picked up by change for (1) where we look for new access 
rules]

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1738898/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1742600] Re: chromedriver version needs updating for running tests

2018-04-05 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1742600

Title:
  chromedriver version needs updating for running tests

Status in Mahara:
  Fix Released
Status in Mahara 16.10 series:
  Fix Released
Status in Mahara 17.04 series:
  Fix Released
Status in Mahara 17.10 series:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released

Bug description:
  Chrome has been causing errors in running behat tests since version
  61. As a work around I pinned my version of chrome as in this wiki
  page:
  
https://wiki.mahara.org/wiki/Testing/Behat_Testing/Error_%26_Solutions#Tests_failing_erratically_since_Chrome.2FChromium_upgrade_to_version_61

  However, it seems like the issue can be resolved by updating
  chromedriver. Details of chrome versions supported by versions of
  chromedriver:
  https://sites.google.com/a/chromium.org/chromedriver/downloads

  I have now successfully run tests with chrome 63 and chromedriver
  2.35, so this seems to be the fix.

  
  Further info:
  In order to unpin your chrome/chromium versions if you used the workaround, 
run apt-mark unhold commands on the packages you have installed - e.g:

   sudo apt-mark unhold chromium-browser
   sudo apt-mark unhold chromium-codecs-ffmpeg-extra
   sudo apt-mark unhold chromium-codecs-ffmpeg
   sudo apt-mark unhold google-chrome

  I had an issue upgrading after that, which was solved by reading this: 
  
https://askubuntu.com/questions/724093/no-more-updates-for-google-chrome-apt-get-update-error/724146
 and running:
  echo "deb http://dl.google.com/linux/chrome/deb/ stable main" | sudo tee 
/etc/apt/sources.list.d/google-chrome.list  
  wget -q -O - https://dl.google.com/linux/linux_signing_key.pub | sudo apt-key 
add -  
  sudo apt-get update
  sudo apt-get install google-chrome-stable

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1742600/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1737851] Re: Unable to view public group homepage when logged out

2018-04-05 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1737851

Title:
  Unable to view public group homepage when logged out

Status in Mahara:
  Fix Released
Status in Mahara 17.10 series:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released

Bug description:
  When we have the follow in play:

  1) A group that has "public" = 1
  2) a group homepage where the group pages block has 
$configdata['showsubmitted'] = 1

  When a logged out user tries to view the group homepage we get an
  error:

  group_user_access: user argument should be an integer

  This is because the logged out user can't be compared to a group
  member/admin

  We need to add a $USER->is_logged-in() check before going down that
  rabbithole

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1737851/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1737581] Re: Add a spinner icon when copying collections

2018-04-05 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1737581

Title:
  Add a spinner icon when copying collections

Status in Mahara:
  Fix Released
Status in Mahara 16.10 series:
  Fix Released
Status in Mahara 17.04 series:
  Fix Released
Status in Mahara 17.10 series:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released

Bug description:
  Copying a collection can take some time. Even before bug 1724603, it could 
take more than 30 seconds.
  During that time, some users think it isn't working and try and try again, 
resulting in several collection copies they will have to delete after. It can 
be very tedious since they have to delete the pages too. We've had some 
complaints about that.

  Adding a spinner icon or at least a message could prevent this kind of
  situation.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1737581/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1741814] Re: error when navigating to My groups page

2018-04-05 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1741814

Title:
  error when navigating to My groups page

Status in Mahara:
  Fix Released

Bug description:
  This may be related to PHP 7.1 as it seems to be peculiar to my
  system. But on the current master branch when I choose Groups from the
  main menu, I see an error and a call stack. It doesn't seem to cause
  any other problems.

  I looked into it and found that the code is trying to divide the word
  'all' by 10, hence the error, but I'm not sure why this is.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1741814/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1748079] Re: Can't delete institution when users have accepted its privacy statement

2018-04-05 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1748079

Title:
  Can't delete institution when users have accepted its privacy
  statement

Status in Mahara:
  Fix Released

Bug description:
  to replicate:

  Set privacy switch to true in 'Site opstions' -> "Institutions'
  Create an institution and add a privacy to it
  Add a user to the institution, login as the user and accept the privacy 
statement
  Remove the user from the institution
  Try to delete the institution

  An error is displayed and the institution is not deleted:

  [WAR] 92 (lib/errors.php:859) Failed to get a recordset: postgres8 error: 
[-1: ERROR:  update or delete on table "site_content_version" violates foreign 
key constraint "usragre_sit_fk" on table "usr_agreement"
  DETAIL:  Key (id)=(5) is still referenced from table "usr_agreement".] in 
adodb_throw(DELETE FROM "site_content_version"  WHERE "institution" = ? , 
Array)Command was: DELETE FROM "site_content_version"  WHERE "institution" = ?  
and values was (0:institutioni)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1748079/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1744789] Re: Avoid relying on TinyMCE code stipping alone

2018-04-05 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Fix Committed => Fix Released

** Changed in: mahara/17.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1744789

Title:
  Avoid relying on TinyMCE code stipping alone

Status in Mahara:
  Fix Released
Status in Mahara 16.10 series:
  Fix Released
Status in Mahara 17.04 series:
  Fix Released
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Released
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  TinyMCE will strip bad strings from input, eg 

[Mahara-contributors] [Bug 1746346] Re: Unable to add/edit skin for profile & dashboard page in 17.10+

2018-04-05 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1746346

Title:
  Unable to add/edit skin for profile & dashboard page in 17.10+

Status in Mahara:
  Fix Released
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Released

Bug description:
  In 17.10+ we changed around how a bunch of the page edit screens work.
  This has accidentally removed the ability to edit the skin for a
  profile page.

  We will need to add this back in

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1746346/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1747795] Re: Importing leap2A file does not respect the locked fields rules

2018-04-05 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1747795

Title:
  Importing  leap2A file does not respect the locked fields rules

Status in Mahara:
  Fix Released

Bug description:
  In the institution settings we can lock profile fields, eg firstname,
  lastname so that a user can't change the values of them.

  However, if we upload a Leap2A file with profile details in them that
  are different to the current ones we can save the new info to our
  profile - ignoring the 'lock' on the fields

  The import should respect the lock

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1747795/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1739688] Re: Turn on "strict privacy" modus on the site level

2018-04-05 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1739688

Title:
  Turn on "strict privacy" modus on the site level

Status in Mahara:
  Fix Released

Bug description:
  We need to make a series of changes in Mahara to comply with the GDPR.
  More info is available on the wiki at
  
https://wiki.mahara.org/wiki/Developer_Area/Specifications_in_Development/GDPR_compliance

  The GDPR requires that users consent to the privacy statement of a
  site explicitely. Mahara can have multiple institutions and in theory
  it is possible that a user can be in multiple institutions.

  We are excluding the case of users being in multiple institutions at
  the same time from the initial development work as it makes the
  consent and also removal of accounts much more complicated for the
  amount of time that we have available until the GDPR takes effect.
  Furthermore, the majority of Mahara sites is not multi-tenanted and
  thus people wouldn't be in multiple accounts.

  What is to be done:

  1. Create a Yes/No switch in Config site -> Site options ->
  Institutions settings as first option in that panel: Strict privacy.

  2. The short grey description should have a sentence along the lines
  of: Turn on this option when your site needs to adhere to the GDPR
  (link to it).

  3. Info icon for this option (text to be confirmed):
  - Link to the GDPR
  - Turning on this option will require everyone to accept the T&C and the 
privacy statement for the site / their institution.
  - It will not be possible for people to be in multiple institutions at the 
same time.
  - The option is not available if the current site has people in multiple 
institutions. If you need to turn on the strict privacy, then these accounts 
will need to be cleaned up.
  - For more information and any text changes you may need to make to your T&C 
and privacy statement, please consult your lawyer. The Mahara project cannot 
provide legal advice.

  4. When displaying this option, Mahara needs to be checked if there
  are users in multiple institutions. If so, the option is greyed out.
  If multiple institutions are allowed but there aren't any users in
  multiple institutions, the multi institution switch is moved to "No"
  and greyed out. If multi institutions is not allowed, the switch is
  greyed out.

  5. Turning the "Strict privacy" switch to "Yes" also requires everyone
  to accept the T&C and privacy statement when they log in for the first
  time (once changes were made etc. as per the separate Launchpad items
  on that).

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1739688/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1740208] Re: Elasticsearch - display link to related view for artefacts in search results

2018-04-05 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1740208

Title:
  Elasticsearch - display link to related view for artefacts in search
  results

Status in Mahara:
  Fix Released

Bug description:
  Now that we use the 'doc' type in Elasticsearch 5+/6+ we need to
  adjust the views_by_artefact_acl_filter() so that it finds/returns the
  view(s) related to the artefact being displayed in the results

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1740208/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1737631] Re: Fail to upgrade to 17.10 when db prefix being used in postgres

2018-04-05 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1737631

Title:
  Fail to upgrade to 17.10 when db prefix being used in postgres

Status in Mahara:
  Fix Released
Status in Mahara 17.10 series:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released

Bug description:
  We need to use a table alias for things to work

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1737631/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1748782] Re: "Inactive user" highlight disappeared

2018-04-05 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Fix Committed => Fix Released

** Changed in: mahara/17.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1748782

Title:
  "Inactive user" highlight disappeared

Status in Mahara:
  Fix Released
Status in Mahara 17.04 series:
  Fix Released
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Released

Bug description:
  In Mahara 16.10 we added the functionality to show inactive users in
  Admin -> Users -> User search. See the user manual at
  http://manual.mahara.org/en/16.10/administration/users.html#index-4
  (#16 in the screenshot).

  This disappeared in Mahara 17.04. It needs to be put back in.

  The functionality was added in https://reviews.mahara.org/#/c/6631

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1748782/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1749402] Re: Views and collection list (in group) throws MySQL error

2018-04-05 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1749402

Title:
  Views and collection list (in group) throws MySQL error

Status in Mahara:
  Fix Released
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Released
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  If a normal group member tries to visit views and collections of the
  group, following warning/error is thrown under some conditions which
  are mentioned below:

  SQL:
  [WAR] 93 (lib/errors.php:859) Failed to get a recordset: mysqli error: [1452: 
Cannot add or update a child row: a foreign key constraint fails 
("dp-dev-master-ep"."view_rows_columns", CONSTRAINT "viewrowscolu_vie_fk" 
FOREIGN KEY ("view") REFERENCES "view" ("id"))] in EXECUTE("INSERT INTO 
"view_rows_columns" ("view", "row", "columns") VALUES ('46', '1', '3')")Command 
was: INSERT INTO "view_rows_columns" ("view", "row", "columns") VALUES (?, ?, 
?) and values was (view:46,row:1,columns:3)

  PHP:
  Call stack (most recent first):
  log_message("Failed to get a recordset: mysqli error: [1452: Ca...", 8, true, 
true) at /var/www/mahara/master/htdocs/lib/errors.php:95
  log_warn("Failed to get a recordset: mysqli error: [1452: Ca...") at 
/var/www/mahara/master/htdocs/lib/errors.php:859
  SQLException->__construct("Failed to get a recordset: mysqli error: [1452: 
Ca...") at /var/www/mahara/master/htdocs/lib/dml.php:1105
  insert_record("view_rows_columns", object(stdClass), false, false) at 
/var/www/mahara/master/htdocs/lib/dml.php:1192
  ensure_record_exists("view_rows_columns", object(stdClass), object(stdClass)) 
at /var/www/mahara/master/htdocs/lib/view.php:356
  View->__construct(0array(size 25)) at 
/var/www/mahara/master/htdocs/lib/view.php:5581
  View::get_extra_view_info(array(size 2), false) at 
/var/www/mahara/master/htdocs/view/groupviews.php:52

  This happens if the group views and collections are readonly to
  members, a group collection exisits with at least one view inside and
  in the DB there is no view which has the same id as this collection.

  I didn't went too deep inside the code, but it seems that this issue
  is somehow connected to the bug #1514608.

  It further seems that Mahara interprets a collection as a view trying
  to get/set view related data using a collection id to avoid having no
  DB entry in table view_rows_columns for this erroneously supposed view
  so the actually error should be found in functions calling this code
  areas (get_extra_view_info).

  Reproduce error:
  Create a group in which views and collections are only editable by others 
that normal group members.
  Create a view and a collection inside this group and assign the view to the 
collection.
  Make sure, that in the DB there are no entries referring to a view which has 
the same id as the above created collection (e. g. by deleting a possibly 
existing view with this id inside Mahara).
  As a normal group member call the tab views and collection of the group.

  Greetings
  Alex

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1749402/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1741799] Re: Strict privacy: Require everyone to accept the T&C and privacy statement

2018-04-05 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1741799

Title:
  Strict privacy: Require everyone to accept the T&C and privacy
  statement

Status in Mahara:
  Fix Released

Bug description:
  We need to make a series of changes in Mahara to comply with the GDPR.
  More info is available on the wiki at
  
https://wiki.mahara.org/wiki/Developer_Area/Specifications_in_Development/GDPR_compliance

  The GDPR requires that users consent to the privacy statement of a site 
explicitely. 
  For institutions, we have a Yes/No switch "Strict privacy" in Config site -> 
Site options -> Institutions settings.

  What is to be done (last item from Bug 1739688):

  5. Turning the "Strict privacy" switch to "Yes" (if enabled) requires
  everyone to accept the T&C and privacy statement when they log in for
  the first time (once changes were made etc. as per the separate
  Launchpad items on that).

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1741799/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1694874] Re: Quotation marks not escaped in name in group members block and when masquerading

2018-04-05 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1694874

Title:
  Quotation marks not escaped in name in group members block and when
  masquerading

Status in Mahara:
  Fix Released

Bug description:
  When a user's name (first or last or display name) contains double
  quotation marks, they are not escaped and shown as " in the
  "Members" block on the group homepage.

  It's not a problem on the "Members" page, but just in the "Members"
  block on the group homepage.

  To replicate:

  1. Set up a group and make sure that the group members block is displayed on 
the group homepage.
  2. Add double quotation marks to your
  a) first name
  b) last name
  c) display name (in a separate test)
  3. Go to the group homepage and check your name. 

  Expected result: The double quotation marks are shown.
  Actual result: Instead they are displayed as "

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1694874/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1719221] Re: small fixes to some behat tests

2018-04-05 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1719221

Title:
  small fixes to some behat tests

Status in Mahara:
  Fix Released

Bug description:
  There are some badly formatted tests, with background steps in the
  scenario:

  test/behat/features/user_content/search_users_by_share_pages.feature
  compare with test/behat/features/social/sharedwithme.feature.
  Could this be a scenario in the other test?
   - regardless, the format should be changed. This is not testing adding 
pages, so add the pages in the background using the generic format data.

  test/behat/features/social/modified_date.feature
   - put background into background.
   - is this already covered in 
test/behat/features/site_content/shared_views_to_group.feature?
   - if not, should it be combined.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1719221/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1734186] Re: Remove mention of username and email once account is deleted

2018-04-05 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1734186

Title:
  Remove mention of username and email once account is deleted

Status in Mahara:
  Fix Released

Bug description:
  We need to make a series of changes in Mahara to comply with the GDPR.
  More info is available on the wiki at
  
https://wiki.mahara.org/wiki/Developer_Area/Specifications_in_Development/GDPR_compliance

  While we append a "deleted" at the end of a username and email
  address, it is still possible for someone looking into the database to
  identify the email address. Since we don't need to keep it, both
  username and email address should become a random value.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1734186/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1703751] Re: behat change_account_settings.feature doesn't test functionality

2018-04-05 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1703751

Title:
  behat change_account_settings.feature doesn't test functionality

Status in Mahara:
  Fix Released

Bug description:
  This test is currently not testing actual functionality. It should be
  changed to check notification options are available and to check one
  or two actually work.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1703751/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1667526] Re: Rename "Edit this page" to "Edit"

2018-04-05 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1667526

Title:
  Rename "Edit this page" to "Edit"

Status in Mahara:
  Fix Released

Bug description:
  We can shorten the "Edit this page" button to simply "Edit" for people
  not using a screenreader.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1667526/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1719216] Re: Participation report doesn't show pages in a collection

2018-04-05 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1719216

Title:
  Participation report doesn't show pages in a collection

Status in Mahara:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released

Bug description:
  seen in Mahara 17.04

  The group participation report is supposed to display pages shared
  with the group and created within a group. However, it only displays
  pages when they are not in a collection. As soon as they are in a
  collection, they are not displayed.

  The report should be altered to show "portfolios" shared or created
  within the group, i.e. individual pages when they are not in a
  collection and a collection (with the number of pages in parentheses)
  when there is a collection.

  For collections, the comment count should be across all pages that are
  in the collection.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1719216/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1698257] Re: Ensure that the header displays correctly with or without site message

2018-04-05 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1698257

Title:
  Ensure that the header displays correctly with or without site message

Status in Mahara:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  When the custom theme has taller logo it causes the header to be
  larger, sometimes this makes the secondary menu appear to be hidden or
  cutoff when there is no site message.

  Ensure that Raw and Old raw theme header display correctly with or
  without site message(s)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1698257/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1679886] Re: behat test for files/folders blocktypes

2018-04-05 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1679886

Title:
  behat test for files/folders blocktypes

Status in Mahara:
  Fix Released

Bug description:
  Files and folders blocktypes don't have a test.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1679886/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1692757] Re: Collapse main menu by pressing Esc key

2018-04-05 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1692757

Title:
  Collapse main menu by pressing Esc key

Status in Mahara:
  Fix Released

Bug description:
  Mahara 17.04+

  User should be able to collapse the main navigation menus (user menu,
  admin menu, main menu) by pressing the Escape key.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1692757/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1692746] Re: Behat test for shared access to pages

2018-04-05 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1692746

Title:
  Behat test for shared access to pages

Status in Mahara:
  Fix Released

Bug description:
  There isn't a good test for sharing page access.

  It would be good to have a test that creates a number of pages and
  users and confirms that the users whom the pages are shared with are
  the only ones that have access to them.

  So the test should go to pages and collections, set the access to a
  particular role, group or individual and confirm that the people
  shared with are the ones that have access.

  There are tests that start to test this function, but they don't 
comprehensively test it.
  /features/user/search_users_by_share_pages.feature
  /features/user/registered_users.feature

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1692746/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1736800] Re: Update npm packages related to bootstrap-sass / mahara-themes

2018-04-05 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1736800

Title:
  Update npm packages related to bootstrap-sass / mahara-themes

Status in Mahara:
  Fix Released

Bug description:
  Bumped the versions of dependent packages to

  1) stop deprecated warnings
  2) stop using ejs < 2.5.5 due to security risk
  3) add repository / license info for mahara-themes package

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1736800/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1692761] Re: Label combo boxes correctly on "External apps"

2018-04-05 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1692761

Title:
  Label combo boxes correctly on "External apps"

Status in Mahara:
  Fix Released

Bug description:
  Mahara 17.04+ on /webservice/admin/oauthv1sregister.php

  In the Add application form, ensure the 2 combo boxes are properly
  labeled and that their labels are programmatically associated with the
  combo boxes. The first combo box contains "school, aut, etc" and the
  second contains "user provisioning, user query, etc.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1692761/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1761037] Re: Installing a site doesn't update email correctly

2018-04-05 Thread Robert Lyon
** Changed in: mahara/17.04
   Status: Fix Committed => Fix Released

** Changed in: mahara/18.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1761037

Title:
  Installing a site doesn't update email correctly

Status in Mahara:
  Fix Released
Status in Mahara 16.10 series:
  Fix Released
Status in Mahara 17.04 series:
  Fix Released
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Released
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  We added a bit of code that made sure that when we install a site it
  changes the admin email from ad...@example.org to the one supplied in
  all 3 places where we save email addresses - we save this directly to
  db.

  This is ok if we then log out before going to a place in Mahara where
  $USER->commit() is called

  But if we don't the $USER object still has ad...@example.org set so
  overwrites our change in the usr table.

  We need to commit this change via the USER object rather than update
  the usr table directly

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1761037/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1572825] Re: voki externalmedia embed code changed

2018-04-05 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1572825

Title:
  voki externalmedia embed code changed

Status in Mahara:
  Fix Released
Status in Mahara 17.10 series:
  Fix Released

Bug description:
  A recent support post on the Mahara forums has highlighted that the
  externalmedia flags the voki URL invalid:

  
https://mahara.org/interaction/forum/topic.php?id=4007&offset=0&limit=10#post30536

  It appears that the links have changed and will require an update in
  Mahara.

  Previous voki bug: https://bugs.launchpad.net/mahara/+bug/905097

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1572825/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1713908] Re: Doubled up functionality in navigation tests

2018-04-05 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1713908

Title:
  Doubled up functionality in navigation tests

Status in Mahara:
  Fix Released

Bug description:
  It looks like /test/behat/features/admin/random_clicking.feature is just a 
subset of
  /test/behat/features/view/menu_navigation.feature

  Make sure there's nothing extra in random_clicking.feature, and if
  not, delete it.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1713908/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1760970] Re: Upgraded site doesn't rotate images

2018-04-05 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1760970

Title:
  Upgraded site doesn't rotate images

Status in Mahara:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  When you upgrade from 17.10 to 18.04RC2 / master, images that had been
  uploaded prior to the upgrade cannot be rotated.

  Robert tracked it down to the database in the table
  "artefact_file_image". There it says:

  orientation character varying(10) DEFAULT '0'::character varying,

  and

  CONSTRAINT artefileimag_ori_ck CHECK (orientation::text = ANY
  (ARRAY['0'::character varying

  when on a fresh install it says "bigint" instead of "character
  varying".

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1760970/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1708959] Re: Webservice create group missing some settings

2018-04-05 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1708959

Title:
  Webservice create group missing some settings

Status in Mahara:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  The mahara_group_create_groups function is missing some options

  Including
  - Hide group
  - Hide membership
  - Hide membership from members
  - Participation report
  - Comment notifications

  Also the Shared page notifications option is boolean yet there are 4
  valid states for this option.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1708959/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1703465] Re: Masquerading sessions show deleted users

2018-04-05 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1703465

Title:
  Masquerading sessions show deleted users

Status in Mahara:
  Fix Released
Status in Mahara 17.10 series:
  Fix Released

Bug description:
  when you select people to report over for masquerading sessions,
  people who have been deleted show up if the person you are reporting
  over is an admin as the masquerading sessions display both who you has
  masqueraded and who is being masqueraded.

  Thus, if users were deleted from the system, but you are reporting
  over the site admin who masqueraded as them before the deletion, the
  deleted user data shows up, i.e. the "Deleted user
  (pitpalmer.deleted.1459025466.5...)" and the masquerading reason,
  admin and time.

  Since the users are deleted, that data should not be displayed
  anymore.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1703465/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1757283] Re: The views.js file uses the javascript 'includes' function but this is not available to IE11

2018-04-05 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1757283

Title:
  The views.js file uses the javascript 'includes' function but this is
  not available to IE11

Status in Mahara:
  Fix Released
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Released
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  We have:
   if (embedjs.includes("AC_Voki_Embed")) {

  We need:
   if (embedjs.indexOf("AC_Voki_Embed") !== -1) {

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1757283/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1715299] Re: make adding_pages_collections a user, not admin behat test

2018-04-05 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1715299

Title:
  make adding_pages_collections a user, not admin behat test

Status in Mahara:
  Fix Released

Bug description:
  This should be a user test, not admin as we want to check that a user
  can add pages and collections.

  This is the primary test for adding a collection, so does it manually
  rather than in the background. (All other tests should do it in the
  background though!)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1715299/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1752688] Re: MariaDB fails to upgrade - unable to CAST as JSON

2018-04-05 Thread Cecilia Vela Gurovic
** Changed in: mahara/17.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1752688

Title:
  MariaDB fails to upgrade - unable to CAST as JSON

Status in Mahara:
  Fix Released
Status in Mahara 17.10 series:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released

Bug description:
  There is a problem in htdocs/lib/db/upgrade.php on the line

   if (is_mysql() && version_compare($db_version, '5.7.8', '>=')) {

  The problem is Mahara recognises both MySQL and MariaDB as being
  is_mysql() and their numbering systems are different (where MariaDB is
  around 10.* while MySQL is around 5.*)

  While both are mostly compatible with each other there are some slight
  differences and in this case CAST as JSON is not yet available in
  MariaDB.

  In this case we need to check which type of is_mysql() we have and if
  it is not 'MySQL' then we need to return the if statement as false
  rather than true.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1752688/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1755611] Re: Should not call non static function statically in framework module

2018-04-05 Thread Cecilia Vela Gurovic
** Changed in: mahara/17.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1755611

Title:
  Should not call non static function statically in framework module

Status in Mahara:
  Fix Released
Status in Mahara 17.04 series:
  Fix Released
Status in Mahara 17.10 series:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  Get these deprecated warnings: 
  Non-static method PluginModuleFramework::add_matrix_to_db() should not be 
called statically in htdocs/module/framework/lib.php on line 56 
  Non-static method PluginModuleFramework::matrix_is_valid_json() should not be 
called statically in htdocs/module/framework/lib.php on line 107

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1755611/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1753841] Re: Behat test: image/text blocks can be deleted

2018-04-05 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1753841

Title:
  Behat test: image/text blocks can be deleted

Status in Mahara:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  We need to add delete and should not see steps to newtextblock.feature
  and addimageblock.feature

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1753841/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1755329] Re: Working out folder size slows down opening of image block config

2018-04-05 Thread Cecilia Vela Gurovic
** Changed in: mahara/17.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1755329

Title:
  Working out folder size slows down opening of image block config

Status in Mahara:
  Fix Released
Status in Mahara 17.04 series:
  Fix Released
Status in Mahara 17.10 series:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  We added the fix for https://bugs.launchpad.net/mahara/+bug/1650980 so that 
we could know how much content a folder contained when viewing via Content -> 
Files
  This was useful in helping one delete files to sort out quota problems.

  
  But the problem is that bit of code is also used when displaying a 
filebrowser form in block config forms. And it slows down the opening/closing 
of the config.

  We don't need to know about the folder / file size here so we should
  avoid the slow db calls that work out the size when not on Content ->
  Files page

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1755329/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1752489] Re: Behat test for One resume field block

2018-04-05 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1752489

Title:
  Behat test for One resume field block

Status in Mahara:
  Fix Released

Bug description:
  Test required to add the Interests field to the "One resume field"
  block

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1752489/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1755331] Re: Cannot copy group pages when pagination is used

2018-04-05 Thread Cecilia Vela Gurovic
** Changed in: mahara/17.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1755331

Title:
  Cannot copy group pages when pagination is used

Status in Mahara:
  Fix Released
Status in Mahara 17.04 series:
  Fix Released
Status in Mahara 17.10 series:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  Version: Mahara Version 17.10.0
  OS: Linux (Ubuntu)
  Database: MySQL
  Browser: Chrome

  Issue:
  Group pages are created that can be copied by group members

  Pages for users to copy that require they navigation to page 2 or higher of a 
shared list 
  (using the pagination at the bottom)
  Clicking Copy Reloads the page (the page is not copied)

  Page 1 is unaffected

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1755331/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1752497] Re: Behat test for Creative Commons license block

2018-04-05 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1752497

Title:
  Behat test for Creative Commons license block

Status in Mahara:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  New test for adding license block to a page and checking it displays
  correctly. Explore the different options and check them.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1752497/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1755674] Re: tinyMCE not defined error in comment on SE colection

2018-04-05 Thread Cecilia Vela Gurovic
** Changed in: mahara/17.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1755674

Title:
  tinyMCE not defined error in comment on SE colection

Status in Mahara:
  Fix Released
Status in Mahara 17.04 series:
  Fix Released
Status in Mahara 17.10 series:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  to test:

  
  Go to admin menu-> Extensions -> Plugin admin and enable annotations
  create a page and add an annotation to it
  share it with Public
  log out and go to the collection first page (not SE view table)
  try to leave a comment as anonymous user

  the page will be stuck loading and the comment is never submitted
  in the browser's console we can see the error:

  Uncaught ReferenceError: tinyMCE is not defined
  at isTinyMceUsed (annotation.js?v=7998:14)
  at addFeedbackSuccess (viewmenu.js?v=7998:37)
  at Object.window.pieformHandlers.(/view/anonymous function) [as 
add_feedback_form] 
(https://mahara/lib/pieforms/static/core/pieforms.js?v=7998:239:60)
  at sendResult (view.php?id=7:4)
  at onload (view.php?id=7:7)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1755674/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1754207] Re: Make SmartEvidence strings for statuses configurable

2018-04-05 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1754207

Title:
  Make SmartEvidence strings for statuses configurable

Status in Mahara:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  Mahara 18.04.RC1:

  /module/framework/lang/en.utf8/module.framework.php contains the
  following lang strings:

  $string['readyforassessmentcount'] = 'Number of pages that contain the 
standard element "Ready for assessment":';
  $string['dontmatchcount'] = 'Number of pages that contain the standard 
element "Does not meet the standard":';
  $string['partiallycompletecount'] = 'Number of pages that contain the 
standard element "Partially meets the standard":';
  $string['completedcount'] = 'Number of pages that contain the standard 
element "Meets the standard":';

  
  The text in the quotation marks should be configurable so that it pulls in 
the string that is used in the particular SmartEvidence framework.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1754207/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1755508] Re: Unable to remove users from group when pagination is used

2018-04-05 Thread Cecilia Vela Gurovic
** Changed in: mahara/17.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1755508

Title:
  Unable to remove users from group when pagination is used

Status in Mahara:
  Fix Released
Status in Mahara 17.04 series:
  Fix Released
Status in Mahara 17.10 series:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  Version: Mahara Version 17.10.1
  Server OS: Linux (CentOS 7.4.1708)
  Client OS: Windows 10
  Database: MySQL
  Browser: Chrome

  I am unable to remove users from groups when pagination is used and
  the user, which should be removed, is on a page higher than 1. I dont
  touch the sortorder and items per page settings, so standard sortorder
  "admin first" and "10 items per page" are used.

  It works for users on the first page, but doesnt work on all other
  pages. It just redirects me back to page 1. There is no entry in the
  logfile.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1755508/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1753911] Re: Behat: Files to download block test

2018-04-05 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1753911

Title:
  Behat: Files to download block test

Status in Mahara:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  There is no test for Files to Download block currently:

  New test requires one pdf and one jpg. Can add the files and check
  that the option to download exists, but not confirm it downloads
  locally. This would need to be done manually.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1753911/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1747856] Re: Macrons not shown in proper font character in the "Configurable theme"

2018-04-05 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1747856

Title:
  Macrons not shown in proper font character in the "Configurable theme"

Status in Mahara:
  Fix Released

Bug description:
  Māori letters are not displayed properly in page headings (see
  attachment) when the "Configurable theme" is used. The font set would
  need to be extended to account for more special characters of
  languages of the world.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1747856/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1739561] Re: Remove option to link to external T&C and privacy statements

2018-04-05 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1739561

Title:
  Remove option to link to external T&C and privacy statements

Status in Mahara:
  Fix Released

Bug description:
  We need to make a series of changes in Mahara to comply with the GDPR.
  More info is available on the wiki at
  
https://wiki.mahara.org/wiki/Developer_Area/Specifications_in_Development/GDPR_compliance

  Currently, we can link to external T&C and privacy statements in the
  Mahara footer via Admin -> Configure site -> Menus. This should not be
  possible anymore as people will need to agree and consent on Mahara.
  Therefore, these options should be removed for these two items. We can
  keep the options for "About" and "Contact us".

  If someone does want to link to an external page, they could enter
  that in the page text itself as a link.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1739561/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1750477] Re: Elasticsearch: JSON_PRESERVE_ZERO_FRACTION not defined for php < 5.6.6

2018-04-05 Thread Cecilia Vela Gurovic
** Changed in: mahara/17.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1750477

Title:
  Elasticsearch: JSON_PRESERVE_ZERO_FRACTION not defined for php < 5.6.6

Status in Mahara:
  Fix Released
Status in Mahara 17.10 series:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released

Bug description:
  We support php 5.5.9 or later.

  Elasticsearch 5 fails when creating the client in 
  search/elasticsearch/lib line 1171 because JSON_PRESERVE_ZERO_FRACTION
  is not defined

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1750477/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1749834] Re: Not showing username to users when "never display usernames" is set to no

2018-04-05 Thread Cecilia Vela Gurovic
** Changed in: mahara/17.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1749834

Title:
  Not showing username to users when "never display usernames" is set to
  no

Status in Mahara:
  Fix Released
Status in Mahara 17.04 series:
  Fix Released
Status in Mahara 17.10 series:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  Operating system: Linux
  PHP: 7
  Mahara: 17.04.2
  Database: MySQL
  Browser: Chrome

  Site config setting in Question:
  Changed "Never show usernames" to "no" for site config

  Expectaiton:
  Users can now see usernames for other users

  Actual Result:
  Username does not appear when searching for users to share a page with (It 
only appears to admins and staff) 
  The setting for this on the config page is that changing this setting does 
not affect admin and staff (which is true), however regardless of this setting 
- users cannot see a username appear in search areas when sharing portfolio 
items.

  Possible Reason:
  Searchlib.php Function search_user calls "display_name($result)" (located in 
lib/user.php)

  User.php line 1125 - display_name takes 5 params - the last one of
  which is $username which is set to false by default.

  Lines 1134: 
  $nousernames = get_config('nousernames');
  $userto = get_user_for_display($userto);
  $user   = get_user_for_display($user);

  $addusername = ($username && empty($nousernames)) ||
  !empty($userto->admin) || !empty($userto->staff);

  As username is set to false when calling this function from a search,
  the net result for normal users $addusername is always false.

  Cheers

  Kevin

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1749834/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1738055] Re: Avoid committing behat tests with 'And I insert breakpoint' in them

2018-04-05 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1738055

Title:
  Avoid committing behat tests with 'And I insert breakpoint' in them

Status in Mahara:
  Fix Released
Status in Mahara 17.10 series:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released

Bug description:
  This is only a step to be used locally for debugging behat test
  purposes.

  It will break Jenkins automated tests as the test run will never
  complete

  Need a step in the minaccept to stop us committing patches with that
  line present

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1738055/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1743286] Re: styling changes for behat html report

2018-04-05 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1743286

Title:
  styling changes for behat html report

Status in Mahara:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  making it look nicer and display the information we need fully.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1743286/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1757330] Re: Export file Session Data not saved in PHP 7.1+

2018-04-05 Thread Cecilia Vela Gurovic
** Changed in: mahara/17.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1757330

Title:
  Export file Session Data not saved in PHP 7.1+

Status in Mahara:
  Fix Released
Status in Mahara 17.04 series:
  Won't Fix
Status in Mahara 17.10 series:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  Mahara 17.10.3 (alo occurs on Mahara 17.10.0)
  Operating system: Ubuntu, apache2, PHP 7.1.8 (also occurs on PHP 7.1.15 and 
PHP 7.1.3)
  Database; MySQL
  Browser: Chrome.

  Exporting files in Mahara
  /export/index.php

  Export Either LEAP file or Standalone HTML
  click Generate Export
  in the iframe - the /export/download.php redirects back to the 
export/index.php file and nothing is downloaded - the progress iframe now shows 
the /export/index.php page.

  Possible Cause:
  Download.php (export/download.php) as this located at the bottom of the page 
(~ line 106)
  $SESSION->set('exportfile', $exporter->get('exportdir') . $zipfile);

  At the top of the page it checks to see if this session data exists - and if 
so - to force the download of the file.
  line 17: 
  if ($exportfile = $SESSION->get('exportfile')) {
  $SESSION->set('exportdata', '');
  $SESSION->set('exportfile', '');
  require_once('file.php');
  serve_file($exportfile, basename($exportfile), 'application/x-zip', 
array('lifetime' => 0, 'forcedownload' => true));
  exit;
  }

  In PHP 7.1.3 and higher - the $SESSION->get('exportfile') is empty
  when the JS redirect calls this page (from the print_export_footer
  function) and the session data set at the bottom of the page is not
  present when the page is being loaded to get the file. (loading the
  /export/index.php again will empty the exportfile data).

  The export works as expected in PHP 7, but fails in PHP 7.1+.

  Is Mahara 7.1+ ready?

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1757330/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1758735] Re: Consolidate styles of registration agreements

2018-04-05 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1758735

Title:
  Consolidate styles of registration agreements

Status in Mahara:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  When self-registration is turned on and you register for an account at
  /register.php, the terms and conditions and privacy statements are
  displayed (will need to correct it so they only show when registration
  agreement needs to be selected).

  The statements do not have our usual panels and thus it's a bit hard
  to follow their text esp. when they are long (see screenshot). They
  should get the same styling as on /userprivacy.php

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1758735/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1758757] Re: Leap2A export warnings on comment/annotation

2018-04-05 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1758757

Title:
  Leap2A export warnings on comment/annotation

Status in Mahara:
  Fix Released
Status in Mahara 18.04 series:
  Fix Released
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  On doing an export in PHP 7.0/7.1 I see these warnings

  [WAR] 4a (export/leap/lib.php:406) Parameter 1 to
  LeapExportElementComment::setup_links() expected to be a reference,
  value given, referer: http://testing/export/index.php

  [WAR] 4a (export/leap/lib.php:406) Parameter 1 to
  LeapExportElementAnnotation::setup_links() expected to be a reference,
  value given, referer: http://testing/export/index.php

  In the Mahara code it says:
  "You must explicitly pass variables by reference when calling call_user_func, 
..." 

  But in PHP manual itself it says "Note that the parameters for
  call_user_func() are not passed by reference."

  So there is something not quite right here

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1758757/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1733963] Re: Users are autoadded to the deleted groups

2018-04-05 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1733963

Title:
  Users are autoadded to the deleted groups

Status in Mahara:
  Fix Released

Bug description:
  To reproduce:

  # create a group with "Auto-add users" setting on.
  # delete a group
  # create a user after the group has been deleted
  # if you check group_members table, you will see that the new user was added 
to the deleted group

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1733963/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1736033] Re: Show site and institution privacy statements in footer when an institution member is logged in

2018-04-05 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1736033

Title:
  Show site and institution privacy statements in footer when an
  institution member is logged in

Status in Mahara:
  Fix Released

Bug description:
  We are going to change the way our privacy statement are displayed due
  to necessary changes for the GDPR.

  For that, we should ensure that the link to the privacy statement in
  the footer of the site (if displayed) shows both site and institution
  privacy statements when an institution member is logged in.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1736033/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


  1   2   3   >