Re: [DISCUSS] Change project style guidelines to allow line length 100

2021-05-20 Thread John Zhuge 
+1

On Thu, May 20, 2021 at 6:23 PM Takanobu Asanuma 
wrote:

> +1 for 100 characters. Thanks.
>
> 2021年5月21日(金) 8:38 Chao Sun :
>
> > +1. I think this will be very helpful.
> >
> > On Thu, May 20, 2021 at 3:10 PM Sangjin Lee  wrote:
> >
> > > +1 (binding). It's long overdue IMHO.
> > >
> > > On Thu, May 20, 2021 at 2:11 PM Gergely Pollak
> > >  wrote:
> > >
> > > > I really like this initiative, thank you!
> > > > +1 for line length increase to 100 characters.
> > > >
> > > > Regards,
> > > >   Gergely Pollak
> > > >
> > > > On Thu, May 20, 2021 at 8:30 PM Vivek Ratnavel <
> > vivekratna...@apache.org
> > > >
> > > > wrote:
> > > >
> > > > > +1 (non-binding) to increase line length to 100 characters. This
> will
> > > > > definitely help clear most of the checkstyle violations.
> > > > >
> > > > > Thank you Sean for starting this thread!
> > > > >
> > > > > On Thu, May 20, 2021 at 7:17 AM Sean Busbey
> >  > > >
> > > > > wrote:
> > > > >
> > > > > > Hi Bhavik!
> > > > > >
> > > > > > What concerns do you have about back porting patches to earlier
> > > release
> > > > > > branches?
> > > > > >
> > > > > > If we change our style guidelines then presumably we can do that
> > for
> > > > all
> > > > > > branches, so a backport from e.g. trunk to branch-3.3 won’t fail
> a
> > > > style
> > > > > > check on the destination branch unless something changed in the
> > > > > backporting.
> > > > > >
> > > > > > If you are referring to patches for clearing up line length
> > > violations,
> > > > > my
> > > > > > usual preference is to aim for my changes to be on all active
> > release
> > > > > > lines. So at least in the case of the patches coming from me or
> > being
> > > > > > committed by me, there’d be effort to make sure all branches end
> up
> > > as
> > > > > easy
> > > > > > to backport to as they were prior to the clean up.
> > > > > >
> > > > > >
> > > > > >
> > > > > > > On May 20, 2021, at 2:27 AM, Bhavik Patel <
> > > bhavikpatel...@gmail.com>
> > > > > > wrote:
> > > > > > >
> > > > > > > I am just worried about the backporting of the Jira to child
> > > branch!!
> > > > > How
> > > > > > > we are planning to handle this?
> > > > > > >
> > > > > > > On Thu, May 20, 2021, 11:09 AM Qi Zhu <821684...@qq.com
>  > > > > > 821684...@qq.com>> wrote:
> > > > > > >
> > > > > > >> +1 100 is reasonable.
> > > > > > >>
> > > > > > >>
> > > > > > >>
> > > > > > >> ---Original---
> > > > > > >> From: "Xiaoqiao He" > > > > hexiaoq...@apache.org
> > > > > > >
> > > > > > >> Date: Thu, May 20, 2021 13:35 PM
> > > > > > >> To: "Masatake Iwasaki" > > > > > iwasak...@oss.nttdata.co.jp>;
> > > > > > >> Cc: "Akira Ajisaka" > > aajis...@apache.org
> > > > > >;"Hadoop
> > > > > > Common"<
> > > > > > >> common-...@hadoop.apache.org  > common-...@hadoop.apache.org
> > > > > > >;"Hdfs-dev" > > > > > hdfs-...@hadoop.apache.org>
> > > > > > >> ;"yarn-dev" > > > > > yarn-...@hadoop.apache.org>;"mapreduce-dev"<
> > > > > > >> mapreduce-dev@hadoop.apache.org  > > > > mapreduce-dev@hadoop.apache.org
> > > > > > >;
> > > > > > >> Subject: Re: [DISCUSS] Change project style guidelines to
> allow
> > > line
> > > > > > >> length 100
> > > > > > >>
> > > > > > >>
> > > > > > >> +1 for <= 100 chars long per line length.
> > > > > > >>
> > > > > > >> On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
> > > > > > >> iwasak...@oss.nttdata.co.jp wrote:
> > > > > > >>
> > > > > > >>  I'm +1 too.
> > > > > > >>  I feel 80 characters limit tends to degrade readability
> by
> > > > > > introducing
> > > > > > >>  useless line breaks.
> > > > > > >> 
> > > > > > >>  
> > > > > > >> 
> > > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > > <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > > >
> > > > > > >> 
> > > > > > >> <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > > <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > > >>
> > > > > > >> ;
> > > > > > >>  I have no inconvenience on 100 characters for using Emacs
> > and
> > > > > > >> side-by-side
> > > > > > >>  diff even on 13-inch MBP.
> > > > > > >> 
> > > > > > >>  Masatake Iwasaki
> > > > > > >> 
> > > > > > >>  On 2021/05/20 11:00, Akira Ajisaka wrote:
> > > > > > >>   I'm +1 to allow <= 100 chars.
> > > > > > >>  
> > > > > > >>   FYI: There were some discussions long before:
> > > > > > >>   -
> > > > > > >> 
> > > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
>

Publishing Apache Hadoop 3.3.1-RC0 Preview bits

2021-05-20 Thread Wei-Chiu Chuang 
Hi community,

This is the preview bits of the first release candidate of Apache
Hadoop 3.3.1 line. It takes tremendous amount of effort to produce a Hadoop
RC
and we still have a number of unresolved issues [1]. Meanwhile, I'd like to
publish
preview bits so you guys can check out earlier than later. I expect to roll
the official RC earlier next week.

It contains 693 fixed jira issues [2] since 3.3.0 which include a lot of
features and improvements(read the full set of release notes).

Below feature additions are the highlights of the release.
Using lz4-java in Lz4Codec

Using snappy-java in SnappyCodec

Provide Regex Based Mount Point In Inode Tree

Add Public IOStatistics API

ABFS: Delegation SAS Generator Updates

ABFS: Delegation SAS generator for integration with Ranger

Über-jira: S3A Hadoop 3.3.1 features

Add Metrics to HttpFS Server

EC: Verify EC reconstruction correctness on DataNode

Standby NameNode process getBlocks request to reduce Active load

LocatedFileStatusFetcher to collect/publish IOStatistics


*RC tag is release-3.3.0-RC0 (4a0b8c92f599553a93a39071d287bb2cc3d1a19d)

*The RC0 artifacts are at*:
https://home.apache.org/~weichiu/hadoop-3.3.1-RC0/

*The maven artifacts are hosted here:*
https://repository.apache.org/content/repositories/orgapachehadoop-1310/

*My public key is available here:*
https://dist.apache.org/repos/dist/release/hadoop/common/KEYS

[1] https://issues.apache.org/jira/issues/?filter=12350491
[2]
https://issues.apache.org/jira/issues/?jql=project%20in%20(YARN%2C%20HADOOP%2C%20MAPREDUCE%2C%20HDFS)%20AND%20fixVersion%20in%20(3.3.1)%20AND%20status%20%3D%20Resolved%20ORDER%20BY%0AfixVersion%20ASC


My ask:
(1) please use the bits to test downstream applications. I am aware of a
number of API changes between 3.1.x and 3.3.1 and even between 3.3.0 and
3.3.1. You should use this as an opportunity to test out applications and
be ready for it.
(AFAIK Knox, Ranger, Tez, Phoenix-omid don't compile)

(2) please check out the release notes and change log, find out if anything
important should be included in 3.3.1.

Regards,


1. project in (YARN, HADOOP, MAPREDUCE, HDFS) AND fixVersion in (3.3.1) AND
status = Resolved ORDER BY
fixVersion ASC

Re: [DISCUSS] Change project style guidelines to allow line length 100

2021-05-20 Thread Takanobu Asanuma 
+1 for 100 characters. Thanks.

2021年5月21日(金) 8:38 Chao Sun :

> +1. I think this will be very helpful.
>
> On Thu, May 20, 2021 at 3:10 PM Sangjin Lee  wrote:
>
> > +1 (binding). It's long overdue IMHO.
> >
> > On Thu, May 20, 2021 at 2:11 PM Gergely Pollak
> >  wrote:
> >
> > > I really like this initiative, thank you!
> > > +1 for line length increase to 100 characters.
> > >
> > > Regards,
> > >   Gergely Pollak
> > >
> > > On Thu, May 20, 2021 at 8:30 PM Vivek Ratnavel <
> vivekratna...@apache.org
> > >
> > > wrote:
> > >
> > > > +1 (non-binding) to increase line length to 100 characters. This will
> > > > definitely help clear most of the checkstyle violations.
> > > >
> > > > Thank you Sean for starting this thread!
> > > >
> > > > On Thu, May 20, 2021 at 7:17 AM Sean Busbey
>  > >
> > > > wrote:
> > > >
> > > > > Hi Bhavik!
> > > > >
> > > > > What concerns do you have about back porting patches to earlier
> > release
> > > > > branches?
> > > > >
> > > > > If we change our style guidelines then presumably we can do that
> for
> > > all
> > > > > branches, so a backport from e.g. trunk to branch-3.3 won’t fail a
> > > style
> > > > > check on the destination branch unless something changed in the
> > > > backporting.
> > > > >
> > > > > If you are referring to patches for clearing up line length
> > violations,
> > > > my
> > > > > usual preference is to aim for my changes to be on all active
> release
> > > > > lines. So at least in the case of the patches coming from me or
> being
> > > > > committed by me, there’d be effort to make sure all branches end up
> > as
> > > > easy
> > > > > to backport to as they were prior to the clean up.
> > > > >
> > > > >
> > > > >
> > > > > > On May 20, 2021, at 2:27 AM, Bhavik Patel <
> > bhavikpatel...@gmail.com>
> > > > > wrote:
> > > > > >
> > > > > > I am just worried about the backporting of the Jira to child
> > branch!!
> > > > How
> > > > > > we are planning to handle this?
> > > > > >
> > > > > > On Thu, May 20, 2021, 11:09 AM Qi Zhu <821684...@qq.com  > > > > 821684...@qq.com>> wrote:
> > > > > >
> > > > > >> +1 100 is reasonable.
> > > > > >>
> > > > > >>
> > > > > >>
> > > > > >> ---Original---
> > > > > >> From: "Xiaoqiao He" > > > hexiaoq...@apache.org
> > > > > >
> > > > > >> Date: Thu, May 20, 2021 13:35 PM
> > > > > >> To: "Masatake Iwasaki" > > > > iwasak...@oss.nttdata.co.jp>;
> > > > > >> Cc: "Akira Ajisaka" > aajis...@apache.org
> > > > >;"Hadoop
> > > > > Common"<
> > > > > >> common-...@hadoop.apache.org  common-...@hadoop.apache.org
> > > > > >;"Hdfs-dev" > > > > hdfs-...@hadoop.apache.org>
> > > > > >> ;"yarn-dev" > > > > yarn-...@hadoop.apache.org>;"mapreduce-dev"<
> > > > > >> mapreduce-dev@hadoop.apache.org  > > > mapreduce-dev@hadoop.apache.org
> > > > > >;
> > > > > >> Subject: Re: [DISCUSS] Change project style guidelines to allow
> > line
> > > > > >> length 100
> > > > > >>
> > > > > >>
> > > > > >> +1 for <= 100 chars long per line length.
> > > > > >>
> > > > > >> On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
> > > > > >> iwasak...@oss.nttdata.co.jp wrote:
> > > > > >>
> > > > > >>  I'm +1 too.
> > > > > >>  I feel 80 characters limit tends to degrade readability by
> > > > > introducing
> > > > > >>  useless line breaks.
> > > > > >> 
> > > > > >>  
> > > > > >> 
> > > > > >>
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > <
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > >
> > > > > >> 
> > > > > >> <
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > <
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > >>
> > > > > >> ;
> > > > > >>  I have no inconvenience on 100 characters for using Emacs
> and
> > > > > >> side-by-side
> > > > > >>  diff even on 13-inch MBP.
> > > > > >> 
> > > > > >>  Masatake Iwasaki
> > > > > >> 
> > > > > >>  On 2021/05/20 11:00, Akira Ajisaka wrote:
> > > > > >>   I'm +1 to allow <= 100 chars.
> > > > > >>  
> > > > > >>   FYI: There were some discussions long before:
> > > > > >>   -
> > > > > >> 
> > > > > >>
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > <
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > >
> > > > > >> 
> > > > > >> <
> > > > >
> > > >
> > >
> >
>

Re: [DISCUSS] Change project style guidelines to allow line length 100

2021-05-20 Thread Chao Sun 
+1. I think this will be very helpful.

On Thu, May 20, 2021 at 3:10 PM Sangjin Lee  wrote:

> +1 (binding). It's long overdue IMHO.
>
> On Thu, May 20, 2021 at 2:11 PM Gergely Pollak
>  wrote:
>
> > I really like this initiative, thank you!
> > +1 for line length increase to 100 characters.
> >
> > Regards,
> >   Gergely Pollak
> >
> > On Thu, May 20, 2021 at 8:30 PM Vivek Ratnavel  >
> > wrote:
> >
> > > +1 (non-binding) to increase line length to 100 characters. This will
> > > definitely help clear most of the checkstyle violations.
> > >
> > > Thank you Sean for starting this thread!
> > >
> > > On Thu, May 20, 2021 at 7:17 AM Sean Busbey  >
> > > wrote:
> > >
> > > > Hi Bhavik!
> > > >
> > > > What concerns do you have about back porting patches to earlier
> release
> > > > branches?
> > > >
> > > > If we change our style guidelines then presumably we can do that for
> > all
> > > > branches, so a backport from e.g. trunk to branch-3.3 won’t fail a
> > style
> > > > check on the destination branch unless something changed in the
> > > backporting.
> > > >
> > > > If you are referring to patches for clearing up line length
> violations,
> > > my
> > > > usual preference is to aim for my changes to be on all active release
> > > > lines. So at least in the case of the patches coming from me or being
> > > > committed by me, there’d be effort to make sure all branches end up
> as
> > > easy
> > > > to backport to as they were prior to the clean up.
> > > >
> > > >
> > > >
> > > > > On May 20, 2021, at 2:27 AM, Bhavik Patel <
> bhavikpatel...@gmail.com>
> > > > wrote:
> > > > >
> > > > > I am just worried about the backporting of the Jira to child
> branch!!
> > > How
> > > > > we are planning to handle this?
> > > > >
> > > > > On Thu, May 20, 2021, 11:09 AM Qi Zhu <821684...@qq.com  > > > 821684...@qq.com>> wrote:
> > > > >
> > > > >> +1 100 is reasonable.
> > > > >>
> > > > >>
> > > > >>
> > > > >> ---Original---
> > > > >> From: "Xiaoqiao He" > > hexiaoq...@apache.org
> > > > >
> > > > >> Date: Thu, May 20, 2021 13:35 PM
> > > > >> To: "Masatake Iwasaki" > > > iwasak...@oss.nttdata.co.jp>;
> > > > >> Cc: "Akira Ajisaka" aajis...@apache.org
> > > >;"Hadoop
> > > > Common"<
> > > > >> common-...@hadoop.apache.org  > > > >;"Hdfs-dev" > > > hdfs-...@hadoop.apache.org>
> > > > >> ;"yarn-dev" > > > yarn-...@hadoop.apache.org>;"mapreduce-dev"<
> > > > >> mapreduce-dev@hadoop.apache.org  > > mapreduce-dev@hadoop.apache.org
> > > > >;
> > > > >> Subject: Re: [DISCUSS] Change project style guidelines to allow
> line
> > > > >> length 100
> > > > >>
> > > > >>
> > > > >> +1 for <= 100 chars long per line length.
> > > > >>
> > > > >> On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
> > > > >> iwasak...@oss.nttdata.co.jp wrote:
> > > > >>
> > > > >>  I'm +1 too.
> > > > >>  I feel 80 characters limit tends to degrade readability by
> > > > introducing
> > > > >>  useless line breaks.
> > > > >> 
> > > > >>  
> > > > >> 
> > > > >>
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > >
> > > > >> 
> > > > >> <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > >>
> > > > >> ;
> > > > >>  I have no inconvenience on 100 characters for using Emacs and
> > > > >> side-by-side
> > > > >>  diff even on 13-inch MBP.
> > > > >> 
> > > > >>  Masatake Iwasaki
> > > > >> 
> > > > >>  On 2021/05/20 11:00, Akira Ajisaka wrote:
> > > > >>   I'm +1 to allow <= 100 chars.
> > > > >>  
> > > > >>   FYI: There were some discussions long before:
> > > > >>   -
> > > > >> 
> > > > >>
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > >
> > > > >> 
> > > > >> <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > >>;
> > > > >>  -
> > > > >> 
> > > > >>
> > > >
> > >
> >
>

[DISCUSS] which release lines should we still consider actively maintained?

2021-05-20 Thread Sean Busbey 


Hi folks!

Which release lines do we as a community still consider actively maintained?

I found an earlier discussion[1] where we had consensus to consider branches 
that don’t get maintenance releases on a regular basis end-of-life for 
practical purposes. The result of that discussion was written up in our wiki 
docs in the “EOL Release Branches” page, summarized here

>  If no volunteer to do a maintenance release in a short to mid-term (like 3 
> months to 1 or 1.5 year).

Looking at release lines that are still on our download page[3]:

* Hadoop 2.10.z - last release 8 months ago
* Hadoop 3.1.z - last release 9.5 months ago
* Hadoop 3.2.z - last release 4.5 months ago
* Hadoop 3.3.z - last release 10 months ago

And then trunk holds 3.4 which hasn’t had a release since the branch-3.3 fork 
~14 months ago.

I can see that Wei-Chiu has been actively working on getting the 3.3.1 release 
out[4] (thanks Wei-Chiu!) but I do not see anything similar for the other 
release lines.

We also have pages on the wiki for our project roadmap of release[5], but it 
seems out of date since it lists in progress releases that have happened or 
branches we have announced as end of life, i.e. 2.8.

We also have a group of pages (sorry, I’m not sure what the confluence jargon 
is for this) for “hadoop active release lines”[6] but this list has 2.8, 2.9, 
3.0, 3.1, and 3.3. So several declared end of life lines and no 2.10 or 3.2 
despite those being our release lines with the most recent releases.

Are there folks willing to go through being release managers to get more of 
these release lines on a steady cadence?

If I were to take up maintenance release for one of them which should it be?

Should we declare to our downstream users that some of these lines aren’t going 
to get more releases?

Is there downstream facing documentation somewhere that I missed for setting 
expectations about our release cadence and actively maintained branches?

Do we have a backlog of work written up that could make the release process 
easier for our release managers?


[1]: https://s.apache.org/7c8jt
[2]: https://s.apache.org/4no96
[3]: https://hadoop.apache.org/releases.html
[4]: https://s.apache.org/1bvwe
[5]: https://cwiki.apache.org/confluence/display/HADOOP/Roadmap
[6]: 
https://cwiki.apache.org/confluence/display/HADOOP/Hadoop+Active+Release+Lines
-
To unsubscribe, e-mail: mapreduce-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-dev-h...@hadoop.apache.org

Re: [DISCUSS] Change project style guidelines to allow line length 100

2021-05-20 Thread Sangjin Lee 
+1 (binding). It's long overdue IMHO.

On Thu, May 20, 2021 at 2:11 PM Gergely Pollak
 wrote:

> I really like this initiative, thank you!
> +1 for line length increase to 100 characters.
>
> Regards,
>   Gergely Pollak
>
> On Thu, May 20, 2021 at 8:30 PM Vivek Ratnavel 
> wrote:
>
> > +1 (non-binding) to increase line length to 100 characters. This will
> > definitely help clear most of the checkstyle violations.
> >
> > Thank you Sean for starting this thread!
> >
> > On Thu, May 20, 2021 at 7:17 AM Sean Busbey 
> > wrote:
> >
> > > Hi Bhavik!
> > >
> > > What concerns do you have about back porting patches to earlier release
> > > branches?
> > >
> > > If we change our style guidelines then presumably we can do that for
> all
> > > branches, so a backport from e.g. trunk to branch-3.3 won’t fail a
> style
> > > check on the destination branch unless something changed in the
> > backporting.
> > >
> > > If you are referring to patches for clearing up line length violations,
> > my
> > > usual preference is to aim for my changes to be on all active release
> > > lines. So at least in the case of the patches coming from me or being
> > > committed by me, there’d be effort to make sure all branches end up as
> > easy
> > > to backport to as they were prior to the clean up.
> > >
> > >
> > >
> > > > On May 20, 2021, at 2:27 AM, Bhavik Patel 
> > > wrote:
> > > >
> > > > I am just worried about the backporting of the Jira to child branch!!
> > How
> > > > we are planning to handle this?
> > > >
> > > > On Thu, May 20, 2021, 11:09 AM Qi Zhu <821684...@qq.com  > > 821684...@qq.com>> wrote:
> > > >
> > > >> +1 100 is reasonable.
> > > >>
> > > >>
> > > >>
> > > >> ---Original---
> > > >> From: "Xiaoqiao He" > hexiaoq...@apache.org
> > > >
> > > >> Date: Thu, May 20, 2021 13:35 PM
> > > >> To: "Masatake Iwasaki" > > iwasak...@oss.nttdata.co.jp>;
> > > >> Cc: "Akira Ajisaka"mailto:aajis...@apache.org
> > >;"Hadoop
> > > Common"<
> > > >> common-...@hadoop.apache.org  > > >;"Hdfs-dev" > > hdfs-...@hadoop.apache.org>
> > > >> ;"yarn-dev" > > yarn-...@hadoop.apache.org>;"mapreduce-dev"<
> > > >> mapreduce-dev@hadoop.apache.org  > mapreduce-dev@hadoop.apache.org
> > > >;
> > > >> Subject: Re: [DISCUSS] Change project style guidelines to allow line
> > > >> length 100
> > > >>
> > > >>
> > > >> +1 for <= 100 chars long per line length.
> > > >>
> > > >> On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
> > > >> iwasak...@oss.nttdata.co.jp wrote:
> > > >>
> > > >>  I'm +1 too.
> > > >>  I feel 80 characters limit tends to degrade readability by
> > > introducing
> > > >>  useless line breaks.
> > > >> 
> > > >>  
> > > >> 
> > > >>
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > <
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > >
> > > >> 
> > > >> <
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > <
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > >>
> > > >> ;
> > > >>  I have no inconvenience on 100 characters for using Emacs and
> > > >> side-by-side
> > > >>  diff even on 13-inch MBP.
> > > >> 
> > > >>  Masatake Iwasaki
> > > >> 
> > > >>  On 2021/05/20 11:00, Akira Ajisaka wrote:
> > > >>   I'm +1 to allow <= 100 chars.
> > > >>  
> > > >>   FYI: There were some discussions long before:
> > > >>   -
> > > >> 
> > > >>
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > <
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > >
> > > >> 
> > > >> <
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > <
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > >>;
> > > >>  -
> > > >> 
> > > >>
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > > <
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > > >
> > > >> 
> > > >> <
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > > <
> > >
> >

Apache Hadoop qbt Report: trunk+JDK8 on Linux/x86_64

2021-05-20 Thread Apache Jenkins Server 
For more details, see 
https://ci-hadoop.apache.org/job/hadoop-qbt-trunk-java8-linux-x86_64/513/

[May 19, 2021 3:14:18 AM] (noreply) Bump node-sass (#3004)
[May 19, 2021 5:55:47 AM] (noreply) HADOOP-17426. Upgrade to 
hadoop-thirdparty-1.1.0. (#3024)
[May 19, 2021 5:53:42 PM] (noreply) HDFS-15757 RBF: Improving Router Connection 
Management (#2651)




-1 overall


The following subsystems voted -1:
blanks pathlen unit xml


The following subsystems voted -1 but
were configured to be filtered/ignored:
cc checkstyle javac javadoc pylint shellcheck


The following subsystems are considered long running:
(runtime bigger than 1h  0m  0s)
unit


Specific tests:

XML :

   Parsing Error(s): 
   
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/resources/nvidia-smi-output-excerpt.xml
 
   
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/resources/nvidia-smi-output-missing-tags.xml
 
   
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/resources/nvidia-smi-output-missing-tags2.xml
 
   
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/resources/nvidia-smi-sample-output.xml
 
   
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/resources/fair-scheduler-invalid.xml
 
   
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/resources/yarn-site-with-invalid-allocation-file-ref.xml
 

Failed junit tests :

   hadoop.tools.fedbalance.procedure.TestBalanceProcedureScheduler 
   hadoop.tools.fedbalance.TestDistCpProcedure 
   hadoop.yarn.server.router.clientrm.TestFederationClientInterceptor 
   hadoop.yarn.csi.client.TestCsiClient 
   hadoop.mapred.uploader.TestFrameworkUploader 
  

   cc:

  
https://ci-hadoop.apache.org/job/hadoop-qbt-trunk-java8-linux-x86_64/513/artifact/out/results-compile-cc-root.txt
 [96K]

   javac:

  
https://ci-hadoop.apache.org/job/hadoop-qbt-trunk-java8-linux-x86_64/513/artifact/out/results-compile-javac-root.txt
 [384K]

   blanks:

  
https://ci-hadoop.apache.org/job/hadoop-qbt-trunk-java8-linux-x86_64/513/artifact/out/blanks-eol.txt
 [13M]
  
https://ci-hadoop.apache.org/job/hadoop-qbt-trunk-java8-linux-x86_64/513/artifact/out/blanks-tabs.txt
 [2.0M]

   checkstyle:

  
https://ci-hadoop.apache.org/job/hadoop-qbt-trunk-java8-linux-x86_64/513/artifact/out/results-checkstyle-root.txt
 [16M]

   pathlen:

  
https://ci-hadoop.apache.org/job/hadoop-qbt-trunk-java8-linux-x86_64/513/artifact/out/results-pathlen.txt
 [16K]

   pylint:

  
https://ci-hadoop.apache.org/job/hadoop-qbt-trunk-java8-linux-x86_64/513/artifact/out/results-pylint.txt
 [20K]

   shellcheck:

  
https://ci-hadoop.apache.org/job/hadoop-qbt-trunk-java8-linux-x86_64/513/artifact/out/results-shellcheck.txt
 [28K]

   xml:

  
https://ci-hadoop.apache.org/job/hadoop-qbt-trunk-java8-linux-x86_64/513/artifact/out/xml.txt
 [24K]

   javadoc:

  
https://ci-hadoop.apache.org/job/hadoop-qbt-trunk-java8-linux-x86_64/513/artifact/out/results-javadoc-javadoc-root.txt
 [1.1M]

   unit:

  
https://ci-hadoop.apache.org/job/hadoop-qbt-trunk-java8-linux-x86_64/513/artifact/out/patch-unit-hadoop-tools_hadoop-federation-balance.txt
 [32K]
  
https://ci-hadoop.apache.org/job/hadoop-qbt-trunk-java8-linux-x86_64/513/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt
 [24K]
  
https://ci-hadoop.apache.org/job/hadoop-qbt-trunk-java8-linux-x86_64/513/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-csi.txt
 [20K]
  
https://ci-hadoop.apache.org/job/hadoop-qbt-trunk-java8-linux-x86_64/513/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-uploader.txt
 [24K]

Powered by Apache Yetus 0.14.0-SNAPSHOT   https://yetus.apache.org

-
To unsubscribe, e-mail: mapreduce-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-dev-h...@hadoop.apache.org

Re: [DISCUSS] Change project style guidelines to allow line length 100

2021-05-20 Thread Vivek Ratnavel 
+1 (non-binding) to increase line length to 100 characters. This will
definitely help clear most of the checkstyle violations.

Thank you Sean for starting this thread!

On Thu, May 20, 2021 at 7:17 AM Sean Busbey 
wrote:

> Hi Bhavik!
>
> What concerns do you have about back porting patches to earlier release
> branches?
>
> If we change our style guidelines then presumably we can do that for all
> branches, so a backport from e.g. trunk to branch-3.3 won’t fail a style
> check on the destination branch unless something changed in the backporting.
>
> If you are referring to patches for clearing up line length violations, my
> usual preference is to aim for my changes to be on all active release
> lines. So at least in the case of the patches coming from me or being
> committed by me, there’d be effort to make sure all branches end up as easy
> to backport to as they were prior to the clean up.
>
>
>
> > On May 20, 2021, at 2:27 AM, Bhavik Patel 
> wrote:
> >
> > I am just worried about the backporting of the Jira to child branch!! How
> > we are planning to handle this?
> >
> > On Thu, May 20, 2021, 11:09 AM Qi Zhu <821684...@qq.com  821684...@qq.com>> wrote:
> >
> >> +1 100 is reasonable.
> >>
> >>
> >>
> >> ---Original---
> >> From: "Xiaoqiao He"mailto:hexiaoq...@apache.org
> >
> >> Date: Thu, May 20, 2021 13:35 PM
> >> To: "Masatake Iwasaki" iwasak...@oss.nttdata.co.jp>;
> >> Cc: "Akira Ajisaka" >> ;"Hadoop
> Common"<
> >> common-...@hadoop.apache.org  >;"Hdfs-dev" hdfs-...@hadoop.apache.org>
> >> ;"yarn-dev" yarn-...@hadoop.apache.org>;"mapreduce-dev"<
> >> mapreduce-dev@hadoop.apache.org  >;
> >> Subject: Re: [DISCUSS] Change project style guidelines to allow line
> >> length 100
> >>
> >>
> >> +1 for <= 100 chars long per line length.
> >>
> >> On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
> >> iwasak...@oss.nttdata.co.jp wrote:
> >>
> >>  I'm +1 too.
> >>  I feel 80 characters limit tends to degrade readability by
> introducing
> >>  useless line breaks.
> >> 
> >>  
> >> 
> >>
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> <
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> >
> >> 
> >> <
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> <
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> >>
> >> ;
> >>  I have no inconvenience on 100 characters for using Emacs and
> >> side-by-side
> >>  diff even on 13-inch MBP.
> >> 
> >>  Masatake Iwasaki
> >> 
> >>  On 2021/05/20 11:00, Akira Ajisaka wrote:
> >>   I'm +1 to allow <= 100 chars.
> >>  
> >>   FYI: There were some discussions long before:
> >>   -
> >> 
> >>
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> <
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> >
> >> 
> >> <
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> <
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> >>;
> >>  -
> >> 
> >>
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> <
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> >
> >> 
> >> <
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> <
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> >>;
> >> 
> >>   Thanks,
> >>   Akira
> >>  
> >>   On Thu, May 20, 2021 at 6:36 AM Sean Busbey
> >> mailto:sbus...@apple.com.invalid>
> >>  wrote:
> >>  
> >>   Hello!
> >>  
> >>   What do folks think about changing our line length
> >> guidelines to allow
> >>  for 100 character width?
> >>  
> >>   Currently, we tell folks to follow the sun style guide
> with
> >> some
> >>  exception unrelated to line length. That guide says width of 80 is
> the
> >>  standard and our current check style rules act as enforcement.
> >>  
> >>   Looking at the current trunk codebase our nightly build
> >> shows a total
> >>  of ~15k line length violations; it’s about 18% of identified

Re: [DISCUSS] Change project style guidelines to allow line length 100

2021-05-20 Thread Sean Busbey 
Hi Bhavik!

What concerns do you have about back porting patches to earlier release 
branches?

If we change our style guidelines then presumably we can do that for all 
branches, so a backport from e.g. trunk to branch-3.3 won’t fail a style check 
on the destination branch unless something changed in the backporting.

If you are referring to patches for clearing up line length violations, my 
usual preference is to aim for my changes to be on all active release lines. So 
at least in the case of the patches coming from me or being committed by me, 
there’d be effort to make sure all branches end up as easy to backport to as 
they were prior to the clean up.



> On May 20, 2021, at 2:27 AM, Bhavik Patel  wrote:
> 
> I am just worried about the backporting of the Jira to child branch!! How
> we are planning to handle this?
> 
> On Thu, May 20, 2021, 11:09 AM Qi Zhu <821684...@qq.com 
> > wrote:
> 
>> +1 100 is reasonable.
>> 
>> 
>> 
>> ---Original---
>> From: "Xiaoqiao He"mailto:hexiaoq...@apache.org>
>> Date: Thu, May 20, 2021 13:35 PM
>> To: "Masatake Iwasaki"> ;
>> Cc: "Akira Ajisaka"> ;"Hadoop Common"<
>> common-...@hadoop.apache.org 
>> ;"Hdfs-dev">  
>> ;"yarn-dev"> ;"mapreduce-dev"<
>> mapreduce-dev@hadoop.apache.org ;
>> Subject: Re: [DISCUSS] Change project style guidelines to allow line
>> length 100
>> 
>> 
>> +1 for <= 100 chars long per line length.
>> 
>> On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
>> iwasak...@oss.nttdata.co.jp wrote:
>> 
>>  I'm +1 too.
>>  I feel 80 characters limit tends to degrade readability by introducing
>>  useless line breaks.
>> 
>>  
>> 
>> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
>>  
>> 
>> 
>> >  
>> >
>> ;
>>  I have no inconvenience on 100 characters for using Emacs and
>> side-by-side
>>  diff even on 13-inch MBP.
>> 
>>  Masatake Iwasaki
>> 
>>  On 2021/05/20 11:00, Akira Ajisaka wrote:
>>   I'm +1 to allow <= 100 chars.
>>  
>>   FYI: There were some discussions long before:
>>   -
>> 
>> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
>>  
>> 
>> 
>> >  
>> >;
>>  -
>> 
>> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
>>  
>> 
>> 
>> >  
>> >;
>> 
>>   Thanks,
>>   Akira
>>  
>>   On Thu, May 20, 2021 at 6:36 AM Sean Busbey
>> mailto:sbus...@apple.com.invalid>
>>  wrote:
>>  
>>   Hello!
>>  
>>   What do folks think about changing our line length
>> guidelines to allow
>>  for 100 character width?
>>  
>>   Currently, we tell folks to follow the sun style guide with
>> some
>>  exception unrelated to line length. That guide says width of 80 is the
>>  standard and our current check style rules act as enforcement.
>>  
>>   Looking at the current trunk codebase our nightly build
>> shows a total
>>  of ~15k line length violations; it’s about 18% of identified
>> checkstyle
>>  issues.
>>  
>>   The vast majority of those line length violations are <= 100
>> characters
>>  long. 100 characters happens to be the length for the Google Java
>> Style
>>  Guide, another commonly adopted style guide for java projects, so I
>> suspect
>>  these longer lines leaking past the checkstyle precommit warning
>> might be a
>>  reflection of committers

Re: [DISCUSS] Change project style guidelines to allow line length 100

2021-05-20 Thread Viraj Jasani 
+1 (non-binding) to increasing line length to 100 instead of 80 and
applying this to all active branches (for the ease of backport as Stephen
mentioned).


On Thu, 20 May 2021 at 3:30 PM, Stephen O'Donnell
 wrote:

> I am +1 on increasing the line length to 100.
>
> As for changes to address existing style issues - I think that is more pain
> than it's worth. It will make backports much harder, and we have quite a
> few active branches, not to mention those who maintain custom builds.
>
> To ease the backport problems the style fixes would need to be pushed down
> all the branches, otherwise if we start making them on trunk only, future
> changes on trunk will not be able to be cherry-picked cleanly to branch-3.3
> etc.
>
>
> On Thu, May 20, 2021 at 8:28 AM Bhavik Patel 
> wrote:
>
> > I am just worried about the backporting of the Jira to child branch!! How
> > we are planning to handle this?
> >
> > On Thu, May 20, 2021, 11:09 AM Qi Zhu <821684...@qq.com> wrote:
> >
> > > +1 100 is reasonable.
> > >
> > >
> > >
> > > ---Original---
> > > From: "Xiaoqiao He" > > Date: Thu, May 20, 2021 13:35 PM
> > > To: "Masatake Iwasaki" > > Cc: "Akira Ajisaka" > > common-...@hadoop.apache.org;"Hdfs-dev" > > ;"yarn-dev" > > mapreduce-dev@hadoop.apache.org;
> > > Subject: Re: [DISCUSS] Change project style guidelines to allow line
> > > length 100
> > >
> > >
> > > +1 for <= 100 chars long per line length.
> > >
> > > On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
> > > iwasak...@oss.nttdata.co.jp wrote:
> > >
> > >  I'm +1 too.
> > >  I feel 80 characters limit tends to degrade readability by
> > introducing
> > >  useless line breaks.
> > > 
> > >  
> > > 
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > 
> > > <
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > >
> > > ;
> > >  I have no inconvenience on 100 characters for using Emacs and
> > > side-by-side
> > >  diff even on 13-inch MBP.
> > > 
> > >  Masatake Iwasaki
> > > 
> > >  On 2021/05/20 11:00, Akira Ajisaka wrote:
> > >   I'm +1 to allow <= 100 chars.
> > >  
> > >   FYI: There were some discussions long before:
> > >   -
> > > 
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > 
> > > <
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > >;
> > >  -
> > > 
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > > 
> > > <
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > >;
> > > 
> > >   Thanks,
> > >   Akira
> > >  
> > >   On Thu, May 20, 2021 at 6:36 AM Sean Busbey
> > >  > >  wrote:
> > >  
> > >   Hello!
> > >  
> > >   What do folks think about changing our line length
> > > guidelines to allow
> > >  for 100 character width?
> > >  
> > >   Currently, we tell folks to follow the sun style guide
> with
> > > some
> > >  exception unrelated to line length. That guide says width of 80 is
> > the
> > >  standard and our current check style rules act as enforcement.
> > >  
> > >   Looking at the current trunk codebase our nightly build
> > > shows a total
> > >  of ~15k line length violations; it’s about 18% of identified
> > > checkstyle
> > >  issues.
> > >  
> > >   The vast majority of those line length violations are <=
> > 100
> > > characters
> > >  long. 100 characters happens to be the length for the Google Java
> > > Style
> > >  Guide, another commonly adopted style guide for java projects, so
> I
> > > suspect
> > >  these longer lines leaking past the checkstyle precommit warning
> > > might be a
> > >  reflection of committers working across multiple java codebases.
> > >  
> > >   I don’t feel strongly about lines being longer, but I
> would
> > > like to
> > >  move towards more consistent style enforcement as a project.
> > Updating
> > > our
> > >  project guidance to allow for 100 character lines would reduce the
> > >  likelihood that folks bringing in new contributions need a
> precommit
> > > test
> > >  cycle to get the formatting correct.
> > >  
> > >   Does anyone feel strongly about keeping the line length
> > > limit at 80
> > >  characters?
> > >  
> > >   Does anyone feel strongly about contributions coming in
> > that
> > > clear up
> > >  line length violations?
> > >  
> > >  
> > >  
> > > -
> > >   To unsubscribe, e-mail:
> > > common-dev-unsubscr...@hadoop.apache.org
> > >   For additional commands, e-mail:
> > >

Apache Hadoop qbt Report: branch-2.10+JDK7 on Linux/x86_64

2021-05-20 Thread Apache Jenkins Server 
For more details, see 
https://ci-hadoop.apache.org/job/hadoop-qbt-branch-2.10-java7-linux-x86_64/304/

[May 17, 2021 7:37:07 AM] (noreply) HDFS-15912. Allow ProtobufRpcEngine to be 
extensible (#2999)
[May 17, 2021 10:47:03 AM] (Akira Ajisaka) YARN-10555. Missing access check 
before getAppAttempts (#2608)




-1 overall


The following subsystems voted -1:
asflicense hadolint mvnsite pathlen unit


The following subsystems voted -1 but
were configured to be filtered/ignored:
cc checkstyle javac javadoc pylint shellcheck shelldocs whitespace


The following subsystems are considered long running:
(runtime bigger than 1h  0m  0s)
unit


Specific tests:

Failed junit tests :

   hadoop.fs.TestFileUtil 
   hadoop.crypto.key.kms.server.TestKMS 
   hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys 
   hadoop.hdfs.server.datanode.TestBlockRecovery 
   
hadoop.hdfs.server.blockmanagement.TestReplicationPolicyWithUpgradeDomain 
   hadoop.contrib.bkjournal.TestBookKeeperHACheckpoints 
   hadoop.contrib.bkjournal.TestBookKeeperHACheckpoints 
   hadoop.hdfs.server.federation.router.TestRouterQuota 
   hadoop.hdfs.server.federation.router.TestRouterNamenodeHeartbeat 
   hadoop.hdfs.server.federation.resolver.order.TestLocalResolver 
   hadoop.hdfs.server.federation.resolver.TestMultipleDestinationResolver 
   
hadoop.yarn.server.resourcemanager.monitor.invariants.TestMetricsInvariantChecker
 
   hadoop.yarn.server.resourcemanager.TestClientRMService 
   hadoop.mapreduce.jobhistory.TestHistoryViewerPrinter 
   hadoop.yarn.sls.TestSLSRunner 
   hadoop.resourceestimator.service.TestResourceEstimatorService 
   hadoop.resourceestimator.solver.impl.TestLpSolver 
  

   cc:

   
https://ci-hadoop.apache.org/job/hadoop-qbt-branch-2.10-java7-linux-x86_64/304/artifact/out/diff-compile-cc-root.txt
  [4.0K]

   javac:

   
https://ci-hadoop.apache.org/job/hadoop-qbt-branch-2.10-java7-linux-x86_64/304/artifact/out/diff-compile-javac-root.txt
  [496K]

   checkstyle:

   
https://ci-hadoop.apache.org/job/hadoop-qbt-branch-2.10-java7-linux-x86_64/304/artifact/out/diff-checkstyle-root.txt
  [16M]

   hadolint:

   
https://ci-hadoop.apache.org/job/hadoop-qbt-branch-2.10-java7-linux-x86_64/304/artifact/out/diff-patch-hadolint.txt
  [4.0K]

   mvnsite:

   
https://ci-hadoop.apache.org/job/hadoop-qbt-branch-2.10-java7-linux-x86_64/304/artifact/out/patch-mvnsite-root.txt
  [824K]

   pathlen:

   
https://ci-hadoop.apache.org/job/hadoop-qbt-branch-2.10-java7-linux-x86_64/304/artifact/out/pathlen.txt
  [12K]

   pylint:

   
https://ci-hadoop.apache.org/job/hadoop-qbt-branch-2.10-java7-linux-x86_64/304/artifact/out/diff-patch-pylint.txt
  [48K]

   shellcheck:

   
https://ci-hadoop.apache.org/job/hadoop-qbt-branch-2.10-java7-linux-x86_64/304/artifact/out/diff-patch-shellcheck.txt
  [56K]

   shelldocs:

   
https://ci-hadoop.apache.org/job/hadoop-qbt-branch-2.10-java7-linux-x86_64/304/artifact/out/diff-patch-shelldocs.txt
  [8.0K]

   whitespace:

   
https://ci-hadoop.apache.org/job/hadoop-qbt-branch-2.10-java7-linux-x86_64/304/artifact/out/whitespace-eol.txt
  [12M]
   
https://ci-hadoop.apache.org/job/hadoop-qbt-branch-2.10-java7-linux-x86_64/304/artifact/out/whitespace-tabs.txt
  [1.3M]

   javadoc:

   
https://ci-hadoop.apache.org/job/hadoop-qbt-branch-2.10-java7-linux-x86_64/304/artifact/out/diff-javadoc-javadoc-root.txt
  [20K]

   unit:

   
https://ci-hadoop.apache.org/job/hadoop-qbt-branch-2.10-java7-linux-x86_64/304/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
  [232K]
   
https://ci-hadoop.apache.org/job/hadoop-qbt-branch-2.10-java7-linux-x86_64/304/artifact/out/patch-unit-hadoop-common-project_hadoop-kms.txt
  [48K]
   
https://ci-hadoop.apache.org/job/hadoop-qbt-branch-2.10-java7-linux-x86_64/304/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
  [444K]
   
https://ci-hadoop.apache.org/job/hadoop-qbt-branch-2.10-java7-linux-x86_64/304/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs_src_contrib_bkjournal.txt
  [12K]
   
https://ci-hadoop.apache.org/job/hadoop-qbt-branch-2.10-java7-linux-x86_64/304/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
  [40K]
   
https://ci-hadoop.apache.org/job/hadoop-qbt-branch-2.10-java7-linux-x86_64/304/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
  [112K]
   
https://ci-hadoop.apache.org/job/hadoop-qbt-branch-2.10-java7-linux-x86_64/304/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
  [96K]
   
https://ci-hadoop.apache.org/job/hadoop-qbt-branch-2.10-java7-linux-x86_64/304/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt
  [104K]

Re: [DISCUSS] Change project style guidelines to allow line length 100

2021-05-20 Thread Bhavik Patel 
I am just worried about the backporting of the Jira to child branch!! How
we are planning to handle this?

On Thu, May 20, 2021, 11:09 AM Qi Zhu <821684...@qq.com> wrote:

> +1 100 is reasonable.
>
>
>
> ---Original---
> From: "Xiaoqiao He" Date: Thu, May 20, 2021 13:35 PM
> To: "Masatake Iwasaki" Cc: "Akira Ajisaka" common-...@hadoop.apache.org;"Hdfs-dev" ;"yarn-dev" mapreduce-dev@hadoop.apache.org;
> Subject: Re: [DISCUSS] Change project style guidelines to allow line
> length 100
>
>
> +1 for <= 100 chars long per line length.
>
> On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
> iwasak...@oss.nttdata.co.jp wrote:
>
>  I'm +1 too.
>  I feel 80 characters limit tends to degrade readability by introducing
>  useless line breaks.
> 
>  
> 
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> 
> 
> ;
>  I have no inconvenience on 100 characters for using Emacs and
> side-by-side
>  diff even on 13-inch MBP.
> 
>  Masatake Iwasaki
> 
>  On 2021/05/20 11:00, Akira Ajisaka wrote:
>   I'm +1 to allow <= 100 chars.
>  
>   FYI: There were some discussions long before:
>   -
> 
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> 
> ;
>  -
> 
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> 
> ;
> 
>   Thanks,
>   Akira
>  
>   On Thu, May 20, 2021 at 6:36 AM Sean Busbey
>   wrote:
>  
>   Hello!
>  
>   What do folks think about changing our line length
> guidelines to allow
>  for 100 character width?
>  
>   Currently, we tell folks to follow the sun style guide with
> some
>  exception unrelated to line length. That guide says width of 80 is the
>  standard and our current check style rules act as enforcement.
>  
>   Looking at the current trunk codebase our nightly build
> shows a total
>  of ~15k line length violations; it’s about 18% of identified
> checkstyle
>  issues.
>  
>   The vast majority of those line length violations are <= 100
> characters
>  long. 100 characters happens to be the length for the Google Java
> Style
>  Guide, another commonly adopted style guide for java projects, so I
> suspect
>  these longer lines leaking past the checkstyle precommit warning
> might be a
>  reflection of committers working across multiple java codebases.
>  
>   I don’t feel strongly about lines being longer, but I would
> like to
>  move towards more consistent style enforcement as a project. Updating
> our
>  project guidance to allow for 100 character lines would reduce the
>  likelihood that folks bringing in new contributions need a precommit
> test
>  cycle to get the formatting correct.
>  
>   Does anyone feel strongly about keeping the line length
> limit at 80
>  characters?
>  
>   Does anyone feel strongly about contributions coming in that
> clear up
>  line length violations?
>  
>  
>  
> -
>   To unsubscribe, e-mail:
> common-dev-unsubscr...@hadoop.apache.org
>   For additional commands, e-mail:
> common-dev-h...@hadoop.apache.org
>  
>  
>  
> -
>   To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
>   For additional commands, e-mail:
> common-dev-h...@hadoop.apache.org
>  
> 
>  -
>  To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
>  For additional commands, e-mail: common-dev-h...@hadoop.apache.org
> 
>