[jira] [Updated] (MAPREDUCE-5747) Potential null pointer deference in HsTasksBlock#render()

2015-10-01 Thread Jorge Gabriel Siqueira (JIRA) 

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-5747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jorge Gabriel Siqueira updated MAPREDUCE-5747:
--
Attachment: MAPREDUCE-5747-6.patch

> Potential null pointer deference in HsTasksBlock#render()
> -
>
> Key: MAPREDUCE-5747
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5747
> Project: Hadoop Map/Reduce
>  Issue Type: Bug
>Reporter: Ted Yu
>Priority: Minor
>  Labels: BB2015-05-TBR, newbie, patch
> Attachments: MAPREDUCE-5747-1.patch, MAPREDUCE-5747-2.patch, 
> MAPREDUCE-5747-3.patch, MAPREDUCE-5747-4.patch, MAPREDUCE-5747-5.patch, 
> MAPREDUCE-5747-6.patch
>
>
> At line 140:
> {code}
> } else {
>   ta = new TaskAttemptInfo(successful, type, false);
> {code}
> There is no check for type against null.
> TaskAttemptInfo ctor deferences type:
> {code}
>   public TaskAttemptInfo(TaskAttempt ta, TaskType type, Boolean isRunning) {
> final TaskAttemptReport report = ta.getReport();
> this.type = type.toString();
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (MAPREDUCE-5747) Potential null pointer deference in HsTasksBlock#render()

2015-10-01 Thread Guilherme (JIRA) 

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-5747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guilherme updated MAPREDUCE-5747:
-
Attachment: MAPREDUCE-5747-8.patch

> Potential null pointer deference in HsTasksBlock#render()
> -
>
> Key: MAPREDUCE-5747
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5747
> Project: Hadoop Map/Reduce
>  Issue Type: Bug
>Reporter: Ted Yu
>Priority: Minor
>  Labels: BB2015-05-TBR, newbie, patch
> Attachments: MAPREDUCE-5747-1.patch, MAPREDUCE-5747-2.patch, 
> MAPREDUCE-5747-3.patch, MAPREDUCE-5747-4.patch, MAPREDUCE-5747-5.patch, 
> MAPREDUCE-5747-6.patch, MAPREDUCE-5747-7.patch, MAPREDUCE-5747-8.patch
>
>
> At line 140:
> {code}
> } else {
>   ta = new TaskAttemptInfo(successful, type, false);
> {code}
> There is no check for type against null.
> TaskAttemptInfo ctor deferences type:
> {code}
>   public TaskAttemptInfo(TaskAttempt ta, TaskType type, Boolean isRunning) {
> final TaskAttemptReport report = ta.getReport();
> this.type = type.toString();
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (MAPREDUCE-5747) Potential null pointer deference in HsTasksBlock#render()

2015-10-01 Thread Guilherme (JIRA) 

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-5747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guilherme updated MAPREDUCE-5747:
-
Attachment: MAPREDUCE-5747-7.patch

> Potential null pointer deference in HsTasksBlock#render()
> -
>
> Key: MAPREDUCE-5747
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5747
> Project: Hadoop Map/Reduce
>  Issue Type: Bug
>Reporter: Ted Yu
>Priority: Minor
>  Labels: BB2015-05-TBR, newbie, patch
> Attachments: MAPREDUCE-5747-1.patch, MAPREDUCE-5747-2.patch, 
> MAPREDUCE-5747-3.patch, MAPREDUCE-5747-4.patch, MAPREDUCE-5747-5.patch, 
> MAPREDUCE-5747-6.patch, MAPREDUCE-5747-7.patch
>
>
> At line 140:
> {code}
> } else {
>   ta = new TaskAttemptInfo(successful, type, false);
> {code}
> There is no check for type against null.
> TaskAttemptInfo ctor deferences type:
> {code}
>   public TaskAttemptInfo(TaskAttempt ta, TaskType type, Boolean isRunning) {
> final TaskAttemptReport report = ta.getReport();
> this.type = type.toString();
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (MAPREDUCE-5747) Potential null pointer deference in HsTasksBlock#render()

2015-09-30 Thread Jorge Gabriel Siqueira (JIRA) 

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-5747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jorge Gabriel Siqueira updated MAPREDUCE-5747:
--
Attachment: MAPREDUCE-5747-5.patch

Fixing other checkstyle issue

> Potential null pointer deference in HsTasksBlock#render()
> -
>
> Key: MAPREDUCE-5747
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5747
> Project: Hadoop Map/Reduce
>  Issue Type: Bug
>Reporter: Ted Yu
>Priority: Minor
>  Labels: BB2015-05-TBR, newbie, patch
> Attachments: MAPREDUCE-5747-1.patch, MAPREDUCE-5747-2.patch, 
> MAPREDUCE-5747-3.patch, MAPREDUCE-5747-4.patch, MAPREDUCE-5747-5.patch
>
>
> At line 140:
> {code}
> } else {
>   ta = new TaskAttemptInfo(successful, type, false);
> {code}
> There is no check for type against null.
> TaskAttemptInfo ctor deferences type:
> {code}
>   public TaskAttemptInfo(TaskAttempt ta, TaskType type, Boolean isRunning) {
> final TaskAttemptReport report = ta.getReport();
> this.type = type.toString();
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (MAPREDUCE-5747) Potential null pointer deference in HsTasksBlock#render()

2015-09-28 Thread Guilherme (JIRA) 

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-5747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guilherme updated MAPREDUCE-5747:
-
Attachment: MAPREDUCE-5747-3.patch

I've written a test for the case when type is null, based on the method 
TestBlocks.testHsTasksBlock. It basically sets the type as null and asserts 
that the data must not contain things that are only added when a type is 
available.  I had to move an amount of code to a new method (getAttempts) in 
order to avoid code duplication.

> Potential null pointer deference in HsTasksBlock#render()
> -
>
> Key: MAPREDUCE-5747
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5747
> Project: Hadoop Map/Reduce
>  Issue Type: Bug
>Reporter: Ted Yu
>Priority: Minor
>  Labels: BB2015-05-TBR, newbie, patch
> Attachments: MAPREDUCE-5747-1.patch, MAPREDUCE-5747-2.patch, 
> MAPREDUCE-5747-3.patch
>
>
> At line 140:
> {code}
> } else {
>   ta = new TaskAttemptInfo(successful, type, false);
> {code}
> There is no check for type against null.
> TaskAttemptInfo ctor deferences type:
> {code}
>   public TaskAttemptInfo(TaskAttempt ta, TaskType type, Boolean isRunning) {
> final TaskAttemptReport report = ta.getReport();
> this.type = type.toString();
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (MAPREDUCE-5747) Potential null pointer deference in HsTasksBlock#render()

2015-09-28 Thread Jorge Gabriel Siqueira (JIRA) 

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-5747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jorge Gabriel Siqueira updated MAPREDUCE-5747:
--
Attachment: MAPREDUCE-5747-2.patch

Fixing checkstyle issues in the patch. I could not develop the tests for the 
issue.

> Potential null pointer deference in HsTasksBlock#render()
> -
>
> Key: MAPREDUCE-5747
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5747
> Project: Hadoop Map/Reduce
>  Issue Type: Bug
>Reporter: Ted Yu
>Priority: Minor
>  Labels: BB2015-05-TBR, newbie, patch
> Attachments: MAPREDUCE-5747-1.patch, MAPREDUCE-5747-2.patch
>
>
> At line 140:
> {code}
> } else {
>   ta = new TaskAttemptInfo(successful, type, false);
> {code}
> There is no check for type against null.
> TaskAttemptInfo ctor deferences type:
> {code}
>   public TaskAttemptInfo(TaskAttempt ta, TaskType type, Boolean isRunning) {
> final TaskAttemptReport report = ta.getReport();
> this.type = type.toString();
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (MAPREDUCE-5747) Potential null pointer deference in HsTasksBlock#render()

2015-09-28 Thread Guilherme (JIRA) 

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-5747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guilherme updated MAPREDUCE-5747:
-
Attachment: MAPREDUCE-5747-4.patch

Fixed checkstyle and whitespace issues.

> Potential null pointer deference in HsTasksBlock#render()
> -
>
> Key: MAPREDUCE-5747
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5747
> Project: Hadoop Map/Reduce
>  Issue Type: Bug
>Reporter: Ted Yu
>Priority: Minor
>  Labels: BB2015-05-TBR, newbie, patch
> Attachments: MAPREDUCE-5747-1.patch, MAPREDUCE-5747-2.patch, 
> MAPREDUCE-5747-3.patch, MAPREDUCE-5747-4.patch
>
>
> At line 140:
> {code}
> } else {
>   ta = new TaskAttemptInfo(successful, type, false);
> {code}
> There is no check for type against null.
> TaskAttemptInfo ctor deferences type:
> {code}
>   public TaskAttemptInfo(TaskAttempt ta, TaskType type, Boolean isRunning) {
> final TaskAttemptReport report = ta.getReport();
> this.type = type.toString();
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (MAPREDUCE-5747) Potential null pointer deference in HsTasksBlock#render()

2015-05-05 Thread Allen Wittenauer (JIRA) 

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-5747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer updated MAPREDUCE-5747:

Labels: BB2015-05-TBR newbie patch  (was: newbie patch)

 Potential null pointer deference in HsTasksBlock#render()
 -

 Key: MAPREDUCE-5747
 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5747
 Project: Hadoop Map/Reduce
  Issue Type: Bug
Reporter: Ted Yu
Priority: Minor
  Labels: BB2015-05-TBR, newbie, patch
 Attachments: MAPREDUCE-5747-1.patch


 At line 140:
 {code}
 } else {
   ta = new TaskAttemptInfo(successful, type, false);
 {code}
 There is no check for type against null.
 TaskAttemptInfo ctor deferences type:
 {code}
   public TaskAttemptInfo(TaskAttempt ta, TaskType type, Boolean isRunning) {
 final TaskAttemptReport report = ta.getReport();
 this.type = type.toString();
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (MAPREDUCE-5747) Potential null pointer deference in HsTasksBlock#render()

2014-10-21 Thread Rahul Palamuttam (JIRA) 

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-5747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rahul Palamuttam updated MAPREDUCE-5747:

  Tags: Newbie
Labels: newbie patch  (was: )
Status: Patch Available  (was: Open)

TaskAttemptInfo has a constructor that does not require a TaskType variable.
If the type variable is null then use this constructor instead.

I am fairly new here so any help is appreciated!

 Potential null pointer deference in HsTasksBlock#render()
 -

 Key: MAPREDUCE-5747
 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5747
 Project: Hadoop Map/Reduce
  Issue Type: Bug
Reporter: Ted Yu
Priority: Minor
  Labels: newbie, patch

 At line 140:
 {code}
 } else {
   ta = new TaskAttemptInfo(successful, type, false);
 {code}
 There is no check for type against null.
 TaskAttemptInfo ctor deferences type:
 {code}
   public TaskAttemptInfo(TaskAttempt ta, TaskType type, Boolean isRunning) {
 final TaskAttemptReport report = ta.getReport();
 this.type = type.toString();
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (MAPREDUCE-5747) Potential null pointer deference in HsTasksBlock#render()

2014-10-21 Thread Rahul Palamuttam (JIRA) 

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-5747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rahul Palamuttam updated MAPREDUCE-5747:

Attachment: MAPREDUCE-5747-1.patch

 Potential null pointer deference in HsTasksBlock#render()
 -

 Key: MAPREDUCE-5747
 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5747
 Project: Hadoop Map/Reduce
  Issue Type: Bug
Reporter: Ted Yu
Priority: Minor
  Labels: newbie, patch
 Attachments: MAPREDUCE-5747-1.patch


 At line 140:
 {code}
 } else {
   ta = new TaskAttemptInfo(successful, type, false);
 {code}
 There is no check for type against null.
 TaskAttemptInfo ctor deferences type:
 {code}
   public TaskAttemptInfo(TaskAttempt ta, TaskType type, Boolean isRunning) {
 final TaskAttemptReport report = ta.getReport();
 this.type = type.toString();
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)