[jira] [Updated] (MAPREDUCE-6927) MR job should only set tracking url if history was successfully written

2017-08-08 Thread Jason Lowe (JIRA) 

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-6927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Lowe updated MAPREDUCE-6927:
--
   Resolution: Fixed
 Hadoop Flags: Reviewed
Fix Version/s: 2.8.2
   3.0.0-beta1
   2.9.0
   Status: Resolved  (was: Patch Available)

Thanks, Eric!  I committed this to trunk, branch-2, branch-2.8, and 
branch-2.8.2.

> MR job should only set tracking url if history was successfully written
> ---
>
> Key: MAPREDUCE-6927
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6927
> Project: Hadoop Map/Reduce
>  Issue Type: Bug
>Reporter: Eric Badger
>Assignee: Eric Badger
> Fix For: 2.9.0, 3.0.0-beta1, 2.8.2
>
> Attachments: MAPREDUCE-6927.001.patch, MAPREDUCE-6927.002.patch, 
> MAPREDUCE-6927.003.patch, MAPREDUCE-6927.004.patch
>
>
> Currently the RMCommunicator will set the tracking url during unregistration 
> once a job has finished, regardless of whether it actually wrote history or 
> not. If the write to history failed for whatever reason, we should leave the 
> tracking url as null so that we get redirected to the AHS instead of getting 
> a job not found on the JHS. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org

[jira] [Updated] (MAPREDUCE-6927) MR job should only set tracking url if history was successfully written

2017-08-07 Thread Eric Badger (JIRA) 

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-6927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Badger updated MAPREDUCE-6927:
---
Attachment: MAPREDUCE-6927.004.patch

Thanks for the additional review. Thought I got rid of all of the checkstyle 
issues, but I must've added in new ones as I updated the patch. I'm pretty sure 
this one got rid of them all. I had to move {{moveTmpToDone}} to protected so 
that I could override it in the test. Not sure if there's another way around 
that. 

> MR job should only set tracking url if history was successfully written
> ---
>
> Key: MAPREDUCE-6927
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6927
> Project: Hadoop Map/Reduce
>  Issue Type: Bug
>Reporter: Eric Badger
>Assignee: Eric Badger
> Attachments: MAPREDUCE-6927.001.patch, MAPREDUCE-6927.002.patch, 
> MAPREDUCE-6927.003.patch, MAPREDUCE-6927.004.patch
>
>
> Currently the RMCommunicator will set the tracking url during unregistration 
> once a job has finished, regardless of whether it actually wrote history or 
> not. If the write to history failed for whatever reason, we should leave the 
> tracking url as null so that we get redirected to the AHS instead of getting 
> a job not found on the JHS. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org

[jira] [Updated] (MAPREDUCE-6927) MR job should only set tracking url if history was successfully written

2017-08-04 Thread Eric Badger (JIRA) 

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-6927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Badger updated MAPREDUCE-6927:
---
Attachment: MAPREDUCE-6927.003.patch

[~jlowe], that all makes sense. Definitely a better way to do the tests than I 
was before. I've fixed them up and separated them. I also fixed the checkstyle, 
so hopefully that comes back clean.

> MR job should only set tracking url if history was successfully written
> ---
>
> Key: MAPREDUCE-6927
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6927
> Project: Hadoop Map/Reduce
>  Issue Type: Bug
>Reporter: Eric Badger
>Assignee: Eric Badger
> Attachments: MAPREDUCE-6927.001.patch, MAPREDUCE-6927.002.patch, 
> MAPREDUCE-6927.003.patch
>
>
> Currently the RMCommunicator will set the tracking url during unregistration 
> once a job has finished, regardless of whether it actually wrote history or 
> not. If the write to history failed for whatever reason, we should leave the 
> tracking url as null so that we get redirected to the AHS instead of getting 
> a job not found on the JHS. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org

[jira] [Updated] (MAPREDUCE-6927) MR job should only set tracking url if history was successfully written

2017-08-04 Thread Eric Badger (JIRA) 

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-6927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Badger updated MAPREDUCE-6927:
---
Description: Currently the RMCommunicator will set the tracking url during 
unregistration once a job has finished, regardless of whether it actually wrote 
history or not. If the write to history failed for whatever reason, we should 
leave the tracking url as null so that we get redirected to the AHS instead of 
getting a job not found on the JHS. 

> MR job should only set tracking url if history was successfully written
> ---
>
> Key: MAPREDUCE-6927
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6927
> Project: Hadoop Map/Reduce
>  Issue Type: Bug
>Reporter: Eric Badger
>Assignee: Eric Badger
> Attachments: MAPREDUCE-6927.001.patch, MAPREDUCE-6927.002.patch
>
>
> Currently the RMCommunicator will set the tracking url during unregistration 
> once a job has finished, regardless of whether it actually wrote history or 
> not. If the write to history failed for whatever reason, we should leave the 
> tracking url as null so that we get redirected to the AHS instead of getting 
> a job not found on the JHS. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org

[jira] [Updated] (MAPREDUCE-6927) MR job should only set tracking url if history was successfully written

2017-08-04 Thread Eric Badger (JIRA) 

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-6927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Badger updated MAPREDUCE-6927:
---
Attachment: MAPREDUCE-6927.002.patch

[~jlowe], thanks for the comments. I'm not quite sure why I didn't write a 
description. I'll fix that.

{quote}
I think we should set the tracking URL as soon as the .jhist file is 
successfully put in the done folder which is a bit earlier than where it is now 
in the patch.
{quote}
I moved the {{setHistoryFile()}} call up to just after the .jhist file is moved 
to done. 

bq. It would be nice if the unit test verified the job history URL was 
correctly rather than just any string at all.
Fixed

bq. I think the test should also verify that even if the job history event 
handler receives a job finished event but is unable to complete moving the 
history to the done directory that it does not set the tracking URL.
I had to mock up more stuff than I wanted to to get this to work. Let me know 
if you have a better way in mind that can accomplish the same thing. 

> MR job should only set tracking url if history was successfully written
> ---
>
> Key: MAPREDUCE-6927
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6927
> Project: Hadoop Map/Reduce
>  Issue Type: Bug
>Reporter: Eric Badger
>Assignee: Eric Badger
> Attachments: MAPREDUCE-6927.001.patch, MAPREDUCE-6927.002.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org

[jira] [Updated] (MAPREDUCE-6927) MR job should only set tracking url if history was successfully written

2017-08-02 Thread Eric Badger (JIRA) 

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-6927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Badger updated MAPREDUCE-6927:
---
Attachment: MAPREDUCE-6927.001.patch

> MR job should only set tracking url if history was successfully written
> ---
>
> Key: MAPREDUCE-6927
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6927
> Project: Hadoop Map/Reduce
>  Issue Type: Bug
>Reporter: Eric Badger
>Assignee: Eric Badger
> Attachments: MAPREDUCE-6927.001.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org

[jira] [Updated] (MAPREDUCE-6927) MR job should only set tracking url if history was successfully written

2017-08-02 Thread Eric Badger (JIRA) 

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-6927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Badger updated MAPREDUCE-6927:
---
Status: Patch Available  (was: Open)

> MR job should only set tracking url if history was successfully written
> ---
>
> Key: MAPREDUCE-6927
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6927
> Project: Hadoop Map/Reduce
>  Issue Type: Bug
>Reporter: Eric Badger
>Assignee: Eric Badger
> Attachments: MAPREDUCE-6927.001.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org