Re: [PATCH] Allow storing mc configuration in /etc/mc
Hi! I wrote a patch allowing to store mc configuration to /etc/mc. It's tested within Fedora for a few months with no complaints. I moved these configuration files from /usr/share/mc to /etc/mc: I use this patch several months, all ok. -- Sincerely yours, Vadim Likhota ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [RFE][PATCH] Display free space on device in panels
Hello Jindrich,
On Wed, 1 Feb 2006, Jindrich Novy wrote:
On Mon, 2006-01-02 at 14:41 +0100, Jindrich Novy wrote:
thanks for your comments, attaching the patch better matching the mc
coding style.
I modified the patch so that it can be switched on/off in the
Options/Layout dialog to display free space on device.
I red the patch more carefully and I have several questions:
1)
--- mc-4.6.1a/src/screen.c.showfree 2006-01-31 21:59:12.0 +0100
+++ mc-4.6.1a/src/screen.c 2006-01-31 21:59:12.0 +0100
@@ -49,6 +49,7 @@
+static void
+show_free_space(WPanel *panel)
+{
+struct stat st;
+
+/* Don't try to stat non-local fs */
+if (!vfs_file_is_local(panel-cwd))
+ return;
+
+if (old_cwd == NULL || strcmp(old_cwd, panel-cwd) == 0) {
^^^
Is this made on purpose ? Maybe you meant '!=' ?
2) Do you think that retrieving the free space information once per
directory read would diminish the effect of this patch. Currently
my_statfs () is called each time the screen changes i.e. move up,
move down, etc - this seems a bit too much ...
Pavel The Prick Tsekov
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [PATCH] Allow storing mc configuration in /etc/mc
On Thu, 18 May 2006, Jindrich Novy wrote: On Wed, 2006-05-17 at 23:36 +0300, Pavel Tsekov wrote: I think the patch is pretty straigth forward. I am not really sure that we want to check both mc_home and mc_home_alt though. Anyway, if noone objects I'll commit this patch. I would keep both checks for a while to not to break mc when someone decides he wants the configs in one place as it used to be (/usr/share/mc). On the other hand we could remove the dual checks after some time when the most of the mc users are aware of the change. I can write a patch for it as well then. I don't want to start a big discussion about it - either way it is acceptable. I just occured to me that it may be confusing for the end user if both paths are checked. If someone wants to store the config files in the old place he just needs to configure MC accordingly. What's more important if someone wants to use their old config files without doing anything it won't work either. So in both cases the user has to be aware of the fact that MC looks for config files in a different place. ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [RFE][PATCH] Display free space on device in panels
Hi Pavel,
On Thu, 2006-05-18 at 12:11 +0300, Pavel Tsekov wrote:
Hello Jindrich,
On Wed, 1 Feb 2006, Jindrich Novy wrote:
On Mon, 2006-01-02 at 14:41 +0100, Jindrich Novy wrote:
thanks for your comments, attaching the patch better matching the mc
coding style.
I modified the patch so that it can be switched on/off in the
Options/Layout dialog to display free space on device.
I red the patch more carefully and I have several questions:
1)
--- mc-4.6.1a/src/screen.c.showfree 2006-01-31 21:59:12.0 +0100
+++ mc-4.6.1a/src/screen.c2006-01-31 21:59:12.0 +0100
@@ -49,6 +49,7 @@
+static void
+show_free_space(WPanel *panel)
+{
+struct stat st;
+
+/* Don't try to stat non-local fs */
+if (!vfs_file_is_local(panel-cwd))
+ return;
+
+if (old_cwd == NULL || strcmp(old_cwd, panel-cwd) == 0) {
^^^
Is this made on purpose ? Maybe you meant '!=' ?
Thanks for the review. There should be != of course as we need to update
old_cwd whenever it differs from panel-cwd.
2) Do you think that retrieving the free space information once per
directory read would diminish the effect of this patch. Currently
my_statfs () is called each time the screen changes i.e. move up,
move down, etc - this seems a bit too much ...
Yes, the patch can still be improved. I posted it here just to discuss
the feature and whether upstream likes it. It's still not a commit
candidate yet.
Pavel The Prick Tsekov
LOL, feel free to be Mr. Prick here ;)
Jindrich
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel
[bug #16328] Can't display correct info with file size = 4Gbytes
Follow-up Comment #1, bug #16328 (project mc): I've tried to simulate the problem but it doesn't happen here with both MC from cvs and mc-4.6.1a-10 (from FC5). Now, I noticed that the filename in the screenshot is not the same filename as in the ls output in your bugreport. Can you post a real ls output so I can try with the same filename. ___ Reply to this item at: http://savannah.gnu.org/bugs/?func=detailitemitem_id=16328 ___ Message sent via/by Savannah http://savannah.gnu.org/ ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [RFE][PATCH] Display free space on device in panels
On Thu, 18 May 2006, Jindrich Novy wrote: Yes, the patch can still be improved. I posted it here just to discuss the feature and whether upstream likes it. It's still not a commit candidate yet. Well, it seems that this is a much desired feature... I've seen people requesting it at several different places. Despite from the strcmp() issue do you plan to improve it one way or another anytime soon. I mean should I wait for an update or just commit it as is ? Btw if anyone on this list wants to share his thoughts on this patch - now is the time. Pavel The Prick Tsekov ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: hi.I want to translate mc into Vietnamese.
Hello, On Thu, 18 May 2006, x??m h???u wrote: Hi , I want to translate mc into Vietnamese. If nobody translate mc into Vietnamese then I might translate. Send me, pls.Thank. There is a Viatnamese translation for MC but I guess it is somewhat outdated. You can see that for yourself by checking out a copy of the CVS version of MC. The Viatnamese translation can be found under directory po/ in vi.po. ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[bug #16303] More functionally u7z
Follow-up Comment #2, bug #16303 (project mc): It would be better if you tweak the existing u7z script instead of providing a new one. I see the exisiting one has support for removing files from archives - why doesn't it work for you ? Does it print an error message of some kind ? ___ Reply to this item at: http://savannah.gnu.org/bugs/?func=detailitemitem_id=16303 ___ Message sent via/by Savannah http://savannah.gnu.org/ ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [RFE][PATCH] Display free space on device in panels
Hi Pavel, On Thu, 2006-05-18 at 16:36 +0300, Pavel Tsekov wrote: On Thu, 18 May 2006, Jindrich Novy wrote: Yes, the patch can still be improved. I posted it here just to discuss the feature and whether upstream likes it. It's still not a commit candidate yet. Well, it seems that this is a much desired feature... I've seen people requesting it at several different places. Despite from the strcmp() issue do you plan to improve it one way or another anytime soon. I mean should I wait for an update or just commit it as is ? Ok, I'll send a better patch in a few days. So please wait with committing for a while. Cheers, Jindrich -- Jindrich Novy [EMAIL PROTECTED] ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: find in viewer
Hello, On Tue, 28 Mar 2006, Nerijus Baliunas wrote: Find in viewer does not remember its last search string: F3, F7, enter some text, Enter, F10. F3, F7 - search string field is empty. It used to remember earlier, and it doesn't happen with editor (editor remembers search string). mc-4.6.1a-10 from FC5. The following commit broke it: http://cvs.savannah.gnu.org/viewcvs/mc/mc/src/view.c?sortby=dater2=1.336r1=1.335diff_format=u I guess in the long term the last seach string should be remembered onto persistent storage as for example the file positions. Any thoughts ? ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [PATCH] Allow storing mc configuration in /etc/mc
On Thu, May 18, 2006 at 04:09:00PM +0300, Pavel Tsekov wrote: On Thu, 18 May 2006, Jindrich Novy wrote: On Wed, 2006-05-17 at 23:36 +0300, Pavel Tsekov wrote: I think the patch is pretty straigth forward. I am not really sure that we want to check both mc_home and mc_home_alt though. Anyway, if noone objects I'll commit this patch. I would keep both checks for a while to not to break mc when someone decides he wants the configs in one place as it used to be (/usr/share/mc). On the other hand we could remove the dual checks after some time when the most of the mc users are aware of the change. I can write a patch for it as well then. I don't want to start a big discussion about it - either way it is acceptable. I just occured to me that it may be confusing for the end user if both paths are checked. you bet it is. for example, suse-packaged kdm has a long track record of confusing the hell out of users with this approach. i'd much prefer a clean switch to sysconfdir, which is presumably what the debian packaging does. -- Hi! I'm a .signature virus! Copy me into your ~/.signature, please! -- Chaos, panic, and disorder - my work here is done. ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: find in viewer
On Thu, May 18, 2006 at 05:42:45PM +0300, Pavel Tsekov wrote: I guess in the long term the last seach string should be remembered onto persistent storage as for example the file positions. yes. -- Hi! I'm a .signature virus! Copy me into your ~/.signature, please! -- Chaos, panic, and disorder - my work here is done. ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [PATCH] Allow storing mc configuration in /etc/mc
On Thu, 18 May 2006, Oswald Buddenhagen wrote: On Thu, May 18, 2006 at 04:09:00PM +0300, Pavel Tsekov wrote: On Thu, 18 May 2006, Jindrich Novy wrote: On Wed, 2006-05-17 at 23:36 +0300, Pavel Tsekov wrote: I think the patch is pretty straigth forward. I am not really sure that we want to check both mc_home and mc_home_alt though. Anyway, if noone objects I'll commit this patch. I would keep both checks for a while to not to break mc when someone decides he wants the configs in one place as it used to be (/usr/share/mc). On the other hand we could remove the dual checks after some time when the most of the mc users are aware of the change. I can write a patch for it as well then. I don't want to start a big discussion about it - either way it is acceptable. I just occured to me that it may be confusing for the end user if both paths are checked. you bet it is. for example, suse-packaged kdm has a long track record of confusing the hell out of users with this approach. i'd much prefer a clean switch to sysconfdir, which is presumably what the debian packaging does. Oswald, your advice is always appreciated. Let's see what the rest of the MC developes think about that patch and whether Jindrich is willing to change his patch. ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [RFE][PATCH] Display free space on device in panels
Hi Pavel, On Thu, 2006-05-18 at 16:36 +0300, Pavel Tsekov wrote: Btw if anyone on this list wants to share his thoughts on this patch - now is the time. Personally I don't like the highlighting of the free space indicator. I find it rather distracting. It suffices that the top of the panel is highlighted, no need to highlight that info for the active panel. IMO the conditional attrset (REVERSE_COLOR) etc should be removed. Leonard. -- mount -t life -o ro /dev/dna /genetic/research ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Mailfs date problem
Hi,
Pavel Tsekov drew my attention to the fact that the fact that we now
only parse dates with 3 elements (either year or time, not both) broke
mailfs. I intend to fix this, but haven't had time to look into this
thoroughly.
The representation for files younger and older than 6 months use either
time or year in the third field. However, there's a bit of an issue as
to what constitutes to 6 months that I need to investigate before I can
commit a correct fix. GNU ls seems to change at 180 or 181 days in the
past (not sure why this is inconsistent) but I'm unsure what mc assumes
internally (this day 6 months ago?).
Anyway, if you are using mc from CVS and using mailfs you can
temporarily use the attached patch which parses the date values back to
3 fields (year, not time). This causes all times for emails younger than
6 months to be represented as 00:00 which is ugly but at least it gets
rid of the year in the mail name.
I hope to find some time to fix this issue correctly next week (or the
week after that ;) .
Leonard.
--
mount -t life -o ro /dev/dna /genetic/research
--- mailfs.in.000 2002-12-24 07:56:17.0 +0100
+++ mailfs.in 2006-05-14 00:03:22.0 +0200
@@ -21,7 +21,7 @@ if (eval require Date::Manip) {
$parse_date=
sub {
local $_ =localtime(str2time($_[0],$TZ));
- s/^... (.+) (\d\d:\d\d):\d\d (\d\d\d\d)$/$1 $3 $2/;
+ s/^... (.+) (\d\d:\d\d):\d\d (\d\d\d\d)$/$1 $2/;
return $_;
}
} else { # use light version
@@ -29,7 +29,7 @@ if (eval require Date::Manip) {
# assumes something like: Mon, 5 Jan 1998 16:08:19 +0200 (GMT+0200)
# if you have mails with another date format, add it here
if (/(\d\d?) ([A-Z][a-z][a-z]) (\d\d\d\d) (\d\d?:\d\d)/) {
- return $2 $1 $3 $4;
+ return $2 $1 $3;
}
# Y2K bug.
# Date: Mon, 27 Mar 100 16:30:47 + (GMT)
@@ -38,12 +38,12 @@ if (eval require Date::Manip) {
if ($correct_year 1970) {
$correct_year += 100;
}
- return $2 $1 $correct_year $4;
+ return $2 $1 $correct_year;
}
# AOLMail(SM).
# Date: Sat Jul 01 10:06:06 2000
if (/([A-Z][a-z][a-z]) (\d\d?) (\d\d?:\d\d)(:\d\d)? (\d\d\d\d)/) {
- return $1 $2 $5 $3;
+ return $1 $2 $5;
}
# Fallback
return localtime(time);
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [PATCH] Allow storing mc configuration in /etc/mc
Hi Pavel, On Thu, 2006-05-18 at 23:17 +0300, Pavel Tsekov wrote: Let's see what the rest of the MC developes think about that patch and whether Jindrich is willing to change his patch. A consistent change to the new location is fine with me :) . Leonard. -- mount -t life -o ro /dev/dna /genetic/research ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
