Re: Fwd: some problems with do_*_ca_mode()

2005-11-23 Thread Jindrich Novy
Hi Andrey, Leonard,

On Fri, 2005-11-18 at 14:26 +0100, Leonard den Ottolander wrote:
 Hi Andrey,
 
 On Fri, 2005-11-18 at 11:03 +0700, Andrey V. Malyshev wrote:
  I can not test it under the real xterm console (with X), I have not one. I
  think it is nessessary before commiting, can everyone do it?
 
 Maybe somebody will beat me to it. Otherwise I'll do. Even though your
 explanation sounds senisible I'd like to hear some other peoples opinion
 though.

I agree with Andrey here, that we should use ti and te sequences
acquired from termcap database instead of hardcoded ones. The problem is
that Andrey uses direct putp() calls. The putp() belongs to ncurses and
it doesn't seem to work when slang support is enabled.

I propose this way to write termcap sequences to the terminal what
should work even with slang:

#ifdef HAVE_SLANG
  SLtt_write_string (ti_cap);
#else
  putp (ti_cap);
#endif

and similarly for the te_cap. The question is whether not to call
SLtt_initialize () and friends in case of slang instead as slang takes
care of setting proper ti/te sequences itself.

Jindrich
-- 
Jindrich Novy [EMAIL PROTECTED], http://people.redhat.com/jnovy/
(o_   _o)
//\  The worst evil in the world is refusal to think. //\
V_/_ _\_V


___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel


Re: Fwd: some problems with do_*_ca_mode()

2005-11-18 Thread Leonard den Ottolander
Hi Andrey,

On Fri, 2005-11-18 at 11:03 +0700, Andrey V. Malyshev wrote:
 I can not test it under the real xterm console (with X), I have not one. I
 think it is nessessary before commiting, can everyone do it?

Maybe somebody will beat me to it. Otherwise I'll do. Even though your
explanation sounds senisible I'd like to hear some other peoples opinion
though.

 My English limps :) But I'll try.

I'll fix it up :) . Thanks.

 Is it possible to obtain basic cvs-version of mc? If yes - how?

Sure. See http://savannah.gnu.org/cvs/?group=mc .

Leonard.

-- 
mount -t life -o ro /dev/dna /genetic/research


___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel


Fwd: some problems with do_*_ca_mode()

2005-11-17 Thread Andrey V. Malyshev

This is copy for mailing-list, sorry.

==
* Forwarded by Andrey V. Malyshev [EMAIL PROTECTED]
* From: Andrey V. Malyshev [EMAIL PROTECTED]
* Date: Fri, 18 Nov 2005 11:01:46 +0700
* To: Leonard den Ottolander [EMAIL PROTECTED]
* Subj: Re: some problems with do_*_ca_mode()
==

Hello, Leonard!
You wrote to MC development mc-devel@gnome.org on Thu, 17 Nov 2005
22:11:50 +0100:

?? I've found some problems in mc-4.6.1 connected to do_enter_ca_mode()
?? and do_exit_ca_mode() functions.
LdO What problems are you seeing?

The source problem was unwrapped output.
I work with FreeBSD(4.11, 5.4) using SecureCRT ssh-client. When I use
xterm terminal in SCRT session options, everything works fine with mc
except one: starting mc disables line wrapping. For example, if  I write
under mc:
$ echo o(many times, 200)
it is echoing as one string without any wrapping. The same for ps axww and
so on.
Sending proper ca_mode codes fix it, as far as I see.

LdO If noone has objections I think we should commit this patch.

I can not test it under the real xterm console (with X), I have not one. I
think it is nessessary before commiting, can everyone do it?

LdO Could you please provide a ChangeLog entry?

My English limps :) But I'll try.

src/main.c
* The way of detecting xmouse_seq terminal capability changed.
* Detecting of enter_ca_mode and exit_ca_mode terminal capabilities
added.
* Calling of do_enter_ca_mode() at startup and do_exit_ca_mode() at shutdown
fixed.
src/main.h
* Detecting of enter_ca_mode and exit_ca_mode terminal capabilities
added.
src/win.c
* Using detected enter_ca_mode and exit_ca_mode terminal capabilities
instead of hardcoded.
* Calling putp() instead of fprintf() in do_enter_ca_mode() and
do_exit_ca_mode().

P.S.
Is it possible to obtain basic cvs-version of mc? If yes - how?

==
With best regards, Andrey V. Malyshev.
E-mail: [EMAIL PROTECTED] 

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel