[MediaWiki-commits] [Gerrit] mediawiki/vagrant[master]: Use local ORES service when both ores and ores_services role...

[Code Review]

Gergő Tisza has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/344814 )

Change subject: Use local ORES service when both ores and ores_services roles 
are enabled
..

Use local ORES service when both ores and ores_services roles are enabled

This is not very useful as it is because the local ORES service is not
automatically set up to do anything useful.

Bug: T159105
Change-Id: I2ea694c745f2c3e2f636ee76f839393f89107633
---
M puppet/modules/role/manifests/ores_services.pp
1 file changed, 15 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/vagrant 
refs/changes/14/344814/1

diff --git a/puppet/modules/role/manifests/ores_services.pp 
b/puppet/modules/role/manifests/ores_services.pp
index 3c720e6..a5cf773 100644
--- a/puppet/modules/role/manifests/ores_services.pp
+++ b/puppet/modules/role/manifests/ores_services.pp
@@ -8,6 +8,21 @@
 
 $ores_hostname = $::ores::vhost_name
 $wikilabels_hostname = $::ores::wikilabels::vhost_name
+
+# when role::ores is also enabled, make it use the local service
+mediawiki::settings { 'ORES service:':
+values   => {
+wgOresBaseUrl => "http://localhost:${::ores::port}/;,
+wgOresModels  => {
+damaging  => true,
+goodfaith => true,
+reverted  => true,
+wp10  => true,
+},
+},
+priority => 20,
+}
+
 mediawiki::import::text { 'VagrantRoleOresServices':
 content => 
template('role/ores_services/VagrantRoleOresServices.wiki.erb'),
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/344814
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ea694c745f2c3e2f636ee76f839393f89107633
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/vagrant
Gerrit-Branch: master
Gerrit-Owner: Gergő Tisza 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: SurfaceFragment: Avoid double-annotating in insertDocument, ...

[DLynch (Code Review)]

DLynch has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/344813 )

Change subject: SurfaceFragment: Avoid double-annotating in insertDocument, as 
well
..

SurfaceFragment: Avoid double-annotating in insertDocument, as well

This applies e0933438's fix to insertContent to insertDocument. Took the
opportunity to switch insertDocument to use addAnnotationsToData as well,
though had to add a few new parameters to handle inserting from a different
store.

Bug: T143261
Change-Id: I13c30b38d33e7fffb2f50d06c87c22cead893c88
---
M src/dm/ve.dm.Document.js
M src/dm/ve.dm.SurfaceFragment.js
M tests/dm/ve.dm.SurfaceFragment.test.js
3 files changed, 43 insertions(+), 26 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/13/344813/1

diff --git a/src/dm/ve.dm.Document.js b/src/dm/ve.dm.Document.js
index 1f5700b..972eabe 100644
--- a/src/dm/ve.dm.Document.js
+++ b/src/dm/ve.dm.Document.js
@@ -165,17 +165,29 @@
  * @param {Array} data Data to apply annotations to
  * @param {ve.dm.AnnotationSet} annotationSet Annotations to apply
  * @param {boolean} [replaceComparable] Whether to remove annotations from the 
data which are comparable to those in annotationSet
+ * @param {ve.dm.IndexValueStore} [store] Store associated with the data; only 
needs to be provided if that data is associated with a different store than 
annotationSet
+ * @param {number} [offset] Offset at which to insert annotationSet; defaults 
to the end of the set
  */
-ve.dm.Document.static.addAnnotationsToData = function ( data, annotationSet, 
replaceComparable ) {
-   var i, length, newAnnotationSet, store = annotationSet.getStore();
+ve.dm.Document.static.addAnnotationsToData = function ( data, annotationSet, 
replaceComparable, store, offset ) {
+   var i, length, newAnnotationSet;
if ( annotationSet.isEmpty() ) {
// Nothing to do
return;
}
+   store = store || annotationSet.getStore();
// Apply annotations to data
for ( i = 0, length = data.length; i < length; i++ ) {
if ( data[ i ].type ) {
// Element
+   if ( ve.dm.LinearData.static.isOpenElementData( data[ i 
] ) ) {
+   // data[ i ].annotations = 
annotations.storeIndexes.concat( item.annotations || [] );
+   newAnnotationSet = new ve.dm.AnnotationSet( 
store, data[ i ].annotations || [] );
+   if ( replaceComparable ) {
+   newAnnotationSet = 
newAnnotationSet.withoutComparableSet( annotationSet );
+   }
+   newAnnotationSet.addSet( annotationSet.clone(), 
offset );
+   data[ i ].annotations = 
newAnnotationSet.getIndexes();
+   }
continue;
} else if ( !Array.isArray( data[ i ] ) ) {
// Wrap in array
@@ -189,7 +201,7 @@
// comparable to those in annotationSet
newAnnotationSet = 
newAnnotationSet.withoutComparableSet( annotationSet );
}
-   newAnnotationSet.addSet( annotationSet.clone() );
+   newAnnotationSet.addSet( annotationSet.clone(), offset 
);
}
data[ i ][ 1 ] = newAnnotationSet.getIndexes();
}
diff --git a/src/dm/ve.dm.SurfaceFragment.js b/src/dm/ve.dm.SurfaceFragment.js
index e5714ec..5e8eda8 100644
--- a/src/dm/ve.dm.SurfaceFragment.js
+++ b/src/dm/ve.dm.SurfaceFragment.js
@@ -818,7 +818,7 @@
// wrapping any annotations which are identical apart 
from their
// original DOM element so we don't generate markup like
// foo when pasting.
-   ve.dm.Document.static.addAnnotationsToData( content, 
annotations, true );
+   ve.dm.Document.static.addAnnotationsToData( content, 
annotations, true, doc.store );
}
tx = ve.dm.TransactionBuilder.static.newFromInsertion( doc, 
offset, content );
// Set the range to cover the inserted content; the offset 
translation will be wrong
@@ -861,7 +861,7 @@
  * @chainable
  */
 ve.dm.SurfaceFragment.prototype.insertDocument = function ( newDoc, 
newDocRange, annotate ) {
-   var tx, newRange, annotations, offset, i, iLen, item, annotatedData, 
annotatedDoc,
+   var tx, newRange, annotations, offset, annotatedData, annotatedDoc,
range = this.getSelection().getCoveringRange(),
doc = this.getDocument();
 
@@ -889,28 +889,10 @@
annotatedDoc = newDoc;
} else {
// Build shallow-cloned annotatedData array, copying 

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Serialize/deserialize for Transaction and IndexValueStore

[Divec (Code Review)]

Divec has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/344812 )

Change subject: Serialize/deserialize for Transaction and IndexValueStore
..

Serialize/deserialize for Transaction and IndexValueStore

Change-Id: I565c9a4e3de5af2cb46501ab84e08a71b0636929
---
M src/dm/ve.dm.Change.js
M src/dm/ve.dm.IndexValueStore.js
M src/dm/ve.dm.Transaction.js
3 files changed, 103 insertions(+), 55 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/12/344812/1

diff --git a/src/dm/ve.dm.Change.js b/src/dm/ve.dm.Change.js
index 48aff04..3eb521c 100644
--- a/src/dm/ve.dm.Change.js
+++ b/src/dm/ve.dm.Change.js
@@ -86,19 +86,18 @@
 ve.dm.Change.static = {};
 
 /**
- * Deserialize a JSON-serialized change
+ * Deserialize a change from a JSONable object
  *
  * Store values can be deserialized, or kept verbatim; the latter is an 
optimization if the
  * Change object will be rebased and reserialized without ever being applied 
to a document.
  *
- * @param {Object} data JSON-serialized change
+ * @param {Object} data Change serialized as a JSONable object
  * @param {ve.dm.Document} [doc] Document, used for creating proper selections 
if deserializing in the client
  * @param {boolean} [preserveStoreValues] Keep store values verbatim instead 
of deserializing
- * @return {ve.dm.Change} Deserialized Change object
+ * @return {ve.dm.Change} Deserialized change
  */
 ve.dm.Change.static.deserialize = function ( data, doc, preserveStoreValues ) {
-   var author,
-   staticChange = this,
+   var author, deserializeStore,
selections = {};
 
for ( author in data.selections ) {
@@ -107,27 +106,16 @@
data.selections[ author ]
);
}
+   deserializeStore = ve.dm.IndexValueStore.static.deserialize.bind(
+   null,
+   preserveStoreValues ? function noop( x ) {
+   return x;
+   } : this.deserializeValue
+   );
return new ve.dm.Change(
data.start,
-   data.transactions.map( function ( tx ) {
-   var newTx = new ve.dm.Transaction( tx.operations );
-   newTx.author = tx.author;
-   return newTx;
-   } ),
-   data.stores.map( function ( serializedStore ) {
-   var hash, value,
-   store = new ve.dm.IndexValueStore();
-   store.hashes = serializedStore.hashes;
-   store.hashStore = {};
-   for ( hash in serializedStore.hashStore ) {
-   value = serializedStore.hashStore[ hash ];
-   if ( !preserveStoreValues ) {
-   value = staticChange.deserializeValue( 
value );
-   }
-   store.hashStore[ hash ] = value;
-   }
-   return store;
-   } ),
+   data.transactions.map( ve.dm.Transaction.static.deserialize ),
+   data.stores.map( deserializeStore ),
selections
);
 };
@@ -733,39 +721,27 @@
  * already, i.e. the Change object was created by #deserialize without 
deserializing store values).
  *
  * @param {boolean} [preserveStoreValues] If true, keep store values verbatim 
instead of serializing
- * @return {ve.dm.Change} Deserialized Change object
+ * @return {ve.dm.Change} Deserialized change
  */
 ve.dm.Change.prototype.serialize = function ( preserveStoreValues ) {
-   var author,
-   selections = {},
-   change = this;
+   var author, serializeStoreValues, serializeStore,
+   selections = {};
 
for ( author in this.selections ) {
selections[ author ] = this.selections[ author ].toJSON();
}
+   serializeStoreValues = preserveStoreValues ? function noop( x ) {
+   return x;
+   } : this.constructor.static.serializeValue;
+   serializeStore = function ( store ) {
+   return store.serialize( serializeStoreValues );
+   };
return {
start: this.start,
-   transactions: this.transactions.map( function ( transaction ) {
-   return {
-   operations: transaction.operations,
-   author: transaction.author
-   };
+   transactions: this.transactions.map( function ( tx ) {
+   return tx.serialize();
} ),
-   stores: this.stores.map( function ( store ) {
-   var hash, value,
-   serialized = {};
-   for ( hash in store.hashStore ) {
-   

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: Update linktrails

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/344764 )

Change subject: Update linktrails
..


Update linktrails

Change-Id: I98b6d36db94909e2f5c7f735c595c2a479420717
---
M pywikibot/family.py
1 file changed, 10 insertions(+), 0 deletions(-)

Approvals:
  Dalba: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/pywikibot/family.py b/pywikibot/family.py
index 85aa05d..d031b8a 100644
--- a/pywikibot/family.py
+++ b/pywikibot/family.py
@@ -158,6 +158,8 @@
 'be-tarask': u'[абвгґджзеёжзійклмнопрстуўфхцчшыьэюяćčłńśšŭźža-z]*',
 'bg': u'[a-zабвгдежзийклмнопрстуфхцчшщъыьэюя]*',
 'bm': u'[a-zàâçéèêîôûäëïöüùÇÉÂÊÎÔÛÄËÏÖÜÀÈÙ]*',
+'bn': '[ঀ-৿]*',
+'bpy': '[ঀ-৿]*',
 'bs': u'[a-zćčžšđž]*',
 'bxr': u'[a-zабвгдеёжзийклмнопрстуфхцчшщъыьэюя]*',
 'ca': u'[a-zàèéíòóúç·ïü]*',
@@ -210,6 +212,7 @@
 'koi': u'[a-zабвгдеёжзийклмнопрстуфхцчшщъыьэюя]*',
 'krc': u'[a-zабвгдеёжзийклмнопрстуфхцчшщъыьэюя]*',
 'ksh': u'[a-zäöüėëijßəğåůæœç]*',
+'ku': '[a-zçêîşûẍḧÇÊÎŞÛẌḦ]*',
 'kv': u'[a-zабвгдеёжзийклмнопрстуфхцчшщъыьэюя]*',
 'lad': u'[a-záéíóúñ]*',
 'lb': u'[äöüßa-z]*',
@@ -220,9 +223,11 @@
 'lmo': u'[a-zàéèíîìóòúù]*',
 'ln': u'[a-zàâçéèêîôûäëïöüùÇÉÂÊÎÔÛÄËÏÖÜÀÈÙ]*',
 'lrc': u'[ابپتثجچحخدذرزژسشصضطظعغفقکگلمنوهیآأئؤة‌]*',
+'lt': '[a-ząčęėįšųūž]*',
 'ltg': u'[a-zA-ZĀāČčĒēĢģĪīĶķĻļŅņŠšŪūŽž]*',
 'lv': u'[a-zA-ZĀāČčĒēĢģĪīĶķĻļŅņŠšŪūŽž]*',
 'mai': '[a-zऀ-ॣ०-꣠-ꣿ]*',
+'mdf': '[a-zабвгдеёжзийклмнопрстуфхцчшщъыьэюя]*',
 'mg': u'[a-zàâçéèêîôûäëïöüùÇÉÂÊÎÔÛÄËÏÖÜÀÈÙ]*',
 'mhr': u'[a-zабвгдеёжзийклмнопрстуфхцчшщъыьэюя]*',
 'mk': u'[a-zабвгдѓежзѕијклљмнњопрстќуфхцчџш]*',
@@ -240,6 +245,7 @@
 'nl': u'[a-zäöüïëéèà]*',
 'nn': u'[æøåa-z]*',
 'no': u'[æøåa-z]*',
+'nrm': '[a-zàâçéèêîôûäëïöüùÇÉÂÊÎÔÛÄËÏÖÜÀÈÙ]*',
 'oc': u'[a-zàâçéèêîôû]*',
 'or': u'[a-z଀-୿]*',
 'pa': 
u'[ਁਂਃਅਆਇਈਉਊਏਐਓਔਕਖਗਘਙਚਛਜਝਞਟਠਡਢਣਤਥਦਧਨਪਫਬਭਮਯਰਲਲ਼ਵਸ਼ਸਹ਼ਾਿੀੁੂੇੈੋੌ੍ਖ਼ਗ਼ਜ਼ੜਫ਼ੰੱੲੳa-z]*',
@@ -248,10 +254,14 @@
 'pfl': u'[äöüßa-z]*',
 'pl': u'[a-zęóąśłżźćńĘÓĄŚŁŻŹĆŃ]*',
 'pms': u'[a-zàéèíîìóòúù]*',
+'pnt': ('[a-zαβγδεζηθικλμνξοπρστυφχψωςΑΒΓΔΕΖΗΘΙΚΛΜΝΞΟΠΡΣΤΥΦΧΨΩ'
+'άέήίόύώϊϋΐΰΆΈΉΊΌΎΏΪΫ]*'),
 'pt': u'[a-záâãàéêẽçíòóôõq̃úüűũ]*',
 'qu': u'[a-záéíóúñ]*',
 'rmy': u'[a-zăâîşţșțĂÂÎŞŢȘȚ]*',
 'ro': u'[a-zăâîşţșțĂÂÎŞŢȘȚ]*',
+'roa-rup': '[a-zăâîşţșțĂÂÎŞŢȘȚ]*',
+'roa-tara': '[a-zàéèíîìóòúù]*',
 'ru': u'[a-zабвгдеёжзийклмнопрстуфхцчшщъыьэюя]*',
 'rue': u'[a-zабвгґдеєжзиіїйклмнопрстуфхцчшщьєюяёъы“»]*',
 'sa': u'[a-zऀ-ॣ०-꣠-ꣿ]*',

-- 
To view, visit https://gerrit.wikimedia.org/r/344764
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I98b6d36db94909e2f5c7f735c595c2a479420717
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt 
Gerrit-Reviewer: Dalba 
Gerrit-Reviewer: John Vandenberg 
Gerrit-Reviewer: Magul 
Gerrit-Reviewer: Xqt 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Show "change block" in userlinks for blocked users

[EddieGP (Code Review)]

EddieGP has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/344811 )

Change subject: Show "change block" in userlinks for blocked users
..

Show "change block" in userlinks for blocked users

User links are used on various special pages. Currently, if one user is
blocked, it will still say (talk | contribs | block). After this patch
it'll be (talk | contribs | change block ) if the user is already
blocked. The necessary message is already in use on other places, hence
another translation message isn't needed.

Bug: T24705
Change-Id: I85f8ad1133ed6085220bc35ba99b73cf8a489fd0
---
M includes/Linker.php
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/11/344811/1

diff --git a/includes/Linker.php b/includes/Linker.php
index 0c8d1c6..fbcbb88 100644
--- a/includes/Linker.php
+++ b/includes/Linker.php
@@ -1002,9 +1002,11 @@
 */
public static function blockLink( $userId, $userText ) {
$blockPage = SpecialPage::getTitleFor( 'Block', $userText );
+   $message = User::newFromId( $userId )->isBlocked() ?
+   'change-blocklink' : 'blocklink';
$moreLinkAttribs['class'] = 'mw-usertoollinks-block';
$blockLink = self::link( $blockPage,
-wfMessage( 'blocklink' )->escaped(),
+wfMessage( $message )->escaped(),
 $moreLinkAttribs );
return $blockLink;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/344811
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I85f8ad1133ed6085220bc35ba99b73cf8a489fd0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: EddieGP 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] 3d2png/deploy[master]: Add .gitreview

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/344810 )

Change subject: Add .gitreview
..


Add .gitreview

Change-Id: I25272bd719e3a9930193d0523b0c7ec59314b999
---
A .gitreview
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  MarkTraceur: Verified; Looks good to me, approved



diff --git a/.gitreview b/.gitreview
new file mode 100644
index 000..b92c324
--- /dev/null
+++ b/.gitreview
@@ -0,0 +1,6 @@
+[gerrit]
+host=gerrit.wikimedia.org
+port=29418
+project=3d2png/deploy.git
+defaultbranch=master
+defaultrebase=0

-- 
To view, visit https://gerrit.wikimedia.org/r/344810
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I25272bd719e3a9930193d0523b0c7ec59314b999
Gerrit-PatchSet: 1
Gerrit-Project: 3d2png/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 
Gerrit-Reviewer: MarkTraceur 
Gerrit-Reviewer: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Metrolook[master]: Fix TypeError: undefined is not an object (evaluating '$(hr...

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/344795 )

Change subject: Fix  TypeError: undefined is not an object (evaluating 
'$(href).offset().top')
..


Fix  TypeError: undefined is not an object (evaluating '$(href).offset().top')

Bug: T157532
Change-Id: I1d94c41656b60169f5cedcf8b067603539a72943
---
M js/fixed-header-scroll-fix.js
1 file changed, 29 insertions(+), 15 deletions(-)

Approvals:
  Paladox: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/js/fixed-header-scroll-fix.js b/js/fixed-header-scroll-fix.js
index d2fe16d..1ad4483 100644
--- a/js/fixed-header-scroll-fix.js
+++ b/js/fixed-header-scroll-fix.js
@@ -1,17 +1,31 @@
-/* Add offset when scrolling to an anchor from a table of contents link */
-var href = $( this ).attr( 'href' ),
-   dest = ( $( href ).offset().top -
-   ( $( 'div.vectorMenu#usermenu' ).height() + 10 ) ),
-   d = ( $( ':target' ).offset().top -
-   ( $( 'div.vectorMenu#usermenu' ).height() + 10 ) );
+jQuery( document ).ready( function( $ ) {
+   /* Add offset when scrolling to an anchor from a table of contents link 
*/
+   var dest,
+   headerHeight = $( 'div.vectorMenu#usermenu' ).height() + 10,
+   // Split hash
+   hash;
 
-$( '.toc ul a[href^=#]' ).on( 'click', function( e ) {
-   window.history.pushState( {}, '', $( this ).prop( 'href' ) );
-   $( 'html, body' ).scrollTop( dest );
-   e.preventDefault();
+   $( '.toc ul a[href*="#"]' ).click( function( e ) {
+   try {
+   if ( this && this.href !== '' ) {
+   // Split location and hash
+   hash = this.href.match( /[#].*/g )[ 0 ],
+
+   // Don't reload page if already at same 
location as last clicked
+   $( 'html, body' ).animate( {
+   scrollTop: $( hash ).offset().top - 41
+   }, 200 );
+   }
+   e.preventDefault();
+   return false;
+   } catch ( e ) { }
+   } );
+
+   /* Add offset when scrolling to an anchor present at page load time */
+   if ( $( ':target' ).length > 0 ) {
+   dest = $( this ).offset().top - headerHeight;
+   $( 'html, body' ).animate( {
+   scrollTop: dest // also use scrollTop to animate 
scrolling
+   } );
+   }
 } );
-
-/* Add offset when scrolling to an anchor present at page load time */
-if ( $( ':target' ).length > 0 ) {
-   $( 'html, body' ).scrollTop( d );
-}

-- 
To view, visit https://gerrit.wikimedia.org/r/344795
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1d94c41656b60169f5cedcf8b067603539a72943
Gerrit-PatchSet: 7
Gerrit-Project: mediawiki/skins/Metrolook
Gerrit-Branch: master
Gerrit-Owner: Paladox 
Gerrit-Reviewer: Paladox 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] 3d2png/deploy[master]: Add .gitreview

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/344810 )

Change subject: Add .gitreview
..

Add .gitreview

Change-Id: I25272bd719e3a9930193d0523b0c7ec59314b999
---
A .gitreview
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/3d2png/deploy 
refs/changes/10/344810/1

diff --git a/.gitreview b/.gitreview
new file mode 100644
index 000..b92c324
--- /dev/null
+++ b/.gitreview
@@ -0,0 +1,6 @@
+[gerrit]
+host=gerrit.wikimedia.org
+port=29418
+project=3d2png/deploy.git
+defaultbranch=master
+defaultrebase=0

-- 
To view, visit https://gerrit.wikimedia.org/r/344810
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I25272bd719e3a9930193d0523b0c7ec59314b999
Gerrit-PatchSet: 1
Gerrit-Project: 3d2png/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: MWHttpRequest: optionally add original request data

[Code Review]

Gergő Tisza has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/344809 )

Change subject: MWHttpRequest: optionally add original request data
..

MWHttpRequest: optionally add original request data

Bug: T161029
Change-Id: I16a2eec46ae9e0e242fe740be20e39a2422dc867
---
M includes/http/Http.php
M includes/http/MWHttpRequest.php
2 files changed, 39 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/09/344809/1

diff --git a/includes/http/Http.php b/includes/http/Http.php
index fa2d5a3..889cb60 100644
--- a/includes/http/Http.php
+++ b/includes/http/Http.php
@@ -53,6 +53,8 @@
 *- logger  A \Psr\Logger\LoggerInterface instance for 
debug logging
 *- usernameUsername for HTTP Basic Authentication
 *- passwordPassword for HTTP Basic Authentication
+*- originalRequest Information about the original request (as 
a WebRequest object or
+*  an associative array with 'ip' and 
'userAgent').
 * @param string $caller The method making this request, for profiling
 * @return string|bool (bool)false on failure or a string on success
 */
diff --git a/includes/http/MWHttpRequest.php b/includes/http/MWHttpRequest.php
index e04402f..ea83a9c 100644
--- a/includes/http/MWHttpRequest.php
+++ b/includes/http/MWHttpRequest.php
@@ -52,6 +52,9 @@
protected $followRedirects = false;
protected $connectTimeout;
 
+   /** @var string[] Associative array with 'ip' and 'userAgent' keys */
+   protected $originalRequest;
+
/**
 * @var CookieJar
 */
@@ -124,6 +127,10 @@
'Authorization',
'Basic ' . base64_encode( $options['username'] 
. ':' . $options['password'] )
);
+   }
+   var_dump(array_keys($options));
+   if ( isset( $options['originalRequest'] ) ) {
+   $this->setOriginalRequest( $options['originalRequest'] 
);
}
 
$members = [ "postData", "proxy", "noProxy", "sslVerifyHost", 
"caInfo",
@@ -632,4 +639,34 @@
public function canFollowRedirects() {
return true;
}
+
+   /**
+* Set information about the original request. This can be useful for
+* endpoints/API modules which act as a proxy for some service, and
+* throttling etc. needs to happen in that service.
+* Calling this will result in the X-Forwarded-For and 
X-Original-User-Agent
+* headers being set.
+* @param WebRequest|array $originalRequest When in array form, it's
+ *   expected to have the keys 'ip' and 'userAgent'.
+* @note IP/user agent is personally identifiable information, and 
should
+*   only be set when the privacy policy of the request target is
+*   compatible with that of the MediaWiki installation.
+*/
+   public function setOriginalRequest( $originalRequest ) {
+   if ( $originalRequest instanceof WebRequest ) {
+   $originalRequest = [
+   'ip' => $originalRequest->getIP(),
+   'userAgent' => $originalRequest->getHeader( 
'User-Agent' ),
+   ];
+   } elseif (
+   !is_array( $originalRequest )
+   || array_diff( [ 'ip', 'userAgent' ], array_keys( 
$originalRequest ) )
+   ) {
+   throw new InvalidArgumentException( __METHOD__ . ': 
$originalReuqest must be a '
+   . "WebRequest or an array with 'ip' and 
'userAgent' keys" );
+   }
+
+   $this->reqHeaders['X-Forwarder-For'] = $originalRequest['ip'];
+   $this->reqHeaders['X-Original-User-Agent'] = 
$originalRequest['userAgent'];
+   }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/344809
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I16a2eec46ae9e0e242fe740be20e39a2422dc867
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gergő Tisza 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[master]: Update to use EditPageGetCheckboxesDefinition hook

[Code Review]

Bartosz Dziewoński has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/344808 )

Change subject: Update to use EditPageGetCheckboxesDefinition hook
..

Update to use EditPageGetCheckboxesDefinition hook

Depends-On: I3dbe973dcac6cba0c3a1ac5d983cafcfb49d833c
Change-Id: I1613d5f8a792e2e520b974eff9687edd27b43352
---
M FlaggedRevs.php
M frontend/FlaggablePageView.php
M frontend/FlaggedRevsUI.hooks.php
3 files changed, 39 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FlaggedRevs 
refs/changes/08/344808/1

diff --git a/FlaggedRevs.php b/FlaggedRevs.php
index 37ac0aa..66fe3d6 100644
--- a/FlaggedRevs.php
+++ b/FlaggedRevs.php
@@ -558,7 +558,8 @@
 # Tweak submit button name/title
 $wgHooks['EditPageBeforeEditButtons'][] = 
'FlaggedRevsUIHooks::onBeforeEditButtons';
 # Autoreview information from form
-$wgHooks['EditPageBeforeEditChecks'][] = 'FlaggedRevsUIHooks::addReviewCheck';
+$wgHooks['EditPageBeforeEditChecks'][] = 
'FlaggedRevsUIHooks::onEditPageBeforeEditChecks';
+$wgHooks['EditPageGetCheckboxesDefinition'][] = 
'FlaggedRevsUIHooks::onEditPageGetCheckboxesDefinition';
 $wgHooks['EditPage::showEditForm:fields'][] = 
'FlaggedRevsUIHooks::addRevisionIDField';
 # Add draft link to section edit error
 $wgHooks['EditPageNoSuchSection'][] = 'FlaggedRevsUIHooks::onNoSuchSection';
diff --git a/frontend/FlaggablePageView.php b/frontend/FlaggablePageView.php
index b1eb800..fa98347 100644
--- a/frontend/FlaggablePageView.php
+++ b/frontend/FlaggablePageView.php
@@ -1877,7 +1877,7 @@
 * (a) there are currently any revisions pending (bug 16713)
 * (b) this is an unreviewed page (bug 23970)
 */
-   public function addReviewCheck( EditPage $editPage, array &$checkboxes, 
&$tabindex ) {
+   public function addReviewCheck( EditPage $editPage, array &$checkboxes, 
&$tabindex = null ) {
$this->load();
$request = $this->getRequest();
$title = $this->article->getTitle(); // convenience
@@ -1891,31 +1891,46 @@
# the user decide if he/she wants it reviewed on the 
spot. One might
# do this if he/she just saw the diff-to-stable and 
*then* decided to edit.
# Note: check not shown when editing old revisions, 
which is confusing.
-   $checkbox = Xml::check(
-   'wpReviewEdit',
-   $request->getCheck( 'wpReviewEdit' ),
-   array( 'tabindex' => ++$tabindex, 'id' => 
'wpReviewEdit' )
+   $name = 'wpReviewEdit';
+   $options = array(
+   'label-message' => null,
+   'id' => 'wpReviewEdit',
+   'default' => $request->getCheck( $name ),
+   'title-message' => null,
+   'legacy-name' => 'reviewed',
);
-   $attribs = array( 'for' => 'wpReviewEdit' );
// For reviewed pages...
if ( $this->article->getStable() ) {
// For pending changes...
if ( $this->article->revsArePending() ) {
$n = 
$this->article->getPendingRevCount();
-   $attribs['title'] = $this->msg( 
'revreview-check-flag-p-title' )->text();
-   $labelMsg = $this->msg( 
'revreview-check-flag-p' )->numParams( $n )->parse();
+   $options['title-message'] = 
'revreview-check-flag-p-title';
+   $options['label-message'] = $this->msg( 
'revreview-check-flag-p' )->numParams( $n );
// For just the user's changes...
} else {
-   $attribs['title'] = $this->msg( 
'revreview-check-flag-y-title' )->parse();
-   $labelMsg = $this->msg( 
'revreview-check-flag-y' )->parse();
+   $options['title-message'] = 
'revreview-check-flag-y-title';
+   $options['label-message'] = 
'revreview-check-flag-y';
}
// For unreviewed pages...
} else {
-   $attribs['title'] = $this->msg( 
'revreview-check-flag-u-title' )->text();
-   $labelMsg = $this->msg( 
'revreview-check-flag-u' )->parse();
+   $options['title-message'] = 
'revreview-check-flag-u-title';
+   $options['label-message'] = 
'revreview-check-flag-u';
   

[MediaWiki-commits] [Gerrit] mediawiki...GreyStuff[master]: Fix stuff I broke, also changes

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/344807 )

Change subject: Fix stuff I broke, also changes
..


Fix stuff I broke, also changes

* Some more consistent naming, classes and ids
* Changed private functions to protected
* Half-arsed formatting for echo
* Made search better
* ...

Change-Id: I889f2dbb15d0a9f601d5210dd13f95c24d9a9adf
---
M GreyStuffTemplate.php
M resources/main.less
M resources/screen-full.less
M resources/screen-mobile.less
4 files changed, 93 insertions(+), 30 deletions(-)

Approvals:
  jenkins-bot: Verified
  Isarra: Looks good to me, approved



diff --git a/GreyStuffTemplate.php b/GreyStuffTemplate.php
index 8f05b25..bf8fc6b 100644
--- a/GreyStuffTemplate.php
+++ b/GreyStuffTemplate.php
@@ -18,13 +18,7 @@
  */
 class GreyStuffTemplate extends BaseTemplate {
 
-   /**
-* Template filter callback for GreyStuff skin.
-* Takes an associative array of data set from a SkinTemplate-based
-* class, and a wrapper for MediaWiki's localization database, and
-* outputs a formatted page.
-*/
-   function execute() {
+   public function execute() {
// Apparently not set by default?
$this->data['pageLanguage'] = 
$this->getSkin()->getTitle()->getPageViewLanguage()->getHtmlCode();
 
@@ -91,7 +85,7 @@
 
$this->clear() .
 
-   Html::rawElement( 'div', [ 'id' => 
'bodyContent', 'class' => 'mw-body' ],
+   Html::rawElement( 'div', [ 'id' => 
'bodyContent', 'class' => 'mw-body-content' ],
Html::rawElement( 'div', [ 'id' => 
'siteSub' ], $this->getMsg( 'tagline' ) ) .
$this->get( 'bodytext' ) .
$this->clear()
@@ -135,7 +129,7 @@
 *
 * @return string html
 */
-   private function getPortlet( $name, $content, $dropdown = false, $msg = 
null ) {
+   protected function getPortlet( $name, $content, $dropdown = false, $msg 
= null ) {
if ( $msg === null ) {
$msg = $name;
} elseif ( is_array( $msg ) ) {
@@ -185,7 +179,7 @@
$dropdown ? 'dropdown' : ''
] ],
$contentText .
-   $this->renderAfterPortlet( $name )
+   $this->getAfterPortlet( $name )
)
);
 
@@ -197,7 +191,7 @@
 *
 * @return string html
 */
-   private function getMainNavigation() {
+   protected function getMainNavigation() {
$html = '';
 
$sidebar = $this->getSidebar();
@@ -256,7 +250,7 @@
 *
 * @return string html
 */
-   private function getBanner() {
+   protected function getBanner() {
$html = Html::rawElement( 'div', [ 'class' => 'p-logo', 'role' 
=> 'banner' ],
Html::element( 'a', array_merge( [
'class' => 'mw-wiki-logo',
@@ -290,8 +284,22 @@
 *
 * @return string html
 */
-   private function getPersonalNavigation() {
+   protected function getPersonalNavigation() {
$user = $this->getSkin()->getUser();
+   $personalTools = $this->getPersonalTools();
+
+   $html = '';
+   $extraTools = [];
+
+   // Remove Echo badges
+   if ( isset( $personalTools['notifications-alert'] ) ) {
+   $extraTools['notifications-alert'] = 
$personalTools['notifications-alert'];
+   unset( $personalTools['notifications-alert'] );
+   }
+   if ( isset( $personalTools['notifications-notice'] ) ) {
+   $extraTools['notifications-notice'] = 
$personalTools['notifications-notice'];
+   unset( $personalTools['notifications-notice'] );
+   }
 
if ( $user->isLoggedIn() ) {
$headerMsg = [ 'greystuff-loggedinas', $user->getName() 
];
@@ -299,7 +307,8 @@
$headerMsg = 'greystuff-notloggedin';
}
 
-   $personalTools = $this->getPersonalTools();
+   $html .= Html::openElement( 'div', [ 'id' => 
'p-personal-container' ] );
+
if ( isset( $personalTools['userpage'] ) ) {
$personalTools['userpage']['links'][0]['text'] = 
$this->getMsg( 'greystuff-userpage' );
}
@@ -307,7 +316,25 @@
$personalTools['mytalk']['links'][0]['text'] = 
$this->getMsg( 'greystuff-talkpage' );
}
 
-   return $this->getPortlet( 

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Deploy Timeless skin to labs

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/344788 )

Change subject: Deploy Timeless skin to labs
..


Deploy Timeless skin to labs

Bug: T160643
Change-Id: Ic28c66de95e1f9c1ee83d07ade41c728fcb77d46
---
M wmf-config/CommonSettings-labs.php
M wmf-config/InitialiseSettings-labs.php
M wmf-config/extension-list-labs
3 files changed, 10 insertions(+), 0 deletions(-)

Approvals:
  Paladox: Looks good to me, but someone else must approve
  Bartosz Dziewoński: Looks good to me, but someone else must approve
  Luke081515: Looks good to me, but someone else must approve
  Harej: Looks good to me, but someone else must approve
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified
  Isarra: Looks good to me, but someone else must approve



diff --git a/wmf-config/CommonSettings-labs.php 
b/wmf-config/CommonSettings-labs.php
index fdd536c..2328f55 100644
--- a/wmf-config/CommonSettings-labs.php
+++ b/wmf-config/CommonSettings-labs.php
@@ -341,6 +341,11 @@
wfLoadExtension( 'CollaborationKit' );
 }
 
+if ( $wmgUseTimeless ) {
+   // Test new Isarra responsive skin
+   wfLoadSkin( 'Timeless' ); // T160643
+}
+
 $wgMessageCacheType = CACHE_ACCEL;
 
 // Let Beta Cluster Commons do upload-from-URL from production Commons.
diff --git a/wmf-config/InitialiseSettings-labs.php 
b/wmf-config/InitialiseSettings-labs.php
index 91a6606..6c321fa 100644
--- a/wmf-config/InitialiseSettings-labs.php
+++ b/wmf-config/InitialiseSettings-labs.php
@@ -609,5 +609,9 @@
'wmgEnableDashikiData' => [
'default' => true,
],
+
+   'wmgUseTimeless' => [
+   'default' => true,
+   ],
];
 } # wmflLabsSettings()
diff --git a/wmf-config/extension-list-labs b/wmf-config/extension-list-labs
index 3a5609a..da1257a 100644
--- a/wmf-config/extension-list-labs
+++ b/wmf-config/extension-list-labs
@@ -6,3 +6,4 @@
 $IP/extensions/Newsletter/extension.json
 $IP/extensions/PerformanceInspector/extension.json
 $IP/extensions/Sentry/extension.json
+$IP/skins/Timeless/skin.json

-- 
To view, visit https://gerrit.wikimedia.org/r/344788
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic28c66de95e1f9c1ee83d07ade41c728fcb77d46
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Dereckson 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Brian Wolff 
Gerrit-Reviewer: Dereckson 
Gerrit-Reviewer: Florianschmidtwelzow 
Gerrit-Reviewer: Harej 
Gerrit-Reviewer: Isarra 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Luke081515 
Gerrit-Reviewer: Paladox 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...GreyStuff[master]: Fix stuff I broke, also changes

[Isarra (Code Review)]

Isarra has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/344807 )

Change subject: Fix stuff I broke, also changes
..

Fix stuff I broke, also changes

I'm real specific shut up.

Change-Id: I889f2dbb15d0a9f601d5210dd13f95c24d9a9adf
---
M GreyStuffTemplate.php
M resources/main.less
M resources/screen-full.less
M resources/screen-mobile.less
4 files changed, 93 insertions(+), 30 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/GreyStuff 
refs/changes/07/344807/1

diff --git a/GreyStuffTemplate.php b/GreyStuffTemplate.php
index 8f05b25..bf8fc6b 100644
--- a/GreyStuffTemplate.php
+++ b/GreyStuffTemplate.php
@@ -18,13 +18,7 @@
  */
 class GreyStuffTemplate extends BaseTemplate {
 
-   /**
-* Template filter callback for GreyStuff skin.
-* Takes an associative array of data set from a SkinTemplate-based
-* class, and a wrapper for MediaWiki's localization database, and
-* outputs a formatted page.
-*/
-   function execute() {
+   public function execute() {
// Apparently not set by default?
$this->data['pageLanguage'] = 
$this->getSkin()->getTitle()->getPageViewLanguage()->getHtmlCode();
 
@@ -91,7 +85,7 @@
 
$this->clear() .
 
-   Html::rawElement( 'div', [ 'id' => 
'bodyContent', 'class' => 'mw-body' ],
+   Html::rawElement( 'div', [ 'id' => 
'bodyContent', 'class' => 'mw-body-content' ],
Html::rawElement( 'div', [ 'id' => 
'siteSub' ], $this->getMsg( 'tagline' ) ) .
$this->get( 'bodytext' ) .
$this->clear()
@@ -135,7 +129,7 @@
 *
 * @return string html
 */
-   private function getPortlet( $name, $content, $dropdown = false, $msg = 
null ) {
+   protected function getPortlet( $name, $content, $dropdown = false, $msg 
= null ) {
if ( $msg === null ) {
$msg = $name;
} elseif ( is_array( $msg ) ) {
@@ -185,7 +179,7 @@
$dropdown ? 'dropdown' : ''
] ],
$contentText .
-   $this->renderAfterPortlet( $name )
+   $this->getAfterPortlet( $name )
)
);
 
@@ -197,7 +191,7 @@
 *
 * @return string html
 */
-   private function getMainNavigation() {
+   protected function getMainNavigation() {
$html = '';
 
$sidebar = $this->getSidebar();
@@ -256,7 +250,7 @@
 *
 * @return string html
 */
-   private function getBanner() {
+   protected function getBanner() {
$html = Html::rawElement( 'div', [ 'class' => 'p-logo', 'role' 
=> 'banner' ],
Html::element( 'a', array_merge( [
'class' => 'mw-wiki-logo',
@@ -290,8 +284,22 @@
 *
 * @return string html
 */
-   private function getPersonalNavigation() {
+   protected function getPersonalNavigation() {
$user = $this->getSkin()->getUser();
+   $personalTools = $this->getPersonalTools();
+
+   $html = '';
+   $extraTools = [];
+
+   // Remove Echo badges
+   if ( isset( $personalTools['notifications-alert'] ) ) {
+   $extraTools['notifications-alert'] = 
$personalTools['notifications-alert'];
+   unset( $personalTools['notifications-alert'] );
+   }
+   if ( isset( $personalTools['notifications-notice'] ) ) {
+   $extraTools['notifications-notice'] = 
$personalTools['notifications-notice'];
+   unset( $personalTools['notifications-notice'] );
+   }
 
if ( $user->isLoggedIn() ) {
$headerMsg = [ 'greystuff-loggedinas', $user->getName() 
];
@@ -299,7 +307,8 @@
$headerMsg = 'greystuff-notloggedin';
}
 
-   $personalTools = $this->getPersonalTools();
+   $html .= Html::openElement( 'div', [ 'id' => 
'p-personal-container' ] );
+
if ( isset( $personalTools['userpage'] ) ) {
$personalTools['userpage']['links'][0]['text'] = 
$this->getMsg( 'greystuff-userpage' );
}
@@ -307,7 +316,25 @@
$personalTools['mytalk']['links'][0]['text'] = 
$this->getMsg( 'greystuff-talkpage' );
}
 
-   return $this->getPortlet( 'personal', 
$this->getPersonalTools(), true, $headerMsg );
+   // Re-add Echo badges
+   if ( 

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Revert "Simplify definition of 'ext.echo.badgeicons' module"

[Paladox (Code Review)]

Hello Bartosz Dziewoński, Catrope, jenkins-bot,

I'd like you to do a code review.  Please visit

https://gerrit.wikimedia.org/r/344806

to review the following change.


Change subject: Revert "Simplify definition of 'ext.echo.badgeicons' module"
..

Revert "Simplify definition of 'ext.echo.badgeicons' module"

This reverts commit c39fffd82f0f9e292bd2f9af62762fc7f6926ceb.

Change-Id: I9d40ae59d6b93d926831de02fd5c9db2359dc1ba
---
M extension.json
R modules/icons/apex/badgeicons.json
C modules/icons/mediawiki/badgeicons.json
3 files changed, 11 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo 
refs/changes/06/344806/1

diff --git a/extension.json b/extension.json
index 4f906bf..d96e2e9 100644
--- a/extension.json
+++ b/extension.json
@@ -519,9 +519,10 @@
]
},
"ext.echo.badgeicons": {
-   "class": "ResourceLoaderImageModule",
+   "class": "ResourceLoaderOOUIImageModule",
"position": "top",
-   "data": "icons/badgeicons.json",
+   "name": "badgeicons",
+   "rootPath": "icons",
"selectorWithoutVariant": ".oo-ui-icon-{name}",
"selectorWithVariant": 
".oo-ui-image-{variant}.oo-ui-icon-{name}"
}
diff --git a/modules/icons/badgeicons.json b/modules/icons/apex/badgeicons.json
similarity index 60%
rename from modules/icons/badgeicons.json
rename to modules/icons/apex/badgeicons.json
index 1593a5c..85ff3ca 100644
--- a/modules/icons/badgeicons.json
+++ b/modules/icons/apex/badgeicons.json
@@ -1,4 +1,5 @@
 {
+   "prefix": "oo-ui-icon",
"variants": {
"invert": {
"color": "#FF"
@@ -6,13 +7,13 @@
},
"images": {
"bell": {
-   "file": "icons/bell.svg"
+   "file": "../bell.svg"
},
"tray": {
-   "file": "icons/tray.svg"
+   "file": "../tray.svg"
},
"doubleCheck": {
-   "file": "icons/double-check.svg",
+   "file": "../double-check.svg",
"variants": [ "invert" ]
}
}
diff --git a/modules/icons/badgeicons.json 
b/modules/icons/mediawiki/badgeicons.json
similarity index 60%
copy from modules/icons/badgeicons.json
copy to modules/icons/mediawiki/badgeicons.json
index 1593a5c..85ff3ca 100644
--- a/modules/icons/badgeicons.json
+++ b/modules/icons/mediawiki/badgeicons.json
@@ -1,4 +1,5 @@
 {
+   "prefix": "oo-ui-icon",
"variants": {
"invert": {
"color": "#FF"
@@ -6,13 +7,13 @@
},
"images": {
"bell": {
-   "file": "icons/bell.svg"
+   "file": "../bell.svg"
},
"tray": {
-   "file": "icons/tray.svg"
+   "file": "../tray.svg"
},
"doubleCheck": {
-   "file": "icons/double-check.svg",
+   "file": "../double-check.svg",
"variants": [ "invert" ]
}
}

-- 
To view, visit https://gerrit.wikimedia.org/r/344806
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9d40ae59d6b93d926831de02fd5c9db2359dc1ba
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Paladox 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: EditPage: Refactor getCheckboxes() to allow changing the format

[Code Review]

Bartosz Dziewoński has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/344805 )

Change subject: EditPage: Refactor getCheckboxes() to allow changing the format
..

EditPage: Refactor getCheckboxes() to allow changing the format

getCheckboxes() directly generated the HTML for the
"This is a minor edit" and "Watch this page" checkboxes,
and allowed extensions to add more HTML checkboxes (and
modify existing ones) using the 'EditPageBeforeEditChecks'
hook. This prevents us from ever changing the format of
the HTML (e.g. to use OOUI checkboxes).

Introduce new method getCheckboxesDefinition(), which
generates the checkboxes in a machine-readable format,
with a new hook 'EditPageGetCheckboxesDefinition'.
Rewrite getCheckboxes() in terms of that. The old hook
'EditPageBeforeEditChecks' is now deprecated.

Change-Id: I3dbe973dcac6cba0c3a1ac5d983cafcfb49d833c
---
M RELEASE-NOTES-1.29
M docs/hooks.txt
M includes/EditPage.php
3 files changed, 80 insertions(+), 40 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/05/344805/1

diff --git a/RELEASE-NOTES-1.29 b/RELEASE-NOTES-1.29
index bd75eb7..c6ad77b 100644
--- a/RELEASE-NOTES-1.29
+++ b/RELEASE-NOTES-1.29
@@ -268,6 +268,8 @@
 * WikiRevision::$fileIsTemp was deprecated.
 * WikiRevision::$importer was deprecated.
 * WikiRevision::$user was deprecated.
+* Hook 'EditPageBeforeEditChecks' is now deprecated.
+  Use the new hook 'EditPageGetCheckboxesDefinition' instead.
 
 == Compatibility ==
 
diff --git a/docs/hooks.txt b/docs/hooks.txt
index 3a57563..a38f9bb 100644
--- a/docs/hooks.txt
+++ b/docs/hooks.txt
@@ -1404,10 +1404,12 @@
 &$buttons: Array of edit buttons "Save", "Preview", "Live", and "Diff"
 &$tabindex: HTML tabindex of the last edit check/button
 
-'EditPageBeforeEditChecks': Allows modifying the edit checks below the textarea
-in the edit form.
+'EditPageBeforeEditChecks': DEPRECATED! Use 'EditPageGetCheckboxesDefinition' 
instead,
+or 'EditPage::showStandardInputs:options' if you don't actually care about 
checkboxes
+and just want to add some HTML to the page.
+Allows modifying the edit checks below the textarea in the edit form.
 &$editpage: The current EditPage object
-&$checks: Array of edit checks like "watch this page"/"minor edit"
+&$checks: Array of the HTML for edit checks like "watch this page"/"minor edit"
 &$tabindex: HTML tabindex of the last edit check/button
 
 'EditPageBeforeEditToolbar': Allows modifying the edit toolbar above the
@@ -1420,6 +1422,12 @@
 &$msg: localization message name, overridable. Default is either
   'copyrightwarning' or 'copyrightwarning2'.
 
+'EditPageGetCheckboxesDefinition': Allows modifying the edit checkboxes
+below the textarea in the edit form.
+$editpage: The current EditPage object
+&$checkboxes: Array of checkbox definitions. See 
EditPage::getCheckboxesDefinition()
+for the format.
+
 'EditPageGetDiffContent': Allow modifying the wikitext that will be used in
 "Show changes". Note that it is preferable to implement diff handling for
 different data types using the ContentHandler facility.
diff --git a/includes/EditPage.php b/includes/EditPage.php
index ac62e3f..1bbd816 100644
--- a/includes/EditPage.php
+++ b/includes/EditPage.php
@@ -4006,6 +4006,54 @@
}
 
/**
+* Return an array of checkbox definitions.
+*
+* Array keys correspond to the `` 'name' attribute to use for 
each checkbox.
+*
+* Array values are associative arrays with the following keys:
+*  - 'label-message' (required): message for label text
+*  - 'tooltip' (optional): used to generate 'title' and 'accesskey' 
attributes from messages like
+*'tooltip-foo', 'accesskey-foo'
+*  - 'id' (optional): 'id' attribute for the ``
+*  - 'label-id' (optional): 'id' attribute for the ``
+*  - 'legacy-name' (optional): short name for backwards-compatibility
+*
+* @return array
+*/
+   protected function getCheckboxesDefinition() {
+   global $wgUser;
+   $checkboxes = [];
+
+   // don't show the minor edit checkbox if it's a new page or 
section
+   if ( !$this->isNew && $wgUser->isAllowed( 'minoredit' ) ) {
+   $checkboxes['wpMinoredit'] = [
+   'id' => 'wpMinoredit',
+   'label-message' => 'minoredit',
+   // Uses messages: tooltip-minoredit, 
accesskey-minoredit
+   'tooltip' => 'minoredit',
+   'label-id' => 'mw-editpage-minoredit',
+   'legacy-name' => 'minor',
+   ];
+   }
+
+   if ( $wgUser->isLoggedIn() ) {
+   $checkboxes['wpWatchthis'] = [
+   'id' => 

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add some common functions to BaseTemplate

[Isarra (Code Review)]

Isarra has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/344804 )

Change subject: Add some common functions to BaseTemplate
..

Add some common functions to BaseTemplate

Breaks any skins with same-name functions with different
visibility.

* getPortlet: essentially renderPortlet from Vector,
  outputPortlet from Example, getPortlet from Timeless etc
* clear: returns a visualClear
* getFooter: wraps getFooterIcons and getFooterLinks and
  handles all the output; format is common to nearly every
  skin since MonoBook
* getAfterPortlet: same as renderAfterPortlet, but doesn't
  directly print content
* getTrail: same as printTrail, but doesn't directly print
  content

Also some formatting fixes for related functions.

Change-Id: I5621f585b501e47b40ae80e9cb12e6a32da72275
---
M includes/skins/BaseTemplate.php
1 file changed, 170 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/04/344804/1

diff --git a/includes/skins/BaseTemplate.php b/includes/skins/BaseTemplate.php
index e571c58..785c851 100644
--- a/includes/skins/BaseTemplate.php
+++ b/includes/skins/BaseTemplate.php
@@ -291,7 +291,32 @@
Hooks::run( 'BaseTemplateAfterPortlet', [ $this, $name, 
&$content ] );
 
if ( $content !== '' ) {
-   echo "$content";
+   echo Html::rawElement(
+   'div',
+   [ 'class' => [ 'after-portlet', 
'after-portlet-' . $name ] ],
+   $content
+   );
+   }
+   }
+
+   /**
+* The same as renderAfterPortlet(), but returns the content instead of
+* printing it
+*
+* @param string $name
+*
+* @return string html
+*/
+   protected function getAfterPortlet( $name ) {
+   $content = '';
+   Hooks::run( 'BaseTemplateAfterPortlet', [ $this, $name, 
&$content ] );
+
+   if ( $content !== '' ) {
+   return Html::rawElement(
+   'div',
+   [ 'class' => [ 'after-portlet', 
'after-portlet-' . $name ] ],
+   $content
+   );
}
}
 
@@ -499,6 +524,73 @@
return Html::rawElement( isset( $options['tag'] ) ? 
$options['tag'] : 'li', $attrs, $html );
}
 
+   /**
+* Generates a block of navigation links with a header
+*
+* @param string $name
+* @param array|string $content array of links for use with 
makeListItem, or a block of text
+* @param null|string|array|bool $msg
+*
+* @return string html
+*/
+   private function getPortlet( $name, $content, $msg = null ) {
+   if ( $msg === null ) {
+   $msg = $name;
+   } elseif ( is_array( $msg ) ) {
+   $msgString = array_shift( $msg );
+   $msgParams = $msg;
+   $msg = $msgString;
+   }
+   $msgObj = wfMessage( $msg );
+   if ( $msgObj->exists() ) {
+   if ( isset( $msgParams ) && !empty( $msgParams ) ) {
+   $msgString = $this->getMsg( $msg, $msgParams 
)->parse();
+   } else {
+   $msgString = $msgObj->parse();
+   }
+   } else {
+   $msgString = htmlspecialchars( $msg );
+   }
+
+   $labelId = Sanitizer::escapeId( "p-$name-label" );
+
+   if ( is_array( $content ) ) {
+   $contentText = Html::openElement( 'ul' );
+   foreach ( $content as $key => $item ) {
+   $contentText .= $this->makeListItem(
+   $key,
+   $item,
+   [ 'text-wrapper' => [ 'tag' => 'span' ] 
]
+   );
+   }
+   $contentText .= Html::closeElement( 'ul' );
+   } else {
+   $contentText = $content;
+   }
+
+   $html = Html::rawElement( 'div', [
+   'role' => 'navigation',
+   'class' => 'mw-portlet',
+   'id' => Sanitizer::escapeId( 'p-' . $name ),
+   'title' => Linker::titleAttrib( 'p-' . $name ),
+   'aria-labelledby' => $labelId
+   ],
+   Html::rawElement( 'h3', [
+   'id' => $labelId,
+   'lang' => 

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Defer rendering of visual diff until tab is selected

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/344782 )

Change subject: Defer rendering of visual diff until tab is selected
..


Defer rendering of visual diff until tab is selected

Bug: T161355
Change-Id: I718a92f4c9f8c3a48e359da898ede7dccebcec5e
---
M modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
1 file changed, 22 insertions(+), 6 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js 
b/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
index 8df5de4..249b223 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
@@ -124,11 +124,11 @@
 ve.ui.MWSaveDialog.prototype.setDiffAndReview = function ( wikitextDiff, 
visualDiff ) {
this.$reviewVisualDiff.empty();
if ( visualDiff ) {
-   this.diffElement = new ve.ui.DiffElement( visualDiff );
-   this.diffElement.$document.addClass( 'mw-body-content' );
-   // TODO: Remove when fixed upstream in Parsoid (T58756)
-   this.diffElement.$element.find( 'a[rel="mw:ExtLink"]' 
).addClass( 'external' );
-   this.$reviewVisualDiff.append( this.diffElement.$element );
+   if ( this.diffElement ) {
+   this.diffElement.destroy();
+   this.diffElement = null;
+   }
+   this.visualDiff = visualDiff;
this.reviewModeButtonSelect.getItemFromData( 'visual' 
).setDisabled( false );
} else {
// TODO: Support visual diffs in source mode (epic)
@@ -184,6 +184,10 @@
this.$reviewWikitextDiff.empty();
this.$previewViewer.empty();
this.hasDiff = false;
+   if ( this.diffElement ) {
+   this.diffElement.destroy();
+   this.diffElement = null;
+   }
 };
 
 /**
@@ -590,9 +594,17 @@
var isVisual = this.reviewModeButtonSelect.getSelectedItem().getData() 
=== 'visual';
this.$reviewVisualDiff.toggleClass( 'oo-ui-element-hidden', !isVisual );
this.$reviewWikitextDiff.toggleClass( 'oo-ui-element-hidden', isVisual 
);
-   this.updateSize();
if ( isVisual ) {
+   if ( !this.diffElement ) {
+   this.diffElement = new ve.ui.DiffElement( 
this.visualDiff );
+   this.diffElement.$document.addClass( 'mw-body-content' 
);
+   // TODO: Remove when fixed upstream in Parsoid (T58756)
+   this.diffElement.$element.find( 'a[rel="mw:ExtLink"]' 
).addClass( 'external' );
+   this.$reviewVisualDiff.append( 
this.diffElement.$element );
+   }
this.diffElement.positionDescriptions();
+   this.updateSize();
+   } else {
this.updateSize();
}
 };
@@ -663,6 +675,10 @@
 ve.ui.MWSaveDialog.prototype.getTeardownProcess = function ( data ) {
return ve.ui.MWSaveDialog.super.prototype.getTeardownProcess.call( 
this, data )
.next( function () {
+   if ( this.diffElement ) {
+   this.diffElement.destroy();
+   this.diffElement = null;
+   }
this.emit( 'close' );
}, this );
 };

-- 
To view, visit https://gerrit.wikimedia.org/r/344782
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I718a92f4c9f8c3a48e359da898ede7dccebcec5e
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Update VE core submodule to master (15ee3e37d)

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/344803 )

Change subject: Update VE core submodule to master (15ee3e37d)
..

Update VE core submodule to master (15ee3e37d)

New changes:
e0651b2df Move -hasDescriptions class toggle into #renderDiff
94dbb244d Fix dm.BlockquoteNode to inherit from ContentBranchNode
8715f7be7 Remove superfluous setting of canContainContent when inheriting from 
CBN
88e5b918d Replace instanceof ContentBranchNode with #canContainContent
c4b404408 DiffTreeNode: Use getters for type and attributes

Bug: T161262
Change-Id: I1a54293f9a2e0b27adc4fa0708b8dc1fdcca16b0
---
M lib/ve
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/03/344803/1

diff --git a/lib/ve b/lib/ve
index 7b51cb6..15ee3e3 16
--- a/lib/ve
+++ b/lib/ve
@@ -1 +1 @@
-Subproject commit 7b51cb6aba3cf7e46cb2dfe78ea0bc91e6145303
+Subproject commit 15ee3e37dc3524b97f40e7068a5517eb073c76b4

-- 
To view, visit https://gerrit.wikimedia.org/r/344803
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1a54293f9a2e0b27adc4fa0708b8dc1fdcca16b0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Move -hasDescriptions class toggle into #renderDiff

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/344783 )

Change subject: Move -hasDescriptions class toggle into #renderDiff
..


Move -hasDescriptions class toggle into #renderDiff

Makes more sense to have it here.

Change-Id: I72b6c9a1b816df9f1112177abc64233e628e6417
---
M src/ui/elements/ve.ui.DiffElement.js
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/src/ui/elements/ve.ui.DiffElement.js 
b/src/ui/elements/ve.ui.DiffElement.js
index 379735a..ff20f1c 100644
--- a/src/ui/elements/ve.ui.DiffElement.js
+++ b/src/ui/elements/ve.ui.DiffElement.js
@@ -57,8 +57,8 @@
this.$sidebar.append( this.descriptions.$element )
)
.addClass( 've-ui-diffElement' );
+
this.renderDiff();
-   this.$element.toggleClass( 've-ui-diffElement-hasDescriptions', 
!this.descriptions.isEmpty() );
 };
 
 /* Inheritance */
@@ -294,6 +294,8 @@
documentNode.innerHTML = '';
documentNode.appendChild( noChanges );
}
+
+   this.$element.toggleClass( 've-ui-diffElement-hasDescriptions', 
!this.descriptions.isEmpty() );
 };
 
 /**

-- 
To view, visit https://gerrit.wikimedia.org/r/344783
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I72b6c9a1b816df9f1112177abc64233e628e6417
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: DiffTreeNode: Use getters for type and attributes

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/344802 )

Change subject: DiffTreeNode: Use getters for type and attributes
..


DiffTreeNode: Use getters for type and attributes

Avoids undefined object accesses.

Change-Id: I1d3be11df2f6522cb5d38ea356fc59730bd39112
---
M src/ve.DiffTreeNode.js
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/src/ve.DiffTreeNode.js b/src/ve.DiffTreeNode.js
index 964cef4..3dbf09e 100644
--- a/src/ve.DiffTreeNode.js
+++ b/src/ve.DiffTreeNode.js
@@ -42,8 +42,8 @@
return JSON.stringify( this.doc.getData( 
this.node.getOuterRange() ) ) ===
JSON.stringify( otherNode.doc.getData( 
otherNode.node.getOuterRange() ) );
} else {
-   return ( this.node.element.type === otherNode.node.element.type 
&&
-   ve.compare( this.node.element.attributes, 
otherNode.node.element.attributes ) );
+   return ( this.node.getType() === otherNode.node.getType() &&
+   ve.compare( this.node.getAttributes(), 
otherNode.node.getAttributes() ) );
}
 };
 

-- 
To view, visit https://gerrit.wikimedia.org/r/344802
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1d3be11df2f6522cb5d38ea356fc59730bd39112
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Replace instanceof ContentBranchNode with #canContainContent

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/344801 )

Change subject: Replace instanceof ContentBranchNode with #canContainContent
..


Replace instanceof ContentBranchNode with #canContainContent

Change-Id: I3d3968c9017245247673e317b7ff48c064c97313
---
M src/ce/ve.ce.Surface.js
M src/dm/ve.dm.VisualDiff.js
M src/ui/elements/ve.ui.DiffElement.js
M src/ve.DiffTreeNode.js
4 files changed, 10 insertions(+), 11 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/src/ce/ve.ce.Surface.js b/src/ce/ve.ce.Surface.js
index e3fabf0..fabb2d0 100644
--- a/src/ce/ve.ce.Surface.js
+++ b/src/ce/ve.ce.Surface.js
@@ -2239,7 +2239,7 @@
// (which wouldn't put the open and close tags in the clipboard 
to begin with).
if (
pastedNodes.length === 1 &&
-   pastedNodes[ 0 ].node instanceof ve.dm.ContentBranchNode
+   pastedNodes[ 0 ].node.canContainContent()
) {
if ( contextRange.containsRange( pastedNodes[ 0 
].nodeRange ) ) {
contextRange = pastedNodes[ 0 ].nodeRange;
diff --git a/src/dm/ve.dm.VisualDiff.js b/src/dm/ve.dm.VisualDiff.js
index 353fa52..534faca 100644
--- a/src/dm/ve.dm.VisualDiff.js
+++ b/src/dm/ve.dm.VisualDiff.js
@@ -266,8 +266,7 @@
oldNode = oldDocChildTree.orderedNodes[ treeDiff[ i ][ 
0 ] ].node;
newNode = newDocChildTree.orderedNodes[ treeDiff[ i ][ 
1 ] ].node;
 
-   if ( !( oldNode instanceof ve.dm.ContentBranchNode ) &&
-   !( newNode instanceof ve.dm.ContentBranchNode ) 
) {
+   if ( !oldNode.canContainContent() && 
!newNode.canContainContent() ) {
 
// There is no content change
diffInfo[ i ] = {
@@ -281,13 +280,13 @@
};
continue;
 
-   } else if ( !( newNode instanceof 
ve.dm.ContentBranchNode ) ) {
+   } else if ( !newNode.canContainContent() ) {
 
// Content was removed
diffInfo[ i ] = { replacement: true };
removeLength = oldNode.length;
 
-   } else if ( !( oldNode instanceof 
ve.dm.ContentBranchNode ) ) {
+   } else if ( !oldNode.canContainContent() ) {
 
// Content was inserted
diffInfo[ i ] = { replacement: true };
@@ -334,7 +333,7 @@
 
// Node was removed
oldNode = oldDocChildTree.orderedNodes[ treeDiff[ i ][ 
0 ] ];
-   if ( oldNode.node instanceof ve.dm.ContentBranchNode ) {
+   if ( oldNode.node.canContainContent() ) {
removeLength = oldNode.node.length;
}
 
@@ -342,7 +341,7 @@
 
// Node was inserted
newNode = newDocChildTree.orderedNodes[ treeDiff[ i ][ 
1 ] ];
-   if ( newNode.node instanceof ve.dm.ContentBranchNode ) {
+   if ( newNode.node.canContainContent() ) {
insertLength = newNode.node.length;
}
 
diff --git a/src/ui/elements/ve.ui.DiffElement.js 
b/src/ui/elements/ve.ui.DiffElement.js
index 379735a..cbd07d6 100644
--- a/src/ui/elements/ve.ui.DiffElement.js
+++ b/src/ui/elements/ve.ui.DiffElement.js
@@ -409,7 +409,7 @@
 
node = oldNodes[ nodeIndex ];
 
-   if ( !( node.node instanceof ve.dm.ContentBranchNode ) ) {
+   if ( !node.node.canContainContent() ) {
 
// Record that the node has been removed, but don't 
display it, for now
// TODO: describe the change for the attribute diff
@@ -494,7 +494,7 @@
// Add insert class
nodeData[ nodeRangeStart ] = this.addAttributesToNode(
nodeData[ nodeRangeStart ], this.newDoc, {
-   'data-diff-action': node.node instanceof 
ve.dm.ContentBranchNode ? 'insert' : 'structural-insert'
+   'data-diff-action': 
node.node.canContainContent() ? 'insert' : 'structural-insert'
}
);
}
diff --git a/src/ve.DiffTreeNode.js b/src/ve.DiffTreeNode.js
index 1131159..964cef4 100644
--- a/src/ve.DiffTreeNode.js
+++ b/src/ve.DiffTreeNode.js
@@ -38,7 +38,7 @@
  * @return {boolean} The nodes are equal
  */
 ve.DiffTreeNode.prototype.isEqual = function ( otherNode ) {
-   if ( this.node instanceof ve.dm.ContentBranchNode && 

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove superfluous setting of canContainContent when inherit...

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/344800 )

Change subject: Remove superfluous setting of canContainContent when inheriting 
from CBN
..


Remove superfluous setting of canContainContent when inheriting from CBN

Change-Id: Ieb318ad9febb155e669fbd52cdd53a7a19d1b927
---
M src/dm/nodes/ve.dm.HeadingNode.js
M src/dm/nodes/ve.dm.ParagraphNode.js
M src/dm/nodes/ve.dm.PreformattedNode.js
3 files changed, 0 insertions(+), 6 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/src/dm/nodes/ve.dm.HeadingNode.js 
b/src/dm/nodes/ve.dm.HeadingNode.js
index a0a6ec0..495fa73 100644
--- a/src/dm/nodes/ve.dm.HeadingNode.js
+++ b/src/dm/nodes/ve.dm.HeadingNode.js
@@ -27,8 +27,6 @@
 
 ve.dm.HeadingNode.static.name = 'heading';
 
-ve.dm.HeadingNode.static.canContainContent = true;
-
 ve.dm.HeadingNode.static.defaultAttributes = {
level: 1
 };
diff --git a/src/dm/nodes/ve.dm.ParagraphNode.js 
b/src/dm/nodes/ve.dm.ParagraphNode.js
index 8d30baf..2261fd6 100644
--- a/src/dm/nodes/ve.dm.ParagraphNode.js
+++ b/src/dm/nodes/ve.dm.ParagraphNode.js
@@ -27,8 +27,6 @@
 
 ve.dm.ParagraphNode.static.name = 'paragraph';
 
-ve.dm.ParagraphNode.static.canContainContent = true;
-
 ve.dm.ParagraphNode.static.matchTagNames = [ 'p' ];
 
 /* Registration */
diff --git a/src/dm/nodes/ve.dm.PreformattedNode.js 
b/src/dm/nodes/ve.dm.PreformattedNode.js
index 94ad080..98b5ecf 100644
--- a/src/dm/nodes/ve.dm.PreformattedNode.js
+++ b/src/dm/nodes/ve.dm.PreformattedNode.js
@@ -27,8 +27,6 @@
 
 ve.dm.PreformattedNode.static.name = 'preformatted';
 
-ve.dm.PreformattedNode.static.canContainContent = true;
-
 ve.dm.PreformattedNode.static.hasSignificantWhitespace = true;
 
 ve.dm.PreformattedNode.static.matchTagNames = [ 'pre' ];

-- 
To view, visit https://gerrit.wikimedia.org/r/344800
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb318ad9febb155e669fbd52cdd53a7a19d1b927
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Fix dm.BlockquoteNode to inherit from ContentBranchNode

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/344799 )

Change subject: Fix dm.BlockquoteNode to inherit from ContentBranchNode
..


Fix dm.BlockquoteNode to inherit from ContentBranchNode

It is already effectively a CBN, but it should inherit from it too.

Bug: T161262
Change-Id: Ib1ef7561fd2b47ebe26edd2a8e4907ddde7464f9
---
M src/dm/nodes/ve.dm.BlockquoteNode.js
1 file changed, 1 insertion(+), 3 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/src/dm/nodes/ve.dm.BlockquoteNode.js 
b/src/dm/nodes/ve.dm.BlockquoteNode.js
index 6440768..aea9018 100644
--- a/src/dm/nodes/ve.dm.BlockquoteNode.js
+++ b/src/dm/nodes/ve.dm.BlockquoteNode.js
@@ -21,13 +21,11 @@
 
 /* Inheritance */
 
-OO.inheritClass( ve.dm.BlockquoteNode, ve.dm.BranchNode );
+OO.inheritClass( ve.dm.BlockquoteNode, ve.dm.ContentBranchNode );
 
 /* Static Properties */
 
 ve.dm.BlockquoteNode.static.name = 'blockquote';
-
-ve.dm.BlockquoteNode.static.canContainContent = true;
 
 ve.dm.BlockquoteNode.static.matchTagNames = [ 'blockquote' ];
 

-- 
To view, visit https://gerrit.wikimedia.org/r/344799
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1ef7561fd2b47ebe26edd2a8e4907ddde7464f9
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Throw RuntimeException when caching doesn't work in testDisp...

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/344751 )

Change subject: Throw RuntimeException when caching doesn't work in 
testDispatchCoordinator
..


Throw RuntimeException when caching doesn't work in testDispatchCoordinator

Bug: T157308
Change-Id: If179be912f3b5de680533abf9ba618d6ca4fb1b3
---
M repo/tests/testDispatchCoordinator.php
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Daniel Kinzler: Looks good to me, approved
  jenkins-bot: Verified
  Thiemo Mättig (WMDE): Looks good to me, but someone else must approve



diff --git a/repo/tests/testDispatchCoordinator.php 
b/repo/tests/testDispatchCoordinator.php
index 4047f1e..1565f81 100644
--- a/repo/tests/testDispatchCoordinator.php
+++ b/repo/tests/testDispatchCoordinator.php
@@ -7,6 +7,7 @@
 use Maintenance;
 use MediaWiki\MediaWikiServices;
 use MWException;
+use RuntimeException;
 use WANObjectCache;
 use Wikibase\Repo\Store\Sql\LockManagerSqlChangeDispatchCoordinator;
 use Wikibase\Repo\WikibaseRepo;
@@ -147,6 +148,9 @@
private function readTestValue( $key ) {
$memcKey = wfMemcKey( 'test-dispatch-coordinator-' . $key );
$value = $this->cache->get( $memcKey );
+   if ( $value === null ) {
+   throw new RuntimeException( "Caching mechanism doesn't 
work as expected." );
+   }
$this->log( "Got cache key $key: $value" );
return is_string( $value ) ? (int)$value : $value;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/344751
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If179be912f3b5de680533abf9ba618d6ca4fb1b3
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Ladsgroup 
Gerrit-Reviewer: Daniel Kinzler 
Gerrit-Reviewer: Ladsgroup 
Gerrit-Reviewer: Thiemo Mättig (WMDE) 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Document dispatchingLockManager option in $wgWBRepoSettings

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/344750 )

Change subject: Document dispatchingLockManager option in $wgWBRepoSettings
..


Document dispatchingLockManager option in $wgWBRepoSettings

Bug: T151993
Change-Id: I4a43053400584d74eb93fb890c2f663db01f8942
---
M docs/options.wiki
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Daniel Kinzler: Looks good to me, approved
  jenkins-bot: Verified
  Thiemo Mättig (WMDE): Looks good to me, but someone else must approve



diff --git a/docs/options.wiki b/docs/options.wiki
index bba0710..cd5e5be 100644
--- a/docs/options.wiki
+++ b/docs/options.wiki
@@ -52,6 +52,7 @@
 ;pagePropertiesRdf: Array that maps between page properties and Wikibase 
predicates for RDF dumps. Maps from database property name to an array that 
contains a key 'name' (RDF property name, which will be prefixed 
by wikibase:) and an optional key 'type'.
 ;unitStorage: Definition for unit conversion storage. Should be in in the 
format ObjectFactory understands, example: array( 'class' => 
'Wikibase\\Lib\\JsonUnitStorage',  'args' => array( 'myUnits.json' ) ).
 ;supportedEntityTypesForEntitiesWithoutTermListings: Array of entity types 
that are supported on Special:EntitiesWithoutLabel and …Description, typically 
'item' and 'property'. Defaults to null, 
which enables all numeric entity types.
+;dispatchingLockManager: If you want to use another lock mechanism for 
dispatching changes to clients instead of database locking (which can occupy 
too many connections to the master database), set its name in this config. See 
$wgLockManagers documentation in MediaWiki core for more information on 
configuring a locking mechanism inside core.
 
 == Client Settings ==
 

-- 
To view, visit https://gerrit.wikimedia.org/r/344750
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4a43053400584d74eb93fb890c2f663db01f8942
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Ladsgroup 
Gerrit-Reviewer: Aleksey Bekh-Ivanov (WMDE) 
Gerrit-Reviewer: Daniel Kinzler 
Gerrit-Reviewer: Ladsgroup 
Gerrit-Reviewer: Thiemo Mättig (WMDE) 
Gerrit-Reviewer: WMDE-leszek 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: DiffTreeNode: Use getters for type and attributes

[Esanders (Code Review)]

Esanders has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/344802 )

Change subject: DiffTreeNode: Use getters for type and attributes
..

DiffTreeNode: Use getters for type and attributes

Avoids undefined object accesses.

Change-Id: I1d3be11df2f6522cb5d38ea356fc59730bd39112
---
M src/ve.DiffTreeNode.js
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/02/344802/1

diff --git a/src/ve.DiffTreeNode.js b/src/ve.DiffTreeNode.js
index 964cef4..3dbf09e 100644
--- a/src/ve.DiffTreeNode.js
+++ b/src/ve.DiffTreeNode.js
@@ -42,8 +42,8 @@
return JSON.stringify( this.doc.getData( 
this.node.getOuterRange() ) ) ===
JSON.stringify( otherNode.doc.getData( 
otherNode.node.getOuterRange() ) );
} else {
-   return ( this.node.element.type === otherNode.node.element.type 
&&
-   ve.compare( this.node.element.attributes, 
otherNode.node.element.attributes ) );
+   return ( this.node.getType() === otherNode.node.getType() &&
+   ve.compare( this.node.getAttributes(), 
otherNode.node.getAttributes() ) );
}
 };
 

-- 
To view, visit https://gerrit.wikimedia.org/r/344802
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d3be11df2f6522cb5d38ea356fc59730bd39112
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Replace instanceof ContentBranchNode with #canContainContent

[Esanders (Code Review)]

Esanders has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/344801 )

Change subject: Replace instanceof ContentBranchNode with #canContainContent
..

Replace instanceof ContentBranchNode with #canContainContent

Change-Id: I3d3968c9017245247673e317b7ff48c064c97313
---
M src/ce/ve.ce.Surface.js
M src/dm/ve.dm.VisualDiff.js
M src/ui/elements/ve.ui.DiffElement.js
M src/ve.DiffTreeNode.js
4 files changed, 11 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/01/344801/1

diff --git a/src/ce/ve.ce.Surface.js b/src/ce/ve.ce.Surface.js
index e3fabf0..fabb2d0 100644
--- a/src/ce/ve.ce.Surface.js
+++ b/src/ce/ve.ce.Surface.js
@@ -2239,7 +2239,7 @@
// (which wouldn't put the open and close tags in the clipboard 
to begin with).
if (
pastedNodes.length === 1 &&
-   pastedNodes[ 0 ].node instanceof ve.dm.ContentBranchNode
+   pastedNodes[ 0 ].node.canContainContent()
) {
if ( contextRange.containsRange( pastedNodes[ 0 
].nodeRange ) ) {
contextRange = pastedNodes[ 0 ].nodeRange;
diff --git a/src/dm/ve.dm.VisualDiff.js b/src/dm/ve.dm.VisualDiff.js
index 353fa52..534faca 100644
--- a/src/dm/ve.dm.VisualDiff.js
+++ b/src/dm/ve.dm.VisualDiff.js
@@ -266,8 +266,7 @@
oldNode = oldDocChildTree.orderedNodes[ treeDiff[ i ][ 
0 ] ].node;
newNode = newDocChildTree.orderedNodes[ treeDiff[ i ][ 
1 ] ].node;
 
-   if ( !( oldNode instanceof ve.dm.ContentBranchNode ) &&
-   !( newNode instanceof ve.dm.ContentBranchNode ) 
) {
+   if ( !oldNode.canContainContent() && 
!newNode.canContainContent() ) {
 
// There is no content change
diffInfo[ i ] = {
@@ -281,13 +280,13 @@
};
continue;
 
-   } else if ( !( newNode instanceof 
ve.dm.ContentBranchNode ) ) {
+   } else if ( !newNode.canContainContent() ) {
 
// Content was removed
diffInfo[ i ] = { replacement: true };
removeLength = oldNode.length;
 
-   } else if ( !( oldNode instanceof 
ve.dm.ContentBranchNode ) ) {
+   } else if ( !oldNode.canContainContent() ) {
 
// Content was inserted
diffInfo[ i ] = { replacement: true };
@@ -334,7 +333,7 @@
 
// Node was removed
oldNode = oldDocChildTree.orderedNodes[ treeDiff[ i ][ 
0 ] ];
-   if ( oldNode.node instanceof ve.dm.ContentBranchNode ) {
+   if ( oldNode.node.canContainContent() ) {
removeLength = oldNode.node.length;
}
 
@@ -342,7 +341,7 @@
 
// Node was inserted
newNode = newDocChildTree.orderedNodes[ treeDiff[ i ][ 
1 ] ];
-   if ( newNode.node instanceof ve.dm.ContentBranchNode ) {
+   if ( newNode.node.canContainContent() ) {
insertLength = newNode.node.length;
}
 
diff --git a/src/ui/elements/ve.ui.DiffElement.js 
b/src/ui/elements/ve.ui.DiffElement.js
index 379735a..cbd07d6 100644
--- a/src/ui/elements/ve.ui.DiffElement.js
+++ b/src/ui/elements/ve.ui.DiffElement.js
@@ -409,7 +409,7 @@
 
node = oldNodes[ nodeIndex ];
 
-   if ( !( node.node instanceof ve.dm.ContentBranchNode ) ) {
+   if ( !node.node.canContainContent() ) {
 
// Record that the node has been removed, but don't 
display it, for now
// TODO: describe the change for the attribute diff
@@ -494,7 +494,7 @@
// Add insert class
nodeData[ nodeRangeStart ] = this.addAttributesToNode(
nodeData[ nodeRangeStart ], this.newDoc, {
-   'data-diff-action': node.node instanceof 
ve.dm.ContentBranchNode ? 'insert' : 'structural-insert'
+   'data-diff-action': 
node.node.canContainContent() ? 'insert' : 'structural-insert'
}
);
}
diff --git a/src/ve.DiffTreeNode.js b/src/ve.DiffTreeNode.js
index 1131159..150e2f1 100644
--- a/src/ve.DiffTreeNode.js
+++ b/src/ve.DiffTreeNode.js
@@ -38,11 +38,11 @@
  * @return {boolean} The nodes are equal
  */
 ve.DiffTreeNode.prototype.isEqual = function ( otherNode ) {
-   if ( this.node instanceof ve.dm.ContentBranchNode 

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove superfluous setting of canContainContent when inherit...

[Esanders (Code Review)]

Esanders has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/344800 )

Change subject: Remove superfluous setting of canContainContent when inheriting 
from CBN
..

Remove superfluous setting of canContainContent when inheriting from CBN

Change-Id: Ieb318ad9febb155e669fbd52cdd53a7a19d1b927
---
M src/dm/nodes/ve.dm.HeadingNode.js
M src/dm/nodes/ve.dm.ParagraphNode.js
M src/dm/nodes/ve.dm.PreformattedNode.js
3 files changed, 0 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/00/344800/1

diff --git a/src/dm/nodes/ve.dm.HeadingNode.js 
b/src/dm/nodes/ve.dm.HeadingNode.js
index a0a6ec0..495fa73 100644
--- a/src/dm/nodes/ve.dm.HeadingNode.js
+++ b/src/dm/nodes/ve.dm.HeadingNode.js
@@ -27,8 +27,6 @@
 
 ve.dm.HeadingNode.static.name = 'heading';
 
-ve.dm.HeadingNode.static.canContainContent = true;
-
 ve.dm.HeadingNode.static.defaultAttributes = {
level: 1
 };
diff --git a/src/dm/nodes/ve.dm.ParagraphNode.js 
b/src/dm/nodes/ve.dm.ParagraphNode.js
index 8d30baf..2261fd6 100644
--- a/src/dm/nodes/ve.dm.ParagraphNode.js
+++ b/src/dm/nodes/ve.dm.ParagraphNode.js
@@ -27,8 +27,6 @@
 
 ve.dm.ParagraphNode.static.name = 'paragraph';
 
-ve.dm.ParagraphNode.static.canContainContent = true;
-
 ve.dm.ParagraphNode.static.matchTagNames = [ 'p' ];
 
 /* Registration */
diff --git a/src/dm/nodes/ve.dm.PreformattedNode.js 
b/src/dm/nodes/ve.dm.PreformattedNode.js
index 94ad080..98b5ecf 100644
--- a/src/dm/nodes/ve.dm.PreformattedNode.js
+++ b/src/dm/nodes/ve.dm.PreformattedNode.js
@@ -27,8 +27,6 @@
 
 ve.dm.PreformattedNode.static.name = 'preformatted';
 
-ve.dm.PreformattedNode.static.canContainContent = true;
-
 ve.dm.PreformattedNode.static.hasSignificantWhitespace = true;
 
 ve.dm.PreformattedNode.static.matchTagNames = [ 'pre' ];

-- 
To view, visit https://gerrit.wikimedia.org/r/344800
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieb318ad9febb155e669fbd52cdd53a7a19d1b927
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Fix dm.BlockquoteNode to inherit from ContentBranchNode

[Esanders (Code Review)]

Esanders has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/344799 )

Change subject: Fix dm.BlockquoteNode to inherit from ContentBranchNode
..

Fix dm.BlockquoteNode to inherit from ContentBranchNode

It is already effectively a CBN, but it should inherit from it too.

Bug: T161262
Change-Id: Ib1ef7561fd2b47ebe26edd2a8e4907ddde7464f9
---
M src/dm/nodes/ve.dm.BlockquoteNode.js
1 file changed, 1 insertion(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/99/344799/1

diff --git a/src/dm/nodes/ve.dm.BlockquoteNode.js 
b/src/dm/nodes/ve.dm.BlockquoteNode.js
index 6440768..aea9018 100644
--- a/src/dm/nodes/ve.dm.BlockquoteNode.js
+++ b/src/dm/nodes/ve.dm.BlockquoteNode.js
@@ -21,13 +21,11 @@
 
 /* Inheritance */
 
-OO.inheritClass( ve.dm.BlockquoteNode, ve.dm.BranchNode );
+OO.inheritClass( ve.dm.BlockquoteNode, ve.dm.ContentBranchNode );
 
 /* Static Properties */
 
 ve.dm.BlockquoteNode.static.name = 'blockquote';
-
-ve.dm.BlockquoteNode.static.canContainContent = true;
 
 ve.dm.BlockquoteNode.static.matchTagNames = [ 'blockquote' ];
 

-- 
To view, visit https://gerrit.wikimedia.org/r/344799
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib1ef7561fd2b47ebe26edd2a8e4907ddde7464f9
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Test wgLogoHD keys

[Dereckson (Code Review)]

Dereckson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/344798 )

Change subject: Test wgLogoHD keys
..

Test wgLogoHD keys

When a value is defined, keys MUST be 1.5x and 2x.

Bug: T161416
Change-Id: I41196e2756eff07cdcecedcde06b141b77621789
---
A tests/InitialiseSettingsTest.php
1 file changed, 50 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/98/344798/1

diff --git a/tests/InitialiseSettingsTest.php b/tests/InitialiseSettingsTest.php
new file mode 100644
index 000..502f5e1
--- /dev/null
+++ b/tests/InitialiseSettingsTest.php
@@ -0,0 +1,50 @@
+settings = $this->loadSettings( 'unittest' );
+   }
+
+   private function loadSettings( $wmfRealm ) {
+   // Variables required for wgConf.php
+   $wmfConfigDir = __DIR__ . "/../wmf-config";
+
+   require "{$wmfConfigDir}/wgConf.php";
+
+   // InitialiseSettings.php explicitly declares these as global, 
so we must too
+   $GLOBALS['wmfUdp2logDest'] = 'localhost';
+   $GLOBALS['wmfDatacenter'] = 'unittest';
+   $GLOBALS['wmfMasterDatacenter'] = 'unittest';
+   $GLOBALS['wmfRealm'] = $wmfRealm;
+   $GLOBALS['wmfConfigDir'] = $wmfConfigDir;
+   $GLOBALS['wgConf'] = $wgConf;
+
+   require __DIR__ . '/TestServices.php';
+   require "{$wmfConfigDir}/InitialiseSettings.php";
+
+   return $wgConf->settings;
+   }
+
+   ///
+   /// wgLogoHD
+   ///
+
+   public function testLogoHD () {
+   $requiredKeys = $this->getRequiredLogoHDKeys();
+
+   foreach ( $this->settings[ 'wgLogoHD' ] as $db => $entry ) {
+   $keys = array_keys( $entry );
+   $this->assertEquals( $requiredKeys, $keys, "Unexpected 
keys for $db", 0.0, 10, true ); // canonicalize
+   }
+   }
+
+   public function getRequiredLogoHDKeys () {
+   return [ '1.5x', '2x' ];
+   }
+
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/344798
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I41196e2756eff07cdcecedcde06b141b77621789
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Dereckson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Exclude .git in phpcs.xml instead of command line argument

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/344797 )

Change subject: Exclude .git in phpcs.xml instead of command line argument
..


Exclude .git in phpcs.xml instead of command line argument

In order to benefit of it in other PHP_CodeSniffer tools.
Thanks to Legoktm for this tip!

Change-Id: I6d8e2a4242f0b5ec4536da72a44a4fb2f9b9e2f2
---
M composer.json
M phpcs.xml
2 files changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Seb35: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index 4ff65bd..61956c2 100644
--- a/composer.json
+++ b/composer.json
@@ -27,7 +27,7 @@
"scripts": {
"validate-schema": "php ./bin/validate-schema.php",
"lint": "parallel-lint --exclude vendor .",
-   "phpcs": "phpcs -p -s --ignore=.git",
+   "phpcs": "phpcs -p -s",
"phpdoc": "[ \"`which phpdoc`\" = \"\" ] || phpdoc -d bin,src 
-t ./docs/code",
"phpunit": "which phpdbg && phpdbg -qrr `which phpunit` 
--strict-coverage || phpunit --strict-coverage",
"unit": "phpunit --no-coverage",
diff --git a/phpcs.xml b/phpcs.xml
index 6224889..9a172ae 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -32,4 +32,5 @@

tests/perfs/results
vendor
+   .git
 

-- 
To view, visit https://gerrit.wikimedia.org/r/344797
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6d8e2a4242f0b5ec4536da72a44a4fb2f9b9e2f2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MediaWikiFarm
Gerrit-Branch: master
Gerrit-Owner: Seb35 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Seb35 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MediaWikiFarm[master]: Exclude .git in phpcs.xml instead of command line argument

[Seb35 (Code Review)]

Seb35 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/344797 )

Change subject: Exclude .git in phpcs.xml instead of command line argument
..

Exclude .git in phpcs.xml instead of command line argument

In order to benefit of it in other PHP_CodeSniffer tools.
Thanks to Legoktm for this tip!

Change-Id: I6d8e2a4242f0b5ec4536da72a44a4fb2f9b9e2f2
---
M composer.json
M phpcs.xml
2 files changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MediaWikiFarm 
refs/changes/97/344797/1

diff --git a/composer.json b/composer.json
index 4ff65bd..61956c2 100644
--- a/composer.json
+++ b/composer.json
@@ -27,7 +27,7 @@
"scripts": {
"validate-schema": "php ./bin/validate-schema.php",
"lint": "parallel-lint --exclude vendor .",
-   "phpcs": "phpcs -p -s --ignore=.git",
+   "phpcs": "phpcs -p -s",
"phpdoc": "[ \"`which phpdoc`\" = \"\" ] || phpdoc -d bin,src 
-t ./docs/code",
"phpunit": "which phpdbg && phpdbg -qrr `which phpunit` 
--strict-coverage || phpunit --strict-coverage",
"unit": "phpunit --no-coverage",
diff --git a/phpcs.xml b/phpcs.xml
index 6224889..9a172ae 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -32,4 +32,5 @@

tests/perfs/results
vendor
+   .git
 

-- 
To view, visit https://gerrit.wikimedia.org/r/344797
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6d8e2a4242f0b5ec4536da72a44a4fb2f9b9e2f2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MediaWikiFarm
Gerrit-Branch: master
Gerrit-Owner: Seb35 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Fix wgLogoHD keys

[Dereckson (Code Review)]

Dereckson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/344796 )

Change subject: Fix wgLogoHD keys
..

Fix wgLogoHD keys

This is a follow-up to 26cbc1ac3.

This solves the following production error:
Notice: Undefined index: 1.5x in 
/srv/mediawiki/php-1.29.0-wmf.17/includes/resourceloader/ResourceLoaderSkinModule.php
 on line 38

Bug: T161416
Change-Id: Idc981d7c7044822650abcc48b14f744c56e19930
---
M wmf-config/InitialiseSettings.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/96/344796/1

diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index 9774ade..c26acfd 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -1194,7 +1194,7 @@
'enwiki' => [ '1.5x' => '/static/images/project-logos/enwiki-1.5x.png', 
'2x' => '/static/images/project-logos/enwiki-2x.png' ],
'eswiki' => [ '1.5x' => '/static/images/project-logos/eswiki-1.5x.png', 
'2x' => '/static/images/project-logos/eswiki-2x.png' ], // T150618
'fawiki' => [ '1.5x' => '/static/images/project-logos/fawiki-1.5x.png', 
'2x' => '/static/images/project-logos/fawiki-2x.png' ],
-   'ffwiki' => [ '2.5x' => '/static/images/project-logos/ffwiki-1.5x.png', 
'2x' => '/static/images/project-logos/ffwiki-2x.png'], // T150618
+   'ffwiki' => [ '1.5x' => '/static/images/project-logos/ffwiki-1.5x.png', 
'2x' => '/static/images/project-logos/ffwiki-2x.png'], // T150618
'fowiki' => [ '1.5x' => '/static/images/project-logos/fowiki-1.5x.png', 
'2x' => '/static/images/project-logos/fowiki-2x.png' ], // T150618
'frpwiki' => [ '1.5x' => 
'/static/images/project-logos/frpwiki-1.5x.png', '2x' => 
'/static/images/project-logos/frpwiki-2x.png'], // T150618
'frrwiki' => [ '1.5x' => 
'/static/images/project-logos/frrwiki-1.5x.png', '2x' => 
'/static/images/project-logos/frrwiki-2x.png'], // T150618

-- 
To view, visit https://gerrit.wikimedia.org/r/344796
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idc981d7c7044822650abcc48b14f744c56e19930
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Dereckson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...NewUserActions[master]: Use tabs in json

[Umherirrender (Code Review)]

Umherirrender has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/344772 )

Change subject: Use tabs in json
..


Use tabs in json

Change-Id: I18354b03d4620ffc36dbd3f213325b48607c86c2
---
M composer.json
M package.json
2 files changed, 26 insertions(+), 26 deletions(-)

Approvals:
  Umherirrender: Verified; Looks good to me, approved



diff --git a/composer.json b/composer.json
index a2a5aca..3debb7b 100644
--- a/composer.json
+++ b/composer.json
@@ -1,18 +1,18 @@
 {
-"require-dev": {
-"jakub-onderka/php-parallel-lint": "0.9.2",
-"mediawiki/mediawiki-codesniffer": "0.5.1",
-"psy/psysh": "@stable"
-},
-"scripts": {
-"test": [
-"parallel-lint . --exclude node_modules --exclude vendor",
-"phpcs -p -s src",
-"phpcs -p -s tests/phpunit"
-],
-"fix": [
-"phpcbf src",
-"phpcbf tests/phpunit"
-]
-}
+   "require-dev": {
+   "jakub-onderka/php-parallel-lint": "0.9.2",
+   "mediawiki/mediawiki-codesniffer": "0.5.1",
+   "psy/psysh": "@stable"
+   },
+   "scripts": {
+   "test": [
+   "parallel-lint . --exclude node_modules --exclude 
vendor",
+   "phpcs -p -s src",
+   "phpcs -p -s tests/phpunit"
+   ],
+   "fix": [
+   "phpcbf src",
+   "phpcbf tests/phpunit"
+   ]
+   }
 }
diff --git a/package.json b/package.json
index 72eb4aa..4282d40 100644
--- a/package.json
+++ b/package.json
@@ -1,12 +1,12 @@
 {
-  "private": true,
-  "scripts": {
-"test": "grunt test"
-  },
-  "devDependencies": {
-"grunt": "0.4.5",
-"grunt-cli": "0.1.13",
-"grunt-banana-checker": "0.4.0",
-"grunt-jsonlint": "1.0.7"
-  }
+   "private": true,
+   "scripts": {
+   "test": "grunt test"
+   },
+   "devDependencies": {
+   "grunt": "0.4.5",
+   "grunt-cli": "0.1.13",
+   "grunt-banana-checker": "0.4.0",
+   "grunt-jsonlint": "1.0.7"
+   }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/344772
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I18354b03d4620ffc36dbd3f213325b48607c86c2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/NewUserActions
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Umherirrender 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: [IMPR] Rewrite setParameters()

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/281603 )

Change subject: [IMPR] Rewrite setParameters()
..


[IMPR] Rewrite setParameters()

- assign image from generator to setParameters directly
- setup self.imageName (might be replaced by self.image.title() later)
- remove "future" comment

Change-Id: I869c8f34c612e90e7bf1108429117b851a47aaf6
---
M scripts/checkimages.py
1 file changed, 7 insertions(+), 10 deletions(-)

Approvals:
  jenkins-bot: Verified
  Sn1per: Looks good to me, approved



diff --git a/scripts/checkimages.py b/scripts/checkimages.py
index 213ab96..7196cb1 100755
--- a/scripts/checkimages.py
+++ b/scripts/checkimages.py
@@ -82,7 +82,7 @@
 # (C) Kyle/Orgullomoore, 2006-2007 (newimage.py)
 # (C) Siebrand Mazeland, 2007-2010
 # (C) Filnik, 2007-2011
-# (C) Pywikibot team, 2007-2016
+# (C) Pywikibot team, 2007-2017
 #
 # Distributed under the terms of the MIT license.
 #
@@ -596,14 +596,11 @@
 """Return username."""
 return self.site.username()
 
-def setParameters(self, imageName):
-"""
-Set parameters.
-
-Now only image but maybe it can be used for others in "future".
-"""
-self.imageName = imageName
-self.image = pywikibot.FilePage(self.site, self.imageName)
+def setParameters(self, image):
+"""Set parameters."""
+# ensure we have a FilePage
+self.image = pywikibot.FilePage(image)
+self.imageName = image.title(withNamespace=False)
 self.timestamp = None
 self.uploader = None
 
@@ -1752,7 +1749,7 @@
 generator = Bot.wait(generator, waitTime)
 for image in generator:
 # Setting the image for the main class
-Bot.setParameters(image.title(withNamespace=False))
+Bot.setParameters(image)
 if skip:
 skip = Bot.skipImages(skip_number, limit)
 if skip:

-- 
To view, visit https://gerrit.wikimedia.org/r/281603
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I869c8f34c612e90e7bf1108429117b851a47aaf6
Gerrit-PatchSet: 2
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt 
Gerrit-Reviewer: John Vandenberg 
Gerrit-Reviewer: Magul 
Gerrit-Reviewer: Sn1per 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Metrolook[master]: Fix TypeError: undefined is not an object (evaluating '$(hr...

[Paladox (Code Review)]

Paladox has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/344795 )

Change subject: Fix  TypeError: undefined is not an object (evaluating 
'$(href).offset().top')
..

Fix  TypeError: undefined is not an object (evaluating '$(href).offset().top')

Change-Id: I1d94c41656b60169f5cedcf8b067603539a72943
---
0 files changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Metrolook 
refs/changes/95/344795/1


-- 
To view, visit https://gerrit.wikimedia.org/r/344795
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d94c41656b60169f5cedcf8b067603539a72943
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Metrolook
Gerrit-Branch: master
Gerrit-Owner: Paladox 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: Fixed a bug in two funnctions which caused zimdump to cause ...

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/78379 )

Change subject: Fixed a bug in two funnctions which caused zimdump to cause a 
segmentation fault when the url passed was not found in the zim file. The error 
occurred when the tool attempts to display the article.
..


Fixed a bug in two funnctions which caused zimdump to cause a segmentation 
fault when the url passed was not found in the zim file. The error occurred 
when the tool attempts to display the article.

Change-Id: Ica90f36dc7b8aef93de9581355030b6f08a2ca61
---
M zimlib/src/tools/zimDump.cpp
1 file changed, 11 insertions(+), 5 deletions(-)



diff --git a/zimlib/src/tools/zimDump.cpp b/zimlib/src/tools/zimDump.cpp
index e7f6b3a..65d13b8 100644
--- a/zimlib/src/tools/zimDump.cpp
+++ b/zimlib/src/tools/zimDump.cpp
@@ -46,7 +46,7 @@
   { }
 
 void setVerbose(bool sw = true)  { verbose = sw; }
-
+
 void printInfo();
 void printNsInfo(char ch);
 void locateArticle(zim::size_type idx);
@@ -84,11 +84,11 @@
"cluster count: " << file.getFileheader().getClusterCount() << 
"\n"
"cluster ptr pos: " << file.getFileheader().getClusterPtrPos() 
<< "\n";
   if (file.getFileheader().hasChecksum())
-std::cout << 
+std::cout <<
"checksum pos: " << file.getFileheader().getChecksumPos() << 
"\n"
"checksum: " << file.getChecksum() << "\n";
   else
-std::cout << 
+std::cout <<
"no checksum\n";
 
   if (file.getFileheader().hasMainPage())
@@ -135,13 +135,19 @@
 void ZimDumper::printPage()
 {
   log_trace("print page");
-  std::cout << pos->getPage() << std::flush;
+  if(pos!=file.end())
+  {
+std::cout << pos->getPage() << std::flush;
+  }
 }
 
 void ZimDumper::dumpArticle()
 {
   log_trace("dump article");
-  std::cout << pos->getData() << std::flush;
+  if(pos!=file.end())
+  {
+std::cout << pos->getData() << std::flush;
+  }
 }
 
 void ZimDumper::dumpIndex()

-- 
To view, visit https://gerrit.wikimedia.org/r/78379
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ica90f36dc7b8aef93de9581355030b6f08a2ca61
Gerrit-PatchSet: 1
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: Kiran mathew koshy 1993 
Gerrit-Reviewer: Kelson 
Gerrit-Reviewer: Tntnet 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: Fixed wrong libmagic path

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/216530 )

Change subject: Fixed wrong libmagic path
..


Fixed wrong libmagic path

Change-Id: Ic7674a62530abde447252fd6c0b693a8d741443e
---
M zimwriterfs/macosx-build.sh
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimwriterfs/macosx-build.sh b/zimwriterfs/macosx-build.sh
index 6f2e3bc..ae38a39 100755
--- a/zimwriterfs/macosx-build.sh
+++ b/zimwriterfs/macosx-build.sh
@@ -10,10 +10,9 @@
 LIBZIM_DIR="${ZIM_DIR}/build/lib"
 LZMA_DIR="${KIWIX_ROOT}/src/dependencies/xz/build"
 LIBLZMA_DIR="${LZMA_DIR}/lib"
-MAGIC_DIR="/usr/local"
+MAGIC_DIR="/usr/local/Cellar/libmagic/5.22_1"
 LIBMAGIC_DIR="${MAGIC_DIR}/lib"
 STATIC_LDFLAGS="${LIBZIM_DIR}/libzim.a ${LIBLZMA_DIR}/liblzma.a 
${LIBMAGIC_DIR}/libmagic.a -lz"
-#LDFLAGS="-L${KIWIX_ROOT}/src/dependencies/zimlib-1.2/build/lib/ -lzim 
-L${KIWIX_ROOT}/src/dependencies/xz/build/lib/ -llzma 
-L/usr/local/Cellar/libmagic/5.22_1/lib/ -lmagic -lz"
 
 CC="clang -O3"
 CXX="clang++ -O3"

-- 
To view, visit https://gerrit.wikimedia.org/r/216530
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic7674a62530abde447252fd6c0b693a8d741443e
Gerrit-PatchSet: 1
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: Rgaudin 
Gerrit-Reviewer: Kelson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: Minor wording and typo fixes to the zimwriterfs README.

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/295032 )

Change subject: Minor wording and typo fixes to the zimwriterfs README.
..


Minor wording and typo fixes to the zimwriterfs README.

Change-Id: Ia408f755b38f079f3063a6f0bc02ae95519f5e1c
---
M zimwriterfs/README
1 file changed, 7 insertions(+), 7 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimwriterfs/README b/zimwriterfs/README
index 91ea637..811d4a8 100644
--- a/zimwriterfs/README
+++ b/zimwriterfs/README
@@ -1,15 +1,15 @@
-zimwriterfs is a console tool to create ZIM (http://www.openzim.org)
-files from a localy stored directory containing a "self-sufficient"
-HTML content (with pictures, javascript, stylesheets). The result will
+`zimwriterfs` is a console tool to create [ZIM](http://www.openzim.org)
+files from a locally-stored directory containing "self-sufficient"
+HTML content (with pictures, javascript, and stylesheets). The result will
 contain all the files of the local directory compressed and merged in
 the ZIM file. Nothing more, nothing less. The generated file can be
-open with a ZIM reader, Kiwix (http://www.kiwix.org) for example, but
-you have other one (http://openzim.org/wiki/ZIM_Readers).
+opened with a ZIM reader; [Kiwix](http://www.kiwix.org) is one example, but
+there are [others](http://openzim.org/wiki/ZIM_Readers).
 
-zimwriterfs works for now only on POSIX compatible systems, you simply
+`zimwriterfs` works for now only on POSIX-compatible systems, you simply
 need to compile it and run it. The software does not need a lot of
 resources, but if you create a pretty big ZIM files, then it could
-take a wile to complete.
+take a while to complete.
 
 GNU/Linux compilation
 -

-- 
To view, visit https://gerrit.wikimedia.org/r/295032
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia408f755b38f079f3063a6f0bc02ae95519f5e1c
Gerrit-PatchSet: 1
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: C. Scott Ananian 
Gerrit-Reviewer: Kelson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: libzim.pc: Add "Requires" field

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/330857 )

Change subject: libzim.pc: Add "Requires" field
..


libzim.pc: Add "Requires" field

Follows-up b7e5564423b8644c.

Change-Id: I0710aefa8f706067c5e6cb11c70da785c7956608
---
M zimlib/libzim.pc.in
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Mgautierfr: Looks good to me, but someone else must approve
  Kelson: Verified; Looks good to me, approved

Objections:
  Legoktm: There's a problem with this change, please improve



diff --git a/zimlib/libzim.pc.in b/zimlib/libzim.pc.in
index bbef0d6..58cc155 100644
--- a/zimlib/libzim.pc.in
+++ b/zimlib/libzim.pc.in
@@ -6,6 +6,7 @@
 Name: libzim
 Description: implements read and write methods for ZIM files
 Version: @VERSION@
+Requires: liblzma
 Libs: -L${libdir} -lzim
 Cflags: -I${includedir}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/330857
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0710aefa8f706067c5e6cb11c70da785c7956608
Gerrit-PatchSet: 1
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Kelson 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Mgautierfr 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: Bug Fix for bug no 52324 on openzim. Sorts the MIME Types be...

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/79021 )

Change subject: Bug Fix for bug no 52324 on openzim. Sorts the MIME Types 
before storing them to file.
..


Bug Fix for bug no 52324 on openzim. Sorts the MIME Types before storing them 
to file.

Since this will be the new standard, the old ZIM files will have to be 
generated gain in order to obtain checksum match during zimdiff/zimpatch

Change-Id: I37a32d4d9adad7402ab7dbb0d9bee143b76d89b7
---
M zimlib/include/zim/dirent.h
M zimlib/src/zimcreator.cpp
2 files changed, 33 insertions(+), 2 deletions(-)



diff --git a/zimlib/include/zim/dirent.h b/zimlib/include/zim/dirent.h
index a5e0511..2ceea35 100644
--- a/zimlib/include/zim/dirent.h
+++ b/zimlib/include/zim/dirent.h
@@ -108,7 +108,10 @@
 clusterNumber = 0;
 blobNumber = 0;
   }
-
+  void setMimeType(uint16_t mime)
+  {
+mimeType=mime;
+  }
   void setLinktarget()
   {
 mimeType = linktargetMimeType;
diff --git a/zimlib/src/zimcreator.cpp b/zimlib/src/zimcreator.cpp
index bbc9420..e767dd3 100644
--- a/zimlib/src/zimcreator.cpp
+++ b/zimlib/src/zimcreator.cpp
@@ -401,12 +401,40 @@
   log_debug("after writing header - pos=" << zimfile.tellp());
 
   // write mime type list
+  std::vector  oldMImeList;
+  std::vector  newMImeList;
+  std::vectormapping;
+  for (RMimeTypes::const_iterator it = rmimeTypes.begin(); it != 
rmimeTypes.end(); ++it)
+  {
+oldMImeList.push_back(it->second);
+newMImeList.push_back(it->second);
+  }
+  mapping.resize(oldMImeList.size());
+  std::sort(newMImeList.begin(),newMImeList.end());
 
+  for(unsigned int i=0;isecond << '\0';
   }
-
+  */
   out << '\0';
 
   // write url ptr list

-- 
To view, visit https://gerrit.wikimedia.org/r/79021
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I37a32d4d9adad7402ab7dbb0d9bee143b76d89b7
Gerrit-PatchSet: 1
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: Kiran mathew koshy 1993 
Gerrit-Reviewer: Kelson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: Add .gitignore and .gitreview

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/84432 )

Change subject: Add .gitignore and .gitreview
..


Add .gitignore and .gitreview

Bug: 54175
Change-Id: Ic900b6a1aa3848aa59b428adef19115a9c55ac61
---
A .gitignore
A .gitreview
2 files changed, 9 insertions(+), 0 deletions(-)

Approvals:
  Reedy: Looks good to me, but someone else must approve
  Kelson: Verified; Looks good to me, approved



diff --git a/.gitignore b/.gitignore
new file mode 100644
index 000..98b092a
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1,4 @@
+.svn
+*~
+*.kate-swp
+.*.swp
diff --git a/.gitreview b/.gitreview
new file mode 100644
index 000..2a01b99
--- /dev/null
+++ b/.gitreview
@@ -0,0 +1,5 @@
+[gerrit]
+host=gerrit.wikimedia.org
+port=29418
+project=openzim.git
+defaultbranch=master

-- 
To view, visit https://gerrit.wikimedia.org/r/84432
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic900b6a1aa3848aa59b428adef19115a9c55ac61
Gerrit-PatchSet: 2
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Kelson 
Gerrit-Reviewer: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: Fixed compilation on OSX. made a script to compile both stat...

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/216507 )

Change subject: Fixed compilation on OSX. made a script to compile both static 
and shared
..


Fixed compilation on OSX. made a script to compile both static and shared

Change-Id: I9dd7b7039988be13f932bdb3e4b30c5bcf2e6783
---
M zimwriterfs/README
A zimwriterfs/macosx-build.sh
2 files changed, 79 insertions(+), 12 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimwriterfs/README b/zimwriterfs/README
index c1d2b10..d8d6a83 100644
--- a/zimwriterfs/README
+++ b/zimwriterfs/README
@@ -32,16 +32,10 @@
 OSX compilation
 
 
-Until the autotool is configured properly to support flexible options,
-you can still compile and use zimwriterfs with some manual work.
+On MaxOSX, a script helps you build zimwriterfs both statically and 
dynamically.
+You must have a working and set up Kiwix repository (with dependencies ready).
 
-1. Have a working Kiwix dev environnment (up to make inside src/dependencies)
-2. Install libmagic: brew install libmagic
-3. zimwriterfs compilation
-./autogen.sh
-LDFLAGS="-L$KIWIX_ROOT/src/dependencies/zimlib-1.1/build/lib/ 
-L/usr/local/Cellar/libmagic/5.14/lib/ 
-L$KIWIX_ROOT/src/dependencies/xz/build/lib/" CXXFLAGS="-I 
$KIWIX_ROOT/src/kiwix/src/dependencies/zimlib-1.1/include/ 
-I/usr/local/Cellar/libmagic/5.14/include/ 
-I$KIWIX_ROOT/src/kiwix/src/dependencies/xz/src/liblzma/lzma/ 
-I$KIWIX_ROOT/src/kiwix/src/dependencies/xz/src/liblzma/" ./configure && make
-4. Copy libs if not in LIBRARY_PATH
-ln -s $KIWIX_ROOT/src/dependencies/zimlib-1.1/build/lib/libzim.dylib .
-ln -s $KIWIX_ROOT/src/dependencies/xz/build/lib/liblzma.dylib .
-5. Use it
-./zimwriterfs
\ No newline at end of file
+1. Install libmagic with brew (it's important)
+   - ruby -e "$(curl -fsSL 
https://raw.githubusercontent.com/Homebrew/install/master/install)"
+   - brew install libmagic
+2. KIWIX_ROOT=/Users/xxx/src/kiwix ./macosx-build.sh
diff --git a/zimwriterfs/macosx-build.sh b/zimwriterfs/macosx-build.sh
new file mode 100755
index 000..6f2e3bc
--- /dev/null
+++ b/zimwriterfs/macosx-build.sh
@@ -0,0 +1,73 @@
+#!/bin/bash
+
+if [ "x$KIWIX_ROOT" = "x" ];
+   then
+   echo "You must define envvironment variable KIWIX_ROOT to the root of 
Kiwix git repository. Exiting."
+   exit 1
+fi
+
+ZIM_DIR="${KIWIX_ROOT}/src/dependencies/zimlib-1.2"
+LIBZIM_DIR="${ZIM_DIR}/build/lib"
+LZMA_DIR="${KIWIX_ROOT}/src/dependencies/xz/build"
+LIBLZMA_DIR="${LZMA_DIR}/lib"
+MAGIC_DIR="/usr/local"
+LIBMAGIC_DIR="${MAGIC_DIR}/lib"
+STATIC_LDFLAGS="${LIBZIM_DIR}/libzim.a ${LIBLZMA_DIR}/liblzma.a 
${LIBMAGIC_DIR}/libmagic.a -lz"
+#LDFLAGS="-L${KIWIX_ROOT}/src/dependencies/zimlib-1.2/build/lib/ -lzim 
-L${KIWIX_ROOT}/src/dependencies/xz/build/lib/ -llzma 
-L/usr/local/Cellar/libmagic/5.22_1/lib/ -lmagic -lz"
+
+CC="clang -O3"
+CXX="clang++ -O3"
+CXXFLAGS="-Igumbo -I${ZIM_DIR}/include -I${MAGIC_DIR}/include/ 
-I${LZMA_DIR}/include"
+CFLAGS="$CXXFLAGS"
+LDFLAGS="-L. -lzim -llzma -lmagic -lz"
+SHARED_OUTPUT="zimwriterfs-shared"
+STATIC_OUTPUT="zimwriterfs-static"
+
+function compile {
+   $CXX $CXXFLAGS -c zimwriterfs.cpp
+   $CC $CFLAGS -c gumbo/utf8.c
+   $CC $CFLAGS -c gumbo/string_buffer.c
+   $CC $CFLAGS -c gumbo/parser.c
+   $CC $CFLAGS -c gumbo/error.c
+   $CC $CFLAGS -c gumbo/string_piece.c
+   $CC $CFLAGS -c gumbo/tag.c
+   $CC $CFLAGS -c gumbo/vector.c
+   $CC $CFLAGS -c gumbo/tokenizer.c
+   $CC $CFLAGS -c gumbo/util.c
+   $CC $CFLAGS -c gumbo/char_ref.c
+   $CC $CFLAGS -c gumbo/attribute.c
+}
+
+echo "Compiling zimwriterfs for OSX as static then shared."
+
+# remove object files
+echo "Clean-up repository (*.o, zimwriterfs-*, *.dylib)"
+rm *.o ${STATIC_OUTPUT} ${SHARED_OUTPUT} *.dylib
+
+# compile source code
+echo "Compile source code file objects"
+compile
+
+# link statically
+echo "Link statically into ${STATIC_OUTPUT}"
+$CXX $CXXFLAGS $STATIC_LDFLAGS -o ${STATIC_OUTPUT} *.o
+
+# copy dylib to current folder
+echo "Copy dylibs into the current folder"
+cp -v ${KIWIX_ROOT}/src/dependencies/zimlib-1.2/build/lib/libzim.dylib .
+cp -v ${KIWIX_ROOT}/src/dependencies/xz/build/lib/liblzma.dylib .
+cp -v ${LIBMAGIC_DIR}/libmagic.dylib .
+chmod 644 ./libmagic.dylib
+
+# link dynamicaly
+echo "Link dynamically into ${SHARED_OUTPUT}"
+$CXX $CXXFLAGS $LDFLAGS -o zimwriterfs-shared *.o
+
+echo "Fix install name tool on ${SHARED_OUTPUT}"
+install_name_tool -change ${LIBZIM_DIR}/libzim.0.dylib libzim.dylib 
${SHARED_OUTPUT}
+install_name_tool -change ${LIBLZMA_DIR}/liblzma.5.dylib liblzma.dylib 
${SHARED_OUTPUT}
+install_name_tool -change ${LIBMAGIC_DIR}/libmagic.1.dylib libmagic.dylib 
${SHARED_OUTPUT}
+otool -L ${SHARED_OUTPUT}
+
+ls -lh ${STATIC_OUTPUT}
+ls -lh ${SHARED_OUTPUT}

-- 
To view, visit https://gerrit.wikimedia.org/r/216507
To unsubscribe, 

[MediaWiki-commits] [Gerrit] openzim[master]: Readd call to stripTitleInvalidChars.

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/295633 )

Change subject: Readd call to stripTitleInvalidChars.
..


Readd call to stripTitleInvalidChars.

Commit 1c969dd remove the call to stripTitleInvalidChars in Article.
This was a error while rebasing changes. Fix this.

Change-Id: I001bcdce81db27a359703221c929620e543b0a32
---
M zimwriterfs/article.cpp
M zimwriterfs/tools.h
2 files changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimwriterfs/article.cpp b/zimwriterfs/article.cpp
index f743cde..4aeb083 100644
--- a/zimwriterfs/article.cpp
+++ b/zimwriterfs/article.cpp
@@ -69,6 +69,7 @@
  GumboNode* title_text = 
(GumboNode*)(child->v.element.children.data[0]);
  if (title_text->type == GUMBO_NODE_TEXT) {
title = title_text->v.text.text;
+   stripTitleInvalidChars(title);
  }
}
  }
diff --git a/zimwriterfs/tools.h b/zimwriterfs/tools.h
index ec6b454..8b43da4 100644
--- a/zimwriterfs/tools.h
+++ b/zimwriterfs/tools.h
@@ -40,6 +40,7 @@
 
 void replaceStringInPlaceOnce(std::string& subject, const std::string& search, 
const std::string& replace);
 void replaceStringInPlace(std::string& subject, const std::string& search, 
const std::string& replace);
+void stripTitleInvalidChars(std::string & str);
 
 std::string extractRedirectUrlFromHtml(const GumboVector* head_children);
 void getLinks(GumboNode* node, std::map );

-- 
To view, visit https://gerrit.wikimedia.org/r/295633
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I001bcdce81db27a359703221c929620e543b0a32
Gerrit-PatchSet: 1
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: Mgautierfr 
Gerrit-Reviewer: Kelson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: Move articleSource's related stuffs in articlesource.(h|cpp).

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/295517 )

Change subject: Move articleSource's related stuffs in articlesource.(h|cpp).
..


Move articleSource's related stuffs in articlesource.(h|cpp).

Change-Id: Iee91484679bf401a693af1ca7e1c7e34f2c741d0
---
M zimwriterfs/Makefile.am
A zimwriterfs/articlesource.cpp
A zimwriterfs/articlesource.h
M zimwriterfs/zimwriterfs.cpp
4 files changed, 305 insertions(+), 229 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimwriterfs/Makefile.am b/zimwriterfs/Makefile.am
index 3383e35..6e46553 100644
--- a/zimwriterfs/Makefile.am
+++ b/zimwriterfs/Makefile.am
@@ -4,4 +4,5 @@
 zimwriterfs_SOURCES= \
 zimwriterfs.cpp \
 tools.cpp \
-article.cpp
+article.cpp \
+articlesource.cpp
diff --git a/zimwriterfs/articlesource.cpp b/zimwriterfs/articlesource.cpp
new file mode 100644
index 000..8b0b34c
--- /dev/null
+++ b/zimwriterfs/articlesource.cpp
@@ -0,0 +1,256 @@
+/*
+ * Copyright 2013-2016 Emmanuel Engelhart 
+ * Copyright 2016 Matthieu Gautier 
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU  General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+ * MA 02110-1301, USA.
+ */
+
+#include "articlesource.h"
+#include "article.h"
+#include "tools.h"
+
+#include 
+
+#include 
+#include 
+#include 
+
+bool popFromFilenameQueue(std::string );
+bool isVerbose();
+
+extern std::string welcome;
+extern std::string language;
+extern std::string creator;
+extern std::string publisher;
+extern std::string title;
+extern std::string description;
+extern std::string directoryPath;
+
+std::map counters;
+char *data = NULL;
+unsigned int dataSize = 0;
+
+
+
+ArticleSource::ArticleSource() {
+  /* Prepare metadata */
+  metadataQueue.push("Language");
+  metadataQueue.push("Publisher");
+  metadataQueue.push("Creator");
+  metadataQueue.push("Title");
+  metadataQueue.push("Description");
+  metadataQueue.push("Date");
+  metadataQueue.push("Favicon");
+  metadataQueue.push("Counter");
+}
+
+void ArticleSource::init_redirectsQueue_from_file(const std::string& path){
+std::ifstream in_stream;
+std::string line;
+
+in_stream.open(path.c_str());
+while (std::getline(in_stream, line)) {
+  redirectsQueue.push(line);
+}
+in_stream.close();
+}
+
+std::string ArticleSource::getMainPage() {
+  return welcome;
+}
+
+Article *article = NULL;
+const zim::writer::Article* ArticleSource::getNextArticle() {
+  std::string path;
+
+  if (article != NULL) {
+delete(article);
+  }
+
+  if (!metadataQueue.empty()) {
+path = metadataQueue.front();
+metadataQueue.pop();
+article = new MetadataArticle(path);
+  } else if (!redirectsQueue.empty()) {
+std::string line = redirectsQueue.front();
+redirectsQueue.pop();
+article = new RedirectArticle(line);
+  } else if (popFromFilenameQueue(path)) {
+do {
+  article = new Article(path);
+} while (article && article->isInvalid() && popFromFilenameQueue(path));
+  } else {
+article = NULL;
+  }
+
+  /* Count mimetypes */
+  if (article != NULL && !article->isRedirect()) {
+
+if (isVerbose())
+  std::cout << "Creating entry for " << article->getAid() << std::endl;
+
+std::string mimeType = article->getMimeType();
+if (counters.find(mimeType) == counters.end()) {
+  counters[mimeType] = 1;
+} else {
+  counters[mimeType]++;
+}
+  }
+
+  return article;
+}
+
+zim::Blob ArticleSource::getData(const std::string& aid) {
+
+  if (isVerbose())
+std::cout << "Packing data for " << aid << std::endl;
+
+  if (data != NULL) {
+delete(data);
+data = NULL;
+  }
+
+  if (aid.substr(0, 3) == "/M/") {
+std::string value; 
+
+if ( aid == "/M/Language") {
+  value = language;
+} else if (aid == "/M/Creator") {
+  value = creator;
+} else if (aid == "/M/Publisher") {
+  value = publisher;
+} else if (aid == "/M/Title") {
+  value = title;
+} else if (aid == "/M/Description") {
+  value = description;
+} else if ( aid == "/M/Date") {
+  time_t t = time(0);
+  struct tm * now = localtime( & t );
+  std::stringstream stream;
+  stream << (now->tm_year + 1900) << '-' 
+   

[MediaWiki-commits] [Gerrit] openzim[master]: Update build instructions for MacOS X.

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/295382 )

Change subject: Update build instructions for MacOS X.
..


Update build instructions for MacOS X.

Change-Id: I0190ada3bf02c42ed34cb6d253516a9c662357e1
---
M zimlib/README.md
M zimwriterfs/README.md
2 files changed, 31 insertions(+), 2 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimlib/README.md b/zimlib/README.md
index ce35ed9..9aef82c 100644
--- a/zimlib/README.md
+++ b/zimlib/README.md
@@ -16,5 +16,24 @@
 make
 ```
 
+OSX compilation
+---
+On MacOSX, you'll need to install some packages from
+[homebrew](http://brew.sh/):
+```
+brew update
+brew install xz libmagic
+```
+You'll also want to add `/usr/local/include` to your search path,
+for example:
+```
+./autogen.sh
+./configure CFLAGS=-I/usr/local/include CXXFLAGS=-I/usr/local/include
+make
+```
+
+License
+---
+
 The `zimlib` library is released under the GPLv2 license
 terms.
diff --git a/zimwriterfs/README.md b/zimwriterfs/README.md
index 8695643..1cbb7dc 100644
--- a/zimwriterfs/README.md
+++ b/zimwriterfs/README.md
@@ -44,9 +44,19 @@
 ```
 
 OSX compilation
-
+---
+OSX builds are similar to Linux, except we use homebrew.  Change to
+`../zimlib` and build zimlib as instructed in the README there.  Then
+return here and:
+```
+brew install gumbo-parser
+./autogen.sh
+./configure CXXFLAGS="-I../zimlib/include -I/usr/local/include" 
LDFLAGS=-L../zimlib/src/.libs
+make
+```
 
-On MaxOSX, a script helps you build zimwriterfs both statically and 
dynamically.
+Alternatively, there is a script included here to help you build both
+static and dynamic binaries for `zimwriterfs`.
 You must have a working and set up Kiwix repository (with dependencies ready).
 
 1. Install libmagic with brew (it's important)

-- 
To view, visit https://gerrit.wikimedia.org/r/295382
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0190ada3bf02c42ed34cb6d253516a9c662357e1
Gerrit-PatchSet: 1
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: C. Scott Ananian 
Gerrit-Reviewer: Kelson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: Update .gitignore files.

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/295037 )

Change subject: Update .gitignore files.
..


Update .gitignore files.

Change-Id: Iad8d95fa2deab178396e8804b6e195a5b1520a4a
---
C zimlib/.gitignore
R zimwriterfs/.gitignore
2 files changed, 3 insertions(+), 11 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/.gitignore b/zimlib/.gitignore
similarity index 75%
copy from .gitignore
copy to zimlib/.gitignore
index c50679e..0a4a991 100644
--- a/.gitignore
+++ b/zimlib/.gitignore
@@ -4,7 +4,6 @@
 compile
 config.*
 configure
-createZimExample
 depcomp
 .deps
 .dirstamp
@@ -25,8 +24,6 @@
 .svn
 .*.swp
 *.zim
-zimdiff
-zimdump
-zimpatch
-zimsearch
-zimwriterfs
+examples/createZimExample
+src/tools/zimdump
+src/tools/zimsearch
diff --git a/.gitignore b/zimwriterfs/.gitignore
similarity index 80%
rename from .gitignore
rename to zimwriterfs/.gitignore
index c50679e..1aaab40 100644
--- a/.gitignore
+++ b/zimwriterfs/.gitignore
@@ -4,7 +4,6 @@
 compile
 config.*
 configure
-createZimExample
 depcomp
 .deps
 .dirstamp
@@ -25,8 +24,4 @@
 .svn
 .*.swp
 *.zim
-zimdiff
-zimdump
-zimpatch
-zimsearch
 zimwriterfs

-- 
To view, visit https://gerrit.wikimedia.org/r/295037
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iad8d95fa2deab178396e8804b6e195a5b1520a4a
Gerrit-PatchSet: 1
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: C. Scott Ananian 
Gerrit-Reviewer: Kelson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: Update zimwriterfs makefiles.

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/295038 )

Change subject: Update zimwriterfs makefiles.
..


Update zimwriterfs makefiles.

Change-Id: Ic0f93e19eb3e07d86c115bd15f47ef5fbc74f954
---
M zimwriterfs/Makefile.am
M zimwriterfs/README.md
M zimwriterfs/configure.ac
3 files changed, 22 insertions(+), 49 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimwriterfs/Makefile.am b/zimwriterfs/Makefile.am
index 308149d..e52da96 100644
--- a/zimwriterfs/Makefile.am
+++ b/zimwriterfs/Makefile.am
@@ -1,5 +1,3 @@
 AUTOMAKE_OPTIONS=subdir-objects
 bin_PROGRAMS=zimwriterfs
 zimwriterfs_SOURCES= zimwriterfs.cpp gumbo/utf8.c gumbo/string_buffer.c 
gumbo/parser.c gumbo/error.c gumbo/string_piece.c gumbo/tag.c gumbo/vector.c 
gumbo/tokenizer.c gumbo/util.c gumbo/char_ref.c gumbo/attribute.c
-zimwriterfs_CXXFLAGS=$(LIBZIM_CFLAGS) $(LIBLZMA_CFLAGS) $(LIBZ_CFLAGS) 
$(LIBMAGIC_CFLAGS) $(LIBPTHREAD_CFLAGS) $(CFLAGS) $(CXXFLAGS)
-zimwriterfs_LDFLAGS=$(LIBZIM_LDFLAGS) $(LIBLZMA_LDFLAGS) $(LIBZ_LDFLAGS) 
$(LIBMAGIC_LDFLAGS) $(LIBPTHREAD_LDFLAGS)
\ No newline at end of file
diff --git a/zimwriterfs/README.md b/zimwriterfs/README.md
index 797f6fb..db8a01d 100644
--- a/zimwriterfs/README.md
+++ b/zimwriterfs/README.md
@@ -29,10 +29,16 @@
   packaged), resp. for the mimeType detection
 * libz (http://www.zlib.net/), resp. for unpack compressed HTML files
 
+On Debian, you can ensure these are installed with:
+```
+sudo apt-get install liblzma-dev libmagic-dev zlib1g-dev
+cd ../zimlib && ./autogen.sh && ./configure && make && cd ../zimwriterfs
+```
+
 Once the dependencies are in place, to build:
 ```
 ./autogen.sh
-./configure
+./configure CXXFLAGS=-I../zimlib/include LDFLAGS=-L../zimlib/src/.libs
 make
 ```
 
diff --git a/zimwriterfs/configure.ac b/zimwriterfs/configure.ac
index 5a01142..9c80493 100644
--- a/zimwriterfs/configure.ac
+++ b/zimwriterfs/configure.ac
@@ -33,70 +33,39 @@
   AC_MSG_ERROR([[cannot find pkg-config]])
 fi
 
-# Check if the liblzma is available
+# Set up CXXFLAGS/LDFLAGS and ensure they are substituted
+AC_ARG_VAR(CXXFLAGS, [C++ compiler flags])
+AC_ARG_VAR(LDFLAGS, linker flags)
+CFLAGS="-O3 -std=gnu99 -std=c99 $CFLAGS"
+CXXFLAGS="-O3 -Igumbo $CXXFLAGS"
+
+# Check if the liblzma library is available
 AC_CHECK_HEADER([lzma.h],, [AC_MSG_ERROR([[cannot find lzma header]])])
 AC_CHECK_LIB([lzma], [lzma_version_string],, [AC_MSG_ERROR([[cannot find 
lzma]])])
 
-# Check if the libzim is available
+# Check if the libzim library is available
 AC_CHECK_HEADER([zim/zim.h],, [AC_MSG_ERROR([[cannot find libzim header]])])
 AC_CHECK_LIB([zim], [zim_MD5Init],, [AC_MSG_ERROR([[cannot find libzim]])])
 
-# Check if the libmagic is available
+# Check if the libz library is available
+AC_CHECK_HEADER([zlib.h],, [AC_MSG_ERROR([[cannot find libz header]])])
+AC_CHECK_LIB([z], [deflate],, [AC_MSG_ERROR([[cannot find libz]])])
+
+# Check if the libmagic library is available
 AC_CHECK_HEADER([magic.h],, [AC_MSG_ERROR([[cannot find libmagic header]])])
 AC_CHECK_LIB([magic], [magic_file],, [AC_MSG_ERROR([[cannot find libmagic]])])
 
-# Check if the libpthread is available
+# Check if the libpthread library is available
 AC_CHECK_HEADER([pthread.h],, [AC_MSG_ERROR([[cannot find libpthread 
header]])])
 AC_CHECK_LIB([pthread], [pthread_exit],, [AC_MSG_ERROR([[cannot find 
libpthread]])])
 
-# Set current language to C++
-AC_LANG(C++)
-
 # Check the existence of stat64 (to handle file >2GB) in the libc
 AC_CHECK_FUNCS([stat64])
-
-# cxxflags
-CXXFLAGS="-O3 -Igumbo $CXXFLAGS"
-CFLAGS="-O3 -std=gnu99 -std=c99"
-
-# liblzma
-LIBLZMA_CFLAGS=""
-LIBLZMA_LDFLAGS=" -llzma"
-
-# libzim
-LIBZIM_CFLAGS=""
-LIBZIM_LDFLAGS=" -lzim"
-
-# libz
-LIBZ_CFLAGS=""
-LIBZ_LDFLAGS=" -lz"
-
-# libmagic
-LIBMAGIC_CFLAGS=""
-LIBMAGIC_LDFLAGS=" -lmagic"
-
-# libpthread
-LIBPTHREAD_CFLAGS=""
-LIBPTHREAD_LDFLAGS=" -lpthread"
 
 AC_DEFINE_UNQUOTED(CLUSTER_CACHE_SIZE, 16, [set zim cluster cache size to 
number of cached chunks])
 AC_DEFINE_UNQUOTED(DIRENT_CACHE_SIZE, 512, [set zim dirent cache size to 
number of cached chunks])
 AC_DEFINE_UNQUOTED(LZMA_MEMORY_SIZE, 128, [set lzma uncompress memory size to 
number of MB])
 AC_DEFINE(ENABLE_LZMA, [1], [defined if lzma compression is enabled])
-
-# export variables
-AC_SUBST(CXXFLAGS)
-AC_SUBST(CFLAGS)
-AC_SUBST(LIBLZMA_CFLAGS)
-AC_SUBST(LIBLZMA_LDFLAGS)
-AC_SUBST(LIBZIM_CFLAGS)
-AC_SUBST(LIBZIM_LDFLAGS)
-AC_SUBST(LIBZ_CFLAGS)
-AC_SUBST(LIBZ_LDFLAGS)
-AC_SUBST(LIBMAGIC_CFLAGS)
-AC_SUBST(LIBMAGIC_LDFLAGS)
-AC_SUBST(LIBPTHREAD_CFLAGS)
-AC_SUBST(LIBPTHREAD_LDFLAGS)
 
 # Configure the output files
 AC_CONFIG_FILES([
@@ -104,4 +73,4 @@
 ])
 
 AC_PROG_INSTALL
-AC_OUTPUT
\ No newline at end of file
+AC_OUTPUT

-- 
To view, visit https://gerrit.wikimedia.org/r/295038
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: 

[MediaWiki-commits] [Gerrit] openzim[master]: Bug fix: correctly update cluster offsets in directory entries.

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/296158 )

Change subject: Bug fix: correctly update cluster offsets in directory entries.
..


Bug fix: correctly update cluster offsets in directory entries.

This is a follow-up to f5de40f94b30795f42bb9388cbb46df9cd605167.

When we moved the blob writing to the main dirent-creation loop,
we ended up making separate *copies* of the dirents and updating
blob/cluster information in these, instead of the dirents in the
main list which will eventually be written.  Make the auxilliary
lists contain dirent *pointers* to avoid this problem.

Change-Id: I008fa700acd90c3c51614bde65d61ffbc6061872
---
M zimlib/include/zim/writer/zimcreator.h
M zimlib/src/zimcreator.cpp
2 files changed, 10 insertions(+), 9 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimlib/include/zim/writer/zimcreator.h 
b/zimlib/include/zim/writer/zimcreator.h
index 6f47402..2e52d7e 100644
--- a/zimlib/include/zim/writer/zimcreator.h
+++ b/zimlib/include/zim/writer/zimcreator.h
@@ -33,6 +33,7 @@
 {
   public:
 typedef std::vector DirentsType;
+typedef std::vector DirentPtrsType;
 typedef std::vector SizeVectorType;
 typedef std::vector OffsetsType;
 typedef std::map MimeTypes;
diff --git a/zimlib/src/zimcreator.cpp b/zimlib/src/zimcreator.cpp
index bc977ea..46c550f 100644
--- a/zimlib/src/zimcreator.cpp
+++ b/zimlib/src/zimcreator.cpp
@@ -144,7 +144,7 @@
   // because we don't know which one will fill up first.  We also need
   // to track the dirents currently in each, so we can fix up the
   // cluster index if the other one ends up written first.
-  DirentsType compDirents, uncompDirents;
+  DirentPtrsType compDirents, uncompDirents;
   Cluster compCluster, uncompCluster;
   compCluster.setCompression(compression);
   uncompCluster.setCompression(zimcompNone);
@@ -188,11 +188,11 @@
   }
 }
 
-dirents.push_back(dirent);
 currentSize +=
   dirent.getDirentSize() /* for directory entry */ +
   sizeof(offset_type) /* for url pointer list */ +
   sizeof(size_type) /* for title pointer list */;
+dirents.push_back(dirent);
 
 // If this is a redirect, we're done: there's no blob to add.
 if (dirent.isRedirect())
@@ -217,7 +217,7 @@
 }
 
 Cluster *cluster;
-DirentsType *myDirents, *otherDirents;
+DirentPtrsType *myDirents, *otherDirents;
 if (dirent.isCompress())
 {
   cluster = 
@@ -230,9 +230,9 @@
   myDirents = 
   otherDirents = 
 }
-myDirents->push_back(dirent);
-dirent.setCluster(clusterOffsets.size(), cluster->count());
+dirents.back().setCluster(clusterOffsets.size(), cluster->count());
 cluster->addBlob(blob);
+myDirents->push_back(&(dirents.back()));
 
 // If cluster is now large enough, write it to disk.
 if (cluster->size() >= minChunkSize * 1024)
@@ -247,10 +247,10 @@
   cluster->clear();
   myDirents->clear();
   // Update the cluster number of the dirents *not* written to disk.
-  for (DirentsType::iterator di = otherDirents->begin();
+  for (DirentPtrsType::iterator di = otherDirents->begin();
di != otherDirents->end(); ++di)
   {
-di->setCluster(clusterOffsets.size(), di->getBlobNumber());
+(*di)->setCluster(clusterOffsets.size(), (*di)->getBlobNumber());
   }
   offset_type end = out.tellp();
   currentSize += (end - start) +
@@ -263,10 +263,10 @@
   {
 clusterOffsets.push_back(out.tellp());
 out << compCluster;
-for (DirentsType::iterator di = uncompDirents.begin();
+for (DirentPtrsType::iterator di = uncompDirents.begin();
  di != uncompDirents.end(); ++di)
 {
-  di->setCluster(clusterOffsets.size(), di->getBlobNumber());
+  (*di)->setCluster(clusterOffsets.size(), (*di)->getBlobNumber());
 }
   }
   compCluster.clear();

-- 
To view, visit https://gerrit.wikimedia.org/r/296158
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I008fa700acd90c3c51614bde65d61ffbc6061872
Gerrit-PatchSet: 1
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: C. Scott Ananian 
Gerrit-Reviewer: C. Scott Ananian 
Gerrit-Reviewer: Kelson 
Gerrit-Reviewer: Mgautierfr 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: Fix memory corruption in decodeUrl.

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/303540 )

Change subject: Fix memory corruption in decodeUrl.
..


Fix memory corruption in decodeUrl.

Reuse the function from kiwix as it does the same thing but with much
better c++ code.

If we pass a char to sscanf while letting it thinks it is a uint,
sscanf will initialize 4 bytes. As there is only byte associated to the
char, this lead to undefined behavior.

This bug was not found before as we were using the function as inline
function. Compiler optimization probably hid the error.

Change-Id: I618f8b9ede083e6580044f967153bfbe3ee3d294
---
M zimwriterfs/tools.cpp
1 file changed, 13 insertions(+), 10 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimwriterfs/tools.cpp b/zimwriterfs/tools.cpp
index 49bc79e..cc6091d 100644
--- a/zimwriterfs/tools.cpp
+++ b/zimwriterfs/tools.cpp
@@ -246,19 +246,22 @@
 
 }
 
-std::string decodeUrl(const std::string ) {
-  std::string decodedUrl = encodedUrl;
-  std::string::size_type pos = 0;
-  char ch;
+static char charFromHex(std::string a) {
+  std::istringstream Blat(a);
+  int Z;
+  Blat >> std::hex >> Z;
+  return char (Z);
+}
 
-  while ((pos = decodedUrl.find('%', pos)) != std::string::npos &&
-pos + 2 < decodedUrl.length()) {
-sscanf(decodedUrl.substr(pos + 1, 2).c_str(), "%x", (unsigned int*));
-decodedUrl.replace(pos, 3, 1, ch);
+std::string decodeUrl(const std::string ) {
+  std::string url = originalUrl;
+  std::string::size_type pos = 0;
+  while ((pos = url.find('%', pos)) != std::string::npos &&
+pos + 2 < url.length()) {
+url.replace(pos, 3, 1, charFromHex(url.substr(pos + 1, 2)));
 ++pos;
   }
-
-  return decodedUrl;
+  return url;
 }
 
 std::string removeLastPathElement(const std::string& path, const bool 
removePreSeparator, const bool removePostSeparator) {

-- 
To view, visit https://gerrit.wikimedia.org/r/303540
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I618f8b9ede083e6580044f967153bfbe3ee3d294
Gerrit-PatchSet: 2
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: Mgautierfr 
Gerrit-Reviewer: Kelson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: Use the system's libgumbo.

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/295039 )

Change subject: Use the system's libgumbo.
..


Use the system's libgumbo.

Change-Id: Id6b06033bba6c1d47d305b50259e7eaf41c073e2
---
M zimwriterfs/Makefile.am
M zimwriterfs/README.md
M zimwriterfs/configure.ac
D zimwriterfs/gumbo/attribute.c
D zimwriterfs/gumbo/attribute.h
D zimwriterfs/gumbo/char_ref.c
D zimwriterfs/gumbo/char_ref.h
D zimwriterfs/gumbo/error.c
D zimwriterfs/gumbo/error.h
D zimwriterfs/gumbo/gumbo.h
D zimwriterfs/gumbo/insertion_mode.h
D zimwriterfs/gumbo/parser.c
D zimwriterfs/gumbo/parser.h
D zimwriterfs/gumbo/string_buffer.c
D zimwriterfs/gumbo/string_buffer.h
D zimwriterfs/gumbo/string_piece.c
D zimwriterfs/gumbo/string_piece.h
D zimwriterfs/gumbo/tag.c
D zimwriterfs/gumbo/token_type.h
D zimwriterfs/gumbo/tokenizer.c
D zimwriterfs/gumbo/tokenizer.h
D zimwriterfs/gumbo/tokenizer_states.h
D zimwriterfs/gumbo/utf8.c
D zimwriterfs/gumbo/utf8.h
D zimwriterfs/gumbo/util.c
D zimwriterfs/gumbo/util.h
D zimwriterfs/gumbo/vector.c
D zimwriterfs/gumbo/vector.h
28 files changed, 9 insertions(+), 33,053 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved




-- 
To view, visit https://gerrit.wikimedia.org/r/295039
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id6b06033bba6c1d47d305b50259e7eaf41c073e2
Gerrit-PatchSet: 2
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: C. Scott Ananian 
Gerrit-Reviewer: Kelson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: Use explicit LZMA_STREAM_INIT initializer, instead of memset.

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/296548 )

Change subject: Use explicit LZMA_STREAM_INIT initializer, instead of memset.
..


Use explicit LZMA_STREAM_INIT initializer, instead of memset.

This follows the recommendations in lzma.h.

Change-Id: Ib6b392ba3c6a249fa55b8cf8c04cdae1ae407925
---
M zimlib/src/lzmastream.cpp
1 file changed, 2 insertions(+), 3 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimlib/src/lzmastream.cpp b/zimlib/src/lzmastream.cpp
index d880933..bd02bd8 100644
--- a/zimlib/src/lzmastream.cpp
+++ b/zimlib/src/lzmastream.cpp
@@ -58,11 +58,10 @@
   }
 
   LzmaStreamBuf::LzmaStreamBuf(std::streambuf* sink_, uint32_t preset, 
lzma_check check, unsigned bufsize_)
-: obuffer(bufsize_),
+: stream(LZMA_STREAM_INIT),
+  obuffer(bufsize_),
   sink(sink_)
   {
-std::memset(reinterpret_cast(), 0, sizeof(stream));
-
 checkError(
   ::lzma_easy_encoder(, preset, check));
 

-- 
To view, visit https://gerrit.wikimedia.org/r/296548
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6b392ba3c6a249fa55b8cf8c04cdae1ae407925
Gerrit-PatchSet: 3
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: C. Scott Ananian 
Gerrit-Reviewer: Kelson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: Revert "Use explicit LZMA_STREAM_INIT initializer, instead o...

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/296752 )

Change subject: Revert "Use explicit LZMA_STREAM_INIT initializer, instead of 
memset."
..


Revert "Use explicit LZMA_STREAM_INIT initializer, instead of memset."

This reverts commit 498539d869bbb9add9e795432520f305523e09bf.

Turns out that the clang compiler doesn't like this form of initializer:
it must be a GCC extension of some kind.  There's nothing technically
wrong with the previous `memset` way of initializing the variable,
it just looks kind of gross.  But functionality trumps aesthetics.

Change-Id: I1d5a12c6eb40706023f81323c04a356da3356f42
---
M zimlib/src/lzmastream.cpp
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimlib/src/lzmastream.cpp b/zimlib/src/lzmastream.cpp
index bd02bd8..d880933 100644
--- a/zimlib/src/lzmastream.cpp
+++ b/zimlib/src/lzmastream.cpp
@@ -58,10 +58,11 @@
   }
 
   LzmaStreamBuf::LzmaStreamBuf(std::streambuf* sink_, uint32_t preset, 
lzma_check check, unsigned bufsize_)
-: stream(LZMA_STREAM_INIT),
-  obuffer(bufsize_),
+: obuffer(bufsize_),
   sink(sink_)
   {
+std::memset(reinterpret_cast(), 0, sizeof(stream));
+
 checkError(
   ::lzma_easy_encoder(, preset, check));
 

-- 
To view, visit https://gerrit.wikimedia.org/r/296752
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1d5a12c6eb40706023f81323c04a356da3356f42
Gerrit-PatchSet: 1
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: C. Scott Ananian 
Gerrit-Reviewer: Kelson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: Revert compatibility with previous API.

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/296910 )

Change subject: Revert compatibility with previous API.
..


Revert compatibility with previous API.

The API has changed. The behavior is different, so do not try to keep
a false API compatibility.

Change-Id: I174f7df03d5ad5477c6b0fd1869258a31af3366a
---
M zimlib/include/zim/writer/articlesource.h
M zimlib/src/articlesource.cpp
M zimlib/src/zimcreator.cpp
M zimwriterfs/article.cpp
M zimwriterfs/article.h
M zimwriterfs/articlesource.cpp
6 files changed, 15 insertions(+), 59 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimlib/include/zim/writer/articlesource.h 
b/zimlib/include/zim/writer/articlesource.h
index dbe9263..a9ecffb 100644
--- a/zimlib/include/zim/writer/articlesource.h
+++ b/zimlib/include/zim/writer/articlesource.h
@@ -46,26 +46,10 @@
 virtual bool shouldCompress() const;
 virtual std::string getRedirectAid() const;
 virtual std::string getParameter() const;
-/* Idealy this method should be pure virtual,
- * but for compatibility reasons, provide a default implementation
- * using the old ArticleSourc::getData.
- */
-virtual Blob getData() const;
+virtual Blob getData() const = 0;
 
 // returns the next category id, to which the article is assigned to
 virtual std::string getNextCategory();
-
-  
//
-  /* For API compatibility.
-   * The default Article::getData call ArticleSource::getData.
-   * So store the source of article in article to let default API 
compatible
-   * function do its job.
-   * This should be removed once every users switch to new API.
-   */
-  private:
-mutable ArticleSource*  __source;
-friend class ZimCreator;
-  
//
 };
 
 class Category
@@ -90,17 +74,6 @@
 // ids. Using this list, the writer fetches the category data using
 // this method.
 virtual Category* getCategory(const std::string& cid);
-
-
/**/
-/* For API compatibility.
- * The default Article::getData call ArticleSource::getData.
- * So keep the getData. Do not set it pure virtual cause we want new
- * code to not use it.
- * This should be removed once every users switch to new API.
- */
-virtual Blob getData(const std::string& aid);
-
-
/**/
 };
 
   }
diff --git a/zimlib/src/articlesource.cpp b/zimlib/src/articlesource.cpp
index a2087a7..26d33f8 100644
--- a/zimlib/src/articlesource.cpp
+++ b/zimlib/src/articlesource.cpp
@@ -69,22 +69,6 @@
   return std::string();
 }
 
-
/**/
-/* For API compatibility.
- * The default Article::getData call ArticleSource::getData.
- * This should be removed once every users switch to new API.
- */
-Blob Article::getData() const
-{
-  std::cerr << "DEPRECATED WARNING : Use of ArticleSource::getData is 
deprecated." << std::endl;
-  std::cerr << " You should override Article::getData 
directly." << std::endl;
-  return __source->getData(getAid());
-}
-Blob ArticleSource::getData(const std::string& aid) {
-throw std::runtime_error("This should not be called");
-}
-
/**/
-
 Uuid ArticleSource::getUuid()
 {
   return Uuid::generate();
diff --git a/zimlib/src/zimcreator.cpp b/zimlib/src/zimcreator.cpp
index 1b528f4..0f0f6d0 100644
--- a/zimlib/src/zimcreator.cpp
+++ b/zimlib/src/zimcreator.cpp
@@ -202,15 +202,6 @@
 }
 
 // Add blob data to compressed or uncompressed cluster.
-
/**/
-/* For API compatibility.
- * The default Article::getData call ArticleSource::getData.
- * So set the source of article to let default API compatible function
- * do its job.
- * This should be removed once every users switch to new API.
- */
-article->__source = 
-
/**/
 Blob blob = article->getData();
 if (blob.size() > 0)
 {
diff --git a/zimwriterfs/article.cpp b/zimwriterfs/article.cpp
index 4aeb083..98ec882 100644
--- a/zimwriterfs/article.cpp
+++ b/zimwriterfs/article.cpp
@@ -24,7 +24,9 @@
 
 extern std::string directoryPath;
 
-Article::Article(const std::string& path, const bool 

[MediaWiki-commits] [Gerrit] openzim[master]: Compress blobs and track file size immediately after adding ...

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/295383 )

Change subject: Compress blobs and track file size immediately after adding 
each article.
..


Compress blobs and track file size immediately after adding each article.

Rather than first collecting all the directory entries and only afterwards
writing the blobs, write each cluster on the fly as we see each article.
Keep track of both compressed and uncompressed clusters so that we don't
needlessly terminate compressed clusters just because we happen to have
encountered an uncompressible file.  Account for additions to each of
the various indices as we go so that we maintain a fairly accurate
size for the file at every point, which will allow us to stop adding
articles once the ZIM file gets to a certain size.

Change-Id: Ib644fff4cb804320a07aadbea499c8416df66adc
---
M zimlib/include/zim/writer/zimcreator.h
M zimlib/src/zimcreator.cpp
2 files changed, 126 insertions(+), 86 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimlib/include/zim/writer/zimcreator.h 
b/zimlib/include/zim/writer/zimcreator.h
index 5134d98..4296371 100644
--- a/zimlib/include/zim/writer/zimcreator.h
+++ b/zimlib/include/zim/writer/zimcreator.h
@@ -52,10 +52,10 @@
 CompressionType compression;
 bool isEmpty;
 offset_type clustersSize;
+offset_type currentSize;
 
-void createDirents(ArticleSource& src);
+void createDirents(ArticleSource& src, const std::string& tmpfname);
 void createTitleIndex(ArticleSource& src);
-void createClusters(ArticleSource& src, const std::string& tmpfname);
 void fillHeader(ArticleSource& src);
 void write(const std::string& fname, const std::string& tmpfname);
 
@@ -84,6 +84,10 @@
 void setMinChunkSize(int s)   { minChunkSize = s; }
 
 void create(const std::string& fname, ArticleSource& src);
+
+/* The user can query `currentSize` after each article has been
+ * added to the ZIM file. */
+offset_type getCurrentSize() { return currentSize; }
 };
 
   }
diff --git a/zimlib/src/zimcreator.cpp b/zimlib/src/zimcreator.cpp
index 66ce902..ac2720b 100644
--- a/zimlib/src/zimcreator.cpp
+++ b/zimlib/src/zimcreator.cpp
@@ -56,28 +56,30 @@
   : minChunkSize(1024-64),
 nextMimeIdx(0),
 #ifdef ENABLE_LZMA
-compression(zimcompLzma)
+compression(zimcompLzma),
 #elif ENABLE_BZIP2
-compression(zimcompBzip2)
+compression(zimcompBzip2),
 #elif ENABLE_ZLIB
-compression(zimcompZip)
+compression(zimcompZip),
 #else
-compression(zimcompNone)
+compression(zimcompNone),
 #endif
+currentSize(0)
 {
 }
 
 ZimCreator::ZimCreator(int& argc, char* argv[])
   : nextMimeIdx(0),
 #ifdef ENABLE_LZMA
-compression(zimcompLzma)
+compression(zimcompLzma),
 #elif ENABLE_BZIP2
-compression(zimcompBzip2)
+compression(zimcompBzip2),
 #elif ENABLE_ZLIB
-compression(zimcompZip)
+compression(zimcompZip),
 #else
-compression(zimcompNone)
+compression(zimcompNone),
 #endif
+currentSize(0)
 {
   Arg minChunkSizeArg(argc, argv, "--min-chunk-size");
   if (minChunkSizeArg.isSet())
@@ -110,15 +112,12 @@
   log_debug("basename " << basename);
 
   INFO("create directory entries");
-  createDirents(src);
+  createDirents(src, basename + ".tmp");
   INFO(dirents.size() << " directory entries created");
 
   INFO("create title index");
   createTitleIndex(src);
   INFO(dirents.size() << " title index created");
-
-  INFO("create clusters");
-  createClusters(src, basename + ".tmp");
   INFO(clusterOffsets.size() << " clusters created");
 
   INFO("fill header");
@@ -132,9 +131,23 @@
   INFO("ready");
 }
 
-void ZimCreator::createDirents(ArticleSource& src)
+void ZimCreator::createDirents(ArticleSource& src, const std::string& 
tmpfname)
 {
   INFO("collect articles");
+  std::ofstream out(tmpfname.c_str());
+  currentSize =
+80 /* for header */ +
+1 /* for mime type table termination */ +
+16 /* for md5sum */;
+
+  // We keep both a "compressed cluster" and an "uncompressed cluster"
+  // because we don't know which one will fill up first.  We also need
+  // to track the dirents currently in each, so we can fix up the
+  // cluster index if the other one ends up written first.
+  DirentsType compDirents, uncompDirents;
+  Cluster compCluster, uncompCluster;
+  compCluster.setCompression(compression);
+  uncompCluster.setCompression(zimcompNone);
 
   const Article* article;
   while ((article = src.getNextArticle()) != 0)
@@ -163,13 +176,107 @@
 }
 else
 {
+  uint16_t oldMimeIdx = 

[MediaWiki-commits] [Gerrit] openzim[master]: Explain that ZIntStream only represents uint32_t values righ...

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/296657 )

Change subject: Explain that ZIntStream only represents uint32_t values right 
now.
..


Explain that ZIntStream only represents uint32_t values right now.

Change-Id: Id712847949af1ce32b2e3118fc241be171124186
---
M zimlib/include/zim/zintstream.h
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimlib/include/zim/zintstream.h b/zimlib/include/zim/zintstream.h
index 1c78a1f..66fdfef 100644
--- a/zimlib/include/zim/zintstream.h
+++ b/zimlib/include/zim/zintstream.h
@@ -41,7 +41,10 @@
   substracted from the actual number, so a 2 byte zero is actually a 128.
 
   The same logic continues on the 3rd, 4th, ... byte. Up to 7 additional bytes
-  are used, so the first byte must contain at least one 0.
+  could used, since the first byte must contain at least one 0.
+
+  This particular implementation only represents uint32_t values (numbers up
+  to 2^32-1), so it will only ever emit 5 bytes per input value.
 
   binary  range
   --- 
--

-- 
To view, visit https://gerrit.wikimedia.org/r/296657
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id712847949af1ce32b2e3118fc241be171124186
Gerrit-PatchSet: 1
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: C. Scott Ananian 
Gerrit-Reviewer: Kelson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: Use a Queue object to handle threadsafe access to a queue.

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/295518 )

Change subject: Use a Queue object to handle threadsafe access to a queue.
..


Use a Queue object to handle threadsafe access to a queue.

By using a Queue object we avoid the declaration of popFromFilenameQueue
function in articlesource.cpp.

Change-Id: Ic685f7e22e4ce95f6e0eb280f65809fd0dff1a6a
---
M zimwriterfs/articlesource.cpp
M zimwriterfs/articlesource.h
A zimwriterfs/queue.h
M zimwriterfs/zimwriterfs.cpp
4 files changed, 116 insertions(+), 55 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimwriterfs/articlesource.cpp b/zimwriterfs/articlesource.cpp
index 8b0b34c..6cf5f30 100644
--- a/zimwriterfs/articlesource.cpp
+++ b/zimwriterfs/articlesource.cpp
@@ -28,7 +28,6 @@
 #include 
 #include 
 
-bool popFromFilenameQueue(std::string );
 bool isVerbose();
 
 extern std::string welcome;
@@ -44,8 +43,9 @@
 unsigned int dataSize = 0;
 
 
-
-ArticleSource::ArticleSource() {
+ArticleSource::ArticleSource(Queue& filenameQueue):
+filenameQueue(filenameQueue)
+{
   /* Prepare metadata */
   metadataQueue.push("Language");
   metadataQueue.push("Publisher");
@@ -88,10 +88,10 @@
 std::string line = redirectsQueue.front();
 redirectsQueue.pop();
 article = new RedirectArticle(line);
-  } else if (popFromFilenameQueue(path)) {
+  } else if (filenameQueue.popFromQueue(path)) {
 do {
   article = new Article(path);
-} while (article && article->isInvalid() && popFromFilenameQueue(path));
+} while (article && article->isInvalid() && 
filenameQueue.popFromQueue(path));
   } else {
 article = NULL;
   }
diff --git a/zimwriterfs/articlesource.h b/zimwriterfs/articlesource.h
index adbdbda..1ad6524 100644
--- a/zimwriterfs/articlesource.h
+++ b/zimwriterfs/articlesource.h
@@ -24,12 +24,13 @@
 #include 
 #include 
 #include 
+#include "queue.h"
 
 #include 
 
 class ArticleSource : public zim::writer::ArticleSource {
   public:
-explicit ArticleSource();
+explicit ArticleSource(Queue& filenameQueue);
 virtual const zim::writer::Article* getNextArticle();
 virtual zim::Blob getData(const std::string& aid);
 virtual std::string getMainPage();
@@ -39,6 +40,7 @@
   private:
 std::queue metadataQueue;
 std::queue redirectsQueue;
+Queue& filenameQueue;
 };
 
 #endif //OPENZIM_ZIMWRITERFS_ARTICLESOURCE_H
diff --git a/zimwriterfs/queue.h b/zimwriterfs/queue.h
new file mode 100644
index 000..d177568
--- /dev/null
+++ b/zimwriterfs/queue.h
@@ -0,0 +1,88 @@
+/*
+ * Copyright 2016 Matthieu Gautier 
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU  General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+ * MA 02110-1301, USA.
+ */
+
+#ifndef OPENZIM_ZIMWRITERFS_QUEUE_H
+#define OPENZIM_ZIMWRITERFS_QUEUE_H
+
+#define MAX_QUEUE_SIZE 100
+
+#include 
+#include 
+
+template
+class Queue {
+public:
+Queue() {pthread_mutex_init(_queueMutex,NULL);};
+virtual ~Queue() {pthread_mutex_destroy(_queueMutex);};
+virtual bool isEmpty();
+virtual void pushToQueue(const T& element);
+virtual bool popFromQueue(T );
+
+protected:
+std::queue   m_realQueue;
+pthread_mutex_t m_queueMutex;
+
+private:
+// Make this queue non copyable
+Queue(const Queue&);
+Queue& operator=(const Queue&);
+};
+
+template
+bool Queue::isEmpty() {
+pthread_mutex_lock(_queueMutex);
+bool retVal = m_realQueue.empty();
+pthread_mutex_unlock(_queueMutex);
+return retVal;
+}
+
+template
+void Queue::pushToQueue(const T ) {
+unsigned int wait = 0;
+unsigned int queueSize = 0;
+
+do {
+usleep(wait);
+pthread_mutex_lock(_queueMutex);
+queueSize = m_realQueue.size();
+pthread_mutex_unlock(_queueMutex);
+wait += 10;
+} while (queueSize > MAX_QUEUE_SIZE);
+
+pthread_mutex_lock(_queueMutex);
+m_realQueue.push(element);
+pthread_mutex_unlock(_queueMutex);
+}
+
+template
+bool Queue::popFromQueue(T ) {
+pthread_mutex_lock(_queueMutex);
+if (m_realQueue.empty()) {
+pthread_mutex_unlock(_queueMutex);
+return false;
+}
+
+element = m_realQueue.front();
+m_realQueue.pop();
+

[MediaWiki-commits] [Gerrit] openzim[master]: Include files from srcdir; built files in builddir.

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/295111 )

Change subject: Include files from srcdir; built files in builddir.
..


Include files from srcdir; built files in builddir.

Change-Id: I84f097567b944601534cdbc3313216c0364211bd
---
M zimlib/examples/Makefile.am
M zimlib/src/Makefile.am
M zimlib/src/tools/Makefile.am
M zimlib/test/Makefile.am
M zimreader/src/Makefile.am
M zimwriterdb/src/Makefile.am
M zimwriterdb/test/Makefile.am
7 files changed, 7 insertions(+), 7 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimlib/examples/Makefile.am b/zimlib/examples/Makefile.am
index 13ac63f..3157cf0 100644
--- a/zimlib/examples/Makefile.am
+++ b/zimlib/examples/Makefile.am
@@ -1,4 +1,4 @@
-AM_CPPFLAGS=-I$(top_builddir)/include
+AM_CPPFLAGS=-I$(top_srcdir)/include
 noinst_PROGRAMS = createZimExample
 createZimExample_SOURCES = createZimExample.cpp
 LDADD = $(top_builddir)/src/libzim.la
diff --git a/zimlib/src/Makefile.am b/zimlib/src/Makefile.am
index 823a3b6..c0bd632 100644
--- a/zimlib/src/Makefile.am
+++ b/zimlib/src/Makefile.am
@@ -1,4 +1,4 @@
-AM_CPPFLAGS=-I$(top_builddir)/include
+AM_CPPFLAGS=-I$(top_srcdir)/include
 
 lib_LTLIBRARIES = libzim.la
 
diff --git a/zimlib/src/tools/Makefile.am b/zimlib/src/tools/Makefile.am
index a50b7c8..410504a 100644
--- a/zimlib/src/tools/Makefile.am
+++ b/zimlib/src/tools/Makefile.am
@@ -1,4 +1,4 @@
-AM_CPPFLAGS=-I$(top_builddir)/include
+AM_CPPFLAGS=-I$(top_srcdir)/include -I$(top_srcdir)/src
 if MAKE_BENCHMARK
   ZIMBENCH = zimbench
 endif
diff --git a/zimlib/test/Makefile.am b/zimlib/test/Makefile.am
index 34dad12..29dd7bd 100644
--- a/zimlib/test/Makefile.am
+++ b/zimlib/test/Makefile.am
@@ -1,4 +1,4 @@
-AM_CPPFLAGS=-I$(top_builddir)/include
+AM_CPPFLAGS=-I$(top_srcdir)/include
 
 noinst_PROGRAMS = zimlib-test
 
diff --git a/zimreader/src/Makefile.am b/zimreader/src/Makefile.am
index ff40f97..b7fc747 100644
--- a/zimreader/src/Makefile.am
+++ b/zimreader/src/Makefile.am
@@ -10,7 +10,7 @@
 .css.cpp:
ecppc $(ECPPFLAGS) -b $(ECPPFLAGS_CSS) $<
 
-AM_CPPFLAGS=-I$(top_builddir)/include
+AM_CPPFLAGS=-I$(top_srcdir)/include
 
 bin_PROGRAMS = zimreader
 
diff --git a/zimwriterdb/src/Makefile.am b/zimwriterdb/src/Makefile.am
index 46b0fac..854f2cb 100644
--- a/zimwriterdb/src/Makefile.am
+++ b/zimwriterdb/src/Makefile.am
@@ -1,6 +1,6 @@
 bin_PROGRAMS = zimwriterdb zimindexer zimcreatorsearch wikizim
 
-AM_CPPFLAGS=-I$(top_builddir)/include
+AM_CPPFLAGS=-I$(top_srcdir)/include
 
 # wikizim
 #
diff --git a/zimwriterdb/test/Makefile.am b/zimwriterdb/test/Makefile.am
index fffe02a..52262b2 100644
--- a/zimwriterdb/test/Makefile.am
+++ b/zimwriterdb/test/Makefile.am
@@ -6,4 +6,4 @@
 createzim_t_LDFLAGS = -lcxxtools -lzim
 createzim_t_SOURCES = createzim-t.cpp
 
-AM_CPPFLAGS=-I$(top_builddir)/include
+AM_CPPFLAGS=-I$(top_srcdir)/include

-- 
To view, visit https://gerrit.wikimedia.org/r/295111
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I84f097567b944601534cdbc3313216c0364211bd
Gerrit-PatchSet: 2
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: C. Scott Ananian 
Gerrit-Reviewer: Kelson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: Convert READMEs to markdown.

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/295035 )

Change subject: Convert READMEs to markdown.
..


Convert READMEs to markdown.

Change-Id: I596bec7ef70bd0a7d45ba67d4fa313d93c861890
---
A README.md
D zimlib/README
A zimlib/README
A zimlib/README.md
D zimreader-java/README
A zimreader-java/README.md
D zimreader/README
A zimreader/README.md
A zimwriterdb/README.md
R zimwriterfs/README.md
10 files changed, 100 insertions(+), 61 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/README.md b/README.md
new file mode 100644
index 000..c5fee8e
--- /dev/null
+++ b/README.md
@@ -0,0 +1,11 @@
+This OpenZIM project repository contains the sources for:
+* [zimlib](./zimlib#readme): A library for reading and writing ZIM files.
+* [zimwriterfs](./zimwriterfs#readme): A tool for creating ZIM files based on
+  contents on a local filesystem.
+* [zimreader-java](./zimreader-java#readme): A ZIM reader written in Java.
+
+Old code, provided for archive purposes:
+* [zimreader](./zimreader#readme): An old reader for the Zeno file format, the
+  predecessor to the ZIM file format.
+* [zimwriterdb](./zimwriterdb#readme): Demonstrates how to write a ZIM file
+  based on data in a database.
diff --git a/zimlib/README b/zimlib/README
deleted file mode 100644
index e12d9c0..000
--- a/zimlib/README
+++ /dev/null
@@ -1,6 +0,0 @@
-The zimlib is the standard implementation of the ZIM specification. It
-is a library which implements the read and write method for ZIM
-files. The zimlib is released under the GPLv2 license terms. Use the
-zimlib in your own software - like reader applications - to make them
-ZIM-capable without the need having to dig too much into the ZIM file
-format.
diff --git a/zimlib/README b/zimlib/README
new file mode 12
index 000..42061c0
--- /dev/null
+++ b/zimlib/README
@@ -0,0 +1 @@
+README.md
\ No newline at end of file
diff --git a/zimlib/README.md b/zimlib/README.md
new file mode 100644
index 000..ce35ed9
--- /dev/null
+++ b/zimlib/README.md
@@ -0,0 +1,20 @@
+zimlib
+--
+
+The `zimlib` library is the standard implementation of the ZIM
+specification.  It is a library which implements read and write
+methods for ZIM files.
+
+Use the zimlib in your own software --- for example, reader
+applications --- to make them ZIM-capable without the need having to
+dig too much into the ZIM file format.
+
+To build:
+```
+./autogen.sh
+./configure
+make
+```
+
+The `zimlib` library is released under the GPLv2 license
+terms.
diff --git a/zimreader-java/README b/zimreader-java/README
deleted file mode 100644
index 973e7b2..000
--- a/zimreader-java/README
+++ /dev/null
@@ -1,46 +0,0 @@
-
-ZIMReader in Java
-=
-
-This is a port of the ZIMReader in Java. One 
-of the aims of this project is to enable mobile 
-users developing on Android, J2ME and other 
-platforms to use ZIM files and build offline 
-Wikipedia readers.
-
-I'll soon add a javadoc, in the mean time 
-you can go through the comments that I have 
-provided in the source code. Also, try running 
-the example ZIMTest.java. 
-
-This code was built on Java 1.6 and has not 
-been tested on previous versions. However, I'll
-do that soon on previous ones as well. In the 
-next release, I intend to provide an Ant file.
-
-If you find any bugs, please report them to 
- or visit the 
-IRC channel #openzim on Freenode and ping 
-'gremmachook'.
-
-This library is licensed under the LGPL v3.0 
-license. However, I understand that sometimes 
-licensing can be a problem for you. I would be 
-happy to provide a alternate lesser permissive 
-license if the need be.
-
-Found this library useful? Drop in a mail, I 
-love to hear feedback.
-
-Before this ends, I'd like to thank Lasse Collin 
-, who maintains the 
-Tukaani project, for his port of XZ in Java, 
-without which it wouldn't have been possible for 
-me to write this library.
- 
-
--- Arunesh Mathur
-   
-
-   
-
diff --git a/zimreader-java/README.md b/zimreader-java/README.md
new file mode 100644
index 000..abce858
--- /dev/null
+++ b/zimreader-java/README.md
@@ -0,0 +1,42 @@
+ZIMReader in Java
+=
+
+This is a port of the ZIMReader in Java. One
+of the aims of this project is to enable mobile
+users developing on Android, J2ME and other
+platforms to use ZIM files and build offline
+Wikipedia readers.
+
+I'll soon add a javadoc, in the mean time
+you can go through the comments that I have
+provided in the source code. Also, try running
+the example ZIMTest.java.
+
+This code was built on Java 1.6 and has not
+been tested on previous versions. However, I'll
+do that soon on previous ones as well. In the
+next release, I intend to provide an Ant 

[MediaWiki-commits] [Gerrit] openzim[master]: Move zim::writer::ArticleSource::getData() to zim::writer::A...

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/295460 )

Change subject: Move zim::writer::ArticleSource::getData() to 
zim::writer::Article::getData().
..


Move zim::writer::ArticleSource::getData() to zim::writer::Article::getData().

When building a ZIM file incrementally, it makes more sense to provide
the data upfront as soon as you return the Article object from
ArticleSource::getNextArticle.  This is the way that the Category
object already works.

Change-Id: I78f2a69ae3931cc43a51cdab360468e13fcc54cb
---
M zimlib/examples/createZimExample.cpp
M zimlib/include/zim/writer/articlesource.h
M zimlib/src/articlesource.cpp
M zimlib/src/zimcreator.cpp
4 files changed, 54 insertions(+), 14 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimlib/examples/createZimExample.cpp 
b/zimlib/examples/createZimExample.cpp
index 914000c..95b8d09 100644
--- a/zimlib/examples/createZimExample.cpp
+++ b/zimlib/examples/createZimExample.cpp
@@ -40,7 +40,7 @@
 virtual std::string getMimeType() const;
 virtual std::string getRedirectAid() const;
 
-zim::Blob data()
+virtual zim::Blob getData() const
 { return zim::Blob(&_data[0], _data.size()); }
 };
 
@@ -96,7 +96,6 @@
 explicit TestArticleSource(unsigned max = 16);
 
 virtual const zim::writer::Article* getNextArticle();
-virtual zim::Blob getData(const std::string& aid);
 };
 
 TestArticleSource::TestArticleSource(unsigned max)
@@ -119,14 +118,6 @@
   unsigned n = _next++;
 
   return &_articles[n];
-}
-
-zim::Blob TestArticleSource::getData(const std::string& aid)
-{
-  unsigned n;
-  std::istringstream s(aid);
-  s >> n;
-  return _articles[n-1].data();
 }
 
 int main(int argc, char* argv[])
diff --git a/zimlib/include/zim/writer/articlesource.h 
b/zimlib/include/zim/writer/articlesource.h
index 1fda337..94ee91b 100644
--- a/zimlib/include/zim/writer/articlesource.h
+++ b/zimlib/include/zim/writer/articlesource.h
@@ -20,16 +20,16 @@
 #ifndef ZIM_WRITER_ARTICLESOURCE_H
 #define ZIM_WRITER_ARTICLESOURCE_H
 
+#include 
 #include 
 #include 
 #include 
 
 namespace zim
 {
-  class Blob;
-
   namespace writer
   {
+class ArticleSource;
 class Article
 {
   public:
@@ -45,9 +45,26 @@
 virtual bool shouldCompress() const;
 virtual std::string getRedirectAid() const;
 virtual std::string getParameter() const;
+/* Idealy this method should be pure virtual,
+ * but for compatibility reasons, provide a default implementation
+ * using the old ArticleSourc::getData.
+ */
+virtual Blob getData() const;
 
 // returns the next category id, to which the article is assigned to
 virtual std::string getNextCategory();
+
+  
//
+  /* For API compatibility.
+   * The default Article::getData call ArticleSource::getData.
+   * So store the source of article in article to let default API 
compatible
+   * function do its job.
+   * This should be removed once every users switch to new API.
+   */
+  private:
+mutable ArticleSource*  __source;
+friend class ZimCreator;
+  
//
 };
 
 class Category
@@ -63,7 +80,6 @@
   public:
 virtual void setFilename(const std::string& fname) { }
 virtual const Article* getNextArticle() = 0;
-virtual Blob getData(const std::string& aid) = 0;
 virtual Uuid getUuid();
 virtual std::string getMainPage();
 virtual std::string getLayoutPage();
@@ -73,6 +89,16 @@
 // ids. Using this list, the writer fetches the category data using
 // this method.
 virtual Category* getCategory(const std::string& cid);
+
+
/**/
+/* For API compatibility.
+ * The default Article::getData call ArticleSource::getData.
+ * So keep the getData. Do not set it pure virtual cause we want new
+ * code to not use it.
+ * This should be removed once every users switch to new API.
+ */
+virtual Blob getData(const std::string& aid) { throw "This should not 
be called"; };
+
/**/
 };
 
   }
diff --git a/zimlib/src/articlesource.cpp b/zimlib/src/articlesource.cpp
index 4d1ec91..cc72ae2 100644
--- a/zimlib/src/articlesource.cpp
+++ b/zimlib/src/articlesource.cpp
@@ -17,6 +17,7 @@
  *
  */
 
+#include 
 #include 
 
 namespace zim
@@ -68,6 +69,19 @@
   return std::string();
 }
 
+
/**/
+/* For API compatibility.
+ * The default Article::getData call 

[MediaWiki-commits] [Gerrit] openzim[master]: Move few utility functions to a separate module.

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/295515 )

Change subject: Move few utility functions to a separate module.
..


Move few utility functions to a separate module.

Change-Id: Ia26754d14f0cd6c557626675beb5a7c5fe2cadaa
---
M zimwriterfs/Makefile.am
A zimwriterfs/tools.cpp
A zimwriterfs/tools.h
M zimwriterfs/zimwriterfs.cpp
4 files changed, 578 insertions(+), 481 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimwriterfs/Makefile.am b/zimwriterfs/Makefile.am
index 0caa3c8..ea2ab7a 100644
--- a/zimwriterfs/Makefile.am
+++ b/zimwriterfs/Makefile.am
@@ -1,3 +1,6 @@
 AUTOMAKE_OPTIONS=subdir-objects
 bin_PROGRAMS=zimwriterfs
-zimwriterfs_SOURCES=zimwriterfs.cpp
+
+zimwriterfs_SOURCES= \
+zimwriterfs.cpp \
+tools.cpp
diff --git a/zimwriterfs/tools.cpp b/zimwriterfs/tools.cpp
new file mode 100644
index 000..019b22c
--- /dev/null
+++ b/zimwriterfs/tools.cpp
@@ -0,0 +1,525 @@
+/*
+ * Copyright 2013-2016 Emmanuel Engelhart 
+ * Copyright 2016 Matthieu Gautier 
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU  General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+ * MA 02110-1301, USA.
+ */
+
+#include "tools.h"
+
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#ifdef _WIN32
+#define SEPARATOR "\\"
+#else
+#define SEPARATOR "/"
+#endif
+
+
+/* Init file extensions hash */
+static std::map _create_extMimeTypes(){
+  std::map extMimeTypes;
+  extMimeTypes["HTML"] = "text/html";
+  extMimeTypes["html"] = "text/html";
+  extMimeTypes["HTM"] = "text/html";
+  extMimeTypes["htm"] = "text/html";
+  extMimeTypes["PNG"] = "image/png";
+  extMimeTypes["png"] = "image/png";
+  extMimeTypes["TIFF"] = "image/tiff";
+  extMimeTypes["tiff"] = "image/tiff";
+  extMimeTypes["TIF"] = "image/tiff";
+  extMimeTypes["tif"] = "image/tiff";
+  extMimeTypes["JPEG"] = "image/jpeg";
+  extMimeTypes["jpeg"] = "image/jpeg";
+  extMimeTypes["JPG"] = "image/jpeg";
+  extMimeTypes["jpg"] = "image/jpeg";
+  extMimeTypes["GIF"] = "image/gif";
+  extMimeTypes["gif"] = "image/gif";
+  extMimeTypes["SVG"] = "image/svg+xml";
+  extMimeTypes["svg"] = "image/svg+xml";
+  extMimeTypes["TXT"] = "text/plain";
+  extMimeTypes["txt"] = "text/plain";
+  extMimeTypes["XML"] = "text/xml";
+  extMimeTypes["xml"] = "text/xml";
+  extMimeTypes["EPUB"] = "application/epub+zip";
+  extMimeTypes["epub"] = "application/epub+zip";
+  extMimeTypes["PDF"] = "application/pdf";
+  extMimeTypes["pdf"] = "application/pdf";
+  extMimeTypes["OGG"] = "application/ogg";
+  extMimeTypes["ogg"] = "application/ogg";
+  extMimeTypes["JS"] = "application/javascript";
+  extMimeTypes["js"] = "application/javascript";
+  extMimeTypes["JSON"] = "application/json";
+  extMimeTypes["json"] = "application/json";
+  extMimeTypes["CSS"] = "text/css";
+  extMimeTypes["css"] = "text/css";
+  extMimeTypes["otf"] = "application/vnd.ms-opentype";
+  extMimeTypes["OTF"] = "application/vnd.ms-opentype";
+  extMimeTypes["eot"] = "application/vnd.ms-fontobject";
+  extMimeTypes["EOT"] = "application/vnd.ms-fontobject";
+  extMimeTypes["ttf"] = "application/font-ttf";
+  extMimeTypes["TTF"] = "application/font-ttf";
+  extMimeTypes["woff"] = "application/font-woff";
+  extMimeTypes["WOFF"] = "application/font-woff";
+  extMimeTypes["vtt"] = "text/vtt";
+  extMimeTypes["VTT"] = "text/vtt";
+  
+  return extMimeTypes;
+}
+
+static std::map extMimeTypes = 
_create_extMimeTypes();
+
+static std::map fileMimeTypes;
+
+
+extern std::string directoryPath;
+extern bool inflateHtmlFlag;
+extern bool uniqueNamespace;
+extern magic_t magic;
+
+/* Decompress an STL string using zlib and return the original data. */
+inline std::string inflateString(const std::string& str) {
+  z_stream zs; // z_stream is zlib's control structure
+  memset(, 0, sizeof(zs));
+
+  if (inflateInit() != Z_OK)
+throw(std::runtime_error("inflateInit failed while decompressing."));
+
+  zs.next_in = (Bytef*)str.data();
+  zs.avail_in = str.size();
+
+  int ret;
+  char outbuffer[32768];
+  std::string outstring;
+
+  // get the decompressed bytes blockwise using repeated 

[MediaWiki-commits] [Gerrit] openzim[master]: Add xapian indexer.

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/296913 )

Change subject: Add xapian indexer.
..


Add xapian indexer.

Xapian is optional.
Build your index inside zim by adding "-i" or "--createFullTextIndex"
to zimwriterfs' command line.

Change-Id: I52c255e8335d0b6763c1c59eeb1549300d5f6f81
---
M zimwriterfs/Makefile.am
M zimwriterfs/configure.ac
M zimwriterfs/tools.cpp
M zimwriterfs/tools.h
A zimwriterfs/xapian/htmlparse.cc
A zimwriterfs/xapian/htmlparse.h
A zimwriterfs/xapian/myhtmlparse.cc
A zimwriterfs/xapian/myhtmlparse.h
A zimwriterfs/xapian/namedentities.h
A zimwriterfs/xapianIndexer.cpp
A zimwriterfs/xapianIndexer.h
M zimwriterfs/zimwriterfs.cpp
12 files changed, 1,490 insertions(+), 0 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimwriterfs/Makefile.am b/zimwriterfs/Makefile.am
index 628b74c..1d40174 100644
--- a/zimwriterfs/Makefile.am
+++ b/zimwriterfs/Makefile.am
@@ -10,3 +10,15 @@
 resourceTools.cpp \
 pathTools.cpp \
 mimetypecounter.cpp
+
+zimwriterfs_CXXFLAGS = $(ICU_CFLAGS)
+zimwriterfs_LDFLAGS = $(ICU_LDFLAGS)
+
+if HAVE_XAPIAN
+zimwriterfs_CXXFLAGS += $(XAPIAN_CFLAGS)
+zimwriterfs_LDFLAGS += $(XAPIAN_LDFLAGS)
+zimwriterfs_SOURCES += \
+xapianIndexer.cpp \
+xapian/myhtmlparse.cc \
+xapian/htmlparse.cc
+endif
diff --git a/zimwriterfs/configure.ac b/zimwriterfs/configure.ac
index fb12c8f..795d3b1 100644
--- a/zimwriterfs/configure.ac
+++ b/zimwriterfs/configure.ac
@@ -71,6 +71,121 @@
 AC_DEFINE_UNQUOTED(LZMA_MEMORY_SIZE, 128, [set lzma uncompress memory size to 
number of MB])
 AC_DEFINE(ENABLE_LZMA, [1], [defined if lzma compression is enabled])
 
+
+function findLibrary {
+   found=0
+   for f in $(echo $LIBS_ROOT|tr ":" "\n") ; do
+   sf=`find $f -name $1 | grep $ARCH | head -1 2> /dev/null`
+   if [[ -f "$sf" -a $found -eq 0 ]]
+   then
+   found=1
+   echo $sf
+   fi
+   done
+   if [[ $found -eq 0 ]]
+   then
+   for f in $(echo $LIBS_ROOT|tr ":" "\n") ; do
+   sf=`find $f -name $1 | head -1 2> /dev/null`
+   if [[ -f "$sf" -a $found -eq 0 ]]
+   then
+   found=1
+   echo $sf
+   fi
+   done
+   fi
+   if [[ $found -eq 0 ]]
+   then
+   echo "no"
+   fi
+}
+
+
+
+ ICU
+
+
+
+ICU_CFLAGS=""
+ICU_LDFLAGS="-licui18n -licuuc -licudata" # replaced by icu-config
+ICU_STATIC_LDFLAGS=""
+
+# if --with-x, add path to LIBRARY_PATH
+AC_ARG_WITH(icu,
+AC_HELP_STRING([--with-icu=DIR], [alternate location for 
icu-config]),
+export 
LIBRARY_PATH="${withval}:${LIBRARY_PATH}";ICU_PATH=${withval}
+   )
+
+# look for shared library.
+# AC_CHECK_HEADER([zlib.h],, [AC_MSG_ERROR([[cannot find zlib header]])])
+# AC_CHECK_LIB([z], [zlibVersion],, [AC_MSG_ERROR([[cannot find 
zlib]]);COMPILE_ICU=1])
+# ICU_FILES=`findLibrary "libicuuc.${SHARED_EXT}"`
+
+AC_CHECK_TOOL(HAVE_ICU_CONFIG, icu-config,, "${ICU_PATH}:${PATH}")
+if test [ ! "$HAVE_ICU_CONFIG" ]
+then
+ AC_MSG_ERROR([[cannot find icu-config]])
+else
+OLDPATH=$PATH
+PATH="${ICU_PATH}:${PATH}"
+ICU_CFLAGS=`icu-config --cxxflags`;
+ICU_LDFLAGS=`icu-config --ldflags`;
+ICU_VER=`icu-config --version`;
+ICU_FILES="`findLibrary "libicuuc.${SHARED_EXT}"` `findLibrary 
"libicudata.${SHARED_EXT}"` `findLibrary "libicui18n.${SHARED_EXT}"`"
+PATH=$OLDPATH
+if [[ $ICU_VER \< "4.2" ]]
+   then
+AC_MSG_ERROR([[You need a version of libicu >= 4.2]])
+   fi
+fi
+
+
+AC_SUBST(ICU_CFLAGS)
+AC_SUBST(ICU_LDFLAGS)
+AC_SUBST(ICU_STATIC_LDFLAGS)
+AC_SUBST(ICU_FILES)
+AC_SUBST(COMPILED_ICUDATA_DAT)
+
+
+ XAPIAN
+
+
+XAPIAN_CFLAGS=""
+XAPIAN_LDFLAGS=""
+XAPIAN_STATIC_LDFLAGS=""
+XAPIAN_ENABLE=0
+
+# if --with-x, add path to LIBRARY_PATH
+AC_ARG_WITH([xapian],
+   [AS_HELP_STRING([--with-xapian=DIR], [alternat location for 
xapian-config] @@)],
+   [xapian_dir=$withval],
+   [with_xapian=yes])
+
+
+AS_IF([test "x$with_xapian" == xno],
+[AM_CONDITIONAL(HAVE_XAPIAN, false)],
+   [OLDPATH=$PATH
+AS_IF([test "x$with_xapian" != xyes],
+  PATH="$with_xapian:$PATH")
+AC_CHECK_TOOLS(XAPIAN_CONFIG, xapian-config-1.3, 
xapian-config,[],$PATH)
+AS_IF([test "x$XAPIAN_CONFIG" == x ],
+   AC_MSG_ERROR([[cannot find xapian-config file]])
+ )
+XAPIAN_VERSION=`$XAPIAN_CONFIG --version`
+

[MediaWiki-commits] [Gerrit] openzim[master]: Bug fix: preserve cluster compression type after clear().

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/296547 )

Change subject: Bug fix: preserve cluster compression type after clear().
..


Bug fix: preserve cluster compression type after clear().

By nulling out the cluster implementation on clear, we were also
resetting the cluster compression type.  This caused the ZimCreator
API to not compress compressible clusters after the first one.
This is a follow-up to f5de40f94b30795f42bb9388cbb46df9cd605167,
which reused cluster objects instead of recreating them from scratch
each time.

Related issue: the `size()` of an empty cluster is actually 4, not 0,
since even an empty cluster contains an field which counts the number
of offsets in the cluster, and change the ClusterImpl initializer so
the compresion type doesn't change from zimcompNone to zimcompDefault
as soon as the ClusterImpl is created.

Change-Id: I468a1719a33c450db9a28d9704b539bdb97cd7fc
---
M zimlib/include/zim/cluster.h
M zimlib/src/cluster.cpp
2 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimlib/include/zim/cluster.h b/zimlib/include/zim/cluster.h
index c26c24c..bd55cb5 100644
--- a/zimlib/include/zim/cluster.h
+++ b/zimlib/include/zim/cluster.h
@@ -88,8 +88,8 @@
   Blob getBlob(size_type n) const;
 
   size_type count() const   { return impl ? impl->getCount() : 0; }
-  size_type size() const{ return impl ? impl->getSize() : 0; }
-  void clear()  { impl = 0; }
+  size_type size() const{ return impl ? impl->getSize(): 
sizeof(size_type); }
+  void clear()  { if (impl) impl->clear(); }
 
   void addBlob(const char* data, unsigned size) { getImpl()->addBlob(data, 
size); }
   void addBlob(const Blob& blob){ 
getImpl()->addBlob(blob); }
diff --git a/zimlib/src/cluster.cpp b/zimlib/src/cluster.cpp
index 6f6ea14..3630042 100644
--- a/zimlib/src/cluster.cpp
+++ b/zimlib/src/cluster.cpp
@@ -60,7 +60,7 @@
   }
 
   ClusterImpl::ClusterImpl()
-: compression(zimcompDefault)
+: compression(zimcompNone)
   {
 offsets.push_back(0);
   }

-- 
To view, visit https://gerrit.wikimedia.org/r/296547
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I468a1719a33c450db9a28d9704b539bdb97cd7fc
Gerrit-PatchSet: 3
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: C. Scott Ananian 
Gerrit-Reviewer: Kelson 
Gerrit-Reviewer: Mgautierfr 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: Move `throw` statement out of header file.

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/295720 )

Change subject: Move `throw` statement out of header file.
..


Move `throw` statement out of header file.

This ensures that we don't fail compilation when including the header
file in an environment where exception handling is disabled (like
when binding to node.js).

Change-Id: Ib49060c7fe479054e58c20249dd9b3236ea7eb03
---
M zimlib/include/zim/writer/articlesource.h
M zimlib/src/articlesource.cpp
2 files changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimlib/include/zim/writer/articlesource.h 
b/zimlib/include/zim/writer/articlesource.h
index 94ee91b..54653ef 100644
--- a/zimlib/include/zim/writer/articlesource.h
+++ b/zimlib/include/zim/writer/articlesource.h
@@ -97,7 +97,8 @@
  * code to not use it.
  * This should be removed once every users switch to new API.
  */
-virtual Blob getData(const std::string& aid) { throw "This should not 
be called"; };
+virtual Blob getData(const std::string& aid);
+
 
/**/
 };
 
diff --git a/zimlib/src/articlesource.cpp b/zimlib/src/articlesource.cpp
index cc72ae2..a2087a7 100644
--- a/zimlib/src/articlesource.cpp
+++ b/zimlib/src/articlesource.cpp
@@ -80,6 +80,9 @@
   std::cerr << " You should override Article::getData 
directly." << std::endl;
   return __source->getData(getAid());
 }
+Blob ArticleSource::getData(const std::string& aid) {
+throw std::runtime_error("This should not be called");
+}
 
/**/
 
 Uuid ArticleSource::getUuid()

-- 
To view, visit https://gerrit.wikimedia.org/r/295720
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib49060c7fe479054e58c20249dd9b3236ea7eb03
Gerrit-PatchSet: 1
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: C. Scott Ananian 
Gerrit-Reviewer: Kelson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: Bug fix: don't store pointers inside a dynamic vector.

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/296644 )

Change subject: Bug fix: don't store pointers inside a dynamic vector.
..


Bug fix: don't store pointers inside a dynamic vector.

Use offsets instead, since the actual objects change location whenever
the std::vector resizes its internal storage.

This is a follow-up to f5de40f94b30795f42bb9388cbb46df9cd605167.

Change-Id: I166aa8dd209dd2755e68be70829f269a71a3aaca
---
M zimlib/include/zim/writer/zimcreator.h
M zimlib/src/zimcreator.cpp
2 files changed, 10 insertions(+), 8 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimlib/include/zim/writer/zimcreator.h 
b/zimlib/include/zim/writer/zimcreator.h
index 2e52d7e..8ce2c44 100644
--- a/zimlib/include/zim/writer/zimcreator.h
+++ b/zimlib/include/zim/writer/zimcreator.h
@@ -33,7 +33,7 @@
 {
   public:
 typedef std::vector DirentsType;
-typedef std::vector DirentPtrsType;
+typedef std::vector DirentPtrsType;
 typedef std::vector SizeVectorType;
 typedef std::vector OffsetsType;
 typedef std::map MimeTypes;
diff --git a/zimlib/src/zimcreator.cpp b/zimlib/src/zimcreator.cpp
index 46c550f..9c024a7 100644
--- a/zimlib/src/zimcreator.cpp
+++ b/zimlib/src/zimcreator.cpp
@@ -232,7 +232,7 @@
 }
 dirents.back().setCluster(clusterOffsets.size(), cluster->count());
 cluster->addBlob(blob);
-myDirents->push_back(&(dirents.back()));
+myDirents->push_back(dirents.size()-1);
 
 // If cluster is now large enough, write it to disk.
 if (cluster->size() >= minChunkSize * 1024)
@@ -247,10 +247,11 @@
   cluster->clear();
   myDirents->clear();
   // Update the cluster number of the dirents *not* written to disk.
-  for (DirentPtrsType::iterator di = otherDirents->begin();
-   di != otherDirents->end(); ++di)
+  for (DirentPtrsType::iterator dpi = otherDirents->begin();
+   dpi != otherDirents->end(); ++dpi)
   {
-(*di)->setCluster(clusterOffsets.size(), (*di)->getBlobNumber());
+Dirent *di = [*dpi];
+di->setCluster(clusterOffsets.size(), di->getBlobNumber());
   }
   offset_type end = out.tellp();
   currentSize += (end - start) +
@@ -263,10 +264,11 @@
   {
 clusterOffsets.push_back(out.tellp());
 out << compCluster;
-for (DirentPtrsType::iterator di = uncompDirents.begin();
- di != uncompDirents.end(); ++di)
+for (DirentPtrsType::iterator dpi = uncompDirents.begin();
+ dpi != uncompDirents.end(); ++dpi)
 {
-  (*di)->setCluster(clusterOffsets.size(), (*di)->getBlobNumber());
+  Dirent *di = [*dpi];
+  di->setCluster(clusterOffsets.size(), di->getBlobNumber());
 }
   }
   compCluster.clear();

-- 
To view, visit https://gerrit.wikimedia.org/r/296644
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I166aa8dd209dd2755e68be70829f269a71a3aaca
Gerrit-PatchSet: 1
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: C. Scott Ananian 
Gerrit-Reviewer: Kelson 
Gerrit-Reviewer: Mgautierfr 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: Move article's related stuffs in article.(h|cpp).

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/295516 )

Change subject: Move article's related stuffs in article.(h|cpp).
..


Move article's related stuffs in article.(h|cpp).

Change-Id: I2a257ea1a0a13eca0748b444838a525666a9090d
---
M zimwriterfs/Makefile.am
A zimwriterfs/article.cpp
A zimwriterfs/article.h
M zimwriterfs/zimwriterfs.cpp
4 files changed, 253 insertions(+), 199 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimwriterfs/Makefile.am b/zimwriterfs/Makefile.am
index ea2ab7a..3383e35 100644
--- a/zimwriterfs/Makefile.am
+++ b/zimwriterfs/Makefile.am
@@ -3,4 +3,5 @@
 
 zimwriterfs_SOURCES= \
 zimwriterfs.cpp \
-tools.cpp
+tools.cpp \
+article.cpp
diff --git a/zimwriterfs/article.cpp b/zimwriterfs/article.cpp
new file mode 100644
index 000..f743cde
--- /dev/null
+++ b/zimwriterfs/article.cpp
@@ -0,0 +1,158 @@
+/*
+ * Copyright 2013-2016 Emmanuel Engelhart 
+ * Copyright 2016 Matthieu Gautier 
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU  General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+ * MA 02110-1301, USA.
+ */
+
+#include "article.h"
+#include "tools.h"
+
+
+extern std::string directoryPath;
+
+Article::Article(const std::string& path, const bool detectRedirects) {
+  invalid = false;
+
+  /* aid */
+  aid = path.substr(directoryPath.size()+1);
+
+  /* url */
+  url = aid;
+
+  /* mime-type */
+  mimeType = getMimeTypeForFile(aid);
+  
+  /* namespace */
+  ns = getNamespaceForMimeType(mimeType)[0];
+
+  /* HTML specific code */
+  if (mimeType.find("text/html") != std::string::npos) {
+std::size_t found;
+std::string html = getFileContent(path);
+GumboOutput* output = gumbo_parse(html.c_str());
+GumboNode* root = output->root;
+
+/* Search the content of the  tag in the HTML */
+if (root->type == GUMBO_NODE_ELEMENT && root->v.element.children.length >= 
2) {
+  const GumboVector* root_children = >v.element.children;
+  GumboNode* head = NULL;
+  for (int i = 0; i < root_children->length; ++i) {
+   GumboNode* child = (GumboNode*)(root_children->data[i]);
+   if (child->type == GUMBO_NODE_ELEMENT &&
+   child->v.element.tag == GUMBO_TAG_HEAD) {
+ head = child;
+ break;
+   }
+  }
+
+  if (head != NULL) {
+   GumboVector* head_children = >v.element.children;
+   for (int i = 0; i < head_children->length; ++i) {
+ GumboNode* child = (GumboNode*)(head_children->data[i]);
+ if (child->type == GUMBO_NODE_ELEMENT &&
+ child->v.element.tag == GUMBO_TAG_TITLE) {
+   if (child->v.element.children.length == 1) {
+ GumboNode* title_text = 
(GumboNode*)(child->v.element.children.data[0]);
+ if (title_text->type == GUMBO_NODE_TEXT) {
+   title = title_text->v.text.text;
+ }
+   }
+ }
+   }
+
+   /* Detect if this is a redirection (if no redirects CSV specified) */
+   std::string targetUrl;
+   try {
+ targetUrl = detectRedirects ? 
extractRedirectUrlFromHtml(head_children) : "";
+   } catch (std::string ) {
+ std::cerr << error << std::endl;
+   }
+   if (!targetUrl.empty()) {
+ redirectAid = computeAbsolutePath(aid, decodeUrl(targetUrl));
+ if (!fileExists(directoryPath + "/" + redirectAid)) {
+   redirectAid.clear();
+   invalid = true;
+ }
+   }
+  }
+
+  /* If no title, then compute one from the filename */
+  if (title.empty()) {
+   found = path.rfind("/");
+   if (found != std::string::npos) {
+ title = path.substr(found+1);
+ found = title.rfind(".");
+ if (found!=std::string::npos) {
+   title = title.substr(0, found);
+ }
+   } else {
+ title = path;
+   }
+   std::replace(title.begin(), title.end(), '_',  ' ');
+  }
+}
+
+gumbo_destroy_output(, output);
+  }
+}
+
+std::string Article::getAid() const
+{
+  return aid;
+}
+
+bool Article::isInvalid() const
+{
+  return invalid;
+}
+
+char Article::getNamespace() const
+{
+  return ns;
+}
+
+std::string Article::getUrl() const
+{
+  return url;
+}
+
+std::string 

[MediaWiki-commits] [Gerrit] openzim[master]: Port zimwriterfs to the new API.

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/296911 )

Change subject: Port zimwriterfs to the new API.
..


Port zimwriterfs to the new API.

No more ArticleSource::getData.

Change-Id: I76cd6f3e7e4a390ed6a58cf9815dda2a2f1bfde5
---
M zimwriterfs/Makefile.am
M zimwriterfs/article.cpp
M zimwriterfs/article.h
M zimwriterfs/articlesource.cpp
M zimwriterfs/articlesource.h
A zimwriterfs/mimetypecounter.cpp
A zimwriterfs/mimetypecounter.h
M zimwriterfs/zimwriterfs.cpp
8 files changed, 376 insertions(+), 248 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimwriterfs/Makefile.am b/zimwriterfs/Makefile.am
index 6e46553..92641d9 100644
--- a/zimwriterfs/Makefile.am
+++ b/zimwriterfs/Makefile.am
@@ -5,4 +5,5 @@
 zimwriterfs.cpp \
 tools.cpp \
 article.cpp \
-articlesource.cpp
+articlesource.cpp \
+mimetypecounter.cpp
diff --git a/zimwriterfs/article.cpp b/zimwriterfs/article.cpp
index 98ec882..3840f7b 100644
--- a/zimwriterfs/article.cpp
+++ b/zimwriterfs/article.cpp
@@ -21,11 +21,61 @@
 #include "article.h"
 #include "tools.h"
 
+#include 
+#include 
+
 
 extern std::string directoryPath;
 
-Article::Article(ArticleSource* source, const std::string& path, const bool 
detectRedirects):
-source(source)
+std::string Article::getAid() const
+{
+  return aid;
+}
+
+bool Article::isInvalid() const
+{
+  return invalid;
+}
+
+char Article::getNamespace() const
+{
+  return ns;
+}
+
+std::string Article::getUrl() const
+{
+  return url;
+}
+
+std::string Article::getTitle() const
+{
+  return title;
+}
+
+bool Article::isRedirect() const
+{
+  return !redirectAid.empty();
+}
+
+std::string Article::getMimeType() const
+{
+  return mimeType;
+}
+
+std::string Article::getRedirectAid() const
+{
+  return redirectAid;
+}
+
+bool Article::shouldCompress() const {
+  return (getMimeType().find("text") == 0 ||
+ getMimeType() == "application/javascript" ||
+ getMimeType() == "application/json" ||
+  getMimeType() == "image/svg+xml" ? true : false);
+}
+
+FileArticle::FileArticle(const std::string& path, const bool detectRedirects):
+dataRead(false)
 {
   invalid = false;
 
@@ -109,57 +159,125 @@
   }
 }
 
+/* Update links in the html to let them still be valid */
+std::map links;
+getLinks(root, links);
+std::map::iterator it;
+
+/* If a link appearch to be duplicated in the HTML, it will
+   occurs only one time in the links variable */
+for(it = links.begin(); it != links.end(); it++) {
+  if (!it->first.empty()
+&& it->first[0] != '#'
+&& it->first[0] != '?'
+&& it->first.substr(0, 5) != "data:") {
+replaceStringInPlace(html, "\"" + it->first + "\"", "\"" + 
computeNewUrl(aid, it->first) + "\"");
+  }
+}
+
+data = html;
+dataRead = true;
+
 gumbo_destroy_output(, output);
   }
 }
 
-std::string Article::getAid() const
+zim::Blob FileArticle::getData() const {
+if ( dataRead )
+return zim::Blob(data.data(), data.size());;
+
+std::string aidPath = directoryPath + "/" + aid;
+std::string fileContent = getFileContent(aidPath);
+
+if (getMimeType().find("text/css") == 0) {
+/* Rewrite url() values in the CSS */
+size_t startPos = 0;
+size_t endPos = 0;
+std::string url;
+
+while ((startPos = fileContent.find("url(", endPos)) && startPos != 
std::string::npos) {
+/* URL delimiters */
+endPos = fileContent.find(")", startPos);
+startPos = startPos + (fileContent[startPos+4] == '\'' || 
fileContent[startPos+4] == '"' ? 5 : 4);
+endPos = endPos - (fileContent[endPos-1] == '\'' || 
fileContent[endPos-1] == '"' ? 1 : 0);
+url = fileContent.substr(startPos, endPos - startPos);
+std::string startDelimiter = fileContent.substr(startPos-1, 1);
+std::string endDelimiter = fileContent.substr(endPos, 1);
+
+if (url.substr(0, 5) != "data:") {
+/* Deal with URL with arguments (using '? ') */
+std::string path = url;
+size_t markPos = url.find("?");
+if (markPos != std::string::npos) {
+path = url.substr(0, markPos);
+}
+
+/* Embeded fonts need to be inline because Kiwix is
+   otherwise not able to load same because of the
+   same-origin security */
+std::string mimeType = getMimeTypeForFile(path);
+if ( mimeType == "application/font-ttf"
+  || mimeType == "application/font-woff"
+  || mimeType == "application/vnd.ms-opentype"
+  || mimeType == "application/vnd.ms-fontobject") {
+try {
+ 

[MediaWiki-commits] [Gerrit] openzim[master]: Actually call the (previously-unused) ArticleSource#setFilen...

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/296632 )

Change subject: Actually call the (previously-unused) ArticleSource#setFilename 
method.
..


Actually call the (previously-unused) ArticleSource#setFilename method.

Change-Id: I00d340f86c91419f1237976f6eb636ea8c32a743
---
M zimlib/src/zimcreator.cpp
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimlib/src/zimcreator.cpp b/zimlib/src/zimcreator.cpp
index 9c024a7..1b528f4 100644
--- a/zimlib/src/zimcreator.cpp
+++ b/zimlib/src/zimcreator.cpp
@@ -110,6 +110,7 @@
  ? fname.substr(0, fname.size() - 4)
  : fname;
   log_debug("basename " << basename);
+  src.setFilename(fname);
 
   INFO("create directory entries");
   createDirentsAndClusters(src, basename + ".tmp");

-- 
To view, visit https://gerrit.wikimedia.org/r/296632
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I00d340f86c91419f1237976f6eb636ea8c32a743
Gerrit-PatchSet: 2
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: C. Scott Ananian 
Gerrit-Reviewer: Kelson 
Gerrit-Reviewer: Mgautierfr 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: Add a indexer.

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/296912 )

Change subject: Add a indexer.
..


Add a indexer.

This indexer is not used.
This is mainly code from kiwix-indexer imported in openzim.
Unused function in *Tools has been removed.
No dependency to xapian.

Change-Id: I55079339d21d6903634c265f83f4d1c6ba0ac333
---
M zimwriterfs/Makefile.am
A zimwriterfs/indexer.cpp
A zimwriterfs/indexer.h
A zimwriterfs/pathTools.cpp
A zimwriterfs/pathTools.h
A zimwriterfs/resourceTools.cpp
A zimwriterfs/resourceTools.h
M zimwriterfs/zimwriterfs.cpp
8 files changed, 921 insertions(+), 2 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimwriterfs/Makefile.am b/zimwriterfs/Makefile.am
index 92641d9..628b74c 100644
--- a/zimwriterfs/Makefile.am
+++ b/zimwriterfs/Makefile.am
@@ -6,4 +6,7 @@
 tools.cpp \
 article.cpp \
 articlesource.cpp \
+indexer.cpp \
+resourceTools.cpp \
+pathTools.cpp \
 mimetypecounter.cpp
diff --git a/zimwriterfs/indexer.cpp b/zimwriterfs/indexer.cpp
new file mode 100644
index 000..7820a32
--- /dev/null
+++ b/zimwriterfs/indexer.cpp
@@ -0,0 +1,262 @@
+/*
+ * Copyright 2011-2014 Emmanuel Engelhart 
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU  General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+ * MA 02110-1301, USA.
+ */
+
+#include "indexer.h"
+#include "resourceTools.h"
+#include "pathTools.h"
+#include 
+
+  /* Count word */
+  unsigned int Indexer::countWords(const string ) {
+unsigned int numWords = 1;
+unsigned int length = text.size();
+
+for(unsigned int i=0; istopWords.push_back(stopWord);
+}
+  }
+
+  /* Article indexer methods */
+  void *Indexer::indexArticles(void *ptr) {
+pthread_setcanceltype(PTHREAD_CANCEL_DEFERRED, NULL);
+Indexer *self = (Indexer *)ptr;
+unsigned int indexedArticleCount = 0;
+indexerToken token;
+
+self->indexingPrelude(self->getIndexPath());
+
+while (self->popFromToIndexQueue(token)) {
+  self->index(token.url,
+ token.accentedTitle,
+ token.title,
+ token.keywords,
+ token.content,
+ token.snippet,
+ token.size,
+ token.wordCount
+ );
+
+  indexedArticleCount += 1;
+
+  /* Make a hard-disk flush every 10.000 articles */
+  if (indexedArticleCount % 5000 == 0) {
+   self->flush();
+  }
+
+  /* Test if the thread should be cancelled */
+  pthread_testcancel();
+}
+self->indexingPostlude();
+
+/* Write content id file */
+string path = appendToDirectory(self->getIndexPath(), "content.id");
+writeTextFile(path, self->getZimId());
+
+usleep(100);
+
+self->articleIndexerRunning(false);
+pthread_exit(NULL);
+return NULL;
+  }
+
+  void Indexer::articleIndexerRunning(bool value) {
+pthread_mutex_lock();
+this->articleIndexerRunningFlag = value;
+pthread_mutex_unlock();
+  }
+
+  bool Indexer::isArticleIndexerRunning() {
+pthread_mutex_lock();
+bool retVal = this->articleIndexerRunningFlag;
+pthread_mutex_unlock();
+return retVal;
+  }
+
+  /* ToIndexQueue methods */
+  bool Indexer::isToIndexQueueEmpty() {
+pthread_mutex_lock();
+bool retVal = this->toIndexQueue.empty();
+pthread_mutex_unlock();
+return retVal;
+  }
+
+  void Indexer::pushToIndexQueue(indexerToken ) {
+pthread_mutex_lock();
+this->toIndexQueue.push(token);
+pthread_mutex_unlock();
+usleep(int(this->toIndexQueue.size() / 200) / 10 * 1000);
+  }
+
+  bool Indexer::popFromToIndexQueue(indexerToken ) {
+while (this->isToIndexQueueEmpty()) {
+  usleep(500);
+  if (this->getVerboseFlag()) {
+   std::cout << "Waiting... ToIndexQueue is empty for now..." << std::endl;
+  }
+
+  pthread_testcancel();
+}
+
+pthread_mutex_lock();
+token = this->toIndexQueue.front();
+this->toIndexQueue.pop();
+pthread_mutex_unlock();
+
+if (token.title == ""){
+//This is a empty token, end of the queue.
+return false;
+}
+return true;
+  }
+
+  /* Index 

[MediaWiki-commits] [Gerrit] openzim[master]: Support running tests with "make check"

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/330859 )

Change subject: Support running tests with "make check"
..


Support running tests with "make check"

Change-Id: I1e15ba2dbda2f71c98bafa84d36b81c2a1772df1
---
M zimlib/.gitignore
M zimlib/test/Makefile.am
2 files changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimlib/.gitignore b/zimlib/.gitignore
index 550c09a..5896863 100644
--- a/zimlib/.gitignore
+++ b/zimlib/.gitignore
@@ -28,3 +28,6 @@
 src/tools/zimdump
 src/tools/zimsearch
 libzim.pc
+test-driver
+test/zimlib-test*
+test/test-suite.log
diff --git a/zimlib/test/Makefile.am b/zimlib/test/Makefile.am
index 29dd7bd..f28d6fe 100644
--- a/zimlib/test/Makefile.am
+++ b/zimlib/test/Makefile.am
@@ -1,6 +1,7 @@
 AM_CPPFLAGS=-I$(top_srcdir)/include
 
 noinst_PROGRAMS = zimlib-test
+TESTS = zimlib-test
 
 if WITH_ZLIB
 ZLIB_SOURCES = \

-- 
To view, visit https://gerrit.wikimedia.org/r/330859
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1e15ba2dbda2f71c98bafa84d36b81c2a1772df1
Gerrit-PatchSet: 1
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Kelson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: Add a API to get the offset of a article in the zimfile.

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/296914 )

Change subject: Add a API to get the offset of a article in the zimfile.
..


Add a API to get the offset of a article in the zimfile.

To get the offset of a article :

- get the article
- use article.getOffset()

If offset cannot be found (not regular article (redirection...) or cluster
is compressed), 0 is returned.

Change-Id: I5b4aced056c16aa8fc62ce4b8048553ae1f96c25
---
M zimlib/include/zim/article.h
M zimlib/include/zim/cluster.h
M zimlib/include/zim/file.h
M zimlib/src/cluster.cpp
M zimlib/src/file.cpp
5 files changed, 32 insertions(+), 7 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimlib/include/zim/article.h b/zimlib/include/zim/article.h
index 5172adb..b950173 100644
--- a/zimlib/include/zim/article.h
+++ b/zimlib/include/zim/article.h
@@ -85,6 +85,15 @@
: 
const_cast(file).getBlob(dirent.getClusterNumber(), 
dirent.getBlobNumber());
   }
 
+  offset_type getOffset() const
+  {
+Dirent dirent = getDirent();
+return isRedirect()
+|| isLinktarget()
+|| isDeleted() ? 0
+   : 
const_cast(file).getOffset(dirent.getClusterNumber(), 
dirent.getBlobNumber());
+  }
+
   std::string getPage(bool layout = true, unsigned maxRecurse = 10);
   void getPage(std::ostream&, bool layout = true, unsigned maxRecurse = 
10);
 
diff --git a/zimlib/include/zim/cluster.h b/zimlib/include/zim/cluster.h
index bd55cb5..96b16f0 100644
--- a/zimlib/include/zim/cluster.h
+++ b/zimlib/include/zim/cluster.h
@@ -42,6 +42,7 @@
   CompressionType compression;
   Offsets offsets;
   Data data;
+  offset_type startOffset;
 
   void read(std::istream& in);
   void write(std::ostream& out) const;
@@ -49,14 +50,15 @@
 public:
   ClusterImpl();
 
-  void setCompression(CompressionType c)  { compression = c; }
-  CompressionType getCompression() const  { return compression; }
-  bool isCompressed() const   { return compression == 
zimcompZip || compression == zimcompBzip2 || compression == zimcompLzma; }
+  void setCompression(CompressionType c)   { compression = c; }
+  CompressionType getCompression() const   { return compression; }
+  bool isCompressed() const{ return compression == 
zimcompZip || compression == zimcompBzip2 || compression == zimcompLzma; }
 
-  size_type getCount() const  { return offsets.size() - 1; }
-  const char* getData(unsigned n) const   { return [ offsets[n] ]; }
-  size_type getSize(unsigned n) const { return offsets[n+1] - 
offsets[n]; }
-  size_type getSize() const   { return offsets.size() * 
sizeof(size_type) + data.size(); }
+  size_type getCount() const   { return offsets.size() - 1; }
+  const char* getData(unsigned n) const{ return [ offsets[n] ]; }
+  size_type getSize(unsigned n) const  { return offsets[n+1] - 
offsets[n]; }
+  size_type getSize() const{ return offsets.size() * 
sizeof(size_type) + data.size(); }
+  offset_type getOffset(size_type n) const { return startOffset + 
offsets[n]; }
   Blob getBlob(size_type n) const;
   void clear();
 
@@ -85,6 +87,7 @@
 
   const char* getBlobPtr(size_type n) const { return impl->getData(n); 
}
   size_type getBlobSize(size_type n) const  { return impl->getSize(n); 
}
+  offset_type getBlobOffset(size_type n) const  { return 
impl->getOffset(n); }
   Blob getBlob(size_type n) const;
 
   size_type count() const   { return impl ? impl->getCount() : 0; }
diff --git a/zimlib/include/zim/file.h b/zimlib/include/zim/file.h
index a6ac75b..0a3a2c3 100644
--- a/zimlib/include/zim/file.h
+++ b/zimlib/include/zim/file.h
@@ -62,6 +62,7 @@
 
   Blob getBlob(size_type clusterIdx, size_type blobIdx)
 { return getCluster(clusterIdx).getBlob(blobIdx); }
+  offset_type getOffset(size_type clusterIdx, size_type blobIdx);
 
   size_type getNamespaceBeginOffset(char ch)
 { return impl->getNamespaceBeginOffset(ch); }
diff --git a/zimlib/src/cluster.cpp b/zimlib/src/cluster.cpp
index 3630042..3b24fee 100644
--- a/zimlib/src/cluster.cpp
+++ b/zimlib/src/cluster.cpp
@@ -79,6 +79,9 @@
 
 size_type n = offset / 4;
 size_type a = offset;
+// offset are from start of cluster !after the char telling the 
compression!
+// but startOffset is offset from start of the cluster.
+startOffset = offset + sizeof(char);
 
 log_debug1("first offset is " << offset << " n=" << n << " a=" << a);
 
diff --git a/zimlib/src/file.cpp b/zimlib/src/file.cpp
index b6777e6..c5f25a4 100644
--- a/zimlib/src/file.cpp
+++ b/zimlib/src/file.cpp
@@ -201,6 +201,15 @@
   File::const_iterator 

[MediaWiki-commits] [Gerrit] openzim[master]: Fix issue #2 Zimdump crashes on long titles.

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/296931 )

Change subject: Fix issue #2 Zimdump crashes on long titles.
..


Fix issue #2 Zimdump crashes on long titles.

Most of filesystems have a filename limited to 255 bytes.
If the filename is > 255 bytes truncate it.
Postfix the truncated filename with a counter to avoid name collision.

Change-Id: I0475aaa2d1221be46c48c5a52814ca6659cc7940
---
M zimlib/src/tools/zimDump.cpp
1 file changed, 8 insertions(+), 0 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimlib/src/tools/zimDump.cpp b/zimlib/src/tools/zimDump.cpp
index 65d13b8..7c0149d 100644
--- a/zimlib/src/tools/zimDump.cpp
+++ b/zimlib/src/tools/zimDump.cpp
@@ -394,6 +394,7 @@
 
 void ZimDumper::dumpFiles(const std::string& directory)
 {
+  unsigned int truncatedFiles = 0;
   ::mkdir(directory.c_str(), 0777);
 
   std::set ns;
@@ -406,6 +407,13 @@
 std::string::size_type p;
 while ((p = t.find('/')) != std::string::npos)
   t.replace(p, 1, "%2f");
+if ( t.length() > 255 )
+{
+  std::ostringstream sspostfix, sst;
+  sspostfix << (++truncatedFiles);
+  sst << t.substr(0, 254-sspostfix.tellp()) << "~" << sspostfix.str();
+  t = sst.str();
+}
 std::string f = d + '/' + t;
 std::ofstream out(f.c_str());
 out << it->getData();

-- 
To view, visit https://gerrit.wikimedia.org/r/296931
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0475aaa2d1221be46c48c5a52814ca6659cc7940
Gerrit-PatchSet: 1
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: Mgautierfr 
Gerrit-Reviewer: Kelson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: Handle the case of last article for filenameQueue is invalid.

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/296915 )

Change subject: Handle the case of last article for filenameQueue is invalid.
..


Handle the case of last article for filenameQueue is invalid.

Change-Id: I970d7dc6cfbc572ed7c2b2c7e1b4d3a27cd98ce9
---
M zimwriterfs/articlesource.cpp
1 file changed, 8 insertions(+), 3 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimwriterfs/articlesource.cpp b/zimwriterfs/articlesource.cpp
index 06a773d..0eea3e1 100644
--- a/zimwriterfs/articlesource.cpp
+++ b/zimwriterfs/articlesource.cpp
@@ -58,6 +58,7 @@
 
   if (article != NULL) {
 delete article;
+article = NULL;
   }
 
   if (!metadataQueue.empty()) {
@@ -69,12 +70,16 @@
 article = new RedirectArticle(line);
   } else if (filenameQueue.popFromQueue(path)) {
 article = new FileArticle(path);
-while (article && article->isInvalid() && 
filenameQueue.popFromQueue(path)) {
+while (article->isInvalid() && filenameQueue.popFromQueue(path)) {
   delete article;
   article = new FileArticle(path);
 };
-  } else {
-article = NULL;
+if (article->isInvalid()) {
+  article = NULL;
+}
+  }
+
+  if (article == NULL) {
 if ( !loopOverHandlerStarted )
 {
 currentLoopHandler = articleHandlers.begin();

-- 
To view, visit https://gerrit.wikimedia.org/r/296915
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I970d7dc6cfbc572ed7c2b2c7e1b4d3a27cd98ce9
Gerrit-PatchSet: 1
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: Mgautierfr 
Gerrit-Reviewer: Kelson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: Delete all articles, even the last one.

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/303776 )

Change subject: Delete all articles, even the last one.
..


Delete all articles, even the last one.

No so important, only one article *could* be impacted.
(If it is the last article and it is invalid)

Change-Id: Ibd3e7587148eccbdb2c588d4a915a94e343fc003
---
M zimwriterfs/articlesource.cpp
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimwriterfs/articlesource.cpp b/zimwriterfs/articlesource.cpp
index 0eea3e1..5ce0cc1 100644
--- a/zimwriterfs/articlesource.cpp
+++ b/zimwriterfs/articlesource.cpp
@@ -75,6 +75,7 @@
   article = new FileArticle(path);
 };
 if (article->isInvalid()) {
+  delete article;
   article = NULL;
 }
   }

-- 
To view, visit https://gerrit.wikimedia.org/r/303776
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibd3e7587148eccbdb2c588d4a915a94e343fc003
Gerrit-PatchSet: 1
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: Mgautierfr 
Gerrit-Reviewer: Kelson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: Remove temporary ft_index.

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/304450 )

Change subject: Remove temporary ft_index.
..


Remove temporary ft_index.

Xapian indexer create temporary files while indexing content.
Remove those files at end.

Change-Id: I637da46f69a8f127052a48de5028c185fb0748aa
---
M zimwriterfs/tools.cpp
M zimwriterfs/tools.h
M zimwriterfs/xapianIndexer.cpp
M zimwriterfs/xapianIndexer.h
4 files changed, 31 insertions(+), 0 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimwriterfs/tools.cpp b/zimwriterfs/tools.cpp
index b73b5ca..af6d71d 100644
--- a/zimwriterfs/tools.cpp
+++ b/zimwriterfs/tools.cpp
@@ -31,6 +31,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -539,3 +540,19 @@
   ustring.toUTF8String(unaccentedText);
   return unaccentedText;
 }
+
+void remove_all(const std::string& path) {
+  DIR *dir;
+  struct dirent *ent;
+  if ((dir = opendir (path.c_str())) != NULL) {
+/* It's a directory, remove all its entries. */
+while ((ent = readdir (dir)) != NULL) {
+  if (strcmp(ent->d_name, ".") and strcmp(ent->d_name, "..")) {
+std::string childPath = path + SEPARATOR + ent->d_name;
+remove_all(childPath);
+  }
+}
+closedir (dir);
+  }
+  remove(path.c_str());
+}
diff --git a/zimwriterfs/tools.h b/zimwriterfs/tools.h
index d85b292..bd7d6e6 100644
--- a/zimwriterfs/tools.h
+++ b/zimwriterfs/tools.h
@@ -47,4 +47,6 @@
 
 std::string removeAccents(const std::string );
 
+void remove_all(const std::string& path);
+
 #endif // OPENZIM_ZIMWRITERFS_TOOLS_H
diff --git a/zimwriterfs/xapianIndexer.cpp b/zimwriterfs/xapianIndexer.cpp
index 4d0effa..4117c14 100644
--- a/zimwriterfs/xapianIndexer.cpp
+++ b/zimwriterfs/xapianIndexer.cpp
@@ -32,6 +32,17 @@
   */
 }
 
+XapianIndexer::~XapianIndexer(){
+  if (!indexPath.empty()) {
+try {
+  remove_all(indexPath + ".tmp");
+  remove_all(indexPath);
+} catch(...) {
+  /* Do not raise */
+}
+  }
+}
+
 void XapianIndexer::indexingPrelude(const string indexPath_) {
 indexPath = indexPath_;
 this->writableDatabase = Xapian::WritableDatabase(indexPath + ".tmp", 
Xapian::DB_CREATE_OR_OVERWRITE);
diff --git a/zimwriterfs/xapianIndexer.h b/zimwriterfs/xapianIndexer.h
index 71dfe64..bbb170e 100644
--- a/zimwriterfs/xapianIndexer.h
+++ b/zimwriterfs/xapianIndexer.h
@@ -50,6 +50,7 @@
 class XapianIndexer : public Indexer, public IHandler {
 public:
 XapianIndexer(const std::string& language, bool verbose);
+virtual ~XapianIndexer();
 std::string getIndexPath() { return indexPath; }
 
 protected:

-- 
To view, visit https://gerrit.wikimedia.org/r/304450
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I637da46f69a8f127052a48de5028c185fb0748aa
Gerrit-PatchSet: 1
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: Mgautierfr 
Gerrit-Reviewer: Kelson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: Fix memory leak in zimwriterfs.

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/303775 )

Change subject: Fix memory leak in zimwriterfs.
..


Fix memory leak in zimwriterfs.

We are using polymorphism in articlesource.cpp (a Article* pointer but
derived class as real instance).
If we want to correctly delete allocated resources, we need to let compiler
get the correct destructor in the vtable.

In our case, the data member of FileArticle was never destructed and
the internal buffer of the std::string was leaked (even if the article was
correctly deleted).

Change-Id: I58833f48a440e9c91a97637d6c11e5642eaf64ce
---
M zimwriterfs/article.h
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimwriterfs/article.h b/zimwriterfs/article.h
index 49f7d25..4a26ead 100644
--- a/zimwriterfs/article.h
+++ b/zimwriterfs/article.h
@@ -47,6 +47,7 @@
 virtual std::string getMimeType() const;
 virtual std::string getRedirectAid() const;
 virtual bool shouldCompress() const;
+virtual ~Article() {};
 };
 
 class MetadataArticle : public Article {

-- 
To view, visit https://gerrit.wikimedia.org/r/303775
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I58833f48a440e9c91a97637d6c11e5642eaf64ce
Gerrit-PatchSet: 1
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: Mgautierfr 
Gerrit-Reviewer: Kelson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: Better replaceStringInPlaceOnce.

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/303778 )

Change subject: Better replaceStringInPlaceOnce.
..


Better replaceStringInPlaceOnce.

If we do only one replace, we do not need a while and a update of pos.
(Thank to cppcheck)

Change-Id: I5c825590c3a5ed7e01020b415b5ea695baa070a0
---
M zimwriterfs/tools.cpp
1 file changed, 2 insertions(+), 4 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimwriterfs/tools.cpp b/zimwriterfs/tools.cpp
index cc6091d..b73b5ca 100644
--- a/zimwriterfs/tools.cpp
+++ b/zimwriterfs/tools.cpp
@@ -423,11 +423,9 @@
 void replaceStringInPlaceOnce(std::string& subject,
   const std::string& search,
   const std::string& replace) {
-  size_t pos = 0;
-  while ((pos = subject.find(search, pos)) != std::string::npos) {
+  size_t pos = subject.find(search, 0);
+  if (pos != std::string::npos) {
 subject.replace(pos, search.length(), replace);
-pos += replace.length();
-return; /* Do it once */
   }
 }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/303778
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5c825590c3a5ed7e01020b415b5ea695baa070a0
Gerrit-PatchSet: 1
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: Mgautierfr 
Gerrit-Reviewer: Kelson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: The indexed url must contain the namespace.

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/304240 )

Change subject: The indexed url must contain the namespace.
..


The indexed url must contain the namespace.

Change-Id: Icc17c7552a2b213a15edc2c674fe00aacb36952b
---
M zimwriterfs/xapianIndexer.cpp
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimwriterfs/xapianIndexer.cpp b/zimwriterfs/xapianIndexer.cpp
index 8325152..4d0effa 100644
--- a/zimwriterfs/xapianIndexer.cpp
+++ b/zimwriterfs/xapianIndexer.cpp
@@ -108,7 +108,7 @@
 return;
 
 token.title = article->getTitle();
-token.url = article->getUrl();
+token.url = std::string(1, article->getNamespace()) + '/' + 
article->getUrl();
 zim::Blob article_content = article->getData();
 token.content = std::string(article_content.data(), 
article_content.size());
 

-- 
To view, visit https://gerrit.wikimedia.org/r/304240
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icc17c7552a2b213a15edc2c674fe00aacb36952b
Gerrit-PatchSet: 1
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: Mgautierfr 
Gerrit-Reviewer: Kelson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: Close the magic database.

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/303777 )

Change subject: Close the magic database.
..


Close the magic database.

Change-Id: Ib0c7d1736d804526eea701ef39cb9ae5780b13c1
---
M zimwriterfs/zimwriterfs.cpp
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimwriterfs/zimwriterfs.cpp b/zimwriterfs/zimwriterfs.cpp
index 094e5c0..f69c530 100644
--- a/zimwriterfs/zimwriterfs.cpp
+++ b/zimwriterfs/zimwriterfs.cpp
@@ -404,6 +404,8 @@
 #if HAVE_XAPIAN
   delete xapianIndexer;
 #endif
+
+  magic_close(magic);
   /* Destroy mutex */
   pthread_mutex_destroy();
   pthread_mutex_destroy();

-- 
To view, visit https://gerrit.wikimedia.org/r/303777
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib0c7d1736d804526eea701ef39cb9ae5780b13c1
Gerrit-PatchSet: 1
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: Mgautierfr 
Gerrit-Reviewer: Kelson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: Avoid get the dirent too many time.

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/314717 )

Change subject: Avoid get the dirent too many time.
..


Avoid get the dirent too many time.

Article::is* functions are "alias" to Article::getDirent().is* functions.
As we already get the dirent just before, directly use the functions on
the dirent, not the article.
This way, we avoid calls to getDirent().

Change-Id: Ida3531c540b4848ee7028fee420eefa68aea3d40
---
M zimlib/include/zim/article.h
1 file changed, 8 insertions(+), 8 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimlib/include/zim/article.h b/zimlib/include/zim/article.h
index b950173..f2ece1e 100644
--- a/zimlib/include/zim/article.h
+++ b/zimlib/include/zim/article.h
@@ -79,19 +79,19 @@
   Blob getData() const
   {
 Dirent dirent = getDirent();
-return isRedirect()
-|| isLinktarget()
-|| isDeleted() ? Blob()
-   : 
const_cast(file).getBlob(dirent.getClusterNumber(), 
dirent.getBlobNumber());
+return dirent.isRedirect()
+|| dirent.isLinktarget()
+|| dirent.isDeleted() ? Blob()
+  : 
const_cast(file).getBlob(dirent.getClusterNumber(), 
dirent.getBlobNumber());
   }
 
   offset_type getOffset() const
   {
 Dirent dirent = getDirent();
-return isRedirect()
-|| isLinktarget()
-|| isDeleted() ? 0
-   : 
const_cast(file).getOffset(dirent.getClusterNumber(), 
dirent.getBlobNumber());
+return dirent.isRedirect()
+|| dirent.isLinktarget()
+|| dirent.isDeleted() ? 0
+  : 
const_cast(file).getOffset(dirent.getClusterNumber(), 
dirent.getBlobNumber());
   }
 
   std::string getPage(bool layout = true, unsigned maxRecurse = 10);

-- 
To view, visit https://gerrit.wikimedia.org/r/314717
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ida3531c540b4848ee7028fee420eefa68aea3d40
Gerrit-PatchSet: 1
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: Mgautierfr 
Gerrit-Reviewer: Kelson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: Read the cluster content only when necessary.

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/314718 )

Change subject: Read the cluster content only when necessary.
..


Read the cluster content only when necessary.

Instead of reading the full cluster content at cluster creation, it is
better to read the cluster content when we need it.
This is mainly useful when we want a cluster to only get an article
offset.
For compressed cluster we read all in once cause :
- We create a proxy uncompressor stream from the input stream.
  This proxy stream do not handle teelg who is necessary for lazy_read.
- This change is only useful when we use getOffset, and there is no
  offset available on comressed cluster.

We do not use the operator>> anymore.
This operator is designed to allow chained reads. ie :
in >> cluster1 >> cluster2;

As may do not read all the content when reading from in, the use of the
operator>> is now not desirable.

Change-Id: I0709eb6b8fe49512ee302d13dfd5641cdc1c676b
---
M zimlib/include/zim/cluster.h
M zimlib/src/cluster.cpp
M zimlib/src/file.cpp
M zimlib/src/fileimpl.cpp
4 files changed, 87 insertions(+), 46 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimlib/include/zim/cluster.h b/zimlib/include/zim/cluster.h
index 96b16f0..4fd3971 100644
--- a/zimlib/include/zim/cluster.h
+++ b/zimlib/include/zim/cluster.h
@@ -23,6 +23,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 
@@ -33,7 +34,6 @@
 
   class ClusterImpl : public RefCounted
   {
-  friend std::istream& operator>> (std::istream& in, ClusterImpl& 
blobImpl);
   friend std::ostream& operator<< (std::ostream& out, const ClusterImpl& 
blobImpl);
 
   typedef std::vector Offsets;
@@ -41,11 +41,28 @@
 
   CompressionType compression;
   Offsets offsets;
-  Data data;
+  Data _data;
   offset_type startOffset;
 
-  void read(std::istream& in);
+  ifstream* lazy_read_stream;
+
+  offset_type read_header(std::istream& in);
+  void read_content(std::istream& in);
   void write(std::ostream& out) const;
+
+  void set_lazy_read(ifstream* in) {
+lazy_read_stream = in;
+  }
+
+  bool is_fully_initialised() const { return lazy_read_stream == 0; }
+  void finalise_read();
+  const Data& data() const {
+if ( !is_fully_initialised() )
+{
+   const_cast(this)->finalise_read();
+}
+return _data;
+  }
 
 public:
   ClusterImpl();
@@ -55,20 +72,21 @@
   bool isCompressed() const{ return compression == 
zimcompZip || compression == zimcompBzip2 || compression == zimcompLzma; }
 
   size_type getCount() const   { return offsets.size() - 1; }
-  const char* getData(unsigned n) const{ return [ offsets[n] ]; }
+  const char* getData(unsigned n) const{ return ()[ offsets[n] ]; 
}
   size_type getSize(unsigned n) const  { return offsets[n+1] - 
offsets[n]; }
-  size_type getSize() const{ return offsets.size() * 
sizeof(size_type) + data.size(); }
+  size_type getSize() const{ return offsets.size() * 
sizeof(size_type) + data().size(); }
   offset_type getOffset(size_type n) const { return startOffset + 
offsets[n]; }
   Blob getBlob(size_type n) const;
   void clear();
 
   void addBlob(const Blob& blob);
   void addBlob(const char* data, unsigned size);
+
+  void init_from_stream(ifstream& in, offset_type offset);
   };
 
   class Cluster
   {
-  friend std::istream& operator>> (std::istream& in, Cluster& blob);
   friend std::ostream& operator<< (std::ostream& out, const Cluster& blob);
 
   SmartPtr impl;
@@ -98,10 +116,10 @@
   void addBlob(const Blob& blob){ 
getImpl()->addBlob(blob); }
 
   operator bool() const   { return impl; }
+
+  void init_from_stream(ifstream& in, offset_type offset);
   };
 
-  std::istream& operator>> (std::istream& in, ClusterImpl& blobImpl);
-  std::istream& operator>> (std::istream& in, Cluster& blob);
   std::ostream& operator<< (std::ostream& out, const ClusterImpl& blobImpl);
   std::ostream& operator<< (std::ostream& out, const Cluster& blob);
 
diff --git a/zimlib/src/cluster.cpp b/zimlib/src/cluster.cpp
index 3b24fee..9dbefdc 100644
--- a/zimlib/src/cluster.cpp
+++ b/zimlib/src/cluster.cpp
@@ -20,6 +20,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 
@@ -60,34 +61,35 @@
   }
 
   ClusterImpl::ClusterImpl()
-: compression(zimcompNone)
+: compression(zimcompNone),
+  startOffset(0),
+  lazy_read_stream(NULL)
   {
 offsets.push_back(0);
   }
 
-  void ClusterImpl::read(std::istream& in)
+  /* This return the number of char read */
+  offset_type ClusterImpl::read_header(std::istream& in)
   {
-log_debug1("read");
-
+log_debug1("read_header");
 

[MediaWiki-commits] [Gerrit] openzim[master]: Invalidate internal streambuf buffer when we change it.

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/314720 )

Change subject: Invalidate internal streambuf buffer when we change it.
..


Invalidate internal streambuf buffer when we change it.

It may be not necessary as it never fails before, but let's be cautious.

Change-Id: Ie54f95e08e2683c43ef7b0fdc70bd9f74fb1fbe9
---
M zimlib/include/zim/fstream.h
M zimlib/src/fstream.cpp
2 files changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimlib/include/zim/fstream.h b/zimlib/include/zim/fstream.h
index 970920e..4b99814 100644
--- a/zimlib/include/zim/fstream.h
+++ b/zimlib/include/zim/fstream.h
@@ -75,7 +75,7 @@
 
   void seekg(zim::offset_type off);
   void setBufsize(unsigned s)
-  { buffer.resize(s); }
+  { buffer.resize(s); setg(0, 0, 0);}
   zim::offset_type fsize() const;
   time_t getMTime() const;
   };
diff --git a/zimlib/src/fstream.cpp b/zimlib/src/fstream.cpp
index b925fc5..ef91b57 100644
--- a/zimlib/src/fstream.cpp
+++ b/zimlib/src/fstream.cpp
@@ -258,6 +258,7 @@
   throw std::runtime_error(msg.str());
 }
   }
+  setg(0, 0, 0);
 }
 
 void streambuf::seekg(zim::offset_type off)

-- 
To view, visit https://gerrit.wikimedia.org/r/314720
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie54f95e08e2683c43ef7b0fdc70bd9f74fb1fbe9
Gerrit-PatchSet: 2
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: Mgautierfr 
Gerrit-Reviewer: Kelson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: [zimwriterfs] Try to avoid too big cluster.

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/315238 )

Change subject: [zimwriterfs] Try to avoid too big cluster.
..


[zimwriterfs] Try to avoid too big cluster.

We check that cluster will not be too big *before* adding the content.
This way, cluster are always closed before the maximum size and not
just after.

The only way a cluster can be too big is if the content of a sole article
is bigger than the maximum size.

Change-Id: I77a581df46ae87e01a3fe2689570a7c7355d1877
---
M zimlib/src/zimcreator.cpp
1 file changed, 9 insertions(+), 5 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimlib/src/zimcreator.cpp b/zimlib/src/zimcreator.cpp
index 0f0f6d0..1e4a21c 100644
--- a/zimlib/src/zimcreator.cpp
+++ b/zimlib/src/zimcreator.cpp
@@ -222,12 +222,12 @@
   myDirents = 
   otherDirents = 
 }
-dirents.back().setCluster(clusterOffsets.size(), cluster->count());
-cluster->addBlob(blob);
-myDirents->push_back(dirents.size()-1);
 
-// If cluster is now large enough, write it to disk.
-if (cluster->size() >= minChunkSize * 1024)
+// If cluster will be too large, write it to dis, and open a new
+// one for the content.
+if ( cluster->count()
+  && cluster->size()+blob.size() >= minChunkSize * 1024
+   )
 {
   log_info("cluster with " << cluster->count() << " articles, " <<
cluster->size() << " bytes; current title \"" <<
@@ -249,6 +249,10 @@
   currentSize += (end - start) +
 sizeof(offset_type) /* for cluster pointer entry */;
 }
+
+dirents.back().setCluster(clusterOffsets.size(), cluster->count());
+cluster->addBlob(blob);
+myDirents->push_back(dirents.size()-1);
   }
 
   // When we've seen all articles, write any remaining clusters.

-- 
To view, visit https://gerrit.wikimedia.org/r/315238
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I77a581df46ae87e01a3fe2689570a7c7355d1877
Gerrit-PatchSet: 1
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: Mgautierfr 
Gerrit-Reviewer: Kelson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: Do not store the snippet nor the size of the content in the ...

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/343897 )

Change subject: Do not store the snippet nor the size of the content in the 
database.
..


Do not store the snippet nor the size of the content in the database.

Change-Id: I354a1e76dd2214e844d67ddb4b94f43087664729
---
M zimwriterfs/indexer.cpp
M zimwriterfs/indexer.h
M zimwriterfs/xapianIndexer.cpp
M zimwriterfs/xapianIndexer.h
4 files changed, 2 insertions(+), 28 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimwriterfs/indexer.cpp b/zimwriterfs/indexer.cpp
index 6c26fc9..b83abd4 100644
--- a/zimwriterfs/indexer.cpp
+++ b/zimwriterfs/indexer.cpp
@@ -84,8 +84,6 @@
  token.title,
  token.keywords,
  token.content,
- token.snippet,
- token.size,
  token.wordCount
  );
 
diff --git a/zimwriterfs/indexer.h b/zimwriterfs/indexer.h
index 02d989b..3291e36 100644
--- a/zimwriterfs/indexer.h
+++ b/zimwriterfs/indexer.h
@@ -46,8 +46,6 @@
 string title;
 string keywords;
 string content;
-string snippet;
-string size;
 string wordCount;
 };
 
@@ -70,8 +68,6 @@
   const string ,
   const string ,
   const string ,
-  const string ,
-  const string ,
   const string ) = 0;
 virtual void flush() = 0;
 virtual void indexingPostlude() = 0;
diff --git a/zimwriterfs/xapianIndexer.cpp b/zimwriterfs/xapianIndexer.cpp
index 65129b7..db27f9d 100644
--- a/zimwriterfs/xapianIndexer.cpp
+++ b/zimwriterfs/xapianIndexer.cpp
@@ -52,7 +52,7 @@
 void XapianIndexer::indexingPrelude(const string indexPath_) {
 indexPath = indexPath_;
 this->writableDatabase = Xapian::WritableDatabase(indexPath + ".tmp", 
Xapian::DB_CREATE_OR_OVERWRITE);
-this->writableDatabase.set_metadata("valuesmap", 
"title:0;snippet:1;size:2;wordcount:3");
+this->writableDatabase.set_metadata("valuesmap", "title:0;wordcount:1");
 this->writableDatabase.begin_transaction(true);
 
 /* Insert the stopwords */
@@ -72,17 +72,13 @@
   const string ,
   const string ,
   const string ,
-  const string ,
-  const string ,
   const string ) {
 
 /* Put the data in the document */
 Xapian::Document currentDocument;
 currentDocument.clear_values();
 currentDocument.add_value(0, title);
-currentDocument.add_value(1, snippet);
-currentDocument.add_value(2, size);
-currentDocument.add_value(3, wordCount);
+currentDocument.add_value(1, wordCount);
 currentDocument.set_data(url);
 indexer.set_document(currentDocument);
 
@@ -149,20 +145,6 @@
stringstream countWordStringStream;
countWordStringStream << countWords(htmlParser.dump);
token.wordCount = countWordStringStream.str();
-
-   /* snippet */
-   std::string snippet = std::string(htmlParser.dump, 0, 300);
-   std::string::size_type last = snippet.find_last_of('.');
-   if (last == snippet.npos)
- last = snippet.find_last_of(' ');
-   if (last != snippet.npos)
- snippet = snippet.substr(0, last);
-   token.snippet = snippet;
-
-   /* size */
-   stringstream sizeStringStream;
-   sizeStringStream << token.content.size() / 1024;
-   token.size = sizeStringStream.str();
 
/* Remove accent */
token.title = removeAccents(token.accentedTitle);
diff --git a/zimwriterfs/xapianIndexer.h b/zimwriterfs/xapianIndexer.h
index 1d854da..16dc094 100644
--- a/zimwriterfs/xapianIndexer.h
+++ b/zimwriterfs/xapianIndexer.h
@@ -61,8 +61,6 @@
const string ,
const string ,
const string ,
-   const string ,
-   const string ,
const string );
 void flush();
 void indexingPostlude();

-- 
To view, visit https://gerrit.wikimedia.org/r/343897
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I354a1e76dd2214e844d67ddb4b94f43087664729
Gerrit-PatchSet: 1
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: Mgautierfr 
Gerrit-Reviewer: Kelson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: Make zimlib compilable with meson.

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/328341 )

Change subject: Make zimlib compilable with meson.
..


Make zimlib compilable with meson.

Also install a correct pkg-config file who correctly declare dependencies
of zimlib.

Change-Id: I6b2e1bb0797cdc0afbf8c986dd91bfac757242d0
---
M zimlib/.gitignore
A zimlib/include/meson.build
A zimlib/meson.build
A zimlib/meson_options.txt
A zimlib/src/config.h.in
A zimlib/src/meson.build
6 files changed, 168 insertions(+), 1 deletion(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimlib/.gitignore b/zimlib/.gitignore
index 550c09a..3563fa8 100644
--- a/zimlib/.gitignore
+++ b/zimlib/.gitignore
@@ -2,7 +2,7 @@
 *#*
 autom4te.cache
 compile
-config.*
+config.h
 configure
 depcomp
 .deps
diff --git a/zimlib/include/meson.build b/zimlib/include/meson.build
new file mode 100644
index 000..0caa2e8
--- /dev/null
+++ b/zimlib/include/meson.build
@@ -0,0 +1,34 @@
+install_headers(
+'zim/article.h',
+'zim/articlesearch.h',
+'zim/blob.h',
+'zim/cache.h',
+'zim/cluster.h',
+'zim/dirent.h',
+'zim/endian.h',
+'zim/error.h',
+'zim/file.h',
+'zim/fileheader.h',
+'zim/fileimpl.h',
+'zim/fileiterator.h',
+'zim/fstream.h',
+'zim/indexarticle.h',
+'zim/noncopyable.h',
+'zim/search.h',
+'zim/smartptr.h',
+'zim/refcounted.h',
+'zim/template.h',
+'zim/unicode.h',
+'zim/uuid.h',
+'zim/zim.h',
+'zim/zintstream.h',
+subdir:'zim'
+)
+
+install_headers(
+'zim/writer/articlesource.h',
+'zim/writer/dirent.h',
+'zim/writer/zimcreator.h',
+subdir:'zim/writer'
+)
+
diff --git a/zimlib/meson.build b/zimlib/meson.build
new file mode 100644
index 000..0eed3c4
--- /dev/null
+++ b/zimlib/meson.build
@@ -0,0 +1,44 @@
+project('libzim', ['c', 'cpp'],
+  version : '1.4',
+  license : 'GPL2')
+
+abi_current=2
+abi_revision=0
+abi_age=0
+  
+conf = configuration_data()
+conf.set('VERSION', '"@0@"'.format(meson.project_version()))
+conf.set('DIRENT_CACHE_SIZE', get_option('DIRENT_CACHE_SIZE'))
+conf.set('CLUSTER_CACHE_SIZE', get_option('CLUSTER_CACHE_SIZE'))
+conf.set('LZMA_MEMORY_SIZE', get_option('LZMA_MEMORY_SIZE'))
+
+zlib_dep = dependency('zlib', required:false)
+conf.set('ENABLE_ZLIB', zlib_dep.found())
+lzma_dep = dependency('liblzma', required:false)
+conf.set('ENABLE_LZMA', lzma_dep.found())
+bzip2_dep = dependency('bzip2', required:false)
+conf.set('ENABLE_BZIP2', bzip2_dep.found())
+
+pkg_requires = []
+if zlib_dep.found()
+pkg_requires += ['zlib']
+endif
+if lzma_dep.found()
+pkg_requires += ['liblzma']
+endif
+if bzip2_dep.found()
+pkg_requires += ['bzip2']
+endif
+
+inc = include_directories('include')
+
+subdir('include')
+subdir('src')
+
+pkg_mod = import('pkgconfig')
+pkg_mod.generate(libraries : libzim,
+ version : meson.project_version(),
+ name : 'libzim',
+ filebase : 'libzim',
+ description : 'A Library to zim.',
+ requires : pkg_requires)
diff --git a/zimlib/meson_options.txt b/zimlib/meson_options.txt
new file mode 100644
index 000..108edf9
--- /dev/null
+++ b/zimlib/meson_options.txt
@@ -0,0 +1,6 @@
+option('CLUSTER_CACHE_SIZE', type : 'string', value : '16',
+  description : 'set cluster cache size to number (default:16)')
+option('DIRENT_CACHE_SIZE', type : 'string', value : '512',
+  description : 'set dirent cache size to number (default:512)')
+option('LZMA_MEMORY_SIZE', type : 'string', value : '128',
+  description : 'set lzma uncompress memory in MB (default:128)')
\ No newline at end of file
diff --git a/zimlib/src/config.h.in b/zimlib/src/config.h.in
new file mode 100644
index 000..d9e4b7d
--- /dev/null
+++ b/zimlib/src/config.h.in
@@ -0,0 +1,14 @@
+
+#mesondefine VERSION
+
+#mesondefine DIRENT_CACHE_SIZE
+
+#mesondefine CLUSTER_CACHE_SIZE
+
+#mesondefine LZMA_MEMORY_SIZE
+
+#mesondefine ENABLE_ZLIB
+
+#mesondefine ENABLE_LZMA
+
+#mesondefine ENABLE_BZIP2
diff --git a/zimlib/src/meson.build b/zimlib/src/meson.build
new file mode 100644
index 000..ec550f4
--- /dev/null
+++ b/zimlib/src/meson.build
@@ -0,0 +1,69 @@
+
+configure_file(output : 'config.h',
+   configuration : conf,
+   input : 'config.h.in')
+
+common_sources = [
+#'config.h',
+'article.cpp',
+'articlesearch.cpp',
+'articlesource.cpp',
+'cluster.cpp',
+'dirent.cpp',
+'envvalue.cpp',
+'file.cpp',
+'fileheader.cpp',
+'fileimpl.cpp',
+'fstream.cpp',
+'indexarticle.cpp',
+'md5.c',
+'md5stream.cpp',
+'ptrstream.cpp',
+'search.cpp',
+'tee.cpp',
+'template.cpp',
+'unicode.cpp',
+'uuid.cpp',
+'zimcreator.cpp',
+'zintstream.cpp'
+]
+
+zlib_sources = [
+'deflatestream.cpp',
+'inflatestream.cpp'
+]
+
+bzip2_sources = [
+

[MediaWiki-commits] [Gerrit] openzim[master]: Do not cache uncompressed cluster by default.

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/315237 )

Change subject: Do not cache uncompressed cluster by default.
..


Do not cache uncompressed cluster by default.

Uncompressed cluster can be big (if they contain videos for example).
We should not cache them by default before having a cache system who
limits itself in memory used.

Change-Id: If307af3f91a614b943fa408b2bf30e2016ebfe81
---
M zimlib/include/zim/fileimpl.h
M zimlib/src/fileimpl.cpp
2 files changed, 10 insertions(+), 3 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimlib/include/zim/fileimpl.h b/zimlib/include/zim/fileimpl.h
index 1cf584d..ddf7bc1 100644
--- a/zimlib/include/zim/fileimpl.h
+++ b/zimlib/include/zim/fileimpl.h
@@ -41,6 +41,7 @@
 
   Cache direntCache;
   Cache clusterCache;
+  bool cacheUncompressedCluster;
   typedef std::map NamespaceCache;
   NamespaceCache namespaceBeginCache;
   NamespaceCache namespaceEndCache;
diff --git a/zimlib/src/fileimpl.cpp b/zimlib/src/fileimpl.cpp
index 2aa9e1f..a1b4eee 100644
--- a/zimlib/src/fileimpl.cpp
+++ b/zimlib/src/fileimpl.cpp
@@ -41,7 +41,8 @@
   FileImpl::FileImpl(const char* fname)
 : zimFile(fname),
   direntCache(envValue("ZIM_DIRENTCACHE", DIRENT_CACHE_SIZE)),
-  clusterCache(envValue("ZIM_CLUSTERCACHE", CLUSTER_CACHE_SIZE))
+  clusterCache(envValue("ZIM_CLUSTERCACHE", CLUSTER_CACHE_SIZE)),
+  cacheUncompressedCluster(envValue("ZIM_CACHEUNCOMPRESSEDCLUSTER", false))
   {
 log_trace("read file \"" << fname << '"');
 
@@ -181,8 +182,13 @@
 if (zimFile.fail())
   throw ZimFileFormatError("error reading cluster data");
 
-log_debug("put cluster " << idx << " into cluster cache; hits " << 
clusterCache.getHits() << " misses " << clusterCache.getMisses() << " ratio " 
<< clusterCache.hitRatio() * 100 << "% fillfactor " << 
clusterCache.fillfactor());
-clusterCache.put(idx, cluster);
+if (cacheUncompressedCluster || cluster.isCompressed())
+{
+  log_debug("put cluster " << idx << " into cluster cache; hits " << 
clusterCache.getHits() << " misses " << clusterCache.getMisses() << " ratio " 
<< clusterCache.hitRatio() * 100 << "% fillfactor " << 
clusterCache.fillfactor());
+  clusterCache.put(idx, cluster);
+}
+else
+  log_debug("cluster " << idx << " is not compressed - do not cache");
 
 return cluster;
   }

-- 
To view, visit https://gerrit.wikimedia.org/r/315237
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If307af3f91a614b943fa408b2bf30e2016ebfe81
Gerrit-PatchSet: 1
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: Mgautierfr 
Gerrit-Reviewer: Kelson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: Adapt tests to new internal cluster API.

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/320243 )

Change subject: Adapt tests to new internal cluster API.
..


Adapt tests to new internal cluster API.

- There is no more operator>>() on cluster. We should use init_from_stream.
- The stream must be a zim::ifstream not a std::istream.

Change-Id: I58b8e1d43b0973129d02393b83c3f248b77768fd
---
M zimlib/test/cluster.cpp
1 file changed, 48 insertions(+), 20 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimlib/test/cluster.cpp b/zimlib/test/cluster.cpp
index c4c25e6..687c1e1 100644
--- a/zimlib/test/cluster.cpp
+++ b/zimlib/test/cluster.cpp
@@ -18,9 +18,12 @@
  */
 
 #include 
+#include 
 #include 
 #include 
+#include 
 #include 
+#include 
 
 #include 
 #include 
@@ -69,7 +72,9 @@
 
 void ReadWriteCluster()
 {
-  std::stringstream s;
+  std::string name = std::tmpnam(NULL);
+  std::ofstream os;
+  os.open(name.c_str());
 
   zim::Cluster cluster;
 
@@ -81,20 +86,25 @@
   cluster.addBlob(blob1.data(), blob1.size());
   cluster.addBlob(blob2.data(), blob2.size());
 
-  s << cluster;
+  os << cluster;
+  os.close();
 
+  zim::ifstream is(name);
   zim::Cluster cluster2;
-  s >> cluster2;
-  CXXTOOLS_UNIT_ASSERT(!s.fail());
+  cluster2.init_from_stream(is, 0);
+  CXXTOOLS_UNIT_ASSERT(!is.fail());
   CXXTOOLS_UNIT_ASSERT_EQUALS(cluster2.count(), 3);
   CXXTOOLS_UNIT_ASSERT_EQUALS(cluster2.getBlobSize(0), blob0.size());
   CXXTOOLS_UNIT_ASSERT_EQUALS(cluster2.getBlobSize(1), blob1.size());
   CXXTOOLS_UNIT_ASSERT_EQUALS(cluster2.getBlobSize(2), blob2.size());
+  std::remove(name.c_str());
 }
 
 void ReadWriteEmpty()
 {
-  std::stringstream s;
+  std::string name = std::tmpnam(NULL);
+  std::ofstream os;
+  os.open(name.c_str());
 
   zim::Cluster cluster;
 
@@ -102,21 +112,26 @@
   cluster.addBlob(0, 0);
   cluster.addBlob(0, 0);
 
-  s << cluster;
+  os << cluster;
+  os.close();
 
+  zim::ifstream is(name);
   zim::Cluster cluster2;
-  s >> cluster2;
-  CXXTOOLS_UNIT_ASSERT(!s.fail());
+  cluster2.init_from_stream(is, 0);
+  CXXTOOLS_UNIT_ASSERT(!is.fail());
   CXXTOOLS_UNIT_ASSERT_EQUALS(cluster2.count(), 3);
   CXXTOOLS_UNIT_ASSERT_EQUALS(cluster2.getBlobSize(0), 0);
   CXXTOOLS_UNIT_ASSERT_EQUALS(cluster2.getBlobSize(1), 0);
   CXXTOOLS_UNIT_ASSERT_EQUALS(cluster2.getBlobSize(2), 0);
+  std::remove(name.c_str());
 }
 
 #ifdef ENABLE_ZLIB
 void ReadWriteClusterZ()
 {
-  std::stringstream s;
+  std::string name = std::tmpnam(NULL);
+  std::ofstream os;
+  os.open(name.c_str());
 
   zim::Cluster cluster;
 
@@ -129,11 +144,13 @@
   cluster.addBlob(blob2.data(), blob2.size());
   cluster.setCompression(zim::zimcompZip);
 
-  s << cluster;
+  os << cluster;
+  os.close();
 
+  zim::ifstream is(name);
   zim::Cluster cluster2;
-  s >> cluster2;
-  CXXTOOLS_UNIT_ASSERT(!s.fail());
+  cluster2.init_from_stream(is, 0);
+  CXXTOOLS_UNIT_ASSERT(!is.fail());
   CXXTOOLS_UNIT_ASSERT_EQUALS(cluster2.count(), 3);
   CXXTOOLS_UNIT_ASSERT_EQUALS(cluster2.getCompression(), zim::zimcompZip);
   CXXTOOLS_UNIT_ASSERT_EQUALS(cluster2.getBlobSize(0), blob0.size());
@@ -142,6 +159,7 @@
   CXXTOOLS_UNIT_ASSERT(std::equal(cluster2.getBlobPtr(0), 
cluster2.getBlobPtr(0) + cluster2.getBlobSize(0), blob0.data()));
   CXXTOOLS_UNIT_ASSERT(std::equal(cluster2.getBlobPtr(1), 
cluster2.getBlobPtr(1) + cluster2.getBlobSize(1), blob1.data()));
   CXXTOOLS_UNIT_ASSERT(std::equal(cluster2.getBlobPtr(2), 
cluster2.getBlobPtr(2) + cluster2.getBlobSize(2), blob2.data()));
+  std::remove(name.c_str());
 }
 
 #endif
@@ -149,7 +167,9 @@
 #ifdef ENABLE_BZIP2
 void ReadWriteClusterBz2()
 {
-  std::stringstream s;
+  std::string name = std::tmpnam(NULL);
+  std::ofstream os;
+  os.open(name.c_str());
 
   zim::Cluster cluster;
 
@@ -162,11 +182,13 @@
   cluster.addBlob(blob2.data(), blob2.size());
   cluster.setCompression(zim::zimcompBzip2);
 
-  s << cluster;
+  os << cluster;
+  os.close();
 
+  zim::ifstream is(name);
   zim::Cluster cluster2;
-  s >> cluster2;
-  CXXTOOLS_UNIT_ASSERT(!s.fail());
+  cluster2.init_from_stream(is, 0);
+  CXXTOOLS_UNIT_ASSERT(!is.fail());
   CXXTOOLS_UNIT_ASSERT_EQUALS(cluster2.count(), 3);
   CXXTOOLS_UNIT_ASSERT_EQUALS(cluster2.getCompression(), 
zim::zimcompBzip2);
   CXXTOOLS_UNIT_ASSERT_EQUALS(cluster2.getBlobSize(0), blob0.size());
@@ -175,6 +197,7 @@
   CXXTOOLS_UNIT_ASSERT(std::equal(cluster2.getBlobPtr(0), 
cluster2.getBlobPtr(0) + cluster2.getBlobSize(0), blob0.data()));
   

[MediaWiki-commits] [Gerrit] openzim[refs/meta/config]: Modify access rules

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/344794 )

Change subject: Modify access rules
..


Modify access rules

Change-Id: Ifb79d6cb21c10144d5cce325136a3f68257b2ec9
---
M project.config
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/project.config b/project.config
index 8effac7..7e7ca50 100644
--- a/project.config
+++ b/project.config
@@ -5,6 +5,7 @@
 [access "refs/*"]
owner = group openzim
create = group openzim
+   forgeCommitter = group openzim
forgeCommitter = group platform-engineering
push = group openzim
pushMerge = group openzim

-- 
To view, visit https://gerrit.wikimedia.org/r/344794
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb79d6cb21c10144d5cce325136a3f68257b2ec9
Gerrit-PatchSet: 1
Gerrit-Project: openzim
Gerrit-Branch: refs/meta/config
Gerrit-Owner: Paladox 
Gerrit-Reviewer: Kelson 
Gerrit-Reviewer: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: Few clean and better verbose message.

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/343898 )

Change subject: Few clean and better verbose message.
..


Few clean and better verbose message.

Change-Id: Id4675f70422ecef42198ca33fe82bc1f33866548
---
M zimwriterfs/indexer.cpp
M zimwriterfs/indexer.h
2 files changed, 4 insertions(+), 8 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimwriterfs/indexer.cpp b/zimwriterfs/indexer.cpp
index b83abd4..33989f4 100644
--- a/zimwriterfs/indexer.cpp
+++ b/zimwriterfs/indexer.cpp
@@ -89,6 +89,10 @@
 
   indexedArticleCount += 1;
 
+  if ( (indexedArticleCount % 1000 == 0) && self->getVerboseFlag()) {
+  std::cout << indexedArticleCount << " articled indexed." <flush();
@@ -137,10 +141,6 @@
   bool Indexer::popFromToIndexQueue(indexerToken ) {
 while (this->isToIndexQueueEmpty()) {
   usleep(500);
-  if (this->getVerboseFlag()) {
-   std::cout << "Waiting... ToIndexQueue is empty for now..." << std::endl;
-  }
-
   pthread_testcancel();
 }
 
diff --git a/zimwriterfs/indexer.h b/zimwriterfs/indexer.h
index 3291e36..686d156 100644
--- a/zimwriterfs/indexer.h
+++ b/zimwriterfs/indexer.h
@@ -29,14 +29,10 @@
 #include 
 
 #include 
-/*#include 
-#include 
-#include */
 #include 
 #include 
 #include 
 #include 
-/*#include "reader.h"*/
 
 using namespace std;
 

-- 
To view, visit https://gerrit.wikimedia.org/r/343898
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id4675f70422ecef42198ca33fe82bc1f33866548
Gerrit-PatchSet: 1
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: Mgautierfr 
Gerrit-Reviewer: Kelson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: Fix use of ENABLE_* by preprocessor.

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/330236 )

Change subject: Fix use of ENABLE_* by preprocessor.
..


Fix use of ENABLE_* by preprocessor.

If a compression lib is not present, the associated ENABLE_* is not
defined.
So we need to always test for the definition existance and not for its
value.
This is not the case in zimcreator.cpp with the #ifdef/#elif construction.

We also change other (correct) syntax #ifdef to #if defined() to keep some
consistency.

Change-Id: I86d4309bfcdeeb3356d0fb4f192d0849a5e57275
---
M zimlib/src/cluster.cpp
M zimlib/src/zimcreator.cpp
M zimlib/test/cluster.cpp
3 files changed, 24 insertions(+), 24 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimlib/src/cluster.cpp b/zimlib/src/cluster.cpp
index 9dbefdc..e944ec6 100644
--- a/zimlib/src/cluster.cpp
+++ b/zimlib/src/cluster.cpp
@@ -28,17 +28,17 @@
 
 #include "config.h"
 
-#ifdef ENABLE_ZLIB
+#if defined(ENABLE_ZLIB)
 #include 
 #include 
 #endif
 
-#ifdef ENABLE_BZIP2
+#if defined(ENABLE_BZIP2)
 #include 
 #include 
 #endif
 
-#ifdef ENABLE_LZMA
+#if defined(ENABLE_LZMA)
 #include 
 #include 
 #endif
@@ -212,7 +212,7 @@
 
   case zimcompZip:
 {
-#ifdef ENABLE_ZLIB
+#if defined(ENABLE_ZLIB)
   log_debug("uncompress data (zlib)");
   zim::InflateStream is(in);
   is.exceptions(std::ios::failbit | std::ios::badbit);
@@ -226,7 +226,7 @@
 
   case zimcompBzip2:
 {
-#ifdef ENABLE_BZIP2
+#if defined(ENABLE_BZIP2)
   log_debug("uncompress data (bzip2)");
   zim::Bunzip2Stream is(in);
   is.exceptions(std::ios::failbit | std::ios::badbit);
@@ -240,7 +240,7 @@
 
   case zimcompLzma:
 {
-#ifdef ENABLE_LZMA
+#if defined(ENABLE_LZMA)
   log_debug("uncompress data (lzma)");
   zim::UnlzmaStream is(in);
   is.exceptions(std::ios::failbit | std::ios::badbit);
@@ -274,7 +274,7 @@
 
   case zimcompZip:
 {
-#ifdef ENABLE_ZLIB
+#if defined(ENABLE_ZLIB)
   log_debug("compress data (zlib)");
   zim::DeflateStream os(out);
   os.exceptions(std::ios::failbit | std::ios::badbit);
@@ -288,7 +288,7 @@
 
   case zimcompBzip2:
 {
-#ifdef ENABLE_BZIP2
+#if defined(ENABLE_BZIP2)
   log_debug("compress data (bzip2)");
   zim::Bzip2Stream os(out);
   os.exceptions(std::ios::failbit | std::ios::badbit);
@@ -302,7 +302,7 @@
 
   case zimcompLzma:
 {
-#ifdef ENABLE_LZMA
+#if defined(ENABLE_LZMA)
   uint32_t lzmaPreset = 3 | LZMA_PRESET_EXTREME;
   /**
* read lzma preset from environment
diff --git a/zimlib/src/zimcreator.cpp b/zimlib/src/zimcreator.cpp
index 1e4a21c..fac4c96 100644
--- a/zimlib/src/zimcreator.cpp
+++ b/zimlib/src/zimcreator.cpp
@@ -55,11 +55,11 @@
 ZimCreator::ZimCreator()
   : minChunkSize(1024-64),
 nextMimeIdx(0),
-#ifdef ENABLE_LZMA
+#if defined(ENABLE_LZMA)
 compression(zimcompLzma),
-#elif ENABLE_BZIP2
+#elif defined(ENABLE_BZIP2)
 compression(zimcompBzip2),
-#elif ENABLE_ZLIB
+#elif defined(ENABLE_ZLIB)
 compression(zimcompZip),
 #else
 compression(zimcompNone),
@@ -70,11 +70,11 @@
 
 ZimCreator::ZimCreator(int& argc, char* argv[])
   : nextMimeIdx(0),
-#ifdef ENABLE_LZMA
+#if defined(ENABLE_LZMA)
 compression(zimcompLzma),
-#elif ENABLE_BZIP2
+#elif defined(ENABLE_BZIP2)
 compression(zimcompBzip2),
-#elif ENABLE_ZLIB
+#elif defined( ENABLE_ZLIB)
 compression(zimcompZip),
 #else
 compression(zimcompNone),
@@ -87,15 +87,15 @@
   else
 minChunkSize = Arg(argc, argv, 's', 1024-64);
 
-#ifdef ENABLE_ZLIB
+#if defined(ENABLE_ZLIB)
   if (Arg(argc, argv, "--zlib"))
 compression = zimcompZip;
 #endif
-#ifdef ENABLE_BZIP2
+#if defined(ENABLE_BZIP2)
   if (Arg(argc, argv, "--bzip2"))
 compression = zimcompBzip2;
 #endif
-#ifdef ENABLE_LZMA
+#if defined(ENABLE_LZMA)
   if (Arg(argc, argv, "--lzma"))
 compression = zimcompLzma;
 #endif
diff --git a/zimlib/test/cluster.cpp b/zimlib/test/cluster.cpp
index 687c1e1..b907bad 100644
--- a/zimlib/test/cluster.cpp
+++ b/zimlib/test/cluster.cpp
@@ -39,13 +39,13 @@
   registerMethod("CreateCluster", *this, ::CreateCluster);
   registerMethod("ReadWriteCluster", *this, 
::ReadWriteCluster);
   registerMethod("ReadWriteEmpty", *this, ::ReadWriteEmpty);
-#ifdef ENABLE_ZLIB
+#if defined(ENABLE_ZLIB)
   registerMethod("ReadWriteClusterZ", *this, 
::ReadWriteClusterZ);
 #endif
-#ifdef ENABLE_BZIP2
+#if defined(ENABLE_BZIP2)
   registerMethod("ReadWriteClusterBz2", *this, 
::ReadWriteClusterBz2);
 #endif
-#ifdef ENABLE_LZMA
+#if defined(ENABLE_LZMA)
   registerMethod("ReadWriteClusterLzma", *this, 
::ReadWriteClusterLzma);
 #endif
 }
@@ -126,7 +126,7 @@
   

[MediaWiki-commits] [Gerrit] openzim[master]: Provide time gap between uuid generation during tests

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/330861 )

Change subject: Provide time gap between uuid generation during tests
..


Provide time gap between uuid generation during tests

GNU Mach's i.e. Hurd's kernel clock is not very accurate so during
test on generating and comparing uuid's time might be same leading to
generating same Uuid. This patch adds a sleep of 1s between 2
generate statemens. Thanks to Pino Toscano.

This patch was written for the Debian package to fix a build failure on
GNU Hurd, and is suitable to be included upstream.

Change-Id: I1a1520bb0597244a1d2423ed17e87c5a39cb4aa6
---
M zimlib/test/uuid.cpp
1 file changed, 8 insertions(+), 0 deletions(-)

Approvals:
  Mgautierfr: Looks good to me, but someone else must approve
  Kelson: Verified; Looks good to me, approved



diff --git a/zimlib/test/uuid.cpp b/zimlib/test/uuid.cpp
index 3348b73..0bace52 100644
--- a/zimlib/test/uuid.cpp
+++ b/zimlib/test/uuid.cpp
@@ -24,6 +24,8 @@
 #include 
 #include 
 
+#include 
+
 class UuidTest : public cxxtools::unit::TestSuite
 {
   public:
@@ -92,6 +94,12 @@
   CXXTOOLS_UNIT_ASSERT(uuid1 != zim::Uuid());
   CXXTOOLS_UNIT_ASSERT(uuid2 == zim::Uuid());
 
+  // Since GNU Mach's clock isn't precise hence the time might be
+  // same during generating uuid1 and uuid2 leading to test
+  // failure. To bring the time difference between 2 sleep for a
+  // second. Thanks to Pino Toscano.
+  sleep(1);
+
   uuid2 = zim::Uuid::generate();
   CXXTOOLS_UNIT_ASSERT(uuid1 != uuid2);
   CXXTOOLS_UNIT_ASSERT(uuid1 != zim::Uuid());

-- 
To view, visit https://gerrit.wikimedia.org/r/330861
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1a1520bb0597244a1d2423ed17e87c5a39cb4aa6
Gerrit-PatchSet: 1
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Kelson 
Gerrit-Reviewer: Mgautierfr 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: pkg_config dependencies are properly declared.

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/333593 )

Change subject: pkg_config dependencies are properly declared.
..


pkg_config dependencies are properly declared.

The 'Requires' field now use a variable from the configure to properly set
the dependencies depending of what compression algorithms are really used.

Change-Id: I282a8039bce4cfec23ae13d8a3240d45c5cab1ac
---
M zimlib/configure.ac
M zimlib/libzim.pc.in
2 files changed, 7 insertions(+), 1 deletion(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimlib/configure.ac b/zimlib/configure.ac
index da71e40..6be35df 100644
--- a/zimlib/configure.ac
+++ b/zimlib/configure.ac
@@ -65,6 +65,7 @@
 # compression algorithms
 #
 
+pkg_config_deps=""
 # zlib
 AC_ARG_ENABLE([zlib],
   AS_HELP_STRING([--enable-zlib], [add support for zlib compression (disabled 
by default)]),
@@ -75,6 +76,7 @@
 then
 AC_CHECK_HEADER([zlib.h], , AC_MSG_ERROR([zlib header not found]))
 AC_DEFINE(ENABLE_ZLIB, [1], [defined if zlib compression is enabled])
+pkg_config_deps+=" zlib"
 fi
 
 AM_CONDITIONAL(WITH_ZLIB, test "$enable_zlib" = "yes")
@@ -89,6 +91,7 @@
 then
 AC_CHECK_HEADER([bzlib.h], , AC_MSG_ERROR([bzip2 header files not found]))
 AC_DEFINE(ENABLE_BZIP2, [1], [defined if bzip2 compression is enabled])
+pkg_config_deps+=" bzip2"
 fi
 
 AM_CONDITIONAL(WITH_BZIP2, test "$enable_bzip2" = "yes")
@@ -103,10 +106,13 @@
 then
 AC_CHECK_HEADER([lzma.h], , AC_MSG_ERROR([lzma header files not found]))
 AC_DEFINE(ENABLE_LZMA, [1], [defined if lzma compression is enabled])
+pkg_config_deps+=" liblzma"
 fi
 
 AM_CONDITIONAL(WITH_LZMA, test "$enable_lzma" = "yes")
 
+AC_SUBST(PKG_CONFIG_DEPENDENCIES, $pkg_config_deps)
+
 #
 # unittest
 #
diff --git a/zimlib/libzim.pc.in b/zimlib/libzim.pc.in
index 58cc155..d17e236 100644
--- a/zimlib/libzim.pc.in
+++ b/zimlib/libzim.pc.in
@@ -6,7 +6,7 @@
 Name: libzim
 Description: implements read and write methods for ZIM files
 Version: @VERSION@
-Requires: liblzma
+Requires: @PKG_CONFIG_DEPENDENCIES@
 Libs: -L${libdir} -lzim
 Cflags: -I${includedir}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/333593
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I282a8039bce4cfec23ae13d8a3240d45c5cab1ac
Gerrit-PatchSet: 1
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: Mgautierfr 
Gerrit-Reviewer: Kelson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: Always try to cache a cluster, even if it is a uncompressed ...

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/314721 )

Change subject: Always try to cache a cluster, even if it is a uncompressed one.
..


Always try to cache a cluster, even if it is a uncompressed one.

Creating a cluster is costly. We need to avoid it.

Change-Id: I5a5c384a13d77387d1d7ae020df08c010f82502c
---
M zimlib/src/fileimpl.cpp
1 file changed, 2 insertions(+), 7 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimlib/src/fileimpl.cpp b/zimlib/src/fileimpl.cpp
index 8c072eb..04fcacd 100644
--- a/zimlib/src/fileimpl.cpp
+++ b/zimlib/src/fileimpl.cpp
@@ -182,13 +182,8 @@
 if (zimFile.fail())
   throw ZimFileFormatError("error reading cluster data");
 
-if (cluster.isCompressed())
-{
-  log_debug("put cluster " << idx << " into cluster cache; hits " << 
clusterCache.getHits() << " misses " << clusterCache.getMisses() << " ratio " 
<< clusterCache.hitRatio() * 100 << "% fillfactor " << 
clusterCache.fillfactor());
-  clusterCache.put(idx, cluster);
-}
-else
-  log_debug("cluster " << idx << " is not compressed - do not cache");
+log_debug("put cluster " << idx << " into cluster cache; hits " << 
clusterCache.getHits() << " misses " << clusterCache.getMisses() << " ratio " 
<< clusterCache.hitRatio() * 100 << "% fillfactor " << 
clusterCache.fillfactor());
+clusterCache.put(idx, cluster);
 
 return cluster;
   }

-- 
To view, visit https://gerrit.wikimedia.org/r/314721
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5a5c384a13d77387d1d7ae020df08c010f82502c
Gerrit-PatchSet: 2
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: Mgautierfr 
Gerrit-Reviewer: Kelson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: Remove unused currentPos from fstream.

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/314719 )

Change subject: Remove unused currentPos from fstream.
..


Remove unused currentPos from fstream.

Change-Id: Idd7e392b35dbe36e5d4ee4a03f6119bb01ab4e2e
---
M zimlib/include/zim/fstream.h
M zimlib/src/fstream.cpp
2 files changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimlib/include/zim/fstream.h b/zimlib/include/zim/fstream.h
index 4b99814..b971da0 100644
--- a/zimlib/include/zim/fstream.h
+++ b/zimlib/include/zim/fstream.h
@@ -60,7 +60,6 @@
   FilesType files;
   OpenFilesCacheType openFilesCache;
   OpenfileInfoPtr currentFile;
-  zim::offset_type currentPos;
 
   std::streambuf::int_type overflow(std::streambuf::int_type ch);
   std::streambuf::int_type underflow();
diff --git a/zimlib/src/fstream.cpp b/zimlib/src/fstream.cpp
index ef91b57..b8e5a98 100644
--- a/zimlib/src/fstream.cpp
+++ b/zimlib/src/fstream.cpp
@@ -264,7 +264,6 @@
 void streambuf::seekg(zim::offset_type off)
 {
   setg(0, 0, 0);
-  currentPos = off;
 
   zim::offset_type o = off;
   FilesType::iterator it;

-- 
To view, visit https://gerrit.wikimedia.org/r/314719
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idd7e392b35dbe36e5d4ee4a03f6119bb01ab4e2e
Gerrit-PatchSet: 3
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: Mgautierfr 
Gerrit-Reviewer: Kelson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: Make zimlib compilable with meson.

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/330417 )

Change subject: Make zimlib compilable with meson.
..


Make zimlib compilable with meson.

Also install a correct pkg-config file who correctly declare dependencies
of zimlib.

Change-Id: I86b999e46fac42e8d552cba8a1be1c674bb2c67d
---
M zimlib/.gitignore
A zimlib/include/meson.build
A zimlib/meson.build
A zimlib/meson_options.txt
A zimlib/src/config.h.in
A zimlib/src/meson.build
6 files changed, 168 insertions(+), 1 deletion(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimlib/.gitignore b/zimlib/.gitignore
index 550c09a..3563fa8 100644
--- a/zimlib/.gitignore
+++ b/zimlib/.gitignore
@@ -2,7 +2,7 @@
 *#*
 autom4te.cache
 compile
-config.*
+config.h
 configure
 depcomp
 .deps
diff --git a/zimlib/include/meson.build b/zimlib/include/meson.build
new file mode 100644
index 000..0caa2e8
--- /dev/null
+++ b/zimlib/include/meson.build
@@ -0,0 +1,34 @@
+install_headers(
+'zim/article.h',
+'zim/articlesearch.h',
+'zim/blob.h',
+'zim/cache.h',
+'zim/cluster.h',
+'zim/dirent.h',
+'zim/endian.h',
+'zim/error.h',
+'zim/file.h',
+'zim/fileheader.h',
+'zim/fileimpl.h',
+'zim/fileiterator.h',
+'zim/fstream.h',
+'zim/indexarticle.h',
+'zim/noncopyable.h',
+'zim/search.h',
+'zim/smartptr.h',
+'zim/refcounted.h',
+'zim/template.h',
+'zim/unicode.h',
+'zim/uuid.h',
+'zim/zim.h',
+'zim/zintstream.h',
+subdir:'zim'
+)
+
+install_headers(
+'zim/writer/articlesource.h',
+'zim/writer/dirent.h',
+'zim/writer/zimcreator.h',
+subdir:'zim/writer'
+)
+
diff --git a/zimlib/meson.build b/zimlib/meson.build
new file mode 100644
index 000..0eed3c4
--- /dev/null
+++ b/zimlib/meson.build
@@ -0,0 +1,44 @@
+project('libzim', ['c', 'cpp'],
+  version : '1.4',
+  license : 'GPL2')
+
+abi_current=2
+abi_revision=0
+abi_age=0
+  
+conf = configuration_data()
+conf.set('VERSION', '"@0@"'.format(meson.project_version()))
+conf.set('DIRENT_CACHE_SIZE', get_option('DIRENT_CACHE_SIZE'))
+conf.set('CLUSTER_CACHE_SIZE', get_option('CLUSTER_CACHE_SIZE'))
+conf.set('LZMA_MEMORY_SIZE', get_option('LZMA_MEMORY_SIZE'))
+
+zlib_dep = dependency('zlib', required:false)
+conf.set('ENABLE_ZLIB', zlib_dep.found())
+lzma_dep = dependency('liblzma', required:false)
+conf.set('ENABLE_LZMA', lzma_dep.found())
+bzip2_dep = dependency('bzip2', required:false)
+conf.set('ENABLE_BZIP2', bzip2_dep.found())
+
+pkg_requires = []
+if zlib_dep.found()
+pkg_requires += ['zlib']
+endif
+if lzma_dep.found()
+pkg_requires += ['liblzma']
+endif
+if bzip2_dep.found()
+pkg_requires += ['bzip2']
+endif
+
+inc = include_directories('include')
+
+subdir('include')
+subdir('src')
+
+pkg_mod = import('pkgconfig')
+pkg_mod.generate(libraries : libzim,
+ version : meson.project_version(),
+ name : 'libzim',
+ filebase : 'libzim',
+ description : 'A Library to zim.',
+ requires : pkg_requires)
diff --git a/zimlib/meson_options.txt b/zimlib/meson_options.txt
new file mode 100644
index 000..108edf9
--- /dev/null
+++ b/zimlib/meson_options.txt
@@ -0,0 +1,6 @@
+option('CLUSTER_CACHE_SIZE', type : 'string', value : '16',
+  description : 'set cluster cache size to number (default:16)')
+option('DIRENT_CACHE_SIZE', type : 'string', value : '512',
+  description : 'set dirent cache size to number (default:512)')
+option('LZMA_MEMORY_SIZE', type : 'string', value : '128',
+  description : 'set lzma uncompress memory in MB (default:128)')
\ No newline at end of file
diff --git a/zimlib/src/config.h.in b/zimlib/src/config.h.in
new file mode 100644
index 000..d9e4b7d
--- /dev/null
+++ b/zimlib/src/config.h.in
@@ -0,0 +1,14 @@
+
+#mesondefine VERSION
+
+#mesondefine DIRENT_CACHE_SIZE
+
+#mesondefine CLUSTER_CACHE_SIZE
+
+#mesondefine LZMA_MEMORY_SIZE
+
+#mesondefine ENABLE_ZLIB
+
+#mesondefine ENABLE_LZMA
+
+#mesondefine ENABLE_BZIP2
diff --git a/zimlib/src/meson.build b/zimlib/src/meson.build
new file mode 100644
index 000..ec550f4
--- /dev/null
+++ b/zimlib/src/meson.build
@@ -0,0 +1,69 @@
+
+configure_file(output : 'config.h',
+   configuration : conf,
+   input : 'config.h.in')
+
+common_sources = [
+#'config.h',
+'article.cpp',
+'articlesearch.cpp',
+'articlesource.cpp',
+'cluster.cpp',
+'dirent.cpp',
+'envvalue.cpp',
+'file.cpp',
+'fileheader.cpp',
+'fileimpl.cpp',
+'fstream.cpp',
+'indexarticle.cpp',
+'md5.c',
+'md5stream.cpp',
+'ptrstream.cpp',
+'search.cpp',
+'tee.cpp',
+'template.cpp',
+'unicode.cpp',
+'uuid.cpp',
+'zimcreator.cpp',
+'zintstream.cpp'
+]
+
+zlib_sources = [
+'deflatestream.cpp',
+'inflatestream.cpp'
+]
+
+bzip2_sources = [
+

[MediaWiki-commits] [Gerrit] openzim[master]: Add libzim.pc for pkg-config

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/329759 )

Change subject: Add libzim.pc for pkg-config
..


Add libzim.pc for pkg-config

This registers the libzim library with pkg-config, mostly so adding it
as a dependency with meson works as expected.

After building and installing the library, the following should work:
 $ pkg-config --modversion libzim

Change-Id: Ieb41c0b3a9445e6d651f8c0d528d30c2ebaf06dc
---
M zimlib/.gitignore
M zimlib/Makefile.am
M zimlib/configure.ac
A zimlib/libzim.pc.in
4 files changed, 16 insertions(+), 0 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimlib/.gitignore b/zimlib/.gitignore
index 0a4a991..550c09a 100644
--- a/zimlib/.gitignore
+++ b/zimlib/.gitignore
@@ -27,3 +27,4 @@
 examples/createZimExample
 src/tools/zimdump
 src/tools/zimsearch
+libzim.pc
diff --git a/zimlib/Makefile.am b/zimlib/Makefile.am
index 504fe34..4053e7f 100644
--- a/zimlib/Makefile.am
+++ b/zimlib/Makefile.am
@@ -13,3 +13,6 @@
include \
$(UNITTEST_DIR) \
examples
+
+pkgconfigdir = $(libdir)/pkgconfig
+pkgconfig_DATA = libzim.pc
diff --git a/zimlib/configure.ac b/zimlib/configure.ac
index 0472538..da71e40 100644
--- a/zimlib/configure.ac
+++ b/zimlib/configure.ac
@@ -146,6 +146,7 @@
 # output
 #
 AC_CONFIG_FILES([
+  libzim.pc
   Makefile
   src/Makefile
   src/tools/Makefile
diff --git a/zimlib/libzim.pc.in b/zimlib/libzim.pc.in
new file mode 100644
index 000..bbef0d6
--- /dev/null
+++ b/zimlib/libzim.pc.in
@@ -0,0 +1,11 @@
+prefix=@prefix@
+exec_prefix=@exec_prefix@
+libdir=@libdir@
+includedir=@includedir@
+
+Name: libzim
+Description: implements read and write methods for ZIM files
+Version: @VERSION@
+Libs: -L${libdir} -lzim
+Cflags: -I${includedir}
+

-- 
To view, visit https://gerrit.wikimedia.org/r/329759
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb41c0b3a9445e6d651f8c0d528d30c2ebaf06dc
Gerrit-PatchSet: 1
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Kelson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[master]: Add the valuesmap metadata.

[Kelson (Code Review)]

Kelson has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/343896 )

Change subject: Add the valuesmap metadata.
..


Add the valuesmap metadata.

This way, the searcher will know where values are stored.

Change-Id: I1228ebfefd70dc7c22fc37034c50d0019968c796
---
M zimwriterfs/xapianIndexer.cpp
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Kelson: Verified; Looks good to me, approved



diff --git a/zimwriterfs/xapianIndexer.cpp b/zimwriterfs/xapianIndexer.cpp
index 6cb6713..65129b7 100644
--- a/zimwriterfs/xapianIndexer.cpp
+++ b/zimwriterfs/xapianIndexer.cpp
@@ -52,6 +52,7 @@
 void XapianIndexer::indexingPrelude(const string indexPath_) {
 indexPath = indexPath_;
 this->writableDatabase = Xapian::WritableDatabase(indexPath + ".tmp", 
Xapian::DB_CREATE_OR_OVERWRITE);
+this->writableDatabase.set_metadata("valuesmap", 
"title:0;snippet:1;size:2;wordcount:3");
 this->writableDatabase.begin_transaction(true);
 
 /* Insert the stopwords */

-- 
To view, visit https://gerrit.wikimedia.org/r/343896
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1228ebfefd70dc7c22fc37034c50d0019968c796
Gerrit-PatchSet: 1
Gerrit-Project: openzim
Gerrit-Branch: master
Gerrit-Owner: Mgautierfr 
Gerrit-Reviewer: Kelson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] openzim[refs/meta/config]: Modify access rules

[Paladox (Code Review)]

Paladox has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/344794 )

Change subject: Modify access rules
..

Modify access rules

Change-Id: Ifb79d6cb21c10144d5cce325136a3f68257b2ec9
---
M project.config
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/openzim refs/changes/94/344794/1

diff --git a/project.config b/project.config
index 8effac7..7e7ca50 100644
--- a/project.config
+++ b/project.config
@@ -5,6 +5,7 @@
 [access "refs/*"]
owner = group openzim
create = group openzim
+   forgeCommitter = group openzim
forgeCommitter = group platform-engineering
push = group openzim
pushMerge = group openzim

-- 
To view, visit https://gerrit.wikimedia.org/r/344794
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifb79d6cb21c10144d5cce325136a3f68257b2ec9
Gerrit-PatchSet: 1
Gerrit-Project: openzim
Gerrit-Branch: refs/meta/config
Gerrit-Owner: Paladox 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...BlueSpicePageVersion[master]: Use tabs in json

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/344752 )

Change subject: Use tabs in json
..


Use tabs in json

Change-Id: I3435422e6cbdbcb4bbefb64d7f72072519fe3db2
---
M composer.json
M i18n/en.json
2 files changed, 20 insertions(+), 20 deletions(-)

Approvals:
  Pwirth: Looks good to me, but someone else must approve
  Mglaser: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
index 5f67376..42cd9b9 100644
--- a/composer.json
+++ b/composer.json
@@ -1,16 +1,16 @@
 {
-  "autoload" : {
-"psr-4": {
-  "BS\\PageVersion\\Tests\\" : "tests/phpunit",
-  "BS\\PageVersion\\" : "src"
-}
-  },
-  "require-dev": {
-"jakub-onderka/php-parallel-lint": "0.9.2"
-  },
-  "scripts": {
-"test": [
-  "parallel-lint . --exclude vendor"
-]
-  }
+   "autoload": {
+   "psr-4": {
+   "BS\\PageVersion\\Tests\\": "tests/phpunit",
+   "BS\\PageVersion\\": "src"
+   }
+   },
+   "require-dev": {
+   "jakub-onderka/php-parallel-lint": "0.9.2"
+   },
+   "scripts": {
+   "test": [
+   "parallel-lint . --exclude vendor"
+   ]
+   }
 }
diff --git a/i18n/en.json b/i18n/en.json
index 8f9ae89..a3ed204 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -1,8 +1,8 @@
 {
-  "@metadata": {
-"authors": [
-  "Robert Vogel "
-]
-  },
-  "bs-pageversion-desc": "Provides variables and other functions about page 
revisions"
+   "@metadata": {
+   "authors": [
+   "Robert Vogel "
+   ]
+   },
+   "bs-pageversion-desc": "Provides variables and other functions about 
page revisions"
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/344752
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3435422e6cbdbcb4bbefb64d7f72072519fe3db2
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/BlueSpicePageVersion
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: Ljonka 
Gerrit-Reviewer: Mglaser 
Gerrit-Reviewer: Pwirth 
Gerrit-Reviewer: Robert Vogel 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Metrolook[master]: Add a scroll offset when a table of contents anchor link is ...

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/344792 )

Change subject: Add a scroll offset when a table of contents anchor link is 
clicked
..


Add a scroll offset when a table of contents anchor link is clicked

Patch is by @smkent

Bug: T157532
Change-Id: I2ef002f7daeb0f215c7b36fa31344090b0ae6db9
---
A js/fixed-header-scroll-fix.js
M skin.json
2 files changed, 19 insertions(+), 1 deletion(-)

Approvals:
  Paladox: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/js/fixed-header-scroll-fix.js b/js/fixed-header-scroll-fix.js
new file mode 100644
index 000..d2fe16d
--- /dev/null
+++ b/js/fixed-header-scroll-fix.js
@@ -0,0 +1,17 @@
+/* Add offset when scrolling to an anchor from a table of contents link */
+var href = $( this ).attr( 'href' ),
+   dest = ( $( href ).offset().top -
+   ( $( 'div.vectorMenu#usermenu' ).height() + 10 ) ),
+   d = ( $( ':target' ).offset().top -
+   ( $( 'div.vectorMenu#usermenu' ).height() + 10 ) );
+
+$( '.toc ul a[href^=#]' ).on( 'click', function( e ) {
+   window.history.pushState( {}, '', $( this ).prop( 'href' ) );
+   $( 'html, body' ).scrollTop( dest );
+   e.preventDefault();
+} );
+
+/* Add offset when scrolling to an anchor present at page load time */
+if ( $( ':target' ).length > 0 ) {
+   $( 'html, body' ).scrollTop( d );
+}
diff --git a/skin.json b/skin.json
index ae9e5c6..d64876b 100644
--- a/skin.json
+++ b/skin.json
@@ -99,7 +99,8 @@
"js/metrolook.js",
"js/metrolook.search.js",
"js/vector.js",
-   "js/overthrow.js"
+   "js/overthrow.js",
+   "js/fixed-header-scroll-fix.js"
],
"position": "top",
"dependencies": [

-- 
To view, visit https://gerrit.wikimedia.org/r/344792
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2ef002f7daeb0f215c7b36fa31344090b0ae6db9
Gerrit-PatchSet: 7
Gerrit-Project: mediawiki/skins/Metrolook
Gerrit-Branch: master
Gerrit-Owner: Paladox 
Gerrit-Reviewer: Paladox 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits