[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: CX2: Define translation unit for external links

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/346727 )

Change subject: CX2: Define translation unit for external links
..


CX2: Define translation unit for external links

Do not mix up them with internal links as we did in CX1
Also remove some unused methods from LinkTranslationUnit

Bug: T106525
Change-Id: I8cf8e155144297073c1f067e408fe6faf4cf05c7
---
M extension.json
A modules/dm/translationunits/mw.cx.dm.ExternalLinkTranslationUnit.js
M modules/dm/translationunits/mw.cx.dm.LinkTranslationUnit.js
A modules/tools/mw.cx.tools.ExternalLinkTool.js
A modules/tools/styles/mw.cx.tools.ExternalLinkTool.less
A modules/ui/translationunits/mw.cx.ui.ExternalLinkTranslationUnit.js
M modules/ui/translationunits/mw.cx.ui.LinkTranslationUnit.js
7 files changed, 147 insertions(+), 13 deletions(-)

Approvals:
  jenkins-bot: Verified
  Nikerabbit: Looks good to me, approved



diff --git a/extension.json b/extension.json
index d64de02..aca5ea6 100644
--- a/extension.json
+++ b/extension.json
@@ -1249,6 +1249,7 @@
"mw.cx.dm.ImageTranslationUnit",
"mw.cx.dm.SentenceTranslationUnit",
"mw.cx.dm.LinkTranslationUnit",
+   "mw.cx.dm.ExternalLinkTranslationUnit",
"mw.cx.dm.PoemTranslationUnit",
"mw.cx.dm.ReferenceTranslationUnit",
"mw.cx.dm.TemplateTranslationUnit",
@@ -1270,6 +1271,14 @@
],
"dependencies": [
"mw.cx.dm.SectionTranslationUnit"
+   ]
+   },
+   "mw.cx.dm.ExternalLinkTranslationUnit": {
+   "scripts": [
+   
"dm/translationunits/mw.cx.dm.ExternalLinkTranslationUnit.js"
+   ],
+   "dependencies": [
+   "mw.cx.dm.TranslationUnit"
]
},
"mw.cx.dm.SentenceTranslationUnit": {
@@ -1689,6 +1698,7 @@
"mw.cx.ui.PoemTranslationUnit",
"mw.cx.ui.ReferenceTranslationUnit",
"mw.cx.ui.LinkTranslationUnit",
+   "mw.cx.ui.ExternalLinkTranslationUnit",
"mw.cx.ui.TemplateTranslationUnit",
"mw.cx.ui.SentenceTranslationUnit"
]
@@ -1717,6 +1727,14 @@
],
"styles":[

"ui/styles/translationunits/mw.cx.ui.LinkTranslationUnit.less"
+   ],
+   "dependencies": [
+   "mw.cx.ui.TranslationUnit"
+   ]
+   },
+   "mw.cx.ui.ExternalLinkTranslationUnit": {
+   "scripts": [
+   
"ui/translationunits/mw.cx.ui.ExternalLinkTranslationUnit.js"
],
"dependencies": [
"mw.cx.ui.TranslationUnit"
@@ -1783,6 +1801,7 @@
"mw.cx.tools": {
"dependencies": [
"mw.cx.tools.DictionaryTool",
+   "mw.cx.tools.ExternalLinkTool",
"mw.cx.tools.FormatterTool",
"mw.cx.tools.InstructionsTool",
"mw.cx.tools.LinkTool",
@@ -1875,6 +1894,20 @@
"mw.cx.tools.TranslationTool"
]
},
+   "mw.cx.tools.ExternalLinkTool": {
+   "scripts": [
+   "tools/mw.cx.tools.ExternalLinkTool.js"
+   ],
+   "styles": [
+   "tools/styles/mw.cx.tools.ExternalLinkTool.less"
+   ],
+   "dependencies": [
+   "mw.cx.tools.TranslationTool"
+   ],
+   "messages":[
+   "cx-tools-link-hover-tooltip"
+   ]
+   },
"mw.cx.tools.FormatterTool": {
"scripts": [
"tools/mw.cx.tools.FormatterTool.js"
diff --git 
a/modules/dm/translationunits/mw.cx.dm.ExternalLinkTranslationUnit.js 
b/modules/dm/translationunits/mw.cx.dm.ExternalLinkTranslationUnit.js
new file mode 100644
index 000..1ab985e
--- /dev/null
+++ b/modules/dm/translationunits/mw.cx.dm.ExternalLinkTranslationUnit.js
@@ -0,0 +1,37 @@
+'use strict';
+
+/**
+ * CX External Link TranslationUnit 

[MediaWiki-commits] [Gerrit] mediawiki...Linter[master]: Show tag name for the stripped-tag category

[Subramanya Sastry (Code Review)]

Subramanya Sastry has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348903 )

Change subject: Show tag name for the stripped-tag category
..

Show tag name for the stripped-tag category

Change-Id: I53546c11391fb2388dbcf3f70c0a21b2b1af9b09
---
M includes/LintErrorsPager.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Linter 
refs/changes/03/348903/1

diff --git a/includes/LintErrorsPager.php b/includes/LintErrorsPager.php
index f21bea1..f6c192d 100644
--- a/includes/LintErrorsPager.php
+++ b/includes/LintErrorsPager.php
@@ -120,7 +120,7 @@
case 'details':
// While deletable-table-tag has params set, it 
adds no new information
// and is not included here since the error 
category has the tag name.
-   $hasNameCats = [ 'obsolete-tag', 
'missing-end-tag', 'self-closed-tag', 'misnested-tag' ];
+   $hasNameCats = [ 'obsolete-tag', 
'missing-end-tag', 'self-closed-tag', 'misnested-tag', 'stripped-tag' ];
if ( in_array( $this->category, $hasNameCats ) 
&& isset( $lintError->params['name'] ) ) {
return Html::element( 'code', [], 
$lintError->params['name'] );
} elseif ( $this->category === 
'bogus-image-options' && isset( $lintError->params['items'] ) ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/348903
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I53546c11391fb2388dbcf3f70c0a21b2b1af9b09
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Linter
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Temporarily half the transclusion update concurrency

[Ppchelko (Code Review)]

Ppchelko has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348902 )

Change subject: Temporarily half the transclusion update concurrency
..


Temporarily half the transclusion update concurrency

Because of the loss of restnase1018, other instances in the `d` rack are
exposed to high load, so back off for a while with transclusion updates.

Bug: T163292
Change-Id: Ia228fc2aca02b1a12690afffaa7f88df47ed5eba
---
M scap/templates/config.yaml.j2
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Ppchelko: Verified; Looks good to me, approved



diff --git a/scap/templates/config.yaml.j2 b/scap/templates/config.yaml.j2
index 6167f90..a6ed0ca 100644
--- a/scap/templates/config.yaml.j2
+++ b/scap/templates/config.yaml.j2
@@ -286,7 +286,7 @@
   redirect: false
 
   on_transclusion_update:
-concurrency: <%= concurrency * 8 %>
+concurrency: <%= concurrency * 4 %>
 topic: change-prop.transcludes.resource-change
 cases:
   - match:

-- 
To view, visit https://gerrit.wikimedia.org/r/348902
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia228fc2aca02b1a12690afffaa7f88df47ed5eba
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/change-propagation/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 
Gerrit-Reviewer: Eevans 
Gerrit-Reviewer: Ppchelko 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Temporarily half the transclusion update concurrency

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348902 )

Change subject: Temporarily half the transclusion update concurrency
..

Temporarily half the transclusion update concurrency

Because of the loss of restnase1018, other instances in the `d` rack are
exposed to high load, so back off for a while with transclusion updates.

Bug: T163292
Change-Id: Ia228fc2aca02b1a12690afffaa7f88df47ed5eba
---
M scap/templates/config.yaml.j2
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/services/change-propagation/deploy 
refs/changes/02/348902/1

diff --git a/scap/templates/config.yaml.j2 b/scap/templates/config.yaml.j2
index 6167f90..a6ed0ca 100644
--- a/scap/templates/config.yaml.j2
+++ b/scap/templates/config.yaml.j2
@@ -286,7 +286,7 @@
   redirect: false
 
   on_transclusion_update:
-concurrency: <%= concurrency * 8 %>
+concurrency: <%= concurrency * 4 %>
 topic: change-prop.transcludes.resource-change
 cases:
   - match:

-- 
To view, visit https://gerrit.wikimedia.org/r/348902
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia228fc2aca02b1a12690afffaa7f88df47ed5eba
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/change-propagation/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RC Filters: Detect filters conflicts to by-pass db query

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/347418 )

Change subject: RC Filters: Detect filters conflicts to by-pass db query
..


RC Filters: Detect filters conflicts to by-pass db query

Filters are in conflict when their combination is guaranteed
to return no results. For instance: minor and log entries
is a conflict because major/minor does not apply to
log entries and the field is set to major by default.

Letting conflicts go through result in some very slow
database queries.

Bug: T160220
Change-Id: Ia6b0125c675c4a3cc4e4be4f83d1bd10d23059ba
---
M includes/changes/ChangesListBooleanFilter.php
M includes/changes/ChangesListFilter.php
M includes/changes/ChangesListFilterGroup.php
M includes/changes/ChangesListStringOptionsFilter.php
M includes/specialpage/ChangesListSpecialPage.php
M includes/specials/SpecialRecentchanges.php
M tests/phpunit/includes/specialpage/ChangesListSpecialPageTest.php
M tests/phpunit/mocks/MockChangesListFilter.php
8 files changed, 305 insertions(+), 0 deletions(-)

Approvals:
  Mattflaschen: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/changes/ChangesListBooleanFilter.php 
b/includes/changes/ChangesListBooleanFilter.php
index 851d173..1c116ab 100644
--- a/includes/changes/ChangesListBooleanFilter.php
+++ b/includes/changes/ChangesListBooleanFilter.php
@@ -223,4 +223,13 @@
return $output;
}
 
+   /**
+* @inheritdoc
+*/
+   public function isSelected( FormOptions $opts ) {
+   return !$opts[ $this->getName() ] &&
+   array_filter( $this->getSiblings(), function ( $sibling 
) use ( $opts ) {
+   return $opts[ $sibling->getName() ];
+   } );
+   }
 }
diff --git a/includes/changes/ChangesListFilter.php 
b/includes/changes/ChangesListFilter.php
index b3a16a8..9af9adc 100644
--- a/includes/changes/ChangesListFilter.php
+++ b/includes/changes/ChangesListFilter.php
@@ -227,6 +227,7 @@
if ( $other instanceof ChangesListFilterGroup ) {
$this->conflictingGroups[] = [
'group' => $other->getName(),
+   'groupObject' => $other,
'globalDescription' => $globalDescription,
'contextDescription' => $contextDescription,
];
@@ -234,6 +235,7 @@
$this->conflictingFilters[] = [
'group' => $other->getGroup()->getName(),
'filter' => $other->getName(),
+   'filterObject' => $other,
'globalDescription' => $globalDescription,
'contextDescription' => $contextDescription,
];
@@ -385,6 +387,8 @@
);
 
foreach ( $conflicts as $conflictInfo ) {
+   unset( $conflictInfo['filterObject'] );
+   unset( $conflictInfo['groupObject'] );
$output['conflicts'][] = $conflictInfo;
array_push(
$output['messageKeys'],
@@ -395,4 +399,105 @@
 
return $output;
}
+
+   /**
+* Checks whether this filter is selected in the provided options
+*
+* @param FormOptions $opts
+* @return bool
+*/
+   abstract public function isSelected( FormOptions $opts );
+
+   /**
+* Get groups conflicting with this filter
+*
+* @return ChangesListFilterGroup[]
+*/
+   public function getConflictingGroups() {
+   return array_map(
+   function ( $conflictDesc ) {
+   return $conflictDesc[ 'groupObject' ];
+   },
+   $this->conflictingGroups
+   );
+   }
+
+   /**
+* Get filters conflicting with this filter
+*
+* @return ChangesListFilter[]
+*/
+   public function getConflictingFilters() {
+   return array_map(
+   function ( $conflictDesc ) {
+   return $conflictDesc[ 'filterObject' ];
+   },
+   $this->conflictingFilters
+   );
+   }
+
+   /**
+* Check if the conflict with a group is currently "active"
+*
+* @param ChangesListFilterGroup $group
+* @param FormOptions $opts
+* @return bool
+*/
+   public function activelyInConflictWithGroup( ChangesListFilterGroup 
$group, FormOptions $opts ) {
+   if ( $group->anySelected( $opts ) && $this->isSelected( $opts ) 
) {
+   /** @var 

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[master]: phpcs: Fix the easy rule violations with `composer fix`

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348899 )

Change subject: phpcs: Fix the easy rule violations with `composer fix`
..


phpcs: Fix the easy rule violations with `composer fix`

* Generic.Functions.FunctionCallArgumentSpacing.NoSpaceAfterComma
* Generic.Functions.FunctionCallArgumentSpacing.SpaceBeforeComma
* Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine
* Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
* MediaWiki.ControlStructures.IfElseStructure.SpaceAfterElse
* MediaWiki.ControlStructures.IfElseStructure.SpaceBeforeElse
* MediaWiki.WhiteSpace.MultipleEmptyLines.MultipleEmptyLines
* MediaWiki.WhiteSpace.SpaceAfterControlStructure.Incorrect
* MediaWiki.WhiteSpace.SpaceyParenthesis.SingleSpaceAfterOpenParenthesis
* MediaWiki.WhiteSpace.SpaceyParenthesis.SingleSpaceBeforeCloseParenthesis
* MediaWiki.WhiteSpace.SpaceyParenthesis.SpaceBeforeOpeningParenthesis
* PSR2.ControlStructures.ElseIfDeclaration.NotAllowed
* Squiz.WhiteSpace.LanguageConstructSpacing.Incorrect
* Squiz.WhiteSpace.ScopeClosingBrace.ContentBefore
* Squiz.WhiteSpace.ScopeClosingBrace.Indent
* Squiz.WhiteSpace.SuperfluousWhitespace.EndLine

Change-Id: I85a771bffb56816e9070954b5eb4a5bc4612c45e
---
M FlaggedRevs.php
M api/FlaggedRevsApi.hooks.php
M api/actions/ApiReview.php
M api/actions/ApiReviewActivity.php
M api/actions/ApiStabilize.php
M api/reports/ApiFlagConfig.php
M api/reports/ApiQueryConfiguredPages.php
M api/reports/ApiQueryFlagged.php
M api/reports/ApiQueryOldreviewedpages.php
M api/reports/ApiQueryReviewedpages.php
M api/reports/ApiQueryUnreviewedpages.php
M backend/FRDependencyUpdate.php
M backend/FRInclusionManager.php
M backend/FlaggedRevision.php
M backend/FlaggedRevs.class.php
M backend/FlaggedRevs.hooks.php
M backend/FlaggedRevsStats.php
M business/FRGenericSubmitForm.php
M business/PageStabilityForm.php
M frontend/FlaggablePageView.php
M frontend/FlaggedRevsStableLogFormatter.php
M frontend/FlaggedRevsXML.php
M frontend/RejectConfirmationFormUI.php
M frontend/RevisionReviewFormUI.php
M frontend/specialpages/actions/RevisionReview_body.php
M frontend/specialpages/actions/Stabilization_body.php
M frontend/specialpages/reports/PendingChanges_body.php
M frontend/specialpages/reports/ProblemChanges_body.php
M frontend/specialpages/reports/QualityOversight_body.php
M frontend/specialpages/reports/StablePages_body.php
M frontend/specialpages/reports/UnreviewedPages_body.php
M maintenance/cachePendingRevs.php
M maintenance/clearCachedText.php
M maintenance/fixBug28348.php
M maintenance/flagToSemiProtect.php
M maintenance/populateRevTimestamp.php
M maintenance/pruneRevData.php
M maintenance/purgeReviewablePages.php
M maintenance/reviewAllPages.php
M maintenance/updateAutoPromote.php
M maintenance/updateQueryCache.php
M maintenance/updateStats.php
M maintenance/updateTracking.php
M phpcs.xml
M tests/FRInclusionManagerTest.php
M tests/FRParserCacheStableTest.php
M tests/FRUserActivityTest.php
M tests/FRUserCountersTest.php
M tests/FlaggablePageTest.php
49 files changed, 218 insertions(+), 259 deletions(-)

Approvals:
  Krinkle: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/FlaggedRevs.php b/FlaggedRevs.php
index ef1c008..c06f89f 100644
--- a/FlaggedRevs.php
+++ b/FlaggedRevs.php
@@ -36,7 +36,7 @@
 ];
 
 # Load global constants
-require( dirname( __FILE__ ) . '/FlaggedRevs.defines.php' );
+require ( dirname( __FILE__ ) . '/FlaggedRevs.defines.php' );
 
 # This will only distinguish "checked", "quality", and unreviewed
 # A small icon will show in the upper right hand corner
@@ -165,7 +165,7 @@
 */
 
 # Defines extra rights for advanced reviewer class (Reviewers)
-$wgGroupPermissions['reviewer']['validate']  = true;
+$wgGroupPermissions['reviewer']['validate'] = true;
 # Let this stand alone just in case...
 $wgGroupPermissions['reviewer']['review']= true;
 $wgGroupPermissions['reviewer']['autoreview']= true;
@@ -471,7 +471,7 @@
 $wgLogActionsHandlers['stable/move_stable'] = 'FlaggedRevsStableLogFormatter'; 
// move
 
 # B/C ...
-$wgLogActions['rights/erevoke']  = 'rights-editor-revoke';
+$wgLogActions['rights/erevoke'] = 'rights-editor-revoke';
 
 # AJAX functions
 $wgAjaxExportList[] = 'RevisionReview::AjaxReview';
diff --git a/api/FlaggedRevsApi.hooks.php b/api/FlaggedRevsApi.hooks.php
index 135c636..e7c8135 100644
--- a/api/FlaggedRevsApi.hooks.php
+++ b/api/FlaggedRevsApi.hooks.php
@@ -1,15 +1,15 @@
  revid => array_index of the revision
-   // we will need this later to add data to the result array 
+   // we will need this later to add data to the result array
$result = $module->getResult();
if ( defined( 'ApiResult::META_CONTENT' ) ) {
$data = (array)$result->getResultData( [ 'query', 
'pages' ], [ 'Strip' => 'all' ] );
@@ -78,7 +78,7 @@

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Revert "Temporarily lower the concurrency to 30"

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348901 )

Change subject: Revert "Temporarily lower the concurrency to 30"
..


Revert "Temporarily lower the concurrency to 30"

Let's first just lower the concurrency of transclusion updates only.

This reverts commit e7ffc2e6c8b4c3f4137622038800c767ca8d00a1.

Bug: T163292
Change-Id: Ic36a885f70eb5c507202c5fcf2c27e4db7d98276
---
M scap/vars.yaml
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved



diff --git a/scap/vars.yaml b/scap/vars.yaml
index c160856..6c3396c 100644
--- a/scap/vars.yaml
+++ b/scap/vars.yaml
@@ -18,4 +18,4 @@
 ores_uris: [ 'localhost:8081' ]
 purge_host: 127.0.0.1
 purge_port: 4827
-concurrency: 30
+concurrency: 50

-- 
To view, visit https://gerrit.wikimedia.org/r/348901
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic36a885f70eb5c507202c5fcf2c27e4db7d98276
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/change-propagation/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 
Gerrit-Reviewer: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Revert "Temporarily lower the concurrency to 30"

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348901 )

Change subject: Revert "Temporarily lower the concurrency to 30"
..

Revert "Temporarily lower the concurrency to 30"

Let's first just lower the concurrency of transclusion updates only.

This reverts commit e7ffc2e6c8b4c3f4137622038800c767ca8d00a1.

Bug: T163292
Change-Id: Ic36a885f70eb5c507202c5fcf2c27e4db7d98276
---
M scap/vars.yaml
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/services/change-propagation/deploy 
refs/changes/01/348901/1

diff --git a/scap/vars.yaml b/scap/vars.yaml
index c160856..6c3396c 100644
--- a/scap/vars.yaml
+++ b/scap/vars.yaml
@@ -18,4 +18,4 @@
 ores_uris: [ 'localhost:8081' ]
 purge_host: 127.0.0.1
 purge_port: 4827
-concurrency: 30
+concurrency: 50

-- 
To view, visit https://gerrit.wikimedia.org/r/348901
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic36a885f70eb5c507202c5fcf2c27e4db7d98276
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/change-propagation/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Temporarily lower the concurrency to 30

[Eevans (Code Review)]

Eevans has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348900 )

Change subject: Temporarily lower the concurrency to 30
..


Temporarily lower the concurrency to 30

We have lost 3 instances on restbase1018, which increased the load on
the remaining ones in the sme rack (d). Lower the concurrency to release
the pressure off of them.

To be reverted, at the latest after the removal of the instances from
the Cassandra cluster has been completed.

Bug: T163292
Change-Id: Iacca78ee48239d4d5784953b458f854a4764da8b
---
M scap/vars.yaml
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Eevans: Verified; Looks good to me, approved



diff --git a/scap/vars.yaml b/scap/vars.yaml
index 6c3396c..c160856 100644
--- a/scap/vars.yaml
+++ b/scap/vars.yaml
@@ -18,4 +18,4 @@
 ores_uris: [ 'localhost:8081' ]
 purge_host: 127.0.0.1
 purge_port: 4827
-concurrency: 50
+concurrency: 30

-- 
To view, visit https://gerrit.wikimedia.org/r/348900
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iacca78ee48239d4d5784953b458f854a4764da8b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/change-propagation/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 
Gerrit-Reviewer: Eevans 
Gerrit-Reviewer: Ppchelko 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Temporarily lower the concurrency to 30

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348900 )

Change subject: Temporarily lower the concurrency to 30
..

Temporarily lower the concurrency to 30

We have lost 3 instances on restbase1018, which increased the load on
the remaining ones in the sme rack (d). Lower the concurrency to release
the pressure off of them.

To be reverted, at the latest after the removal of the instances from
the Cassandra cluster has been completed.

Bug: T163292
Change-Id: Iacca78ee48239d4d5784953b458f854a4764da8b
---
M scap/vars.yaml
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/services/change-propagation/deploy 
refs/changes/00/348900/1

diff --git a/scap/vars.yaml b/scap/vars.yaml
index 6c3396c..c160856 100644
--- a/scap/vars.yaml
+++ b/scap/vars.yaml
@@ -18,4 +18,4 @@
 ores_uris: [ 'localhost:8081' ]
 purge_host: 127.0.0.1
 purge_port: 4827
-concurrency: 50
+concurrency: 30

-- 
To view, visit https://gerrit.wikimedia.org/r/348900
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iacca78ee48239d4d5784953b458f854a4764da8b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/change-propagation/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[master]: phpcs: Fix the easy rule violations with `composer fix`

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348899 )

Change subject: phpcs: Fix the easy rule violations with `composer fix`
..

phpcs: Fix the easy rule violations with `composer fix`

* Generic.Functions.FunctionCallArgumentSpacing.NoSpaceAfterComma
* Generic.Functions.FunctionCallArgumentSpacing.SpaceBeforeComma
* Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine
* Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
* MediaWiki.ControlStructures.IfElseStructure.SpaceAfterElse
* MediaWiki.ControlStructures.IfElseStructure.SpaceBeforeElse
* MediaWiki.WhiteSpace.MultipleEmptyLines.MultipleEmptyLines
* MediaWiki.WhiteSpace.SpaceAfterControlStructure.Incorrect
* MediaWiki.WhiteSpace.SpaceyParenthesis.SingleSpaceAfterOpenParenthesis
* MediaWiki.WhiteSpace.SpaceyParenthesis.SingleSpaceBeforeCloseParenthesis
* MediaWiki.WhiteSpace.SpaceyParenthesis.SpaceBeforeOpeningParenthesis
* PSR2.ControlStructures.ElseIfDeclaration.NotAllowed
* Squiz.WhiteSpace.LanguageConstructSpacing.Incorrect
* Squiz.WhiteSpace.ScopeClosingBrace.ContentBefore
* Squiz.WhiteSpace.ScopeClosingBrace.Indent
* Squiz.WhiteSpace.SuperfluousWhitespace.EndLine

Change-Id: I85a771bffb56816e9070954b5eb4a5bc4612c45e
---
M FlaggedRevs.php
M api/FlaggedRevsApi.hooks.php
M api/actions/ApiReview.php
M api/actions/ApiReviewActivity.php
M api/actions/ApiStabilize.php
M api/reports/ApiFlagConfig.php
M api/reports/ApiQueryConfiguredPages.php
M api/reports/ApiQueryFlagged.php
M api/reports/ApiQueryOldreviewedpages.php
M api/reports/ApiQueryReviewedpages.php
M api/reports/ApiQueryUnreviewedpages.php
M backend/FRDependencyUpdate.php
M backend/FRInclusionManager.php
M backend/FlaggedRevision.php
M backend/FlaggedRevs.class.php
M backend/FlaggedRevs.hooks.php
M backend/FlaggedRevsStats.php
M business/FRGenericSubmitForm.php
M business/PageStabilityForm.php
M frontend/FlaggablePageView.php
M frontend/FlaggedRevsStableLogFormatter.php
M frontend/FlaggedRevsXML.php
M frontend/RejectConfirmationFormUI.php
M frontend/RevisionReviewFormUI.php
M frontend/specialpages/actions/RevisionReview_body.php
M frontend/specialpages/actions/Stabilization_body.php
M frontend/specialpages/reports/PendingChanges_body.php
M frontend/specialpages/reports/ProblemChanges_body.php
M frontend/specialpages/reports/QualityOversight_body.php
M frontend/specialpages/reports/StablePages_body.php
M frontend/specialpages/reports/UnreviewedPages_body.php
M maintenance/cachePendingRevs.php
M maintenance/clearCachedText.php
M maintenance/fixBug28348.php
M maintenance/flagToSemiProtect.php
M maintenance/populateRevTimestamp.php
M maintenance/pruneRevData.php
M maintenance/purgeReviewablePages.php
M maintenance/reviewAllPages.php
M maintenance/updateAutoPromote.php
M maintenance/updateQueryCache.php
M maintenance/updateStats.php
M maintenance/updateTracking.php
M phpcs.xml
M tests/FRInclusionManagerTest.php
M tests/FRParserCacheStableTest.php
M tests/FRUserActivityTest.php
M tests/FRUserCountersTest.php
M tests/FlaggablePageTest.php
49 files changed, 218 insertions(+), 259 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FlaggedRevs 
refs/changes/99/348899/1

diff --git a/FlaggedRevs.php b/FlaggedRevs.php
index ef1c008..c06f89f 100644
--- a/FlaggedRevs.php
+++ b/FlaggedRevs.php
@@ -36,7 +36,7 @@
 ];
 
 # Load global constants
-require( dirname( __FILE__ ) . '/FlaggedRevs.defines.php' );
+require ( dirname( __FILE__ ) . '/FlaggedRevs.defines.php' );
 
 # This will only distinguish "checked", "quality", and unreviewed
 # A small icon will show in the upper right hand corner
@@ -165,7 +165,7 @@
 */
 
 # Defines extra rights for advanced reviewer class (Reviewers)
-$wgGroupPermissions['reviewer']['validate']  = true;
+$wgGroupPermissions['reviewer']['validate'] = true;
 # Let this stand alone just in case...
 $wgGroupPermissions['reviewer']['review']= true;
 $wgGroupPermissions['reviewer']['autoreview']= true;
@@ -471,7 +471,7 @@
 $wgLogActionsHandlers['stable/move_stable'] = 'FlaggedRevsStableLogFormatter'; 
// move
 
 # B/C ...
-$wgLogActions['rights/erevoke']  = 'rights-editor-revoke';
+$wgLogActions['rights/erevoke'] = 'rights-editor-revoke';
 
 # AJAX functions
 $wgAjaxExportList[] = 'RevisionReview::AjaxReview';
diff --git a/api/FlaggedRevsApi.hooks.php b/api/FlaggedRevsApi.hooks.php
index 135c636..e7c8135 100644
--- a/api/FlaggedRevsApi.hooks.php
+++ b/api/FlaggedRevsApi.hooks.php
@@ -1,15 +1,15 @@
  revid => array_index of the revision
-   // we will need this later to add data to the result array 
+   // we will need this later to add data to the result array
$result = $module->getResult();
if ( defined( 'ApiResult::META_CONTENT' ) ) {
$data = (array)$result->getResultData( [ 'query', 
'pages' ], [ 'Strip' => 'all' ] );
@@ -78,7 +78,7 

[MediaWiki-commits] [Gerrit] operations/puppet[production]: icinga: wrap run-no-puppet around sync_icinga_state

[Dzahn (Code Review)]

Dzahn has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348898 )

Change subject: icinga: wrap run-no-puppet around sync_icinga_state
..


icinga: wrap run-no-puppet around sync_icinga_state

To avoid possible races with puppet runs on tegmen,
the passive Icinga server.

Bug: T163286
Change-Id: I8fe43e1d43b06ffa645b3fc9db4e469c9703400b
---
M modules/role/manifests/icinga.pp
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/modules/role/manifests/icinga.pp b/modules/role/manifests/icinga.pp
index ee78d85..7e66f78 100644
--- a/modules/role/manifests/icinga.pp
+++ b/modules/role/manifests/icinga.pp
@@ -84,7 +84,7 @@
 if $is_passive {
 cron { 'sync-icinga-state':
 minute  => '*/10',
-command => '/usr/local/sbin/sync_icinga_state >/dev/null 2>&1',
+command => '/usr/local/sbin/run-no-puppet 
/usr/local/sbin/sync_icinga_state >/dev/null 2>&1',
 }
 }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/348898
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8fe43e1d43b06ffa645b3fc9db4e469c9703400b
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 
Gerrit-Reviewer: Alexandros Kosiaris 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: Volans 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: icinga: wrap run-no-puppet around sync_icinga_state

[Dzahn (Code Review)]

Dzahn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348898 )

Change subject: icinga: wrap run-no-puppet around sync_icinga_state
..

icinga: wrap run-no-puppet around sync_icinga_state

Bug: T163286
Change-Id: I8fe43e1d43b06ffa645b3fc9db4e469c9703400b
---
M modules/role/manifests/icinga.pp
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/98/348898/1

diff --git a/modules/role/manifests/icinga.pp b/modules/role/manifests/icinga.pp
index ee78d85..7e66f78 100644
--- a/modules/role/manifests/icinga.pp
+++ b/modules/role/manifests/icinga.pp
@@ -84,7 +84,7 @@
 if $is_passive {
 cron { 'sync-icinga-state':
 minute  => '*/10',
-command => '/usr/local/sbin/sync_icinga_state >/dev/null 2>&1',
+command => '/usr/local/sbin/run-no-puppet 
/usr/local/sbin/sync_icinga_state >/dev/null 2>&1',
 }
 }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/348898
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8fe43e1d43b06ffa645b3fc9db4e469c9703400b
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[master]: phpcs: Disallow long array syntax

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348895 )

Change subject: phpcs: Disallow long array syntax
..


phpcs: Disallow long array syntax

Depends-On: I425ce273f2d38df315773a4b9ff816955e1f8e78
Change-Id: I616813063477425fa8ef2afb1ef90af5e4cf6b45
---
M phpcs.xml
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  Krinkle: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/phpcs.xml b/phpcs.xml
index 9d0cfa4..dc443ff 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -5,9 +5,6 @@


vendor
-
-0
-
 
 0
 

-- 
To view, visit https://gerrit.wikimedia.org/r/348895
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I616813063477425fa8ef2afb1ef90af5e4cf6b45
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/FlaggedRevs
Gerrit-Branch: master
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[master]: build: Use composer to lint PHP and assert code style

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348894 )

Change subject: build: Use composer to lint PHP and assert code style
..


build: Use composer to lint PHP and assert code style

Change-Id: Id16b6f8bcc519e147d51612a5ef7226c790d5279
---
A composer.json
A phpcs.xml
2 files changed, 104 insertions(+), 0 deletions(-)

Approvals:
  Krinkle: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.json b/composer.json
new file mode 100644
index 000..4653c05
--- /dev/null
+++ b/composer.json
@@ -0,0 +1,15 @@
+{
+   "require-dev": {
+   "jakub-onderka/php-parallel-lint": "0.9.2",
+   "mediawiki/mediawiki-codesniffer": "0.7.2"
+   },
+   "scripts": {
+   "test": [
+   "parallel-lint . --exclude vendor",
+   "phpcs -p -s"
+   ],
+   "fix": [
+   "phpcbf"
+   ]
+   }
+}
diff --git a/phpcs.xml b/phpcs.xml
new file mode 100644
index 000..9d0cfa4
--- /dev/null
+++ b/phpcs.xml
@@ -0,0 +1,89 @@
+
+
+   
+   .
+   
+   
+   vendor
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+   
+   0
+   
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+

-- 
To view, visit https://gerrit.wikimedia.org/r/348894
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id16b6f8bcc519e147d51612a5ef7226c790d5279
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FlaggedRevs
Gerrit-Branch: master
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/config[master]: [FlaggedRevs] Add composer-test template

[Krinkle (Code Review)]

Krinkle has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348896 )

Change subject: [FlaggedRevs] Add composer-test template
..


[FlaggedRevs] Add composer-test template

Bug: T163301
Change-Id: I9d39660344dc939af8f45706871901e1f260377d
---
M zuul/layout.yaml
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Krinkle: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index 55f60a2..3277bd8 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -3379,6 +3379,7 @@
   - name: mediawiki/extensions/FlaggedRevs
 template:
   - name: extension-unittests-generic
+  - name: composer-test
   - name: npm
 check:
   - jsonlint

-- 
To view, visit https://gerrit.wikimedia.org/r/348896
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9d39660344dc939af8f45706871901e1f260377d
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[master]: Convert PHP syntax from array() to []

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348800 )

Change subject: Convert PHP syntax from array() to []
..


Convert PHP syntax from array() to []

Performed using:
find . -name \*.php -exec php ~/convert.php -w "{}" \;

Script from:
https://github.com/thomasbachem/php-short-array-syntax-converter

And convert syntax in comments manually.

Change-Id: I425ce273f2d38df315773a4b9ff816955e1f8e78
---
M FlaggedRevs.php
M FlaggedRevs.setup.php
M api/FlaggedRevsApi.hooks.php
M api/actions/ApiReview.php
M api/actions/ApiReviewActivity.php
M api/actions/ApiStabilize.php
M api/reports/ApiFlagConfig.php
M api/reports/ApiQueryConfiguredPages.php
M api/reports/ApiQueryFlagged.php
M api/reports/ApiQueryOldreviewedpages.php
M api/reports/ApiQueryReviewedpages.php
M api/reports/ApiQueryUnreviewedpages.php
M backend/FRDependencyUpdate.php
M backend/FRExtraCacheUpdate.php
M backend/FRExtraCacheUpdateJob.php
M backend/FRInclusionCache.php
M backend/FRInclusionManager.php
M backend/FRPageConfig.php
M backend/FRUserActivity.php
M backend/FRUserCounters.php
M backend/FlaggableWikiPage.php
M backend/FlaggedRevision.php
M backend/FlaggedRevs.class.php
M backend/FlaggedRevs.hooks.php
M backend/FlaggedRevsLog.php
M backend/FlaggedRevsStats.php
M backend/schema/FlaggedRevsUpdater.hooks.php
M business/FRGenericSubmitForm.php
M business/PageStabilityForm.php
M business/RevisionReviewForm.php
M frontend/FlaggablePageView.php
M frontend/FlaggedRevsReviewLogFormatter.php
M frontend/FlaggedRevsStableLogFormatter.php
M frontend/FlaggedRevsUI.hooks.php
M frontend/FlaggedRevsXML.php
M frontend/RejectConfirmationFormUI.php
M frontend/RevisionReviewFormUI.php
M frontend/language/ConfiguredPages.i18n.php
M frontend/language/FlaggedRevs.alias.php
M frontend/language/FlaggedRevs.i18n.magic.php
M frontend/language/FlaggedRevs.i18n.php
M frontend/language/PendingChanges.i18n.php
M frontend/language/ProblemChanges.i18n.php
M frontend/language/QualityOversight.i18n.php
M frontend/language/ReviewedPages.i18n.php
M frontend/language/ReviewedVersions.i18n.php
M frontend/language/RevisionReview.i18n.php
M frontend/language/Stabilization.i18n.php
M frontend/language/StablePages.i18n.php
M frontend/language/UnreviewedPages.i18n.php
M frontend/language/ValidationStatistics.i18n.php
M frontend/specialpages/actions/Stabilization_body.php
M frontend/specialpages/reports/ConfiguredPages_body.php
M frontend/specialpages/reports/PendingChanges_body.php
M frontend/specialpages/reports/ProblemChanges_body.php
M frontend/specialpages/reports/QualityOversight_body.php
M frontend/specialpages/reports/ReviewedPages_body.php
M frontend/specialpages/reports/ReviewedVersions_body.php
M frontend/specialpages/reports/StablePages_body.php
M frontend/specialpages/reports/UnreviewedPages_body.php
M frontend/specialpages/reports/ValidationStatistics_body.php
M maintenance/cachePendingRevs.php
M maintenance/clearCachedText.php
M maintenance/fixBug28348.php
M maintenance/flagToSemiProtect.php
M maintenance/populateRevTimestamp.php
M maintenance/pruneRevData.php
M maintenance/purgeReviewablePages.php
M maintenance/reviewAllPages.php
M maintenance/updateAutoPromote.php
M maintenance/updateTracking.php
M scribunto/FlaggedRevs.library.php
M tests/FRInclusionManagerTest.php
M tests/FRUserActivityTest.php
M tests/FRUserCountersTest.php
M tests/FlaggedRevsLibraryTest.php
76 files changed, 2,145 insertions(+), 2,145 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved




-- 
To view, visit https://gerrit.wikimedia.org/r/348800
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I425ce273f2d38df315773a4b9ff816955e1f8e78
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FlaggedRevs
Gerrit-Branch: master
Gerrit-Owner: Fomafix 
Gerrit-Reviewer: Jackmcbarn 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: tox.ini: Don't use pydocstyle 2.0.0

[Dalba (Code Review)]

Dalba has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348897 )

Change subject: tox.ini: Don't use pydocstyle 2.0.0
..

tox.ini: Don't use pydocstyle 2.0.0

pydocstyle 2.0.0 is not compatible with flake8-docstrings.

Bug: T163293
Change-Id: Ibf2996dfed11b30ac11aa55b629f15ba83d282ea
---
M tox.ini
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/97/348897/1

diff --git a/tox.ini b/tox.ini
index 513d5cc..d702afe 100644
--- a/tox.ini
+++ b/tox.ini
@@ -52,7 +52,7 @@
 basepython = python2.7
 deps = flake8<3
pyflakes >= 1.1
-   pydocstyle != 1.1.0
+   pydocstyle != 2.0.0
hacking
flake8-docstrings>=0.2.6
flake8-putty>=0.3.2

-- 
To view, visit https://gerrit.wikimedia.org/r/348897
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibf2996dfed11b30ac11aa55b629f15ba83d282ea
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Dalba 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/config[master]: [FlaggedRevs] Add composer-test template

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348896 )

Change subject: [FlaggedRevs] Add composer-test template
..

[FlaggedRevs] Add composer-test template

Bug: T163301
Change-Id: I9d39660344dc939af8f45706871901e1f260377d
---
M zuul/layout.yaml
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/96/348896/1

diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index 55f60a2..3277bd8 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -3379,6 +3379,7 @@
   - name: mediawiki/extensions/FlaggedRevs
 template:
   - name: extension-unittests-generic
+  - name: composer-test
   - name: npm
 check:
   - jsonlint

-- 
To view, visit https://gerrit.wikimedia.org/r/348896
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9d39660344dc939af8f45706871901e1f260377d
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[master]: phpcs: Disallow long array syntax

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348895 )

Change subject: phpcs: Disallow long array syntax
..

phpcs: Disallow long array syntax

Change-Id: I616813063477425fa8ef2afb1ef90af5e4cf6b45
---
M phpcs.xml
1 file changed, 0 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FlaggedRevs 
refs/changes/95/348895/1

diff --git a/phpcs.xml b/phpcs.xml
index 9d0cfa4..dc443ff 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -5,9 +5,6 @@


vendor
-
-0
-
 
 0
 

-- 
To view, visit https://gerrit.wikimedia.org/r/348895
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I616813063477425fa8ef2afb1ef90af5e4cf6b45
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FlaggedRevs
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[master]: build: Use composer to lint PHP and assert code style

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348894 )

Change subject: build: Use composer to lint PHP and assert code style
..

build: Use composer to lint PHP and assert code style

Change-Id: Id16b6f8bcc519e147d51612a5ef7226c790d5279
---
A composer.json
A phpcs.xml
2 files changed, 104 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FlaggedRevs 
refs/changes/94/348894/1

diff --git a/composer.json b/composer.json
new file mode 100644
index 000..4653c05
--- /dev/null
+++ b/composer.json
@@ -0,0 +1,15 @@
+{
+   "require-dev": {
+   "jakub-onderka/php-parallel-lint": "0.9.2",
+   "mediawiki/mediawiki-codesniffer": "0.7.2"
+   },
+   "scripts": {
+   "test": [
+   "parallel-lint . --exclude vendor",
+   "phpcs -p -s"
+   ],
+   "fix": [
+   "phpcbf"
+   ]
+   }
+}
diff --git a/phpcs.xml b/phpcs.xml
new file mode 100644
index 000..9d0cfa4
--- /dev/null
+++ b/phpcs.xml
@@ -0,0 +1,89 @@
+
+
+   
+   .
+   
+   
+   vendor
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+   
+   0
+   
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+

-- 
To view, visit https://gerrit.wikimedia.org/r/348894
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id16b6f8bcc519e147d51612a5ef7226c790d5279
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FlaggedRevs
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Keystone: Kill off novaobserver and novaadmin tokens after ...

[Andrew Bogott (Code Review)]

Andrew Bogott has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348862 )

Change subject: Keystone:  Kill off novaobserver and novaadmin tokens after 2+ 
hours.
..


Keystone:  Kill off novaobserver and novaadmin tokens after 2+ hours.

This is a bit horrifying but should improve keystone performance
dramatically.

Bug: T163259
Change-Id: I63be6533b30db03d648fd54c9136c919aa6ac91a
---
M modules/openstack/manifests/keystone/service.pp
1 file changed, 29 insertions(+), 0 deletions(-)

Approvals:
  Andrew Bogott: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/openstack/manifests/keystone/service.pp 
b/modules/openstack/manifests/keystone/service.pp
index e696359..cf08801 100644
--- a/modules/openstack/manifests/keystone/service.pp
+++ b/modules/openstack/manifests/keystone/service.pp
@@ -103,6 +103,35 @@
 command => '/usr/bin/keystone-manage token_flush > /dev/null 
2>&1',
 }
 
+# Clean up service user tokens.  These tend to pile up
+#  quickly, and are never used for Horizon sessions.
+#  so, don't wait for them to expire, just delete them
+#  after a few hours.
+#
+# Tokens only know when they expire and not when they
+#  were created.  Since token lifespan is 7.1
+#  days (613440 seconds), any token that expires
+#  less than 7 days from now is already at least
+#  2 hours old.
+$keystone_db_name = $keystoneconfig['db_name']
+$keystone_db_user = $keystoneconfig['db_user']
+$keystone_db_pass = $keystoneconfig['db_pass']
+$keystone_db_host = $keystoneconfig['db_host']
+cron {
+'cleanup_novaobserver_keystone_tokens':
+ensure  => present,
+user=> 'root',
+minute  => 30,
+command => "/usr/bin/mysql ${keystone_db_name} 
-h${keystone_db_host} -u${keystone_db_user} -p${keystone_db_pass} -e 'DELETE 
FROM token WHERE user_id=\"novaobserver\" AND NOW() + INTERVAL 7 day > expires 
LIMIT 1;'",
+}
+cron {
+'cleanup_novaadmin_keystone_tokens':
+ensure  => present,
+user=> 'root',
+minute  => 40,
+command => "/usr/bin/mysql ${keystone_db_name} 
-h${keystone_db_host} -u${keystone_db_user} -p${keystone_db_pass} -e 'DELETE 
FROM token WHERE user_id=\"novaadmin\" AND NOW() + INTERVAL 7 day > expires 
LIMIT 1;'",
+}
+
 monitoring::service { 'keystone-http-35357':
 description   => 'keystone http',
 check_command => 'check_http_on_port!35357',

-- 
To view, visit https://gerrit.wikimedia.org/r/348862
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I63be6533b30db03d648fd54c9136c919aa6ac91a
Gerrit-PatchSet: 6
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Andrew Bogott 
Gerrit-Reviewer: Andrew Bogott 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: MediaWiki theme: Fix IE 7 oversized buttons

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348442 )

Change subject: MediaWiki theme: Fix IE 7 oversized buttons
..


MediaWiki theme: Fix IE 7 oversized buttons

Fixing IE 7 wrong, oversized rendering due to false `min-height`
interpretation. Rely only on `padding` with unchanged calculation result.

Bug: T124905
Change-Id: I8420c088339ccfe0b7b4b6f921a8488a87dcc7ca
---
M src/themes/mediawiki/common.less
M src/themes/mediawiki/elements.less
2 files changed, 14 insertions(+), 2 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/src/themes/mediawiki/common.less b/src/themes/mediawiki/common.less
index 8b51404..49cf417 100644
--- a/src/themes/mediawiki/common.less
+++ b/src/themes/mediawiki/common.less
@@ -131,6 +131,7 @@
 @padding-horizontal-input-text: 8 / @oo-ui-font-size-browser / 
@oo-ui-font-size-default;
 @padding-vertical-label: 4 / @oo-ui-font-size-browser / 
@oo-ui-font-size-default; // equals `0.3125em`≈`4px`
 @padding-top-default: 8 / @oo-ui-font-size-browser / @oo-ui-font-size-default; 
// equals `0.625em`≈`8px`
+@padding-top-icon-indicator: 30 / @oo-ui-font-size-browser / 
@oo-ui-font-size-default;
 @padding-top-menu: 9 / @oo-ui-font-size-browser / @oo-ui-font-size-default;
 @padding-bottom-default: 7 / @oo-ui-font-size-browser / 
@oo-ui-font-size-default; // equals `0.547em`≈`7px`
 @padding-bottom-menu: 8 / @oo-ui-font-size-browser / @oo-ui-font-size-default;
diff --git a/src/themes/mediawiki/elements.less 
b/src/themes/mediawiki/elements.less
index 008f86b..ff51236 100644
--- a/src/themes/mediawiki/elements.less
+++ b/src/themes/mediawiki/elements.less
@@ -211,14 +211,16 @@
 
&-framed {
> .oo-ui-buttonElement-button {
-   min-height: @min-height-widget-default;
border-radius: @border-radius-default;
-   padding: @padding-default;
+   padding-left: @padding-horizontal-default;
+   padding-right: @padding-horizontal-default;
}
 
&.oo-ui-iconElement {
// Icon (-only) framed
> .oo-ui-buttonElement-button {
+   padding-top: @padding-top-icon-indicator;
+   padding-bottom: 0;
padding-left: @padding-start-icon-only;
 
> .oo-ui-iconElement-icon {
@@ -242,7 +244,9 @@
&.oo-ui-indicatorElement {
// Indicator (-only) framed
> .oo-ui-buttonElement-button {
+   padding-top: @padding-top-icon-indicator;
padding-right: @padding-start-indicator-only;
+   padding-bottom: 0;
 
> .oo-ui-indicatorElement-indicator {
right: @start-framed-indicator-only;
@@ -258,6 +262,13 @@
}
}
 
+   &.oo-ui-labelElement {
+   > .oo-ui-buttonElement-button {
+   padding-top: @padding-top-default;
+   padding-bottom: @padding-bottom-default;
+   }
+   }
+
&.oo-ui-widget-disabled {
> .oo-ui-buttonElement-button {
background-color: 
@background-color-disabled-filled;

-- 
To view, visit https://gerrit.wikimedia.org/r/348442
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8420c088339ccfe0b7b4b6f921a8488a87dcc7ca
Gerrit-PatchSet: 3
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Prtksxna 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Revert "deployment: sync home dirs from mira to naos"

[Dzahn (Code Review)]

Dzahn has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348892 )

Change subject: Revert "deployment: sync home dirs from mira to naos"
..


Revert "deployment: sync home dirs from mira to naos"

This reverts commit d91272a19628b4d2e375cd92de8bbe5c69f24ac3.

Change-Id: I450ac26a15d2591e24e6dff171ef045757c81f1c
---
M manifests/site.pp
D modules/role/manifests/deployment/migrate.pp
2 files changed, 1 insertion(+), 29 deletions(-)

Approvals:
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/manifests/site.pp b/manifests/site.pp
index 2115734..e0efeb0 100644
--- a/manifests/site.pp
+++ b/manifests/site.pp
@@ -2682,17 +2682,8 @@
 }
 
 # deployment servers
-node 'tin.eqiad.wmnet', 'mira.codfw.wmnet' {
+node 'tin.eqiad.wmnet', 'mira.codfw.wmnet', 'naos.codfw.wmnet' {
 role(deployment::server)
-include ::base::firewall
-
-interface::add_ip6_mapped { 'main':
-interface => 'eth0',
-}
-}
-
-node 'naos.codfw.wmnet' {
-role(deployment::server, deployment::migrate)
 include ::base::firewall
 
 interface::add_ip6_mapped { 'main':
diff --git a/modules/role/manifests/deployment/migrate.pp 
b/modules/role/manifests/deployment/migrate.pp
deleted file mode 100644
index 559329c..000
--- a/modules/role/manifests/deployment/migrate.pp
+++ /dev/null
@@ -1,19 +0,0 @@
-class role::deployment::migrate {
-
-$sourceip='10.192.16.132'
-
-ferm::service { 'deployment-migration-rsync':
-proto  => 'tcp',
-port   => '873',
-srange => "${sourceip}/32",
-}
-
-include rsync::server
-
-rsync::server::module { 'deployment-home':
-path=> '/home',
-read_only   => 'no',
-hosts_allow => $sourceip,
-}
-
-}

-- 
To view, visit https://gerrit.wikimedia.org/r/348892
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I450ac26a15d2591e24e6dff171ef045757c81f1c
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: Filippo Giunchedi 
Gerrit-Reviewer: RobH 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Interwiki map update

[Krinkle (Code Review)]

Krinkle has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348893 )

Change subject: Interwiki map update
..

Interwiki map update

Changes since last sync:

- wikilivres: Use HTTPS
- prefer "wikitech:" over "labsconsole:" (for Parsoid)
- prefer "mw:" over "mediawikiwiki:" (for Parsoid)

Bug: T145337
Change-Id: Ife88cd2c362e3d59dfe2212794326cf3c360f48b
---
M wmf-config/interwiki.php
1 file changed, 6 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/93/348893/1

diff --git a/wmf-config/interwiki.php b/wmf-config/interwiki.php
index 5ab5aca..1c57000 100644
--- a/wmf-config/interwiki.php
+++ b/wmf-config/interwiki.php
@@ -1,5 +1,5 @@
  '0 
http://www.acronymfinder.com/af-query.asp?String=exact=$1',
'__global:advisory' => '1 https://advisory.wikimedia.org/wiki/$1',
@@ -154,7 +154,7 @@
'__global:komicawiki' => '0 http://wiki.komica.org/wiki3/?$1',
'__global:kontuwiki' => '0 http://kontu.wiki/$1',
'__global:koslarwiki' => '0 http://wiki.koslar.de/index.php/$1',
-   '__global:labsconsole' => '1 https://wikitech.wikimedia.org/wiki/$1',
+   '__global:wikitech' => '1 https://wikitech.wikimedia.org/wiki/$1',
'__global:libreplanet' => '0 //libreplanet.org/wiki/$1',
'__global:linguistlist' => '0 
//linguistlist.org/forms/langs/LLDescription.cfm?code=$1',
'__global:linuxwiki' => '0 http://www.linuxwiki.de/$1',
@@ -172,7 +172,7 @@
'__global:mariowiki' => '0 http://www.mariowiki.com/$1',
'__global:marveldatabase' => '0 
http://www.marveldatabase.com/wiki/index.php/$1',
'__global:meatball' => '0 http://meatballwiki.org/wiki/$1',
-   '__global:mediawikiwiki' => '1 https://www.mediawiki.org/wiki/$1',
+   '__global:mw' => '1 https://www.mediawiki.org/wiki/$1',
'__global:mediazilla' => '1 https://bugzilla.wikimedia.org/$1',
'__global:memoryalpha' => '0 http://memory-alpha.org/wiki/$1',
'__global:metawiki' => '1 https://meta.wikimedia.org/wiki/$1',
@@ -187,7 +187,7 @@
'__global:mozillawiki' => '0 https://wiki.mozilla.org/$1',
'__global:mozillazinekb' => '0 http://kb.mozillazine.org/$1',
'__global:musicbrainz' => '0 http://musicbrainz.org/doc/$1',
-   '__global:mw' => '1 https://www.mediawiki.org/wiki/$1',
+   '__global:mediawikiwiki' => '1 https://www.mediawiki.org/wiki/$1',
'__global:mwod' => '0 
http://www.merriam-webster.com/cgi-bin/dictionary?book=Dictionary=$1',
'__global:mwot' => '0 
http://www.merriam-webster.com/cgi-bin/thesaurus?book=Thesaurus=$1',
'__global:nkcells' => '0 http://www.nkcells.info/index.php?title=$1',
@@ -323,7 +323,7 @@
'__global:wikihow' => '0 http://www.wikihow.com/$1',
'__global:wikiindex' => '0 http://wikiindex.org/$1',
'__global:wikilemon' => '0 http://wiki.illemonati.com/$1',
-   '__global:wikilivres' => '0 http://wikilivres.ca/wiki/$1',
+   '__global:wikilivres' => '0 https://wikilivres.ca/wiki/$1',
'__global:wikilivresru' => '0 http://wikilivres.ru/$1',
'__global:wikimac-de' => '0 http://apfelwiki.de/wiki/Main/$1',
'__global:wikimedia' => '1 https://wikimediafoundation.org/wiki/$1',
@@ -340,7 +340,7 @@
'__global:wikispecies' => '1 https://species.wikimedia.org/wiki/$1',
'__global:wikispot' => '0 
http://wikispot.org/?action=gotowikipage=$1',
'__global:wikiskripta' => '0 http://www.wikiskripta.eu/index.php/$1',
-   '__global:wikitech' => '1 https://wikitech.wikimedia.org/wiki/$1',
+   '__global:labsconsole' => '1 https://wikitech.wikimedia.org/wiki/$1',
'__global:wikiti' => '0 http://wikiti.denglend.net/index.php?title=$1',
'__global:wikitree' => '0 http://wikitree.org/index.php?title=$1',
'__global:wikiversity' => '1 https://en.wikiversity.org/wiki/$1',

-- 
To view, visit https://gerrit.wikimedia.org/r/348893
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife88cd2c362e3d59dfe2212794326cf3c360f48b
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Krinkle 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Revert "deployment: sync home dirs from mira to naos"

[Dzahn (Code Review)]

Hello RobH, jenkins-bot, Filippo Giunchedi,

I'd like you to do a code review.  Please visit

https://gerrit.wikimedia.org/r/348892

to review the following change.


Change subject: Revert "deployment: sync home dirs from mira to naos"
..

Revert "deployment: sync home dirs from mira to naos"

This reverts commit d91272a19628b4d2e375cd92de8bbe5c69f24ac3.

Change-Id: I450ac26a15d2591e24e6dff171ef045757c81f1c
---
M manifests/site.pp
D modules/role/manifests/deployment/migrate.pp
2 files changed, 1 insertion(+), 29 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/92/348892/1

diff --git a/manifests/site.pp b/manifests/site.pp
index 2115734..e0efeb0 100644
--- a/manifests/site.pp
+++ b/manifests/site.pp
@@ -2682,17 +2682,8 @@
 }
 
 # deployment servers
-node 'tin.eqiad.wmnet', 'mira.codfw.wmnet' {
+node 'tin.eqiad.wmnet', 'mira.codfw.wmnet', 'naos.codfw.wmnet' {
 role(deployment::server)
-include ::base::firewall
-
-interface::add_ip6_mapped { 'main':
-interface => 'eth0',
-}
-}
-
-node 'naos.codfw.wmnet' {
-role(deployment::server, deployment::migrate)
 include ::base::firewall
 
 interface::add_ip6_mapped { 'main':
diff --git a/modules/role/manifests/deployment/migrate.pp 
b/modules/role/manifests/deployment/migrate.pp
deleted file mode 100644
index 559329c..000
--- a/modules/role/manifests/deployment/migrate.pp
+++ /dev/null
@@ -1,19 +0,0 @@
-class role::deployment::migrate {
-
-$sourceip='10.192.16.132'
-
-ferm::service { 'deployment-migration-rsync':
-proto  => 'tcp',
-port   => '873',
-srange => "${sourceip}/32",
-}
-
-include rsync::server
-
-rsync::server::module { 'deployment-home':
-path=> '/home',
-read_only   => 'no',
-hosts_allow => $sourceip,
-}
-
-}

-- 
To view, visit https://gerrit.wikimedia.org/r/348892
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I450ac26a15d2591e24e6dff171ef045757c81f1c
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 
Gerrit-Reviewer: Filippo Giunchedi 
Gerrit-Reviewer: RobH 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...RevisionSlider[master]: Revert "Temporary workaround for OOjs UI missing border bug"

[Jforrester (Code Review)]

Hello Addshore, Tobias Gritschacher, WMDE-Fisch, jenkins-bot, Andrew-WMDE,

I'd like you to do a code review.  Please visit

https://gerrit.wikimedia.org/r/348891

to review the following change.


Change subject: Revert "Temporary workaround for OOjs UI missing border bug"
..

Revert "Temporary workaround for OOjs UI missing border bug"

This reverts commit 33aea27e94d03c91e54c1a06eed4c870c694cd7e.

Sorry, I lied; we decided to release v0.21.1 anyway, which is now merged into 
master.

Change-Id: I791c814b33d17016d51f859948623b0bcc982f9c
---
M modules/ext.RevisionSlider.lazy.css
1 file changed, 0 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/RevisionSlider 
refs/changes/91/348891/1

diff --git a/modules/ext.RevisionSlider.lazy.css 
b/modules/ext.RevisionSlider.lazy.css
index 10d28f6..cda8428 100644
--- a/modules/ext.RevisionSlider.lazy.css
+++ b/modules/ext.RevisionSlider.lazy.css
@@ -45,8 +45,3 @@
 .mw-revslider-toggle-button .oo-ui-labelElement-label {
line-height: 1.875em;
 }
-
-/* can be removed when OOjs UI v0.21.1 is put into core master */
-.mw-revslider-toggle-button > .oo-ui-buttonElement-button {
-   margin-left: 0 !important;  /* stylelint-disable-line 
declaration-no-important */
-}

-- 
To view, visit https://gerrit.wikimedia.org/r/348891
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I791c814b33d17016d51f859948623b0bcc982f9c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: master
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Addshore 
Gerrit-Reviewer: Andrew-WMDE 
Gerrit-Reviewer: Tobias Gritschacher 
Gerrit-Reviewer: WMDE-Fisch 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: build: Use source maps in coverage report

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348890 )

Change subject: build: Use source maps in coverage report
..

build: Use source maps in coverage report

Shamelessly stolen from I0939c217146e5ee95e555435240a7f1e371b901d
by Timo, who worked out how to do this.

Change-Id: Ibbc64b0c07f7051bb3baf5ba48a5d70c5e5365c0
---
M Gruntfile.js
M package.json
2 files changed, 19 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/90/348890/1

diff --git a/Gruntfile.js b/Gruntfile.js
index 8613382..e1a979d 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -201,6 +201,7 @@
build: 'dist/*',
demos: 
'demos/{composer.json,composer.lock,node_modules,dist,php,vendor}',
tests: 'tests/{JSPHP-suite.json,JSPHP.test.js}',
+   coverage: 'coverage/*',
doc: 'docs/*',
tmp: 'dist/tmp'
},
@@ -216,7 +217,8 @@
},
concat: {
options: {
-   banner: grunt.file.read( 'build/banner.txt' )
+   banner: grunt.file.read( 'build/banner.txt' ),
+   sourceMap: true
},
js: {
files: concatJsFiles
@@ -232,7 +234,8 @@
},
demoCss: {
options: {
-   banner: '/** This file is generated 
automatically. Do not modify it. */\n\n'
+   banner: '/** This file is generated 
automatically. Do not modify it. */\n\n',
+   sourceMap: false
},
files: {
'demos/styles/demo.rtl.css': 
'demos/styles/demo.rtl.css'
@@ -407,7 +410,10 @@
'tests/QUnit.assert.equalDomElement.js',
'node_modules/jquery/dist/jquery.js',
'node_modules/oojs/dist/oojs.jquery.js',
-   'dist/oojs-ui.js',
+   'dist/oojs-ui-core.js',
+   'dist/oojs-ui-widgets.js',
+   'dist/oojs-ui-windows.js',
+   'dist/oojs-ui-toolbars.js',
'dist/oojs-ui-apex.js',
'dist/oojs-ui-mediawiki.js',
'tests/TestTimer.js',
@@ -430,11 +436,14 @@
preprocessors: {
'dist/*.js': [ 'coverage' ]
},
-   reporters: [ 'dots', 'coverage' ],
-   coverageReporter: { reporters: [
-   { type: 'html', dir: 'coverage/' },
-   { type: 'text-summary', dir: 
'coverage/' }
-   ] }
+   reporters: [ 'dots', 'coverage', 
'karma-remap-istanbul' ],
+   coverageReporter: { type: 'in-memory' },
+   remapIstanbulReporter: {
+   reports: {
+   'text-summary': null,
+   html: 'coverage/'
+   }
+   }
},
other: {
browsers: [ 'Firefox' ]
@@ -615,7 +624,7 @@
// Run this before opening "tests/index.php"
grunt.registerTask( 'prep-test', [ 'lint', 'git-build', 'build-tests' ] 
);
 
-   grunt.registerTask( '_test', [ 'prep-test', 'karma:main', 'karma:other' 
] );
+   grunt.registerTask( '_test', [ 'prep-test', 'clean:coverage', 
'karma:main', 'karma:other' ] );
grunt.registerTask( '_ci', [ '_test', 'minify', 'demos', 
'exec:composer' ] );
grunt.registerTask( 'demos', [ 'clean:demos', 'copy:demos', 
'exec:demos' ] );
 
diff --git a/package.json b/package.json
index 6ac8d60..6435c72 100644
--- a/package.json
+++ b/package.json
@@ -53,6 +53,7 @@
 "karma-coverage": "1.1.0",
 "karma-firefox-launcher": "1.0.0",
 "karma-qunit": "1.1.0",
+   "karma-remap-istanbul": "0.6.0",
 "q": "1.4.1",
 "qunitjs": "1.22.0",
 "stylelint-config-wikimedia": "0.4.1"

-- 
To view, visit https://gerrit.wikimedia.org/r/348890
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: 

[MediaWiki-commits] [Gerrit] operations/puppet[production]: l10nupdate: Ensure a default uid of 10002

[Dzahn (Code Review)]

Dzahn has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348884 )

Change subject: l10nupdate: Ensure a default uid of 10002
..


l10nupdate: Ensure a default uid of 10002

While we're here, make it depend on Group['l10nupdate'] since it
needs to exist before setting our gid to it

Change-Id: If8b2a16bb82b1753e95c9743f35c248c19db0c70
---
M modules/scap/manifests/l10nupdate.pp
1 file changed, 6 insertions(+), 4 deletions(-)

Approvals:
  Chad: Looks good to me, but someone else must approve
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/modules/scap/manifests/l10nupdate.pp 
b/modules/scap/manifests/l10nupdate.pp
index 8853fa2..83f709d 100644
--- a/modules/scap/manifests/l10nupdate.pp
+++ b/modules/scap/manifests/l10nupdate.pp
@@ -29,10 +29,12 @@
 }
 
 user { 'l10nupdate':
-ensure => present,
-gid=> 10002,
-shell  => '/bin/bash',
-home   => '/home/l10nupdate',
+ensure  => present,
+uid => 10002,
+gid => 10002,
+shell   => '/bin/bash',
+home=> '/home/l10nupdate',
+require => Group['l10nupdate'],
 }
 
 # Explicitly provision the l10nupdate user's home directory. In Labs the

-- 
To view, visit https://gerrit.wikimedia.org/r/348884
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If8b2a16bb82b1753e95c9743f35c248c19db0c70
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Chad 
Gerrit-Reviewer: Chad 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: Filippo Giunchedi 
Gerrit-Reviewer: RobH 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: deployment: sync home dirs from mira to naos

[Dzahn (Code Review)]

Dzahn has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348886 )

Change subject: deployment: sync home dirs from mira to naos
..


deployment: sync home dirs from mira to naos

This is a temp change to sync home dirs from mira to naos.

Will be reverted after migration.

Bug: T162900
Change-Id: I63b5b69610972ad57b199822c84c9c255625e823
---
M manifests/site.pp
A modules/role/manifests/deployment/migrate.pp
2 files changed, 29 insertions(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/manifests/site.pp b/manifests/site.pp
index e0efeb0..2115734 100644
--- a/manifests/site.pp
+++ b/manifests/site.pp
@@ -2682,7 +2682,7 @@
 }
 
 # deployment servers
-node 'tin.eqiad.wmnet', 'mira.codfw.wmnet', 'naos.codfw.wmnet' {
+node 'tin.eqiad.wmnet', 'mira.codfw.wmnet' {
 role(deployment::server)
 include ::base::firewall
 
@@ -2691,6 +2691,15 @@
 }
 }
 
+node 'naos.codfw.wmnet' {
+role(deployment::server, deployment::migrate)
+include ::base::firewall
+
+interface::add_ip6_mapped { 'main':
+interface => 'eth0',
+}
+}
+
 # test system for performance team (T117888)
 node 'tungsten.eqiad.wmnet' {
 role(test::system, xhgui::app)
diff --git a/modules/role/manifests/deployment/migrate.pp 
b/modules/role/manifests/deployment/migrate.pp
new file mode 100644
index 000..559329c
--- /dev/null
+++ b/modules/role/manifests/deployment/migrate.pp
@@ -0,0 +1,19 @@
+class role::deployment::migrate {
+
+$sourceip='10.192.16.132'
+
+ferm::service { 'deployment-migration-rsync':
+proto  => 'tcp',
+port   => '873',
+srange => "${sourceip}/32",
+}
+
+include rsync::server
+
+rsync::server::module { 'deployment-home':
+path=> '/home',
+read_only   => 'no',
+hosts_allow => $sourceip,
+}
+
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/348886
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I63b5b69610972ad57b199822c84c9c255625e823
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: RobH 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[wmf/1.29.0-wmf.20]: Add missing dependency on mediawiki.Uri

[Krinkle (Code Review)]

Krinkle has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348889 )

Change subject: Add missing dependency on mediawiki.Uri
..

Add missing dependency on mediawiki.Uri

Change-Id: Ifaf2b6076297de94145fd78f37ad0433618ba0fc
(cherry picked from commit fe2aca46f4e206bfec2b903aa896e7876e079258)
---
M extension.json
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaEvents 
refs/changes/89/348889/1

diff --git a/extension.json b/extension.json
index 996e5c4..015b995 100644
--- a/extension.json
+++ b/extension.json
@@ -183,7 +183,8 @@
"mobile"
],
"dependencies": [
-   "mediawiki.user"
+   "mediawiki.user",
+   "mediawiki.Uri"
]
}
},

-- 
To view, visit https://gerrit.wikimedia.org/r/348889
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifaf2b6076297de94145fd78f37ad0433618ba0fc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: wmf/1.29.0-wmf.20
Gerrit-Owner: Krinkle 
Gerrit-Reviewer: Catrope 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] analytics/limn-ee-data[master]: Add frwiki, hewiki, etwiki to list of RCFilters wikis

[Jforrester (Code Review)]

Jforrester has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348028 )

Change subject: Add frwiki, hewiki, etwiki to list of RCFilters wikis
..


Add frwiki, hewiki, etwiki to list of RCFilters wikis

Change-Id: I80a2fed919d31729c0cd56af8fda44a3947f9ebb
---
M ee-beta-features/rcfilters_dbs.txt
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Catrope: Looks good to me, approved
  Jforrester: Verified



diff --git a/ee-beta-features/rcfilters_dbs.txt 
b/ee-beta-features/rcfilters_dbs.txt
index 35ea5ad..952046d 100644
--- a/ee-beta-features/rcfilters_dbs.txt
+++ b/ee-beta-features/rcfilters_dbs.txt
@@ -1,9 +1,13 @@
 plwiki
 ptwiki
+frwiki
 fawiki
-nlwiki
 ruwiki
 trwiki
+nlwiki
 wikidatawiki
 cswiki
+hewiki
+etwiki
 enwiki
+dewiki

-- 
To view, visit https://gerrit.wikimedia.org/r/348028
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I80a2fed919d31729c0cd56af8fda44a3947f9ebb
Gerrit-PatchSet: 1
Gerrit-Project: analytics/limn-ee-data
Gerrit-Branch: master
Gerrit-Owner: Catrope 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[master]: Add missing dependency on mediawiki.Uri

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/34 )

Change subject: Add missing dependency on mediawiki.Uri
..


Add missing dependency on mediawiki.Uri

Change-Id: Ifaf2b6076297de94145fd78f37ad0433618ba0fc
---
M extension.json
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/extension.json b/extension.json
index ef4e921..77a27d0 100644
--- a/extension.json
+++ b/extension.json
@@ -183,7 +183,8 @@
"mobile"
],
"dependencies": [
-   "mediawiki.user"
+   "mediawiki.user",
+   "mediawiki.Uri"
]
}
},

-- 
To view, visit https://gerrit.wikimedia.org/r/34
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifaf2b6076297de94145fd78f37ad0433618ba0fc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: master
Gerrit-Owner: Catrope 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: qunit: Also clear $.timers when stopping unfinished animations

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348883 )

Change subject: qunit: Also clear $.timers when stopping unfinished animations
..


qunit: Also clear $.timers when stopping unfinished animations

Stopping the animation is essentially the same as pausing, it remains in the
animation registry and will continue to fail all subsequent tests until one
of those later tests starts the animation queue again and also happens to
wait long enough for this unrelated animation to finish.

Fix the testrunner to actually fully stop the pre-existing animations, which
requires clearing $.timers as well. This matches the logic we have for
pending ajax requests.

Bug: T163211
Change-Id: Ic7d848187bc3c800e8347e0650093b2ffce6dddc
---
M tests/qunit/data/testrunner.js
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/tests/qunit/data/testrunner.js b/tests/qunit/data/testrunner.js
index 55bd276..a947484 100644
--- a/tests/qunit/data/testrunner.js
+++ b/tests/qunit/data/testrunner.js
@@ -240,6 +240,7 @@
);
} );
// Force animations to stop to 
give the next test a clean start
+   $.timers = [];
$.fx.stop();
 
throw new Error( 'Unfinished 
animations: ' + timers );

-- 
To view, visit https://gerrit.wikimedia.org/r/348883
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic7d848187bc3c800e8347e0650093b2ffce6dddc
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[master]: Add missing dependency on mediawiki.Uri

[Catrope (Code Review)]

Catrope has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/34 )

Change subject: Add missing dependency on mediawiki.Uri
..

Add missing dependency on mediawiki.Uri

Change-Id: Ifaf2b6076297de94145fd78f37ad0433618ba0fc
---
M extension.json
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaEvents 
refs/changes/88/34/1

diff --git a/extension.json b/extension.json
index ef4e921..77a27d0 100644
--- a/extension.json
+++ b/extension.json
@@ -183,7 +183,8 @@
"mobile"
],
"dependencies": [
-   "mediawiki.user"
+   "mediawiki.user",
+   "mediawiki.Uri"
]
}
},

-- 
To view, visit https://gerrit.wikimedia.org/r/34
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifaf2b6076297de94145fd78f37ad0433618ba0fc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: master
Gerrit-Owner: Catrope 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.29.0-wmf.20]: mw.loader: Don't assume var 'loading' assigns before Promise...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348887 )

Change subject: mw.loader: Don't assume var 'loading' assigns before Promise 
resolves
..

mw.loader: Don't assume var 'loading' assigns before Promise resolves

In rare situations the variable loading already assigned with a promise and
the call to loading.map fails with

  TypeError: loading.map is not a function

Change-Id: Ie50bdda229e48b159702fc2a83e641a35d7c850c
(cherry picked from commit dd140224c850e011f9c5ea4a8763c5918d4ab566)
---
M resources/src/mediawiki/mediawiki.js
1 file changed, 5 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/87/348887/1

diff --git a/resources/src/mediawiki/mediawiki.js 
b/resources/src/mediawiki/mediawiki.js
index 86a9a0a..08807fb 100644
--- a/resources/src/mediawiki/mediawiki.js
+++ b/resources/src/mediawiki/mediawiki.js
@@ -2754,14 +2754,16 @@
 * @member mw.hook
 */
$( function () {
-   var loading = $.grep( mw.loader.getModuleNames(), function ( 
module ) {
+   var loading, modules;
+
+   modules = $.grep( mw.loader.getModuleNames(), function ( module 
) {
return mw.loader.getState( module ) === 'loading';
} );
// We only need a callback, not any actual module. First try a 
single using()
// for all loading modules. If one fails, fall back to tracking 
each module
// separately via $.when(), this is expensive.
-   loading = mw.loader.using( loading ).then( null, function () {
-   var all = loading.map( function ( module ) {
+   loading = mw.loader.using( modules ).then( null, function () {
+   var all = modules.map( function ( module ) {
return mw.loader.using( module ).then( null, 
function () {
return $.Deferred().resolve();
} );

-- 
To view, visit https://gerrit.wikimedia.org/r/348887
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie50bdda229e48b159702fc2a83e641a35d7c850c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.29.0-wmf.20
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Fomafix 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: deployment: sync home dirs from mira to naos

[Dzahn (Code Review)]

Dzahn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348886 )

Change subject: deployment: sync home dirs from mira to naos
..

deployment: sync home dirs from mira to naos

This is a temp change to sync home dirs from mira to naos.

Will be reverted after migration.

Bug: T162900
Change-Id: I63b5b69610972ad57b199822c84c9c255625e823
---
M manifests/site.pp
A modules/role/manifests/deployment/migrate.pp
2 files changed, 29 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/86/348886/1

diff --git a/manifests/site.pp b/manifests/site.pp
index e0efeb0..2115734 100644
--- a/manifests/site.pp
+++ b/manifests/site.pp
@@ -2682,7 +2682,7 @@
 }
 
 # deployment servers
-node 'tin.eqiad.wmnet', 'mira.codfw.wmnet', 'naos.codfw.wmnet' {
+node 'tin.eqiad.wmnet', 'mira.codfw.wmnet' {
 role(deployment::server)
 include ::base::firewall
 
@@ -2691,6 +2691,15 @@
 }
 }
 
+node 'naos.codfw.wmnet' {
+role(deployment::server, deployment::migrate)
+include ::base::firewall
+
+interface::add_ip6_mapped { 'main':
+interface => 'eth0',
+}
+}
+
 # test system for performance team (T117888)
 node 'tungsten.eqiad.wmnet' {
 role(test::system, xhgui::app)
diff --git a/modules/role/manifests/deployment/migrate.pp 
b/modules/role/manifests/deployment/migrate.pp
new file mode 100644
index 000..559329c
--- /dev/null
+++ b/modules/role/manifests/deployment/migrate.pp
@@ -0,0 +1,19 @@
+class role::deployment::migrate {
+
+$sourceip='10.192.16.132'
+
+ferm::service { 'deployment-migration-rsync':
+proto  => 'tcp',
+port   => '873',
+srange => "${sourceip}/32",
+}
+
+include rsync::server
+
+rsync::server::module { 'deployment-home':
+path=> '/home',
+read_only   => 'no',
+hosts_allow => $sourceip,
+}
+
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/348886
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I63b5b69610972ad57b199822c84c9c255625e823
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: toollabs: iterate bigbrother job dict values not keys

[BryanDavis (Code Review)]

BryanDavis has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348885 )

Change subject: toollabs: iterate bigbrother job dict values not keys
..

toollabs: iterate bigbrother job dict values not keys

The collection of jobs being watched for a tool is a dict, not a list,
so for loop iteration must use `.values()` to iterate the job objects.

Bug: T163265
Change-Id: Ib4332ab935b00d1d6ac8753eaab0fba1393610c9
---
M modules/toollabs/files/bigbrother.py
1 file changed, 11 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/85/348885/1

diff --git a/modules/toollabs/files/bigbrother.py 
b/modules/toollabs/files/bigbrother.py
index 7ac200f..3946d0d 100755
--- a/modules/toollabs/files/bigbrother.py
+++ b/modules/toollabs/files/bigbrother.py
@@ -171,7 +171,7 @@
 self.log_event(
 tool, 'warn',
 "Too many attempts to restart job '%s'; throttling" % 
job['name'])
-job['state'] = 'throttled'
+job['state'] = 'THROTTLED'
 job['since'] = now
 # Don't try to restart this job again until 24 hours after the
 # first restart that we remember
@@ -180,10 +180,10 @@
 
 job['restarts'].append(now)
 # Give the new job 90-120 seconds to start before trying again
-job['state'] = 'starting'
+job['state'] = 'STARTING'
 job['timeout'] = now + 90 + random.randint(0, 30)
 job['since'] = now
-self.log_event(tool, 'info', "Restarting job '%s'" % job['name'])
+self.log_event(tool, 'info', "Restarting job '%s'" % job['jname'])
 
 if not self.dry_run:
 with open(self.watchdb[tool]['logfile'], 'a') as log:
@@ -209,7 +209,7 @@
 # leave the current state alone
 continue
 # Mark as dead pending verification of state from qstat
-job['state'] = 'dead'
+job['state'] = 'DEAD'
 
 # Update the known state of all jobs from qstat data
 xml = ET.fromstring(subprocess.check_output(
@@ -251,23 +251,25 @@
 print(datetime.datetime.utcnow(), file=sb)
 for tool in self.watchdb:
 if 'jobs' not in self.watchdb[tool]:
+print('%s:-:-:-:-' % tool, file=sb)
 continue
-for job in self.watchdb[tool]['jobs']:
+for job in self.watchdb[tool]['jobs'].values():
 if 'state' not in job:
+print('%s:%s:-:-:-' % (tool, job['jname']), file=sb)
 continue
-if job['state'] == 'dead':
+if job['state'] == 'DEAD':
 self.start_job(tool, job)
-elif job['state'] in ['starting', 'throttled']:
+elif job['state'] in ['STARTING', 'THROTTLED']:
 if time.time() >= job.get('timeout', 0):
 self.log_event(
 tool, 'warn',
 "job '%s' failed to start" % job['jname'])
 self.start_job(tool, job)
 print(
-'%s:%s:%s:%d:%d' % (
+'%s:%s:%s:%s:%s' % (
 tool,
 job['jname'],
-job.get('state', 'unknown'),
+job.get('state', 'UNKNOWN'),
 job.get('since', 0),
 job.get('timeout', 0)
 ),

-- 
To view, visit https://gerrit.wikimedia.org/r/348885
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib4332ab935b00d1d6ac8753eaab0fba1393610c9
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: BryanDavis 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: tests: Enforce dm unit test coverage at 20% per file and 80%...

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/347800 )

Change subject: tests: Enforce dm unit test coverage at 20% per file and 80% 
globally
..


tests: Enforce dm unit test coverage at 20% per file and 80% globally

Change-Id: I6a95c2da3ab471339e7a9617027abbb2074dda54
---
M Gruntfile.js
1 file changed, 41 insertions(+), 1 deletion(-)

Approvals:
  Esanders: Looks good to me, but someone else must approve
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Gruntfile.js b/Gruntfile.js
index 5462266..fa14180 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -325,7 +325,47 @@
{ type: 'json-summary', dir: 
'coverage/' },
{ type: 'html', dir: 
'coverage/' },
{ type: 'text-summary', dir: 
'coverage/' }
-   ]
+   ],
+   // 
https://github.com/karma-runner/karma-coverage/blob/v1.1.1/docs/configuration.md#check
+   check: {
+   global: {
+   functions: 60,
+   branches: 60,
+   statements: 60,
+   lines: 60,
+   overrides: {
+   'src/dm/*.js': {
+   
functions: 80,
+   
branches: 80,
+   
statements: 80,
+   lines: 
80
+   },
+   
'src/dm/**/*.js': {
+   
functions: 80,
+   
branches: 80,
+   
statements: 80,
+   lines: 
80
+   }
+   }
+   },
+   each: {
+   functions: 20,
+   branches: 20,
+   statements: 20,
+   lines: 20,
+   excludes: [
+   
'src/ve.track.js',
+   
'src/init/**/*.js',
+   
'src/ce/**/*.js',
+   
'src/ui/**/*.js',
+   
'src/dm/ve.dm.SurfaceSynchronizer.js',
+   
'src/dm/ve.dm.TableSlice.js',
+   
'src/dm/annotations/ve.dm.BidiAnnotation.js',
+   
'src/dm/metaitems/ve.dm.CommentMetaItem.js',
+   
'src/dm/nodes/ve.dm.GeneratedContentNode.js'
+   ]
+   }
+   }
}
},
others: {

-- 
To view, visit https://gerrit.wikimedia.org/r/347800
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6a95c2da3ab471339e7a9617027abbb2074dda54
Gerrit-PatchSet: 3
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: Divec 
Gerrit-Reviewer: Esanders 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resourceloader: Move mwNow() to after isCompatible()

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348856 )

Change subject: resourceloader: Move mwNow() to after isCompatible()
..


resourceloader: Move mwNow() to after isCompatible()

Follows-up f2fb4a21af. This is logically still the same point in time.
Only 1 function before it now, isCompatible(), which is fine since it
is small and the variable is not used anyway if it returns false.

Change-Id: I34bbe8edf6e9625f8d80f829707adafcb1b91980
---
M resources/src/startup.js
1 file changed, 7 insertions(+), 5 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/resources/src/startup.js b/resources/src/startup.js
index ad06b34..e0df772 100644
--- a/resources/src/startup.js
+++ b/resources/src/startup.js
@@ -1,7 +1,8 @@
 /**
- * Code in this file MUST work on even the most ancient of browsers!
+ * This file is where we decide whether to initialise the Grade A run-time.
  *
- * This file is where we decide whether to initialise the modern run-time.
+ * - Beware: This file MUST parse without errors on even the most ancient of 
browsers!
+ * - Beware: Do not call mwNow before the isCompatible() check.
  */
 
 /* global mw, $VARS, $CODE */
@@ -18,9 +19,7 @@
function () { return Date.now(); };
}() ),
// eslint-disable-next-line no-unused-vars
-   mediaWikiLoadStart = mwNow();
-
-mwPerformance.mark( 'mwLoadStart' );
+   mediaWikiLoadStart;
 
 /**
  * See 
@@ -153,6 +152,9 @@
};
}
 
+   mediaWikiLoadStart = mwNow();
+   mwPerformance.mark( 'mwLoadStart' );
+
script = document.createElement( 'script' );
script.src = $VARS.baseModulesUri;
script.onload = script.onreadystatechange = function () {

-- 
To view, visit https://gerrit.wikimedia.org/r/348856
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I34bbe8edf6e9625f8d80f829707adafcb1b91980
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: actions: Conditionally dispatch ABANDON_*

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348790 )

Change subject: actions: Conditionally dispatch ABANDON_*
..


actions: Conditionally dispatch ABANDON_*

If the user CmdOrCtrl+Clicks on a link, then the link will remain
focussed. If a preview is shown, clicks another element on the page, and
then there'll be no token to include in ABANDON_* with.

Bug: T162924
Change-Id: Ie2237aa55ea9a11070498b66c73b8bf1898d8d44
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/actions.js
M tests/node-qunit/actions.test.js
4 files changed, 24 insertions(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Jdlrobson: Looks good to me, approved




-- 
To view, visit https://gerrit.wikimedia.org/r/348790
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2237aa55ea9a11070498b66c73b8bf1898d8d44
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx 
Gerrit-Reviewer: Bmansurov 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: l10nupdate: Ensure a default uid of 10002

[Chad (Code Review)]

Chad has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348884 )

Change subject: l10nupdate: Ensure a default uid of 10002
..

l10nupdate: Ensure a default uid of 10002

While we're here, make it depend on Group['l10nupdate'] since it
needs to exist before setting our gid to it

Change-Id: If8b2a16bb82b1753e95c9743f35c248c19db0c70
---
M modules/scap/manifests/l10nupdate.pp
1 file changed, 6 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/84/348884/1

diff --git a/modules/scap/manifests/l10nupdate.pp 
b/modules/scap/manifests/l10nupdate.pp
index 8853fa2..83f709d 100644
--- a/modules/scap/manifests/l10nupdate.pp
+++ b/modules/scap/manifests/l10nupdate.pp
@@ -29,10 +29,12 @@
 }
 
 user { 'l10nupdate':
-ensure => present,
-gid=> 10002,
-shell  => '/bin/bash',
-home   => '/home/l10nupdate',
+ensure  => present,
+uid => 10002,
+gid => 10002,
+shell   => '/bin/bash',
+home=> '/home/l10nupdate',
+require => Group['l10nupdate'],
 }
 
 # Explicitly provision the l10nupdate user's home directory. In Labs the

-- 
To view, visit https://gerrit.wikimedia.org/r/348884
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If8b2a16bb82b1753e95c9743f35c248c19db0c70
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Chad 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Update OOjs UI to v0.21.1

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348881 )

Change subject: Update OOjs UI to v0.21.1
..


Update OOjs UI to v0.21.1

Release notes:
 
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.21.1

Change-Id: I5edcf21effee760d9951965a152481f2c603b59b
---
M composer.json
M composer.lock
M composer/installed.json
M oojs/oojs-ui/History.md
M oojs/oojs-ui/README.md
M oojs/oojs-ui/demos/pages/toolbars.js
M oojs/oojs-ui/demos/pages/widgets.js
M oojs/oojs-ui/demos/pages/widgets.php
M oojs/oojs-ui/demos/styles/demo.css
M oojs/oojs-ui/i18n/jv.json
M oojs/oojs-ui/package.json
11 files changed, 256 insertions(+), 114 deletions(-)

Approvals:
  jenkins-bot: Verified
  VolkerE: Looks good to me, approved



diff --git a/composer.json b/composer.json
index 060cea0..25b488c 100644
--- a/composer.json
+++ b/composer.json
@@ -44,7 +44,7 @@
"mediawiki/at-ease": "1.1.0",
"monolog/monolog": "1.22.1",
"nmred/kafka-php": "0.1.5",
-   "oojs/oojs-ui": "0.21.0",
+   "oojs/oojs-ui": "0.21.1",
"oyejorge/less.php": "1.7.0.14",
"pear/console_getopt": "1.4.1",
"pear/mail": "1.3.0",
diff --git a/composer.lock b/composer.lock
index afa7167..f2416a4 100644
--- a/composer.lock
+++ b/composer.lock
@@ -4,7 +4,7 @@
 "Read more about it at 
https://getcomposer.org/doc/01-basic-usage.md#composer-lock-the-lock-file;,
 "This file is @generated automatically"
 ],
-"content-hash": "cef3fe39dce79bd5ec5b2b4d83e63289",
+"content-hash": "0504cf9f775f597b7227cc031c0faee2",
 "packages": [
 {
 "name": "composer/semver",
@@ -466,16 +466,16 @@
 },
 {
 "name": "oojs/oojs-ui",
-"version": "v0.21.0",
+"version": "v0.21.1",
 "source": {
 "type": "git",
 "url": "https://github.com/wikimedia/oojs-ui.git;,
-"reference": "f8c175f7c3934573715fb97d3c1a64f8f0d365f0"
+"reference": "59965a94e168c23d9dbb154d8a63f6a1abc7f537"
 },
 "dist": {
 "type": "zip",
-"url": 
"https://api.github.com/repos/wikimedia/oojs-ui/zipball/f8c175f7c3934573715fb97d3c1a64f8f0d365f0;,
-"reference": "f8c175f7c3934573715fb97d3c1a64f8f0d365f0",
+"url": 
"https://api.github.com/repos/wikimedia/oojs-ui/zipball/59965a94e168c23d9dbb154d8a63f6a1abc7f537;,
+"reference": "59965a94e168c23d9dbb154d8a63f6a1abc7f537",
 "shasum": ""
 },
 "require": {
@@ -541,7 +541,7 @@
 ],
 "description": "Provides library of common widgets, layouts, and 
windows.",
 "homepage": "https://www.mediawiki.org/wiki/OOjs_UI;,
-"time": "2017-04-11T22:11:33+00:00"
+"time": "2017-04-18T23:06:13+00:00"
 },
 {
 "name": "oyejorge/less.php",
diff --git a/composer/installed.json b/composer/installed.json
index 9a82fa9..d1b6acd 100644
--- a/composer/installed.json
+++ b/composer/installed.json
@@ -2112,17 +2112,17 @@
 },
 {
 "name": "oojs/oojs-ui",
-"version": "v0.21.0",
-"version_normalized": "0.21.0.0",
+"version": "v0.21.1",
+"version_normalized": "0.21.1.0",
 "source": {
 "type": "git",
 "url": "https://github.com/wikimedia/oojs-ui.git;,
-"reference": "f8c175f7c3934573715fb97d3c1a64f8f0d365f0"
+"reference": "59965a94e168c23d9dbb154d8a63f6a1abc7f537"
 },
 "dist": {
 "type": "zip",
-"url": 
"https://api.github.com/repos/wikimedia/oojs-ui/zipball/f8c175f7c3934573715fb97d3c1a64f8f0d365f0;,
-"reference": "f8c175f7c3934573715fb97d3c1a64f8f0d365f0",
+"url": 
"https://api.github.com/repos/wikimedia/oojs-ui/zipball/59965a94e168c23d9dbb154d8a63f6a1abc7f537;,
+"reference": "59965a94e168c23d9dbb154d8a63f6a1abc7f537",
 "shasum": ""
 },
 "require": {
@@ -2134,7 +2134,7 @@
 "mediawiki/mediawiki-codesniffer": "0.6.0",
 "phpunit/phpunit": "4.8.21"
 },
-"time": "2017-04-11T22:11:33+00:00",
+"time": "2017-04-18T23:06:13+00:00",
 "type": "library",
 "installation-source": "dist",
 "autoload": {
diff --git a/oojs/oojs-ui/History.md b/oojs/oojs-ui/History.md
index 58e3bd0..f6e9955 100644
--- a/oojs/oojs-ui/History.md
+++ b/oojs/oojs-ui/History.md
@@ -1,4 +1,32 @@
 # OOjs UI Release History
+## v0.21.1 / 2017-04-18
+### Styles
+* PopupWidget: Do not leave space for anchor if there's no anchor (Bartosz 
Dziewoński)
+* MediaWiki theme: Ensure WCAG level AA contrast on unsupported 
SelectFileWidget (Volker E)
+* MediaWiki 

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: build: Sync qunitjs version for karma with version of Specia...

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348879 )

Change subject: build: Sync qunitjs version for karma with version of Special 
page
..


build: Sync qunitjs version for karma with version of Special page

Special:JavaScriptTest loads qunitjs from /resources/lib/qunitjs
which was upgraded in 99aad9397e to 1.23.1.

However, when running QUnit tests from the command-line, QUnit is
loaded by karma-qunit using the npm qunitjs dependency, which was
still at v1.22.0.

Change-Id: Ie24b2b061735fa03a8ed1527d09f65c103506c67
---
M package.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/package.json b/package.json
index 29388c5..55f36a3 100644
--- a/package.json
+++ b/package.json
@@ -24,7 +24,7 @@
 "karma-firefox-launcher": "1.0.1",
 "karma-mocha-reporter": "2.2.3",
 "karma-qunit": "1.0.0",
-"qunitjs": "1.22.0",
+"qunitjs": "1.23.1",
 "stylelint-config-wikimedia": "0.4.1",
 "wdio-junit-reporter": "0.2.0",
 "wdio-mocha-framework": "0.5.8",

-- 
To view, visit https://gerrit.wikimedia.org/r/348879
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie24b2b061735fa03a8ed1527d09f65c103506c67
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Update OOjs UI to v0.21.1

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348882 )

Change subject: Update OOjs UI to v0.21.1
..


Update OOjs UI to v0.21.1

Release notes:
 
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.21.1

Change-Id: I5edcf21effee760d9951965a152481f2c603b5b9
---
M lib/oojs-ui/i18n/jv.json
M lib/oojs-ui/oojs-ui-apex-icons-alerts.css
M lib/oojs-ui/oojs-ui-apex-icons-alerts.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-content.css
M lib/oojs-ui/oojs-ui-apex-icons-content.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-advanced.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-advanced.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-core.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-core.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-list.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-list.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-styling.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-styling.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-interactions.css
M lib/oojs-ui/oojs-ui-apex-icons-interactions.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-layout.css
M lib/oojs-ui/oojs-ui-apex-icons-layout.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-media.css
M lib/oojs-ui/oojs-ui-apex-icons-media.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-moderation.css
M lib/oojs-ui/oojs-ui-apex-icons-moderation.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-movement.css
M lib/oojs-ui/oojs-ui-apex-icons-movement.rtl.css
M lib/oojs-ui/oojs-ui-apex.css
M lib/oojs-ui/oojs-ui-apex.js
M lib/oojs-ui/oojs-ui-apex.rtl.css
M lib/oojs-ui/oojs-ui-core-apex.css
M lib/oojs-ui/oojs-ui-core-apex.rtl.css
M lib/oojs-ui/oojs-ui-core-mediawiki.css
M lib/oojs-ui/oojs-ui-core-mediawiki.rtl.css
M lib/oojs-ui/oojs-ui-core.js
M lib/oojs-ui/oojs-ui-images-apex.css
M lib/oojs-ui/oojs-ui-images-apex.rtl.css
M lib/oojs-ui/oojs-ui-images-mediawiki.css
M lib/oojs-ui/oojs-ui-images-mediawiki.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-accessibility.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-accessibility.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-alerts.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-alerts.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-content.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-content.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-editing-advanced.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-editing-advanced.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-editing-core.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-editing-core.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-editing-list.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-editing-list.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-editing-styling.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-editing-styling.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-interactions.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-interactions.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-layout.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-layout.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-location.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-location.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-media.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-media.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-moderation.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-moderation.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-movement.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-movement.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-user.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-user.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-wikimedia.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-wikimedia.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki.css
M lib/oojs-ui/oojs-ui-mediawiki.js
M lib/oojs-ui/oojs-ui-mediawiki.rtl.css
M lib/oojs-ui/oojs-ui-toolbars-apex.css
M lib/oojs-ui/oojs-ui-toolbars-apex.rtl.css
M lib/oojs-ui/oojs-ui-toolbars-mediawiki.css
M lib/oojs-ui/oojs-ui-toolbars-mediawiki.rtl.css
M lib/oojs-ui/oojs-ui-toolbars.js
M lib/oojs-ui/oojs-ui-widgets-apex.css
M lib/oojs-ui/oojs-ui-widgets-apex.rtl.css
M lib/oojs-ui/oojs-ui-widgets-mediawiki.css
M lib/oojs-ui/oojs-ui-widgets-mediawiki.rtl.css
M lib/oojs-ui/oojs-ui-widgets.js
M lib/oojs-ui/oojs-ui-windows-apex.css
M lib/oojs-ui/oojs-ui-windows-apex.rtl.css
M lib/oojs-ui/oojs-ui-windows-mediawiki.css
M lib/oojs-ui/oojs-ui-windows-mediawiki.rtl.css
M lib/oojs-ui/oojs-ui-windows.js
83 files changed, 7,694 insertions(+), 6,875 deletions(-)

Approvals:
  jenkins-bot: Verified
  VolkerE: Looks good to me, approved




-- 
To view, visit https://gerrit.wikimedia.org/r/348882
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5edcf21effee760d9951965a152481f2c603b5b9
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: VolkerE 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Drop unused config variable MFIgnoreEventLoggingBucketing

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348877 )

Change subject: Drop unused config variable MFIgnoreEventLoggingBucketing
..


Drop unused config variable MFIgnoreEventLoggingBucketing

See:
https://phabricator.wikimedia.org/T125122#3192270

Change-Id: Ie6c0cba7b48c87ea4946522f43336e8c1166959b
---
M README.md
M extension.json
M includes/MobileFrontend.hooks.php
M tests/browser/LocalSettings.php
4 files changed, 0 insertions(+), 12 deletions(-)

Approvals:
  Krinkle: Looks good to me, but someone else must approve
  Bmansurov: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/README.md b/README.md
index 1a283d1..d26832a 100644
--- a/README.md
+++ b/README.md
@@ -147,15 +147,6 @@
   ]
 ```
 
- $wgMFIgnoreEventLoggingBucketing
-
-Disable EventLogging bucketing for purposes of development.  When enabled all
-events are logged regardless of any existing sampling rate specified in the
-schema.
-
-* Type: `Boolean`
-* Default: `false`
-
  $wgMFExperiments
 
 A list of experiments active on the skin.
diff --git a/extension.json b/extension.json
index 622fdc2..5fcdf94 100644
--- a/extension.json
+++ b/extension.json
@@ -1733,7 +1733,6 @@
"anonymousEditing": true,
"skipPreview": false
},
-   "MFIgnoreEventLoggingBucketing": false,
"MFExperiments": {
"betaoptin": {
"name": "betaoptin",
diff --git a/includes/MobileFrontend.hooks.php 
b/includes/MobileFrontend.hooks.php
index aca4ee2..d4f200c 100644
--- a/includes/MobileFrontend.hooks.php
+++ b/includes/MobileFrontend.hooks.php
@@ -425,7 +425,6 @@
'wgMFLicense' => MobileFrontendSkinHooks::getLicense( 
'editor' ),
'wgMFSchemaEditSampleRate' => $config->get( 
'MFSchemaEditSampleRate' ),
'wgMFExperiments' => $config->get( 'MFExperiments' ),
-   'wgMFIgnoreEventLoggingBucketing' => $config->get( 
'MFIgnoreEventLoggingBucketing' ),
'wgMFEnableJSConsoleRecruitment' => $config->get( 
'MFEnableJSConsoleRecruitment' ),
'wgMFPhotoUploadEndpoint' =>
$config->get( 'MFPhotoUploadEndpoint' ) ? 
$config->get( 'MFPhotoUploadEndpoint' ) : '',
diff --git a/tests/browser/LocalSettings.php b/tests/browser/LocalSettings.php
index 95b4171..6826133 100644
--- a/tests/browser/LocalSettings.php
+++ b/tests/browser/LocalSettings.php
@@ -4,7 +4,6 @@
 // Allow users to edit privacy link.
 $wgGroupPermissions['user']['editinterface'] = true;
 
-$wgMFIgnoreEventLoggingBucketing = true;
 $wgHooks['InterwikiLoadPrefix'][] = function ( $prefix, &$iwdata ) {
if ( $prefix === 'es' ) {
// return our hardcoded interwiki info

-- 
To view, visit https://gerrit.wikimedia.org/r/348877
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6c0cba7b48c87ea4946522f43336e8c1166959b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 
Gerrit-Reviewer: Bmansurov 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: qunit: Also clear $.timers when stopping unfinished animations

[Krinkle (Code Review)]

Krinkle has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348883 )

Change subject: qunit: Also clear $.timers when stopping unfinished animations
..

qunit: Also clear $.timers when stopping unfinished animations

Stopping the animation is essentially the same as pausing, it remains in the
animation registry and will continue to fail all subsequent tests until one
of those later tests starts the animation queue again and also happens to
wait long enough for this unrelated animation to finish.

Fix the testrunner to actually fully stop the pre-existing animations, which
requires clearing $.timers as well. This matches the logic we have for
pending ajax requests.

Bug: T163211
Change-Id: Ic7d848187bc3c800e8347e0650093b2ffce6dddc
---
M tests/qunit/data/testrunner.js
M tests/qunit/suites/resources/jquery/jquery.mwExtension.test.js
2 files changed, 7 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/83/348883/1

diff --git a/tests/qunit/data/testrunner.js b/tests/qunit/data/testrunner.js
index 55bd276..a947484 100644
--- a/tests/qunit/data/testrunner.js
+++ b/tests/qunit/data/testrunner.js
@@ -240,6 +240,7 @@
);
} );
// Force animations to stop to 
give the next test a clean start
+   $.timers = [];
$.fx.stop();
 
throw new Error( 'Unfinished 
animations: ' + timers );
diff --git a/tests/qunit/suites/resources/jquery/jquery.mwExtension.test.js 
b/tests/qunit/suites/resources/jquery/jquery.mwExtension.test.js
index aeda516..7923b9d 100644
--- a/tests/qunit/suites/resources/jquery/jquery.mwExtension.test.js
+++ b/tests/qunit/suites/resources/jquery/jquery.mwExtension.test.js
@@ -25,6 +25,12 @@
} );
 
QUnit.test( 'isDomElement', function ( assert ) {
+   var $a = $( '' ).addClass( 'krinkle' ).css( {
+   width: 300,
+   height: 400
+   } );
+   $( 'body' ).prepend( $a );
+   $a.slideUp( 900 );
assert.strictEqual( $.isDomElement( document.createElement( 
'div' ) ), true,
'isDomElement: HTMLElement' );
assert.strictEqual( $.isDomElement( document.createTextNode( '' 
) ), true,

-- 
To view, visit https://gerrit.wikimedia.org/r/348883
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic7d848187bc3c800e8347e0650093b2ffce6dddc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Update OOjs UI to v0.21.1

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348882 )

Change subject: Update OOjs UI to v0.21.1
..

Update OOjs UI to v0.21.1

Release notes:
 
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.21.1

Change-Id: I5edcf21effee760d9951965a152481f2c603b5b9
---
M lib/oojs-ui/i18n/jv.json
M lib/oojs-ui/oojs-ui-apex-icons-alerts.css
M lib/oojs-ui/oojs-ui-apex-icons-alerts.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-content.css
M lib/oojs-ui/oojs-ui-apex-icons-content.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-advanced.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-advanced.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-core.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-core.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-list.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-list.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-styling.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-styling.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-interactions.css
M lib/oojs-ui/oojs-ui-apex-icons-interactions.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-layout.css
M lib/oojs-ui/oojs-ui-apex-icons-layout.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-media.css
M lib/oojs-ui/oojs-ui-apex-icons-media.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-moderation.css
M lib/oojs-ui/oojs-ui-apex-icons-moderation.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-movement.css
M lib/oojs-ui/oojs-ui-apex-icons-movement.rtl.css
M lib/oojs-ui/oojs-ui-apex.css
M lib/oojs-ui/oojs-ui-apex.js
M lib/oojs-ui/oojs-ui-apex.rtl.css
M lib/oojs-ui/oojs-ui-core-apex.css
M lib/oojs-ui/oojs-ui-core-apex.rtl.css
M lib/oojs-ui/oojs-ui-core-mediawiki.css
M lib/oojs-ui/oojs-ui-core-mediawiki.rtl.css
M lib/oojs-ui/oojs-ui-core.js
M lib/oojs-ui/oojs-ui-images-apex.css
M lib/oojs-ui/oojs-ui-images-apex.rtl.css
M lib/oojs-ui/oojs-ui-images-mediawiki.css
M lib/oojs-ui/oojs-ui-images-mediawiki.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-accessibility.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-accessibility.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-alerts.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-alerts.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-content.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-content.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-editing-advanced.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-editing-advanced.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-editing-core.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-editing-core.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-editing-list.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-editing-list.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-editing-styling.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-editing-styling.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-interactions.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-interactions.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-layout.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-layout.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-location.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-location.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-media.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-media.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-moderation.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-moderation.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-movement.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-movement.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-user.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-user.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-wikimedia.css
M lib/oojs-ui/oojs-ui-mediawiki-icons-wikimedia.rtl.css
M lib/oojs-ui/oojs-ui-mediawiki.css
M lib/oojs-ui/oojs-ui-mediawiki.js
M lib/oojs-ui/oojs-ui-mediawiki.rtl.css
M lib/oojs-ui/oojs-ui-toolbars-apex.css
M lib/oojs-ui/oojs-ui-toolbars-apex.rtl.css
M lib/oojs-ui/oojs-ui-toolbars-mediawiki.css
M lib/oojs-ui/oojs-ui-toolbars-mediawiki.rtl.css
M lib/oojs-ui/oojs-ui-toolbars.js
M lib/oojs-ui/oojs-ui-widgets-apex.css
M lib/oojs-ui/oojs-ui-widgets-apex.rtl.css
M lib/oojs-ui/oojs-ui-widgets-mediawiki.css
M lib/oojs-ui/oojs-ui-widgets-mediawiki.rtl.css
M lib/oojs-ui/oojs-ui-widgets.js
M lib/oojs-ui/oojs-ui-windows-apex.css
M lib/oojs-ui/oojs-ui-windows-apex.rtl.css
M lib/oojs-ui/oojs-ui-windows-mediawiki.css
M lib/oojs-ui/oojs-ui-windows-mediawiki.rtl.css
M lib/oojs-ui/oojs-ui-windows.js
83 files changed, 7,694 insertions(+), 6,875 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/82/348882/1


-- 
To view, visit https://gerrit.wikimedia.org/r/348882
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5edcf21effee760d9951965a152481f2c603b5b9
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Update OOjs UI to v0.21.1

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348881 )

Change subject: Update OOjs UI to v0.21.1
..

Update OOjs UI to v0.21.1

Release notes:
 
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.21.1

Change-Id: I5edcf21effee760d9951965a152481f2c603b59b
---
M composer.json
M composer.lock
M composer/installed.json
M oojs/oojs-ui/History.md
M oojs/oojs-ui/README.md
M oojs/oojs-ui/demos/pages/toolbars.js
M oojs/oojs-ui/demos/pages/widgets.js
M oojs/oojs-ui/demos/pages/widgets.php
M oojs/oojs-ui/demos/styles/demo.css
M oojs/oojs-ui/i18n/jv.json
M oojs/oojs-ui/package.json
11 files changed, 256 insertions(+), 114 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/vendor 
refs/changes/81/348881/1

diff --git a/composer.json b/composer.json
index 060cea0..25b488c 100644
--- a/composer.json
+++ b/composer.json
@@ -44,7 +44,7 @@
"mediawiki/at-ease": "1.1.0",
"monolog/monolog": "1.22.1",
"nmred/kafka-php": "0.1.5",
-   "oojs/oojs-ui": "0.21.0",
+   "oojs/oojs-ui": "0.21.1",
"oyejorge/less.php": "1.7.0.14",
"pear/console_getopt": "1.4.1",
"pear/mail": "1.3.0",
diff --git a/composer.lock b/composer.lock
index afa7167..f2416a4 100644
--- a/composer.lock
+++ b/composer.lock
@@ -4,7 +4,7 @@
 "Read more about it at 
https://getcomposer.org/doc/01-basic-usage.md#composer-lock-the-lock-file;,
 "This file is @generated automatically"
 ],
-"content-hash": "cef3fe39dce79bd5ec5b2b4d83e63289",
+"content-hash": "0504cf9f775f597b7227cc031c0faee2",
 "packages": [
 {
 "name": "composer/semver",
@@ -466,16 +466,16 @@
 },
 {
 "name": "oojs/oojs-ui",
-"version": "v0.21.0",
+"version": "v0.21.1",
 "source": {
 "type": "git",
 "url": "https://github.com/wikimedia/oojs-ui.git;,
-"reference": "f8c175f7c3934573715fb97d3c1a64f8f0d365f0"
+"reference": "59965a94e168c23d9dbb154d8a63f6a1abc7f537"
 },
 "dist": {
 "type": "zip",
-"url": 
"https://api.github.com/repos/wikimedia/oojs-ui/zipball/f8c175f7c3934573715fb97d3c1a64f8f0d365f0;,
-"reference": "f8c175f7c3934573715fb97d3c1a64f8f0d365f0",
+"url": 
"https://api.github.com/repos/wikimedia/oojs-ui/zipball/59965a94e168c23d9dbb154d8a63f6a1abc7f537;,
+"reference": "59965a94e168c23d9dbb154d8a63f6a1abc7f537",
 "shasum": ""
 },
 "require": {
@@ -541,7 +541,7 @@
 ],
 "description": "Provides library of common widgets, layouts, and 
windows.",
 "homepage": "https://www.mediawiki.org/wiki/OOjs_UI;,
-"time": "2017-04-11T22:11:33+00:00"
+"time": "2017-04-18T23:06:13+00:00"
 },
 {
 "name": "oyejorge/less.php",
diff --git a/composer/installed.json b/composer/installed.json
index 9a82fa9..d1b6acd 100644
--- a/composer/installed.json
+++ b/composer/installed.json
@@ -2112,17 +2112,17 @@
 },
 {
 "name": "oojs/oojs-ui",
-"version": "v0.21.0",
-"version_normalized": "0.21.0.0",
+"version": "v0.21.1",
+"version_normalized": "0.21.1.0",
 "source": {
 "type": "git",
 "url": "https://github.com/wikimedia/oojs-ui.git;,
-"reference": "f8c175f7c3934573715fb97d3c1a64f8f0d365f0"
+"reference": "59965a94e168c23d9dbb154d8a63f6a1abc7f537"
 },
 "dist": {
 "type": "zip",
-"url": 
"https://api.github.com/repos/wikimedia/oojs-ui/zipball/f8c175f7c3934573715fb97d3c1a64f8f0d365f0;,
-"reference": "f8c175f7c3934573715fb97d3c1a64f8f0d365f0",
+"url": 
"https://api.github.com/repos/wikimedia/oojs-ui/zipball/59965a94e168c23d9dbb154d8a63f6a1abc7f537;,
+"reference": "59965a94e168c23d9dbb154d8a63f6a1abc7f537",
 "shasum": ""
 },
 "require": {
@@ -2134,7 +2134,7 @@
 "mediawiki/mediawiki-codesniffer": "0.6.0",
 "phpunit/phpunit": "4.8.21"
 },
-"time": "2017-04-11T22:11:33+00:00",
+"time": "2017-04-18T23:06:13+00:00",
 "type": "library",
 "installation-source": "dist",
 "autoload": {
diff --git a/oojs/oojs-ui/History.md b/oojs/oojs-ui/History.md
index 58e3bd0..f6e9955 100644
--- a/oojs/oojs-ui/History.md
+++ b/oojs/oojs-ui/History.md
@@ -1,4 +1,32 @@
 # OOjs UI Release History
+## v0.21.1 / 2017-04-18
+### Styles
+* PopupWidget: Do not leave space for anchor if there's no anchor (Bartosz 
Dziewoński)
+* MediaWiki theme: Ensure WCAG level AA contrast on unsupported 
SelectFileWidget (Volker E)
+* 

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Merge remote-tracking branch 'origin/printstyles' into print...

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348878 )

Change subject: Merge remote-tracking branch 'origin/printstyles' into 
printstylesdeploy
..


Merge remote-tracking branch 'origin/printstyles' into printstylesdeploy

Change-Id: Ic52bdee6b08e39363b8d3b6e8db290603075c0b6
---
0 files changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Bmansurov: Looks good to me, approved
  jenkins-bot: Verified




-- 
To view, visit https://gerrit.wikimedia.org/r/348878
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic52bdee6b08e39363b8d3b6e8db290603075c0b6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 
Gerrit-Reviewer: Bmansurov 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: build: Sync qunitjs version for karma with version of Specia...

[Krinkle (Code Review)]

Krinkle has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348879 )

Change subject: build: Sync qunitjs version for karma with version of Special 
page
..

build: Sync qunitjs version for karma with version of Special page

Special:JavaScriptTest loads qunitjs from /resources/lib/qunitjs
which was upgraded in 99aad9397e to 1.23.1.

However, when running QUnit tests from the command-line, QUnit is
loaded by karma-qunit using the npm qunitjs dependency, which was
still at v1.22.0.

Change-Id: Ie24b2b061735fa03a8ed1527d09f65c103506c67
---
M package.json
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/79/348879/1

diff --git a/package.json b/package.json
index 29388c5..55f36a3 100644
--- a/package.json
+++ b/package.json
@@ -24,7 +24,7 @@
 "karma-firefox-launcher": "1.0.1",
 "karma-mocha-reporter": "2.2.3",
 "karma-qunit": "1.0.0",
-"qunitjs": "1.22.0",
+"qunitjs": "1.23.1",
 "stylelint-config-wikimedia": "0.4.1",
 "wdio-junit-reporter": "0.2.0",
 "wdio-mocha-framework": "0.5.8",

-- 
To view, visit https://gerrit.wikimedia.org/r/348879
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie24b2b061735fa03a8ed1527d09f65c103506c67
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CentralAuth[master]: CentralAuthGroupMembershipProxy needs master CentralAuthUser...

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348231 )

Change subject: CentralAuthGroupMembershipProxy needs master CentralAuthUser 
instances
..


CentralAuthGroupMembershipProxy needs master CentralAuthUser instances

For the calls to ->addGroup and ->removeGroup.

While we could get more complicated and add a flag to make master and
non-master instances, it's probably not worth it since the only caller
is SpecialGlobalGroupMembership.

Change-Id: I61535c3b0125245cbb6a7dd3f392aeb91f3b82d6
---
M includes/CentralAuthGroupMembershipProxy.php
M includes/CentralAuthUser.php
2 files changed, 24 insertions(+), 3 deletions(-)

Approvals:
  Aaron Schulz: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/CentralAuthGroupMembershipProxy.php 
b/includes/CentralAuthGroupMembershipProxy.php
index 9e81b63..c3d9c2c 100644
--- a/includes/CentralAuthGroupMembershipProxy.php
+++ b/includes/CentralAuthGroupMembershipProxy.php
@@ -45,7 +45,7 @@
if ( $name === false ) {
return null;
}
-   $globalUser = CentralAuthUser::getInstanceByName( $name );
+   $globalUser = CentralAuthUser::getMasterInstanceByName( $name );
return $globalUser->exists() ? new 
CentralAuthGroupMembershipProxy( $globalUser ) : null;
}
 
@@ -54,7 +54,7 @@
 * @return CentralAuthGroupMembershipProxy|null
 */
public static function newFromId( $id ) {
-   $globalUser = CentralAuthUser::newFromId( $id );
+   $globalUser = CentralAuthUser::newMasterInstanceFromId( $id );
return $globalUser ? new CentralAuthGroupMembershipProxy( 
$globalUser ) : null;
}
 
diff --git a/includes/CentralAuthUser.php b/includes/CentralAuthUser.php
index de353f6..b22709e 100644
--- a/includes/CentralAuthUser.php
+++ b/includes/CentralAuthUser.php
@@ -288,7 +288,7 @@
__METHOD__
);
 
-   if ( $name ) {
+   if ( $name !== false ) {
return CentralAuthUser::getInstanceByName( $name );
} else {
return false;
@@ -296,6 +296,27 @@
}
 
/**
+* Get a master CentralAuthUser object from a user's id
+*
+* @param int $id
+* @return CentralAuthUser|bool false if no user exists with that id
+*/
+   public static function newMasterInstanceFromId( $id ) {
+   $name = CentralAuthUtils::getCentralDB()->selectField(
+   'globaluser',
+   'gu_name',
+   array( 'gu_id' => $id ),
+   __METHOD__
+   );
+
+   if ( $name !== false ) {
+   return CentralAuthUser::getMasterInstanceByName( $name 
);
+   } else {
+   return false;
+   }
+   }
+
+   /**
 * Create a CentralAuthUser object from a joined globaluser/localuser 
row
 *
 * @param $row ResultWrapper|object

-- 
To view, visit https://gerrit.wikimedia.org/r/348231
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I61535c3b0125245cbb6a7dd3f392aeb91f3b82d6
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: Anomie 
Gerrit-Reviewer: Aaron Schulz 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: MarcoAurelio 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Merge remote-tracking branch 'origin/printstyles' into print...

[Jdlrobson (Code Review)]

Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348878 )

Change subject: Merge remote-tracking branch 'origin/printstyles' into 
printstylesdeploy
..

Merge remote-tracking branch 'origin/printstyles' into printstylesdeploy

Change-Id: Ic52bdee6b08e39363b8d3b6e8db290603075c0b6
---
0 files changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/78/348878/1


-- 
To view, visit https://gerrit.wikimedia.org/r/348878
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic52bdee6b08e39363b8d3b6e8db290603075c0b6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[printstyles]: Tweak page margins

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348876 )

Change subject: Tweak page margins
..


Tweak page margins

Per Nirzar:
The second page had no top margin
Drop top padding on header to avoid double top margin
Drop padding on page - this seems to do nothing

Change-Id: I3614ad0e234b487e3346ddcb08a2dfd6b3f7d8e3
---
M resources/skins.minerva.print.styles/header.less
M resources/skins.minerva.print.styles/styles.less
2 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Bmansurov: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/skins.minerva.print.styles/header.less 
b/resources/skins.minerva.print.styles/header.less
index 28ef7f0..06362c2 100644
--- a/resources/skins.minerva.print.styles/header.less
+++ b/resources/skins.minerva.print.styles/header.less
@@ -5,6 +5,7 @@
 }
 
 .header {
+   border-top: 0;
display: block;
height: auto;
 
@@ -24,7 +25,7 @@
> .branding-box {
height: auto;
display: block !important;
-   padding: 66px 0 51px 50px;
+   padding: 0 0 51px 50px;
 
h1 {
font-size: inherit;
diff --git a/resources/skins.minerva.print.styles/styles.less 
b/resources/skins.minerva.print.styles/styles.less
index 6b06079..dc799b0 100644
--- a/resources/skins.minerva.print.styles/styles.less
+++ b/resources/skins.minerva.print.styles/styles.less
@@ -3,8 +3,7 @@
// Experimental technology (see 
https://developer.mozilla.org/en-US/docs/Web/CSS/@page/size)
@page {
size: legal;
-   margin: 0;
-   padding: 0;
+   margin: 50px 0;
}
 
html {

-- 
To view, visit https://gerrit.wikimedia.org/r/348876
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3614ad0e234b487e3346ddcb08a2dfd6b3f7d8e3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: printstyles
Gerrit-Owner: Jdlrobson 
Gerrit-Reviewer: Bmansurov 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: Tag v0.21.1

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348875 )

Change subject: Tag v0.21.1
..


Tag v0.21.1

Change-Id: I88498ecc79780d16a7b682c49ea03e74c599eb7d
---
M History.md
M package.json
2 files changed, 29 insertions(+), 1 deletion(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/History.md b/History.md
index 58e3bd0..f6e9955 100644
--- a/History.md
+++ b/History.md
@@ -1,4 +1,32 @@
 # OOjs UI Release History
+## v0.21.1 / 2017-04-18
+### Styles
+* PopupWidget: Do not leave space for anchor if there's no anchor (Bartosz 
Dziewoński)
+* MediaWiki theme: Ensure WCAG level AA contrast on unsupported 
SelectFileWidget (Volker E)
+* MediaWiki theme: Fit icon/indicator & label in DecoratedOptionWidget (Volker 
E)
+* MediaWiki theme: Fix standalone, disabled sibling ButtonWidgets (Volker E)
+* MediaWiki theme: Fix white `border-color` of frameless buttons (Volker E)
+* MediaWiki theme: Make readonly TextInputWidget appearance clearer (Volker E)
+* MediaWiki theme: TagMultiselectWidget outlined UI improvements (Volker E)
+* MenuOptionWidget: Remove theme-independent 'check' icon (Prateek Saxena)
+
+### Code
+* environment: Upgrade jQuery from 1.11.3 to 3.2.1 (James D. Forrester)
+* DropdownInput-/RadioSelectInputWidget: Remove unnecessary ARIA attributes 
(Volker E)
+* Element: Use `JSON.parse` rather than the deprecated `$.parseJSON` (James D. 
Forrester)
+* Fix typo in frameless button mixin (David Lynch)
+* FloatingMenuSelectWidget: Add 'ready' event after menu is clipped (Moriel 
Schottlender)
+* MediaWiki theme: Clarify `@min-height-widget-default` usage (Volker E)
+* PopupToolGroup: Mixin flaggable (David Lynch)
+* TagMultiselectWidget: Allow preset InputWidget (Moriel Schottlender)
+* TagMultiselectWidget: Redo data validation for Tag* and Menu* (Moriel 
Schottlender)
+* themes: Align `@size-*-min` variable to naming scheme and rename (Volker E)
+* build: Drop the csscomb task (James D. Forrester)
+* docs: Fix numbering in Quick start (Kartik Mistry)
+* demos: Polish demo labels, styles and add frameless button tests (Volker E)
+* tests: Update OO.ui.Process tests for jQuery 3 compatibility (Bartosz 
Dziewoński)
+
+
 ## v0.21.0 / 2017-04-11
 ### Breaking changes
 * [BREAKING CHANGE] ActionWidget: Remove resize event (IvanFon)
diff --git a/package.json b/package.json
index c97fe60..6ac8d60 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "oojs-ui",
-  "version": "0.21.0",
+  "version": "0.21.1",
   "description": "User interface classes built on the OOjs framework.",
   "keywords": [
 "oojs-plugin",

-- 
To view, visit https://gerrit.wikimedia.org/r/348875
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I88498ecc79780d16a7b682c49ea03e74c599eb7d
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Do an HTMLCacheUpdate of templatelinks on page creation

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348763 )

Change subject: Do an HTMLCacheUpdate of templatelinks on page creation
..


Do an HTMLCacheUpdate of templatelinks on page creation

When a page is created, anything that's trying to transclude that page
needs to have an HTMLCacheUpdate run on it. But that's not currently
happening.

Normal template transclusion happens to get updates only because
transclusion of a nonexistent template is rendered as a link to that
template, which registers a pagelink, and pagelinks *are* being updated
on page creation to cause redlinks to turn blue.

Change-Id: I18b8cfdeedc53f8fdb1e758a6fca1cd23d9574f8
---
M includes/page/WikiPage.php
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Aaron Schulz: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/page/WikiPage.php b/includes/page/WikiPage.php
index 82c32da..a687900 100644
--- a/includes/page/WikiPage.php
+++ b/includes/page/WikiPage.php
@@ -3252,6 +3252,9 @@
 

MediaWikiServices::getInstance()->getLinkCache()->invalidateTitle( $title );
 
+   // Invalidate caches of articles which include this page
+   DeferredUpdates::addUpdate( new HTMLCacheUpdate( $title, 
'templatelinks' ) );
+
if ( $title->getNamespace() == NS_CATEGORY ) {
// Load the Category object, which will schedule a job 
to create
// the category table row if necessary. Checking a 
replica DB is ok

-- 
To view, visit https://gerrit.wikimedia.org/r/348763
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I18b8cfdeedc53f8fdb1e758a6fca1cd23d9574f8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Anomie 
Gerrit-Reviewer: Aaron Schulz 
Gerrit-Reviewer: Anomie 
Gerrit-Reviewer: Gergő Tisza 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Drop unused config variable MFIgnoreEventLoggingBucketing

[Jdlrobson (Code Review)]

Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348877 )

Change subject: Drop unused config variable MFIgnoreEventLoggingBucketing
..

Drop unused config variable MFIgnoreEventLoggingBucketing

See:
https://phabricator.wikimedia.org/T125122#3192270

Change-Id: Ie6c0cba7b48c87ea4946522f43336e8c1166959b
---
M README.md
M extension.json
M includes/MobileFrontend.hooks.php
M tests/browser/LocalSettings.php
4 files changed, 0 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/77/348877/1

diff --git a/README.md b/README.md
index 1a283d1..d26832a 100644
--- a/README.md
+++ b/README.md
@@ -147,15 +147,6 @@
   ]
 ```
 
- $wgMFIgnoreEventLoggingBucketing
-
-Disable EventLogging bucketing for purposes of development.  When enabled all
-events are logged regardless of any existing sampling rate specified in the
-schema.
-
-* Type: `Boolean`
-* Default: `false`
-
  $wgMFExperiments
 
 A list of experiments active on the skin.
diff --git a/extension.json b/extension.json
index 622fdc2..5fcdf94 100644
--- a/extension.json
+++ b/extension.json
@@ -1733,7 +1733,6 @@
"anonymousEditing": true,
"skipPreview": false
},
-   "MFIgnoreEventLoggingBucketing": false,
"MFExperiments": {
"betaoptin": {
"name": "betaoptin",
diff --git a/includes/MobileFrontend.hooks.php 
b/includes/MobileFrontend.hooks.php
index aca4ee2..d4f200c 100644
--- a/includes/MobileFrontend.hooks.php
+++ b/includes/MobileFrontend.hooks.php
@@ -425,7 +425,6 @@
'wgMFLicense' => MobileFrontendSkinHooks::getLicense( 
'editor' ),
'wgMFSchemaEditSampleRate' => $config->get( 
'MFSchemaEditSampleRate' ),
'wgMFExperiments' => $config->get( 'MFExperiments' ),
-   'wgMFIgnoreEventLoggingBucketing' => $config->get( 
'MFIgnoreEventLoggingBucketing' ),
'wgMFEnableJSConsoleRecruitment' => $config->get( 
'MFEnableJSConsoleRecruitment' ),
'wgMFPhotoUploadEndpoint' =>
$config->get( 'MFPhotoUploadEndpoint' ) ? 
$config->get( 'MFPhotoUploadEndpoint' ) : '',
diff --git a/tests/browser/LocalSettings.php b/tests/browser/LocalSettings.php
index 95b4171..6826133 100644
--- a/tests/browser/LocalSettings.php
+++ b/tests/browser/LocalSettings.php
@@ -4,7 +4,6 @@
 // Allow users to edit privacy link.
 $wgGroupPermissions['user']['editinterface'] = true;
 
-$wgMFIgnoreEventLoggingBucketing = true;
 $wgHooks['InterwikiLoadPrefix'][] = function ( $prefix, &$iwdata ) {
if ( $prefix === 'es' ) {
// return our hardcoded interwiki info

-- 
To view, visit https://gerrit.wikimedia.org/r/348877
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie6c0cba7b48c87ea4946522f43336e8c1166959b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[printstyles]: Merge remote-tracking branch 'origin/master' into HEAD

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348872 )

Change subject: Merge remote-tracking branch 'origin/master' into HEAD
..


Merge remote-tracking branch 'origin/master' into HEAD

Additional changes:
* Use Skin:getSkinOption to register print styles
SkinMinerva no longer knows anything about mobileContext.
Update how we add styles to the page

Change-Id: I293f6133160fee40e34c92b7d5c2865dc3c20a3c
---
M includes/Minerva.hooks.php
M includes/skins/SkinMinerva.php
2 files changed, 6 insertions(+), 1 deletion(-)

Approvals:
  Bmansurov: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/Minerva.hooks.php b/includes/Minerva.hooks.php
index cacafff..d74d02d 100644
--- a/includes/Minerva.hooks.php
+++ b/includes/Minerva.hooks.php
@@ -70,6 +70,8 @@
// setSkinOptions is not available
if ( $skin instanceof SkinMinerva ) {
$skin->setSkinOptions( [
+   SkinMinerva::OPTION_PRINT_STYLES
+   => $mobileContext->getConfigVariable( 
'MinervaPrintStyles' ),
SkinMinerva::OPTION_CATEGORIES
=> $mobileContext->getConfigVariable( 
'MinervaShowCategoriesButton' ),
SkinMinerva::OPTION_FONT_CHANGER
diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php
index 8f99e71..d3a87e0 100644
--- a/includes/skins/SkinMinerva.php
+++ b/includes/skins/SkinMinerva.php
@@ -17,6 +17,7 @@
const OPTION_FONT_CHANGER = 'fontChanger';
const OPTION_BACK_TO_TOP = 'backToTop';
const OPTION_TOGGLING = 'toggling';
+   const OPTION_PRINT_STYLES = 'printStyles';
 
/** @var string $skinname Name of this skin */
public $skinname = 'minerva';
@@ -59,6 +60,8 @@
self::OPTION_BACK_TO_TOP => false,
/** Whether sections can be collapsed (requires MobileFrontend 
and MobileFormatter) */
self::OPTION_TOGGLING => false,
+   /** Whether print styles should be loaded */
+   self::OPTION_PRINT_STYLES => false,
];
 
/**
@@ -321,7 +324,7 @@
public function initPage( OutputPage $out ) {
parent::initPage( $out );
$styles = [ 'mobile.usermodule.styles' ];
-   if ( $this->mobileContext->getConfigVariable( 
'MinervaPrintStyles' ) ) {
+   if ( $this->getSkinOption( self::OPTION_PRINT_STYLES ) ) {
$styles[] = 'skins.minerva.print.styles';
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/348872
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I293f6133160fee40e34c92b7d5c2865dc3c20a3c
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: printstyles
Gerrit-Owner: Jdlrobson 
Gerrit-Reviewer: Bmansurov 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[printstyles]: Tweak page margins

[Jdlrobson (Code Review)]

Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348876 )

Change subject: Tweak page margins
..

Tweak page margins

Per Nirzar:
The second page had no top margin
Drop top padding on header to avoid double top margin
Drop padding on page - this seems to do nothing

Change-Id: I3614ad0e234b487e3346ddcb08a2dfd6b3f7d8e3
---
M resources/skins.minerva.print.styles/header.less
M resources/skins.minerva.print.styles/styles.less
2 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/76/348876/1

diff --git a/resources/skins.minerva.print.styles/header.less 
b/resources/skins.minerva.print.styles/header.less
index 28ef7f0..06362c2 100644
--- a/resources/skins.minerva.print.styles/header.less
+++ b/resources/skins.minerva.print.styles/header.less
@@ -5,6 +5,7 @@
 }
 
 .header {
+   border-top: 0;
display: block;
height: auto;
 
@@ -24,7 +25,7 @@
> .branding-box {
height: auto;
display: block !important;
-   padding: 66px 0 51px 50px;
+   padding: 0 0 51px 50px;
 
h1 {
font-size: inherit;
diff --git a/resources/skins.minerva.print.styles/styles.less 
b/resources/skins.minerva.print.styles/styles.less
index 6b06079..dc799b0 100644
--- a/resources/skins.minerva.print.styles/styles.less
+++ b/resources/skins.minerva.print.styles/styles.less
@@ -3,8 +3,7 @@
// Experimental technology (see 
https://developer.mozilla.org/en-US/docs/Web/CSS/@page/size)
@page {
size: legal;
-   margin: 0;
-   padding: 0;
+   margin: 50px 0;
}
 
html {

-- 
To view, visit https://gerrit.wikimedia.org/r/348876
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3614ad0e234b487e3346ddcb08a2dfd6b3f7d8e3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: printstyles
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: Tag v0.21.1

[VolkerE (Code Review)]

VolkerE has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348875 )

Change subject: Tag v0.21.1
..

Tag v0.21.1

Change-Id: I88498ecc79780d16a7b682c49ea03e74c599eb7d
---
M History.md
M package.json
2 files changed, 29 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/75/348875/1

diff --git a/History.md b/History.md
index 58e3bd0..f6e9955 100644
--- a/History.md
+++ b/History.md
@@ -1,4 +1,32 @@
 # OOjs UI Release History
+## v0.21.1 / 2017-04-18
+### Styles
+* PopupWidget: Do not leave space for anchor if there's no anchor (Bartosz 
Dziewoński)
+* MediaWiki theme: Ensure WCAG level AA contrast on unsupported 
SelectFileWidget (Volker E)
+* MediaWiki theme: Fit icon/indicator & label in DecoratedOptionWidget (Volker 
E)
+* MediaWiki theme: Fix standalone, disabled sibling ButtonWidgets (Volker E)
+* MediaWiki theme: Fix white `border-color` of frameless buttons (Volker E)
+* MediaWiki theme: Make readonly TextInputWidget appearance clearer (Volker E)
+* MediaWiki theme: TagMultiselectWidget outlined UI improvements (Volker E)
+* MenuOptionWidget: Remove theme-independent 'check' icon (Prateek Saxena)
+
+### Code
+* environment: Upgrade jQuery from 1.11.3 to 3.2.1 (James D. Forrester)
+* DropdownInput-/RadioSelectInputWidget: Remove unnecessary ARIA attributes 
(Volker E)
+* Element: Use `JSON.parse` rather than the deprecated `$.parseJSON` (James D. 
Forrester)
+* Fix typo in frameless button mixin (David Lynch)
+* FloatingMenuSelectWidget: Add 'ready' event after menu is clipped (Moriel 
Schottlender)
+* MediaWiki theme: Clarify `@min-height-widget-default` usage (Volker E)
+* PopupToolGroup: Mixin flaggable (David Lynch)
+* TagMultiselectWidget: Allow preset InputWidget (Moriel Schottlender)
+* TagMultiselectWidget: Redo data validation for Tag* and Menu* (Moriel 
Schottlender)
+* themes: Align `@size-*-min` variable to naming scheme and rename (Volker E)
+* build: Drop the csscomb task (James D. Forrester)
+* docs: Fix numbering in Quick start (Kartik Mistry)
+* demos: Polish demo labels, styles and add frameless button tests (Volker E)
+* tests: Update OO.ui.Process tests for jQuery 3 compatibility (Bartosz 
Dziewoński)
+
+
 ## v0.21.0 / 2017-04-11
 ### Breaking changes
 * [BREAKING CHANGE] ActionWidget: Remove resize event (IvanFon)
diff --git a/package.json b/package.json
index c97fe60..6ac8d60 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "oojs-ui",
-  "version": "0.21.0",
+  "version": "0.21.1",
   "description": "User interface classes built on the OOjs framework.",
   "keywords": [
 "oojs-plugin",

-- 
To view, visit https://gerrit.wikimedia.org/r/348875
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I88498ecc79780d16a7b682c49ea03e74c599eb7d
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RCFilters UI: Select tag when filter item is selected

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348652 )

Change subject: RCFilters UI: Select tag when filter item is selected
..


RCFilters UI: Select tag when filter item is selected

Retain the selection behavior from previous versions, and synchronize
the selection of the filter item in the menu with the tag items
in the MenuTagMultiselectWidget.

Bug: T163138
Change-Id: I548a1fca65372c697e24b77d928d56b18f4df1c5
---
M resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagItemWidget.js
M 
resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js
2 files changed, 32 insertions(+), 0 deletions(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git 
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagItemWidget.js 
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagItemWidget.js
index cfffc65..f79e013 100644
--- 
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagItemWidget.js
+++ 
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagItemWidget.js
@@ -18,6 +18,7 @@
 
this.controller = controller;
this.model = model;
+   this.selected = false;
 
mw.rcfilters.ui.FilterTagItemWidget.parent.call( this, 
$.extend( {
data: this.model.getName(),
@@ -162,6 +163,15 @@
};
 
/**
+* Get the selected state of this widget
+*
+* @return {boolean} Tag is selected
+*/
+   mw.rcfilters.ui.FilterTagItemWidget.prototype.isSelected = function () {
+   return this.selected;
+   };
+
+   /**
 * Get item name
 *
 * @return {string} Filter name
diff --git 
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js
 
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js
index 8e26271..6fd3585 100644
--- 
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js
+++ 
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js
@@ -137,6 +137,7 @@
} else {
// Clear selection
this.getMenu().selectItem( null );
+   this.selectTag( null );
}
};
 
@@ -207,6 +208,9 @@
mw.rcfilters.ui.FilterTagMultiselectWidget.prototype.onMenuChoose = 
function ( item ) {
this.controller.toggleFilterSelect( item.model.getName() );
 
+   // Select the tag if it exists, or reset selection otherwise
+   this.selectTag( this.getItemFromData( item.model.getName() ) );
+
this.focus();
};
 
@@ -248,6 +252,7 @@

mw.rcfilters.ui.FilterTagMultiselectWidget.parent.prototype.onTagSelect.call( 
this, tagItem );
 
this.menu.selectItem( menuOption );
+   this.selectTag( tagItem );
 
// Scroll to the item
if ( oldInputValue ) {
@@ -265,6 +270,23 @@
};
 
/**
+* Select a tag by reference. This is what OO.ui.SelectWidget is doing.
+* If no items are given, reset selection from all.
+*
+* @param {mw.rcfilters.ui.FilterTagItemWidget} [item] Tag to select,
+*  omit to deselect all
+*/
+   mw.rcfilters.ui.FilterTagMultiselectWidget.prototype.selectTag = 
function ( item ) {
+   var i, len, selected;
+
+   for ( i = 0, len = this.items.length; i < len; i++ ) {
+   selected = this.items[ i ] === item;
+   if ( this.items[ i ].isSelected() !== selected ) {
+   this.items[ i ].toggleSelected( selected );
+   }
+   }
+   };
+   /**
 * @inheritdoc
 */
mw.rcfilters.ui.FilterTagMultiselectWidget.prototype.onTagRemove = 
function ( tagItem ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/348652
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I548a1fca65372c697e24b77d928d56b18f4df1c5
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: Jack Phoenix 
Gerrit-Reviewer: TTO 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Paypal EC recurring: queue one correctly formed message

[Ejegg (Code Review)]

Ejegg has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348874 )

Change subject: Paypal EC recurring: queue one correctly formed message
..

Paypal EC recurring: queue one correctly formed message

Instead of two malformed ones.
Previously, we were sending a message with recurring=1 and no subscr_id
after finishing the initial payment, then clobbering gateway_txn_id and
sending another message without it after setting up the recurring profile.

Change-Id: Iae0625873266cf2f23c13091e5036d6307bac0fa
---
M DonationInterface.class.php
M paypal_gateway/express_checkout/paypal_express.adapter.php
M tests/phpunit/Adapter/PayPal/PayPalExpressTest.php
M tests/phpunit/DonationInterfaceTestCase.php
M tests/phpunit/TestConfiguration.php
A 
tests/phpunit/includes/Responses/paypal_ec/CreateRecurringPaymentsProfile_Recurring-OK.testresponse
A 
tests/phpunit/includes/Responses/paypal_ec/DoExpressCheckoutPayment_OK.testresponse
A 
tests/phpunit/includes/Responses/paypal_ec/DoExpressCheckoutPayment_Recurring-OK.testresponse
A 
tests/phpunit/includes/Responses/paypal_ec/GetExpressCheckoutDetails_OK.testresponse
A 
tests/phpunit/includes/Responses/paypal_ec/GetExpressCheckoutDetails_Recurring-OK.testresponse
A tests/phpunit/includes/Responses/paypal_ec/SetExpressCheckout_OK.testresponse
A tests/phpunit/includes/test_gateway/TestingPaypalExpressAdapter.php
12 files changed, 254 insertions(+), 5 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface 
refs/changes/74/348874/1

diff --git a/DonationInterface.class.php b/DonationInterface.class.php
index 5fcc120..f3f3988 100644
--- a/DonationInterface.class.php
+++ b/DonationInterface.class.php
@@ -66,6 +66,7 @@
$wgAutoloadClasses['TestingGenericAdapter'] = $testDir . 
'includes/test_gateway/TestingGenericAdapter.php';
$wgAutoloadClasses['TestingGlobalCollectAdapter'] = $testDir . 
'includes/test_gateway/TestingGlobalCollectAdapter.php';
$wgAutoloadClasses['TestingGlobalCollectOrphanAdapter'] = 
$testDir . 'includes/test_gateway/TestingGlobalCollectOrphanAdapter.php';
+   $wgAutoloadClasses['TestingPaypalExpressAdapter'] = $testDir . 
'includes/test_gateway/TestingPaypalExpressAdapter.php';
$wgAutoloadClasses['TestingPaypalLegacyAdapter'] = $testDir . 
'includes/test_gateway/TestingPaypalLegacyAdapter.php';
 
$wgAutoloadClasses['TestingRequest'] = $testDir . 
'includes/test_request/test.request.php';
diff --git a/paypal_gateway/express_checkout/paypal_express.adapter.php 
b/paypal_gateway/express_checkout/paypal_express.adapter.php
index b12472c..4de374f 100644
--- a/paypal_gateway/express_checkout/paypal_express.adapter.php
+++ b/paypal_gateway/express_checkout/paypal_express.adapter.php
@@ -405,7 +405,8 @@
$this->checkResponseAck( $response );
 
// Grab the subscription ID.
-   $this->addResponseData( $this->unstageKeys( 
$response ) );
+   $returnedData = $this->unstageKeys( $response );
+   $this->addResponseData( $returnedData );
 
// FIXME: Not a satisfying ending.  Parse the 
PROFILESTATUS
// response and sort it into complete or 
pending.
@@ -441,9 +442,15 @@
$this->getData_Unstaged_Escaped( 
'gateway_txn_id' ) );
$status = $this->findCodeAction( 
'DoExpressCheckoutPayment',
'PAYMENTINFO_0_ERRORCODE', 
$response['PAYMENTINFO_0_ERRORCODE'] );
-   // TODO: Can we do this from do_transaction 
instead, or at least protect with !recurring...
-   $this->finalizeInternalStatus( $status );
-   $this->postProcessDonation();
+   // For recurring payments, we don't want to 
finalize or send the queue
+   // message just yet
+   if (
+   $status === FinalStatus::FAILED ||
+   !$this->getData_Unstaged_Escaped( 
'recurring' )
+   ) {
+   $this->finalizeInternalStatus( $status 
);
+   $this->postProcessDonation();
+   }
break;
}
 
@@ -513,4 +520,12 @@
throw new ResponseProcessingException( "Failure 
response", $response['ACK'] );
}
}
+
+   /**
+* FIXME: this is coming out of the ambient transaction response
+* in the parent adapters. Probably a bad idea everywhere.

[MediaWiki-commits] [Gerrit] mediawiki...parsoid[master]: Linter: Provide name of stripped tag

[Subramanya Sastry (Code Review)]

Subramanya Sastry has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348873 )

Change subject: Linter: Provide name of stripped tag
..

Linter: Provide name of stripped tag

Change-Id: I54c637940a95b7364c0c34e9a3849cbef5fbe00f
---
M lib/wt2html/pp/handlers/linter.js
M tests/mocha/linter.js
2 files changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid 
refs/changes/73/348873/1

diff --git a/lib/wt2html/pp/handlers/linter.js 
b/lib/wt2html/pp/handlers/linter.js
index 39624e1..8ca1f3c 100644
--- a/lib/wt2html/pp/handlers/linter.js
+++ b/lib/wt2html/pp/handlers/linter.js
@@ -116,7 +116,7 @@
}
 
if (DU.isMarkerMeta(c, 'mw:Placeholder/StrippedTag')) {
-   lintObj = { dsr: dsr, templateInfo: templateInfo };
+   lintObj = { dsr: dsr, templateInfo: templateInfo, params: { 
name: dp.name } };
env.log('lint/stripped-tag', lintObj);
}
 
diff --git a/tests/mocha/linter.js b/tests/mocha/linter.js
index 80e036b..b6e78ae 100644
--- a/tests/mocha/linter.js
+++ b/tests/mocha/linter.js
@@ -51,6 +51,8 @@
return parseWT('foo').then(function(result) {
result.should.have.length(1);
result[0].should.have.a.property("type", 
"stripped-tag");
+   result[0].should.have.a.property("params");
+   result[0].params.should.have.a.property("name", 
"DIV");
result[0].dsr.should.deep.equal([ 3, 9, null, 
null ]);
});
});
@@ -58,6 +60,8 @@
return 
parseWT('{{1x|foo}}').then(function(result) {
result.should.have.length(1);
result[0].should.have.a.property("type", 
"stripped-tag");
+   result[0].should.have.a.property("params");
+   result[0].params.should.have.a.property("name", 
"DIV");
result[0].dsr.should.deep.equal([ 0, 27, null, 
null ]);
});
});

-- 
To view, visit https://gerrit.wikimedia.org/r/348873
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I54c637940a95b7364c0c34e9a3849cbef5fbe00f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: dumps: skip cert monitoring where Letsencrypt is disabled

[Dzahn (Code Review)]

Dzahn has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348869 )

Change subject: dumps: skip cert monitoring where Letsencrypt is disabled
..


dumps: skip cert monitoring where Letsencrypt is disabled

Just like done for tendril, in I7d1b09429070a0433447,
skip the Icinga certificate monitoring if do_acme
(the override to skip Letsencrypt cert creation) is set
to false.

If we don't renew certs (on a passive/failover/standy server that
doesn't have the DNS name) we also don't want to monitor them,
or we get false alerts that cause concerns for no reason.

Change-Id: Id0cc0dae29e12b26856f1ff3f39359ba95be8a3c
---
M modules/role/manifests/dumps/server.pp
1 file changed, 6 insertions(+), 3 deletions(-)

Approvals:
  jenkins-bot: Verified
  RobH: Looks good to me, but someone else must approve
  Dzahn: Looks good to me, approved



diff --git a/modules/role/manifests/dumps/server.pp 
b/modules/role/manifests/dumps/server.pp
index 8f83174..233ba3c 100644
--- a/modules/role/manifests/dumps/server.pp
+++ b/modules/role/manifests/dumps/server.pp
@@ -9,9 +9,12 @@
 check_command => 'check_http'
 }
 
-monitoring::service { 'https':
-description   => 'HTTPS',
-check_command => 'check_ssl_http_letsencrypt!dumps.wikimedia.org',
+# TODO: move hiera lookup to parameter of a profile class
+if hiera('do_acme', true) {
+monitoring::service { 'https':
+description   => 'HTTPS',
+check_command => 'check_ssl_http_letsencrypt!dumps.wikimedia.org',
+}
 }
 
 # By default the resolve() function in ferm performs only an IPv4/A DNS

-- 
To view, visit https://gerrit.wikimedia.org/r/348869
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id0cc0dae29e12b26856f1ff3f39359ba95be8a3c
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 
Gerrit-Reviewer: ArielGlenn 
Gerrit-Reviewer: BBlack 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: RobH 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Merge remote-tracking branch 'origin/master' into HEAD

[Jdlrobson (Code Review)]

Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348871 )

Change subject: Merge remote-tracking branch 'origin/master' into HEAD
..

Merge remote-tracking branch 'origin/master' into HEAD

Additional changes:
* Use Skin:getSkinOption to register print styles
SkinMinerva no longer knows anything about mobileContext.
Update how we add styles to the page

Change-Id: I293f6133160fee40e34c92b7d5c2865dc3c20a3c
---
M includes/Minerva.hooks.php
M includes/skins/SkinMinerva.php
2 files changed, 6 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/71/348871/1

diff --git a/includes/Minerva.hooks.php b/includes/Minerva.hooks.php
index cacafff..d74d02d 100644
--- a/includes/Minerva.hooks.php
+++ b/includes/Minerva.hooks.php
@@ -70,6 +70,8 @@
// setSkinOptions is not available
if ( $skin instanceof SkinMinerva ) {
$skin->setSkinOptions( [
+   SkinMinerva::OPTION_PRINT_STYLES
+   => $mobileContext->getConfigVariable( 
'MinervaPrintStyles' ),
SkinMinerva::OPTION_CATEGORIES
=> $mobileContext->getConfigVariable( 
'MinervaShowCategoriesButton' ),
SkinMinerva::OPTION_FONT_CHANGER
diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php
index 8f99e71..d3a87e0 100644
--- a/includes/skins/SkinMinerva.php
+++ b/includes/skins/SkinMinerva.php
@@ -17,6 +17,7 @@
const OPTION_FONT_CHANGER = 'fontChanger';
const OPTION_BACK_TO_TOP = 'backToTop';
const OPTION_TOGGLING = 'toggling';
+   const OPTION_PRINT_STYLES = 'printStyles';
 
/** @var string $skinname Name of this skin */
public $skinname = 'minerva';
@@ -59,6 +60,8 @@
self::OPTION_BACK_TO_TOP => false,
/** Whether sections can be collapsed (requires MobileFrontend 
and MobileFormatter) */
self::OPTION_TOGGLING => false,
+   /** Whether print styles should be loaded */
+   self::OPTION_PRINT_STYLES => false,
];
 
/**
@@ -321,7 +324,7 @@
public function initPage( OutputPage $out ) {
parent::initPage( $out );
$styles = [ 'mobile.usermodule.styles' ];
-   if ( $this->mobileContext->getConfigVariable( 
'MinervaPrintStyles' ) ) {
+   if ( $this->getSkinOption( self::OPTION_PRINT_STYLES ) ) {
$styles[] = 'skins.minerva.print.styles';
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/348871
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I293f6133160fee40e34c92b7d5c2865dc3c20a3c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: Remove delete-stale-branch: use scap clean instead

[Chad (Code Review)]

Chad has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348870 )

Change subject: Remove delete-stale-branch: use scap clean instead
..

Remove delete-stale-branch: use scap clean instead

Change-Id: I7c28d69b031d44ae857d98ef9b9f165d4c7e2eb6
---
D bin/delete-stale-branch
1 file changed, 0 insertions(+), 57 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/tools/release 
refs/changes/70/348870/1

diff --git a/bin/delete-stale-branch b/bin/delete-stale-branch
deleted file mode 100755
index a7a0245..000
--- a/bin/delete-stale-branch
+++ /dev/null
@@ -1,57 +0,0 @@
-#!/bin/bash
-
-# Copyright © 2015 Mukunda Modell
-#
-# This program is free software; you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation; either version 2 of the License, or
-# (at your option) any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License along
-# with this program; if not, write to the Free Software Foundation, Inc.,
-# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
-# http://www.gnu.org/copyleft/gpl.html
-#
-
-# Delete a stale deployment branch, either by specifying the version number
-# or "auto" to automatically pick a branch older than 5 weeks.
-# This will stage symlink changes and run dsh to delete the branch remotely.
-
-export STALE_VERSION=$1
-cd /srv/mediawiki-staging
-if [ "$1" == "" ]; then
-   echo "Usage: $0 [version|auto]"
-   echo "To delete a specific version:"
-echo "delete-stale 1.25wmf22"
-   echo "To automatically pick a stale version, use:"
-echo "delete-stale auto"
-   exit 1;
-fi
-
-if [ "$STALE_VERSION" == "auto" ]; then
-   STALE_VERSION=`find php-* -maxdepth 0 -type d -mtime +35 | head -1`
-fi
-
-if [ "${STALE_VERSION:0:4}" == "php-" ]; then
-   export STALE_VERSION="${STALE_VERSION:4}"
-fi
-
-if [ "$STALE_VERSION" == "" ]; then
-   echo "Unable to determine a stale version to delete"
-   exit 1
-fi
-
-read -p "About to delete php-$STALE_VERSION. Continue? "
-
-multiversion/deleteMediaWiki php-$STALE_VERSION
-sudo -u l10nupdate rm -rf php-$STALE_VERSION/cache/l10n/*
-rm -rf php-$STALE_VERSION
-
-SSH_AUTH_SOCK=/run/keyholder/proxy.sock dsh -F 20 -M -g scap-masters -r ssh -o 
-oUser=mwdeploy -- rm -rf /srv/mediawiki/php-$STALE_VERSION
-SSH_AUTH_SOCK=/run/keyholder/proxy.sock dsh -F 20 -M -g scap-proxies -r ssh -o 
-oUser=mwdeploy -- rm -rf /srv/mediawiki/php-$STALE_VERSION
-SSH_AUTH_SOCK=/run/keyholder/proxy.sock dsh -F 20 -M -g mediawiki-installation 
-r ssh -o -oUser=mwdeploy -- rm -rf /srv/mediawiki/php-$STALE_VERSION

-- 
To view, visit https://gerrit.wikimedia.org/r/348870
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7c28d69b031d44ae857d98ef9b9f165d4c7e2eb6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/release
Gerrit-Branch: master
Gerrit-Owner: Chad 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] apps...java-mwapi[master]: git.wikimedia.org -> phab

[Mholloway (Code Review)]

Mholloway has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348318 )

Change subject: git.wikimedia.org -> phab
..


git.wikimedia.org -> phab

Bug: T139089
Change-Id: I55f15a9e33d5ac5835f7ca8f067920ff088782c1
---
M deploy.gradle
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  jenkins-bot: Verified
  Mholloway: Looks good to me, approved



diff --git a/deploy.gradle b/deploy.gradle
index f1c3d9b..acf4efc 100644
--- a/deploy.gradle
+++ b/deploy.gradle
@@ -4,11 +4,11 @@
 project {
 name 'json'
 description 'MediaWiki JSON API Java bindings.'
-url 
'https://git.wikimedia.org/blob/apps%2Fandroid%2Fjava-mwapi.git/master/README.md'
+url 
'https://phabricator.wikimedia.org/diffusion/APAJ/repository/master/'
 inceptionYear '2013'
 
 scm {
-url 
'https://git.wikimedia.org/blob/apps%2Fandroid%2Fjava-mwapi.git/master/README.md'
+url 
'https://phabricator.wikimedia.org/diffusion/APAJ/repository/master/'
 connection 
'scm:git:https://gerrit.wikimedia.org/r/apps/android/java-mwapi'
 developerConnection 
'scm:git:https://gerrit.wikimedia.org/r/apps/android/java-mwapi'
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/348318
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I55f15a9e33d5ac5835f7ca8f067920ff088782c1
Gerrit-PatchSet: 2
Gerrit-Project: apps/android/java-mwapi
Gerrit-Branch: master
Gerrit-Owner: TerraCodes 
Gerrit-Reviewer: Dbrant 
Gerrit-Reviewer: Mholloway 
Gerrit-Reviewer: Niedzielski 
Gerrit-Reviewer: TerraCodes 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: dumps: skip cert monitoring where Letsencrypt is disabled

[Dzahn (Code Review)]

Dzahn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348869 )

Change subject: dumps: skip cert monitoring where Letsencrypt is disabled
..

dumps: skip cert monitoring where Letsencrypt is disabled

Just like done for tendril, in I7d1b09429070a0433447,
skip the Icinga certificate monitoring if do_acme
(the override to skip Letsencrypt cert creation) is set
to false.

If we don't renew certs (on a passive/failover/standy server that
doesn't have the DNS name) we also don't want to monitor them,
or we get false alerts that cause concerns for no reason.

Change-Id: Id0cc0dae29e12b26856f1ff3f39359ba95be8a3c
---
M modules/role/manifests/dumps/server.pp
1 file changed, 6 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/69/348869/1

diff --git a/modules/role/manifests/dumps/server.pp 
b/modules/role/manifests/dumps/server.pp
index 8f83174..fbabe1a 100644
--- a/modules/role/manifests/dumps/server.pp
+++ b/modules/role/manifests/dumps/server.pp
@@ -9,9 +9,12 @@
 check_command => 'check_http'
 }
 
-monitoring::service { 'https':
-description   => 'HTTPS',
-check_command => 'check_ssl_http_letsencrypt!dumps.wikimedia.org',
+# TODO: move hiera lookup to parameter of a profile class
+if hiera('do_acme', true) { 
+monitoring::service { 'https':
+description   => 'HTTPS',
+check_command => 'check_ssl_http_letsencrypt!dumps.wikimedia.org',
+}
 }
 
 # By default the resolve() function in ferm performs only an IPv4/A DNS

-- 
To view, visit https://gerrit.wikimedia.org/r/348869
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id0cc0dae29e12b26856f1ff3f39359ba95be8a3c
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Recognize SocketTimeoutException as an offline error

[Mholloway (Code Review)]

Mholloway has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348868 )

Change subject: Recognize SocketTimeoutException as an offline error
..

Recognize SocketTimeoutException as an offline error

Some devices attempt to connect and throw a SocketTimeoutException rather
than immediately returning an UnknownHostException.  Add this to the list
to check in ThrowableUtil.isOffline.

Change-Id: I4f4568e8579e271418ec40de1b48ec2ddb589221
---
M app/src/main/java/org/wikipedia/util/ThrowableUtil.java
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/68/348868/1

diff --git a/app/src/main/java/org/wikipedia/util/ThrowableUtil.java 
b/app/src/main/java/org/wikipedia/util/ThrowableUtil.java
index c3ea004..d81e7ee 100644
--- a/app/src/main/java/org/wikipedia/util/ThrowableUtil.java
+++ b/app/src/main/java/org/wikipedia/util/ThrowableUtil.java
@@ -15,6 +15,7 @@
 import org.wikipedia.login.LoginClient;
 
 import java.net.SocketException;
+import java.net.SocketTimeoutException;
 import java.net.UnknownHostException;
 import java.util.concurrent.TimeoutException;
 
@@ -75,7 +76,9 @@
 }
 
 public static boolean isOffline(@NonNull Throwable caught) {
-return caught instanceof UnknownHostException || caught instanceof 
SocketException;
+return caught instanceof UnknownHostException
+|| caught instanceof SocketException
+|| caught instanceof SocketTimeoutException;
 }
 
 public static boolean is404(@NonNull Context ctx, @NonNull Throwable 
caught) {

-- 
To view, visit https://gerrit.wikimedia.org/r/348868
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f4568e8579e271418ec40de1b48ec2ddb589221
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mholloway 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: MediaWiki theme: Ensure WCAG level AA contrast on unsupporte...

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348863 )

Change subject: MediaWiki theme: Ensure WCAG level AA contrast on unsupported 
SelectFileWidget
..


MediaWiki theme: Ensure WCAG level AA contrast on unsupported SelectFileWidget

Ensuring WCAG level AA conforming contrast on unsupported SelectFileWidget
message.

Change-Id: Iaf9fc97f13661e8160fc5348f513baf57b5b46d3
---
M src/themes/mediawiki/widgets.less
1 file changed, 20 insertions(+), 10 deletions(-)

Approvals:
  Bartosz Dziewoński: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/src/themes/mediawiki/widgets.less 
b/src/themes/mediawiki/widgets.less
index 9305aac..fa5156c 100644
--- a/src/themes/mediawiki/widgets.less
+++ b/src/themes/mediawiki/widgets.less
@@ -1452,13 +1452,7 @@
}
 
&.oo-ui-widget-disabled,
-   &-empty.oo-ui-widget-disabled,
-   &-notsupported {
-   &.oo-ui-selectFileWidget-dropTarget {
-   background-color: @background-color-disabled;
-   border-color: @border-color-disabled;
-   }
-
+   &-empty.oo-ui-widget-disabled {
.oo-ui-selectFileWidget-info {
background-color: @background-color-disabled;
color: @color-disabled;
@@ -1473,11 +1467,27 @@
opacity: @opacity-disabled-indicator;
}
}
+
+   &.oo-ui-selectFileWidget-dropTarget {
+   background-color: @background-color-disabled;
+   border-color: @border-color-disabled;
+   }
}
 
-   &-notsupported.oo-ui-selectFileWidget-dropTarget {
-   .oo-ui-selectFileWidget-label {
-   padding: 1em @padding-horizontal-default;
+   &-notsupported {
+   .oo-ui-selectFileWidget-info {
+   background-color: @background-color-disabled;
+   color: @color-default;
+   border-color: @border-color-disabled;
+   }
+
+   &.oo-ui-selectFileWidget-dropTarget {
+   background-color: @background-color-disabled;
+   border-color: @border-color-disabled;
+
+   .oo-ui-selectFileWidget-label {
+   padding: 1em @padding-horizontal-default;
+   }
}
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/348863
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf9fc97f13661e8160fc5348f513baf57b5b46d3
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: VolkerE 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: announcements: Remove recruitment surveys

[BearND (Code Review)]

BearND has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348867 )

Change subject: announcements: Remove recruitment surveys
..

announcements: Remove recruitment surveys

Bug: T163256
Change-Id: Ibdf904cea4454f4347b7bf962e826ce34f00d52a
---
M routes/announcements.js
M spec.yaml
M test/features/announcements/announcements.js
3 files changed, 4 insertions(+), 64 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps 
refs/changes/67/348867/1

diff --git a/routes/announcements.js b/routes/announcements.js
index b91e449..87c72a2 100644
--- a/routes/announcements.js
+++ b/routes/announcements.js
@@ -9,54 +9,7 @@
 const router = sUtil.router();
 
 function getEnwikiAnnouncements() {
-return [
-{
-id: "EN0217SURVEYIOS",
-type: "survey",
-start_time: "2017-02-09T00:00:00Z",
-end_time: "2017-02-14T00:00:00Z",
-platforms: [
-"iOSApp",
-],
-text: "Help to improve the Wikipedia mobile apps by signing up to 
be a user tester. Take a quick survey to participate in an upcoming study or 
research interview.", // eslint-disable-line max-len
-action: {
-title: "Sign up",
-url: "https://goo.gl/forms/AjwqEK42MaHMUsoN2;
-},
-caption_HTML: "Hosted by a third-party service. See the https://m.wikimediafoundation.org/wiki/Mobile_User_Testing_Recruitment_Survey_Privacy_Statement\;>privacy
 statement for information on data handling.",
-countries: [
-"US",
-"CA",
-"GB",
-"IE",
-"AU",
-"NZ"
-]
-},
-{
-id: "EN0217SURVEYANDROID",
-type: "survey",
-start_time: "2017-02-11T00:00:00Z",
-end_time: "2017-02-13T00:00:00Z",
-platforms: [
-"AndroidApp"
-],
-text: "Help to improve the Wikipedia mobile apps by signing up to 
be a user tester. Take a quick survey to participate in an upcoming study or 
research interview.", // eslint-disable-line max-len
-action: {
-title: "Sign up",
-url: "https://goo.gl/forms/AjwqEK42MaHMUsoN2;
-},
-caption_HTML: "Hosted by a third-party service. See the https://m.wikimediafoundation.org/wiki/Mobile_User_Testing_Recruitment_Survey_Privacy_Statement\;>privacy
 statement for information on data handling.",
-countries: [
-"US",
-"CA",
-"GB",
-"IE",
-"AU",
-"NZ"
-]
-}
-];
+return [];
 }
 
 /**
diff --git a/spec.yaml b/spec.yaml
index a3d5f15..f27040d 100644
--- a/spec.yaml
+++ b/spec.yaml
@@ -85,18 +85,7 @@
 headers:
   content-type: application/json
 body:
-  announce:
-- id: /.+/
-  type: /.+/
-  start_time: /.+/
-  end_time: /.+/
-  platforms: [ /.+/ ]
-  text: /.+/
-  action:
-title: /.+/
-url: /.+/
-  caption_HTML: /.+/
-  countries: [ /.+/ ]
+  announce: []
 
   # from routes/on-this-day.js
   /{domain}/v1/feed/onthisday/{type}/{mm}/{dd}:
diff --git a/test/features/announcements/announcements.js 
b/test/features/announcements/announcements.js
index 1737c01..b0063bf 100644
--- a/test/features/announcements/announcements.js
+++ b/test/features/announcements/announcements.js
@@ -34,12 +34,10 @@
 });
 });
 
-it('should return two surveys', () => {
+it('should return 0 surveys', () => {
 return preq.get({ uri: 
`${server.config.uri}en.wikipedia.org/v1/feed/announcements` })
 .then((res) => {
-assert.ok(res.body.announce.length === 2);
-assert.equal(res.body.announce[0].id, 'EN0217SURVEYIOS');
-assert.equal(res.body.announce[1].id, 'EN0217SURVEYANDROID');
+assert.ok(res.body.announce.length === 0);
 });
 });
 

-- 
To view, visit https://gerrit.wikimedia.org/r/348867
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibdf904cea4454f4347b7bf962e826ce34f00d52a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: BearND 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: DropdownInput-/RadioSelectInputWidget: Remove unnecessary AR...

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348859 )

Change subject: DropdownInput-/RadioSelectInputWidget: Remove unnecessary ARIA 
attributes
..


DropdownInput-/RadioSelectInputWidget: Remove unnecessary ARIA attributes

The input is already hidden with `type=hidden` and therefore
doesn't need `aria-disabled` or `tabindex` attributes set.

Change-Id: I5bb81f7e7cee3dfeb0dc1ad65eda34f8d157ed85
---
M src/widgets/DropdownInputWidget.js
M src/widgets/RadioSelectInputWidget.js
2 files changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Bartosz Dziewoński: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/src/widgets/DropdownInputWidget.js 
b/src/widgets/DropdownInputWidget.js
index 6e0f908..8443c20 100644
--- a/src/widgets/DropdownInputWidget.js
+++ b/src/widgets/DropdownInputWidget.js
@@ -58,6 +58,7 @@
this.$element
.addClass( 'oo-ui-dropdownInputWidget' )
.append( this.dropdownWidget.$element );
+   this.setTabIndexedElement( null );
 };
 
 /* Setup */
diff --git a/src/widgets/RadioSelectInputWidget.js 
b/src/widgets/RadioSelectInputWidget.js
index 250d863..a59270e 100644
--- a/src/widgets/RadioSelectInputWidget.js
+++ b/src/widgets/RadioSelectInputWidget.js
@@ -44,6 +44,7 @@
this.$element
.addClass( 'oo-ui-radioSelectInputWidget' )
.append( this.radioSelectWidget.$element );
+   this.setTabIndexedElement( null );
 };
 
 /* Setup */

-- 
To view, visit https://gerrit.wikimedia.org/r/348859
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5bb81f7e7cee3dfeb0dc1ad65eda34f8d157ed85
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix: Update error handling to handle new cache responses

[Mholloway (Code Review)]

Mholloway has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348866 )

Change subject: Fix: Update error handling to handle new cache responses
..

Fix: Update error handling to handle new cache responses

Minor fix so that missing pages (404s) are once again detected correctly.

Bug: T161008
Change-Id: I502dbd46489621ffde904a3fc487c8be5a37351e
---
M app/src/main/java/org/wikipedia/util/ThrowableUtil.java
1 file changed, 12 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/66/348866/1

diff --git a/app/src/main/java/org/wikipedia/util/ThrowableUtil.java 
b/app/src/main/java/org/wikipedia/util/ThrowableUtil.java
index 4769364..9f945ab 100644
--- a/app/src/main/java/org/wikipedia/util/ThrowableUtil.java
+++ b/app/src/main/java/org/wikipedia/util/ThrowableUtil.java
@@ -74,18 +74,22 @@
 return result;
 }
 
-public static boolean is404(@NonNull Context ctx, @NonNull Throwable e) {
-return is404(ThrowableUtil.getAppError(ctx, e));
-}
-
-public static boolean is404(@NonNull ThrowableUtil.AppError e) {
-return e.getDetail() != null && e.getDetail().contains("404");
-}
-
 public static boolean isOffline(@NonNull Throwable caught) {
 return caught instanceof UnknownHostException || caught instanceof 
SocketException;
 }
 
+public static boolean is404(@NonNull Context ctx, @NonNull Throwable 
caught) {
+return is404(caught) || is404(ThrowableUtil.getAppError(ctx, caught));
+}
+
+private static boolean is404(@NonNull Throwable caught) {
+return caught instanceof HttpStatusException && ((HttpStatusException) 
caught).code() == 404;
+}
+
+private static boolean is404(@NonNull ThrowableUtil.AppError e) {
+return e.getDetail() != null && e.getDetail().contains("404");
+}
+
 private static boolean isNetworkError(@NonNull Throwable e) {
 return ThrowableUtil.throwableContainsException(e, 
HttpRequest.HttpRequestException.class)
 || ThrowableUtil.throwableContainsException(e, 
HttpStatusException.class)

-- 
To view, visit https://gerrit.wikimedia.org/r/348866
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I502dbd46489621ffde904a3fc487c8be5a37351e
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mholloway 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix: remove hardware feature requirements

[Niedzielski (Code Review)]

Niedzielski has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348865 )

Change subject: Fix: remove hardware feature requirements
..

Fix: remove hardware feature requirements

Forcefully remove unnecessary hardware requirements. Previously, the log
file, app/build/outputs/logs/manifest-merger-dev-debug-report.txt, would
show*:

  ADDED from 
/home/stephen/Desktop/wikipedia/app/src/main/AndroidManifest.xml:35:5-87
  MERGED from [com.mapzen.android:lost:2.1.2] 
/home/stephen/.android/build-cache/9ceaebdefe79b93c3000b583d40901838bcdedd4/output/AndroidManifest.xml:12:5-62
  android:required
  ADDED from 
/home/stephen/Desktop/wikipedia/app/src/main/AndroidManifest.xml:35:60-84
MERGED from 
/home/stephen/Desktop/wikipedia/app/src/custom/AndroidManifest.xml
  android:name
  ADDED from /home/stephen/Desktop/wikipedia/app/src/main/

Then with tools:node="remove":

  uses-feature#android.hardware.location
  ADDED from 
/home/stephen/dev/wmf/wikipedia-android/app/src/main/AndroidManifest.xml:35:5-107
  REJECTED from [com.mapzen.android:lost:2.1.2] 
/home/stephen/.android/build-cache/9ceaebdefe79b93c3000b583d40901838bcdedd4/output/AndroidManifest.xml:12:5-62
tools:node
  ADDED from 
/home/stephen/dev/wmf/wikipedia-android/app/src/main/AndroidManifest.xml:35:60-79
android:required
  ADDED from 
/home/stephen/dev/wmf/wikipedia-android/app/src/main/AndroidManifest.xml:35:80-104
android:name
  ADDED from 
/home/stephen/dev/wmf/wikipedia-android/app/src/main/AndroidManifest.xml:35:19-59

But that didn't seem to actually work even though the report appeared
correct. After this patch (with tools:node="replace"):

  uses-feature#android.hardware.location
  ADDED from 
/home/stephen/dev/wmf/wikipedia-android/app/src/main/AndroidManifest.xml:36:5-108
  REJECTED from [com.mapzen.android:lost:2.1.2] 
/home/stephen/.android/build-cache/9ceaebdefe79b93c3000b583d40901838bcdedd4/output/AndroidManifest.xml:12:5-62
tools:node
  ADDED from 
/home/stephen/dev/wmf/wikipedia-android/app/src/main/AndroidManifest.xml:36:60-80
android:required
  ADDED from 
/home/stephen/dev/wmf/wikipedia-android/app/src/main/AndroidManifest.xml:36:81-105
android:name
  ADDED from 
/home/stephen/dev/wmf/wikipedia-android/app/src/main/AndroidManifest.xml:36:19-59

*Paths differ some due to different build locations.

This patch also enables strict mode to require manual resolution of
conflicts in the future.

More on manifest merger: 
https://developer.android.com/studio/build/manifest-merge.html
Upstream change: 
https://github.com/mapzen/lost/commit/b59880df7bd91d193206c268253e704d313aae63

Change-Id: I186d9ed9dbee3c38008e7ecd5b0763a19719b4b2
---
M app/src/main/AndroidManifest.xml
1 file changed, 5 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/65/348865/1

diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
index 6ce6068..cf060f0 100644
--- a/app/src/main/AndroidManifest.xml
+++ b/app/src/main/AndroidManifest.xml
@@ -2,7 +2,8 @@
 http://schemas.android.com/apk/res/android;
 xmlns:tools="http://schemas.android.com/tools;
 package="org.wikipedia"
-android:installLocation="auto">
+android:installLocation="auto"
+tools:node="strict">
 
 
-
-
+
+
 
+
 
 

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Revert: add alternate casing for device feature requirements

[Niedzielski (Code Review)]

Niedzielski has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348864 )

Change subject: Revert: add alternate casing for device feature requirements
..

Revert: add alternate casing for device feature requirements

This reverts commit b395f6bb2f9e31633fb2e946ad1ba58d87538c07 which
didn't work.

Change-Id: I4dc67e3c771abed1156ac2479350955a1946cffd
---
M app/src/main/AndroidManifest.xml
1 file changed, 0 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/64/348864/1

diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
index 0ccf8d9..6ce6068 100644
--- a/app/src/main/AndroidManifest.xml
+++ b/app/src/main/AndroidManifest.xml
@@ -33,11 +33,8 @@
 
 
 
-
 
-
 
-
 
 

[MediaWiki-commits] [Gerrit] oojs/ui[master]: MediaWiki theme: Ensure WCAG level AA contrast on unsupporte...

[VolkerE (Code Review)]

VolkerE has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348863 )

Change subject: MediaWiki theme: Ensure WCAG level AA contrast on unsupported 
SelectFileWidget
..

MediaWiki theme: Ensure WCAG level AA contrast on unsupported SelectFileWidget

Ensuring WCAG level AA conforming contrast on unsupported SelectFileWidget
message.

Change-Id: Iaf9fc97f13661e8160fc5348f513baf57b5b46d3
---
M src/themes/mediawiki/widgets.less
1 file changed, 20 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/63/348863/1

diff --git a/src/themes/mediawiki/widgets.less 
b/src/themes/mediawiki/widgets.less
index 9305aac..fa5156c 100644
--- a/src/themes/mediawiki/widgets.less
+++ b/src/themes/mediawiki/widgets.less
@@ -1452,13 +1452,7 @@
}
 
&.oo-ui-widget-disabled,
-   &-empty.oo-ui-widget-disabled,
-   &-notsupported {
-   &.oo-ui-selectFileWidget-dropTarget {
-   background-color: @background-color-disabled;
-   border-color: @border-color-disabled;
-   }
-
+   &-empty.oo-ui-widget-disabled {
.oo-ui-selectFileWidget-info {
background-color: @background-color-disabled;
color: @color-disabled;
@@ -1473,11 +1467,27 @@
opacity: @opacity-disabled-indicator;
}
}
+
+   &.oo-ui-selectFileWidget-dropTarget {
+   background-color: @background-color-disabled;
+   border-color: @border-color-disabled;
+   }
}
 
-   &-notsupported.oo-ui-selectFileWidget-dropTarget {
-   .oo-ui-selectFileWidget-label {
-   padding: 1em @padding-horizontal-default;
+   &-notsupported {
+   .oo-ui-selectFileWidget-info {
+   background-color: @background-color-disabled;
+   color: @color-default;
+   border-color: @border-color-disabled;
+   }
+
+   &.oo-ui-selectFileWidget-dropTarget {
+   background-color: @background-color-disabled;
+   border-color: @border-color-disabled;
+
+   .oo-ui-selectFileWidget-label {
+   padding: 1em @padding-horizontal-default;
+   }
}
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/348863
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaf9fc97f13661e8160fc5348f513baf57b5b46d3
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...parsoid[master]: T162919: Don't lint fostered rendering-transparent nodes

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348507 )

Change subject: T162919: Don't lint fostered rendering-transparent nodes
..


T162919: Don't lint fostered rendering-transparent nodes

* These fostered nodes don't affect rendering and linting them
  only serves to confuse editors.

Change-Id: I0efd4857e235f9aea12f53c274f6871128ba80ce
---
M lib/wt2html/pp/handlers/linter.js
M tests/mocha/linter.js
2 files changed, 26 insertions(+), 2 deletions(-)

Approvals:
  jenkins-bot: Verified
  Arlolra: Looks good to me, approved



diff --git a/lib/wt2html/pp/handlers/linter.js 
b/lib/wt2html/pp/handlers/linter.js
index 818638d..39624e1 100644
--- a/lib/wt2html/pp/handlers/linter.js
+++ b/lib/wt2html/pp/handlers/linter.js
@@ -398,8 +398,11 @@
// Log bogus image options
logBogusImageOptions(env, node, dp, tplInfo);
 
-   if (dp.fostered) {
-   // Log Fostered content
+   // Log fostered content, but skip rendering-transparent nodes
+   //
+   // FIXME: Create a separate emitsRenderingTransparentHTML helper
+   // and use it everywhere where this helper is being used as a proxy.
+   if (dp.fostered && !DU.emitsSolTransparentSingleLineWT(env, node, 
true)) {
return logFosteredContent(env, node, dp, tplInfo);
} else {
return true;
diff --git a/tests/mocha/linter.js b/tests/mocha/linter.js
index 5f52149..80e036b 100644
--- a/tests/mocha/linter.js
+++ b/tests/mocha/linter.js
@@ -138,6 +138,27 @@
result[0].dsr.should.deep.equal([ 0, 18, 2, 2 
]);
});
});
+   it('should not lint fostered categories', function() {
+   return parseWT('{|\n[[Category:Fostered]]\n|-\n| 
bar\n|}').then(function(result) {
+   result.should.have.length(0);
+   });
+   });
+   it('should not lint fostered behavior switches', function() {
+   return parseWT('{|\n__NOTOC__\n|-\n| 
bar\n|}').then(function(result) {
+   result.should.have.length(0);
+   });
+   });
+   it('should not lint fostered include directives without 
fostered content', function() {
+   return 
parseWT('{|\nboo\n|-\n| 
bar\n|}').then(function(result) {
+   result.should.have.length(0);
+   });
+   });
+   it('should lint fostered include directives that has fostered 
content', function() {
+   return parseWT('{|\nboo\n|-\n| 
bar\n|}').then(function(result) {
+   result.should.have.length(1);
+   result[0].should.have.a.property("type", 
"fostered");
+   });
+   });
it('should lint ignored table attributes Correctly', function() 
{
return parseWT('{|\n|- 
foo\n|bar\n|}').then(function(result) {
result.should.have.length(1);

-- 
To view, visit https://gerrit.wikimedia.org/r/348507
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0efd4857e235f9aea12f53c274f6871128ba80ce
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry 
Gerrit-Reviewer: Arlolra 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Keystone: Kill off novaobserver and novaadmin tokens after ...

[Andrew Bogott (Code Review)]

Andrew Bogott has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348862 )

Change subject: Keystone:  Kill off novaobserver and novaadmin tokens after 2+ 
hours.
..

Keystone:  Kill off novaobserver and novaadmin tokens after 2+ hours.

This is a bit horrifying but should improve keystone performance
dramatically.

Bug: T163259
Change-Id: I63be6533b30db03d648fd54c9136c919aa6ac91a
---
M modules/openstack/manifests/keystone/service.pp
1 file changed, 240 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/62/348862/1

diff --git a/modules/openstack/manifests/keystone/service.pp 
b/modules/openstack/manifests/keystone/service.pp
index e696359..fd170c3 100644
--- a/modules/openstack/manifests/keystone/service.pp
+++ b/modules/openstack/manifests/keystone/service.pp
@@ -103,6 +103,246 @@
 command => '/usr/bin/keystone-manage token_flush > /dev/null 
2>&1',
 }
 
+# Clean up service user tokens.  These tend to pile up
+#  quickly, and are never used for Horizon sessions.
+#  so, don't wait for them to expire, just delete them
+#  after a few hours.
+#
+# Tokens only know when they expire and not when they
+#  were created.  Since token lifespan is 7.1
+#  days (613440 seconds), any token that expires
+#  less than 7 days from now is already at least
+#  2 hours old.
+$keystone_db_name = $keystoneconfig['db_name']
+$keystone_db_user = $keystoneconfig['db_user']
+$keystone_db_pass = $keystoneconfig['db_pass']
+$keystone_db_host = $keystoneconfig['db_host']
+cron {
+'cleanup_novaobserver_keystone_tokens':
+ensure  => present,
+user=> 'root',
+minute  => 30,
+command => "/usr/bin/mysql ${keystone_db_name} 
-h${keystone_db_host} -u${keystone_db_user} -p${keystone_db_pass} -e 'DELETE 
FROM token WHERE NOW() + INTERVAL 7 day > expires and user_id='novaobserver' 
LIMIT 1;'",
+}
+cron {
+'cleanup_novaadmin_keystone_tokens':
+ensure  => present,
+user=> 'root',
+minute  => 40,
+command => "/usr/bin/mysql ${keystone_db_name} 
-h${keystone_db_host} -u${keystone_db_user} -p${keystone_db_pass} -e 'DELETE 
FROM token WHERE NOW() + INTERVAL 7 day > expires and user_id='novaadmin' LIMIT 
1;'",
+}
+
+monitoring::service { 'keystone-http-35357':
+description   => 'keystone http',
+check_command => 'check_http_on_port!35357',
+}
+monitoring::service { 'keystone-http-5000': # v2 api is limited here
+description   => 'keystone http',
+check_command => 'check_http_on_port!5000',
+}
+
+if ($openstack_version == 'liberty') {
+# Keystone says that you should run it with uwsgi in Liberty,
+#  but it's actually buggy and terrible in that config.  So, use 
eventlet
+#  ('keystone' service) on liberty, and we'll try uwsgi again on 
mitaka.
+$enable_uwsgi = false
+
+service { 'keystone':
+ensure=> running,
+subscribe => File['/etc/keystone/keystone.conf'],
+require   => Package['keystone'];
+}
+service { 'uwsgi-keystone-admin':
+ensure => stopped,
+}
+service { 'uwsgi-keystone-public':
+ensure => stopped,
+}
+} else {
+$enable_uwsgi = true
+
+# stop the keystone process itself; this will be handled
+#  by uwsgi
+service { 'keystone':
+ensure  => stopped,
+require => Package['keystone'];
+}
+file {'/etc/init/keystone.conf':
+ensure  => 'absent';
+}
+}
+} else {
+$enable_uwsgi = false
+
+# Because of the enabled => false, the uwsgi::app
+#  declarations below don't actually define
+#  services for the keystone processes.  We need
+#  to define them here (even though they're stopped)
+#  so we can refer to them elsewhere.
+service { 'uwsgi-keystone-admin':
+ensure => stopped,
+}
+service { 'uwsgi-keystone-public':
+ensure => stopped,
+}
+service { 'keystone':
+ensure  => stopped,
+require => Package['keystone'];
+}
+}
+
+# Set up uwsgi services
+
+# Keystone admin API
+uwsgi::app { 'keystone-admin':
+enabled  => $enable_uwsgi,
+settings => {
+uwsgi => {
+die-on-term => true,
+http=> 

[MediaWiki-commits] [Gerrit] mediawiki/event-schemas[master]: Topic-Config: Use regex topic definitions for rerty topics.

[Ppchelko (Code Review)]

Ppchelko has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348861 )

Change subject: Topic-Config: Use regex topic definitions for rerty topics.
..

Topic-Config: Use regex topic definitions for rerty topics.

All the Change-Prop retry topics share the same schema, so it's
an excellent test-case fort the new eventlogging-service feature
to support regexed topic names.

Bug: T157091
Change-Id: I383a67a37447482007a036c7527fd7b609fb1a89
Depends-On: Ie33fb27798940927b9df87749683a35c484ae02f
---
M config/eventbus-topics.yaml
1 file changed, 3 insertions(+), 32 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/event-schemas 
refs/changes/61/348861/1

diff --git a/config/eventbus-topics.yaml b/config/eventbus-topics.yaml
index a3031fd..8b9c277 100644
--- a/config/eventbus-topics.yaml
+++ b/config/eventbus-topics.yaml
@@ -39,44 +39,13 @@
 resource_change:
   schema_name: resource_change
 
-# Change propagation retry queues
-change-prop.retry.mediawiki.page-delete:
-  schema_name: change-prop/retry
-
-change-prop.retry.mediawiki.page-move:
-  schema_name: change-prop/retry
-
-change-prop.retry.mediawiki.page-undelete:
-  schema_name: change-prop/retry
-
-change-prop.retry.mediawiki.page-properties-change:
-  schema_name: change-prop/retry
-
-change-prop.retry.mediawiki.revision-visibility-change:
-  schema_name: change-prop/retry
-
-change-prop.retry.mediawiki.revision-create:
-  schema_name: change-prop/retry
-
-change-prop.retry.mediawiki.user-blocks-change:
-  schema_name: change-prop/retry
-
-change-prop.retry.resource_change:
-  schema_name: change-prop/retry
-
 ## Continuation topics for backlinks processing in change propagation service
 change-prop.backlinks.continue:
   schema_name: change-prop/continue
 
-change-prop.retry.change-prop.backlinks.continue:
-  schema_name: change-prop/retry
-
 ## Continuation topics for transcludes processing in change propagation service
 change-prop.transcludes.continue:
   schema_name: change-prop/continue
-
-change-prop.retry.change-prop.transcludes.continue:
-  schema_name: change-prop/retry
 
 ## General error topic for change propagation
 change-prop.error:
@@ -86,5 +55,7 @@
 change-prop.transcludes.resource-change:
   schema_name: resource_change
 
-change-prop.retry.change-prop.transcludes.resource-change:
+# Change propagation retry queues
+/^change-prop\.retry/:
   schema_name: change-prop/retry
+

-- 
To view, visit https://gerrit.wikimedia.org/r/348861
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I383a67a37447482007a036c7527fd7b609fb1a89
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/event-schemas
Gerrit-Branch: master
Gerrit-Owner: Ppchelko 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...parsoid[master]: Improve config.example.yaml documentation.

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348237 )

Change subject: Improve config.example.yaml documentation.
..


Improve config.example.yaml documentation.

Change-Id: I619e2f06ff5ef7a0b02f4395ed919aed9971c435
---
M config.example.yaml
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  jenkins-bot: Verified
  Arlolra: Looks good to me, approved



diff --git a/config.example.yaml b/config.example.yaml
index fff190d..e74103a 100644
--- a/config.example.yaml
+++ b/config.example.yaml
@@ -37,8 +37,9 @@
   uri: 'http://localhost/w/api.php'
   # The "domain" is used for communication with Visual Editor
   # and RESTBase.  It defaults to the hostname portion of
-  # the `uri` property below, but you can manually set it
-  # to an arbitrary string.
+  # the `uri` property above, but you can manually set it
+  # to an arbitrary string. It must match the "domain" set
+  # in $wgVirtualRestConfig.
   domain: 'localhost'  # optional
   # To specify a proxy (or proxy headers) specific to this prefix
   # (which overrides defaultAPIProxyURI). Alternatively, set `proxy`

-- 
To view, visit https://gerrit.wikimedia.org/r/348237
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I619e2f06ff5ef7a0b02f4395ed919aed9971c435
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: C. Scott Ananian 
Gerrit-Reviewer: Arlolra 
Gerrit-Reviewer: Subramanya Sastry 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...parsoid[master]: Improve documentation for sync-parserTests a bit.

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348235 )

Change subject: Improve documentation for sync-parserTests a bit.
..


Improve documentation for sync-parserTests a bit.

Change-Id: If85b92ce4db9edba9e01fd8dc182bb8dc4e9efd5
---
M tools/sync-parserTests.js
1 file changed, 6 insertions(+), 4 deletions(-)

Approvals:
  jenkins-bot: Verified
  Arlolra: Looks good to me, approved



diff --git a/tools/sync-parserTests.js b/tools/sync-parserTests.js
index d58fef5..c7560b5 100755
--- a/tools/sync-parserTests.js
+++ b/tools/sync-parserTests.js
@@ -8,9 +8,11 @@
 
Basic use:
  $PARSOID is the path to a checked out git copy of Parsoid
- $REPO is the path to a checked out git copy of the repo containing the 
parserTest file
- $BRANCH is a branch name for the patch to $REPO (ie, 'pt-sync')
- $TARGET is the key to parserTests.json we're sync'ing
+ $REPO is the path to a checked out git copy of the repo containing
+   the parserTest file. (Check the `repo` key in tests/parserTests.json)
+ $BRANCH is a branch name for the patch to $REPO (ie, 'ptsync-')
+ $TARGET identifies which set of parserTests we're synchronizing.
+   (This should be one of the top-level keys in tests/parserTests.json)
 
$ cd $PARSOID
$ tools/sync-parserTests.js $REPO $BRANCH $TARGET
@@ -21,7 +23,7 @@
  ... fix any failures by marking tests parsoid-only, etc ...
$ git review
 
- ... time passes, eventually your patch is merged to core ...
+ ... time passes, eventually your patch is merged to $REPO ...
 
$ cd $PARSOID
$ tools/fetch-parserTests.txt.js $TARGET --force

-- 
To view, visit https://gerrit.wikimedia.org/r/348235
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If85b92ce4db9edba9e01fd8dc182bb8dc4e9efd5
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: C. Scott Ananian 
Gerrit-Reviewer: Arlolra 
Gerrit-Reviewer: Subramanya Sastry 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: DropdownInput-/RadioSelectInputWidget: Remove unnecessary AR...

[VolkerE (Code Review)]

VolkerE has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348859 )

Change subject: DropdownInput-/RadioSelectInputWidget: Remove unnecessary ARIA 
attributes
..

DropdownInput-/RadioSelectInputWidget: Remove unnecessary ARIA attributes

The input is already hidden with `type=hidden` and therefore
doesn't need `aria-disabled` or `tabindex` attributes set.

Change-Id: I5bb81f7e7cee3dfeb0dc1ad65eda34f8d157ed85
---
M src/widgets/DropdownInputWidget.js
M src/widgets/RadioSelectInputWidget.js
2 files changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/59/348859/1

diff --git a/src/widgets/DropdownInputWidget.js 
b/src/widgets/DropdownInputWidget.js
index 6e0f908..8443c20 100644
--- a/src/widgets/DropdownInputWidget.js
+++ b/src/widgets/DropdownInputWidget.js
@@ -58,6 +58,7 @@
this.$element
.addClass( 'oo-ui-dropdownInputWidget' )
.append( this.dropdownWidget.$element );
+   this.setTabIndexedElement( null );
 };
 
 /* Setup */
diff --git a/src/widgets/RadioSelectInputWidget.js 
b/src/widgets/RadioSelectInputWidget.js
index 250d863..a59270e 100644
--- a/src/widgets/RadioSelectInputWidget.js
+++ b/src/widgets/RadioSelectInputWidget.js
@@ -44,6 +44,7 @@
this.$element
.addClass( 'oo-ui-radioSelectInputWidget' )
.append( this.radioSelectWidget.$element );
+   this.setTabIndexedElement( null );
 };
 
 /* Setup */

-- 
To view, visit https://gerrit.wikimedia.org/r/348859
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5bb81f7e7cee3dfeb0dc1ad65eda34f8d157ed85
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Keystone: Redirect keystone-manage cron output to /dev/null

[Andrew Bogott (Code Review)]

Andrew Bogott has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348858 )

Change subject: Keystone: Redirect keystone-manage cron output to /dev/null
..


Keystone: Redirect keystone-manage cron output to /dev/null

This hits some library version warnings which were
causing cronspam.

Change-Id: I2914c1a46865c6d874a192483f20cb791c390c18
---
M modules/openstack/manifests/keystone/service.pp
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Andrew Bogott: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/openstack/manifests/keystone/service.pp 
b/modules/openstack/manifests/keystone/service.pp
index 92b83f2..e696359 100644
--- a/modules/openstack/manifests/keystone/service.pp
+++ b/modules/openstack/manifests/keystone/service.pp
@@ -100,7 +100,7 @@
 ensure  => present,
 user=> 'root',
 minute  => 20,
-command => '/usr/bin/keystone-manage token_flush',
+command => '/usr/bin/keystone-manage token_flush > /dev/null 
2>&1',
 }
 
 monitoring::service { 'keystone-http-35357':

-- 
To view, visit https://gerrit.wikimedia.org/r/348858
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2914c1a46865c6d874a192483f20cb791c390c18
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Andrew Bogott 
Gerrit-Reviewer: Andrew Bogott 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Pipe keystone-manage cron output to /dev/null

[Andrew Bogott (Code Review)]

Andrew Bogott has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348858 )

Change subject: Pipe keystone-manage cron output to /dev/null
..

Pipe keystone-manage cron output to /dev/null

This hits some library version warnings which were
causing cronspam.

Change-Id: I2914c1a46865c6d874a192483f20cb791c390c18
---
M modules/openstack/manifests/keystone/service.pp
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/58/348858/1

diff --git a/modules/openstack/manifests/keystone/service.pp 
b/modules/openstack/manifests/keystone/service.pp
index 92b83f2..e696359 100644
--- a/modules/openstack/manifests/keystone/service.pp
+++ b/modules/openstack/manifests/keystone/service.pp
@@ -100,7 +100,7 @@
 ensure  => present,
 user=> 'root',
 minute  => 20,
-command => '/usr/bin/keystone-manage token_flush',
+command => '/usr/bin/keystone-manage token_flush > /dev/null 
2>&1',
 }
 
 monitoring::service { 'keystone-http-35357':

-- 
To view, visit https://gerrit.wikimedia.org/r/348858
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2914c1a46865c6d874a192483f20cb791c390c18
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Andrew Bogott 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations...gerrit[master]: Removing bouncycastle libraries, installing from debian pack...

[Chad (Code Review)]

Chad has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348857 )

Change subject: Removing bouncycastle libraries, installing from debian 
packages instead
..

Removing bouncycastle libraries, installing from debian packages instead

Change-Id: I398d28f554e49a6c3fab806c3a555e161264e0bf
---
D lib/bcpkix-jdk15on-1.52.jar
D lib/bcprov-jdk15on-1.52.jar
2 files changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/debs/gerrit 
refs/changes/57/348857/1

diff --git a/lib/bcpkix-jdk15on-1.52.jar b/lib/bcpkix-jdk15on-1.52.jar
deleted file mode 100644
index b6a5a62..000
--- a/lib/bcpkix-jdk15on-1.52.jar
+++ /dev/null
Binary files differ
diff --git a/lib/bcprov-jdk15on-1.52.jar b/lib/bcprov-jdk15on-1.52.jar
deleted file mode 100644
index 6c54dd9..000
--- a/lib/bcprov-jdk15on-1.52.jar
+++ /dev/null
Binary files differ

-- 
To view, visit https://gerrit.wikimedia.org/r/348857
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I398d28f554e49a6c3fab806c3a555e161264e0bf
Gerrit-PatchSet: 1
Gerrit-Project: operations/debs/gerrit
Gerrit-Branch: master
Gerrit-Owner: Chad 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Spike: Which language projects support FeaturedFeed extension

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/340800 )

Change subject: Spike: Which language projects support FeaturedFeed extension
..


Spike: Which language projects support FeaturedFeed extension

This script uses FeaturedFeeds extension pages to get various
featured items: tfa, dyk, potd, motd, qotd, wotd, fwotd.

For tfa it gets the title of the featured article. For others it gets
the full HTML snippet.
It checks all languages to see for which languages we could get one of
these added to the aggregated feed.

The page titles are taken from
https://github.com/wikimedia/operations-mediawiki-config/blob/master/wmf-config/FeaturedFeedsWMF.php#L47-L73
(must be in MediaWiki namespace)

There are actually three modes in this script. To change the mode you
currently need to modify the script.
* wikitext of the setup page (e.g. MediaWiki:Ffeed-wotd-page)
* expanded templates
  actually expanded twice: e.g. '{{ {{ MediaWiki:Ffeed-wotd-page }} }}'
* retrieving the RSS feed using action=featuredfeed

Bug: T148680
Change-Id: I4fbb160de1be7204454cb252c1531ba03d9201fe
---
M package.json
A scripts/check-featured-feed.js
A static/wikiquotes.json
A static/wiktionaries.json
4 files changed, 488 insertions(+), 0 deletions(-)

Approvals:
  Gergő Tisza: Looks good to me, but someone else must approve
  jenkins-bot: Verified
  Mholloway: Looks good to me, approved



diff --git a/package.json b/package.json
index bf5c027..e03e1b2 100644
--- a/package.json
+++ b/package.json
@@ -71,6 +71,7 @@
 "mocha-jshint": "^2.3.1",
 "mocha-lcov-reporter": "^1.2.0",
 "nsp": "^2.6.2",
+"rss-parser": "^2.5.2",
 "sepia": "^2.0.1"
   },
   "deploy": {
diff --git a/scripts/check-featured-feed.js b/scripts/check-featured-feed.js
new file mode 100755
index 000..8d4b850
--- /dev/null
+++ b/scripts/check-featured-feed.js
@@ -0,0 +1,222 @@
+#!/usr/bin/env node
+
+'use strict';
+
+const BBPromise = require('bluebird');
+const domino = require('domino');
+const preq = require('preq');
+const parseRssUrl = BBPromise.promisify(require('rss-parser').parseURL);
+const underscore = require('underscore');
+
+//
+// LANGUAGES SECTION start
+//
+const wikiquoteLanguages = require('../static/wikiquotes.json');
+const wiktionaryLanguages = require('../static/wiktionaries.json');
+const wikipediaLanguagesRawList = require('../static/languages_list.json');
+
+const prepareWikipediaLanguageCodes = () => {
+delete wikipediaLanguagesRawList['Simplified Chinese']; // skip lang 
variants
+delete wikipediaLanguagesRawList['Traditional Chinese'];
+return underscore.values(wikipediaLanguagesRawList).sort();
+};
+const wikipediaLanguages = prepareWikipediaLanguageCodes();
+//
+// LANGUAGES SECTION end
+//
+
+const ModeEnum = Object.freeze({ wikitext: 0, expandTemplates: 1, rssFeed: 2 
});
+const mode = ModeEnum.rssFeed;
+
+const candidates = [];
+const errNotConfigured = [];
+const errElse = [];
+const errHttp = [];
+
+
+const cleanUpHtml = html => html.replace(//mg, 
'').replace(/\n/mg, '');
+
+/* eslint-disable no-console */
+
+const lookForBoldAnchor = (document, projectLang, html) => {
+const boldAnchor = document.querySelector('b > a, a > b');
+if (boldAnchor) {
+const tfaTitle = boldAnchor.getAttribute('title');
+console.log(`${projectLang}: ${tfaTitle}`);
+candidates.push(projectLang);
+} else {
+console.log(`${projectLang}: ERROR: bold anchor not found: else: 
${html}`);
+errElse.push(projectLang);
+}
+};
+
+const getWikitext = (projectLang, feature) => {
+const baseUri = `https://${projectLang}.${feature.projectFamily}.org`;
+const queryParams1 = 
`action=query=json=revisions=content`;
+const queryParams2 = `=MediaWiki%3A${feature.title}`;
+const uri = `${baseUri}/w/api.php?${queryParams1}${queryParams2}`;
+
+return preq.get({ uri })
+.then((rsp) => {
+const pages = rsp.body.query && rsp.body.query.pages;
+if (!pages) {
+errNotConfigured.push(projectLang);
+return;
+}
+const firstPageKey = Object.keys(pages)[0];
+if (Object.prototype.hasOwnProperty.call(pages[firstPageKey], 
'missing')) {
+errNotConfigured.push(projectLang);
+return;
+}
+
+const wikiText = pages[firstPageKey].revisions[0]['*'];
+if (wikiText) {
+console.log(`${projectLang}: ${wikiText}`);
+candidates.push(projectLang);
+} else {
+errNotConfigured.push(projectLang);
+}
+})
+.catch((err) => {
+console.log(`${projectLang} ERROR: ${err}`);
+errHttp.push(projectLang);
+});
+};
+
+const doubleExpandTemplate = (projectLang, feature) => {
+const baseUri = 

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resourceloader: Move mwNow() to after isCompatible()

[Krinkle (Code Review)]

Krinkle has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348856 )

Change subject: resourceloader: Move mwNow() to after isCompatible()
..

resourceloader: Move mwNow() to after isCompatible()

Follows-up f2fb4a21af. This is logically still the same point in time.
Only 1 function before it now, isCompatible(), which is fine since it
is small and the variable is not used anyway if it returns false.

Change-Id: I34bbe8edf6e9625f8d80f829707adafcb1b91980
---
M resources/src/startup.js
1 file changed, 7 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/56/348856/1

diff --git a/resources/src/startup.js b/resources/src/startup.js
index ad06b34..e0df772 100644
--- a/resources/src/startup.js
+++ b/resources/src/startup.js
@@ -1,7 +1,8 @@
 /**
- * Code in this file MUST work on even the most ancient of browsers!
+ * This file is where we decide whether to initialise the Grade A run-time.
  *
- * This file is where we decide whether to initialise the modern run-time.
+ * - Beware: This file MUST parse without errors on even the most ancient of 
browsers!
+ * - Beware: Do not call mwNow before the isCompatible() check.
  */
 
 /* global mw, $VARS, $CODE */
@@ -18,9 +19,7 @@
function () { return Date.now(); };
}() ),
// eslint-disable-next-line no-unused-vars
-   mediaWikiLoadStart = mwNow();
-
-mwPerformance.mark( 'mwLoadStart' );
+   mediaWikiLoadStart;
 
 /**
  * See 
@@ -153,6 +152,9 @@
};
}
 
+   mediaWikiLoadStart = mwNow();
+   mwPerformance.mark( 'mwLoadStart' );
+
script = document.createElement( 'script' );
script.src = $VARS.baseModulesUri;
script.onload = script.onreadystatechange = function () {

-- 
To view, visit https://gerrit.wikimedia.org/r/348856
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I34bbe8edf6e9625f8d80f829707adafcb1b91980
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Allow editors to exclude navigation items from search indices

[EBernhardson (Code Review)]

EBernhardson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348855 )

Change subject: Allow editors to exclude navigation items from search indices
..

Allow editors to exclude navigation items from search indices

When you perform a particular search, the results can be polluted by
navigation elements that are not supposed to be displayed. This gives
editors the ability to mark sections of the document that should not
be indexed.

Bug: T162905
Change-Id: Iab2b83c3778cd5f7f44736c0da569fd938ae2968
---
M includes/content/WikiTextStructure.php
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/55/348855/1

diff --git a/includes/content/WikiTextStructure.php 
b/includes/content/WikiTextStructure.php
index 9f79aa8..ae91e21 100644
--- a/includes/content/WikiTextStructure.php
+++ b/includes/content/WikiTextStructure.php
@@ -37,6 +37,9 @@
'h1', 'h2', 'h3', 'h4', 'h5', 'h6',
// Collapsed fields are hidden by default so we don't want them 
showing up.
'.autocollapse',
+   // Content explicitly decided to be not searchable by editors 
such
+   // as custom navigation templates.
+   '.navigation-not-searchable"'
];
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/348855
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iab2b83c3778cd5f7f44736c0da569fd938ae2968
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: EBernhardson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: MediaWiki theme: TagMultiselectWidget outlined UI improvements

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348621 )

Change subject: MediaWiki theme: TagMultiselectWidget outlined UI improvements
..


MediaWiki theme: TagMultiselectWidget outlined UI improvements

Making elements of the TagMultiselectWidget with `inputPosition:outline`
clearer for the user.
Also
 - changing CSS class to be aligned with widget naming scheme and
 changing test accordingly,
 - removing `inputPosition:none` CSS class and
 - fixing Karma tests, removing numbers of assertions as they aren't
 needed.

Bug: T163126
Depends-on: I8eed225d4370012ff27ed29d0e6326232b1c7e19
Change-Id: I524a0df97de0f8f2b2004d0737c3c95e834d48f4
---
M Gruntfile.js
M demos/pages/widgets.js
M src/styles/widgets/TagMultiselectWidget.less
M src/themes/mediawiki/widgets.less
M src/widgets/TagMultiselectWidget.js
M tests/widgets/TagMultiselectWidget.test.js
6 files changed, 46 insertions(+), 26 deletions(-)

Approvals:
  jenkins-bot: Verified
  Mooeypoo: Looks good to me, approved



diff --git a/Gruntfile.js b/Gruntfile.js
index 9045a0f..0d258bd 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -421,7 +421,8 @@
'tests/core.test.js',
'tests/Element.test.js',
'tests/Process.test.js',
-   'tests/mixins/FlaggedElement.test.js',
+   'tests/mixins/*.test.js',
+   'tests/widgets/*.test.js',
'tests/JSPHP.test.js'
],
reporters: [ 'dots' ],
diff --git a/demos/pages/widgets.js b/demos/pages/widgets.js
index 0005af2..c139838 100644
--- a/demos/pages/widgets.js
+++ b/demos/pages/widgets.js
@@ -1380,7 +1380,7 @@
inputPosition: 'outline'
} ),
{
-   label: 'TagMultiselectWidget 
(allowArbitrary, outline input, placeholder)',
+   label: 'TagMultiselectWidget 
(allowArbitrary, inputPosition:outline, placeholder)',
align: 'top'
}
),
@@ -1391,7 +1391,7 @@
inputWidget: new 
OO.ui.SearchInputWidget()
} ),
{
-   label: 'TagMultiselectWidget 
(inputwidget: OO.ui.SearchInputWidget, outline input)',
+   label: 'TagMultiselectWidget 
(inputwidget: OO.ui.SearchInputWidget, inputPosition:outline)',
align: 'top'
}
),
diff --git a/src/styles/widgets/TagMultiselectWidget.less 
b/src/styles/widgets/TagMultiselectWidget.less
index df1ce58..e68ed50 100644
--- a/src/styles/widgets/TagMultiselectWidget.less
+++ b/src/styles/widgets/TagMultiselectWidget.less
@@ -21,20 +21,24 @@
position: relative;
}
 
-   &.oo-ui-widget-disabled &-content > input {
-   display: none;
-   }
-
&-group {
display: inline;
}
 
-   &-inputPosition {
-   &-outline {
-   width: 100%;
+   &-outlined {
+   width: 100%;
+   }
+
+   &.oo-ui-widget-enabled {
+   &.oo-ui-tagMultiselectWidget-inlined 
.oo-ui-tagMultiselectWidget-handle {
+   cursor: text;
}
}
 
+   &.oo-ui-widget-disabled &-content > input {
+   display: none;
+   }
+
// Support: Chromium
// Ensure the focus trap is not 0x0px, which causes 
OO.ui.isFocusableElement() to return false,
// preventing the TagMultiselectWidget from being programatically 
focussed in BookletLayout.
diff --git a/src/themes/mediawiki/widgets.less 
b/src/themes/mediawiki/widgets.less
index a2bdb48..9305aac 100644
--- a/src/themes/mediawiki/widgets.less
+++ b/src/themes/mediawiki/widgets.less
@@ -1672,7 +1672,6 @@
&.oo-ui-widget-enabled {
.oo-ui-tagMultiselectWidget-handle {
background-color: @background-color-default;
-   cursor: text;
.oo-ui-transition(
border-color @transition-ease-out-sine-medium,
box-shadow @transition-ease-out-sine-medium
@@ -1688,6 +1687,24 @@
outline: 0;
box-shadow: @box-shadow-widget-focus;

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Drop the classList polyfill for IE9

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348223 )

Change subject: Drop the classList polyfill for IE9
..


Drop the classList polyfill for IE9

As a belt-and-braces matter, add classList detection to SupportCheck.

This reverts commit bf73326f8efe421fa3472a0304eebef8fc12f2ed.

Bug: T162277
Change-Id: I1e955a493128e732dae39d1e2ea4a336c403374a
---
M AUTHORS.txt
M build/modules.json
M demos/ve/desktop.html
M demos/ve/mobile.html
D lib/classList/classList.js
M src/init/ve.init.SupportCheck.js
M tests/index.html
7 files changed, 11 insertions(+), 265 deletions(-)

Approvals:
  Krinkle: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/AUTHORS.txt b/AUTHORS.txt
index 417d4e5..424e41b 100644
--- a/AUTHORS.txt
+++ b/AUTHORS.txt
@@ -66,12 +66,6 @@
 
 Libraries used (alphabetically)
 
-classList.js
- – https://github.com/eligrey/classList.js/
- – Dedicated to the public domain
-   https://github.com/eligrey/classList.js/blob/master/LICENSE.md
- – Eli Grey, http://eligrey.com
-
 Diff Match and Patch
  – https://code.google.com/p/google-diff-match-patch/
  – Apache license 2.0
diff --git a/build/modules.json b/build/modules.json
index ce2548f..5fc4d76 100644
--- a/build/modules.json
+++ b/build/modules.json
@@ -103,11 +103,6 @@
"lib/spark-md5/spark-md5.js"
]
},
-   "dom-classlist-shim": {
-   "scripts": [
-   "lib/classList/classList.js"
-   ]
-   },
"jquery.i18n": {
"scripts": [
"lib/jquery.i18n/src/jquery.i18n.js",
@@ -231,8 +226,7 @@
"visualEditor.supportCheck",
"unicodejs",
"rangefix",
-   "spark-md5",
-   "dom-classlist-shim"
+   "spark-md5"
]
},
"visualEditor.core": {
diff --git a/demos/ve/desktop.html b/demos/ve/desktop.html
index f85519e..da8e2d8 100644
--- a/demos/ve/desktop.html
+++ b/demos/ve/desktop.html
@@ -159,9 +159,6 @@


 
-   
-   
-



diff --git a/demos/ve/mobile.html b/demos/ve/mobile.html
index 6340181..cad6de6 100644
--- a/demos/ve/mobile.html
+++ b/demos/ve/mobile.html
@@ -159,9 +159,6 @@


 
-   
-   
-



diff --git a/lib/classList/classList.js b/lib/classList/classList.js
deleted file mode 100644
index 469bacc..000
--- a/lib/classList/classList.js
+++ /dev/null
@@ -1,239 +0,0 @@
-/*
- * classList.js: Cross-browser full element.classList implementation.
- * 1.1.20150312
- *
- * By Eli Grey, http://eligrey.com
- * License: Dedicated to the public domain.
- *   See https://github.com/eligrey/classList.js/blob/master/LICENSE.md
- */
-
-/*global self, document, DOMException */
-
-/*! @source 
http://purl.eligrey.com/github/classList.js/blob/master/classList.js */
-
-if ("document" in self) {
-
-// Full polyfill for browsers with no classList support
-// Including IE < Edge missing SVGElement.classList
-if (!("classList" in document.createElement("_")) 
-  || document.createElementNS && !("classList" in 
document.createElementNS("http://www.w3.org/2000/svg","g;))) {
-
-(function (view) {
-
-"use strict";
-
-if (!('Element' in view)) return;
-
-var
-classListProp = "classList"
-  , protoProp = "prototype"
-  , elemCtrProto = view.Element[protoProp]
-  , objCtr = Object
-  , strTrim = String[protoProp].trim || function () {
-return this.replace(/^\s+|\s+$/g, "");
-  }
-  , arrIndexOf = Array[protoProp].indexOf || function (item) {
-var
-i = 0
-  , len = this.length
-;
-for (; i < len; i++) {
-  if (i in this && this[i] === item) {
-return i;
-  }
-}
-return -1;
-  }
-  // Vendors: please allow content code to instantiate DOMExceptions
-  , DOMEx = function (type, message) {
-this.name = type;
-this.code = DOMException[type];
-this.message = message;
-  }
-  , checkTokenAndGetIndex = function (classList, token) {
-if (token === "") {
-  throw new DOMEx(
-  "SYNTAX_ERR"
-, "An invalid or illegal string was specified"
-  );
-}
-if (/\s/.test(token)) {
-  throw new DOMEx(
-  "INVALID_CHARACTER_ERR"
-, "String contains an invalid character"
-  );
-}
-return arrIndexOf.call(classList, token);
-  }
-  , ClassList = function (elem) {
-var
-trimmedClasses = strTrim.call(elem.getAttribute("class") || "")
-  , classes = trimmedClasses ? trimmedClasses.split(/\s+/) : []
-  , i = 0
-  , len = classes.length
-;
-for (; i < len; i++) {
-  this.push(classes[i]);
-}
-this._updateClassName = 

[MediaWiki-commits] [Gerrit] oojs/ui[master]: build: Drop the csscomb task

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348804 )

Change subject: build: Drop the csscomb task
..


build: Drop the csscomb task

Finally time to bite the bullet on this one.

Not that it really saves anything worthwhile:

Before  After
real3m41.076s   3m41.066s
user2m0.355s1m59.627s
sys 0m41.429s   0m39.145s

Change-Id: I39adec9947aafd263e4fddd81dbe398ed61f87a8
---
M Gruntfile.js
M package.json
2 files changed, 1 insertion(+), 9 deletions(-)

Approvals:
  jenkins-bot: Verified
  VolkerE: Looks good to me, approved



diff --git a/Gruntfile.js b/Gruntfile.js
index 9045a0f..482854e 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -27,7 +27,6 @@
grunt.loadNpmTasks( 'grunt-contrib-less' );
grunt.loadNpmTasks( 'grunt-contrib-uglify' );
grunt.loadNpmTasks( 'grunt-contrib-watch' );
-   grunt.loadNpmTasks( 'grunt-csscomb' );
grunt.loadNpmTasks( 'grunt-cssjanus' );
grunt.loadNpmTasks( 'grunt-exec' );
grunt.loadNpmTasks( 'grunt-file-exists' );
@@ -270,12 +269,6 @@
files: {
'demos/styles/demo.rtl.css': 
'demos/styles/demo.css'
}
-   }
-   },
-   csscomb: {
-   dist: {
-   expand: true,
-   src: 'dist/*.css'
}
},
copy: {
@@ -588,7 +581,7 @@
grunt.registerTask( 'build-code', [ 'concat:js' ] );
grunt.registerTask( 'build-styling', [
'colorizeSvg', 'set-graphics', 'less', 'cssjanus',
-   'concat:css', 'concat:demoCss', 'csscomb',
+   'concat:css', 'concat:demoCss',
'copy:imagesCommon', 'copy:imagesThemes',
'svg2png'
] );
diff --git a/package.json b/package.json
index b69d46d..c97fe60 100644
--- a/package.json
+++ b/package.json
@@ -36,7 +36,6 @@
 "grunt-contrib-less": "1.4.1",
 "grunt-contrib-uglify": "2.2.0",
 "grunt-contrib-watch": "1.0.0",
-"grunt-csscomb": 
"git://github.com/jdforrester/grunt-csscomb.git#v3.1.0-wmf.1",
 "grunt-cssjanus": "0.4.0",
 "grunt-eslint": "19.0.0",
 "grunt-exec": "1.0.1",

-- 
To view, visit https://gerrit.wikimedia.org/r/348804
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I39adec9947aafd263e4fddd81dbe398ed61f87a8
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: VolkerE 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Clean up Mustache form test

[Ejegg (Code Review)]

Ejegg has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348843 )

Change subject: Clean up Mustache form test
..

Clean up Mustache form test

No need for error suppression, should check for file existence.

Change-Id: Ic2172eb0220a4b5cc0a5e5511318a35d755da1e9
---
M gateway_forms/Mustache.php
M tests/phpunit/MustacheFormTest.php
2 files changed, 5 insertions(+), 4 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface 
refs/changes/43/348843/1

diff --git a/gateway_forms/Mustache.php b/gateway_forms/Mustache.php
index 7101c55..e2a5e14 100644
--- a/gateway_forms/Mustache.php
+++ b/gateway_forms/Mustache.php
@@ -70,6 +70,9 @@
 
$options = $options + $defaultOptions;
 
+   if ( !file_exists( $fileName ) ) {
+   throw new RuntimeException( "Template file unavailable: 
[$fileName]" );
+   }
$template = file_get_contents( $fileName );
if ( $template === false ) {
throw new RuntimeException( "Template file unavailable: 
[$fileName]" );
diff --git a/tests/phpunit/MustacheFormTest.php 
b/tests/phpunit/MustacheFormTest.php
index ff1614d..6739ac8 100644
--- a/tests/phpunit/MustacheFormTest.php
+++ b/tests/phpunit/MustacheFormTest.php
@@ -25,6 +25,7 @@
protected $form;
protected $adapter;
protected $outputPage;
+   protected $gatewayPage;
 
public function setUp() {
$this->resetAllEnv();
@@ -90,10 +91,7 @@
$this->form = new Gateway_Form_Mustache();
$this->form->setGateway( $this->adapter );
$this->form->setGatewayPage( $this->gatewayPage );
-   // Suppress the error cos: we know.
-   $html = @$this->form->getForm();
-
-   $this->fail( 'I\'m not dead yet!' );
+   $this->form->getForm();
}
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/348843
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic2172eb0220a4b5cc0a5e5511318a35d755da1e9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Ejegg 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: (failing) test for EC recurring

[Ejegg (Code Review)]

Ejegg has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348837 )

Change subject: (failing) test for EC recurring
..

(failing) test for EC recurring

Change-Id: Ia4d4bac44c11f8ff74b837ded8d94f8eeb6d5f55
---
A PaymentProviders/PayPal/Tests/Data/express_checkout_recurring.json
M PaymentProviders/PayPal/Tests/phpunit/CaptureIncomingMessageTest.php
2 files changed, 31 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/SmashPig 
refs/changes/37/348837/1

diff --git a/PaymentProviders/PayPal/Tests/Data/express_checkout_recurring.json 
b/PaymentProviders/PayPal/Tests/Data/express_checkout_recurring.json
new file mode 100644
index 000..1cd1c71
--- /dev/null
+++ b/PaymentProviders/PayPal/Tests/Data/express_checkout_recurring.json
@@ -0,0 +1,30 @@
+{
+  "payment_cycle": "Monthly",
+  "txn_type": "recurring_payment_profile_created",
+  "last_name": "Fowl",
+  "next_payment_date": "03:00:00 May 18, 2017 PDT",
+  "residence_country": "US",
+  "initial_payment_amount": "0",
+  "rp_invoice_id": "47017286",
+  "currency_code": "JPY",
+  "time_created": "09:45:28 Apr 18, 2017 PDT",
+  "verify_sign": "ATZo1sTL1YpCR8SD-CzFolXviWIiAYV78oZbytx6QLNuI3z-KS8wKLqC",
+  "period_type": " Regular",
+  "payer_status": "unverified",
+  "tax": "0",
+  "payer_email": "do...@generous.net",
+  "first_name": "Fezziwig",
+  "receiver_email": "recei...@organization.org",
+  "payer_id": "8R297FE87CD8S",
+  "product_type": "1",
+  "shipping": "0",
+  "amount_per_cycle": "140",
+  "profile_status": "Active",
+  "charset": "UTF-8",
+  "notify_version": "3.8",
+  "amount": "140",
+  "outstanding_balance": "0",
+  "recurring_payment_id": "I-88J1M3DLSF0",
+  "product_name": "Monthly donation to the Wikimedia Foundation",
+  "ipn_track_id": "8999c084zz0f2"
+}
diff --git 
a/PaymentProviders/PayPal/Tests/phpunit/CaptureIncomingMessageTest.php 
b/PaymentProviders/PayPal/Tests/phpunit/CaptureIncomingMessageTest.php
index 7af7c01..5ab63b5 100644
--- a/PaymentProviders/PayPal/Tests/phpunit/CaptureIncomingMessageTest.php
+++ b/PaymentProviders/PayPal/Tests/phpunit/CaptureIncomingMessageTest.php
@@ -27,6 +27,7 @@
static $message_data = array(
'web_accept.json' => 'donations',
'express_checkout.json' => 'donations',
+   'express_checkout_recurring.json' => 'recurring',
'subscr_signup.json' => 'recurring',
'subscr_payment.json' => 'recurring',
'recurring_payment.json' => 'recurring',

-- 
To view, visit https://gerrit.wikimedia.org/r/348837
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia4d4bac44c11f8ff74b837ded8d94f8eeb6d5f55
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/SmashPig
Gerrit-Branch: master
Gerrit-Owner: Ejegg 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikipedia...ProveIt[master]: Fix bug when adding citations to references without name

[Sophivorus (Code Review)]

Sophivorus has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348836 )

Change subject: Fix bug when adding citations to references without name
..


Fix bug when adding citations to references without name

Bug: T150101
Change-Id: I3acc28f611c409d34b06b830bba83fab98d00ab6
---
M proveit.js
1 file changed, 11 insertions(+), 6 deletions(-)

Approvals:
  Sophivorus: Verified; Looks good to me, approved



diff --git a/proveit.js b/proveit.js
index 875e68f..ac2c768 100755
--- a/proveit.js
+++ b/proveit.js
@@ -537,9 +537,14 @@
this.cite = function ( event ) {
var reference = event.data;
 
-   // If the reference has no name, ask the user for one
+   if ( reference.name ) {
+   // Add the citation
+   var citation = new proveit.Citation({ 'name': 
reference.name });
+   citation.insert();
+
+   // If there's no reference name, ask the user for one
// @todo check if the name is unique
-   if ( !reference.name ) {
+   } else {
reference.name = prompt( proveit.getMessage( 
'prompt-name' ) );
if ( !reference.name ) {
return;
@@ -551,15 +556,15 @@
reference.loadFromForm();
var newString = reference.string;
 
+   // Add the citation
+   var citation = new proveit.Citation({ 'name': 
reference.name });
+   citation.insert();
+
// Replace the old reference
var textbox = proveit.getTextbox(),
text = textbox.val().replace( 
oldString, newString );
textbox.val( text );
}
-
-   // Add the citation
-   var citation = new proveit.Citation({ 'name': 
reference.name });
-   citation.insert();
};
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/348836
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3acc28f611c409d34b06b830bba83fab98d00ab6
Gerrit-PatchSet: 1
Gerrit-Project: wikipedia/gadgets/ProveIt
Gerrit-Branch: master
Gerrit-Owner: Sophivorus 
Gerrit-Reviewer: Sophivorus 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikipedia...ProveIt[master]: Fix bug when adding citations to references without name

[Sophivorus (Code Review)]

Sophivorus has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348836 )

Change subject: Fix bug when adding citations to references without name
..

Fix bug when adding citations to references without name

Bug: T150101
Change-Id: I3acc28f611c409d34b06b830bba83fab98d00ab6
---
M proveit.js
1 file changed, 11 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikipedia/gadgets/ProveIt 
refs/changes/36/348836/1

diff --git a/proveit.js b/proveit.js
index 875e68f..ac2c768 100755
--- a/proveit.js
+++ b/proveit.js
@@ -537,9 +537,14 @@
this.cite = function ( event ) {
var reference = event.data;
 
-   // If the reference has no name, ask the user for one
+   if ( reference.name ) {
+   // Add the citation
+   var citation = new proveit.Citation({ 'name': 
reference.name });
+   citation.insert();
+
+   // If there's no reference name, ask the user for one
// @todo check if the name is unique
-   if ( !reference.name ) {
+   } else {
reference.name = prompt( proveit.getMessage( 
'prompt-name' ) );
if ( !reference.name ) {
return;
@@ -551,15 +556,15 @@
reference.loadFromForm();
var newString = reference.string;
 
+   // Add the citation
+   var citation = new proveit.Citation({ 'name': 
reference.name });
+   citation.insert();
+
// Replace the old reference
var textbox = proveit.getTextbox(),
text = textbox.val().replace( 
oldString, newString );
textbox.val( text );
}
-
-   // Add the citation
-   var citation = new proveit.Citation({ 'name': 
reference.name });
-   citation.insert();
};
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/348836
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3acc28f611c409d34b06b830bba83fab98d00ab6
Gerrit-PatchSet: 1
Gerrit-Project: wikipedia/gadgets/ProveIt
Gerrit-Branch: master
Gerrit-Owner: Sophivorus 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Upload user options only when they're modified.

[Dbrant (Code Review)]

Dbrant has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348833 )

Change subject: Upload user options only when they're modified.
..

Upload user options only when they're modified.

Looking closely at logcat, I noticed that we were always uploading user
options unconditionally every time they were synced. This would send
an unnecessary POST request for every option, whenever a sync is
requested.

This patch updates the logic so that each option is POSTed only if it's
not yet marked as synchronized in the db.

Change-Id: Ia317dafb1c04df741f0087b9d465c8b1601d8c34
---
M app/src/main/java/org/wikipedia/useroption/sync/UserOptionSyncAdapter.java
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/33/348833/1

diff --git 
a/app/src/main/java/org/wikipedia/useroption/sync/UserOptionSyncAdapter.java 
b/app/src/main/java/org/wikipedia/useroption/sync/UserOptionSyncAdapter.java
index 5c38556..2b5b045 100644
--- a/app/src/main/java/org/wikipedia/useroption/sync/UserOptionSyncAdapter.java
+++ b/app/src/main/java/org/wikipedia/useroption/sync/UserOptionSyncAdapter.java
@@ -58,14 +58,15 @@
 
 private void upload() throws IOException {
 List rows = new 
ArrayList<>(UserOptionDao.instance().startTransaction());
-L.i("uploading " + rows.size() + " option(s)");
 while (!rows.isEmpty()) {
 UserOptionRow row = rows.get(0);
 
 try {
 if (row.status() == HttpStatus.DELETED) {
+L.i("deleting user option: " + row.key());
 UserOptionDataClientSingleton.instance().delete(row.key());
-} else {
+} else if (!row.status().synced()) {
+L.i("uploading user option: " + row.key());
 //noinspection ConstantConditions
 UserOptionDataClientSingleton.instance().post(row.dat());
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/348833
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia317dafb1c04df741f0087b9d465c8b1601d8c34
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix: prevent race condition when synchronizing user options.

[Dbrant (Code Review)]

Dbrant has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/348834 )

Change subject: Fix: prevent race condition when synchronizing user options.
..

Fix: prevent race condition when synchronizing user options.

Some of our recent changes (probably the refactor of CSRF token fetching)
seems to have introduced a race condition in the synchronizing logic of
user options.  This is likely because the method to post() a user option
became asynchronous, whereas it was previously synchronous.

This creates a condition where we request to post() an updated user
option, then immediately call get() to retrieve the latest options from
the server, when in fact the previous post() call hasn't yet finished.

This patch updates the post() and delete() methods to be 'artificially'
synchronous by using wait() / notify() logic.

TODO: update synchronizing of user options to use a 'revision' code,
similar to how reading lists are synchronized.

Bug: T163214
Change-Id: Ia8c7ac33d9cb52fad0d1676445f419a573292de1
---
M 
app/src/main/java/org/wikipedia/useroption/dataclient/DefaultUserOptionDataClient.java
M app/src/main/java/org/wikipedia/useroption/sync/UserOptionSyncAdapter.java
2 files changed, 20 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/34/348834/1

diff --git 
a/app/src/main/java/org/wikipedia/useroption/dataclient/DefaultUserOptionDataClient.java
 
b/app/src/main/java/org/wikipedia/useroption/dataclient/DefaultUserOptionDataClient.java
index 01f674f..430aa0b 100644
--- 
a/app/src/main/java/org/wikipedia/useroption/dataclient/DefaultUserOptionDataClient.java
+++ 
b/app/src/main/java/org/wikipedia/useroption/dataclient/DefaultUserOptionDataClient.java
@@ -60,15 +60,18 @@
 if (response.body() != null && 
!response.body().success(response.body().result())) {
 L.e("Bad response for wiki " + wiki.host() + " = " 
+ response.body().result());
 }
+notifyThis();
 }
 
 @Override
 public void onFailure(Call call, Throwable 
caught) {
 L.e(caught);
+notifyThis();
 }
 });
 }
 });
+waitForThis();
 }
 
 @Override
@@ -82,15 +85,30 @@
 if (response.body() != null && 
!response.body().success(response.body().result())) {
 L.e("Bad response for wiki " + wiki.host() + " = " 
+ response.body().result());
 }
+notifyThis();
 }
 
 @Override
 public void onFailure(Call call, Throwable 
caught) {
 L.e(caught);
+notifyThis();
 }
 });
 }
 });
+waitForThis();
+}
+
+private synchronized void waitForThis() {
+try {
+wait();
+} catch (InterruptedException e) {
+L.d(e);
+}
+}
+
+private synchronized void notifyThis() {
+notify();
 }
 
 private static WikipediaApp app() {
diff --git 
a/app/src/main/java/org/wikipedia/useroption/sync/UserOptionSyncAdapter.java 
b/app/src/main/java/org/wikipedia/useroption/sync/UserOptionSyncAdapter.java
index 2b5b045..e9c4c3b 100644
--- a/app/src/main/java/org/wikipedia/useroption/sync/UserOptionSyncAdapter.java
+++ b/app/src/main/java/org/wikipedia/useroption/sync/UserOptionSyncAdapter.java
@@ -49,14 +49,14 @@
 }
 }
 
-private void download() throws IOException {
+private synchronized void download() throws IOException {
 UserInfo info = UserOptionDataClientSingleton.instance().get();
 Collection options = info.userjsOptions();
 L.i("downloaded " + options.size() + " option(s)");
 UserOptionDao.instance().reconcileTransaction(options);
 }
 
-private void upload() throws IOException {
+private synchronized void upload() throws IOException {
 List rows = new 
ArrayList<>(UserOptionDao.instance().startTransaction());
 while (!rows.isEmpty()) {
 UserOptionRow row = rows.get(0);

-- 
To view, visit https://gerrit.wikimedia.org/r/348834
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia8c7ac33d9cb52fad0d1676445f419a573292de1
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...LoginNotify[master]: Rename functions so as to not confuse with with CheckUser ex...

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348757 )

Change subject: Rename functions so as to not confuse with with CheckUser 
extension
..


Rename functions so as to not confuse with with CheckUser extension

Bug: T162748
Change-Id: If2ad9d65cedc8124b2570e2b66574736a8f112f9
---
M LoginNotify.hooks.php
M LoginNotify_body.php
M tests/phpunit/LoginNotifyTests.php
3 files changed, 24 insertions(+), 24 deletions(-)

Approvals:
  jenkins-bot: Verified
  Kaldari: Looks good to me, approved



diff --git a/LoginNotify.hooks.php b/LoginNotify.hooks.php
index 3c9c706..3fa6426 100644
--- a/LoginNotify.hooks.php
+++ b/LoginNotify.hooks.php
@@ -100,7 +100,7 @@
/**
 * Old hook for pre 1.27 or wikis with auth manager disabled.
 *
-* @todo Doesn't catcha captcha or throttle failures
+* @todo Doesn't catch CAPTCHA or throttle failures
 * @param User $user User in question.
 * @param string $pass The password (parameter not used).
 * @param integer $retval A LoginForm constant (e.g. 
LoginForm::SUCCESS).
diff --git a/LoginNotify_body.php b/LoginNotify_body.php
index 4e473bd..71e6f2c 100644
--- a/LoginNotify_body.php
+++ b/LoginNotify_body.php
@@ -99,18 +99,18 @@
 * @return boolean true if the user has used this computer before
 */
private function isFromKnownIP( User $user ) {
-   $cookieResult = $this->checkUserInCookie( $user );
+   $cookieResult = $this->isUserInCookie( $user );
if ( $cookieResult === true ) {
// User has cookie
return true;
}
 
-   $cacheResult = $this->checkUserInCache( $user );
+   $cacheResult = $this->isUserInCache( $user );
if ( $cacheResult === true ) {
return true;
}
 
-   $cuResult = $this->checkUserInCheckUser( $user );
+   $cuResult = $this->isUserInCheckUser( $user );
if ( $cuResult === true ) {
return true;
}
@@ -145,7 +145,7 @@
 * @param $user User User in question.
 * @return Mixed true, false or self::NO_INFO_AVAILABLE.
 */
-   private function checkUserInCache( User $user ) {
+   private function isUserInCache( User $user ) {
$ipPrefix = $this->getIPNetwork( $user->getRequest()->getIP() );
$key = $this->getKey( $user, 'prevSubnet' );
$res = $this->cache->get( $key );
@@ -164,7 +164,7 @@
 * @param $user User User in question.
 * @return Mixed true, false or self::NO_INFO_AVAILABLE.
 */
-   private function checkUserInCheckUser( User $user ) {
+   private function isUserInCheckUser( User $user ) {
if ( !$this->config->get( 'LoginNotifyCheckKnownIPs' )
|| !class_exists( 'CheckUser' )
) {
@@ -177,13 +177,13 @@
$prefix = $this->getIPNetwork( $user->getRequest()->getIP() );
 
$dbr = wfGetDB( DB_SLAVE );
-   $localResult = $this->checkUserInCheckUserQuery( 
$user->getId(), $prefix, $dbr );
+   $localResult = $this->isUserInCheckUserQuery( $user->getId(), 
$prefix, $dbr );
if ( $localResult ) {
return true;
}
 
if ( !$haveAnyInfo ) {
-   $haveAnyInfo = $this->checkUserInCheckUserAnyInfo( 
$user->getId(), $dbr );
+   $haveAnyInfo = $this->isUserInCheckUserAnyInfo( 
$user->getId(), $dbr );
}
 
// Also check checkuser table on the top ten wikis where this 
user has
@@ -220,7 +220,7 @@
}
// FIXME The case where there are no CU 
entries for
// this user.
-   $res = $this->checkUserInCheckUserQuery(
+   $res = $this->isUserInCheckUserQuery(
$localInfo['id'],
$prefix,
$dbrLocal
@@ -231,7 +231,7 @@
return true;
}
if ( !$haveAnyInfo ) {
-   $haveAnyInfo = 
$this->checkUserInCheckUserAnyInfo( $user->getId(), $dbr );
+   $haveAnyInfo = 
$this->isUserInCheckUserAnyInfo( $user->getId(), $dbr );
}
$lb->reuseConnection( $dbrLocal );
   

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Move gerrit to using Bouncycastle as packaged by Debian

[Dzahn (Code Review)]

Dzahn has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348690 )

Change subject: Move gerrit to using Bouncycastle as packaged by Debian
..


Move gerrit to using Bouncycastle as packaged by Debian

/var/lib/gerrit2/review_site/lib on cobalt currently has bcpkix-jdk15on-1.52.jar
and bcprov-jdk15on-1.52.jar from Bouncycastle. Install Bouncycastle as packaged
by Debian to profit from security updates and bring it more in line with server
management standards.

The Jars in the Debian packages are /usr/share/java/bcpkix-1.49.jar and
/usr/share/java/bcprov-1.49.jar. Symlinks will be provided in a followup
commit.

The version in Debian is slightly older, but I can't see anything in the
release notes, which would make the 1.52->1.49 move problematic.

Bug: T163185

Change-Id: I299eda7ee93e6e8b7d86c4955e14ff7271fbf077
---
M modules/gerrit/manifests/jetty.pp
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Paladox: Looks good to me, but someone else must approve
  Chad: Looks good to me, but someone else must approve
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/modules/gerrit/manifests/jetty.pp 
b/modules/gerrit/manifests/jetty.pp
index da8fb56..0737a57 100644
--- a/modules/gerrit/manifests/jetty.pp
+++ b/modules/gerrit/manifests/jetty.pp
@@ -46,6 +46,8 @@
 require_package([
 'openjdk-8-jdk',
 'gerrit',
+'libbcprov-java',
+'libbcpkix-java',
 'libmysql-java',
 ])
 

-- 
To view, visit https://gerrit.wikimedia.org/r/348690
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I299eda7ee93e6e8b7d86c4955e14ff7271fbf077
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Muehlenhoff 
Gerrit-Reviewer: Chad 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: Giuseppe Lavagetto 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: Paladox 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Keystone: Use keystone-manage token_flush rather than a mys...

[Andrew Bogott (Code Review)]

Andrew Bogott has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/348806 )

Change subject: Keystone:  Use keystone-manage token_flush rather than a mysql 
call
..


Keystone:  Use keystone-manage token_flush rather than a mysql call

token_flush has been around for a while but didn't exist when we first
started doing this.  Now that we have a proper upstream way to
purge tokens that seems better than monkeying directly with the db.

https://blueprints.launchpad.net/keystone/+spec/keystone-manage-token-flush

Change-Id: Id6c454b339dc3110d4bd0431ed906bd58cd16652
---
M modules/openstack/manifests/keystone/service.pp
1 file changed, 3 insertions(+), 6 deletions(-)

Approvals:
  Andrew Bogott: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/openstack/manifests/keystone/service.pp 
b/modules/openstack/manifests/keystone/service.pp
index a172b16..92b83f2 100644
--- a/modules/openstack/manifests/keystone/service.pp
+++ b/modules/openstack/manifests/keystone/service.pp
@@ -93,17 +93,14 @@
 }
 
 if $::fqdn == hiera('labs_nova_controller') {
-# Clean up expired keystone tokens, because keystone seems to leak them
-$keystone_db_name = $keystoneconfig['db_name']
-$keystone_db_user = $keystoneconfig['db_user']
-$keystone_db_pass = $keystoneconfig['db_pass']
-$keystone_db_host = $keystoneconfig['db_host']
+# Clean up expired keystone tokens, because otherwise keystone leaves 
them
+#  around forever.
 cron {
 'cleanup_expired_keystone_tokens':
 ensure  => present,
 user=> 'root',
 minute  => 20,
-command => "/usr/bin/mysql ${keystone_db_name} 
-h${keystone_db_host} -u${keystone_db_user} -p${keystone_db_pass} -e 'DELETE 
FROM token WHERE NOW() - INTERVAL 2 day > expires LIMIT 1;'",
+command => '/usr/bin/keystone-manage token_flush',
 }
 
 monitoring::service { 'keystone-http-35357':

-- 
To view, visit https://gerrit.wikimedia.org/r/348806
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id6c454b339dc3110d4bd0431ed906bd58cd16652
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Andrew Bogott 
Gerrit-Reviewer: Alex Monk 
Gerrit-Reviewer: Andrew Bogott 
Gerrit-Reviewer: Giuseppe Lavagetto 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits