[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Use “OOUI” as unified name for code comments

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404632 )

Change subject: Use “OOUI” as unified name for code comments
..


Use “OOUI” as unified name for code comments

Bug: T182360
Change-Id: I25f9e1ca04f9e95d6b9e77d7afa858d1f971cc5a
---
M mobile.less/mobile.variables.less
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  VolkerE: Looks good to me, approved



diff --git a/mobile.less/mobile.variables.less 
b/mobile.less/mobile.variables.less
index 5a2a73e..6deba2f 100644
--- a/mobile.less/mobile.variables.less
+++ b/mobile.less/mobile.variables.less
@@ -8,7 +8,7 @@
 
 @fontFamily: 'Helvetica Neue', 'Helvetica', 'Nimbus Sans L', 'Arial', 
'Liberation Sans', sans-serif;
 
-// OOJs specific icon variables
+// OOUI specific icon variables
 @baseIconSize: 24px;
 @targetIconSize: 32px;
 @indicatorFontSize: 0.4em;

-- 
To view, visit https://gerrit.wikimedia.org/r/404632
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I25f9e1ca04f9e95d6b9e77d7afa858d1f971cc5a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: VolkerE 
Gerrit-Reviewer: Pmiazga 
Gerrit-Reviewer: VolkerE 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Use “OOUI” as unified name for code comments

[VolkerE (Code Review)]

VolkerE has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404633 )

Change subject: Use “OOUI” as unified name for code comments
..

Use “OOUI” as unified name for code comments

Bug: T182360
Change-Id: Ie2755724b3d9b826f4d5a7199213d410beb726a1
---
M modules/entrypoint/styles/ext.cx.contributions.less
M modules/source/ext.cx.SelectedSourcePage.js
M modules/tools/mw.cx.tools.TranslationTool.js
M modules/tools/styles/ext.cx.tools.template.editor.less
M modules/widgets/callout/ext.cx.callout.css
M specials/SpecialContentTranslation.php
6 files changed, 8 insertions(+), 8 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation 
refs/changes/33/404633/1

diff --git a/modules/entrypoint/styles/ext.cx.contributions.less 
b/modules/entrypoint/styles/ext.cx.contributions.less
index ee9e86a..b7748fd 100644
--- a/modules/entrypoint/styles/ext.cx.contributions.less
+++ b/modules/entrypoint/styles/ext.cx.contributions.less
@@ -15,7 +15,7 @@
height: 0;
border-top: 21px solid @color-primary;
border-left: 22px solid transparent;
-   z-index: 3; // oojs button has z-index 2 on hover
+   z-index: 3; // OOUI button has z-index 2 on hover
}
 
&:after {
diff --git a/modules/source/ext.cx.SelectedSourcePage.js 
b/modules/source/ext.cx.SelectedSourcePage.js
index e49251a..e9f6803 100644
--- a/modules/source/ext.cx.SelectedSourcePage.js
+++ b/modules/source/ext.cx.SelectedSourcePage.js
@@ -157,8 +157,8 @@
this.languageFilter.fillSourceLanguages( null, true );
this.languageFilter.fillTargetLanguages( null, true );
 
-   $( 'html' ).click(); // Not sure why click doesn't pass through 
OOJS button to html element
-   // where listener is closing the ULS on outside clicks. Maybe 
some OOjs UI change?
+   $( 'html' ).click(); // Not sure why click doesn't pass through 
OOUI button to HTML element
+   // where listener is closing the ULS on outside clicks. Maybe 
some OOUI change?
 
if ( this.onDiscard ) {
this.onDiscard();
@@ -228,7 +228,7 @@
 * @cfg {string} targetLanguage Target language code
 * @cfg {Object} [params] Parameters used for API call to get page info
 * @cfg {string} [imageUrl] URL for selected source page image
-* @cfg {string} [imageIcon] OOjs UI class of selected page placeholder 
icon
+* @cfg {string} [imageIcon] OOUI class of selected page placeholder 
icon
 * @cfg {Number} [numOfLanguages] Number of different language versions 
for selected source page
 */
mw.cx.SelectedSourcePage.prototype.setSelectedSourcePageData = function 
( pageTitle, href, config ) {
diff --git a/modules/tools/mw.cx.tools.TranslationTool.js 
b/modules/tools/mw.cx.tools.TranslationTool.js
index 8d532d0..46e3f94 100644
--- a/modules/tools/mw.cx.tools.TranslationTool.js
+++ b/modules/tools/mw.cx.tools.TranslationTool.js
@@ -67,7 +67,7 @@
 /**
  * Get all possible actions with this tool widget
  * @method
- * @return {OO.ui.Element[]} Array of OOJS UI Elements
+ * @return {OO.ui.Element[]} Array of OOUI Elements
  */
 mw.cx.tools.TranslationTool.prototype.getActions = function () {
return [];
diff --git a/modules/tools/styles/ext.cx.tools.template.editor.less 
b/modules/tools/styles/ext.cx.tools.template.editor.less
index 9c67f18..acdeb13 100644
--- a/modules/tools/styles/ext.cx.tools.template.editor.less
+++ b/modules/tools/styles/ext.cx.tools.template.editor.less
@@ -104,7 +104,7 @@
 
 .cx-template-editor-target-container {
.cx-template-editor-param-selector {
-   // OOJS UI resets
+   // OOUI resets
.oo-ui-dropdownWidget-handle {
border: 0;
background-color: @white;
diff --git a/modules/widgets/callout/ext.cx.callout.css 
b/modules/widgets/callout/ext.cx.callout.css
index d45b731..0ba69b0 100644
--- a/modules/widgets/callout/ext.cx.callout.css
+++ b/modules/widgets/callout/ext.cx.callout.css
@@ -1,4 +1,4 @@
-.cx-callout { /* styling accordingly to OOjs UI's `popupWidget-popup` */
+.cx-callout { /* styling accordingly to OOUI's `popupWidget-popup` */
background: #fff;
color: #222;
position: absolute;
diff --git a/specials/SpecialContentTranslation.php 
b/specials/SpecialContentTranslation.php
index 567334c..ac8e275 100644
--- a/specials/SpecialContentTranslation.php
+++ b/specials/SpecialContentTranslation.php
@@ -147,7 +147,7 @@
$out->addModuleStyles( 'mw.cx.ui.Header.skin' );
 
$initModule = 'mw.cx.init.legacy';
-   // If request has param to use CX oojs based version, change 
init module.
+   // If 

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Use “OOUI” as unified name for code comments

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404630 )

Change subject: Use “OOUI” as unified name for code comments
..


Use “OOUI” as unified name for code comments

Bug: T182360
Change-Id: Ib1daa160dd7597afe6a6ae22dc263ba7d297f757
---
M modules/styles/mw.echo.ui.MenuItemWidget.less
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  VolkerE: Looks good to me, approved



diff --git a/modules/styles/mw.echo.ui.MenuItemWidget.less 
b/modules/styles/mw.echo.ui.MenuItemWidget.less
index 799f8a3..33b39a7 100644
--- a/modules/styles/mw.echo.ui.MenuItemWidget.less
+++ b/modules/styles/mw.echo.ui.MenuItemWidget.less
@@ -19,7 +19,7 @@
display: inline-block;
margin-left: 1.5em + 0.5em; // Icon width + 0.5em spacing
 
-   // We have to override oojs-ui's color, which uses
+   // We have to override OOUI's color, which uses
// a very specific selector
font-weight: normal !important;
color: @color-base !important;

-- 
To view, visit https://gerrit.wikimedia.org/r/404630
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1daa160dd7597afe6a6ae22dc263ba7d297f757
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: VolkerE 
Gerrit-Reviewer: VolkerE 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Use “OOUI” as unified name for code comments

[VolkerE (Code Review)]

VolkerE has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404632 )

Change subject: Use “OOUI” as unified name for code comments
..

Use “OOUI” as unified name for code comments

Bug: T182360
Change-Id: I25f9e1ca04f9e95d6b9e77d7afa858d1f971cc5a
---
M mobile.less/mobile.variables.less
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/32/404632/1

diff --git a/mobile.less/mobile.variables.less 
b/mobile.less/mobile.variables.less
index 5a2a73e..6deba2f 100644
--- a/mobile.less/mobile.variables.less
+++ b/mobile.less/mobile.variables.less
@@ -8,7 +8,7 @@
 
 @fontFamily: 'Helvetica Neue', 'Helvetica', 'Nimbus Sans L', 'Arial', 
'Liberation Sans', sans-serif;
 
-// OOJs specific icon variables
+// OOUI specific icon variables
 @baseIconSize: 24px;
 @targetIconSize: 32px;
 @indicatorFontSize: 0.4em;

-- 
To view, visit https://gerrit.wikimedia.org/r/404632
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I25f9e1ca04f9e95d6b9e77d7afa858d1f971cc5a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: VolkerE 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Use “OOUI” as unified name in docs & code comments

[VolkerE (Code Review)]

VolkerE has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404631 )

Change subject: Use “OOUI” as unified name in docs & code comments
..

Use “OOUI” as unified name in docs & code comments

Bug: T182360
Change-Id: I24fbfe4fed3148241bc70835ae310bffe5dfcc9d
---
M CONTRIBUTING.md
M modules/engine/misc/mw-ui.modal.js
M modules/flow/dm/mixins/mw.flow.dm.List.js
M modules/styles/common.less
M modules/styles/flow/widgets/editor/mw.flow.ui.CanNotEditWidget.less
5 files changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/31/404631/1

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index b403e88..8c11627 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -14,7 +14,7 @@
 #wikimedia-collaboration on Freenode.
 
 ## Libraries
-Flow primarily uses two libraries, OOjs UI/OO UI PHP and Handlebars.  
Handlebars
+Flow primarily uses two libraries, OOUI/OOUI PHP and Handlebars.  Handlebars
 is a templating language used on both the client and server.
 
 When developing, it is recommended to set:
diff --git a/modules/engine/misc/mw-ui.modal.js 
b/modules/engine/misc/mw-ui.modal.js
index c851b6c..7f3fed2 100644
--- a/modules/engine/misc/mw-ui.modal.js
+++ b/modules/engine/misc/mw-ui.modal.js
@@ -34,7 +34,7 @@
 *
 * @todo Implement multi-step
 * @todo Implement data-mwui handlers
-* @todo Implement OOJS & events
+* @todo Implement OOjs & events
 * @class
 * @constructor
 * @param {string} [name] Name of modal (may be omitted)
diff --git a/modules/flow/dm/mixins/mw.flow.dm.List.js 
b/modules/flow/dm/mixins/mw.flow.dm.List.js
index f0c7ff4..6b46717 100644
--- a/modules/flow/dm/mixins/mw.flow.dm.List.js
+++ b/modules/flow/dm/mixins/mw.flow.dm.List.js
@@ -79,7 +79,7 @@
 
/**
 * Aggregate the events emitted by the group.
-* Taken from oojs-ui's OO.ui.GroupElement#aggregate
+* Taken from OOUI's OO.ui.GroupElement#aggregate
 *
 * When events are aggregated, the group will listen to all contained 
items for the event,
 * and then emit the event under a new name. The new event will contain 
an additional leading
diff --git a/modules/styles/common.less b/modules/styles/common.less
index eeb4141..52719db 100644
--- a/modules/styles/common.less
+++ b/modules/styles/common.less
@@ -104,7 +104,7 @@
height: 100px;
 }
 
-// Override oojs-ui's frameless-buttons having
+// Override OOUI's frameless-buttons having
 // a white border inside the description area
 // (which has a grey background)
 .flow-ui-boardDescriptionWidget-editButton.oo-ui-widget.oo-ui-buttonElement 
.oo-ui-buttonElement-button {
diff --git 
a/modules/styles/flow/widgets/editor/mw.flow.ui.CanNotEditWidget.less 
b/modules/styles/flow/widgets/editor/mw.flow.ui.CanNotEditWidget.less
index 228a78f..62fa111 100644
--- a/modules/styles/flow/widgets/editor/mw.flow.ui.CanNotEditWidget.less
+++ b/modules/styles/flow/widgets/editor/mw.flow.ui.CanNotEditWidget.less
@@ -4,7 +4,7 @@
 
&-active {
/* @embed */
-   // From OOjs-UI
+   // From OOUI
background-image: url( ../../images/lock-ltr.svg );
background-repeat: no-repeat;
background-color: #ffb50d;

-- 
To view, visit https://gerrit.wikimedia.org/r/404631
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I24fbfe4fed3148241bc70835ae310bffe5dfcc9d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: VolkerE 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Use “OOUI” as unified name for code comments

[VolkerE (Code Review)]

VolkerE has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404630 )

Change subject: Use “OOUI” as unified name for code comments
..

Use “OOUI” as unified name for code comments

Bug: T182360
Change-Id: Ib1daa160dd7597afe6a6ae22dc263ba7d297f757
---
M modules/styles/mw.echo.ui.MenuItemWidget.less
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo 
refs/changes/30/404630/1

diff --git a/modules/styles/mw.echo.ui.MenuItemWidget.less 
b/modules/styles/mw.echo.ui.MenuItemWidget.less
index 799f8a3..33b39a7 100644
--- a/modules/styles/mw.echo.ui.MenuItemWidget.less
+++ b/modules/styles/mw.echo.ui.MenuItemWidget.less
@@ -19,7 +19,7 @@
display: inline-block;
margin-left: 1.5em + 0.5em; // Icon width + 0.5em spacing
 
-   // We have to override oojs-ui's color, which uses
+   // We have to override OOUI's color, which uses
// a very specific selector
font-weight: normal !important;
color: @color-base !important;

-- 
To view, visit https://gerrit.wikimedia.org/r/404630
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib1daa160dd7597afe6a6ae22dc263ba7d297f757
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: VolkerE 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Display infobar on CX dashboard

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404447 )

Change subject: Display infobar on CX dashboard
..


Display infobar on CX dashboard

Only hide `.cx-header__bar` and show `.cx-header-infobar`, so that
error messages can be visible on CX dashboard as well.

Bug: T184972
Change-Id: I81d93f1617d08efab01e022e0a8d441c8b559783
---
M modules/ui/legacy/styles/mw.cx.ui.Header.less
M modules/ui/styles/mw.cx.ui.Header.less
2 files changed, 2 insertions(+), 4 deletions(-)

Approvals:
  jenkins-bot: Verified
  Santhosh: Looks good to me, approved



diff --git a/modules/ui/legacy/styles/mw.cx.ui.Header.less 
b/modules/ui/legacy/styles/mw.cx.ui.Header.less
index d2ad30c..dc55bce 100644
--- a/modules/ui/legacy/styles/mw.cx.ui.Header.less
+++ b/modules/ui/legacy/styles/mw.cx.ui.Header.less
@@ -124,8 +124,7 @@
margin: 0 auto;
padding: 10px 40px 0;
 
-   .cx-header__bar,
-   .cx-header-infobar {
+   .cx-header__bar {
display: none;
}
 
diff --git a/modules/ui/styles/mw.cx.ui.Header.less 
b/modules/ui/styles/mw.cx.ui.Header.less
index 666d122..34f516d 100644
--- a/modules/ui/styles/mw.cx.ui.Header.less
+++ b/modules/ui/styles/mw.cx.ui.Header.less
@@ -119,8 +119,7 @@
margin: 0 auto;
padding: 10px 40px 0;
 
-   .cx-header__bar,
-   .cx-header-infobar {
+   .cx-header__bar {
display: none;
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/404447
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I81d93f1617d08efab01e022e0a8d441c8b559783
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Petar.petkovic 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: Santhosh 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: mariadb: Set as spares labsdb1001 and labsdb1003

[Marostegui (Code Review)]

Marostegui has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404323 )

Change subject: mariadb: Set as spares labsdb1001 and labsdb1003
..


mariadb: Set as spares labsdb1001 and labsdb1003

Also removing rests of old labsdb role.

Bug: T184832
Change-Id: I8195d0448c9fba17a6f8d954c01bd0eee98f465a
---
M manifests/site.pp
D modules/role/manifests/mariadb/labs_deprecated.pp
D modules/role/templates/mariadb/mysqld_config/labs.my.cnf.erb
3 files changed, 5 insertions(+), 192 deletions(-)

Approvals:
  Marostegui: Looks good to me, approved
  Rush: Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/manifests/site.pp b/manifests/site.pp
index ce280c2..d42c43d 100644
--- a/manifests/site.pp
+++ b/manifests/site.pp
@@ -1165,11 +1165,6 @@
 }
 
 ## labsdb dbs
-node /labsdb100[13]\.eqiad\.wmnet/ {
-# this role is depecated and its nodes scheduled for decom
-role(mariadb::labs_deprecated)
-}
-
 node /labsdb10(09|10|11)\.eqiad\.wmnet/ {
 role(labs::db::replica)
 }
@@ -1191,6 +1186,11 @@
 role(osm::master)
 }
 
+# old labsdbs, to be decommed. T142807
+node /labsdb100[13]\.eqiad\.wmnet/ {
+role(spare::system)
+}
+
 node /labstore100[12]\.eqiad\.wmnet/ {
 # soon to be recommissioned in T158196
 include ::standard
diff --git a/modules/role/manifests/mariadb/labs_deprecated.pp 
b/modules/role/manifests/mariadb/labs_deprecated.pp
deleted file mode 100644
index b943b21..000
--- a/modules/role/manifests/mariadb/labs_deprecated.pp
+++ /dev/null
@@ -1,57 +0,0 @@
-# MariaDB 10 labsdb multiple-shards slave.
-# This role is deprecated but still in use.
-# Use role::labs::db::replica instead
-class role::mariadb::labs_deprecated {
-
-system::role { 'mariadb::labs_deprecated':
-description => 'Labs DB Slave (deprecated role)',
-}
-
-include ::standard
-include ::profile::mariadb::monitor
-include passwords::misc::scripts
-include role::mariadb::ferm
-include ::profile::base::firewall
-include role::labs::db::common
-include role::labs::db::views
-include role::labs::db::check_private_data
-
-class { 'profile::mariadb::monitor::prometheus':
-mysql_group => 'labs',
-mysql_role  => 'slave',
-socket  => '/tmp/mysql.sock',
-}
-
-include mariadb::packages_wmf
-include mariadb::service
-
-class { 'mariadb::config':
-config  => 'role/mariadb/mysqld_config/labs.my.cnf.erb',
-datadir => '/srv/sqldata',
-tmpdir  => '/srv/tmp',
-}
-
-file { '/srv/innodb':
-ensure => directory,
-owner  => 'mysql',
-group  => 'mysql',
-mode   => '0755',
-}
-
-file { '/srv/tokudb':
-ensure => directory,
-owner  => 'mysql',
-group  => 'mysql',
-mode   => '0755',
-}
-
-# Required for TokuDB to start
-# See 
https://mariadb.com/kb/en/mariadb/enabling-tokudb/#check-for-transparent-hugepage-support-on-linux
-sysfs::parameters { 'disable-transparent-hugepages':
-values => {
-'kernel/mm/transparent_hugepage/enabled' => 'never',
-'kernel/mm/transparent_hugepage/defrag'  => 'never',
-}
-}
-}
-
diff --git a/modules/role/templates/mariadb/mysqld_config/labs.my.cnf.erb 
b/modules/role/templates/mariadb/mysqld_config/labs.my.cnf.erb
deleted file mode 100644
index c187937..000
--- a/modules/role/templates/mariadb/mysqld_config/labs.my.cnf.erb
+++ /dev/null
@@ -1,130 +0,0 @@
-# Labs
-
-[client]
-port   = 3306
-socket = /tmp/mysql.sock
-
-[mysqld]
-
-user  = mysql
-socket= /tmp/mysql.sock
-port  = 3306
-basedir   = <%= @basedir %>
-datadir   = <%= @datadir %>
-tmpdir= <%= @tmpdir %>
-server_id = <%= @server_id %>
-
-# gtid_domain_id flag is needed for multisource replication and GTID.
-# # Strictly it is only needed on masters or servers that can potentially be
-# # masters but for consistency it should be set in all of them.
-# # https://mariadb.com/kb/en/mariadb/gtid/
-#
-gtid_domain_id  = <%= @gtid_domain_id %>
-
-read_only = 0
-
-# enable socket authentication
-plugin-load = unix_socket=auth_socket.so
-
-skip-external-locking
-skip-name-resolve
-#skip-slave-start
-temp-pool
-
-secure_file_priv   = /dev/null
-max_connections= 1000
-max_connect_errors = 10
-max_allowed_packet = 32M
-connect_timeout= 3
-query_cache_size   = 0
-query_cache_type   = 0
-event_scheduler= 1
-userstat   = 1
-log-warnings   = 0
-thread_stack   = 192K
-thread_cache_size  = 300
-interactive_timeout= 28800
-wait_timeout   = 3600
-plugin-load= ha_tokudb
-transaction-isolation  = READ-COMMITTED
-slave_transaction_retries  = 4294967295

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: db-eqiad.php: Depool db1104

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404629 )

Change subject: db-eqiad.php: Depool db1104
..


db-eqiad.php: Depool db1104

Needs alter table

Bug: T174569
Change-Id: Id49ea6ea762f96d7bdfc4ed3db4f5477c108abd4
---
M wmf-config/db-eqiad.php
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Marostegui: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/wmf-config/db-eqiad.php b/wmf-config/db-eqiad.php
index 1c2d251..7444b04 100644
--- a/wmf-config/db-eqiad.php
+++ b/wmf-config/db-eqiad.php
@@ -171,10 +171,10 @@
'db1071' => 0,   # D1 2.8TB 160GB, master
# 'db1063' => 0,   # C5 2.8TB 128GB, vslow, dump # to be moved 
to s6
'db1087' => 0, # C2 3.6TB 512GB, vslow, dump # db1095 master
-   'db1092' => 300, # D2 3.6TB 512GB, api
+   'db1092' => 100, # D2 3.6TB 512GB, api
'db1099:3318' => 1,   # B2 3.6TB 512GB # rc, log: s1 and s8
# 'db1101:3318' => 1,   # C2 3.6TB 512GB # rc, log: s7 and s8 # 
T174569
-   'db1104' => 300,  # B3 3.6TB 512GB, api
+   # 'db1104' => 300,  # B3 3.6TB 512GB, api # T174569
'db1109' => 500,  # D8 3.6TB 512GB
],
 
@@ -481,8 +481,8 @@
'db1087' => 1,
],
'api' => [
-'db1092' => 3,
-   'db1104' => 1,
+   'db1092' => 3,
+   # 'db1104' => 1,
],
'watchlist' => [
'db1099:3318' => 1,

-- 
To view, visit https://gerrit.wikimedia.org/r/404629
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id49ea6ea762f96d7bdfc4ed3db4f5477c108abd4
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Marostegui 
Gerrit-Reviewer: Jcrespo 
Gerrit-Reviewer: Marostegui 
Gerrit-Reviewer: Urbanecm 
Gerrit-Reviewer: Zoranzoki21 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: db-eqiad.php: Depool db1104

[Marostegui (Code Review)]

Marostegui has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404629 )

Change subject: db-eqiad.php: Depool db1104
..

db-eqiad.php: Depool db1104

Needs alter table

Bug: T174569
Change-Id: Id49ea6ea762f96d7bdfc4ed3db4f5477c108abd4
---
M wmf-config/db-eqiad.php
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/29/404629/1

diff --git a/wmf-config/db-eqiad.php b/wmf-config/db-eqiad.php
index 1c2d251..7444b04 100644
--- a/wmf-config/db-eqiad.php
+++ b/wmf-config/db-eqiad.php
@@ -171,10 +171,10 @@
'db1071' => 0,   # D1 2.8TB 160GB, master
# 'db1063' => 0,   # C5 2.8TB 128GB, vslow, dump # to be moved 
to s6
'db1087' => 0, # C2 3.6TB 512GB, vslow, dump # db1095 master
-   'db1092' => 300, # D2 3.6TB 512GB, api
+   'db1092' => 100, # D2 3.6TB 512GB, api
'db1099:3318' => 1,   # B2 3.6TB 512GB # rc, log: s1 and s8
# 'db1101:3318' => 1,   # C2 3.6TB 512GB # rc, log: s7 and s8 # 
T174569
-   'db1104' => 300,  # B3 3.6TB 512GB, api
+   # 'db1104' => 300,  # B3 3.6TB 512GB, api # T174569
'db1109' => 500,  # D8 3.6TB 512GB
],
 
@@ -481,8 +481,8 @@
'db1087' => 1,
],
'api' => [
-'db1092' => 3,
-   'db1104' => 1,
+   'db1092' => 3,
+   # 'db1104' => 1,
],
'watchlist' => [
'db1099:3318' => 1,

-- 
To view, visit https://gerrit.wikimedia.org/r/404629
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id49ea6ea762f96d7bdfc4ed3db4f5477c108abd4
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Marostegui 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikidata...gui-deploy[production]: Merging from 6a7c19001507b21d6b8f447996e188778e3af99c:

[Smalyshev (Code Review)]

Smalyshev has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404628 )

Change subject: Merging from 6a7c19001507b21d6b8f447996e188778e3af99c:
..

Merging from 6a7c19001507b21d6b8f447996e188778e3af99c:

Merge "Disable no-descending-specificity stylelint rule"

Change-Id: If01a56ec9a4edc095fc2c267228717d574f5da14
---
R css/embed.style.min.960e2a8d091fab69f276.css
R css/style.min.605ad8423b53ae1b204f.css
M embed.html
M i18n/ar.json
M i18n/arab.json
M i18n/bg.json
M i18n/bn.json
M i18n/br.json
M i18n/ca.json
M i18n/da.json
M i18n/de.json
M i18n/ec.json
M i18n/el.json
M i18n/en.json
M i18n/eo.json
M i18n/es.json
M i18n/eu.json
M i18n/fa.json
M i18n/fi.json
M i18n/fr.json
M i18n/gl.json
M i18n/hans.json
M i18n/hant.json
M i18n/io.json
M i18n/it.json
M i18n/ja.json
M i18n/ko.json
M i18n/lb.json
M i18n/mk.json
M i18n/mwl.json
M i18n/nb.json
M i18n/pt.json
M i18n/qqq.json
M i18n/ru.json
M i18n/tarask.json
M i18n/th.json
M i18n/uk.json
M index.html
R js/embed.vendor.min.37a2244d96d50592f1b9.js
D js/embed.wdqs.min.82e43fb9327f496a339d.js
A js/embed.wdqs.min.eb0102953a284d576675.js
R js/vendor.min.d58f2053d4a7c20f9ffa.js
D js/wdqs.min.39e024bef0685bb4e558.js
A js/wdqs.min.41a76f3fc525cb2fb571.js
44 files changed, 43 insertions(+), 43 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikidata/query/gui-deploy 
refs/changes/28/404628/1


-- 
To view, visit https://gerrit.wikimedia.org/r/404628
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If01a56ec9a4edc095fc2c267228717d574f5da14
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/gui-deploy
Gerrit-Branch: production
Gerrit-Owner: Smalyshev 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Drop use of MobileOptionsTracking schema

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404495 )

Change subject: Drop use of MobileOptionsTracking schema
..


Drop use of MobileOptionsTracking schema

Going forward we can rely on pageview data to get a sense of how
many users are in beta.

statsd also gives us a  little information on behaviour of the form
so we keep it.

EventLogging has been broken for some time so is removed.

Bug: T182235
Change-Id: I365a31a2e4d1cce280d89fc2a2004290e8ff548d
---
M includes/specials/SpecialMobileOptions.php
1 file changed, 1 insertion(+), 22 deletions(-)

Approvals:
  jenkins-bot: Verified
  Phuedx: Looks good to me, approved
  Jdlrobson: Looks good to me, but someone else must approve



diff --git a/includes/specials/SpecialMobileOptions.php 
b/includes/specials/SpecialMobileOptions.php
index 81cfdbe..a61e1ce 100644
--- a/includes/specials/SpecialMobileOptions.php
+++ b/includes/specials/SpecialMobileOptions.php
@@ -219,12 +219,6 @@
 * of returnto or, if not set, back to this special page
 */
private function submitSettingsForm() {
-   $schema = 'MobileOptionsTracking';
-   $schemaRevision = 16934032;
-   $schemaData = [
-   'action' => 'success',
-   'beta' => "nochange",
-   ];
$context = MobileContext::singleton();
$request = $this->getRequest();
$user = $this->getUser();
@@ -236,26 +230,11 @@
. $this->msg( "mobile-frontend-save-error" 
)->parse()
. ''
);
-   $schemaData['action'] = 'error';
-   $schemaData['errorText'] = $errorText;
-   ExtMobileFrontend::eventLog( $schema, $schemaRevision, 
$schemaData );
$this->addSettingsForm();
return;
}
 
-   if ( $request->getBool( 'enableBeta' ) ) {
-   $group = 'beta';
-   if ( !$context->isBetaGroupMember() ) {
-   // The request was to turn on beta
-   $schemaData['beta'] = "on";
-   }
-   } else {
-   $group = '';
-   if ( $context->isBetaGroupMember() ) {
-   // beta was turned off
-   $schemaData['beta'] = "off";
-   }
-   }
+   $group = $request->getBool( 'enableBeta' ) ? 'beta' : '';
$context->setMobileMode( $group );
$returnToTitle = Title::newFromText( $request->getText( 
'returnto' ) );
if ( $returnToTitle ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/404495
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I365a31a2e4d1cce280d89fc2a2004290e8ff548d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Phuedx 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Phuedx 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Update OOUI to v0.25.1

[VolkerE (Code Review)]

VolkerE has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404627 )

Change subject: Update OOUI to v0.25.1
..

Update OOUI to v0.25.1

Release notes:
 
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.25.1

Depends-on: I4d0697f93fccd919fedd370b0c196af8a3046c50
Change-Id: I6413f052928b1980a6a1031df92a932ba1f14941
---
M composer.json
M resources/lib/oojs-ui/i18n/hy.json
M resources/lib/oojs-ui/i18n/ja.json
M resources/lib/oojs-ui/oojs-ui-apex.js
M resources/lib/oojs-ui/oojs-ui-core-apex.css
M resources/lib/oojs-ui/oojs-ui-core-wikimediaui.css
M resources/lib/oojs-ui/oojs-ui-core.js
M resources/lib/oojs-ui/oojs-ui-core.js.map
M resources/lib/oojs-ui/oojs-ui-toolbars-apex.css
M resources/lib/oojs-ui/oojs-ui-toolbars-wikimediaui.css
M resources/lib/oojs-ui/oojs-ui-toolbars.js
M resources/lib/oojs-ui/oojs-ui-toolbars.js.map
M resources/lib/oojs-ui/oojs-ui-widgets-apex.css
M resources/lib/oojs-ui/oojs-ui-widgets-wikimediaui.css
M resources/lib/oojs-ui/oojs-ui-widgets.js
M resources/lib/oojs-ui/oojs-ui-widgets.js.map
M resources/lib/oojs-ui/oojs-ui-wikimediaui.js
M resources/lib/oojs-ui/oojs-ui-windows-apex.css
M resources/lib/oojs-ui/oojs-ui-windows-wikimediaui.css
M resources/lib/oojs-ui/oojs-ui-windows.js
M resources/lib/oojs-ui/oojs-ui-windows.js.map
21 files changed, 249 insertions(+), 257 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/27/404627/1


-- 
To view, visit https://gerrit.wikimedia.org/r/404627
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6413f052928b1980a6a1031df92a932ba1f14941
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: VolkerE 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Update OOUI to v0.25.1

[VolkerE (Code Review)]

VolkerE has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404626 )

Change subject: Update OOUI to v0.25.1
..

Update OOUI to v0.25.1

Release notes:
 
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.25.1

Change-Id: I4d0697f93fccd919fedd370b0c196af8a3046c50
---
M composer.json
M composer.lock
M composer/installed.json
M oojs/oojs-ui/History.md
M oojs/oojs-ui/LICENSE-MIT
M oojs/oojs-ui/README.md
M oojs/oojs-ui/demos/demo.js
M oojs/oojs-ui/demos/demos.php
M oojs/oojs-ui/demos/index.html
M oojs/oojs-ui/demos/pages/widgets.php
M oojs/oojs-ui/i18n/hy.json
M oojs/oojs-ui/i18n/ja.json
M oojs/oojs-ui/package.json
M oojs/oojs-ui/php/Element.php
M oojs/oojs-ui/php/Tag.php
M oojs/oojs-ui/php/widgets/MultilineTextInputWidget.php
M oojs/oojs-ui/php/widgets/TextInputWidget.php
17 files changed, 134 insertions(+), 129 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/vendor 
refs/changes/26/404626/1

diff --git a/composer.json b/composer.json
index 1193387..23c9403 100644
--- a/composer.json
+++ b/composer.json
@@ -82,7 +82,7 @@
"mustangostang/spyc": "0.6.2",
"nikic/php-parser": "3.0.6",
"nmred/kafka-php": "0.1.5",
-   "oojs/oojs-ui": "0.25.0",
+   "oojs/oojs-ui": "0.25.1",
"oyejorge/less.php": "1.7.0.14",
"pear/console_getopt": "1.4.1",
"pear/mail": "1.4.1",
diff --git a/composer.lock b/composer.lock
index 31fdabf..79b8e27 100644
--- a/composer.lock
+++ b/composer.lock
@@ -4,7 +4,7 @@
 "Read more about it at 
https://getcomposer.org/doc/01-basic-usage.md#composer-lock-the-lock-file;,
 "This file is @generated automatically"
 ],
-"content-hash": "9806bc719f523adfc8bb29f4388b54fe",
+"content-hash": "837c313a820d305f7d8972f339ad3f58",
 "packages": [
 {
 "name": "composer/semver",
@@ -1192,16 +1192,16 @@
 },
 {
 "name": "oojs/oojs-ui",
-"version": "v0.25.0",
+"version": "v0.25.1",
 "source": {
 "type": "git",
 "url": "https://github.com/wikimedia/oojs-ui.git;,
-"reference": "c165b27112aeb281437bb724603851d12f3cb714"
+"reference": "f78d952f8f2deb2d6a251c0243b3b1f2e8639a95"
 },
 "dist": {
 "type": "zip",
-"url": 
"https://api.github.com/repos/wikimedia/oojs-ui/zipball/c165b27112aeb281437bb724603851d12f3cb714;,
-"reference": "c165b27112aeb281437bb724603851d12f3cb714",
+"url": 
"https://api.github.com/repos/wikimedia/oojs-ui/zipball/f78d952f8f2deb2d6a251c0243b3b1f2e8639a95;,
+"reference": "f78d952f8f2deb2d6a251c0243b3b1f2e8639a95",
 "shasum": ""
 },
 "require": {
@@ -1266,8 +1266,8 @@
 }
 ],
 "description": "Provides library of common widgets, layouts, and 
windows.",
-"homepage": "https://www.mediawiki.org/wiki/OOjs_UI;,
-"time": "2018-01-09T23:46:30+00:00"
+"homepage": "https://www.mediawiki.org/wiki/OOUI;,
+"time": "2018-01-17T01:10:25+00:00"
 },
 {
 "name": "oyejorge/less.php",
diff --git a/composer/installed.json b/composer/installed.json
index 9c4fd20..af5afe8 100644
--- a/composer/installed.json
+++ b/composer/installed.json
@@ -3638,87 +3638,6 @@
 "description": "Parsing and pretty-printing Lucene explain data"
 },
 {
-"name": "oojs/oojs-ui",
-"version": "v0.25.0",
-"version_normalized": "0.25.0.0",
-"source": {
-"type": "git",
-"url": "https://github.com/wikimedia/oojs-ui.git;,
-"reference": "c165b27112aeb281437bb724603851d12f3cb714"
-},
-"dist": {
-"type": "zip",
-"url": 
"https://api.github.com/repos/wikimedia/oojs-ui/zipball/c165b27112aeb281437bb724603851d12f3cb714;,
-"reference": "c165b27112aeb281437bb724603851d12f3cb714",
-"shasum": ""
-},
-"require": {
-"mediawiki/at-ease": "1.1.0",
-"php": ">=5.5.9"
-},
-"require-dev": {
-"jakub-onderka/php-parallel-lint": "0.9.2",
-"mediawiki/mediawiki-codesniffer": "15.0.0",
-"phpunit/phpunit": "4.8.21"
-},
-"time": "2018-01-09T23:46:30+00:00",
-"type": "library",
-"installation-source": "dist",
-"autoload": {
-"classmap": [
-"php/"
-]
-},
-"notification-url": "https://packagist.org/downloads/;,
-"license": [
-"MIT"
-],
-"authors": [
-{
-"name": "Timo Tijhof",
-"email": 

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: PetScanPageGenerator.query: Raise ServerError if response st...

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404621 )

Change subject: PetScanPageGenerator.query: Raise ServerError if response 
status is 5xx
..


PetScanPageGenerator.query: Raise ServerError if response status is 5xx

Also skip the related test if there is a ServerError.

Bug: T184426
Change-Id: Ie0110b85be9fe170ca2356ee45369a1771fb2be1
---
M pywikibot/pagegenerators.py
M tests/pagegenerators_tests.py
2 files changed, 15 insertions(+), 4 deletions(-)

Approvals:
  jenkins-bot: Verified
  Xqt: Looks good to me, approved



diff --git a/pywikibot/pagegenerators.py b/pywikibot/pagegenerators.py
index b952a82..e67b64e 100644
--- a/pywikibot/pagegenerators.py
+++ b/pywikibot/pagegenerators.py
@@ -49,7 +49,11 @@
 from pywikibot import date, config, i18n, xmlreader
 from pywikibot.bot import ListOption
 from pywikibot.comms import http
-from pywikibot.exceptions import ArgumentDeprecationWarning, UnknownExtension
+from pywikibot.exceptions import (
+ArgumentDeprecationWarning,
+ServerError,
+UnknownExtension,
+)
 from pywikibot.logentries import LogEntryFactory
 from pywikibot.proofreadpage import ProofreadPage
 
@@ -2915,6 +2919,9 @@
 url = 'https://petscan.wmflabs.org'
 
 req = http.fetch(url, params=self.opts)
+if 500 <= req.status < 600:
+raise ServerError(
+'received {0} status from {1}'.format(req.status, req.uri))
 j = json.loads(req.content)
 raw_pages = j['*'][0]['a']['*']
 for raw_page in raw_pages:
diff --git a/tests/pagegenerators_tests.py b/tests/pagegenerators_tests.py
index 5dd0f69..11e4d6b 100755
--- a/tests/pagegenerators_tests.py
+++ b/tests/pagegenerators_tests.py
@@ -15,7 +15,7 @@
 import pywikibot
 from pywikibot import pagegenerators, date
 
-from pywikibot.exceptions import UnknownExtension
+from pywikibot.exceptions import ServerError, UnknownExtension
 
 from pywikibot.pagegenerators import (
 PagesFromTitlesGenerator,
@@ -362,8 +362,12 @@
 """Test PetScanPageGenerator."""
 site = self.get_site()
 gen = pagegenerators.PetScanPageGenerator(['Pywikibot Protect Test'], 
True, None, site)
-self.assertPagelistTitles(gen, titles=('User:Sn1per/ProtectTest1',
-   'User:Sn1per/ProtectTest2'), 
site=site)
+try:
+self.assertPagelistTitles(gen, titles=(
+'User:Sn1per/ProtectTest1', 'User:Sn1per/ProtectTest2'),
+site=site)
+except ServerError as e:
+self.skipTest(e)
 
 gen = pagegenerators.PetScanPageGenerator(['Pywikibot Protect Test'], 
False, None, site)
 self.assertPagelistTitles(gen, titles=('User:Sn1per/ProtectTest1',

-- 
To view, visit https://gerrit.wikimedia.org/r/404621
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0110b85be9fe170ca2356ee45369a1771fb2be1
Gerrit-PatchSet: 4
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Dalba 
Gerrit-Reviewer: John Vandenberg 
Gerrit-Reviewer: Xqt 
Gerrit-Reviewer: Zoranzoki21 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...GlobalPreferences[master]: Override now-protected showResetForm() rather than re-implem...

[Samwilson (Code Review)]

Samwilson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404625 )

Change subject: Override now-protected showResetForm() rather than 
re-implementing
..

Override now-protected showResetForm() rather than re-implementing

The parent method used to be private, but is now protected, and
so we can clean some things up here. It's still duplicating code,
but it's less than before.

Change-Id: If9dbdd78c2818483c76e92fe70fe9b4a2b7c9fa5
---
M includes/SpecialGlobalPreferences.php
1 file changed, 2 insertions(+), 18 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GlobalPreferences 
refs/changes/25/404625/1

diff --git a/includes/SpecialGlobalPreferences.php 
b/includes/SpecialGlobalPreferences.php
index 204623c..4bb4920 100644
--- a/includes/SpecialGlobalPreferences.php
+++ b/includes/SpecialGlobalPreferences.php
@@ -27,12 +27,6 @@
 * @throws UserNotLoggedIn
 */
public function execute( $par ) {
-   // Because parent::showResetForm() is private, we have to 
override it separately here.
-   if ( $par == 'reset' ) {
-   $this->showGlobalPrefsResetForm();
-   return;
-   }
-
// Dirty override to check user can set global prefs.
if ( $this->getUser()->isAnon() ) {
// @todo use our own error messages here
@@ -76,23 +70,13 @@
 
/**
 * Display the preferences-reset confirmation page.
-* This mostly repeats code in parent::execute() and 
parent::showResetForm().
+* This is identical to parent::showResetForm except with the message 
names changed.
 * @throws PermissionsError
 */
-   protected function showGlobalPrefsResetForm() {
+   protected function showResetForm() {
if ( !$this->getUser()->isAllowed( 'editmyoptions' ) ) {
throw new PermissionsError( 'editmyoptions' );
}
-
-   // This section is duplicated from parent::execute().
-   $this->setHeaders();
-   $this->outputHeader();
-   $out = $this->getOutput();
-   // Prevent hijacked user scripts from sniffing passwords etc.
-   $out->disallowUserJs();
-   // Use the same message as normal Preferences for the 
login-redirection message.
-   $this->requireLogin( 'prefsnologintext2' );
-   $this->checkReadOnly();
 
$this->getOutput()->addWikiMsg( 'globalprefs-reset-intro' );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/404625
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If9dbdd78c2818483c76e92fe70fe9b4a2b7c9fa5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GlobalPreferences
Gerrit-Branch: master
Gerrit-Owner: Samwilson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Add Draft Namespace in enwikiversity

[Jayprakash12345 (Code Review)]

Jayprakash12345 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404624 )

Change subject: Add Draft Namespace in enwikiversity
..

Add Draft Namespace in enwikiversity

Bug: T184957
Change-Id: I486d420580d95a827409b9213dec2500f73c18b8
---
M wmf-config/InitialiseSettings.php
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/24/404624/2

diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index c76cecc..a1efad2 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -7110,6 +7110,8 @@
105 => 'Topic_talk',
106 => 'Collection',
107 => 'Collection_talk',
+   118 => 'Draft', // T184957
+   119 => 'Draft_talk',
],
'frwikiversity' => [
102 => 'Projet',

-- 
To view, visit https://gerrit.wikimedia.org/r/404624
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I486d420580d95a827409b9213dec2500f73c18b8
Gerrit-PatchSet: 2
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Jayprakash12345 <0freerunn...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...GlobalPreferences[master]: Centre globalizing checkboxes, and prevent overwrapping of h...

[Samwilson (Code Review)]

Samwilson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404623 )

Change subject: Centre globalizing checkboxes, and prevent overwrapping of 
header
..

Centre globalizing checkboxes, and prevent overwrapping of header

Bug: T179542
Change-Id: Ibdde03d95c3c314b8162f8bf474c54bf862d026e
---
M resources/ext.GlobalPreferences.global-nojs.css
1 file changed, 12 insertions(+), 2 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GlobalPreferences 
refs/changes/23/404623/1

diff --git a/resources/ext.GlobalPreferences.global-nojs.css 
b/resources/ext.GlobalPreferences.global-nojs.css
index 8b091b9..b8852b9 100644
--- a/resources/ext.GlobalPreferences.global-nojs.css
+++ b/resources/ext.GlobalPreferences.global-nojs.css
@@ -51,21 +51,31 @@
padding-right: 0.5em;
 }
 
-.mw-globalprefs-global-check {
+div.mw-globalprefs-global-check {
font-size: smaller;
padding-left: 0;
float: left;
width: 5%;
+   text-align: center;
 }
-.mw-globalprefs-global-check input.mw-globalprefs-global-check {
+div.mw-globalprefs-global-check div.mw-input {
+   display: inline;
+}
+div.mw-globalprefs-global-check input.mw-globalprefs-global-check {
float: none;
width: auto;
+}
+
+/** Remove fieldset border to distinguish it from other 'proper' fieldsets. */
+fieldset.ext-globalpreferences-select-all {
+   border: 0;
 }
 
 /** Make the column header a bit narrower so it looks more associated with the 
column. */
 .globalprefs-section-header .col-header {
display: block;
width: 7%;
+   min-width: 7em;
text-align: center;
 }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/404623
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibdde03d95c3c314b8162f8bf474c54bf862d026e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GlobalPreferences
Gerrit-Branch: master
Gerrit-Owner: Samwilson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Skip beta cluster test

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404622 )

Change subject: Skip beta cluster test
..


Skip beta cluster test

Beta cluster API is having some issues:
PHP fatal error: Stack overflow

Change-Id: I2292be3d5caae18eba6e0eb6a4d993c6f7659a39
Related: T185055
---
M test/features/mobile-sections/pagecontent.js
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Jdlrobson: Looks good to me, approved



diff --git a/test/features/mobile-sections/pagecontent.js 
b/test/features/mobile-sections/pagecontent.js
index dc072f4..67923d1 100644
--- a/test/features/mobile-sections/pagecontent.js
+++ b/test/features/mobile-sections/pagecontent.js
@@ -109,7 +109,7 @@
 });
 });
 
-it('Beta cluster request should load successfully', () => {
+it.skip('Beta cluster request should load successfully', () => {
 const uri = localUri('Foobar', 'en.wikipedia.beta.wmflabs.org');
 return preq.get({ uri })
 .then((res) => {

-- 
To view, visit https://gerrit.wikimedia.org/r/404622
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2292be3d5caae18eba6e0eb6a4d993c6f7659a39
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: BearND 
Gerrit-Reviewer: Fjalapeno 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Mholloway 
Gerrit-Reviewer: Mhurd 
Gerrit-Reviewer: Ppchelko 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Skip beta cluster test

[BearND (Code Review)]

BearND has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404622 )

Change subject: Skip beta cluster test
..

Skip beta cluster test

Beta cluster API is having some issues:
PHP fatal error: Stack overflow

Change-Id: I2292be3d5caae18eba6e0eb6a4d993c6f7659a39
Related: T185055
---
M test/features/mobile-sections/pagecontent.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps 
refs/changes/22/404622/1

diff --git a/test/features/mobile-sections/pagecontent.js 
b/test/features/mobile-sections/pagecontent.js
index dc072f4..67923d1 100644
--- a/test/features/mobile-sections/pagecontent.js
+++ b/test/features/mobile-sections/pagecontent.js
@@ -109,7 +109,7 @@
 });
 });
 
-it('Beta cluster request should load successfully', () => {
+it.skip('Beta cluster request should load successfully', () => {
 const uri = localUri('Foobar', 'en.wikipedia.beta.wmflabs.org');
 return preq.get({ uri })
 .then((res) => {

-- 
To view, visit https://gerrit.wikimedia.org/r/404622
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2292be3d5caae18eba6e0eb6a4d993c6f7659a39
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: BearND 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: PetScanPageGenerator.query: Raise ServerError if response st...

[Dalba (Code Review)]

Dalba has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404621 )

Change subject: PetScanPageGenerator.query: Raise ServerError if response 
status is 5xx
..

PetScanPageGenerator.query: Raise ServerError if response status is 5xx

Also skip the related test if there is a ServerError.

Bug: T184426
Change-Id: Ie0110b85be9fe170ca2356ee45369a1771fb2be1
---
M pywikibot/pagegenerators.py
M tests/pagegenerators_tests.py
2 files changed, 14 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/21/404621/1

diff --git a/pywikibot/pagegenerators.py b/pywikibot/pagegenerators.py
index b952a82..a8d3001 100644
--- a/pywikibot/pagegenerators.py
+++ b/pywikibot/pagegenerators.py
@@ -49,7 +49,11 @@
 from pywikibot import date, config, i18n, xmlreader
 from pywikibot.bot import ListOption
 from pywikibot.comms import http
-from pywikibot.exceptions import ArgumentDeprecationWarning, UnknownExtension
+from pywikibot.exceptions import (
+ArgumentDeprecationWarning,
+UnknownExtension,
+ServerError,
+)
 from pywikibot.logentries import LogEntryFactory
 from pywikibot.proofreadpage import ProofreadPage
 
@@ -2915,6 +2919,8 @@
 url = 'https://petscan.wmflabs.org'
 
 req = http.fetch(url, params=self.opts)
+if 500 < req.status < 600:
+raise ServerError('{0} status on {1}'.format(req.status, req.uri))
 j = json.loads(req.content)
 raw_pages = j['*'][0]['a']['*']
 for raw_page in raw_pages:
diff --git a/tests/pagegenerators_tests.py b/tests/pagegenerators_tests.py
index 5dd0f69..e73f4e3 100755
--- a/tests/pagegenerators_tests.py
+++ b/tests/pagegenerators_tests.py
@@ -15,7 +15,7 @@
 import pywikibot
 from pywikibot import pagegenerators, date
 
-from pywikibot.exceptions import UnknownExtension
+from pywikibot.exceptions import UnknownExtension, ServerError
 
 from pywikibot.pagegenerators import (
 PagesFromTitlesGenerator,
@@ -362,8 +362,12 @@
 """Test PetScanPageGenerator."""
 site = self.get_site()
 gen = pagegenerators.PetScanPageGenerator(['Pywikibot Protect Test'], 
True, None, site)
-self.assertPagelistTitles(gen, titles=('User:Sn1per/ProtectTest1',
-   'User:Sn1per/ProtectTest2'), 
site=site)
+try:
+self.assertPagelistTitles(gen, titles=(
+'User:Sn1per/ProtectTest1', 'User:Sn1per/ProtectTest2'),
+site=site)
+except ServerError as e:
+self.skipTest(e)
 
 gen = pagegenerators.PetScanPageGenerator(['Pywikibot Protect Test'], 
False, None, site)
 self.assertPagelistTitles(gen, titles=('User:Sn1per/ProtectTest1',

-- 
To view, visit https://gerrit.wikimedia.org/r/404621
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie0110b85be9fe170ca2356ee45369a1771fb2be1
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Dalba 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Move flaggedrevs to NS_MAIN on arwiki

[TerraCodes (Code Review)]

TerraCodes has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404620 )

Change subject: Move flaggedrevs to NS_MAIN on arwiki
..

Move flaggedrevs to NS_MAIN on arwiki

Bug: T148603
Change-Id: Ic6ee514a455b2ba135fcf7b2666c9b0a7f9486dd
---
M wmf-config/flaggedrevs.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/20/404620/1

diff --git a/wmf-config/flaggedrevs.php b/wmf-config/flaggedrevs.php
index 55f40be..76ed7ae 100644
--- a/wmf-config/flaggedrevs.php
+++ b/wmf-config/flaggedrevs.php
@@ -32,7 +32,7 @@
$wgGroupPermissions['sysop']['stablesettings'] = true; // -aaron 3/20/10
 } elseif ( $wgDBname == 'arwiki' ) {
$wgFlaggedRevsWhitelist = [ 'الصفحة_الرئيسية' ];
-   $wgFlaggedRevsNamespaces = array_merge( $wgFlaggedRevsNamespaces, [ 
100, 104 ] ); // T21332
+   $wgFlaggedRevsNamespaces = [ NS_MAIN ]; // T21332, T148603
 } elseif ( $wgDBname == 'bewiki' ) {
$wgFlaggedRevsOverride = false;
$wgFlaggedRevsNamespaces[] = NS_CATEGORY;

-- 
To view, visit https://gerrit.wikimedia.org/r/404620
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic6ee514a455b2ba135fcf7b2666c9b0a7f9486dd
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: TerraCodes 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Timeless[master]: Make languages portlet visible when empty

[Evad37 (Code Review)]

Evad37 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404619 )

Change subject: Make languages portlet visible when empty
..

Make languages portlet visible when empty

The languages portlet should always be visible so that the ULS
is always visible.

Bug: T181362
Change-Id: Icd89ccd28072758b9267906e5f4b72c39da5269d
---
M resources/screen-common.less
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Timeless 
refs/changes/19/404619/1

diff --git a/resources/screen-common.less b/resources/screen-common.less
index e07d336..81bb746 100644
--- a/resources/screen-common.less
+++ b/resources/screen-common.less
@@ -528,6 +528,9 @@
 .emptyPortlet {
display: none;
 }
+#p-lang.emptyPortlet {
+   display: inherit;
+}
 
 /* Hidden stuff */
 

-- 
To view, visit https://gerrit.wikimedia.org/r/404619
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icd89ccd28072758b9267906e5f4b72c39da5269d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Timeless
Gerrit-Branch: master
Gerrit-Owner: Evad37 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: Solve -cc conflict in imagecopy

[Ryan10145 (Code Review)]

Ryan10145 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404618 )

Change subject: Solve -cc conflict in imagecopy
..

Solve -cc conflict in imagecopy

imagecopy.py did not support its -cc option because it conflicted with
the global option to toggle cosmetic changes
Renamed the local implementation and added option descriptions

Bug: T182522
Change-Id: I2db4e4ffa313ff3cc043658b3ca3d6d436d65a5b
---
M scripts/imagecopy.py
1 file changed, 12 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/18/404618/1

diff --git a/scripts/imagecopy.py b/scripts/imagecopy.py
index 7a539b5..6c8a731 100644
--- a/scripts/imagecopy.py
+++ b/scripts/imagecopy.py
@@ -17,6 +17,16 @@
 so he can test at: [[de:Benutzer Diskussion:Magnus Manske]]. You can
 write him in German and English.
 
+Command line options:
+
+-always  Skip the GUI validation
+
+-setcat: Set the category of the copied image
+
+-delete  Delete the image after the image has been transferred. This will
+ only work if the user has sysops privileges, otherwise the image
+ will only be marked for deletion.
+
 Examples
 
 Work on a single image::
@@ -494,8 +504,8 @@
 for arg in local_args:
 if arg == '-always':
 always = True
-elif arg.startswith('-cc:'):
-category = arg[len('-cc:'):]
+elif arg.startswith('-setcat:'):
+category = arg[len('-setcat:'):]
 elif arg == '-delete':
 delete_after_done = True
 else:

-- 
To view, visit https://gerrit.wikimedia.org/r/404618
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2db4e4ffa313ff3cc043658b3ca3d6d436d65a5b
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Ryan10145 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Dynamically update status of save button in Randomizer...

[Cooltey (Code Review)]

Cooltey has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404617 )

Change subject: Dynamically update status of save button in Randomizer 
page
..

Dynamically update status of save button in Randomizer page

 - Default => disable button
 - When card has been loaded => enable button
 - Add status into list

Bug: T184869
Change-Id: I4930582bff28331b5b1a002e1b5a0166e1ce769c
---
M app/src/main/java/org/wikipedia/random/RandomFragment.java
M app/src/main/java/org/wikipedia/random/RandomItemFragment.java
2 files changed, 23 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/17/404617/1

diff --git a/app/src/main/java/org/wikipedia/random/RandomFragment.java 
b/app/src/main/java/org/wikipedia/random/RandomFragment.java
index 29e2c2e..47e101d 100644
--- a/app/src/main/java/org/wikipedia/random/RandomFragment.java
+++ b/app/src/main/java/org/wikipedia/random/RandomFragment.java
@@ -31,6 +31,8 @@
 import org.wikipedia.util.DimenUtil;
 import org.wikipedia.util.FeedbackUtil;
 
+import java.util.ArrayList;
+
 import butterknife.BindView;
 import butterknife.ButterKnife;
 import butterknife.OnClick;
@@ -44,6 +46,7 @@
 private Unbinder unbinder;
 private ExclusiveBottomSheetPresenter bottomSheetPresenter = new 
ExclusiveBottomSheetPresenter();
 private boolean saveButtonState;
+private ArrayList loadStatusList = new ArrayList<>();
 private ViewPagerListener viewPagerListener = new ViewPagerListener();
 @Nullable private RandomizerFunnel funnel;
 
@@ -65,6 +68,7 @@
 randomPager.setPageTransformer(true, new RandomPagerTransformer());
 randomPager.addOnPageChangeListener(viewPagerListener);
 
+enableSaveShareButton(false);
 updateBackButton(0);
 if (savedInstanceState != null && randomPager.getCurrentItem() == 0 && 
getTopTitle() != null) {
 updateSaveShareButton(getTopTitle());
@@ -144,6 +148,10 @@
 (DialogInterface dialogInterface) -> 
updateSaveShareButton(title)));
 }
 
+public ArrayList getLoadStatusList() {
+return loadStatusList;
+}
+
 @SuppressWarnings("magicnumber")
 private void updateBackButton(int pagerPosition) {
 backButton.setClickable(pagerPosition != 0);
@@ -159,6 +167,11 @@
 ? R.drawable.ic_bookmark_white_24dp : 
R.drawable.ic_bookmark_border_white_24dp);
 }
 });
+}
+
+public void enableSaveShareButton(boolean enable) {
+saveButton.setClickable(enable);
+saveButton.setAlpha(enable ? 1f : 0.5f);
 }
 
 @Nullable private PageTitle getTopTitle() {
@@ -247,6 +260,8 @@
 }
 nextPageSelectedAutomatic = false;
 prevPosition = position;
+
+enableSaveShareButton(loadStatusList.get(position));
 }
 
 @Override
diff --git a/app/src/main/java/org/wikipedia/random/RandomItemFragment.java 
b/app/src/main/java/org/wikipedia/random/RandomItemFragment.java
index 5aa5360..b6835c4 100644
--- a/app/src/main/java/org/wikipedia/random/RandomItemFragment.java
+++ b/app/src/main/java/org/wikipedia/random/RandomItemFragment.java
@@ -80,7 +80,8 @@
 }
 
 private void getRandomPage() {
-
+parent().getLoadStatusList().add(false);
+final int getLoadStatusListIndex = parent().getLoadStatusList().size() 
- 1;
 new 
RandomSummaryClient().request(WikipediaApp.getInstance().getWikiSite(), new 
RandomSummaryClient.Callback() {
 @Override
 public void onSuccess(@NonNull Call call, @NonNull 
RbPageSummary pageSummary) {
@@ -88,6 +89,12 @@
 return;
 }
 setContents(pageSummary);
+
+parent().getLoadStatusList().set(getLoadStatusListIndex, true);
+// if in pager position == current position
+if (getPagerPosition() == 
parent().randomPager.getCurrentItem()) {
+parent().enableSaveShareButton(true);
+}
 }
 
 @Override

-- 
To view, visit https://gerrit.wikimedia.org/r/404617
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4930582bff28331b5b1a002e1b5a0166e1ce769c
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Cooltey 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Add a test verifying that rtl.dblist is up to date

[MaxSem (Code Review)]

MaxSem has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404616 )

Change subject: Add a test verifying that rtl.dblist is up to date
..

Add a test verifying that rtl.dblist is up to date

Bug: T172337
Change-Id: Icec6a24372a15c4f771d73aebda476dfdc847844
---
M dblists/rtl.dblist
M tests/dblistTest.php
2 files changed, 49 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/16/404616/1

diff --git a/dblists/rtl.dblist b/dblists/rtl.dblist
index ee872aa..87b0904 100644
--- a/dblists/rtl.dblist
+++ b/dblists/rtl.dblist
@@ -20,8 +20,6 @@
 fawikivoyage
 fawiktionary
 glkwiki
-hawiki
-hawiktionary
 hewiki
 hewikibooks
 hewikinews
@@ -29,7 +27,11 @@
 hewikisource
 hewikivoyage
 hewiktionary
-ladwiki
+kswiki
+kswiktionary
+kswikibooks
+kswikiquote
+lrcwiki
 mznwiki
 pnbwiki
 pnbwiktionary
diff --git a/tests/dblistTest.php b/tests/dblistTest.php
index 6ac7014..b04651b 100644
--- a/tests/dblistTest.php
+++ b/tests/dblistTest.php
@@ -119,4 +119,48 @@
sort( $expectedDbs );
$this->assertEquals( $exprDbs, $expectedDbs );
}
+
+   /**
+* @note Does not support special wikis in RTL languages, luckily there 
are none currently
+*/
+   public function testRtlDblist() {
+   // SiteMatrix currently doesn't know which languages are used 
by special wikis.
+   // We'll have hardcode these.
+   $exceptions = [ 'arwikimedia' ];
+
+   ini_set( 'user_agent', 'mediawiki-config tests' );
+   $siteMatrix = file_get_contents( 
'https://meta.wikimedia.org/w/api.php?action=sitematrix=json=language=dir%7Ccode%7Csite=dbname=2'
 );
+   if ( !$siteMatrix ) {
+   $this->fail( 'Error retrieving site matrix!' );
+   }
+   $siteMatrix = json_decode( $siteMatrix, true );
+   foreach ( $exceptions as $dbname ) {
+   $siteMatrix['sitematrix'][] = [
+   'dir' => 'rtl',
+   'site' => [
+   [ 'dbname' => $dbname ],
+   ],
+   ];
+   }
+
+   $rtl = array_flip( MWWikiversions::readDbListFile( 'rtl' ) );
+   $shouldBeRtl = [];
+
+   foreach ( $siteMatrix['sitematrix'] as $key => $lang ) {
+   if ( !is_numeric( $key )
+   || $lang['dir'] !== 'rtl'
+   ) {
+   continue;
+   }
+   foreach ( $lang['site'] as $site ) {
+   $dbname = $site['dbname'];
+   if ( !isset( $rtl[$dbname] ) ) {
+   $shouldBeRtl[] = $dbname;
+   }
+   unset( $rtl[$dbname] );
+   }
+   }
+   $this->assertEquals( [], array_keys( $rtl ), 'All entries in 
rtl.dblist should correspond to RTL wikis' );
+   $this->assertEquals( [], $shouldBeRtl, 'All RTL wikis should be 
registered in rtl.dblist' );
+   }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/404616
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icec6a24372a15c4f771d73aebda476dfdc847844
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: MaxSem 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: parsoid::testing:: Switch to YAML configuration

[Dzahn (Code Review)]

Dzahn has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/403464 )

Change subject: parsoid::testing:: Switch to YAML configuration 
..


parsoid::testing:: Switch to YAML configuration 

This also enables cpu_workers with useWorker.

The removed empty warnings are from cfff63a in the Parsoid repo.

Change-Id: I0aab1a81f34e717ee1fade5f7b2765d49eb2773b
---
M hieradata/role/common/parsoid/testing.yaml
M modules/parsoid/manifests/init.pp
M modules/profile/manifests/parsoid/testing.pp
M modules/role/manifests/parsoid/rt_client.pp
D modules/testreduce/templates/parsoid-rt-client.rttest.localsettings.js.erb
A modules/testreduce/templates/parsoid-rt.config.yaml.erb
6 files changed, 45 insertions(+), 76 deletions(-)

Approvals:
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/hieradata/role/common/parsoid/testing.yaml 
b/hieradata/role/common/parsoid/testing.yaml
index ada7b11..e406622 100644
--- a/hieradata/role/common/parsoid/testing.yaml
+++ b/hieradata/role/common/parsoid/testing.yaml
@@ -1 +1,2 @@
 parsoid::testing::parsoid_port: 8142
+parsoid::testing::default_api_proxy_uri: 'http://api-rw.discovery.wmnet'
diff --git a/modules/parsoid/manifests/init.pp 
b/modules/parsoid/manifests/init.pp
index 4a0b7ea..d163cb0 100644
--- a/modules/parsoid/manifests/init.pp
+++ b/modules/parsoid/manifests/init.pp
@@ -8,10 +8,14 @@
 # [*port*]
 #   Port to run the Parsoid service on. Default: 8000
 #
-# [*settings_file*]
-#   Location of the old-format Parsoid configuration and settings file. Note
-#   that Parsoid still draws part of its configuration from there when it is
-#   specified. Default: 'conf/wmf/localsettings.js'
+# [*conf*]
+#   Hash or YAML-formatted string that gets merged into the service's
+#   configuration.  Only applicable for non-scap3 deployments.
+#
+# [*no_workers*]
+#   Number of http workers to start.  Default: 'ncpu' (i.e. start as many
+#   workers as there are CPUs)  The same meaning as in service::node
+#   Only applicable for non-scap3 deployments.
 #
 # [*logging_name*]
 #   The logging name to send to logstash. Default: 'parsoid'
@@ -33,12 +37,14 @@
 #   'http://api.svc.eqiad.wmnet'
 #
 # [*discovery*]
-# If defined, will use that discovery key to discover if the current 
datacenter is active
-# for the MediaWiki API, and use HTTP or HTTPS to connect the host 
${discovery}.discovery.wmnet
+#   If defined, will use that discovery key to discover if the current
+#   datacenter is active for the MediaWiki API, and use HTTP or HTTPS to
+#   connect the host ${discovery}.discovery.wmnet
 #
 class parsoid(
 $port  = 8000,
-$settings_file = 'conf/wmf/localsettings.js',
+$conf  = undef,
+$no_workers= 'ncpu',
 $logging_name  = 'parsoid',
 $statsd_prefix = 'parsoid',
 $deployment= 'scap3',
@@ -92,6 +98,8 @@
 } else {
 service::node::config { 'parsoid':
 port   => $port,
+config => $conf,
+no_workers => $no_workers,
 starter_module => 'src/lib/index.js',
 entrypoint => 'apiServiceWorker',
 logging_name   => $logging_name,
@@ -99,9 +107,6 @@
 heartbeat_to   => 18,
 statsd_prefix  => $statsd_prefix,
 auto_refresh   => false,
-config => {
-localsettings => $settings_file,
-},
 }
 }
 }
diff --git a/modules/profile/manifests/parsoid/testing.pp 
b/modules/profile/manifests/parsoid/testing.pp
index a7a3eb1..f08ad5d 100644
--- a/modules/profile/manifests/parsoid/testing.pp
+++ b/modules/profile/manifests/parsoid/testing.pp
@@ -1,11 +1,14 @@
 # Parsoid roundtrip testing, Parsoid & PHP parser visual diff testing
 class profile::parsoid::testing (
 $parsoid_port = hiera('parsoid::testing::parsoid_port'),
+$default_api_proxy_uri = hiera('parsoid::testing::default_api_proxy_uri'),
 ) {
+
 class { '::parsoid':
-port  => $parsoid_port,
-settings_file => '/srv/deployment/parsoid/deploy/src/localsettings.js',
-deployment=> 'git',
+port   => $parsoid_port,
+deployment => 'git',
+no_workers => 1,
+conf   => template('testreduce/parsoid-rt.config.yaml.erb'),
 }
 
 file { '/usr/local/bin/update_parsoid.sh':
@@ -13,15 +16,6 @@
 owner  => 'root',
 group  => 'root',
 mode   => '0555',
-}
-
-# Use this parsoid instance for parsoid rt-testing
-file { '/srv/deployment/parsoid/deploy/src/localsettings.js':
-content => 
template('testreduce/parsoid-rt-client.rttest.localsettings.js.erb'),
-owner   => 'root',
-group   => 'wikidev',
-mode=> '0444',
-before  => Service['parsoid'],
 }
 
 # mysql client and configuration to provide command line access to
diff --git 

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Update OOUI to v0.25.1

[VolkerE (Code Review)]

VolkerE has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404615 )

Change subject: Update OOUI to v0.25.1
..

Update OOUI to v0.25.1

Release notes:
 
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.25.1

Change-Id: I75cc6629d7c7a29276d8ca2cb6e107a0d10021b3
---
M lib/oojs-ui/LICENSE-MIT
M lib/oojs-ui/README.md
M lib/oojs-ui/i18n/hy.json
M lib/oojs-ui/i18n/ja.json
M lib/oojs-ui/oojs-ui-apex-icons-accessibility.css
M lib/oojs-ui/oojs-ui-apex-icons-accessibility.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-alerts.css
M lib/oojs-ui/oojs-ui-apex-icons-alerts.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-content.css
M lib/oojs-ui/oojs-ui-apex-icons-content.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-advanced.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-advanced.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-core.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-core.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-list.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-list.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-styling.css
M lib/oojs-ui/oojs-ui-apex-icons-editing-styling.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-interactions.css
M lib/oojs-ui/oojs-ui-apex-icons-interactions.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-layout.css
M lib/oojs-ui/oojs-ui-apex-icons-layout.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-media.css
M lib/oojs-ui/oojs-ui-apex-icons-media.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-moderation.css
M lib/oojs-ui/oojs-ui-apex-icons-moderation.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-movement.css
M lib/oojs-ui/oojs-ui-apex-icons-movement.rtl.css
M lib/oojs-ui/oojs-ui-apex-icons-user.css
M lib/oojs-ui/oojs-ui-apex-icons-user.rtl.css
M lib/oojs-ui/oojs-ui-apex.css
M lib/oojs-ui/oojs-ui-apex.js
M lib/oojs-ui/oojs-ui-apex.rtl.css
M lib/oojs-ui/oojs-ui-core-apex.css
M lib/oojs-ui/oojs-ui-core-apex.rtl.css
M lib/oojs-ui/oojs-ui-core-wikimediaui.css
M lib/oojs-ui/oojs-ui-core-wikimediaui.rtl.css
M lib/oojs-ui/oojs-ui-core.js
M lib/oojs-ui/oojs-ui-core.js.map
M lib/oojs-ui/oojs-ui-images-apex.css
M lib/oojs-ui/oojs-ui-images-apex.rtl.css
M lib/oojs-ui/oojs-ui-images-wikimediaui.css
M lib/oojs-ui/oojs-ui-images-wikimediaui.rtl.css
M lib/oojs-ui/oojs-ui-toolbars-apex.css
M lib/oojs-ui/oojs-ui-toolbars-apex.rtl.css
M lib/oojs-ui/oojs-ui-toolbars-wikimediaui.css
M lib/oojs-ui/oojs-ui-toolbars-wikimediaui.rtl.css
M lib/oojs-ui/oojs-ui-toolbars.js
M lib/oojs-ui/oojs-ui-toolbars.js.map
M lib/oojs-ui/oojs-ui-widgets-apex.css
M lib/oojs-ui/oojs-ui-widgets-apex.rtl.css
M lib/oojs-ui/oojs-ui-widgets-wikimediaui.css
M lib/oojs-ui/oojs-ui-widgets-wikimediaui.rtl.css
M lib/oojs-ui/oojs-ui-widgets.js
M lib/oojs-ui/oojs-ui-widgets.js.map
M lib/oojs-ui/oojs-ui-wikimediaui-icons-accessibility.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-accessibility.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-alerts.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-alerts.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-content.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-content.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-advanced.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-advanced.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-core.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-core.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-list.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-list.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-styling.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-editing-styling.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-interactions.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-interactions.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-layout.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-layout.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-location.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-location.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-media.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-media.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-moderation.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-moderation.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-movement.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-movement.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-user.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-user.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-wikimedia.css
M lib/oojs-ui/oojs-ui-wikimediaui-icons-wikimedia.rtl.css
M lib/oojs-ui/oojs-ui-wikimediaui.css
M lib/oojs-ui/oojs-ui-wikimediaui.js
M lib/oojs-ui/oojs-ui-wikimediaui.rtl.css
M lib/oojs-ui/oojs-ui-windows-apex.css
M lib/oojs-ui/oojs-ui-windows-apex.rtl.css
M lib/oojs-ui/oojs-ui-windows-wikimediaui.css
M lib/oojs-ui/oojs-ui-windows-wikimediaui.rtl.css
M lib/oojs-ui/oojs-ui-windows.js
M lib/oojs-ui/oojs-ui-windows.js.map
94 files changed, 604 insertions(+), 642 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/15/404615/1


-- 

[MediaWiki-commits] [Gerrit] oojs/ui[master]: Tag v0.25.1

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404613 )

Change subject: Tag v0.25.1
..


Tag v0.25.1

Change-Id: I2e0d47fc053559ae386870dc6ea2168a055424b6
---
M History.md
M package.json
2 files changed, 13 insertions(+), 1 deletion(-)

Approvals:
  Bartosz Dziewoński: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/History.md b/History.md
index a07153e..0e9e45f 100644
--- a/History.md
+++ b/History.md
@@ -1,4 +1,16 @@
 # OOUI Release History
+## v0.25.1 / 2018-01-16
+### Code
+* Allow other stuff to handle the event when we call `simulateLabelClick()` 
(Bartosz Dziewoński)
+* Follow-Up I0f1d9c1f: Update usages of `getSelectedItem` -> 
`findSelectedItem` (Ed Sanders)
+* PanelLayout: Remove buggy `translateZ` performance hack (Volker E.)
+* PopupToolGroup: Revert "Fix popup direction changing…" (Bartosz Dziewoński)
+* Rename prefixes of unique IDs to not mention "OOjs" (Bartosz Dziewoński)
+* build, demos, docs: Use “OOUI” as unified name (Volker E.)
+* demos: Use MultilineTextInputWidget in PHP demos (Ed Sanders)
+* docs: Clarify `required` true handling with `indicator: 'required'` (Volker 
E.)
+* docs: Use “OOUI” as unified name in code comments (Volker E.)
+
 ## v0.25.0 / 2018-01-09
 ### Breaking changes
 * [BREAKING CHANGE] Drop the `constructive` flag entirely (James D. Forrester)
diff --git a/package.json b/package.json
index ce7669b..9cf9121 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "oojs-ui",
-  "version": "0.25.0",
+  "version": "0.25.1",
   "description": "User interface classes built on the OOjs framework.",
   "keywords": [
 "oojs-plugin",

-- 
To view, visit https://gerrit.wikimedia.org/r/404613
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2e0d47fc053559ae386870dc6ea2168a055424b6
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Esanders 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...3D[master]: Display placeholder text until 3D thumb is loaded

[Matthias Mullie (Code Review)]

Matthias Mullie has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404614 )

Change subject: Display placeholder text until 3D thumb is loaded
..

Display placeholder text until 3D thumb is loaded

Bug: T183310
Change-Id: I69af9fe914690cee7c7437da0b32c480be9c8a64
---
M extension.json
M i18n/en.json
M i18n/qqq.json
M modules/ext.3d.js
M modules/mmv.3d.head.js
5 files changed, 154 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/3D 
refs/changes/14/404614/1

diff --git a/extension.json b/extension.json
index adea519..0982c8f 100644
--- a/extension.json
+++ b/extension.json
@@ -30,7 +30,11 @@
"ext.3d.less"
],
"messages": [
-   "3d-badge-text"
+   "3d-badge-text",
+   "3d-thumb-placeholder"
+   ],
+   "dependencies": [
+   "jquery.spinner"
]
},
"mmv.3d": {
diff --git a/i18n/en.json b/i18n/en.json
index ae681da..50cf79e 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -6,5 +6,6 @@
},
"3d": "3d",
"3d-desc": "Provides support for 3d file formats",
-   "3d-badge-text": "3D"
+   "3d-badge-text": "3D",
+   "3d-thumb-placeholder": "Loading thumbnail..."
 }
diff --git a/i18n/qqq.json b/i18n/qqq.json
index c6937a2..d72bbcc 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -8,5 +8,6 @@
},
"3d": "{{name}}",
"3d-desc": 
"{{desc|name=3d|url=https://www.mediawiki.org/wiki/Extension:3d}}\n\n[[wikipedia:3D
 computer graphics|Read more about 3D]]",
-   "3d-badge-text": "{{optional}}\nText for the badge shown in the top 
left corner of images to identify 3D files"
+   "3d-badge-text": "{{optional}}\nText for the badge shown in the top 
left corner of images to identify 3D files",
+   "3d-thumb-placeholder": "Placeholder text to display while the 
thumbnail is still loading"
 }
diff --git a/modules/ext.3d.js b/modules/ext.3d.js
index bfb53c3..7a6315c 100644
--- a/modules/ext.3d.js
+++ b/modules/ext.3d.js
@@ -19,26 +19,158 @@
'use strict';
 
mw.threed = {
-   wrap: function ( $element ) {
-   if ( !$element.parent().hasClass( 'mw-3d-wrapper' ) ) {
-   $element.wrap( $( '' ).addClass( 
'mw-3d-wrapper' ) );
-   }
+   /**
+* @type {object}
+*/
+   thumbnailPromises: {},
 
-   return $element.parent();
+   /**
+* @param {jQuery} $elements
+*/
+   wrap: function ( $elements ) {
+   $elements.each( function ( i, element ) {
+   if ( !$( element ).parent().hasClass( 
'mw-3d-wrapper' ) ) {
+   $( element ).wrap( $( '' 
).addClass( 'mw-3d-wrapper' ) );
+   }
+   } );
+
+   return $elements.parent();
},
 
/**
-* @param {jQuery} $element
+* @param {jQuery} $elements
 */
-   attachBadge: function ( $element ) {
-   var $wrap = this.wrap( $element ),
+   attachBadge: function ( $elements ) {
+   var $wrap = this.wrap( $elements ),
$badge = $( '' )
.addClass( 'mw-3d-badge' )
.text( mw.message( '3d-badge-text' 
).text() );
 
-   $wrap.append( $badge );
+   $elements.each( function ( i, element ) {
+   this.thumbnailLoadComplete( element ).then( 
function () { $wrap.append( $badge ) } );
+   }.bind( this ) );
+   },
+
+   /**
+* @param {jQuery} $elements
+*/
+   addThumbnailPlaceholder: function ( $elements ) {
+   var $spinner = $.createSpinner( { size: 'small', type: 
'inline' } ),
+   $placeholder = $( '' )
+   .addClass( 'mw-3d-thumb-placeholder' )
+   .text( ' ' + mw.message( 
'3d-thumb-placeholder' ).text() + ' ' )
+   .prepend( $spinner );
+
+   // hide the image and put a placeholder there instead
+   $elements.hide().after( $placeholder );
+
+   $elements.each( function( i, element ) {
+   this.thumbnailLoadComplete( element )
+ 

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Add my new key

[Ayounsi (Code Review)]

Ayounsi has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404604 )

Change subject: Add my new key
..


Add my new key

I'm back from travels.
I've confirmed my identity in person with Arzhel.

Change-Id: I59d5e333e82373e95998e146aeabf604eb9c807a
---
M modules/admin/data/data.yaml
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Ayounsi: Verified; Looks good to me, approved



diff --git a/modules/admin/data/data.yaml b/modules/admin/data/data.yaml
index 6142ba7..ac2027c 100644
--- a/modules/admin/data/data.yaml
+++ b/modules/admin/data/data.yaml
@@ -1047,7 +1047,7 @@
 gid: 500
 name: maxsem
 realname: Max Semenik
-ssh_keys: []
+ssh_keys: [ssh-rsa 
B3NzaC1yc2EDAQABAAABAQDfuBTpiiDX2o68s2Lyc2LDT1r39IN3V4bzPVsdZEcJKcti9chfO2BK1xUGZ+KWbUSvQn8TtT0MDTTDDlXEK/oc+MlNn5o+K/xY6lUkyQuWLHZi8GaOuLaqude9myv+u+RGvuvTvre2bVNwAZ94XpSa5gN9BUdrZHeeLGw1NxE9g+675mRxg/2nBM7sPYr7S9MFTxNuW9HUfyXoGx0NZrsTR7gLz0H4ET6HYgLMXVVKIaNLyKkfDdJ/ywmd61LGdp+jUjWjPeClrhutyk/3z//fauC/S1OtyD1IP29Eg3wJbxWaWRnanAq5EueEopz2lOProwOVPnwTYNLk2GRa/xiV
 mseme...@maxsem.corp.wikimedia.org]
 uid: 1220
 email: mseme...@wikimedia.org
   mattflaschen:

-- 
To view, visit https://gerrit.wikimedia.org/r/404604
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I59d5e333e82373e95998e146aeabf604eb9c807a
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: MaxSem 
Gerrit-Reviewer: Alex Monk 
Gerrit-Reviewer: Ayounsi 
Gerrit-Reviewer: Muehlenhoff 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: Tag v0.25.1

[VolkerE (Code Review)]

VolkerE has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404613 )

Change subject: Tag v0.25.1
..

Tag v0.25.1

Change-Id: I2e0d47fc053559ae386870dc6ea2168a055424b6
---
M History.md
M package.json
2 files changed, 13 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/13/404613/1

diff --git a/History.md b/History.md
index a07153e..0e9e45f 100644
--- a/History.md
+++ b/History.md
@@ -1,4 +1,16 @@
 # OOUI Release History
+## v0.25.1 / 2018-01-16
+### Code
+* Allow other stuff to handle the event when we call `simulateLabelClick()` 
(Bartosz Dziewoński)
+* Follow-Up I0f1d9c1f: Update usages of `getSelectedItem` -> 
`findSelectedItem` (Ed Sanders)
+* PanelLayout: Remove buggy `translateZ` performance hack (Volker E.)
+* PopupToolGroup: Revert "Fix popup direction changing…" (Bartosz Dziewoński)
+* Rename prefixes of unique IDs to not mention "OOjs" (Bartosz Dziewoński)
+* build, demos, docs: Use “OOUI” as unified name (Volker E.)
+* demos: Use MultilineTextInputWidget in PHP demos (Ed Sanders)
+* docs: Clarify `required` true handling with `indicator: 'required'` (Volker 
E.)
+* docs: Use “OOUI” as unified name in code comments (Volker E.)
+
 ## v0.25.0 / 2018-01-09
 ### Breaking changes
 * [BREAKING CHANGE] Drop the `constructive` flag entirely (James D. Forrester)
diff --git a/package.json b/package.json
index ce7669b..9cf9121 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "oojs-ui",
-  "version": "0.25.0",
+  "version": "0.25.1",
   "description": "User interface classes built on the OOjs framework.",
   "keywords": [
 "oojs-plugin",

-- 
To view, visit https://gerrit.wikimedia.org/r/404613
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2e0d47fc053559ae386870dc6ea2168a055424b6
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[firsterpaint]: Merge remote-tracking branch 'origin/specialpages' into revi...

[Jdlrobson (Code Review)]

Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404612 )

Change subject: Merge remote-tracking branch 'origin/specialpages' into 
review/jdlrobson/css-cull
..

Merge remote-tracking branch 'origin/specialpages' into 
review/jdlrobson/css-cull

Change-Id: Ide02648f3d7a0367d4cc59d8f54d491b9826cf22
---
M skin.json
1 file changed, 1 insertion(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MinervaNeue 
refs/changes/12/404612/1

diff --git a/skin.json b/skin.json
index c24e21c..df067ee 100644
--- a/skin.json
+++ b/skin.json
@@ -42,14 +42,12 @@
},
"ResourceModuleSkinStyles": {
"minerva": {
-<<< HEAD   (75cbf8 Restrict gallery styles to only pages which need it)
"mediawiki.page.gallery.styles": [

"skinStyles/mediawiki.page.gallery.styles/galleries.less",

"skinStyles/mediawiki.page.gallery.styles/tablet.less"
-===
+   ],
"mobile.special.mobileoptions.styles": [

"skinStyles/mobile.special.mobileoptions.styles/minerva.less"
->>> BRANCH (dede84 Minerva should use FeatureManagers class)
],
"mediawiki.special.userlogin.common.styles": [

"skinStyles/mediawiki.special.userlogin.common.styles/minerva.less"

-- 
To view, visit https://gerrit.wikimedia.org/r/404612
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ide02648f3d7a0367d4cc59d8f54d491b9826cf22
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: firsterpaint
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: DHCP: switch to http to retrieve installer image

[Dzahn (Code Review)]

Dzahn has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404607 )

Change subject: DHCP: switch to http to retrieve installer image
..


DHCP: switch to http to retrieve installer image

Bug: T182215
Change-Id: Ie3915ac8269c7da4be0644fbe3dbca3f0cad52ca
---
M modules/install_server/files/dhcpd/dhcpd.conf
M modules/install_server/files/dhcpd/linux-host-entries.ttyS0-115200
M modules/install_server/files/dhcpd/linux-host-entries.ttyS1-115200
3 files changed, 2,172 insertions(+), 2,174 deletions(-)

Approvals:
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved




-- 
To view, visit https://gerrit.wikimedia.org/r/404607
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie3915ac8269c7da4be0644fbe3dbca3f0cad52ca
Gerrit-PatchSet: 4
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...SocialProfile[master]: Remove return values from hook subscribers

[SamanthaNguyen (Code Review)]

SamanthaNguyen has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404611 )

Change subject: Remove return values from hook subscribers
..

Remove return values from hook subscribers

This removes the return statements (as well as the @return doc
annotations) from the code, as these are no longer needed since 1.22.
See: I11deb2117ff9233c77868470f50e0d8f74053545

This also slightly improves the docs in SocialProfileHooks.

Change-Id: I7f0595619c4f80b1dc90f864cfcdedaed15522f9
---
M SocialProfileHooks.php
M SystemGifts/UserSystemGiftsHooks.php
M UserActivity/SiteActivityHook.php
M UserBoard/UserBoardHooks.php
M UserProfile/UserProfileHooks.php
M UserRelationship/UserRelationshipHooks.php
M UserStats/UserStatsHooks.php
M UserWelcome/UserWelcomeClass.php
8 files changed, 5 insertions(+), 61 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SocialProfile 
refs/changes/11/404611/1

diff --git a/SocialProfileHooks.php b/SocialProfileHooks.php
index 8bf6cfd..a85bf43 100644
--- a/SocialProfileHooks.php
+++ b/SocialProfileHooks.php
@@ -13,35 +13,29 @@
 *
 * @param OutputPage $out
 * @param Skin $skin
-* @return bool
 */
public static function onBeforePageDisplay( OutputPage &$out, &$skin ) {
$out->addModuleStyles( 'ext.socialprofile.responsive' );
-   return true;
}
 
/**
 * Register the canonical names for our custom namespaces and their 
talkspaces.
 *
-* @param $list Array: array of namespace numbers with corresponding
-* canonical names
-* @return Boolean: true
+* @param array $list Array of namespace numbers
+* with corresponding canonical names
 */
public static function onCanonicalNamespaces( &$list ) {
$list[NS_USER_WIKI] = 'UserWiki';
$list[NS_USER_WIKI_TALK] = 'UserWiki_talk';
$list[NS_USER_PROFILE] = 'User_profile';
$list[NS_USER_PROFILE_TALK] = 'User_profile_talk';
-
-   return true;
}
 
/**
 * Creates SocialProfile's new database tables when the user runs
 * /maintenance/update.php, the MediaWiki core updater script.
 *
-* @param $updater DatabaseUpdater
-* @return Boolean
+* @param DatabaseUpdater $updater
 */
public static function onLoadExtensionSchemaUpdates( $updater ) {
$dir = __DIR__;
@@ -65,17 +59,14 @@
$updater->addExtensionTable( 'user_points_weekly', 
"$dir/UserStats/user_points_weekly$dbExt.sql" );
$updater->addExtensionTable( 'user_points_monthly', 
"$dir/UserStats/user_points_monthly$dbExt.sql" );
$updater->addExtensionTable( 'user_points_archive', 
"$dir/UserStats/user_points_archive$dbExt.sql" );
-
-   return true;
}
 
/**
 * For integration with the Renameuser extension.
 *
 * @param int $uid User ID
-* @param String $oldName old user name
-* @param String $newName new user name
-* @return Boolean
+* @param string $oldName Old user name
+* @param string $newName New user name
 */
public static function onRenameUserComplete( $uid, $oldName, $newName ) 
{
$dbw = wfGetDB( DB_MASTER );
@@ -100,7 +91,5 @@
__METHOD__
);
}
-
-   return true;
}
 }
\ No newline at end of file
diff --git a/SystemGifts/UserSystemGiftsHooks.php 
b/SystemGifts/UserSystemGiftsHooks.php
index d171671..8207d3f 100644
--- a/SystemGifts/UserSystemGiftsHooks.php
+++ b/SystemGifts/UserSystemGiftsHooks.php
@@ -7,7 +7,6 @@
 * @param array $notifications Echo notifications
 * @param array $notificationCategories Echo notification categories
 * @param array $icons Icon details
-* @return bool
 */
public static function onBeforeCreateEchoEvent( &$notifications, 
&$notificationCategories, &$icons ) {
$notificationCategories['social-award'] = array(
@@ -35,8 +34,6 @@
$icons['social-award'] = array(
'path' => 'SocialProfile/images/notifications-award.svg'
);
-
-   return true;
}
 
/**
@@ -44,7 +41,6 @@
 *
 * @param EchoEvent $event
 * @param array $users
-* @return bool
 */
public static function onEchoGetDefaultNotifiedUsers( $event, &$users ) 
{
switch ( $event->getType() ) {
@@ -54,7 +50,6 @@
$users[] = User::newFromId( $targetId );
break;
}
-   return true;
}
 
/**
@@ -62,7 +57,6 @@
   

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Test case: Nested spans should be removed...

[Jdlrobson (Code Review)]

Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404610 )

Change subject: Test case: Nested spans should be removed...
..

Test case: Nested spans should be removed...

No solution as of yet, but the logic to remove empty nodes
is incorrect as
rmElementsWithSelector(doc, 'span:empty,b:empty,i:empty,p:empty');
is not recursive.

This can be seen on Ariana Grande wiki page - the summary results in
a parenthetical with an empty span...

Bug: T185050
Change-Id: I56f44e3a3d2825173c293429c73237db05e2a000
---
M test/lib/transformations/summarize.js
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps 
refs/changes/10/404610/1

diff --git a/test/lib/transformations/summarize.js 
b/test/lib/transformations/summarize.js
index ec25458..7898069 100644
--- a/test/lib/transformations/summarize.js
+++ b/test/lib/transformations/summarize.js
@@ -8,6 +8,11 @@
 describe('summarize', () => {
 it('matches the spec', () => {
 const testCases = [
+// Should remove nested empty spans
+[
+'Hello () 
darkness',
+'Hello darkness'
+],
 // Should remove unwanted elements
 [
 '.foo.',

-- 
To view, visit https://gerrit.wikimedia.org/r/404610
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I56f44e3a3d2825173c293429c73237db05e2a000
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: Rename prefixes of unique IDs to not mention "OOjs"

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404601 )

Change subject: Rename prefixes of unique IDs to not mention "OOjs"
..


Rename prefixes of unique IDs to not mention "OOjs"

Following up the recent changes to unify the name of the library
to "OOUI".

Note that the prefixes in OOUI\Tag::generateElementId() and
OO.ui.generateElementId() must be different to avoid conflicts.

Change-Id: I0866d984aadf1fac24b790ccb2e26818eb5ad539
---
M php/Tag.php
M src/core.js
M tests/QUnit.assert.equalDomElement.js
3 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  jenkins-bot: Verified
  VolkerE: Looks good to me, approved



diff --git a/php/Tag.php b/php/Tag.php
index e35fcd2..9f39861 100644
--- a/php/Tag.php
+++ b/php/Tag.php
@@ -279,7 +279,7 @@
 */
public static function generateElementId() {
self::$elementId++;
-   return 'ooui-' . self::$elementId;
+   return 'ooui-php-' . self::$elementId;
}
 
/**
diff --git a/src/core.js b/src/core.js
index ba9081d..c4afac5 100644
--- a/src/core.js
+++ b/src/core.js
@@ -54,7 +54,7 @@
  */
 OO.ui.generateElementId = function () {
OO.ui.elementId++;
-   return 'oojsui-' + OO.ui.elementId;
+   return 'ooui-' + OO.ui.elementId;
 };
 
 /**
diff --git a/tests/QUnit.assert.equalDomElement.js 
b/tests/QUnit.assert.equalDomElement.js
index d8d6ccb..afacb1a 100644
--- a/tests/QUnit.assert.equalDomElement.js
+++ b/tests/QUnit.assert.equalDomElement.js
@@ -119,7 +119,7 @@
attribute = autogeneratedAttributes[ i ];
if (
summary.attributes[ attribute ] !== undefined &&
-   summary.attributes[ attribute ].match( 
/^(ooui-|oojsui-)/ )
+   summary.attributes[ attribute ].match( 
/^(ooui-php-|ooui-)/ )
) {
summary.attributes[ attribute ] = 
'(autogenerated)';
}

-- 
To view, visit https://gerrit.wikimedia.org/r/404601
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0866d984aadf1fac24b790ccb2e26818eb5ad539
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 
Gerrit-Reviewer: VolkerE 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: Allow other stuff to handle the event when we call simulateL...

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/403750 )

Change subject: Allow other stuff to handle the event when we call 
simulateLabelClick()
..


Allow other stuff to handle the event when we call simulateLabelClick()

Using `return false` is equivalent to calling e.preventDefault() and
e.stopPropagation(). We want to remove the call to e.preventDefault()
to allow the browsers to handle links etc. in the label. Removing the
e.stopPropagation() call is harmless.

Bug: T184708
Change-Id: Ie4d780dec1af02e8d1ccc6ccb12cf5c6c163a242
---
M src/layouts/FieldLayout.js
M src/widgets/LabelWidget.js
2 files changed, 0 insertions(+), 2 deletions(-)

Approvals:
  jenkins-bot: Verified
  VolkerE: Looks good to me, approved
  Jforrester: Looks good to me, but someone else must approve



diff --git a/src/layouts/FieldLayout.js b/src/layouts/FieldLayout.js
index 502416f..439a992 100644
--- a/src/layouts/FieldLayout.js
+++ b/src/layouts/FieldLayout.js
@@ -114,7 +114,6 @@
} else {
this.$label.on( 'click', function () {
this.fieldWidget.simulateLabelClick();
-   return false;
}.bind( this ) );
}
this.$element
diff --git a/src/widgets/LabelWidget.js b/src/widgets/LabelWidget.js
index 020a6ab..0820d4e 100644
--- a/src/widgets/LabelWidget.js
+++ b/src/widgets/LabelWidget.js
@@ -58,7 +58,6 @@
} else {
this.$label.on( 'click', function () {
this.input.simulateLabelClick();
-   return false;
}.bind( this ) );
}
}

-- 
To view, visit https://gerrit.wikimedia.org/r/403750
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie4d780dec1af02e8d1ccc6ccb12cf5c6c163a242
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: VolkerE 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: PanelLayout: Remove buggy `translateZ` performance hack

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404608 )

Change subject: PanelLayout: Remove buggy `translateZ` performance hack
..


PanelLayout: Remove buggy `translateZ` performance hack

Promoting to GPU as general approach introduced in
Ie8b99bf84dc71b4f6a50b441bf0a6f5a11050eff has lead to several
rendering glitches as side-effect.
Let's remove it and use it only on specific instances.

Bug: T158610
Bug: T185051
Change-Id: I87b2e027478e6c040deb31f248f4cdf90b671f7e
---
M src/styles/layouts/PanelLayout.less
M src/themes/apex/layouts.less
M src/themes/wikimediaui/layouts.less
3 files changed, 0 insertions(+), 17 deletions(-)

Approvals:
  Bartosz Dziewoński: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/src/styles/layouts/PanelLayout.less 
b/src/styles/layouts/PanelLayout.less
index 1a6d4e8..9dbf409 100644
--- a/src/styles/layouts/PanelLayout.less
+++ b/src/styles/layouts/PanelLayout.less
@@ -5,7 +5,6 @@
 
&-scrollable {
overflow: auto;
-   .oo-ui-force-gpu-composite-layer();
}
 
&-expanded {
diff --git a/src/themes/apex/layouts.less b/src/themes/apex/layouts.less
index 75ded09..032c6d4 100644
--- a/src/themes/apex/layouts.less
+++ b/src/themes/apex/layouts.less
@@ -190,14 +190,6 @@
&-padded&-framed {
margin: 1em 0;
}
-
-   // Support Safari (Webkit), see T176837:
-   // When promoted to GPU composite layer through
-   // `.oo-ui-force-gpu-composite-layer()` while not applying a 
`background-color`
-   // results in blurry text
-   &-scrollable {
-   background-color: @background-color-main;
-   }
 }
 
 .theme-oo-ui-tabPanelLayout () {}
diff --git a/src/themes/wikimediaui/layouts.less 
b/src/themes/wikimediaui/layouts.less
index c4a944d..c49adce 100644
--- a/src/themes/wikimediaui/layouts.less
+++ b/src/themes/wikimediaui/layouts.less
@@ -251,14 +251,6 @@
&-padded&-framed {
margin: 1em 0;
}
-
-   // Support Safari (Webkit), see T176837:
-   // When promoted to GPU composite layer through
-   // `.oo-ui-force-gpu-composite-layer()` while not applying a 
`background-color`
-   // results in blurry text
-   &-scrollable {
-   background-color: @background-color-base;
-   }
 }
 
 .theme-oo-ui-tabPanelLayout () {}

-- 
To view, visit https://gerrit.wikimedia.org/r/404608
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I87b2e027478e6c040deb31f248f4cdf90b671f7e
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Esanders 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Update verbiage of reading list download notification.

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404586 )

Change subject: Update verbiage of reading list download notification.
..


Update verbiage of reading list download notification.

Bug: T184827
Change-Id: I6a7bd3ebb31004bb3e690b879547ffbf88701ac0
---
M app/src/main/res/values/strings.xml
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  jenkins-bot: Verified
  Cooltey: Looks good to me, approved



diff --git a/app/src/main/res/values/strings.xml 
b/app/src/main/res/values/strings.xml
index 9189ee5..5569dda 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -416,9 +416,9 @@
 You\'ve been thanked!
 
 Syncing
-Syncing progress
-Syncing %1$d 
articles
-%1$d articles left
+Download progress
+Downloading %1$d 
article(s)
+%1$d article(s) 
left
 Pause
 Resume
 Cancel

-- 
To view, visit https://gerrit.wikimedia.org/r/404586
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6a7bd3ebb31004bb3e690b879547ffbf88701ac0
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant 
Gerrit-Reviewer: Brion VIBBER 
Gerrit-Reviewer: Cooltey 
Gerrit-Reviewer: Sharvaniharan 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/vagrant[master]: Use absolute scope for systemd template variables

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404521 )

Change subject: Use absolute scope for systemd template variables
..


Use absolute scope for systemd template variables

Bug: T184077
Change-Id: I123ba4d1b19c4e5c2c51f9b042e3ac06ffae3362
---
M puppet/modules/ores/templates/systemd/ores-celery.erb
M puppet/modules/ores/templates/systemd/ores-wsgi.erb
M puppet/modules/wikilabels/manifests/init.pp
M puppet/modules/wikilabels/templates/systemd/wikilabels.erb
4 files changed, 7 insertions(+), 7 deletions(-)

Approvals:
  BryanDavis: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/puppet/modules/ores/templates/systemd/ores-celery.erb 
b/puppet/modules/ores/templates/systemd/ores-celery.erb
index 21493e8..bc0c196 100644
--- a/puppet/modules/ores/templates/systemd/ores-celery.erb
+++ b/puppet/modules/ores/templates/systemd/ores-celery.erb
@@ -11,8 +11,8 @@
 User=www-data
 Group=www-data
 SyslogIdentifier=ores-celery
-WorkingDirectory=<%= @ores_root %>
-ExecStart=<%= @venv_dir %>/bin/ores applications.celery --logging-config <%= 
@logging_config %>
+WorkingDirectory=<%= scope['::ores::ores_root'] %>
+ExecStart=<%= scope['::ores::venv_dir'] %>/bin/ores applications.celery 
--logging-config <%= scope['::ores::logging_config'] %>
 Restart=always
 
 [Install]
diff --git a/puppet/modules/ores/templates/systemd/ores-wsgi.erb 
b/puppet/modules/ores/templates/systemd/ores-wsgi.erb
index afeb81b..97bfab6 100644
--- a/puppet/modules/ores/templates/systemd/ores-wsgi.erb
+++ b/puppet/modules/ores/templates/systemd/ores-wsgi.erb
@@ -11,8 +11,8 @@
 User=www-data
 Group=www-data
 SyslogIdentifier=ores-wsgi
-WorkingDirectory=<%= @ores_root %>
-ExecStart=<%= @venv_dir %>/bin/ores applications.wsgi --port=<%= @port %> 
--processes=1 --logging-config <%= @logging_config %>
+WorkingDirectory=<%= scope['::ores::ores_root'] %>
+ExecStart=<%= scope['::ores::venv_dir'] %>/bin/ores applications.wsgi 
--port=<%= scope['::ores::port'] %> --processes=1 --logging-config <%= 
scope['::ores::logging_config'] %>
 Restart=always
 
 [Install]
diff --git a/puppet/modules/wikilabels/manifests/init.pp 
b/puppet/modules/wikilabels/manifests/init.pp
index 9c742b2..fb8ee4c 100644
--- a/puppet/modules/wikilabels/manifests/init.pp
+++ b/puppet/modules/wikilabels/manifests/init.pp
@@ -84,7 +84,7 @@
 command => "echo y | sudo -u www-data ${deploy_dir}/bin/wikilabels 
load_schema --reload-test-data",
 unless  => "sudo -u postgres psql -d ${db_name} -c \"SELECT 
'campaign'::regclass\"",
 cwd => $repo_dir,
-require =>[
+require => [
   Exec['create wikilabels database'],
   Virtualenv::Package['wikilabels'],
   File[$cfg_file],
diff --git a/puppet/modules/wikilabels/templates/systemd/wikilabels.erb 
b/puppet/modules/wikilabels/templates/systemd/wikilabels.erb
index e5c651d..8b3fdeb 100644
--- a/puppet/modules/wikilabels/templates/systemd/wikilabels.erb
+++ b/puppet/modules/wikilabels/templates/systemd/wikilabels.erb
@@ -11,8 +11,8 @@
 User=www-data
 Group=www-data
 SyslogIdentifier=wikilabels
-WorkingDirectory=<%= @repo_dir %>
-ExecStart=<%= @deploy_dir %>/bin/wikilabels dev_server --port=<%= @port %>
+WorkingDirectory=<%= scope['::wikilabels::repo_dir'] %>
+ExecStart=<%= scope['::wikilabels::deploy_dir'] %>/bin/wikilabels dev_server 
--port=<%= scope['::wikilabels::port'] %>
 Restart=always
 
 [Install]

-- 
To view, visit https://gerrit.wikimedia.org/r/404521
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I123ba4d1b19c4e5c2c51f9b042e3ac06ffae3362
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/vagrant
Gerrit-Branch: master
Gerrit-Owner: Awight 
Gerrit-Reviewer: BryanDavis 
Gerrit-Reviewer: Gergő Tisza 
Gerrit-Reviewer: Ladsgroup 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/vagrant[master]: ORES is not in beta anymore

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404524 )

Change subject: ORES is not in beta anymore
..


ORES is not in beta anymore

Remove ORES role dependency on beta feature role now that
ORES Review Tool is completely out of beta.

Change-Id: Ia8a6417480c8a737907c669efeacbbbdefeb250a
---
M puppet/modules/role/manifests/ores.pp
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  BryanDavis: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/puppet/modules/role/manifests/ores.pp 
b/puppet/modules/role/manifests/ores.pp
index c6ea753..4eb21d0 100644
--- a/puppet/modules/role/manifests/ores.pp
+++ b/puppet/modules/role/manifests/ores.pp
@@ -4,7 +4,6 @@
 # (To install the ORES service, use the ores_service role instead.)
 #
 class role::ores {
-include ::role::betafeatures
 include ::mysql
 
 mediawiki::extension { 'ORES':

-- 
To view, visit https://gerrit.wikimedia.org/r/404524
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia8a6417480c8a737907c669efeacbbbdefeb250a
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/vagrant
Gerrit-Branch: master
Gerrit-Owner: Sbisson 
Gerrit-Reviewer: BryanDavis 
Gerrit-Reviewer: Dduvall 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/vagrant[master]: ORES stop using CheckModelVersion

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404526 )

Change subject: ORES stop using CheckModelVersion
..


ORES stop using CheckModelVersion

The CheckModelVersion maintenance script is gone.

Change-Id: I4115246232f6b0524703cf49c1d656527287c389
---
M puppet/modules/role/manifests/ores.pp
1 file changed, 0 insertions(+), 12 deletions(-)

Approvals:
  BryanDavis: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/puppet/modules/role/manifests/ores.pp 
b/puppet/modules/role/manifests/ores.pp
index a36b5be..c6ea753 100644
--- a/puppet/modules/role/manifests/ores.pp
+++ b/puppet/modules/role/manifests/ores.pp
@@ -23,16 +23,4 @@
 },
 },
 }
-
-mediawiki::maintenance { 'check ORES model versions':
-command => '/usr/local/bin/mwscript 
extensions/ORES/maintenance/CheckModelVersions.php --wiki=wiki',
-unless  => "/usr/bin/mysql -e 'select * from ores_model' wiki | 
/bin/grep -q 'damaging'",
-require => Mediawiki::Extension['ORES'],
-}
-
-# Ensure that the maintenance script does not run before the API is alive,
-# when ORES is installed locally via role::ores_service.
-# This is pretty horrible but seems to be the only way of avoiding cycles.
-Systemd::Service<| title == 'ores-wsgi' or title == 'ores-celery' |>
--> Mediawiki::Maintenance['check ORES model versions']
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/404526
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4115246232f6b0524703cf49c1d656527287c389
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/vagrant
Gerrit-Branch: master
Gerrit-Owner: Sbisson 
Gerrit-Reviewer: BryanDavis 
Gerrit-Reviewer: Dduvall 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Do not completely flatten links with child nodes

[Jdlrobson (Code Review)]

Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404609 )

Change subject: Do not completely flatten links with child nodes
..

Do not completely flatten links with child nodes

Only flatten an anchor link to text content.

Bug: T185050
Change-Id: I05edcf02163289e2e735aff54743cd51cb7da42b
---
M lib/transformations/flattenElements.js
M test/lib/transformations/flattenElements.test.js
2 files changed, 14 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps 
refs/changes/09/404609/1

diff --git a/lib/transformations/flattenElements.js 
b/lib/transformations/flattenElements.js
index 0ee39fc..8153bad 100644
--- a/lib/transformations/flattenElements.js
+++ b/lib/transformations/flattenElements.js
@@ -32,13 +32,13 @@
 }
 
 function createReplacementNode(oldElement, document) {
-if (hasAttribute(oldElement, KEEP_ATTRIBUTES)) {
+if (hasAttribute(oldElement, KEEP_ATTRIBUTES) || 
oldElement.querySelectorAll('*').length) {
 const spanElement = document.createElement('span');
 spanElement.innerHTML = oldElement.innerHTML;
 copyAttributes(oldElement, spanElement, KEEP_ATTRIBUTES);
 return spanElement;
 } else {
-return document.createTextNode(oldElement.innerHTML);
+return document.createTextNode(oldElement.textContent);
 }
 }
 
diff --git a/test/lib/transformations/flattenElements.test.js 
b/test/lib/transformations/flattenElements.test.js
index 3bc1c6c..afbd6ab 100644
--- a/test/lib/transformations/flattenElements.test.js
+++ b/test/lib/transformations/flattenElements.test.js
@@ -22,4 +22,16 @@
 flattenElements(document, 'a');
 assert.deepEqual(document.body.innerHTML, 'foo');
 });
+
+it('retains HTML inside elements', () => {
+const document = domino.createDocument('The Mummy 
franchise');
+flattenElements(document, 'a');
+assert.deepEqual(document.body.innerHTML, 'The Mummy 
franchise');
+});
+
+it('does not change the text content of the node', () => {
+const document = domino.createDocument('uh oh');
+flattenElements(document, 'a');
+assert.deepEqual(document.body.innerHTML, 'uh oh');
+});
 });

-- 
To view, visit https://gerrit.wikimedia.org/r/404609
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I05edcf02163289e2e735aff54743cd51cb7da42b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Remove cirrus AB test config for hewiki

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404592 )

Change subject: Remove cirrus AB test config for hewiki
..


Remove cirrus AB test config for hewiki

This test is complete and the configuration is no longer
necessary.

Bug: T182616
Change-Id: Ibb55c90ecf7fc562860fb69a06d2d1f2babf49aa
---
M wmf-config/InitialiseSettings.php
1 file changed, 0 insertions(+), 24 deletions(-)

Approvals:
  EBernhardson: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index 9767eb5..c76cecc 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -18702,30 +18702,6 @@
 
 'wmgCirrusSearchUserTesting' => [
'default' => [],
-   'hewiki' => [
-   'ltr' => [
-   'globals' => [],
-   'buckets' => [
-   'control' => [
-   'trigger' => 'control',
-   ],
-   'ltr-1024' => [
-   'trigger' => 'ltr-1024',
-   'globals' => [
-   'wgCirrusSearchRescoreProfile' 
=> 'mlr-1024rs',
-   ]
-   ],
-   'ltr-1024-i' => [
-   'trigger' => 'ltr-1024-i',
-   'globals' => [
-   
'wgCirrusSearchInterleaveConfig' => [
-   
'CirrusSearchRescoreProfile' => 'mlr-1024rs'
-   ],
-   ],
-   ],
-   ],
-   ],
-   ],
 ],
 
 'wmgCirrusSearchLanguageDetectors' => [

-- 
To view, visit https://gerrit.wikimedia.org/r/404592
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb55c90ecf7fc562860fb69a06d2d1f2babf49aa
Gerrit-PatchSet: 2
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: EBernhardson 
Gerrit-Reviewer: EBernhardson 
Gerrit-Reviewer: Urbanecm 
Gerrit-Reviewer: Zoranzoki21 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Port categories dump header fix

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/392175 )

Change subject: Port categories dump header fix
..


Port categories dump header fix

This fix is ported from https://gerrit.wikimedia.org/r/#/c/372905
since it does not belong to SPARQL updates really.

It changes main node for category dump to

thus allowing to support multiple wikis living on the same domain.w

Change-Id: Ie1ac5ddf6b3b73f3966274f90abc1db50061b494
---
M includes/CategoriesRdf.php
M maintenance/dumpCategoriesAsRdf.php
M tests/phpunit/data/categoriesrdf/categoriesRdf-out.nt
M tests/phpunit/maintenance/categoriesRdfTest.php
4 files changed, 36 insertions(+), 12 deletions(-)

Approvals:
  EBernhardson: Looks good to me, approved
  jenkins-bot: Verified
  Thiemo Kreuz (WMDE): Looks good to me, but someone else must approve



diff --git a/includes/CategoriesRdf.php b/includes/CategoriesRdf.php
index e19dc2a..463f6e8 100644
--- a/includes/CategoriesRdf.php
+++ b/includes/CategoriesRdf.php
@@ -37,7 +37,13 @@
/**
 * Current version of the dump format.
 */
-   const FORMAT_VERSION = "1.0";
+   const FORMAT_VERSION = "1.1";
+   /**
+* Special page for Dump identification.
+* Used as head URI for each wiki's category dump, e.g.:
+* https://en.wikipedia.org/wiki/Special:CategoryDump
+*/
+   const SPECIAL_DUMP = 'Special:CategoryDump';
/**
 * @var RdfWriter
 */
@@ -85,11 +91,29 @@
}
 
/**
+* Make URL from title label
+* @param string $titleLabel Short label (without namespace) of the 
category
+* @return string URL for the category
+*/
+   public function labelToUrl( $titleLabel ) {
+   return $this->titleToUrl( Title::makeTitle( NS_CATEGORY, 
$titleLabel ) );
+   }
+
+   /**
 * Convert Title to link to target page.
 * @param Title $title
-* @return string
+* @return string URL for the category
 */
private function titleToUrl( Title $title ) {
return $title->getFullURL( '', false, PROTO_CANONICAL );
}
+
+   /**
+* Get URI of the dump for this particular wiki.
+* @return false|string
+*/
+   public function getDumpURI() {
+   return $this->titleToUrl( Title::makeTitle( NS_MAIN, 
self::SPECIAL_DUMP ) );
+   }
+
 }
diff --git a/maintenance/dumpCategoriesAsRdf.php 
b/maintenance/dumpCategoriesAsRdf.php
index 282a04b..c1835d0 100644
--- a/maintenance/dumpCategoriesAsRdf.php
+++ b/maintenance/dumpCategoriesAsRdf.php
@@ -96,7 +96,7 @@
if ( substr( $licenseUrl, 0, 2 ) == '//' ) {
$licenseUrl = 'https:' . $licenseUrl;
}
-   $this->rdfWriter->about( wfExpandUrl( '/categoriesDump', 
PROTO_CANONICAL ) )
+   $this->rdfWriter->about( $this->categoriesRdf->getDumpURI() )
->a( 'schema', 'Dataset' )
->a( 'owl', 'Ontology' )
->say( 'cc', 'license' )->is( $licenseUrl )
diff --git a/tests/phpunit/data/categoriesrdf/categoriesRdf-out.nt 
b/tests/phpunit/data/categoriesrdf/categoriesRdf-out.nt
index d2d7ea8..b8bd8e0 100644
--- a/tests/phpunit/data/categoriesrdf/categoriesRdf-out.nt
+++ b/tests/phpunit/data/categoriesrdf/categoriesRdf-out.nt
@@ -1,10 +1,10 @@
- 
  .
- 
 
 .
-  
 .
-  "1.0" .
-  
"{DATE}"^^ .
-  
 .
-  
 .
+ 
  .
+ 
 
 .
+ 
 
 .
+ 
 "1.1" .
+  
"{DATE}"^^ .

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Updating fonts list and sorting it

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/403984 )

Change subject: Updating fonts list and sorting it
..


Updating fonts list and sorting it

This is to reflect the recently added Noto fonts (and whatever else
has been added since 2014).

Used fc-list :fontformat=TrueType  on a scaler to generate

Bug: T184664
Change-Id: I9259ec705115a8f4952337d6ccde56cfc99cb7e3
---
M fc-list
1 file changed, 216 insertions(+), 45 deletions(-)

Approvals:
  ArielGlenn: Looks good to me, but someone else must approve
  EBernhardson: Looks good to me, approved
  jenkins-bot: Verified
  Dzahn: Looks good to me, but someone else must approve



diff --git a/fc-list b/fc-list
index 186fd30..e0e9e40 100644
--- a/fc-list
+++ b/fc-list
@@ -6,9 +6,13 @@
 AlHor:style=Regular
 AlManzomah:style=Regular
 AlYarmook:style=Regular
+Amiri Quran:style=Regular,عادي
+Amiri:style=Bold Slanted,عريض مائل
+Amiri:style=Bold,عريض
+Amiri:style=Regular,عادي
+Amiri:style=Slanted,مائل
 Ani,অনি  Dvf:style=Regular
 AnjaliOldLipi:style=Regular
-Arab:style=Regular
 AR PL UKai CN:style=Book
 AR PL UKai HK:style=Book
 AR PL UKai TW MBE:style=Book
@@ -17,26 +21,82 @@
 AR PL UMing HK:style=Light
 AR PL UMing TW MBE:style=Light
 AR PL UMing TW:style=Light
+Arab:style=Regular
 Bandal,반달:style=Regular
 Bangwool,방울:style=Regular
+Caladea:style=Bold
+Caladea:style=Bold Italic,Italic
+Caladea:style=Italic
+Caladea:style=Regular
+Carlito:style=Bold
+Carlito:style=Bold Italic
+Carlito:style=Italic
+Carlito:style=Regular
 Chandas:style=Regular
 cmex10:style=Regular
 cmmi10:style=Regular
 cmr10:style=Regular
 cmsy10:style=Regular
+Comfortaa:style=Bold
+Comfortaa:style=Light
+Comfortaa:style=Regular
 Cortoba:style=Regular
 David CLM:style=Bold
 David CLM:style=BoldItalic
 David CLM:style=Medium
 David CLM:style=MediumItalic
 DejaVu Sans Mono:style=Bold
+DejaVu Sans Mono:style=Bold Oblique
 DejaVu Sans Mono:style=Book
+DejaVu Sans Mono:style=Oblique
+DejaVu Sans,DejaVu Sans Condensed:style=Condensed Bold Oblique,Bold Oblique
+DejaVu Sans,DejaVu Sans Condensed:style=Condensed Bold,Bold
+DejaVu Sans,DejaVu Sans Condensed:style=Condensed Oblique,Oblique
+DejaVu Sans,DejaVu Sans Condensed:style=Condensed,Book
+DejaVu Sans,DejaVu Sans Light:style=ExtraLight
 DejaVu Sans:style=Bold
+DejaVu Sans:style=Bold Oblique
 DejaVu Sans:style=Book
+DejaVu Sans:style=Oblique
+DejaVu Serif,DejaVu Serif Condensed:style=Condensed Bold Italic,Bold Italic
+DejaVu Serif,DejaVu Serif Condensed:style=Condensed Bold,Bold
+DejaVu Serif,DejaVu Serif Condensed:style=Condensed Italic,Italic
+DejaVu Serif,DejaVu Serif Condensed:style=Condensed,Book
 DejaVu Serif:style=Bold
+DejaVu Serif:style=Bold Italic
 DejaVu Serif:style=Book
+DejaVu Serif:style=Italic
 Dimnah:style=Regular
-Dyuthi:style=Regular,
+Droid Arabic Kufi:style=Bold
+Droid Arabic Kufi:style=Regular
+Droid Arabic Naskh:style=Bold
+Droid Arabic Naskh:style=Regular
+Droid Naskh Shift Alt:style=Regular
+Droid Sans Arabic:style=Regular
+Droid Sans Armenian:style=Regular
+Droid Sans Ethiopic:style=Bold
+Droid Sans Ethiopic:style=Regular
+Droid Sans Fallback:style=Regular
+Droid Sans Georgian:style=Regular
+Droid Sans Hebrew:style=Bold
+Droid Sans Hebrew:style=Regular
+Droid Sans Japanese:style=Regular
+Droid Sans Mono:style=Regular
+Droid Sans:style=Bold
+Droid Sans:style=Regular
+Droid Serif:style=Bold
+Droid Serif:style=Bold Italic
+Droid Serif:style=Italic
+Droid Serif:style=Regular
+Dyuthi:style=Regular,Book
+EB Garamond Initials Fill1:style=Regular
+EB Garamond Initials Fill2:style=Regular
+EB Garamond Initials:style=Regular
+EB Garamond,EB Garamond 08 SC:style=08 SC 
Regular,Normal,obyčejné,Standard,Κανονικά,SC,Normaali,Normál,Normale,Standaard,Normalny,Обычный,Normálne,Navadno,Arrunta
+EB Garamond,EB Garamond 08:style=08 
Italic,Cursiva,kurzíva,kursiv,Πλάγια,Italic,Kursivoitu,Italique,Dőlt,Corsivo,Cursief,Kursywa,Itálico,Курсив,İtalik,Poševno,Etzana
+EB Garamond,EB Garamond 08:style=08 
Regular,Normal,obyčejné,Standard,Κανονικά,Regular,Normaali,Normál,Normale,Standaard,Normalny,Обычный,Normálne,Navadno,Arrunta
+EB Garamond,EB Garamond 12:style=12 Italic,Italic
+EB Garamond,EB Garamond 12:style=12 Regular,Regular
 Electron:style=Regular
 esint10:style=regular
 eufm10:style=Regular
@@ -44,14 +104,44 @@
 Eunjin,은진:style=Regular
 Ezra SIL SR:style=Regular
 Ezra SIL:style=Regular
+FontAwesome:style=Regular
+FontAwesome:style=Regular
+Frank Ruehl CLM:style=Bold
+Frank Ruehl CLM:style=BoldOblique
+Frank Ruehl CLM:style=Medium
+Frank Ruehl CLM:style=MediumOblique
+FreeMono:style=Bold Oblique,получерен наклонен,Negreta cursiva,tučné 
kurzíva,fed kursiv,Fett-Kursiv,Έντονα Πλάγια,Negrita Cursiva,Lihavoitu 
Kursivoi,Gras Italique,Félkövér dőlt,Grassetto Corsivo,Vet Cursief,Halvfet 
Kursiv,Pogrubiona kursywa,Negrito Itálico,gros oblic,Полужирный Курсив,Tučná 
kurzíva,Fet Kursiv,Kalın İtalik,huruf tebal miring,жирний 

[MediaWiki-commits] [Gerrit] oojs/ui[master]: PanelLayout: Remove buggy `translateZ` performance hack

[VolkerE (Code Review)]

VolkerE has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404608 )

Change subject: PanelLayout: Remove buggy `translateZ` performance hack
..

PanelLayout: Remove buggy `translateZ` performance hack

Promoting to GPU as general approach introduced in
Ie8b99bf84dc71b4f6a50b441bf0a6f5a11050eff has lead to several
rendering glitches as side-effect.
Let's remove it and use it only on specific instances.

Bug: T158610
Bug: T185051
Change-Id: I87b2e027478e6c040deb31f248f4cdf90b671f7e
---
M src/styles/layouts/PanelLayout.less
M src/themes/apex/layouts.less
M src/themes/wikimediaui/layouts.less
3 files changed, 0 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/08/404608/1

diff --git a/src/styles/layouts/PanelLayout.less 
b/src/styles/layouts/PanelLayout.less
index 1a6d4e8..9dbf409 100644
--- a/src/styles/layouts/PanelLayout.less
+++ b/src/styles/layouts/PanelLayout.less
@@ -5,7 +5,6 @@
 
&-scrollable {
overflow: auto;
-   .oo-ui-force-gpu-composite-layer();
}
 
&-expanded {
diff --git a/src/themes/apex/layouts.less b/src/themes/apex/layouts.less
index 75ded09..032c6d4 100644
--- a/src/themes/apex/layouts.less
+++ b/src/themes/apex/layouts.less
@@ -190,14 +190,6 @@
&-padded&-framed {
margin: 1em 0;
}
-
-   // Support Safari (Webkit), see T176837:
-   // When promoted to GPU composite layer through
-   // `.oo-ui-force-gpu-composite-layer()` while not applying a 
`background-color`
-   // results in blurry text
-   &-scrollable {
-   background-color: @background-color-main;
-   }
 }
 
 .theme-oo-ui-tabPanelLayout () {}
diff --git a/src/themes/wikimediaui/layouts.less 
b/src/themes/wikimediaui/layouts.less
index c4a944d..c49adce 100644
--- a/src/themes/wikimediaui/layouts.less
+++ b/src/themes/wikimediaui/layouts.less
@@ -251,14 +251,6 @@
&-padded&-framed {
margin: 1em 0;
}
-
-   // Support Safari (Webkit), see T176837:
-   // When promoted to GPU composite layer through
-   // `.oo-ui-force-gpu-composite-layer()` while not applying a 
`background-color`
-   // results in blurry text
-   &-scrollable {
-   background-color: @background-color-base;
-   }
 }
 
 .theme-oo-ui-tabPanelLayout () {}

-- 
To view, visit https://gerrit.wikimedia.org/r/404608
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I87b2e027478e6c040deb31f248f4cdf90b671f7e
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[wmf/1.31.0-wmf.17]: Turn off cirrus AB test on hewiki

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404595 )

Change subject: Turn off cirrus AB test on hewiki
..


Turn off cirrus AB test on hewiki

Test has run it's course. Time to turn off and reset hewiki
sampling back to the old (default) rates.

Bug: T182616
Change-Id: I0b6d95af218379d47043c63a240ec5a7132d86ee
(cherry picked from commit b2495fcacf3ae7325f34f37705c2c108eb29e513)
---
M modules/all/ext.wikimediaEvents.searchSatisfaction.js
1 file changed, 1 insertion(+), 7 deletions(-)

Approvals:
  EBernhardson: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/all/ext.wikimediaEvents.searchSatisfaction.js 
b/modules/all/ext.wikimediaEvents.searchSatisfaction.js
index de78f11..b818261 100644
--- a/modules/all/ext.wikimediaEvents.searchSatisfaction.js
+++ b/modules/all/ext.wikimediaEvents.searchSatisfaction.js
@@ -114,9 +114,7 @@
function initialize( session ) {
 
var sessionId = session.get( 'sessionId' ),
-   validBuckets = mw.config.get( 'wgDBname' ) === 
'hewiki' ?
-   [ 'control', 'ltr-1024', 'ltr-1024-i' ] 
:
-   [],
+   validBuckets = [],
sampleSize = ( function () {
var dbName = mw.config.get( 'wgDBname' 
),
// Provides a place to handle 
wiki-specific sampling,
@@ -188,10 +186,6 @@
zhwiki: {
test: 100,
subTest: null
-   },
-   hewiki: {
-   test: 0.8112,
-   subTest: 0.8767
}
};
if ( subTests[ dbName ] ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/404595
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0b6d95af218379d47043c63a240ec5a7132d86ee
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: wmf/1.31.0-wmf.17
Gerrit-Owner: EBernhardson 
Gerrit-Reviewer: EBernhardson 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[wmf/1.31.0-wmf.16]: Turn off cirrus AB test on hewiki

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404594 )

Change subject: Turn off cirrus AB test on hewiki
..


Turn off cirrus AB test on hewiki

Test has run it's course. Time to turn off and reset hewiki
sampling back to the old (default) rates.

Bug: T182616
Change-Id: I0b6d95af218379d47043c63a240ec5a7132d86ee
(cherry picked from commit b2495fcacf3ae7325f34f37705c2c108eb29e513)
---
M modules/all/ext.wikimediaEvents.searchSatisfaction.js
1 file changed, 1 insertion(+), 7 deletions(-)

Approvals:
  EBernhardson: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/all/ext.wikimediaEvents.searchSatisfaction.js 
b/modules/all/ext.wikimediaEvents.searchSatisfaction.js
index de78f11..b818261 100644
--- a/modules/all/ext.wikimediaEvents.searchSatisfaction.js
+++ b/modules/all/ext.wikimediaEvents.searchSatisfaction.js
@@ -114,9 +114,7 @@
function initialize( session ) {
 
var sessionId = session.get( 'sessionId' ),
-   validBuckets = mw.config.get( 'wgDBname' ) === 
'hewiki' ?
-   [ 'control', 'ltr-1024', 'ltr-1024-i' ] 
:
-   [],
+   validBuckets = [],
sampleSize = ( function () {
var dbName = mw.config.get( 'wgDBname' 
),
// Provides a place to handle 
wiki-specific sampling,
@@ -188,10 +186,6 @@
zhwiki: {
test: 100,
subTest: null
-   },
-   hewiki: {
-   test: 0.8112,
-   subTest: 0.8767
}
};
if ( subTests[ dbName ] ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/404594
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0b6d95af218379d47043c63a240ec5a7132d86ee
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: wmf/1.31.0-wmf.16
Gerrit-Owner: EBernhardson 
Gerrit-Reviewer: EBernhardson 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: DHCP: switch to http to retrieve installer image

[Dzahn (Code Review)]

Dzahn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404607 )

Change subject: DHCP: switch to http to retrieve installer image
..

DHCP: switch to http to retrieve installer image

Bug: T182215
Change-Id: Ie3915ac8269c7da4be0644fbe3dbca3f0cad52ca
---
M modules/install_server/files/dhcpd/dhcpd.conf
M modules/install_server/files/dhcpd/linux-host-entries.ttyS0-115200
M modules/install_server/files/dhcpd/linux-host-entries.ttyS1-115200
3 files changed, 1,087 insertions(+), 1,087 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/07/404607/1


-- 
To view, visit https://gerrit.wikimedia.org/r/404607
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie3915ac8269c7da4be0644fbe3dbca3f0cad52ca
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...OdbcDatabase[master]: Don't use deprecated DatabaseMysql

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404543 )

Change subject: Don't use deprecated DatabaseMysql
..


Don't use deprecated DatabaseMysql

Bug: T120333
Change-Id: I6c2c37b6393848268f5f67a333c95819c149d337
---
M OdbcDatabase.body.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  MaxSem: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/OdbcDatabase.body.php b/OdbcDatabase.body.php
index 42da7c2..b8edf64 100644
--- a/OdbcDatabase.body.php
+++ b/OdbcDatabase.body.php
@@ -253,7 +253,7 @@
 * @param $fname string
 * @return false|array
 */
-   function indexInfo( $table, $index, $fname = 'DatabaseMysql::indexInfo' 
) {
+   function indexInfo( $table, $index, $fname = __METHOD__ ) {
/*
 * For now, always return false. Not sure how
 * to generically find this info using no

-- 
To view, visit https://gerrit.wikimedia.org/r/404543
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6c2c37b6393848268f5f67a333c95819c149d337
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/OdbcDatabase
Gerrit-Branch: master
Gerrit-Owner: Seb35 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Refactor MaintenanceTest to use a base test case

[Awight (Code Review)]

Awight has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404606 )

Change subject: Refactor MaintenanceTest to use a base test case
..

Refactor MaintenanceTest to use a base test case

Bug: T184775
Change-Id: I0cb2320f765e847a59c721918401da07a3a2b24a
---
M tests/common/TestsAutoLoader.php
A tests/phpunit/maintenance/MaintenanceBaseTestCase.php
D tests/phpunit/maintenance/MaintenanceFixup.php
M tests/phpunit/maintenance/MaintenanceTest.php
4 files changed, 386 insertions(+), 684 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/06/404606/1

diff --git a/tests/common/TestsAutoLoader.php b/tests/common/TestsAutoLoader.php
index 825cee0..48f6267 100644
--- a/tests/common/TestsAutoLoader.php
+++ b/tests/common/TestsAutoLoader.php
@@ -151,6 +151,7 @@
 
# tests/phpunit/maintenance
'MediaWiki\Tests\Maintenance\DumpTestCase' => 
"$testDir/phpunit/maintenance/DumpTestCase.php",
+   'MediaWiki\Tests\Maintenance\MaintenanceBaseTestCase' => 
"$testDir/phpunit/maintenance/MaintenanceBaseTestCase.php",
'MediaWiki\Tests\Maintenance\MaintenanceFixup' => 
"$testDir/phpunit/maintenance/MaintenanceFixup.php",
 
# tests/phpunit/media
diff --git a/tests/phpunit/maintenance/MaintenanceBaseTestCase.php 
b/tests/phpunit/maintenance/MaintenanceBaseTestCase.php
new file mode 100644
index 000..9474441
--- /dev/null
+++ b/tests/phpunit/maintenance/MaintenanceBaseTestCase.php
@@ -0,0 +1,50 @@
+maintenance ) {
+   $this->maintenance->outputChanneled( false );
+   }
+   parent::tearDown();
+   }
+
+   /**
+* Asserts the output before and after simulating shutdown
+*
+* This function simulates shutdown of self::maintenance.
+*
+* @param string $preShutdownOutput Expected output before simulating 
shutdown
+* @param bool $expectNLAppending Whether or not shutdown simulation is 
expected
+*   to add a newline to the output. If false, $preShutdownOutput is the
+*   expected output after shutdown simulation. Otherwise,
+*   $preShutdownOutput with an appended newline is the expected output
+*   after shutdown simulation.
+*/
+   protected function assertOutputPrePostShutdown( $preShutdownOutput, 
$expectNLAppending ) {
+   $this->assertEquals( $preShutdownOutput, 
$this->getActualOutput(),
+   "Output before shutdown simulation" );
+
+   $this->maintenance->outputChanneled( false );
+
+   $postShutdownOutput = $preShutdownOutput . ( $expectNLAppending 
? "\n" : "" );
+   $this->expectOutputString( $postShutdownOutput );
+   }
+
+}
+
diff --git a/tests/phpunit/maintenance/MaintenanceFixup.php 
b/tests/phpunit/maintenance/MaintenanceFixup.php
deleted file mode 100644
index 40da42d..000
--- a/tests/phpunit/maintenance/MaintenanceFixup.php
+++ /dev/null
@@ -1,142 +0,0 @@
-shutdownSimulated ) {
-   $this->testCase->fail( __METHOD__ . " called more than 
once" );
-   }
-
-   // The cleanup action.
-   $this->outputChanneled( false );
-
-   // Bookkeeping that we simulated the clean up.
-   $this->shutdownSimulated = true;
-   }
-
-   // Note that the "public" here does not change visibility
-   public function outputChanneled( $msg, $channel = null ) {
-   if ( $this->shutdownSimulated ) {
-   if ( $msg !== false ) {
-   $this->testCase->fail( "Already past simulated 
shutdown, but msg is "
-   . "not false. Did the hack in 
Maintenance.php change? Please "
-   . "adapt the test case or 
Maintenance.php" );
-   }
-
-   // The current call is the one registered via 
register_shutdown_function.
-   // We can safely ignore it, as we simulated this one 
via simulateShutdown
-   // before (if we did not, the destructor of this 
instance will warn about
-   // it)
-   return;
-   }
-
-   call_user_func_array( [ "parent", __FUNCTION__ ], 
func_get_args() );
-   }
-
-   /**
-* Safety net around register_shutdown_function of Maintenance.php
-*/
-   public function __destruct() {
-   if ( !$this->shutdownSimulated ) {
-   // Someone generated a MaintenanceFixup instance 
without calling
-   // simulateShutdown. We'd have to raise a PHPUnit 
exception to correctly
-   // flag this illegal usage. However, we are already in 
a destruktor, which
-   // would trigger undefined behavior. Hence, 

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Revert accidentally removed trait

[Awight (Code Review)]

Awight has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404605 )

Change subject: Revert accidentally removed trait
..

Revert accidentally removed trait

Change-Id: I82283be89f3f155d7793d4c900927d81a60d5e95
---
M tests/phpunit/maintenance/BenchmarkerTest.php
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/05/404605/1

diff --git a/tests/phpunit/maintenance/BenchmarkerTest.php 
b/tests/phpunit/maintenance/BenchmarkerTest.php
index 83e39cb..765884c 100644
--- a/tests/phpunit/maintenance/BenchmarkerTest.php
+++ b/tests/phpunit/maintenance/BenchmarkerTest.php
@@ -11,6 +11,8 @@
  */
 class BenchmarkerTest extends PHPUnit_Framework_TestCase {
 
+   use MediaWikiCoversValidator;
+
public function testBenchSimple() {
$bench = $this->getMockBuilder( Benchmarker::class )
->setMethods( [ 'execute', 'output' ] )

-- 
To view, visit https://gerrit.wikimedia.org/r/404605
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I82283be89f3f155d7793d4c900927d81a60d5e95
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Awight 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Add my new key

[MaxSem (Code Review)]

MaxSem has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404604 )

Change subject: Add my new key
..

Add my new key

I'm back from travels.
I've confirmed my identity in person with Arzhel.

Change-Id: I59d5e333e82373e95998e146aeabf604eb9c807a
---
M modules/admin/data/data.yaml
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/04/404604/1

diff --git a/modules/admin/data/data.yaml b/modules/admin/data/data.yaml
index 3b2d77e..a30c3b9 100644
--- a/modules/admin/data/data.yaml
+++ b/modules/admin/data/data.yaml
@@ -1023,7 +1023,7 @@
 gid: 500
 name: maxsem
 realname: Max Semenik
-ssh_keys: []
+ssh_keys: [ssh-rsa 
B3NzaC1yc2EDAQABAAABAQDfuBTpiiDX2o68s2Lyc2LDT1r39IN3V4bzPVsdZEcJKcti9chfO2BK1xUGZ+KWbUSvQn8TtT0MDTTDDlXEK/oc+MlNn5o+K/xY6lUkyQuWLHZi8GaOuLaqude9myv+u+RGvuvTvre2bVNwAZ94XpSa5gN9BUdrZHeeLGw1NxE9g+675mRxg/2nBM7sPYr7S9MFTxNuW9HUfyXoGx0NZrsTR7gLz0H4ET6HYgLMXVVKIaNLyKkfDdJ/ywmd61LGdp+jUjWjPeClrhutyk/3z//fauC/S1OtyD1IP29Eg3wJbxWaWRnanAq5EueEopz2lOProwOVPnwTYNLk2GRa/xiV
 mseme...@maxsem.corp.wikimedia.org]
 uid: 1220
 email: mseme...@wikimedia.org
   mattflaschen:

-- 
To view, visit https://gerrit.wikimedia.org/r/404604
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I59d5e333e82373e95998e146aeabf604eb9c807a
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: MaxSem 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: make-wmf-branch: Stop committing weird sub-submodule branching

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404600 )

Change subject: make-wmf-branch: Stop committing weird sub-submodule branching
..


make-wmf-branch: Stop committing weird sub-submodule branching

It's ok to keep creating these branches, but the logic for adding
them as auto-tracked submodules is fragile and has broken several
times over the years.

The drawback? SWAT deploys for the sub-submodules require manual
backports. This sucks, but it sucks less than the tech debt and
isn't any worse than how we used to do things before auto-updating
submodules were used.

Change-Id: I00301d8ea2d003b8d0668a8db998d3d1df34e195
---
M make-wmf-branch/MakeWmfBranch.php
1 file changed, 3 insertions(+), 15 deletions(-)

Approvals:
  20after4: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/make-wmf-branch/MakeWmfBranch.php 
b/make-wmf-branch/MakeWmfBranch.php
index b2a1ead..98363fd 100644
--- a/make-wmf-branch/MakeWmfBranch.php
+++ b/make-wmf-branch/MakeWmfBranch.php
@@ -148,12 +148,9 @@
}
}
 
-   function createBranch( $branchName, $doPush=true ) {
+   function createBranch( $branchName ) {
$this->runCmd( 'git', 'checkout', '-q', '-b', $branchName );
-
-   if ( $doPush == true ) {
-   $this->runWriteCmd( 'git', 'push', 'origin', 
$branchName );
-   }
+   $this->runWriteCmd( 'git', 'push', 'origin', $branchName );
}
 
function branchRepo( $path ) {
@@ -169,7 +166,6 @@
$newVersion = $this->branchPrefix . $this->newVersion;
 
if ( isset( $this->branchedSubmodules[$path] ) ) {
-   $this->createBranch( $newVersion, false );
foreach ( (array)$this->branchedSubmodules[$path] as 
$submodule ) {
$this->runCmd( 'git', 'submodule', 'update', 
'--init', $submodule );
$this->chdir( $submodule );
@@ -179,17 +175,9 @@
// may be inside a subdirectory
$this->chdir( $this->buildDir );
$this->chdir( $repo );
-   $this->runCmd( 'git', 'add', $submodule );
}
-   $diffRet = 0;
-   passthru( '/usr/bin/git diff --cached --no-ext-diff 
--quiet', $diffRet );
-   if ( $diffRet > 0 ) {
-   $this->runCmd( 'git', 'commit', '-q', '-m', 
"Creating new {$newVersion} branch" );
-   }
-   $this->runWriteCmd( 'git', 'push', 'origin', 
$newVersion );
-   } else {
-   $this->createBranch( $newVersion, true );
}
+   $this->createBranch( $newVersion );
$this->chdir( $this->buildDir );
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/404600
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I00301d8ea2d003b8d0668a8db998d3d1df34e195
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/release
Gerrit-Branch: master
Gerrit-Owner: Chad 
Gerrit-Reviewer: 20after4 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Summaries should not contain coordinates

[Jdlrobson (Code Review)]

Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404603 )

Change subject: Summaries should not contain coordinates
..

Summaries should not contain coordinates

Bug: T185050
Change-Id: Idcb882eeabad8c63c18cf0e94a25ca799899445d
---
M lib/summary.js
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps 
refs/changes/03/404603/1

diff --git a/lib/summary.js b/lib/summary.js
index 62c57ce..6b6480c 100644
--- a/lib/summary.js
+++ b/lib/summary.js
@@ -91,6 +91,8 @@
 if (isMainPage) {
 return EMPTY_EXTRACTS;
 } else {
+// The summary should not present any html from removed elements e.g. 
geo tag
+transforms.stripUnneededMarkup(doc)
 const leadSectionDoc = parsoidSections.justLeadSection(doc);
 const intro = transforms.extractLeadIntroduction(leadSectionDoc);
 if (intro.length) {

-- 
To view, visit https://gerrit.wikimedia.org/r/404603
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idcb882eeabad8c63c18cf0e94a25ca799899445d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Make MWHttpRequest more testable by allowing factory override

[Smalyshev (Code Review)]

Smalyshev has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404602 )

Change subject: Make MWHttpRequest more testable by allowing factory override
..

Make MWHttpRequest more testable by allowing factory override

This patch allows overriding the return of MWHttpRequest::factory
via $options['httpRequestImplementation'], thus allowing tests
to substitute a mock HTTP class there and make classes relying on
MWHttpRequest more testable.

The mock must extend MWHttpRequest class.

Also made MWHttpRequest abstract class since it doesn't implement
execute anyway. Maybe a good idea to move execute to an abstract
method?

Change-Id: I5c0e035542ff5f791a21a95ed13bed4cea6906d0
---
M includes/http/MWHttpRequest.php
1 file changed, 11 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/02/404602/1

diff --git a/includes/http/MWHttpRequest.php b/includes/http/MWHttpRequest.php
index 0f0118c..6189c93f 100644
--- a/includes/http/MWHttpRequest.php
+++ b/includes/http/MWHttpRequest.php
@@ -30,7 +30,7 @@
  * Renamed from HttpRequest to MWHttpRequest to avoid conflict with
  * PHP's HTTP extension.
  */
-class MWHttpRequest implements LoggerAwareInterface {
+abstract class MWHttpRequest implements LoggerAwareInterface {
const SUPPORTS_FILE_POSTS = false;
 
/**
@@ -178,7 +178,7 @@
 * @param array $options (optional) extra params to pass (see 
Http::request())
 * @param string $caller The method making this request, for profiling
 * @throws DomainException
-* @return CurlHttpRequest|PhpHttpRequest
+* @return MWHttpRequest
 * @see MWHttpRequest::__construct
 */
public static function factory( $url, $options = null, $caller = 
__METHOD__ ) {
@@ -197,6 +197,15 @@
$options['logger'] = LoggerFactory::getInstance( 'http' 
);
}
 
+   if ( !empty( $options['httpRequestImplementation'] ) ) {
+   if ( $options['httpRequestImplementation'] instanceof 
MWHttpRequest ) {
+   return $options['httpRequestImplementation'];
+   } else {
+   throw new DomainException( __METHOD__ .
+  ': 
$options[\'httpRequestImplementation\'] should be an instace of MWHttpRequest' 
);
+   }
+   }
+
switch ( Http::$httpEngine ) {
case 'curl':
return new CurlHttpRequest( $url, $options, 
$caller, Profiler::instance() );

-- 
To view, visit https://gerrit.wikimedia.org/r/404602
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5c0e035542ff5f791a21a95ed13bed4cea6906d0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Smalyshev 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: Rename prefixes of unique IDs to not mention "OOjs"

[Code Review]

Bartosz Dziewoński has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404601 )

Change subject: Rename prefixes of unique IDs to not mention "OOjs"
..

Rename prefixes of unique IDs to not mention "OOjs"

Following up the recent changes to unify the name of the library
to "OOUI".

Note that the prefixes in OOUI\Tag::generateElementId() and
OO.ui.generateElementId() must be different to avoid conflicts.

Change-Id: I0866d984aadf1fac24b790ccb2e26818eb5ad539
---
M php/Tag.php
M src/core.js
M tests/QUnit.assert.equalDomElement.js
3 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/01/404601/1

diff --git a/php/Tag.php b/php/Tag.php
index e35fcd2..9f39861 100644
--- a/php/Tag.php
+++ b/php/Tag.php
@@ -279,7 +279,7 @@
 */
public static function generateElementId() {
self::$elementId++;
-   return 'ooui-' . self::$elementId;
+   return 'ooui-php-' . self::$elementId;
}
 
/**
diff --git a/src/core.js b/src/core.js
index ba9081d..c4afac5 100644
--- a/src/core.js
+++ b/src/core.js
@@ -54,7 +54,7 @@
  */
 OO.ui.generateElementId = function () {
OO.ui.elementId++;
-   return 'oojsui-' + OO.ui.elementId;
+   return 'ooui-' + OO.ui.elementId;
 };
 
 /**
diff --git a/tests/QUnit.assert.equalDomElement.js 
b/tests/QUnit.assert.equalDomElement.js
index d8d6ccb..afacb1a 100644
--- a/tests/QUnit.assert.equalDomElement.js
+++ b/tests/QUnit.assert.equalDomElement.js
@@ -119,7 +119,7 @@
attribute = autogeneratedAttributes[ i ];
if (
summary.attributes[ attribute ] !== undefined &&
-   summary.attributes[ attribute ].match( 
/^(ooui-|oojsui-)/ )
+   summary.attributes[ attribute ].match( 
/^(ooui-php-|ooui-)/ )
) {
summary.attributes[ attribute ] = 
'(autogenerated)';
}

-- 
To view, visit https://gerrit.wikimedia.org/r/404601
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0866d984aadf1fac24b790ccb2e26818eb5ad539
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: make-wmf-branch: Stop committing weird sub-submodule branching

[Chad (Code Review)]

Chad has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404600 )

Change subject: make-wmf-branch: Stop committing weird sub-submodule branching
..

make-wmf-branch: Stop committing weird sub-submodule branching

It's ok to keep creating these branches, but the logic for adding
them as auto-tracked submodules is fragile and has broken several
times over the years.

The drawback? SWAT deploys for the sub-submodules require manual
backports. This sucks, but it sucks less than the tech debt and
isn't any worse than how we used to do things before auto-updating
submodules were used.

Change-Id: I00301d8ea2d003b8d0668a8db998d3d1df34e195
---
M make-wmf-branch/MakeWmfBranch.php
1 file changed, 3 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/tools/release 
refs/changes/00/404600/1

diff --git a/make-wmf-branch/MakeWmfBranch.php 
b/make-wmf-branch/MakeWmfBranch.php
index b2a1ead..98363fd 100644
--- a/make-wmf-branch/MakeWmfBranch.php
+++ b/make-wmf-branch/MakeWmfBranch.php
@@ -148,12 +148,9 @@
}
}
 
-   function createBranch( $branchName, $doPush=true ) {
+   function createBranch( $branchName ) {
$this->runCmd( 'git', 'checkout', '-q', '-b', $branchName );
-
-   if ( $doPush == true ) {
-   $this->runWriteCmd( 'git', 'push', 'origin', 
$branchName );
-   }
+   $this->runWriteCmd( 'git', 'push', 'origin', $branchName );
}
 
function branchRepo( $path ) {
@@ -169,7 +166,6 @@
$newVersion = $this->branchPrefix . $this->newVersion;
 
if ( isset( $this->branchedSubmodules[$path] ) ) {
-   $this->createBranch( $newVersion, false );
foreach ( (array)$this->branchedSubmodules[$path] as 
$submodule ) {
$this->runCmd( 'git', 'submodule', 'update', 
'--init', $submodule );
$this->chdir( $submodule );
@@ -179,17 +175,9 @@
// may be inside a subdirectory
$this->chdir( $this->buildDir );
$this->chdir( $repo );
-   $this->runCmd( 'git', 'add', $submodule );
}
-   $diffRet = 0;
-   passthru( '/usr/bin/git diff --cached --no-ext-diff 
--quiet', $diffRet );
-   if ( $diffRet > 0 ) {
-   $this->runCmd( 'git', 'commit', '-q', '-m', 
"Creating new {$newVersion} branch" );
-   }
-   $this->runWriteCmd( 'git', 'push', 'origin', 
$newVersion );
-   } else {
-   $this->createBranch( $newVersion, true );
}
+   $this->createBranch( $newVersion );
$this->chdir( $this->buildDir );
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/404600
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I00301d8ea2d003b8d0668a8db998d3d1df34e195
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/release
Gerrit-Branch: master
Gerrit-Owner: Chad 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...PageForms[master]: Added option for "create/edit title"

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404599 )

Change subject: Added  option for "create/edit title"
..


Added  option for "create/edit title"

Change-Id: I62c91907f8862faaa2b0da1e367e209c0e4e1a92
---
M includes/PF_AutoeditAPI.php
M specials/PF_FormEdit.php
2 files changed, 7 insertions(+), 7 deletions(-)

Approvals:
  Yaron Koren: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/PF_AutoeditAPI.php b/includes/PF_AutoeditAPI.php
index 09ec5ec..a403101 100644
--- a/includes/PF_AutoeditAPI.php
+++ b/includes/PF_AutoeditAPI.php
@@ -912,8 +912,7 @@
$wgRequest = $oldRequest;
 
if ( $generatedFormName !== '' ) {
-   $formTitle = Title::newFromText( $generatedFormName );
-   $this->mOptions['formtitle'] = $formTitle->getText();
+   $this->mOptions['formtitle'] = $generatedFormName;
}
 
$this->mOptions['formHTML'] = $formHTML;
diff --git a/specials/PF_FormEdit.php b/specials/PF_FormEdit.php
index 7b29736..44858f7 100644
--- a/specials/PF_FormEdit.php
+++ b/specials/PF_FormEdit.php
@@ -126,17 +126,18 @@
$targetTitle = Title::newFromText( $result[ 'target' ] );
 
// Set page title depending on whether an explicit title was
-   // specified in the form definition.
+   // specified in the form definition, and whether this is a
+   // new or existing page being edited.
if ( array_key_exists( 'formtitle', $result ) ) {
-   // set page title depending on whether the target page 
exists
+   $pageTitle = $result[ 'formtitle' ];
if ( empty( $targetName ) ) {
-   $pageTitle = $result[ 'formtitle' ];
+   // This is a new page - we're done.
+   } elseif ( strpos( $pageTitle, 'page name' ) 
!== false ) {
+   $pageTitle = str_replace( 'page name', 
$targetName, $pageTitle );
} else {
$pageTitle = $result[ 'formtitle' ] . ': ' . 
$targetName;
}
} elseif ( $result[ 'form' ] !== '' ) {
-   // Set page title depending on whether the target page
-   // exists.
if ( empty( $targetName ) ) {
$pageTitle = wfMessage( 
'pf_formedit_createtitlenotarget', $result[ 'form' ] )->text();
} elseif ( $targetTitle->exists() ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/404599
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I62c91907f8862faaa2b0da1e367e209c0e4e1a92
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/PageForms
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren 
Gerrit-Reviewer: Yaron Koren 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...PageForms[master]: Added option for "create/edit title"

[Yaron Koren (Code Review)]

Yaron Koren has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404599 )

Change subject: Added  option for "create/edit title"
..

Added  option for "create/edit title"

Change-Id: I62c91907f8862faaa2b0da1e367e209c0e4e1a92
---
M includes/PF_AutoeditAPI.php
M specials/PF_FormEdit.php
2 files changed, 7 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PageForms 
refs/changes/99/404599/2

diff --git a/includes/PF_AutoeditAPI.php b/includes/PF_AutoeditAPI.php
index 09ec5ec..a403101 100644
--- a/includes/PF_AutoeditAPI.php
+++ b/includes/PF_AutoeditAPI.php
@@ -912,8 +912,7 @@
$wgRequest = $oldRequest;
 
if ( $generatedFormName !== '' ) {
-   $formTitle = Title::newFromText( $generatedFormName );
-   $this->mOptions['formtitle'] = $formTitle->getText();
+   $this->mOptions['formtitle'] = $generatedFormName;
}
 
$this->mOptions['formHTML'] = $formHTML;
diff --git a/specials/PF_FormEdit.php b/specials/PF_FormEdit.php
index 7b29736..44858f7 100644
--- a/specials/PF_FormEdit.php
+++ b/specials/PF_FormEdit.php
@@ -126,17 +126,18 @@
$targetTitle = Title::newFromText( $result[ 'target' ] );
 
// Set page title depending on whether an explicit title was
-   // specified in the form definition.
+   // specified in the form definition, and whether this is a
+   // new or existing page being edited.
if ( array_key_exists( 'formtitle', $result ) ) {
-   // set page title depending on whether the target page 
exists
+   $pageTitle = $result[ 'formtitle' ];
if ( empty( $targetName ) ) {
-   $pageTitle = $result[ 'formtitle' ];
+   // This is a new page - we're done.
+   } elseif ( strpos( $pageTitle, 'page name' ) 
!== false ) {
+   $pageTitle = str_replace( 'page name', 
$targetName, $pageTitle );
} else {
$pageTitle = $result[ 'formtitle' ] . ': ' . 
$targetName;
}
} elseif ( $result[ 'form' ] !== '' ) {
-   // Set page title depending on whether the target page
-   // exists.
if ( empty( $targetName ) ) {
$pageTitle = wfMessage( 
'pf_formedit_createtitlenotarget', $result[ 'form' ] )->text();
} elseif ( $targetTitle->exists() ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/404599
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I62c91907f8862faaa2b0da1e367e209c0e4e1a92
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/PageForms
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: OOUI: Manually pull in fix from I99caad7b ahead of the relea...

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404597 )

Change subject: OOUI: Manually pull in fix from I99caad7b ahead of the release 
cycle
..


OOUI: Manually pull in fix from I99caad7b ahead of the release cycle

The .map file will be wrong, but those aren't used, so oh well.

Change-Id: Ic9a6a20541b2f5f1268dd1cf48f767877d2781d4
---
M lib/oojs-ui/oojs-ui-toolbars.js
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Divec: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/lib/oojs-ui/oojs-ui-toolbars.js b/lib/oojs-ui/oojs-ui-toolbars.js
index 59d6474..1b57f09 100644
--- a/lib/oojs-ui/oojs-ui-toolbars.js
+++ b/lib/oojs-ui/oojs-ui-toolbars.js
@@ -1978,7 +1978,7 @@
this.$element.addClass( 'oo-ui-popupToolGroup-active 
oo-ui-popupToolGroup-left' );
this.setFlags( { progressive: true } );
this.toggleClipping( true );
-   if ( this.isClippedHorizontally() || 
this.isFloatableOutOfView() ) {
+   if ( this.isClippedHorizontally() ) {
// Anchoring to the left caused the popup to 
clip, so anchor it to the right instead
this.toggleClipping( false );
this.$element
@@ -1986,7 +1986,7 @@
.addClass( 'oo-ui-popupToolGroup-right' 
);
this.toggleClipping( true );
}
-   if ( this.isClippedHorizontally() || 
this.isFloatableOutOfView() ) {
+   if ( this.isClippedHorizontally() ) {
// Anchoring to the right also caused the popup 
to clip, so just make it fill the container
containerWidth = 
this.$clippableScrollableContainer.width();
containerLeft = 
this.$clippableScrollableContainer[ 0 ] === document.documentElement ?

-- 
To view, visit https://gerrit.wikimedia.org/r/404597
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9a6a20541b2f5f1268dd1cf48f767877d2781d4
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Divec 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: [JobQueue] Enable htmlCacheUpdate on new infrastructure for ...

[Ppchelko (Code Review)]

Ppchelko has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404598 )

Change subject: [JobQueue] Enable htmlCacheUpdate on new infrastructure for all 
projects.
..

[JobQueue] Enable htmlCacheUpdate on new infrastructure for all projects.

Previously htmlCacheUpdate job was running on the new infrastructure
for all projects except enwiki, commons and wikidats. This change
switches processing of all the jobs to the new infrastructure.

Bug: T182023
Depends-On: Ibbe8c11b4177f9671c6cd4e0681e9851c8b999e5
Change-Id: I8072c59453c69e959d1b07a1809d72b853012985
---
M wmf-config/InitialiseSettings.php
M wmf-config/jobqueue.php
2 files changed, 5 insertions(+), 21 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/98/404598/1

diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index 9767eb5..649fa0e 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -19655,20 +19655,6 @@
'votewiki' => false,
 ],
 
-// Temporary code for gradually integrating htmlCacheUpdate
-// jobs into the EventBus JobQueue - T182023
-// Step 2: enable everywhere but wikidata, enwiki and commons
-'wmgDisableHTMLCacheUpdateInRedis' => [
-   'default' => true,
-   'wikitech' => false,
-   'private' => false,
-   'loginwiki' => false,
-   'votewiki' => false,
-   'commonswiki' => false,
-   'enwiki' => false,
-   'wikidatawiki' => false,
-],
-
 'wmgUseCapiunto' => [
'default' => false,
'testwiki' => true,
diff --git a/wmf-config/jobqueue.php b/wmf-config/jobqueue.php
index a685ac9..29d6683 100644
--- a/wmf-config/jobqueue.php
+++ b/wmf-config/jobqueue.php
@@ -42,16 +42,14 @@
 ];
 
 if ( $wmgUseEventBus && $wmgDebugJobQueueEventBus ) {
-   $wgJobTypeConf['MessageIndexRebuildJob'] =
+   $wgJobTypeConf['deleteLinks'] =
$wgJobTypeConf['flaggedrevs_CacheUpdate'] =
-   $wgJobTypeConf['deleteLinks'] =
-   $wgJobTypeConf['updateBetaFeaturesUserCounts'] =
+   $wgJobTypeConf['htmlCacheUpdate'] =
+   $wgJobTypeConf['MessageIndexRebuildJob'] =
$wgJobTypeConf['RecordLintJob'] =
-   $wgJobTypeConf['wikibase-addUsagesForPage'] =
+   $wgJobTypeConf['updateBetaFeaturesUserCounts'] =
+   $wgJobTypeConf['wikibase-addUsagesForPage'] =
[ 'class' => 'JobQueueEventBus' ];
-   if ( $wmgDisableHTMLCacheUpdateInRedis ) {
-   $wgJobTypeConf['htmlCacheUpdate'] = [ 'class' => 
'JobQueueEventBus' ];
-   }
$wgJobTypeConf['default'] = [
'class' => 'JobQueueSecondTestQueue',
'mainqueue' => $jobQueueFederatedConfig,

-- 
To view, visit https://gerrit.wikimedia.org/r/404598
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8072c59453c69e959d1b07a1809d72b853012985
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Ppchelko 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: OOUI: Manually pull in fix from I99caad7b ahead of the relea...

[Jforrester (Code Review)]

Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404597 )

Change subject: OOUI: Manually pull in fix from I99caad7b ahead of the release 
cycle
..

OOUI: Manually pull in fix from I99caad7b ahead of the release cycle

The .map file will be wrong, but those aren't used, so oh well.

Change-Id: Ic9a6a20541b2f5f1268dd1cf48f767877d2781d4
---
M lib/oojs-ui/oojs-ui-toolbars.js
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/97/404597/1

diff --git a/lib/oojs-ui/oojs-ui-toolbars.js b/lib/oojs-ui/oojs-ui-toolbars.js
index 59d6474..1b57f09 100644
--- a/lib/oojs-ui/oojs-ui-toolbars.js
+++ b/lib/oojs-ui/oojs-ui-toolbars.js
@@ -1978,7 +1978,7 @@
this.$element.addClass( 'oo-ui-popupToolGroup-active 
oo-ui-popupToolGroup-left' );
this.setFlags( { progressive: true } );
this.toggleClipping( true );
-   if ( this.isClippedHorizontally() || 
this.isFloatableOutOfView() ) {
+   if ( this.isClippedHorizontally() ) {
// Anchoring to the left caused the popup to 
clip, so anchor it to the right instead
this.toggleClipping( false );
this.$element
@@ -1986,7 +1986,7 @@
.addClass( 'oo-ui-popupToolGroup-right' 
);
this.toggleClipping( true );
}
-   if ( this.isClippedHorizontally() || 
this.isFloatableOutOfView() ) {
+   if ( this.isClippedHorizontally() ) {
// Anchoring to the right also caused the popup 
to clip, so just make it fill the container
containerWidth = 
this.$clippableScrollableContainer.width();
containerLeft = 
this.$clippableScrollableContainer[ 0 ] === document.documentElement ?

-- 
To view, visit https://gerrit.wikimedia.org/r/404597
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic9a6a20541b2f5f1268dd1cf48f767877d2781d4
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Don't use deprecated DatabaseMysql

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404541 )

Change subject: Don't use deprecated DatabaseMysql
..


Don't use deprecated DatabaseMysql

Bug: T120333
Change-Id: Ib24561d815d28ea5887a7bd5c598340e961b2f5b
---
M tests/phpunit/Data/Storage/RevisionStorageTest.php
M tests/phpunit/Repository/TreeRepositoryTest.php
M tests/phpunit/WatchedTopicItemsTest.php
3 files changed, 6 insertions(+), 6 deletions(-)

Approvals:
  MaxSem: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/tests/phpunit/Data/Storage/RevisionStorageTest.php 
b/tests/phpunit/Data/Storage/RevisionStorageTest.php
index 59c95e8..7687f7f 100644
--- a/tests/phpunit/Data/Storage/RevisionStorageTest.php
+++ b/tests/phpunit/Data/Storage/RevisionStorageTest.php
@@ -156,7 +156,7 @@
 
// A rev ID will be added to $old and $new automatically.
protected function helperToTestUpdating( $old, $new, 
$expectedUpdateValues, $isContentUpdatingAllowed ) {
-   $dbw = $this->getMockBuilder( 'DatabaseMysql' )
+   $dbw = $this->getMockBuilder( 'DatabaseMysqli' )
->disableOriginalConstructor()
->getMock();
$factory = $this->getMockBuilder( 'Flow\DbFactory' )
@@ -389,7 +389,7 @@
}
 
protected function mockDbFactory() {
-   $dbw = $this->getMockBuilder( 'DatabaseMysql' )
+   $dbw = $this->getMockBuilder( 'DatabaseMysqli' )
->disableOriginalConstructor()
->getMock();
 
diff --git a/tests/phpunit/Repository/TreeRepositoryTest.php 
b/tests/phpunit/Repository/TreeRepositoryTest.php
index a4792bf..17771ea 100644
--- a/tests/phpunit/Repository/TreeRepositoryTest.php
+++ b/tests/phpunit/Repository/TreeRepositoryTest.php
@@ -5,7 +5,7 @@
 use Flow\Model\UUID;
 use Flow\Repository\TreeRepository;
 use Flow\Tests\FlowTestCase;
-use Wikimedia\Rdbms\DatabaseMysql;
+use Wikimedia\Rdbms\DatabaseMysqli;
 
 /**
  * @group Flow
@@ -46,7 +46,7 @@
}
 
protected function mockDb( $dbResult ) {
-   $db = $this->getMockBuilder( DatabaseMysql::class )
+   $db = $this->getMockBuilder( DatabaseMysqli::class )
->disableOriginalConstructor()
->getMock();
$db->expects( $this->any() )
diff --git a/tests/phpunit/WatchedTopicItemsTest.php 
b/tests/phpunit/WatchedTopicItemsTest.php
index e55c496..1453fc2 100644
--- a/tests/phpunit/WatchedTopicItemsTest.php
+++ b/tests/phpunit/WatchedTopicItemsTest.php
@@ -5,7 +5,7 @@
 use Flow\Model\UUID;
 use Flow\WatchedTopicItems;
 use User;
-use Wikimedia\Rdbms\DatabaseMysql;
+use Wikimedia\Rdbms\DatabaseMysqli;
 
 /**
  * @group Flow
@@ -72,7 +72,7 @@
}
 
protected function mockDb( $dbResult ) {
-   $db = $this->getMockBuilder( DatabaseMysql::class )
+   $db = $this->getMockBuilder( DatabaseMysqli::class )
->disableOriginalConstructor()
->getMock();
$db->expects( $this->any() )

-- 
To view, visit https://gerrit.wikimedia.org/r/404541
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib24561d815d28ea5887a7bd5c598340e961b2f5b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Seb35 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...jobqueue-deploy[master]: [Config] Enable htmlCacheUpdate job processing for all wikis

[Ppchelko (Code Review)]

Ppchelko has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404596 )

Change subject: [Config] Enable htmlCacheUpdate job processing for all wikis
..

[Config] Enable htmlCacheUpdate job processing for all wikis

Previously htmlCacheUpdate job was running on the new infrastructure
for all projects except enwiki, commons and wikidats. This change
switches processing of all the jobs to the new infrastructure.

Bug: T182023
Change-Id: Ibbe8c11b4177f9671c6cd4e0681e9851c8b999e5
---
M scap/templates/config.yaml.j2
M scap/vars.yaml
2 files changed, 6 insertions(+), 18 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/services/change-propagation/jobqueue-deploy
 refs/changes/96/404596/1

diff --git a/scap/templates/config.yaml.j2 b/scap/templates/config.yaml.j2
index cf20ab3..5bd73bc 100644
--- a/scap/templates/config.yaml.j2
+++ b/scap/templates/config.yaml.j2
@@ -49,22 +49,6 @@
   agentOptions:
 keepAlive: true
 <%- endfor %>
-# Temporary section - we are only enabling the htmlCacheUpdate for all but 
enwiki, commons and wikidata
-# Later this will be moved to the vars.yaml as all the other jobs.
-  htmlCacheUpdate:
-topic: 'mediawiki.job.htmlCacheUpdate'
-match_not:
-  meta:
-domain: 
'/(?:^en\.wikipedia\.org$)|(?:^commons\.wikimedia\.org$)|(?:.*wikidata\.org$)/'
-exec:
-  method: post
-  uri: '<%= jobrunner_uri %>'
-  headers:
-content-type: 'application/json'
-  body: '{{globals.message}}'
-  agentOptions:
-keepAlive: true
-# End of temporary section
 <%- else %>
   job:
 topic: '/^mediawiki\.job\..*/'
diff --git a/scap/vars.yaml b/scap/vars.yaml
index bb782da..fefc489 100644
--- a/scap/vars.yaml
+++ b/scap/vars.yaml
@@ -21,11 +21,15 @@
 kafka_max_bytes: 4194304
 jobs_enabled:
   deleteLinks: {}
-  MessageIndexRebuildJob: {}
   flaggedrevs_CacheUpdate: {}
-  updateBetaFeaturesUserCounts: {}
+  htmlCacheUpdate:
+# The avg exec time of the job is 60ms
+# so this gives us 150 jobs/s - 3 times the avg rate
+concurrency: 10
+  MessageIndexRebuildJob: {}
   RecordLintJob:
 concurrency: 100
 consumer_batch_size: 10
+  updateBetaFeaturesUserCounts: {}
   wikibase-addUsagesForPage: {}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/404596
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibbe8c11b4177f9671c6cd4e0681e9851c8b999e5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/change-propagation/jobqueue-deploy
Gerrit-Branch: master
Gerrit-Owner: Ppchelko 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[wmf/1.31.0-wmf.17]: Turn off cirrus AB test on hewiki

[EBernhardson (Code Review)]

EBernhardson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404595 )

Change subject: Turn off cirrus AB test on hewiki
..

Turn off cirrus AB test on hewiki

Test has run it's course. Time to turn off and reset hewiki
sampling back to the old (default) rates.

Bug: T182616
Change-Id: I0b6d95af218379d47043c63a240ec5a7132d86ee
(cherry picked from commit b2495fcacf3ae7325f34f37705c2c108eb29e513)
---
M modules/all/ext.wikimediaEvents.searchSatisfaction.js
1 file changed, 1 insertion(+), 7 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaEvents 
refs/changes/95/404595/1

diff --git a/modules/all/ext.wikimediaEvents.searchSatisfaction.js 
b/modules/all/ext.wikimediaEvents.searchSatisfaction.js
index de78f11..b818261 100644
--- a/modules/all/ext.wikimediaEvents.searchSatisfaction.js
+++ b/modules/all/ext.wikimediaEvents.searchSatisfaction.js
@@ -114,9 +114,7 @@
function initialize( session ) {
 
var sessionId = session.get( 'sessionId' ),
-   validBuckets = mw.config.get( 'wgDBname' ) === 
'hewiki' ?
-   [ 'control', 'ltr-1024', 'ltr-1024-i' ] 
:
-   [],
+   validBuckets = [],
sampleSize = ( function () {
var dbName = mw.config.get( 'wgDBname' 
),
// Provides a place to handle 
wiki-specific sampling,
@@ -188,10 +186,6 @@
zhwiki: {
test: 100,
subTest: null
-   },
-   hewiki: {
-   test: 0.8112,
-   subTest: 0.8767
}
};
if ( subTests[ dbName ] ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/404595
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b6d95af218379d47043c63a240ec5a7132d86ee
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: wmf/1.31.0-wmf.17
Gerrit-Owner: EBernhardson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[wmf/1.31.0-wmf.16]: Turn off cirrus AB test on hewiki

[EBernhardson (Code Review)]

EBernhardson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404594 )

Change subject: Turn off cirrus AB test on hewiki
..

Turn off cirrus AB test on hewiki

Test has run it's course. Time to turn off and reset hewiki
sampling back to the old (default) rates.

Bug: T182616
Change-Id: I0b6d95af218379d47043c63a240ec5a7132d86ee
(cherry picked from commit b2495fcacf3ae7325f34f37705c2c108eb29e513)
---
M modules/all/ext.wikimediaEvents.searchSatisfaction.js
1 file changed, 1 insertion(+), 7 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaEvents 
refs/changes/94/404594/1

diff --git a/modules/all/ext.wikimediaEvents.searchSatisfaction.js 
b/modules/all/ext.wikimediaEvents.searchSatisfaction.js
index de78f11..b818261 100644
--- a/modules/all/ext.wikimediaEvents.searchSatisfaction.js
+++ b/modules/all/ext.wikimediaEvents.searchSatisfaction.js
@@ -114,9 +114,7 @@
function initialize( session ) {
 
var sessionId = session.get( 'sessionId' ),
-   validBuckets = mw.config.get( 'wgDBname' ) === 
'hewiki' ?
-   [ 'control', 'ltr-1024', 'ltr-1024-i' ] 
:
-   [],
+   validBuckets = [],
sampleSize = ( function () {
var dbName = mw.config.get( 'wgDBname' 
),
// Provides a place to handle 
wiki-specific sampling,
@@ -188,10 +186,6 @@
zhwiki: {
test: 100,
subTest: null
-   },
-   hewiki: {
-   test: 0.8112,
-   subTest: 0.8767
}
};
if ( subTests[ dbName ] ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/404594
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b6d95af218379d47043c63a240ec5a7132d86ee
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: wmf/1.31.0-wmf.16
Gerrit-Owner: EBernhardson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[master]: Turn off cirrus AB test on hewiki

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404591 )

Change subject: Turn off cirrus AB test on hewiki
..


Turn off cirrus AB test on hewiki

Test has run it's course. Time to turn off and reset hewiki
sampling back to the old (default) rates.

Bug: T182616
Change-Id: I0b6d95af218379d47043c63a240ec5a7132d86ee
---
M modules/all/ext.wikimediaEvents.searchSatisfaction.js
1 file changed, 1 insertion(+), 7 deletions(-)

Approvals:
  EBernhardson: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/all/ext.wikimediaEvents.searchSatisfaction.js 
b/modules/all/ext.wikimediaEvents.searchSatisfaction.js
index de78f11..b818261 100644
--- a/modules/all/ext.wikimediaEvents.searchSatisfaction.js
+++ b/modules/all/ext.wikimediaEvents.searchSatisfaction.js
@@ -114,9 +114,7 @@
function initialize( session ) {
 
var sessionId = session.get( 'sessionId' ),
-   validBuckets = mw.config.get( 'wgDBname' ) === 
'hewiki' ?
-   [ 'control', 'ltr-1024', 'ltr-1024-i' ] 
:
-   [],
+   validBuckets = [],
sampleSize = ( function () {
var dbName = mw.config.get( 'wgDBname' 
),
// Provides a place to handle 
wiki-specific sampling,
@@ -188,10 +186,6 @@
zhwiki: {
test: 100,
subTest: null
-   },
-   hewiki: {
-   test: 0.8112,
-   subTest: 0.8767
}
};
if ( subTests[ dbName ] ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/404591
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0b6d95af218379d47043c63a240ec5a7132d86ee
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: master
Gerrit-Owner: EBernhardson 
Gerrit-Reviewer: EBernhardson 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Group0 to 1.31.0-wmf.17

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404593 )

Change subject: Group0 to 1.31.0-wmf.17
..


Group0 to 1.31.0-wmf.17

Change-Id: I9e75cafea3df20396be912ed13a09a49a7c40a6f
---
M php
M wikiversions.json
2 files changed, 131 insertions(+), 131 deletions(-)

Approvals:
  Thcipriani: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/php b/php
index 20ce497..9f86124 12
--- a/php
+++ b/php
@@ -1 +1 @@
-php-1.31.0-wmf.16
\ No newline at end of file
+php-1.31.0-wmf.17
\ No newline at end of file
diff --git a/wikiversions.json b/wikiversions.json
index c6372a1..6e49e02 100644
--- a/wikiversions.json
+++ b/wikiversions.json
@@ -1,28 +1,28 @@
 {
 "aawiki": "php-1.31.0-wmf.16",
-"aawikibooks": "php-1.31.0-wmf.16",
-"aawiktionary": "php-1.31.0-wmf.16",
+"aawikibooks": "php-1.31.0-wmf.17",
+"aawiktionary": "php-1.31.0-wmf.17",
 "abwiki": "php-1.31.0-wmf.16",
-"abwiktionary": "php-1.31.0-wmf.16",
+"abwiktionary": "php-1.31.0-wmf.17",
 "acewiki": "php-1.31.0-wmf.16",
-"advisorywiki": "php-1.31.0-wmf.16",
+"advisorywiki": "php-1.31.0-wmf.17",
 "adywiki": "php-1.31.0-wmf.16",
 "afwiki": "php-1.31.0-wmf.16",
 "afwikibooks": "php-1.31.0-wmf.16",
 "afwikiquote": "php-1.31.0-wmf.16",
 "afwiktionary": "php-1.31.0-wmf.16",
 "akwiki": "php-1.31.0-wmf.16",
-"akwikibooks": "php-1.31.0-wmf.16",
-"akwiktionary": "php-1.31.0-wmf.16",
+"akwikibooks": "php-1.31.0-wmf.17",
+"akwiktionary": "php-1.31.0-wmf.17",
 "alswiki": "php-1.31.0-wmf.16",
 "amwiki": "php-1.31.0-wmf.16",
 "amwikimedia": "php-1.31.0-wmf.16",
-"amwikiquote": "php-1.31.0-wmf.16",
+"amwikiquote": "php-1.31.0-wmf.17",
 "amwiktionary": "php-1.31.0-wmf.16",
 "angwiki": "php-1.31.0-wmf.16",
-"angwikibooks": "php-1.31.0-wmf.16",
-"angwikiquote": "php-1.31.0-wmf.16",
-"angwikisource": "php-1.31.0-wmf.16",
+"angwikibooks": "php-1.31.0-wmf.17",
+"angwikiquote": "php-1.31.0-wmf.17",
+"angwikisource": "php-1.31.0-wmf.17",
 "angwiktionary": "php-1.31.0-wmf.16",
 "anwiki": "php-1.31.0-wmf.16",
 "anwiktionary": "php-1.31.0-wmf.16",
@@ -42,19 +42,19 @@
 "arwiktionary": "php-1.31.0-wmf.16",
 "arzwiki": "php-1.31.0-wmf.16",
 "astwiki": "php-1.31.0-wmf.16",
-"astwikibooks": "php-1.31.0-wmf.16",
-"astwikiquote": "php-1.31.0-wmf.16",
+"astwikibooks": "php-1.31.0-wmf.17",
+"astwikiquote": "php-1.31.0-wmf.17",
 "astwiktionary": "php-1.31.0-wmf.16",
 "aswiki": "php-1.31.0-wmf.16",
-"aswikibooks": "php-1.31.0-wmf.16",
+"aswikibooks": "php-1.31.0-wmf.17",
 "aswikisource": "php-1.31.0-wmf.16",
-"aswiktionary": "php-1.31.0-wmf.16",
+"aswiktionary": "php-1.31.0-wmf.17",
 "atjwiki": "php-1.31.0-wmf.16",
 "auditcomwiki": "php-1.31.0-wmf.16",
 "avwiki": "php-1.31.0-wmf.16",
-"avwiktionary": "php-1.31.0-wmf.16",
+"avwiktionary": "php-1.31.0-wmf.17",
 "aywiki": "php-1.31.0-wmf.16",
-"aywikibooks": "php-1.31.0-wmf.16",
+"aywikibooks": "php-1.31.0-wmf.17",
 "aywiktionary": "php-1.31.0-wmf.16",
 "azbwiki": "php-1.31.0-wmf.16",
 "azwiki": "php-1.31.0-wmf.16",
@@ -83,15 +83,15 @@
 "bgwikisource": "php-1.31.0-wmf.16",
 "bgwiktionary": "php-1.31.0-wmf.16",
 "bhwiki": "php-1.31.0-wmf.16",
-"bhwiktionary": "php-1.31.0-wmf.16",
+"bhwiktionary": "php-1.31.0-wmf.17",
 "biwiki": "php-1.31.0-wmf.16",
-"biwikibooks": "php-1.31.0-wmf.16",
-"biwiktionary": "php-1.31.0-wmf.16",
+"biwikibooks": "php-1.31.0-wmf.17",
+"biwiktionary": "php-1.31.0-wmf.17",
 "bjnwiki": "php-1.31.0-wmf.16",
 "bmwiki": "php-1.31.0-wmf.16",
-"bmwikibooks": "php-1.31.0-wmf.16",
-"bmwikiquote": "php-1.31.0-wmf.16",
-"bmwiktionary": "php-1.31.0-wmf.16",
+"bmwikibooks": "php-1.31.0-wmf.17",
+"bmwikiquote": "php-1.31.0-wmf.17",
+"bmwiktionary": "php-1.31.0-wmf.17",
 "bnwiki": "php-1.31.0-wmf.16",
 "bnwikibooks": "php-1.31.0-wmf.16",
 "bnwikisource": "php-1.31.0-wmf.16",
@@ -99,8 +99,8 @@
 "boardgovcomwiki": "php-1.31.0-wmf.16",
 "boardwiki": "php-1.31.0-wmf.16",
 "bowiki": "php-1.31.0-wmf.16",
-"bowikibooks": "php-1.31.0-wmf.16",
-"bowiktionary": "php-1.31.0-wmf.16",
+"bowikibooks": "php-1.31.0-wmf.17",
+"bowiktionary": "php-1.31.0-wmf.17",
 "bpywiki": "php-1.31.0-wmf.16",
 "brwiki": "php-1.31.0-wmf.16",
 "brwikimedia": "php-1.31.0-wmf.16",
@@ -129,26 +129,26 @@
 "chairwiki": "php-1.31.0-wmf.16",
 "chapcomwiki": "php-1.31.0-wmf.16",
 "checkuserwiki": "php-1.31.0-wmf.16",
-"chowiki": "php-1.31.0-wmf.16",
+"chowiki": "php-1.31.0-wmf.17",
 "chrwiki": "php-1.31.0-wmf.16",
 "chrwiktionary": "php-1.31.0-wmf.16",
 "chwiki": "php-1.31.0-wmf.16",
-"chwikibooks": "php-1.31.0-wmf.16",
-"chwiktionary": 

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Group0 to 1.31.0-wmf.17

[Thcipriani (Code Review)]

Thcipriani has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404593 )

Change subject: Group0 to 1.31.0-wmf.17
..

Group0 to 1.31.0-wmf.17

Change-Id: I9e75cafea3df20396be912ed13a09a49a7c40a6f
---
M php
M wikiversions.json
2 files changed, 131 insertions(+), 131 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/93/404593/1

diff --git a/php b/php
index 20ce497..9f86124 12
--- a/php
+++ b/php
@@ -1 +1 @@
-php-1.31.0-wmf.16
\ No newline at end of file
+php-1.31.0-wmf.17
\ No newline at end of file
diff --git a/wikiversions.json b/wikiversions.json
index c6372a1..6e49e02 100644
--- a/wikiversions.json
+++ b/wikiversions.json
@@ -1,28 +1,28 @@
 {
 "aawiki": "php-1.31.0-wmf.16",
-"aawikibooks": "php-1.31.0-wmf.16",
-"aawiktionary": "php-1.31.0-wmf.16",
+"aawikibooks": "php-1.31.0-wmf.17",
+"aawiktionary": "php-1.31.0-wmf.17",
 "abwiki": "php-1.31.0-wmf.16",
-"abwiktionary": "php-1.31.0-wmf.16",
+"abwiktionary": "php-1.31.0-wmf.17",
 "acewiki": "php-1.31.0-wmf.16",
-"advisorywiki": "php-1.31.0-wmf.16",
+"advisorywiki": "php-1.31.0-wmf.17",
 "adywiki": "php-1.31.0-wmf.16",
 "afwiki": "php-1.31.0-wmf.16",
 "afwikibooks": "php-1.31.0-wmf.16",
 "afwikiquote": "php-1.31.0-wmf.16",
 "afwiktionary": "php-1.31.0-wmf.16",
 "akwiki": "php-1.31.0-wmf.16",
-"akwikibooks": "php-1.31.0-wmf.16",
-"akwiktionary": "php-1.31.0-wmf.16",
+"akwikibooks": "php-1.31.0-wmf.17",
+"akwiktionary": "php-1.31.0-wmf.17",
 "alswiki": "php-1.31.0-wmf.16",
 "amwiki": "php-1.31.0-wmf.16",
 "amwikimedia": "php-1.31.0-wmf.16",
-"amwikiquote": "php-1.31.0-wmf.16",
+"amwikiquote": "php-1.31.0-wmf.17",
 "amwiktionary": "php-1.31.0-wmf.16",
 "angwiki": "php-1.31.0-wmf.16",
-"angwikibooks": "php-1.31.0-wmf.16",
-"angwikiquote": "php-1.31.0-wmf.16",
-"angwikisource": "php-1.31.0-wmf.16",
+"angwikibooks": "php-1.31.0-wmf.17",
+"angwikiquote": "php-1.31.0-wmf.17",
+"angwikisource": "php-1.31.0-wmf.17",
 "angwiktionary": "php-1.31.0-wmf.16",
 "anwiki": "php-1.31.0-wmf.16",
 "anwiktionary": "php-1.31.0-wmf.16",
@@ -42,19 +42,19 @@
 "arwiktionary": "php-1.31.0-wmf.16",
 "arzwiki": "php-1.31.0-wmf.16",
 "astwiki": "php-1.31.0-wmf.16",
-"astwikibooks": "php-1.31.0-wmf.16",
-"astwikiquote": "php-1.31.0-wmf.16",
+"astwikibooks": "php-1.31.0-wmf.17",
+"astwikiquote": "php-1.31.0-wmf.17",
 "astwiktionary": "php-1.31.0-wmf.16",
 "aswiki": "php-1.31.0-wmf.16",
-"aswikibooks": "php-1.31.0-wmf.16",
+"aswikibooks": "php-1.31.0-wmf.17",
 "aswikisource": "php-1.31.0-wmf.16",
-"aswiktionary": "php-1.31.0-wmf.16",
+"aswiktionary": "php-1.31.0-wmf.17",
 "atjwiki": "php-1.31.0-wmf.16",
 "auditcomwiki": "php-1.31.0-wmf.16",
 "avwiki": "php-1.31.0-wmf.16",
-"avwiktionary": "php-1.31.0-wmf.16",
+"avwiktionary": "php-1.31.0-wmf.17",
 "aywiki": "php-1.31.0-wmf.16",
-"aywikibooks": "php-1.31.0-wmf.16",
+"aywikibooks": "php-1.31.0-wmf.17",
 "aywiktionary": "php-1.31.0-wmf.16",
 "azbwiki": "php-1.31.0-wmf.16",
 "azwiki": "php-1.31.0-wmf.16",
@@ -83,15 +83,15 @@
 "bgwikisource": "php-1.31.0-wmf.16",
 "bgwiktionary": "php-1.31.0-wmf.16",
 "bhwiki": "php-1.31.0-wmf.16",
-"bhwiktionary": "php-1.31.0-wmf.16",
+"bhwiktionary": "php-1.31.0-wmf.17",
 "biwiki": "php-1.31.0-wmf.16",
-"biwikibooks": "php-1.31.0-wmf.16",
-"biwiktionary": "php-1.31.0-wmf.16",
+"biwikibooks": "php-1.31.0-wmf.17",
+"biwiktionary": "php-1.31.0-wmf.17",
 "bjnwiki": "php-1.31.0-wmf.16",
 "bmwiki": "php-1.31.0-wmf.16",
-"bmwikibooks": "php-1.31.0-wmf.16",
-"bmwikiquote": "php-1.31.0-wmf.16",
-"bmwiktionary": "php-1.31.0-wmf.16",
+"bmwikibooks": "php-1.31.0-wmf.17",
+"bmwikiquote": "php-1.31.0-wmf.17",
+"bmwiktionary": "php-1.31.0-wmf.17",
 "bnwiki": "php-1.31.0-wmf.16",
 "bnwikibooks": "php-1.31.0-wmf.16",
 "bnwikisource": "php-1.31.0-wmf.16",
@@ -99,8 +99,8 @@
 "boardgovcomwiki": "php-1.31.0-wmf.16",
 "boardwiki": "php-1.31.0-wmf.16",
 "bowiki": "php-1.31.0-wmf.16",
-"bowikibooks": "php-1.31.0-wmf.16",
-"bowiktionary": "php-1.31.0-wmf.16",
+"bowikibooks": "php-1.31.0-wmf.17",
+"bowiktionary": "php-1.31.0-wmf.17",
 "bpywiki": "php-1.31.0-wmf.16",
 "brwiki": "php-1.31.0-wmf.16",
 "brwikimedia": "php-1.31.0-wmf.16",
@@ -129,26 +129,26 @@
 "chairwiki": "php-1.31.0-wmf.16",
 "chapcomwiki": "php-1.31.0-wmf.16",
 "checkuserwiki": "php-1.31.0-wmf.16",
-"chowiki": "php-1.31.0-wmf.16",
+"chowiki": "php-1.31.0-wmf.17",
 "chrwiki": "php-1.31.0-wmf.16",
 "chrwiktionary": "php-1.31.0-wmf.16",
 "chwiki": "php-1.31.0-wmf.16",
-"chwikibooks": "php-1.31.0-wmf.16",
-"chwiktionary": 

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Remove cirrus AB test config for hewiki

[EBernhardson (Code Review)]

EBernhardson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404592 )

Change subject: Remove cirrus AB test config for hewiki
..

Remove cirrus AB test config for hewiki

This test is complete and the configuration is no longer
necessary.

Bug: T182616
Change-Id: Ibb55c90ecf7fc562860fb69a06d2d1f2babf49aa
---
M wmf-config/InitialiseSettings.php
1 file changed, 0 insertions(+), 24 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/92/404592/1

diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index 9767eb5..c76cecc 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -18702,30 +18702,6 @@
 
 'wmgCirrusSearchUserTesting' => [
'default' => [],
-   'hewiki' => [
-   'ltr' => [
-   'globals' => [],
-   'buckets' => [
-   'control' => [
-   'trigger' => 'control',
-   ],
-   'ltr-1024' => [
-   'trigger' => 'ltr-1024',
-   'globals' => [
-   'wgCirrusSearchRescoreProfile' 
=> 'mlr-1024rs',
-   ]
-   ],
-   'ltr-1024-i' => [
-   'trigger' => 'ltr-1024-i',
-   'globals' => [
-   
'wgCirrusSearchInterleaveConfig' => [
-   
'CirrusSearchRescoreProfile' => 'mlr-1024rs'
-   ],
-   ],
-   ],
-   ],
-   ],
-   ],
 ],
 
 'wmgCirrusSearchLanguageDetectors' => [

-- 
To view, visit https://gerrit.wikimedia.org/r/404592
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibb55c90ecf7fc562860fb69a06d2d1f2babf49aa
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: EBernhardson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[master]: Turn off hewiki AB test

[EBernhardson (Code Review)]

EBernhardson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404591 )

Change subject: Turn off hewiki AB test
..

Turn off hewiki AB test

Test has run it's course. Time to turn off and reset hewiki
sampling back to the old (default) rates.

Bug: T182616
Change-Id: I0b6d95af218379d47043c63a240ec5a7132d86ee
---
M modules/all/ext.wikimediaEvents.searchSatisfaction.js
1 file changed, 1 insertion(+), 7 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaEvents 
refs/changes/91/404591/1

diff --git a/modules/all/ext.wikimediaEvents.searchSatisfaction.js 
b/modules/all/ext.wikimediaEvents.searchSatisfaction.js
index de78f11..b818261 100644
--- a/modules/all/ext.wikimediaEvents.searchSatisfaction.js
+++ b/modules/all/ext.wikimediaEvents.searchSatisfaction.js
@@ -114,9 +114,7 @@
function initialize( session ) {
 
var sessionId = session.get( 'sessionId' ),
-   validBuckets = mw.config.get( 'wgDBname' ) === 
'hewiki' ?
-   [ 'control', 'ltr-1024', 'ltr-1024-i' ] 
:
-   [],
+   validBuckets = [],
sampleSize = ( function () {
var dbName = mw.config.get( 'wgDBname' 
),
// Provides a place to handle 
wiki-specific sampling,
@@ -188,10 +186,6 @@
zhwiki: {
test: 100,
subTest: null
-   },
-   hewiki: {
-   test: 0.8112,
-   subTest: 0.8767
}
};
if ( subTests[ dbName ] ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/404591
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b6d95af218379d47043c63a240ec5a7132d86ee
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: master
Gerrit-Owner: EBernhardson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CodeReview[master]: wfMemcKey (deprecated in MW 1.30) -> makeKey() on a BagOStuf...

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/403871 )

Change subject: wfMemcKey (deprecated in MW 1.30) -> makeKey() on a BagOStuff 
instance
..


wfMemcKey (deprecated in MW 1.30) -> makeKey() on a BagOStuff instance

Change-Id: Ibd174f842230118285b682b03c49ec2a432f7764
---
M backend/CodeRepository.php
M backend/RepoStats.php
2 files changed, 14 insertions(+), 4 deletions(-)

Approvals:
  Bartosz Dziewoński: Looks good to me, approved
  SamanthaNguyen: Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/backend/CodeRepository.php b/backend/CodeRepository.php
index 4b60804..eb90ac4 100644
--- a/backend/CodeRepository.php
+++ b/backend/CodeRepository.php
@@ -188,11 +188,13 @@
 */
public function getAuthorList() {
global $wgMemc;
-   $key = wfMemcKey( 'codereview', 'authors', $this->getId() );
+
+   $key = $wgMemc->makeKey( 'codereview', 'authors', 
$this->getId() );
$authors = $wgMemc->get( $key );
if ( is_array( $authors ) ) {
return $authors;
}
+
$dbr = wfGetDB( DB_REPLICA );
$res = $dbr->select(
'code_rev',
@@ -205,6 +207,7 @@
'LIMIT' => 500
]
);
+
$authors = [];
foreach ( $res as $row ) {
if ( $row->cr_author !== null ) {
@@ -214,7 +217,9 @@
];
}
}
+
$wgMemc->set( $key, $authors, 3600 * 24 );
+
return $authors;
}
 
@@ -232,11 +237,13 @@
 */
public function getTagList( $recache = false ) {
global $wgMemc;
-   $key = wfMemcKey( 'codereview', 'tags', $this->getId() );
+
+   $key = $wgMemc->makeKey( 'codereview', 'tags', $this->getId() );
$tags = $wgMemc->get( $key );
if ( is_array( $tags ) && !$recache ) {
return $tags;
}
+
$dbr = wfGetDB( DB_REPLICA );
$res = $dbr->select(
'code_tags',
@@ -249,11 +256,14 @@
'LIMIT' => 500
]
);
+
$tags = [];
foreach ( $res as $row ) {
$tags[$row->ct_tag] = $row->revs;
}
+
$wgMemc->set( $key, $tags, 3600 * 3 );
+
return $tags;
}
 
@@ -355,7 +365,7 @@
 
// Set up the cache key, which will be used both to check if 
already in the
// cache, and to write the final result to the cache.
-   $key = wfMemcKey( 'svn', md5( $this->path ), 'diff', $rev1, 
$rev2 );
+   $key = $wgMemc->makeKey( 'svn', md5( $this->path ), 'diff', 
$rev1, $rev2 );
 
// If not set to explicitly skip the cache, get the current 
diff from memcached
// directly.
diff --git a/backend/RepoStats.php b/backend/RepoStats.php
index 1e9d779..de27b7f 100644
--- a/backend/RepoStats.php
+++ b/backend/RepoStats.php
@@ -25,7 +25,7 @@
public static function newFromRepo( CodeRepository $repo ) {
global $wgMemc, $wgCodeReviewRepoStatsCacheTime;
 
-   $key = wfMemcKey( 'codereview1', 'stats', $repo->getName() );
+   $key = $wgMemc->makeKey( 'codereview1', 'stats', 
$repo->getName() );
$stats = $wgMemc->get( $key );
wfDebug( "{$repo->getName()} repo stats: cache " );
if ( $stats ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/403871
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibd174f842230118285b682b03c49ec2a432f7764
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CodeReview
Gerrit-Branch: master
Gerrit-Owner: Jack Phoenix 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: SamanthaNguyen 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/dns[master]: uncomment ptr record for frav1001

[Jgreen (Code Review)]

Jgreen has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404590 )

Change subject: uncomment ptr record for frav1001
..


uncomment ptr record for frav1001

Change-Id: I6556a58b9b785af783f8ae114ed4e31d40f037b9
---
M templates/10.in-addr.arpa
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Jgreen: Looks good to me, approved



diff --git a/templates/10.in-addr.arpa b/templates/10.in-addr.arpa
index a2ddb39..4c7edc9 100644
--- a/templates/10.in-addr.arpa
+++ b/templates/10.in-addr.arpa
@@ -982,7 +982,7 @@
 68  1H IN PTR   frauth1001.frack.eqiad.wmnet.
 69  1H IN PTR   bismuth.frack.eqiad.wmnet.
 70  1H IN PTR   frpm1001.frack.eqiad.wmnet.
-;71  1H IN PTR   frav1001.frack.eqiad.wmnet.
+71  1H IN PTR   frav1001.frack.eqiad.wmnet.
 72  1H IN PTR   frlog1001.frack.eqiad.wmnet.
 
 ; 10.64.40.96/27 - frack-fundraising1-c-eqiad

-- 
To view, visit https://gerrit.wikimedia.org/r/404590
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6556a58b9b785af783f8ae114ed4e31d40f037b9
Gerrit-PatchSet: 1
Gerrit-Project: operations/dns
Gerrit-Branch: master
Gerrit-Owner: Jgreen 
Gerrit-Reviewer: Jgreen 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/dns[master]: uncomment ptr record for frav1001

[Jgreen (Code Review)]

Jgreen has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404590 )

Change subject: uncomment ptr record for frav1001
..

uncomment ptr record for frav1001

Change-Id: I6556a58b9b785af783f8ae114ed4e31d40f037b9
---
M templates/10.in-addr.arpa
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/dns 
refs/changes/90/404590/1

diff --git a/templates/10.in-addr.arpa b/templates/10.in-addr.arpa
index a2ddb39..4c7edc9 100644
--- a/templates/10.in-addr.arpa
+++ b/templates/10.in-addr.arpa
@@ -982,7 +982,7 @@
 68  1H IN PTR   frauth1001.frack.eqiad.wmnet.
 69  1H IN PTR   bismuth.frack.eqiad.wmnet.
 70  1H IN PTR   frpm1001.frack.eqiad.wmnet.
-;71  1H IN PTR   frav1001.frack.eqiad.wmnet.
+71  1H IN PTR   frav1001.frack.eqiad.wmnet.
 72  1H IN PTR   frlog1001.frack.eqiad.wmnet.
 
 ; 10.64.40.96/27 - frack-fundraising1-c-eqiad

-- 
To view, visit https://gerrit.wikimedia.org/r/404590
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6556a58b9b785af783f8ae114ed4e31d40f037b9
Gerrit-PatchSet: 1
Gerrit-Project: operations/dns
Gerrit-Branch: master
Gerrit-Owner: Jgreen 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: JobQueue: Use EventBus for HTMLCacheUpdate except en, common...

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/403703 )

Change subject: JobQueue: Use EventBus for HTMLCacheUpdate except en, commons, 
wikidata
..


JobQueue: Use EventBus for HTMLCacheUpdate except en, commons, wikidata

This is a second step towards integrating htmlCacheUpdate jobs into the
EventBus system. With this commit we switch them for all wikis but
enwiki, commonswiki and wikidatawiki, meaning that 50% of jobs will run
on the old infra and the other 50% will run on EventBus.

Bug: T182023
Change-Id: I31cc990b3baf7914236b7b56aea8c2ff8102cc07
---
M wmf-config/InitialiseSettings.php
1 file changed, 11 insertions(+), 12 deletions(-)

Approvals:
  Mobrovac: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index e5792d7..9767eb5 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -19655,19 +19655,18 @@
'votewiki' => false,
 ],
 
-// Temporary code for the first test of htmlCacheUpdate
-// on the EventBus JobQueue -disable old queue on wiktionaries only
+// Temporary code for gradually integrating htmlCacheUpdate
+// jobs into the EventBus JobQueue - T182023
+// Step 2: enable everywhere but wikidata, enwiki and commons
 'wmgDisableHTMLCacheUpdateInRedis' => [
-   'default' => false,
-   'cebwiki' => true,
-   'ruwiki' => true,
-   'wikibooks' => true,
-   'wikinews' => true,
-   'wikiquote' => true,
-   'wikisource' => true,
-   'wikiversity' => true,
-   'wikivoyage' => true,
-   'wiktionary' => true,
+   'default' => true,
+   'wikitech' => false,
+   'private' => false,
+   'loginwiki' => false,
+   'votewiki' => false,
+   'commonswiki' => false,
+   'enwiki' => false,
+   'wikidatawiki' => false,
 ],
 
 'wmgUseCapiunto' => [

-- 
To view, visit https://gerrit.wikimedia.org/r/403703
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I31cc990b3baf7914236b7b56aea8c2ff8102cc07
Gerrit-PatchSet: 2
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 
Gerrit-Reviewer: Giuseppe Lavagetto 
Gerrit-Reviewer: Mobrovac 
Gerrit-Reviewer: Ppchelko 
Gerrit-Reviewer: Urbanecm 
Gerrit-Reviewer: Zoranzoki21 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...jobqueue-deploy[master]: Config: Switch htmlCacheUpdates for all but en, commons, wik...

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/403704 )

Change subject: Config: Switch htmlCacheUpdates for all but en, commons, 
wikidata
..


Config: Switch htmlCacheUpdates for all but en, commons, wikidata

Bug: T182023
Change-Id: I5e2876de911f08c392cfc479d9ac0e80d76eb4a7
---
M scap/templates/config.yaml.j2
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved
  Ppchelko: Looks good to me, but someone else must approve



diff --git a/scap/templates/config.yaml.j2 b/scap/templates/config.yaml.j2
index 7b8140a..cf20ab3 100644
--- a/scap/templates/config.yaml.j2
+++ b/scap/templates/config.yaml.j2
@@ -49,13 +49,13 @@
   agentOptions:
 keepAlive: true
 <%- endfor %>
-# Temporary section - we are only enabling the htmlCacheUpdate for wiktionaries
+# Temporary section - we are only enabling the htmlCacheUpdate for all but 
enwiki, commons and wikidata
 # Later this will be moved to the vars.yaml as all the other jobs.
   htmlCacheUpdate:
 topic: 'mediawiki.job.htmlCacheUpdate'
-match:
+match_not:
   meta:
-domain: 
'/(?:^ceb\.wikipedia\.org$)|(?:^ru\.wikipedia\.org$)|(?:.*\.wikibooks\.org$)|(?:.*\.wikinews\.org$)|(?:.*\.wikiquote\.org$)|(?:.*\.wikisource\.org$)|(?:.*\.wikiversity\.org$)|(?:.*\.wikivoyage\.org$)|(?:.*\.wiktionary\.org$)/'
+domain: 
'/(?:^en\.wikipedia\.org$)|(?:^commons\.wikimedia\.org$)|(?:.*wikidata\.org$)/'
 exec:
   method: post
   uri: '<%= jobrunner_uri %>'

-- 
To view, visit https://gerrit.wikimedia.org/r/403704
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5e2876de911f08c392cfc479d9ac0e80d76eb4a7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/change-propagation/jobqueue-deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 
Gerrit-Reviewer: Mobrovac 
Gerrit-Reviewer: Ppchelko 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Align the icon in the popup action sub menus

[Mooeypoo (Code Review)]

Mooeypoo has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404589 )

Change subject: Align the icon in the popup action sub menus
..

Align the icon in the popup action sub menus

Bug: T185046
Change-Id: Iea0305d2b90c659fc24113980fa0900f559c2ab4
---
M modules/styles/mw.echo.ui.MenuItemWidget.less
1 file changed, 0 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo 
refs/changes/89/404589/1

diff --git a/modules/styles/mw.echo.ui.MenuItemWidget.less 
b/modules/styles/mw.echo.ui.MenuItemWidget.less
index 799f8a3..ba05662 100644
--- a/modules/styles/mw.echo.ui.MenuItemWidget.less
+++ b/modules/styles/mw.echo.ui.MenuItemWidget.less
@@ -10,9 +10,6 @@
height: 1.5em;
min-width: 1.5em;
min-height: 1.5em;
-
-   position: absolute;
-   top: 0;
}
 
&-content {

-- 
To view, visit https://gerrit.wikimedia.org/r/404589
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iea0305d2b90c659fc24113980fa0900f559c2ab4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikimedia/wikimania-scholarships[master]: Update 2018 privacy statement

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/403544 )

Change subject: Update 2018 privacy statement
..


Update 2018 privacy statement

Bug: T184659
Change-Id: I8855f0b5be076a34ad31767ac922480710184eff
---
M data/i18n/en.json
M data/i18n/qqq.json
M data/templates/apply.html
3 files changed, 11 insertions(+), 21 deletions(-)

Approvals:
  Niharika29: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/data/i18n/en.json b/data/i18n/en.json
index c1a8974..8be766d 100644
--- a/data/i18n/en.json
+++ b/data/i18n/en.json
@@ -33,6 +33,7 @@
 
"form-intro": "This is the application for sponsorship to attend https://wikimania2018.wikimedia.org/wiki/Special:MyLanguage/Main_Page\;>Wikimania
 2018, the annual international conference centered on Wikimedia projects. 
Awardees will receive a scholarship which will cover conference registration 
fees, hotel, and roundtrip travel to Wikimania in Cape Town, South Africa, July 
18-22, 2018.\nApplications may be submitted in any language, but 
every applicant must provide evidence of English language abilities that 
are at a level which would enable them to participate in Wikimania, a 
conference which is primarily conducted in English. Sufficient English 
abilities could be demonstrated in the application itself or 
elsewhere.\nPlease carefully consider your financial needs before 
applying for a scholarship to attend Wikimania. There are limited funds 
available and many applicants do not have the financial means to attend 
Wikimania without this opportunity. Thank you.\nPlease note that 
if you need more then 10 minutes to complete this application, please 
draft your answers in a text editor, reload this page and then copy 
and paste your answers into corresponding fields before submitting. This 
application may give an error (\"Missing or invalid CSRF token\") if it is open 
for more then 15 minutes before submitting.\nThe deadline to apply is 
January 22, 2018, 23:59 UTC. ",
 
+   "form-intro-privacy": "For information about privacy and data-handling, 
please review the https://wikimediafoundation.org/wiki/Wikimania_2018_Application_Form_Privacy_Statement\;>application
 privacy statement.",
"form-intro-faq": "Frequently
 asked questions",
 
"form-scholarship-type": "Type of Scholarship",
@@ -150,17 +151,13 @@
"form-info-true": "I certify that all of the information provided with 
my application is true and accurate to the best of my knowledge and belief. The 
Wikimedia Foundation reserves the right to require me to pay back all or part 
of the grant if any of the information I provide is found to be untrue or 
inaccurate.",
 
"form-privacy": "Privacy",
-   "form-review": "All information contained in this application will be 
reviewed by the members of the https://wikimania2018.wikimedia.org/wiki/Special:MyLanguage/Scholarship_committee\;>Wikimania
 Scholarship Committee. All personal information will be held strictly 
confidential by the Committee, and the https://wikimediafoundation.org/\;>Wikimedia Foundation.",
+   "form-privacy1": "Please read the https://wikimediafoundation.org/wiki/Wikimania_2018_Application_Form_Privacy_Statement\;>application
 privacy statement for details about privacy and data-handling.",
+   "form-privacy2": "Wikimedia is a global organization committed to 
promoting free and open knowledge. By completing the survey, you agree to the 
collection, transfer, storage, processing and use of the collected information 
in the United States and other places as may be necessary to carry out the 
purposes and objectives discussed above. You also consent to the transfer of 
information from the U.S. to other countries, which may have different or less 
stringent data protection laws than your country, in order to carry out the 
aforementioned purposes and objectives.",
"form-chapteragree": "Wikimedia movement organizations (Chapters, 
Thematic organizations, and User Groups) also offer scholarships for Wikimania, 
separate from the Wikimedia Foundation Scholarship Program. While this 
application is submitted for a Wikimedia Foundation Scholarship, a Wikimedia 
movement organization may request access to applications that are relevant to 
their country or community, for the purpose of selecting and awarding their 
own, independently awarded scholarships. \n Please indicate whether or not 
you would like your information shared with other, independent Wikimedia 
movement organizations.",
"form-separatejury": "Do you intend to apply to any local Chapter / 
other movement organization(s) for scholarship funding to Wikimania 2018?",
"form-scholarorgs": "If so, please list the organizations below:",
 
-   "form-rights-heading": "Applicant Rights & Consent to Data Processing 
and Transfer",
-   "form-rights1": "I as an applicant for a 

[MediaWiki-commits] [Gerrit] mediawiki...SocialProfile[master]: Improve PHP documentation for functions and class member var...

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404231 )

Change subject: Improve PHP documentation for functions and class member 
variables
..


Improve PHP documentation for functions and class member variables

This improves PHP docs across the board, with the following
improvements:
 - Reorders parameter syntax which is now organized like:
   - @param datatype $paramName description
 - Parameter descriptions are now capitalized at the beginning,
   for consistency and easier reading + distinction
 - Make data type on 'mixed' values more specific
 - Add spacing between function description and PHP doc annotations
   where there wasn't some already
 - Adds some @return annotation docs
 - Adds some @param annotation docs
 - Removed inaccurate "@private" and "@access private" annotations

This helps SocialProfile further conform to the conventions as
described in:
https://www.mediawiki.org/wiki/Manual:Coding_conventions/PHP#Comments_and_documentation

Change-Id: Ibd169c0491a23d7ca1cc8c8452420ab2e5e853cc
---
M SystemGifts/SpecialPopulateAwards.php
M SystemGifts/SpecialRemoveMasterSystemGift.php
M SystemGifts/SpecialSystemGiftManager.php
M SystemGifts/SpecialSystemGiftManagerLogo.php
M SystemGifts/SpecialViewSystemGift.php
M SystemGifts/SpecialViewSystemGifts.php
M SystemGifts/SystemGiftsClass.php
M SystemGifts/TopAwards.php
M SystemGifts/UserSystemGiftsClass.php
M UserActivity/SiteActivityHook.php
M UserActivity/UserActivity.body.php
M UserActivity/UserActivityClass.php
M UserBoard/SpecialSendBoardBlast.php
M UserBoard/SpecialUserBoard.php
M UserBoard/UserBoardClass.php
M UserGifts/GiftsClass.php
M UserGifts/SpecialGiftManager.php
M UserGifts/SpecialGiftManagerLogo.php
M UserGifts/SpecialGiveGift.php
M UserGifts/SpecialRemoveGift.php
M UserGifts/SpecialRemoveMasterGift.php
M UserGifts/SpecialViewGift.php
M UserGifts/SpecialViewGifts.php
M UserGifts/UserGiftsClass.php
M UserProfile/AvatarClass.php
M UserProfile/AvatarParserFunction.php
M UserProfile/SpecialEditProfile.php
M UserProfile/SpecialPopulateExistingUsersProfiles.php
M UserProfile/SpecialRemoveAvatar.php
M UserProfile/SpecialToggleUserPageType.php
M UserProfile/SpecialUpdateProfile.php
M UserProfile/SpecialUploadAvatar.php
M UserProfile/UploadAvatar.php
M UserProfile/UserProfileClass.php
M UserProfile/UserProfilePage.php
M UserRelationship/SpecialAddRelationship.php
M UserRelationship/SpecialRemoveRelationship.php
M UserRelationship/SpecialViewRelationshipRequests.php
M UserRelationship/SpecialViewRelationships.php
M UserRelationship/UserRelationshipClass.php
M UserStats/EditCount.php
M UserStats/GenerateTopUsersReport.php
M UserStats/SpecialUpdateEditCounts.php
M UserStats/TopFansByStat.php
M UserStats/TopUsers.php
M UserStats/TopUsersTag.php
M UserStats/UserLevel.php
M UserStats/UserStats.php
M UserStats/UserStatsTrack.php
M UserSystemMessages/UserSystemMessagesClass.php
M UserWelcome/UserWelcomeClass.php
51 files changed, 509 insertions(+), 441 deletions(-)

Approvals:
  Jack Phoenix: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/SystemGifts/SpecialPopulateAwards.php 
b/SystemGifts/SpecialPopulateAwards.php
index 17dc727..bcddf26 100644
--- a/SystemGifts/SpecialPopulateAwards.php
+++ b/SystemGifts/SpecialPopulateAwards.php
@@ -19,7 +19,7 @@
/**
 * Show the special page
 *
-* @param $gift_category Mixed: parameter passed to the page or null
+* @param string|null $gift_category
 */
public function execute( $gift_category ) {
global $wgUserLevels;
diff --git a/SystemGifts/SpecialRemoveMasterSystemGift.php 
b/SystemGifts/SpecialRemoveMasterSystemGift.php
index a68b07b..16d8358 100644
--- a/SystemGifts/SpecialRemoveMasterSystemGift.php
+++ b/SystemGifts/SpecialRemoveMasterSystemGift.php
@@ -17,9 +17,12 @@
/**
 * Deletes a gift image from $wgUploadDirectory/awards/
 *
-* @param $id Integer: internal ID number of the gift whose image we 
want to delete
-* @param $size String: size of the image to delete (s for small, m for
-*  medium, ml for medium-large and l for large)
+* @param int $id Internal ID number of the gift whose image we want to 
delete
+* @param string $size Size of the image to delete,
+* - s for small
+* - m for medium
+* - ml for medium-large
+* - l for large
 */
function deleteImage( $id, $size ) {
global $wgUploadDirectory;
@@ -34,7 +37,8 @@
/**
 * Show the special page
 *
-* @param $par Mixed: parameter passed to the page or null
+* @param string|null $par
+* @return string HTML
 */
public function execute( $par ) {
$out = $this->getOutput();
@@ -113,7 +117,7 @@
/**
 * Displays the main form 

[MediaWiki-commits] [Gerrit] operations/puppet[production]: cloud: labvirt settle on meltdown kernel

[Andrew Bogott (Code Review)]

Andrew Bogott has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404588 )

Change subject: cloud: labvirt settle on meltdown kernel
..


cloud: labvirt settle on meltdown kernel

Bug: T184189
Change-Id: I8da97b71a88788eff8e107c8875baba9c511ca33
---
M modules/openstack/manifests/nova/compute/audit.pp
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Andrew Bogott: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/openstack/manifests/nova/compute/audit.pp 
b/modules/openstack/manifests/nova/compute/audit.pp
index e9ccb94..7e632c6 100644
--- a/modules/openstack/manifests/nova/compute/audit.pp
+++ b/modules/openstack/manifests/nova/compute/audit.pp
@@ -6,7 +6,7 @@
 # Virtio has shown to be non-determinstic on certain host:client kernel
 # version matchups (IO freezing)
 class openstack::nova::compute::audit(
-$whitelist_kernels=['4.4.0-81-generic', '4.4.0-109-generic'],
+$whitelist_kernels=['4.4.0-109-generic'],
 ) {
 
 if os_version('ubuntu >= trusty') {

-- 
To view, visit https://gerrit.wikimedia.org/r/404588
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8da97b71a88788eff8e107c8875baba9c511ca33
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Rush 
Gerrit-Reviewer: Andrew Bogott 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: cloud: labvirt settle on meltdown kernel

[Rush (Code Review)]

Rush has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404588 )

Change subject: cloud: labvirt settle on meltdown kernel
..

cloud: labvirt settle on meltdown kernel

Bug: T184189
Change-Id: I8da97b71a88788eff8e107c8875baba9c511ca33
---
M modules/openstack/manifests/nova/compute/audit.pp
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/88/404588/1

diff --git a/modules/openstack/manifests/nova/compute/audit.pp 
b/modules/openstack/manifests/nova/compute/audit.pp
index e9ccb94..7e632c6 100644
--- a/modules/openstack/manifests/nova/compute/audit.pp
+++ b/modules/openstack/manifests/nova/compute/audit.pp
@@ -6,7 +6,7 @@
 # Virtio has shown to be non-determinstic on certain host:client kernel
 # version matchups (IO freezing)
 class openstack::nova::compute::audit(
-$whitelist_kernels=['4.4.0-81-generic', '4.4.0-109-generic'],
+$whitelist_kernels=['4.4.0-109-generic'],
 ) {
 
 if os_version('ubuntu >= trusty') {

-- 
To view, visit https://gerrit.wikimedia.org/r/404588
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8da97b71a88788eff8e107c8875baba9c511ca33
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Rush 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: puppetmaster::ssl: fix crl file suffix

[Herron (Code Review)]

Herron has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404587 )

Change subject: puppetmaster::ssl: fix crl file suffix
..

puppetmaster::ssl: fix crl file suffix

change file suffix from .0 to .r0 for crl symlinks
created by puppetmaster::ssl

Bug: T18
Change-Id: Iaac76a740a851bb2bc06c81ef53ef520bf285393
---
M modules/puppetmaster/manifests/ssl.pp
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/87/404587/1

diff --git a/modules/puppetmaster/manifests/ssl.pp 
b/modules/puppetmaster/manifests/ssl.pp
index f93e61d..8509fc6 100644
--- a/modules/puppetmaster/manifests/ssl.pp
+++ b/modules/puppetmaster/manifests/ssl.pp
@@ -38,7 +38,7 @@
 exec { 'setup crl dir':
 require => File["${ssldir}/crl"],
 path=> '/usr/sbin:/usr/bin:/sbin:/bin',
-command => "ln -s ${ssldir}/ca/ca_crl.pem ${ssldir}/crl/$(openssl crl 
-in ${ssldir}/ca/ca_crl.pem -hash -noout).0",
-onlyif  => "test ! -L ${ssldir}/crl/$(openssl crl -in 
${ssldir}/ca/ca_crl.pem -hash -noout).0",
+command => "ln -s ${ssldir}/ca/ca_crl.pem ${ssldir}/crl/$(openssl crl 
-in ${ssldir}/ca/ca_crl.pem -hash -noout).r0",
+onlyif  => "test ! -L ${ssldir}/crl/$(openssl crl -in 
${ssldir}/ca/ca_crl.pem -hash -noout).r0",
 }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/404587
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaac76a740a851bb2bc06c81ef53ef520bf285393
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Herron 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Update verbiage of reading list download notification.

[Dbrant (Code Review)]

Dbrant has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404586 )

Change subject: Update verbiage of reading list download notification.
..

Update verbiage of reading list download notification.

Bug: T184827
Change-Id: I6a7bd3ebb31004bb3e690b879547ffbf88701ac0
---
M app/src/main/res/values/strings.xml
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/86/404586/1

diff --git a/app/src/main/res/values/strings.xml 
b/app/src/main/res/values/strings.xml
index 9189ee5..5569dda 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -416,9 +416,9 @@
 You\'ve been thanked!
 
 Syncing
-Syncing progress
-Syncing %1$d 
articles
-%1$d articles left
+Download progress
+Downloading %1$d 
article(s)
+%1$d article(s) 
left
 Pause
 Resume
 Cancel

-- 
To view, visit https://gerrit.wikimedia.org/r/404586
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6a7bd3ebb31004bb3e690b879547ffbf88701ac0
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaMessages[wmf/1.31.0-wmf.17]: Update access to ORES isModelEnabled()

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404583 )

Change subject: Update access to ORES isModelEnabled()
..


Update access to ORES isModelEnabled()

Follow-up Id73153c0f99f8961311a1bba167387bce2175d1a

The isModelEnabled() function was moved from
ORES\Hooks to ORES\Hooks\Helpers.

This breaks account creation locally.

Change-Id: Ie37420351135d3416974f844ca00c20c81065906
(cherry picked from commit 4ed241c74a11244c4eab2a3bb88654f9b57f55c5)
---
M WikimediaMessages.hooks.php
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Thcipriani: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/WikimediaMessages.hooks.php b/WikimediaMessages.hooks.php
index d9b4cec..3dda811 100644
--- a/WikimediaMessages.hooks.php
+++ b/WikimediaMessages.hooks.php
@@ -1269,10 +1269,11 @@
 * @return bool
 */
private static function isOresAvailable() {
-   if ( !class_exists( 'ORES\\Hooks' ) ) {
+   if ( !class_exists( 'ORES\\Hooks\\Helpers' ) ) {
return false;
}
-   return ORES\Hooks::isModelEnabled( 'damaging' ) || 
ORES\Hooks::isModelEnabled( 'goodfaith' );
+   return ORES\Hooks\Helpers::isModelEnabled( 'damaging' ) ||
+   ORES\Hooks\Helpers::isModelEnabled( 'goodfaith' );
}
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/404583
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie37420351135d3416974f844ca00c20c81065906
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaMessages
Gerrit-Branch: wmf/1.31.0-wmf.17
Gerrit-Owner: Thcipriani 
Gerrit-Reviewer: Sbisson 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: Thcipriani 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Fix help menu icon placement for monobook

[Mooeypoo (Code Review)]

Mooeypoo has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404585 )

Change subject: Fix help menu icon placement for monobook
..

Fix help menu icon placement for monobook

Bug: T184023
Change-Id: I6aa356624c7d9532fc69503f0ab99f0511fc30dc
---
M modules/styles/mw.echo.ui.SpecialHelpMenuWidget.less
1 file changed, 7 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo 
refs/changes/85/404585/1

diff --git a/modules/styles/mw.echo.ui.SpecialHelpMenuWidget.less 
b/modules/styles/mw.echo.ui.SpecialHelpMenuWidget.less
index 779b89d..7d49498 100644
--- a/modules/styles/mw.echo.ui.SpecialHelpMenuWidget.less
+++ b/modules/styles/mw.echo.ui.SpecialHelpMenuWidget.less
@@ -25,6 +25,13 @@
padding: 0.5em;
margin-right: 0;
 
+   .oo-ui-buttonElement-button .oo-ui-iconElement-icon {
+   // OOUI Apex sets 'display:block;' with a huge 
level of specificity
+   // on this icon. We must override it otherwise 
it sticks on its
+   // own line
+   display: inline-block !important;
+   }
+
.oo-ui-labelElement-label {
white-space: normal;
// Width of the popup (300px) minus the

-- 
To view, visit https://gerrit.wikimedia.org/r/404585
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6aa356624c7d9532fc69503f0ab99f0511fc30dc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Gadgets[master]: Localize namespaces to inh

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/403982 )

Change subject: Localize namespaces to inh
..


Localize namespaces to inh

Bug: T184515
Change-Id: I25a832ad3887446b3146101d25d7d7dab73305b2
---
M Gadgets.namespaces.php
1 file changed, 7 insertions(+), 0 deletions(-)

Approvals:
  MaxSem: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Gadgets.namespaces.php b/Gadgets.namespaces.php
index 899d736..417db6d 100644
--- a/Gadgets.namespaces.php
+++ b/Gadgets.namespaces.php
@@ -149,6 +149,13 @@
NS_GADGET_DEFINITION_TALK => 'שיחת_הגדרת_גאדג\'ט',
 ];
 
+$namespaceNames['inh'] = [
+   NS_GADGET => 'Гаджет',
+   NS_GADGET_TALK => 'Гаджет_ювцар',
+   NS_GADGET_DEFINITION => 'Гаджета_къоастадар',
+   NS_GADGET_DEFINITION_TALK => 'Гаджета_къоастадар_дувцар',
+];
+
 $namespaceNames['is'] = [
NS_GADGET => 'Smától',
NS_GADGET_TALK => 'Smátólaspjall',

-- 
To view, visit https://gerrit.wikimedia.org/r/403982
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I25a832ad3887446b3146101d25d7d7dab73305b2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Gadgets
Gerrit-Branch: master
Gerrit-Owner: Urbanecm 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...PageAssessments[master]: Fix wrong class name

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404582 )

Change subject: Fix wrong class name
..


Fix wrong class name

Bug: T185037
Change-Id: I0d2c87a418289dce49054ad8ee4c46b51f39bcda
---
M api/ApiQueryProjectPages.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  MaxSem: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/api/ApiQueryProjectPages.php b/api/ApiQueryProjectPages.php
index dc0c4e5..33edf0d 100644
--- a/api/ApiQueryProjectPages.php
+++ b/api/ApiQueryProjectPages.php
@@ -135,7 +135,7 @@
if ( isset( $params['projects'] ) ) {
// Convert the project names into corresponding IDs
foreach ( $params['projects'] as $project ) {
-   $id = PageAssessmentsBody::getProjectId( 
$project );
+   $id = PageAssessmentsDAO::getProjectId( 
$project );
if ( $id ) {
$this->projectIds[] = $id;
} else {

-- 
To view, visit https://gerrit.wikimedia.org/r/404582
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0d2c87a418289dce49054ad8ee4c46b51f39bcda
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PageAssessments
Gerrit-Branch: master
Gerrit-Owner: Niharika29 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: Thcipriani 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] labs/icinga2[master]: Wikimedia-AI host migration/cleanup

[Zppix (Code Review)]

Zppix has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404584 )

Change subject: Wikimedia-AI host migration/cleanup
..

Wikimedia-AI host migration/cleanup

Change-Id: Ib7ad126c988b6191b90c1d1a639211aa6bdfb06e
---
M templates/hosts.conf.erb
1 file changed, 0 insertions(+), 21 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/labs/icinga2 
refs/changes/84/404584/2

diff --git a/templates/hosts.conf.erb b/templates/hosts.conf.erb
index 772fe1a..f765f73 100644
--- a/templates/hosts.conf.erb
+++ b/templates/hosts.conf.erb
@@ -289,27 +289,6 @@
 }
 }
 
-object Host "ORES-redis01.experimental" {
-import "generic-host"
-
-display_name = "ORES-redis01.experimental"
-address = "ores-redis-01.ores.eqiad.wmflabs"
-vars.os = "Linux OS"
-vars.sla = "24x7"
-vars.check_user = true
-vars.address = "ores-redis-01.ores.eqiad.wmflabs"
-vars.check_disk = true
-vars.host = "ores-redis-01.ores.eqiad.wmflabs"
-vars.notification.ores = true
-vars.check_puppet = true
-
-/* Define notification mail attributes for notification apply rules in 
`notifications.conf`. */
-vars.notification["mail"] = {
-  /* The UserGroup `icingaadmins` is defined in `users.conf`. */
-  groups = [ "icingaadmins" ]
-}
-}
-
 object Host "ORES-redis02.experimental" {
 import "generic-host"
 

-- 
To view, visit https://gerrit.wikimedia.org/r/404584
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib7ad126c988b6191b90c1d1a639211aa6bdfb06e
Gerrit-PatchSet: 2
Gerrit-Project: labs/icinga2
Gerrit-Branch: master
Gerrit-Owner: Zppix 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: DHCP: switch from jessie to stretch as default installer

[Dzahn (Code Review)]

Dzahn has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/399826 )

Change subject: DHCP: switch from jessie to stretch as default installer
..


DHCP: switch from jessie to stretch as default installer

Bug: T182215
Change-Id: I29b529e4ea2a85310df0b9562b2a062b332cfe51
---
M modules/install_server/files/dhcpd/dhcpd.conf
M modules/install_server/files/dhcpd/linux-host-entries.ttyS0-115200
M modules/install_server/files/dhcpd/linux-host-entries.ttyS1-115200
3 files changed, 2,109 insertions(+), 491 deletions(-)

Approvals:
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved




-- 
To view, visit https://gerrit.wikimedia.org/r/399826
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I29b529e4ea2a85310df0b9562b2a062b332cfe51
Gerrit-PatchSet: 8
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 
Gerrit-Reviewer: Alexandros Kosiaris 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: Filippo Giunchedi 
Gerrit-Reviewer: Muehlenhoff 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaMessages[wmf/1.31.0-wmf.17]: Update access to ORES isModelEnabled()

[Thcipriani (Code Review)]

Thcipriani has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404583 )

Change subject: Update access to ORES isModelEnabled()
..

Update access to ORES isModelEnabled()

Follow-up Id73153c0f99f8961311a1bba167387bce2175d1a

The isModelEnabled() function was moved from
ORES\Hooks to ORES\Hooks\Helpers.

This breaks account creation locally.

Change-Id: Ie37420351135d3416974f844ca00c20c81065906
(cherry picked from commit 4ed241c74a11244c4eab2a3bb88654f9b57f55c5)
---
M WikimediaMessages.hooks.php
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaMessages 
refs/changes/83/404583/1

diff --git a/WikimediaMessages.hooks.php b/WikimediaMessages.hooks.php
index d9b4cec..3dda811 100644
--- a/WikimediaMessages.hooks.php
+++ b/WikimediaMessages.hooks.php
@@ -1269,10 +1269,11 @@
 * @return bool
 */
private static function isOresAvailable() {
-   if ( !class_exists( 'ORES\\Hooks' ) ) {
+   if ( !class_exists( 'ORES\\Hooks\\Helpers' ) ) {
return false;
}
-   return ORES\Hooks::isModelEnabled( 'damaging' ) || 
ORES\Hooks::isModelEnabled( 'goodfaith' );
+   return ORES\Hooks\Helpers::isModelEnabled( 'damaging' ) ||
+   ORES\Hooks\Helpers::isModelEnabled( 'goodfaith' );
}
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/404583
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie37420351135d3416974f844ca00c20c81065906
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaMessages
Gerrit-Branch: wmf/1.31.0-wmf.17
Gerrit-Owner: Thcipriani 
Gerrit-Reviewer: Sbisson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaMessages[master]: Update access to ORES isModelEnabled()

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404542 )

Change subject: Update access to ORES isModelEnabled()
..


Update access to ORES isModelEnabled()

Follow-up Id73153c0f99f8961311a1bba167387bce2175d1a

The isModelEnabled() function was moved from
ORES\Hooks to ORES\Hooks\Helpers.

This breaks account creation locally.

Change-Id: Ie37420351135d3416974f844ca00c20c81065906
---
M WikimediaMessages.hooks.php
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/WikimediaMessages.hooks.php b/WikimediaMessages.hooks.php
index d9b4cec..3dda811 100644
--- a/WikimediaMessages.hooks.php
+++ b/WikimediaMessages.hooks.php
@@ -1269,10 +1269,11 @@
 * @return bool
 */
private static function isOresAvailable() {
-   if ( !class_exists( 'ORES\\Hooks' ) ) {
+   if ( !class_exists( 'ORES\\Hooks\\Helpers' ) ) {
return false;
}
-   return ORES\Hooks::isModelEnabled( 'damaging' ) || 
ORES\Hooks::isModelEnabled( 'goodfaith' );
+   return ORES\Hooks\Helpers::isModelEnabled( 'damaging' ) ||
+   ORES\Hooks\Helpers::isModelEnabled( 'goodfaith' );
}
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/404542
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie37420351135d3416974f844ca00c20c81065906
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/WikimediaMessages
Gerrit-Branch: master
Gerrit-Owner: Sbisson 
Gerrit-Reviewer: Awight 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: Ladsgroup 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...PageAssessments[master]: Fix wrong class name

[Niharika29 (Code Review)]

Niharika29 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404582 )

Change subject: Fix wrong class name
..

Fix wrong class name

Bug: T185037
Change-Id: I0d2c87a418289dce49054ad8ee4c46b51f39bcda
---
M api/ApiQueryProjectPages.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PageAssessments 
refs/changes/82/404582/1

diff --git a/api/ApiQueryProjectPages.php b/api/ApiQueryProjectPages.php
index dc0c4e5..33edf0d 100644
--- a/api/ApiQueryProjectPages.php
+++ b/api/ApiQueryProjectPages.php
@@ -135,7 +135,7 @@
if ( isset( $params['projects'] ) ) {
// Convert the project names into corresponding IDs
foreach ( $params['projects'] as $project ) {
-   $id = PageAssessmentsBody::getProjectId( 
$project );
+   $id = PageAssessmentsDAO::getProjectId( 
$project );
if ( $id ) {
$this->projectIds[] = $id;
} else {

-- 
To view, visit https://gerrit.wikimedia.org/r/404582
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0d2c87a418289dce49054ad8ee4c46b51f39bcda
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PageAssessments
Gerrit-Branch: master
Gerrit-Owner: Niharika29 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Show Download button only on Android >= 5 & Chrome >= 41

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/403968 )

Change subject: Show Download button only on Android >= 5 & Chrome >= 41
..


Show Download button only on Android >= 5 & Chrome >= 41

Changes:
 - moved DownloadButtton checks & initialization to separate function
 - introduced supportedNamespaces variable for better readability
 - reorganized huge if(){} statement to set of smaller if's with
 nice comments why this configuration is not supported
 - introduced getAndroidVersion and getChromeVersion helper functions
 - added check to not allow Android < 5 or Chrome < 41
 - added unit tests

Bug: T182059
Change-Id: Ib5064459ee56aed68179389f37b4bc3b5c2c4492
---
M resources/skins.minerva.scripts/DownloadIcon.js
M resources/skins.minerva.scripts/init.js
M tests/qunit/skins.minerva.scripts/test_DownloadIcon.js
3 files changed, 164 insertions(+), 30 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jdlrobson: Looks good to me, approved



diff --git a/resources/skins.minerva.scripts/DownloadIcon.js 
b/resources/skins.minerva.scripts/DownloadIcon.js
index 753ee9a..fab7f3e 100644
--- a/resources/skins.minerva.scripts/DownloadIcon.js
+++ b/resources/skins.minerva.scripts/DownloadIcon.js
@@ -1,9 +1,31 @@
 ( function ( M, track ) {
-
var msg = mw.msg,
MAX_PRINT_TIMEOUT = 3000,
GLYPH = 'mf-download',
-   Icon = M.require( 'mobile.startup/Icon' );
+   Icon = M.require( 'mobile.startup/Icon' ),
+   browser = M.require( 'mobile.startup/Browser' ).getSingleton();
+
+   /**
+* Helper function to retreive the Android version
+* @ignore
+* @param {String} userAgent User Agent
+* @return {Integer}
+*/
+   function getAndroidVersion( userAgent ) {
+   var match = userAgent.toLowerCase().match( /android\s(\d\.]*)/ 
);
+   return match ? parseInt( match[1] ) : false;
+   }
+
+   /**
+* Helper function to retrieve the Chrome/Chromium version
+* @ignore
+* @param {String} userAgent User Agent
+* @return {Integer}
+*/
+   function getChromeVersion( userAgent ) {
+   var match = userAgent.toLowerCase().match( 
/chrom(e|ium)\/(\d+)\./ );
+   return match ? parseInt( match[2] ) : false;
+   }
 
/**
 * A download icon for triggering print functionality
@@ -11,11 +33,13 @@
 * @extends Icon
 *
 * @param {Skin} skin
+* @param {Number[]} [supportedNamespaces]
 * @constructor
 */
-   function DownloadIcon( skin ) {
+   function DownloadIcon( skin, supportedNamespaces ) {
var options = {};
this.skin = skin;
+   this.supportedNamespaces = supportedNamespaces || [ 0 ];
options.tagName = 'li';
options.title = msg( 'minerva-download' );
options.name = GLYPH;
@@ -24,6 +48,34 @@
 
OO.mfExtend( DownloadIcon, Icon, {
/**
+* Checks whether DownloadIcon is available for given user agent
+* @param {string} userAgent User agent
+* @return {Boolean}
+   */
+   isAvailable: function ( userAgent ) {
+   var androidVersion = getAndroidVersion( userAgent ),
+   chromeVersion = getChromeVersion( userAgent ),
+   page = this.skin.page;
+
+   // Download button is restricted to certain namespaces 
T181152.
+   // Defaults to 0, in case cached JS has been served.
+   if ( this.supportedNamespaces.indexOf( 
page.getNamespaceId() ) === -1 ||
+   page.isMainPage() ) {
+   // namespace is not supported or it's a main 
page
+   return false;
+   }
+
+   if ( browser.isIos() || chromeVersion === false ) {
+   // we support only chrome/chromium on 
desktop/android
+   return false;
+   }
+   if ( ( androidVersion && androidVersion < 5 ) || 
chromeVersion < 41 ) {
+   return false;
+   }
+   return true;
+   },
+
+   /**
 * Replace download icon with a spinner
 */
showSpinner: function () {
diff --git a/resources/skins.minerva.scripts/init.js 
b/resources/skins.minerva.scripts/init.js
index 327399f..ea1ac1a 100644
--- a/resources/skins.minerva.scripts/init.js
+++ b/resources/skins.minerva.scripts/init.js
@@ -1,6 +1,5 @@
-( function ( M, track, $ ) {
+( function ( M, track, config, $ ) {
 

[MediaWiki-commits] [Gerrit] mediawiki...OdbcDatabase[master]: Don't use deprecated DatabaseMysql

[Seb35 (Code Review)]

Seb35 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404543 )

Change subject: Don't use deprecated DatabaseMysql
..

Don't use deprecated DatabaseMysql

Bug: T120333
Change-Id: I6c2c37b6393848268f5f67a333c95819c149d337
---
M OdbcDatabase.body.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/OdbcDatabase 
refs/changes/43/404543/1

diff --git a/OdbcDatabase.body.php b/OdbcDatabase.body.php
index 42da7c2..db76ba8 100644
--- a/OdbcDatabase.body.php
+++ b/OdbcDatabase.body.php
@@ -253,7 +253,7 @@
 * @param $fname string
 * @return false|array
 */
-   function indexInfo( $table, $index, $fname = 'DatabaseMysql::indexInfo' 
) {
+   function indexInfo( $table, $index, $fname = 
'DatabaseMysqli::indexInfo' ) {
/*
 * For now, always return false. Not sure how
 * to generically find this info using no

-- 
To view, visit https://gerrit.wikimedia.org/r/404543
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6c2c37b6393848268f5f67a333c95819c149d337
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OdbcDatabase
Gerrit-Branch: master
Gerrit-Owner: Seb35 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Also keep style attributes when flattening elements

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404496 )

Change subject: Also keep style attributes when flattening elements
..


Also keep style attributes when flattening elements

See comment https://phabricator.wikimedia.org/T177007#3899976.

Bug: T177007
Change-Id: I3703875bcf1cc924c0ec9bb5a4aa165efbb35d0d
---
M lib/transformations/flattenElements.js
M test/lib/transformations/flattenElements.test.js
2 files changed, 31 insertions(+), 8 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jdlrobson: Looks good to me, approved



diff --git a/lib/transformations/flattenElements.js 
b/lib/transformations/flattenElements.js
index f3d917f..0ee39fc 100644
--- a/lib/transformations/flattenElements.js
+++ b/lib/transformations/flattenElements.js
@@ -1,24 +1,41 @@
 'use strict';
 
-const KEEP_ATTRIBUTE = 'class';
+const KEEP_ATTRIBUTES = [ 'class', 'style' ];
+
+/**
+ * @param {!Element} element the element to copy attributes from
+ * @param {!Array} nameArray an array of attribute names
+ * @return {boolean} true if at least one of the attribute names exist
+ * on the element false otherwise.
+ */
+function hasAttribute(element, nameArray) {
+for (let i = 0; i < nameArray.length; i++) {
+if (element.getAttribute(nameArray[i])) {
+return true;
+}
+}
+return false;
+}
 
 /**
  * Copies only select attributes from one DOM element to another.
  * @param {!Element} oldElement the element to copy attributes from
  * @param {!Element} newElement the element to copy attributes to
- * @param {!String} name the name of the attribute
+ * @param {!Array} nameArray an array of attribute names
  */
-function copyAttribute(oldElement, newElement, name) {
-if (oldElement.getAttribute(name)) {
-newElement.setAttribute(name, oldElement.getAttribute(name));
-}
+function copyAttributes(oldElement, newElement, nameArray) {
+nameArray.forEach((name) => {
+if (oldElement.getAttribute(name)) {
+newElement.setAttribute(name, oldElement.getAttribute(name));
+}
+});
 }
 
 function createReplacementNode(oldElement, document) {
-if (oldElement.getAttribute(KEEP_ATTRIBUTE)) {
+if (hasAttribute(oldElement, KEEP_ATTRIBUTES)) {
 const spanElement = document.createElement('span');
 spanElement.innerHTML = oldElement.innerHTML;
-copyAttribute(oldElement, spanElement, KEEP_ATTRIBUTE);
+copyAttributes(oldElement, spanElement, KEEP_ATTRIBUTES);
 return spanElement;
 } else {
 return document.createTextNode(oldElement.innerHTML);
diff --git a/test/lib/transformations/flattenElements.test.js 
b/test/lib/transformations/flattenElements.test.js
index 4bd1726..3bc1c6c 100644
--- a/test/lib/transformations/flattenElements.test.js
+++ b/test/lib/transformations/flattenElements.test.js
@@ -11,6 +11,12 @@
 assert.deepEqual(document.body.innerHTML, 'foo');
 });
 
+it('replaces a with span, keeps style attribute', () => {
+const document = domino.createDocument('foo');
+flattenElements(document, 'a');
+assert.deepEqual(document.body.innerHTML, 'foo');
+});
+
 it('replaces a tag with plain text if no attributes to keep', () => {
 const document = domino.createDocument('foo');
 flattenElements(document, 'a');

-- 
To view, visit https://gerrit.wikimedia.org/r/404496
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3703875bcf1cc924c0ec9bb5a4aa165efbb35d0d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: BearND 
Gerrit-Reviewer: Fjalapeno 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Mholloway 
Gerrit-Reviewer: Mhurd 
Gerrit-Reviewer: Ppchelko 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Flatten DOM anchors if no attributes kept

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/403977 )

Change subject: Flatten DOM anchors if no attributes kept
..


Flatten DOM anchors if no attributes kept

The flattenElements method previously did not really flatten in a DOM
sense because it changed the  tags to another element ().
This patch proposes to really flatten the  tags to plain text,
but only if there is no (class) attribute to be retained.

Bug: T177007
Change-Id: Ib2e63e665d62e8a80215c456c7832a8e965caad1
---
M lib/transformations/flattenElements.js
A test/lib/transformations/flattenElements.test.js
M test/lib/transformations/summarize.js
3 files changed, 62 insertions(+), 19 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jdlrobson: Looks good to me, approved



diff --git a/lib/transformations/flattenElements.js 
b/lib/transformations/flattenElements.js
index 42f9ea9..f3d917f 100644
--- a/lib/transformations/flattenElements.js
+++ b/lib/transformations/flattenElements.js
@@ -1,21 +1,45 @@
 'use strict';
 
+const KEEP_ATTRIBUTE = 'class';
+
 /**
- * Replace all elements in Document `content` that match the
- * css selector, replacing them with span tags.
- * @param {!Document} content
+ * Copies only select attributes from one DOM element to another.
+ * @param {!Element} oldElement the element to copy attributes from
+ * @param {!Element} newElement the element to copy attributes to
+ * @param {!String} name the name of the attribute
+ */
+function copyAttribute(oldElement, newElement, name) {
+if (oldElement.getAttribute(name)) {
+newElement.setAttribute(name, oldElement.getAttribute(name));
+}
+}
+
+function createReplacementNode(oldElement, document) {
+if (oldElement.getAttribute(KEEP_ATTRIBUTE)) {
+const spanElement = document.createElement('span');
+spanElement.innerHTML = oldElement.innerHTML;
+copyAttribute(oldElement, spanElement, KEEP_ATTRIBUTE);
+return spanElement;
+} else {
+return document.createTextNode(oldElement.innerHTML);
+}
+}
+
+/**
+ * Replaces all elements in the given Document which match the
+ * CSS selector, replacing them with span tags or text.
+ * If the resulting span tag doesn't have any attributes then
+ * the element is replaced with a TextNode of the same content.
+ * The main purpose of this is to disable certain  tags.
+ * @param {!Document} document
  * @param {string} selector
  */
-function flattenElements(content, selector) {
-const elements = content.querySelectorAll(selector);
+function flattenElements(document, selector) {
+const elements = document.querySelectorAll(selector);
 for (let i = 0; i < elements.length; i++) {
-const element = elements[i];
-const replacementSpan = content.createElement('span');
-replacementSpan.innerHTML = element.innerHTML;
-if (element.getAttribute('class')) {
-replacementSpan.setAttribute('class', 
element.getAttribute('class'));
-}
-element.parentNode.replaceChild(replacementSpan, element);
+const oldElement = elements[i];
+const newNode = createReplacementNode(oldElement, document);
+oldElement.parentNode.replaceChild(newNode, oldElement);
 }
 }
 
diff --git a/test/lib/transformations/flattenElements.test.js 
b/test/lib/transformations/flattenElements.test.js
new file mode 100644
index 000..4bd1726
--- /dev/null
+++ b/test/lib/transformations/flattenElements.test.js
@@ -0,0 +1,19 @@
+"use strict";
+
+const domino = require('domino');
+const assert = require('./../../utils/assert.js');
+const flattenElements = 
require('./../../../lib/transformations/flattenElements');
+
+describe('lib:flattenElements', () => {
+it('replaces a with span, keeps class attribute', () => {
+const document = domino.createDocument('foo');
+flattenElements(document, 'a');
+assert.deepEqual(document.body.innerHTML, 'foo');
+});
+
+it('replaces a tag with plain text if no attributes to keep', () => {
+const document = domino.createDocument('foo');
+flattenElements(document, 'a');
+assert.deepEqual(document.body.innerHTML, 'foo');
+});
+});
diff --git a/test/lib/transformations/summarize.js 
b/test/lib/transformations/summarize.js
index fe90123..ec25458 100644
--- a/test/lib/transformations/summarize.js
+++ b/test/lib/transformations/summarize.js
@@ -36,7 +36,7 @@
 // Should flatten links
 [
 'This is some content with a link.',
-'This is some content with a link.'
+'This is some content with a link.'
 ],
 // Should strip .noexcerpt
 [
@@ -125,22 +125,22 @@
 // Content inside Cantonese parentheticals are also stripped
 [
 '蔡英文（Tsai 
Ing-wen，1956年8月31號—）係現任中華民國總統，臺灣學者同埋政治人，民主進步黨主席。',
-   

[MediaWiki-commits] [Gerrit] mediawiki...Vector[master]: OOUI: Remove confusing 'position' override

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404396 )

Change subject: OOUI: Remove confusing 'position' override
..


OOUI: Remove confusing 'position' override

Vector is the only skin that does this, setting 'position: relative'
for .oo-ui-windowManager-modal (normally 'position: static') and for
.ve-ui-overlay-global (normally 'position: absolute').

The override for .oo-ui-windowManager-modal caused it to create a new
stacking context, which is the only reason the 'z-index' override
worked. Use the right selector to override 'z-index' instead.

The override for .ve-ui-overlay-global was completely pointless and
it's surprising that it never broke anything.

Change-Id: Icd1dec43e2da9ef2090b18145099838de3a7890a
---
M skinStyles/ooui.less
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  jenkins-bot: Verified
  VolkerE: Looks good to me, approved



diff --git a/skinStyles/ooui.less b/skinStyles/ooui.less
index 12123b2..fa03233 100644
--- a/skinStyles/ooui.less
+++ b/skinStyles/ooui.less
@@ -1,9 +1,8 @@
 @import '../variables.less';
 
-.oo-ui-windowManager-modal,
+.skin-vector .oo-ui-windowManager-modal > .oo-ui-dialog,
 .skin-vector .ve-ui-overlay-global {
z-index: 101;
-   position: relative;
 }
 
 .oo-ui-defaultOverlay {

-- 
To view, visit https://gerrit.wikimedia.org/r/404396
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icd1dec43e2da9ef2090b18145099838de3a7890a
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/skins/Vector
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: Esanders 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: VolkerE 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits