[MediaWiki-commits] [Gerrit] Fixed handling for errors in property types - change (mediawiki...SemanticMediaWiki[master])

2012-10-15 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged.

Change subject: Fixed handling for errors in property types
..


Fixed handling for errors in property types

The old code would lead to spurious errors when a property is assigned an 
erroneous type during the same PHP run in which this property type is needed.

Change-Id: Ifb170c1d48244ad4b8cebe82def8d707130b4ad8
---
M includes/dataitems/SMW_DI_Property.php
1 file changed, 6 insertions(+), 1 deletion(-)

Approvals:
  Markus Kroetzsch: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/28055
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb170c1d48244ad4b8cebe82def8d707130b4ad8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org
Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Rewritten access/caching layer for smw_ids - change (mediawiki...SemanticMediaWiki[master])

2012-10-15 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged.

Change subject: Rewritten access/caching layer for smw_ids
..


Rewritten access/caching layer for smw_ids

The new implementation significantly reduces the amount of SQL queries that 
need to be issues to retrieve IDs and their sortkeys. Some smaller issues have 
been fixed while restructuring the related code.

Change-Id: I8216857311dccf9f8a123596fa1fabd9bc14b6d3
---
M includes/SMW_Setup.php
M includes/storage/SQLStore/SMW_DIHandler_Container.php
M includes/storage/SQLStore/SMW_DIHandler_WikiPage.php
M includes/storage/SQLStore/SMW_SQLStore3.php
D includes/storage/SQLStore/SMW_SQLStore3IdCache.php
M includes/storage/SQLStore/SMW_SQLStore3_Queries.php
M includes/storage/SQLStore/SMW_SQLStore3_Readers.php
M includes/storage/SQLStore/SMW_SQLStore3_SetupHandlers.php
M includes/storage/SQLStore/SMW_SQLStore3_Writers.php
A includes/storage/SQLStore/SMW_Sql3SmwIds.php
10 files changed, 575 insertions(+), 435 deletions(-)

Approvals:
  Markus Kroetzsch: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/28057
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8216857311dccf9f8a123596fa1fabd9bc14b6d3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org
Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fixed outdated use of SMWDIHandlerFactory - change (mediawiki...SemanticMediaWiki[master])

2012-10-14 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review.

Change subject: Fixed outdated use of SMWDIHandlerFactory
..

Fixed outdated use of SMWDIHandlerFactory

Change-Id: I1eca03f9b7801fd716a9042f33e5c4dc4c038e0e
---
M includes/storage/SQLStore/SMW_SQLStore3_Writers.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki 
refs/changes/32/27932/1
--
To view, visit https://gerrit.wikimedia.org/r/27932
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1eca03f9b7801fd716a9042f33e5c4dc4c038e0e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fixed outdated use of SMWDIHandlerFactory - change (mediawiki...SemanticMediaWiki[master])

2012-10-14 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review.

Change subject: Fixed outdated use of SMWDIHandlerFactory
..

Fixed outdated use of SMWDIHandlerFactory

Change-Id: Id136a4874efbc612a294db2dea94cce7b79e35c3
---
M maintenance/SMW_migration.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki 
refs/changes/33/27933/1
--
To view, visit https://gerrit.wikimedia.org/r/27933
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id136a4874efbc612a294db2dea94cce7b79e35c3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Check $dbkey array size when loading DIs from DB - change (mediawiki...SemanticMediaWiki[master])

2012-10-14 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review.

Change subject: Check $dbkey array size when loading DIs from DB
..

Check $dbkey array size when loading DIs from DB

Change-Id: Iee1a178581bbf33e330a0591d382eaa1210b3528
---
M includes/storage/SQLStore/SMW_DIHandler_Blob.php
M includes/storage/SQLStore/SMW_DIHandler_Bool.php
M includes/storage/SQLStore/SMW_DIHandler_Concept.php
M includes/storage/SQLStore/SMW_DIHandler_GeoCoord.php
M includes/storage/SQLStore/SMW_DIHandler_String.php
M includes/storage/SQLStore/SMW_DIHandler_Time.php
M includes/storage/SQLStore/SMW_DIHandler_WikiPage.php
M includes/storage/SQLStore/SMW_DataItemHandler.php
8 files changed, 32 insertions(+), 100 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki 
refs/changes/34/27934/1
--
To view, visit https://gerrit.wikimedia.org/r/27934
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee1a178581bbf33e330a0591d382eaa1210b3528
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fixed outdated use of SMWDIHandlerFactory - change (mediawiki...SemanticMediaWiki[master])

2012-10-14 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged.

Change subject: Fixed outdated use of SMWDIHandlerFactory
..


Fixed outdated use of SMWDIHandlerFactory

Change-Id: I1eca03f9b7801fd716a9042f33e5c4dc4c038e0e
---
M includes/storage/SQLStore/SMW_SQLStore3_Writers.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Markus Kroetzsch: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/27932
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1eca03f9b7801fd716a9042f33e5c4dc4c038e0e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org
Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fixed outdated use of SMWDIHandlerFactory - change (mediawiki...SemanticMediaWiki[master])

2012-10-14 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged.

Change subject: Fixed outdated use of SMWDIHandlerFactory
..


Fixed outdated use of SMWDIHandlerFactory

Change-Id: Id136a4874efbc612a294db2dea94cce7b79e35c3
---
M maintenance/SMW_migration.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Markus Kroetzsch: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/27933
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id136a4874efbc612a294db2dea94cce7b79e35c3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org
Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Check $dbkey array size when loading DIs from DB - change (mediawiki...SemanticMediaWiki[master])

2012-10-14 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged.

Change subject: Check $dbkey array size when loading DIs from DB
..


Check $dbkey array size when loading DIs from DB

Change-Id: Iee1a178581bbf33e330a0591d382eaa1210b3528
---
M includes/storage/SQLStore/SMW_DIHandler_Blob.php
M includes/storage/SQLStore/SMW_DIHandler_Bool.php
M includes/storage/SQLStore/SMW_DIHandler_Concept.php
M includes/storage/SQLStore/SMW_DIHandler_GeoCoord.php
M includes/storage/SQLStore/SMW_DIHandler_String.php
M includes/storage/SQLStore/SMW_DIHandler_Time.php
M includes/storage/SQLStore/SMW_DIHandler_WikiPage.php
M includes/storage/SQLStore/SMW_DataItemHandler.php
8 files changed, 32 insertions(+), 100 deletions(-)

Approvals:
  Markus Kroetzsch: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/27934
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iee1a178581bbf33e330a0591d382eaa1210b3528
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org
Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Improve subobject handling in SMWSemanticData - change (mediawiki...SemanticMediaWiki[master])

2012-10-14 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review.

Change subject: Improve subobject handling in SMWSemanticData
..

Improve subobject handling in SMWSemanticData

This change impoves error handling and updates the documentation of the new 
functionality. It also fixes a typo in the container DI handler.

Change-Id: I1d978309648384749a4deff08c0ca0e8d5959352
---
M includes/SMW_SemanticData.php
M includes/storage/SQLStore/SMW_DIHandler_Container.php
2 files changed, 47 insertions(+), 22 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki 
refs/changes/40/27940/1
--
To view, visit https://gerrit.wikimedia.org/r/27940
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d978309648384749a4deff08c0ca0e8d5959352
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Improve subobject handling in SMWSemanticData - change (mediawiki...SemanticMediaWiki[master])

2012-10-14 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged.

Change subject: Improve subobject handling in SMWSemanticData
..


Improve subobject handling in SMWSemanticData

This change impoves error handling and updates the documentation of the new 
functionality. It also fixes a typo in the container DI handler.

Change-Id: I1d978309648384749a4deff08c0ca0e8d5959352
---
M includes/SMW_SemanticData.php
M includes/storage/SQLStore/SMW_DIHandler_Container.php
2 files changed, 47 insertions(+), 22 deletions(-)

Approvals:
  Markus Kroetzsch: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/27940
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1d978309648384749a4deff08c0ca0e8d5959352
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org
Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix handling of Container objects. - change (mediawiki...SemanticMediaWiki[master])

2012-10-14 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged.

Change subject: Fix handling of Container objects.
..


Fix handling of Container objects.

The following code introduces new handling method of Container DI objects,
SemanticData stores Containers in an array instead of passing them around as 
property-values, the writers handle these Subobjects separately on their own.
The code is divided into small functions to make things cleaner and 
self-explanatory.

This also fixes some very minor errors in previous commits

Patchset 4: Not deleting smw_ids, these need special code which has to
come in a separate commit. Not replacing DIContainers with DIWikiPages
as this leads to difficult handling when removing Containers. Removing
DIContainers is changed as per comments.

Patchset 5: Containers are replaced with WikiPages after their data is
copied to subSemanticData, all methods handle subSemanticData too.

Patchset 6: Fix small errors with the code, proper subject compatibility
checks
'''Tested to work fine'''

Change-Id: Ib407a10fe7c637b151ea9e342eb9bcb788588eed
---
M includes/SMW_SemanticData.php
M includes/storage/SQLStore/SMW_SQLStore3Table.php
M includes/storage/SQLStore/SMW_SQLStore3_Writers.php
3 files changed, 173 insertions(+), 36 deletions(-)

Approvals:
  Markus Kroetzsch: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/19378
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib407a10fe7c637b151ea9e342eb9bcb788588eed
Gerrit-PatchSet: 7
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Nischayn22 nischay...@gmail.com
Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org
Gerrit-Reviewer: Mwjames jamesin.hongkon...@gmail.com
Gerrit-Reviewer: Nischayn22 nischay...@gmail.com
Gerrit-Reviewer: Yaron Koren yaro...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Minor change to avoid duplicate error reporting - change (mediawiki...SemanticMediaWiki[master])

2012-08-21 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review.

Change subject: Minor change to avoid duplicate error reporting
..

Minor change to avoid duplicate error reporting

Stop processing when finding errors in emails and
phone numbers.

Change-Id: If2c43b3aa4bdeeb04b3c36082a13bcf3650b9213
---
M includes/datavalues/SMW_DV_URI.php
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki 
refs/changes/72/20872/1
--
To view, visit https://gerrit.wikimedia.org/r/20872
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If2c43b3aa4bdeeb04b3c36082a13bcf3650b9213
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Minor change to avoid duplicate error reporting - change (mediawiki...SemanticMediaWiki[master])

2012-08-21 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged.

Change subject: Minor change to avoid duplicate error reporting
..


Minor change to avoid duplicate error reporting

Stop processing when finding errors in emails and
phone numbers.

Change-Id: If2c43b3aa4bdeeb04b3c36082a13bcf3650b9213
---
M includes/datavalues/SMW_DV_URI.php
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Markus Kroetzsch: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/20872
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If2c43b3aa4bdeeb04b3c36082a13bcf3650b9213
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org
Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] removing the Factory class for DIHandlers - change (mediawiki...SemanticMediaWiki[master])

2012-08-15 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged.

Change subject: removing the Factory class for DIHandlers
..


removing the Factory class for DIHandlers

This commit removes the factory class for DIHandlers
instead the handlers are created by the store3 and cached as well
to ensure efficiency.
However, some places the Store3 itself is created newly and this
leads to inefficiency but this has to be fixed in a separate commit.

Patchset3: Modified as per comments, the
store object is no more created anywhere on demand and is passed

Patchset4: Type hinting and direct access

Change-Id: Ibf0bb1ff1e27362a58634f45a74f2de609e053aa
---
M includes/SMW_Setup.php
M includes/storage/SQLStore/SMW_DIHandler_Blob.php
M includes/storage/SQLStore/SMW_DIHandler_Bool.php
M includes/storage/SQLStore/SMW_DIHandler_Concept.php
M includes/storage/SQLStore/SMW_DIHandler_Container.php
M includes/storage/SQLStore/SMW_DIHandler_GeoCoord.php
M includes/storage/SQLStore/SMW_DIHandler_Number.php
M includes/storage/SQLStore/SMW_DIHandler_Property.php
M includes/storage/SQLStore/SMW_DIHandler_String.php
M includes/storage/SQLStore/SMW_DIHandler_Time.php
M includes/storage/SQLStore/SMW_DIHandler_URI.php
M includes/storage/SQLStore/SMW_DIHandler_WikiPage.php
M includes/storage/SQLStore/SMW_DataItemHandler.php
M includes/storage/SQLStore/SMW_SQLStore3.php
M includes/storage/SQLStore/SMW_SQLStore3Table.php
M includes/storage/SQLStore/SMW_SQLStore3_Queries.php
M includes/storage/SQLStore/SMW_SQLStore3_Readers.php
M includes/storage/SQLStore/SMW_SQLStore3_SetupHandlers.php
M includes/storage/SQLStore/SMW_SQLStore3_Writers.php
M includes/storage/SQLStore/SMW_Sql3StubSemanticData.php
20 files changed, 139 insertions(+), 96 deletions(-)

Approvals:
  Markus Kroetzsch: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/19389
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf0bb1ff1e27362a58634f45a74f2de609e053aa
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Nischayn22 nischay...@gmail.com
Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org
Gerrit-Reviewer: Nischayn22 nischay...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix minor issues - change (mediawiki...SemanticMediaWiki[master])

2012-08-05 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged.

Change subject: Fix minor issues
..


Fix minor issues

Not using swmfgetStore() in Store3
updating counts for redirects. and small improvements to prepareDBUpdates()

Change-Id: I305b28d60c81f6425327970a57d1f409a218ed08
---
M includes/storage/SQLStore/SMW_DIHandler_Container.php
M includes/storage/SQLStore/SMW_DIHandler_WikiPage.php
M includes/storage/SQLStore/SMW_SQLStore3_Writers.php
3 files changed, 27 insertions(+), 14 deletions(-)

Approvals:
  Markus Kroetzsch: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/17486
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I305b28d60c81f6425327970a57d1f409a218ed08
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Nischayn22 nischay...@gmail.com
Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org
Gerrit-Reviewer: Nischayn22 nischay...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] make Properties with sortkey. - change (mediawiki...SemanticMediaWiki[master])

2012-07-31 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged.

Change subject: make Properties with sortkey.
..


make Properties with sortkey.

This should also update the sortkeys but needs to be checked

Change-Id: I2635069db46153bba6c39aa085c705dfdc046ac5
---
M includes/storage/SQLStore/SMW_SQLStore3.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Markus Kroetzsch: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/16947
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2635069db46153bba6c39aa085c705dfdc046ac5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Nischayn22 nischay...@gmail.com
Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Extended #subobject parser function with support for value l... - change (mediawiki...SemanticMediaWiki[master])

2012-07-30 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review.

Change subject: Extended #subobject parser function with support for value 
lists, to be entered by using | as a separator between many values that do not 
contain =. Values that contain = still need to be entered by repeating the 
property before the value, which continues
..

Extended #subobject parser function with support for value lists,
to be entered by using | as a separator between many values that
do not contain =. Values that contain = still need to be entered
by repeating the property before the value, which continues to
work in general for adding multiple values for one property to a
subobject.

Change-Id: I0fbf68ce17062b0dc85128a221cd296b895adef7
---
M includes/parserhooks/SMW_Subobject.php
1 file changed, 10 insertions(+), 2 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki 
refs/changes/63/16963/1
--
To view, visit https://gerrit.wikimedia.org/r/16963
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0fbf68ce17062b0dc85128a221cd296b895adef7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Extended #subobject parser function with support for value l... - change (mediawiki...SemanticMediaWiki[master])

2012-07-30 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged.

Change subject: Extended #subobject parser function with support for value 
lists, to be entered by using | as a separator between many values that do not 
contain =. Values that contain = still need to be entered by repeating the 
property before the value, which continues
..


Extended #subobject parser function with support for value lists,
to be entered by using | as a separator between many values that
do not contain =. Values that contain = still need to be entered
by repeating the property before the value, which continues to
work in general for adding multiple values for one property to a
subobject.

Change-Id: I0fbf68ce17062b0dc85128a221cd296b895adef7
---
M includes/parserhooks/SMW_Subobject.php
1 file changed, 10 insertions(+), 2 deletions(-)

Approvals:
  Markus Kroetzsch: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/16963
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0fbf68ce17062b0dc85128a221cd296b895adef7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org
Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] small change- not needed to update counts anymore for concep... - change (mediawiki...SemanticMediaWiki[master])

2012-07-29 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged.

Change subject: small change- not needed to update counts anymore for concepts 
specifically
..


small change- not needed to update counts anymore for concepts specifically

Change-Id: I39795ba7aaeb01b4a14a45796addf26219181d12
---
M includes/storage/SQLStore/SMW_SQLStore3_Writers.php
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  Markus Kroetzsch: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/16911
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I39795ba7aaeb01b4a14a45796addf26219181d12
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Nischayn22 nischay...@gmail.com
Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Add anonymous auto-numbering for subobjects that don't speci... - change (mediawiki...SemanticMediaWiki[master])

2012-07-29 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged.

Change subject: Add anonymous auto-numbering for subobjects that don't specify 
their identifier (bug 36634)
..


Add anonymous auto-numbering for subobjects
that don't specify their identifier (bug 36634)

## Note
This change will add an auto-numbering feature for all subobjects
that don't come with there own idenifier/name.

Right now it is for all cases of $subobjectName === '' but one could force
the user to $subobjectName === '#' to state explicitly to use
autonumbering in either case this takes away huge burden with larger
data sets where up til now each had to be assigned his own identifier.

## Patchsets
- 2 as per suggestion use a value dependant md4 hash instead of a static
number
- 3 ok, no fancy handling, works as with an identifier that when user
doesn't provide content a subobject nevertheless is created without
content
- 4 changed # to -

Change-Id: I076c323159c38d622dd15d1dc970a5bfea584906
---
M RELEASE-NOTES
M includes/parserhooks/SMW_Subobject.php
2 files changed, 8 insertions(+), 2 deletions(-)

Approvals:
  Markus Kroetzsch: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/16884
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I076c323159c38d622dd15d1dc970a5bfea584906
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Mwjames jamesin.hongkon...@gmail.com
Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org
Gerrit-Reviewer: Mwjames jamesin.hongkon...@gmail.com
Gerrit-Reviewer: Yaron Koren yaro...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Better conc handling - change (mediawiki...SemanticMediaWiki[master])

2012-07-29 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged.

Change subject: Better conc handling
..


Better conc handling

Added todo and improved handling of concepts
Patchset2: not creating concepts for subobjects in Concept pages
This is for the change in other commit (recursive handling of Containers)

Change-Id: Ib63f1ec5595c472fa5228dd135d6bec536c44509
---
M includes/storage/SQLStore/SMW_SQLStore3_Writers.php
1 file changed, 43 insertions(+), 38 deletions(-)

Approvals:
  Markus Kroetzsch: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/16753
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib63f1ec5595c472fa5228dd135d6bec536c44509
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Nischayn22 nischay...@gmail.com
Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org
Gerrit-Reviewer: Nischayn22 nischay...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Tiny change for more compact code (minor) - change (mediawiki...SemanticMediaWiki[master])

2012-07-29 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review.

Change subject: Tiny change for more compact code (minor)
..

Tiny change for more compact code (minor)

Change-Id: I99338fc8a2597425cda2865435aaa75657723ff1
---
M includes/storage/SQLStore/SMW_SQLStore3.php
1 file changed, 16 insertions(+), 48 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki 
refs/changes/12/16912/1
--
To view, visit https://gerrit.wikimedia.org/r/16912
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I99338fc8a2597425cda2865435aaa75657723ff1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Tiny change for more compact code (minor) - change (mediawiki...SemanticMediaWiki[master])

2012-07-29 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged.

Change subject: Tiny change for more compact code (minor)
..


Tiny change for more compact code (minor)

Change-Id: I99338fc8a2597425cda2865435aaa75657723ff1
---
M includes/storage/SQLStore/SMW_SQLStore3.php
1 file changed, 16 insertions(+), 48 deletions(-)

Approvals:
  Markus Kroetzsch: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/16912
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I99338fc8a2597425cda2865435aaa75657723ff1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org
Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Implementation of Property count - change (mediawiki...SemanticMediaWiki[master])

2012-07-26 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged.

Change subject: Implementation of Property count
..


Implementation of Property count

Patchset1 - implemented getOldSemanticCount() and general workflow.
Patchset2 - modified workflow,removed getOldSemanticCount() and added oldData
Patchset3 - mostly done with the diff generation and counts, need to do the db  
stuff now
Patchset4 - modified as per comments from Jeroen
Patchset5 - modified as per comments from Markus,
Patchset6 - fixed bugs, and removed array_udiff() which caused useless checks
and caused many problems, count and diff worksforme

Patchset7 - moved some code, fixed other issues according to comments

Change-Id: Ie4d19b07e560877eb2ac884a0be29ceca9cd6cda
---
M includes/SMW_SemanticData.php
M includes/dataitems/SMW_DI_Blob.php
M includes/dataitems/SMW_DI_Bool.php
M includes/dataitems/SMW_DI_Concept.php
M includes/dataitems/SMW_DI_Container.php
M includes/dataitems/SMW_DI_Error.php
M includes/dataitems/SMW_DI_GeoCoord.php
M includes/dataitems/SMW_DI_Number.php
M includes/dataitems/SMW_DI_Property.php
M includes/dataitems/SMW_DI_String.php
M includes/dataitems/SMW_DI_Time.php
M includes/dataitems/SMW_DI_URI.php
M includes/dataitems/SMW_DI_WikiPage.php
M includes/dataitems/SMW_DataItem.php
M includes/storage/SQLStore/SMW_SQLStore3.php
M includes/storage/SQLStore/SMW_SQLStore3_Readers.php
M includes/storage/SQLStore/SMW_SQLStore3_SetupHandlers.php
M includes/storage/SQLStore/SMW_SQLStore3_Writers.php
M includes/storage/SQLStore/SMW_Sql3StubSemanticData.php
19 files changed, 552 insertions(+), 276 deletions(-)

Approvals:
  Markus Kroetzsch: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/16111
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie4d19b07e560877eb2ac884a0be29ceca9cd6cda
Gerrit-PatchSet: 7
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Nischayn22 nischay...@gmail.com
Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org
Gerrit-Reviewer: Nischayn22 nischay...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Remvoing special Sortkeys for predefined props - change (mediawiki...SemanticMediaWiki[master])

2012-07-23 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged.

Change subject: Remvoing special Sortkeys for predefined props
..


Remvoing special Sortkeys for predefined props

removing temproarily SMW_SQL3_SMWPREDEFIW (though it isn't used anywhere lets 
just comment it for the moment)
- Added a TODO
-removed completely SMW_SQL3_SMWPREDEFIW
-removed extra unnecessary checks
-modified as per comments

Change-Id: Icb06060de912d2c1b5d7dcba7cf644670f1704fe
---
M includes/storage/SQLStore/SMW_SQLStore3.php
M includes/storage/SQLStore/SMW_SQLStore3_SetupHandlers.php
M includes/storage/SQLStore/SMW_SQLStore3_SpecialPageHandlers.php
3 files changed, 6 insertions(+), 13 deletions(-)

Approvals:
  Markus Kroetzsch: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/16106
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icb06060de912d2c1b5d7dcba7cf644670f1704fe
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Nischayn22 nischay...@gmail.com
Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org
Gerrit-Reviewer: Nischayn22 nischay...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] removing objectfields from Storetable object - change (mediawiki...SemanticMediaWiki[master])

2012-07-16 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged.

Change subject: removing objectfields from Storetable object
..


removing objectfields from Storetable object

removed objectfields,indexes from storetable object, they are instead fetched 
from the handlers when needed

-new method in StoreTable getFields()

Change-Id: I8a91c95b8df84a4837ae8ae08e97c8948b163a0f
---
M includes/storage/SQLStore/SMW_DIHandler_Blob.php
M includes/storage/SQLStore/SMW_DIHandler_Bool.php
M includes/storage/SQLStore/SMW_DIHandler_Concept.php
M includes/storage/SQLStore/SMW_DIHandler_Container.php
M includes/storage/SQLStore/SMW_DIHandler_GeoCoord.php
M includes/storage/SQLStore/SMW_DIHandler_Number.php
M includes/storage/SQLStore/SMW_DIHandler_Property.php
M includes/storage/SQLStore/SMW_DIHandler_String.php
M includes/storage/SQLStore/SMW_DIHandler_Time.php
M includes/storage/SQLStore/SMW_DIHandler_URI.php
M includes/storage/SQLStore/SMW_DIHandler_WikiPage.php
M includes/storage/SQLStore/SMW_DataItemHandler.php
M includes/storage/SQLStore/SMW_SQLStore3.php
M includes/storage/SQLStore/SMW_SQLStore3Table.php
M includes/storage/SQLStore/SMW_SQLStore3_Queries.php
M includes/storage/SQLStore/SMW_SQLStore3_Readers.php
M includes/storage/SQLStore/SMW_SQLStore3_SetupHandlers.php
M includes/storage/SQLStore/SMW_SQLStore3_Writers.php
18 files changed, 170 insertions(+), 114 deletions(-)

Approvals:
  Markus Kroetzsch: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/15703
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8a91c95b8df84a4837ae8ae08e97c8948b163a0f
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Nischayn22 nischay...@gmail.com
Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org
Gerrit-Reviewer: Nischayn22 nischay...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Cleanup - change (mediawiki...SemanticMediaWiki[master])

2012-07-16 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged.

Change subject: Cleanup
..


Cleanup

removing invalid include_onces and moving compatibilityhelpers to compat folder

Change-Id: Id9a9c4abaa3fab6066c61c0f0f6023ec245115c3
---
M includes/SMW_Setup.php
M includes/storage/SQLStore/SMW_SQLStore3.php
R includes/storage/compatSQLStore/SMW_CompatibilityHelpers.php
M includes/storage/compatSQLStore/SMW_SQLStore2.php
4 files changed, 3 insertions(+), 9 deletions(-)

Approvals:
  Markus Kroetzsch: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/15700
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id9a9c4abaa3fab6066c61c0f0f6023ec245115c3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Nischayn22 nischay...@gmail.com
Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fixed tables for special properties - change (mediawiki...SemanticMediaWiki[master])

2012-07-16 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged.

Change subject: Fixed tables for special properties
..


Fixed tables for special properties

Assigned new tables for all special properties, this way we gain
space by not storing the property ids and querying them
Also removed the use of proptable-specpropsonly, as we now
have only fixed tables for these properties

Change-Id: I5ac14cc960ac804713e02c99062848bd115fff05
---
M includes/storage/SQLStore/SMW_SQLStore3.php
M includes/storage/SQLStore/SMW_SQLStore3Table.php
M includes/storage/SQLStore/SMW_SQLStore3_Readers.php
M includes/storage/SQLStore/SMW_SQLStore3_SetupHandlers.php
M includes/storage/SQLStore/SMW_SQLStore3_SpecialPageHandlers.php
M includes/storage/SQLStore/SMW_SQLStore3_Writers.php
6 files changed, 47 insertions(+), 76 deletions(-)

Approvals:
  Markus Kroetzsch: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/15699
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5ac14cc960ac804713e02c99062848bd115fff05
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Nischayn22 nischay...@gmail.com
Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org
Gerrit-Reviewer: Nischayn22 nischay...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] changingDefaultStoreBackToStore2 - change (mediawiki...SemanticMediaWiki[master])

2012-07-16 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged.

Change subject: changingDefaultStoreBackToStore2
..


changingDefaultStoreBackToStore2

Change-Id: I38e4e66f4cba53b994d834ef1f2f68c7ff74cc99
---
M SMW_Settings.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Markus Kroetzsch: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/15725
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I38e4e66f4cba53b994d834ef1f2f68c7ff74cc99
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Nischayn22 nischay...@gmail.com
Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix bug in DIProperty - change (mediawiki...SemanticMediaWiki[master])

2012-07-11 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has submitted this change and it was merged.

Change subject: Fix bug in DIProperty
..


Fix bug in DIProperty

should always call initPropertyRegistration() before using $m_prop_types

Change-Id: Icfdc38d2134bc95dc26d8acf07a5a5540e197daf
---
M includes/dataitems/SMW_DI_Property.php
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Markus Kroetzsch: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/14867
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icfdc38d2134bc95dc26d8acf07a5a5540e197daf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Nischayn22 nischay...@gmail.com
Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


<    1   2