[MediaWiki-commits] [Gerrit] Hacking in a new API call so status 200 Globalcollect CC pay... - change (mediawiki...DonationInterface[master])
Pgehres has submitted this change and it was merged. Change subject: Hacking in a new API call so status 200 Globalcollect CC payments will ever go through. This is terrible, and temporary until I can figure out a nicer way to do this. .. Hacking in a new API call so status 200 Globalcollect CC payments will ever go through. This is terrible, and temporary until I can figure out a nicer way to do this. Fixed a typo to be slightly less nonsensical. Change-Id: Idde2069bbe2c623262a99dcf9484bdfd00cd0896 --- M donationinterface.php M globalcollect_gateway/globalcollect.adapter.php 2 files changed, 143 insertions(+), 69 deletions(-) Approvals: Pgehres: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/31597 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idde2069bbe2c623262a99dcf9484bdfd00cd0896 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/DonationInterface Gerrit-Branch: master Gerrit-Owner: Katie Horn kh...@wikimedia.org Gerrit-Reviewer: Katie Horn kh...@wikimedia.org Gerrit-Reviewer: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update CentralNotice to master. Fixing Bug 41632 - change (mediawiki/core[wmf/1.21wmf3])
Pgehres has uploaded a new change for review. Change subject: Update CentralNotice to master. Fixing Bug 41632 .. Update CentralNotice to master. Fixing Bug 41632 Change-Id: I44d4c65e02f38e05d00fdaed12e1653292e7cfc3 --- M extensions/CentralNotice 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/37/31337/1 -- To view, visit https://gerrit.wikimedia.org/r/31337 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I44d4c65e02f38e05d00fdaed12e1653292e7cfc3 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf3 Gerrit-Owner: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update CentralNotice to master. - change (mediawiki/core[wmf/1.21wmf3])
Pgehres has submitted this change and it was merged. Change subject: Update CentralNotice to master. .. Update CentralNotice to master. Fixing Bug 41632 Change-Id: I44d4c65e02f38e05d00fdaed12e1653292e7cfc3 --- M extensions/CentralNotice 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Pgehres: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/31337 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I44d4c65e02f38e05d00fdaed12e1653292e7cfc3 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf3 Gerrit-Owner: Pgehres pgeh...@wikimedia.org Gerrit-Reviewer: Pgehres pgeh...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update CentralNotice to master. Fixing Bug 41632. - change (mediawiki/core[wmf/1.21wmf2])
Pgehres has uploaded a new change for review. Change subject: Update CentralNotice to master. Fixing Bug 41632. .. Update CentralNotice to master. Fixing Bug 41632. Change-Id: Ic94e3519745d3653f38c64958c7377a43ae1b9d5 --- M extensions/CentralNotice 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/60/31360/1 -- To view, visit https://gerrit.wikimedia.org/r/31360 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic94e3519745d3653f38c64958c7377a43ae1b9d5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf2 Gerrit-Owner: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update CentralNotice to master. Fixing Bug 41632. - change (mediawiki/core[wmf/1.21wmf2])
Pgehres has submitted this change and it was merged. Change subject: Update CentralNotice to master. Fixing Bug 41632. .. Update CentralNotice to master. Fixing Bug 41632. Change-Id: Ic94e3519745d3653f38c64958c7377a43ae1b9d5 --- M extensions/CentralNotice 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Pgehres: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/31360 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic94e3519745d3653f38c64958c7377a43ae1b9d5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf2 Gerrit-Owner: Pgehres pgeh...@wikimedia.org Gerrit-Reviewer: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Falseish when I was trying to look for a zero. So very annoy... - change (mediawiki...DonationInterface[master])
Pgehres has submitted this change and it was merged. Change subject: Falseish when I was trying to look for a zero. So very annoyed. .. Falseish when I was trying to look for a zero. So very annoyed. Change-Id: Ic8bff65947212985584eadfceec9811e999daad1 --- M globalcollect_gateway/globalcollect.adapter.php M globalcollect_gateway/scripts/orphans.php 2 files changed, 4 insertions(+), 3 deletions(-) Approvals: Pgehres: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/31056 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8bff65947212985584eadfceec9811e999daad1 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DonationInterface Gerrit-Branch: master Gerrit-Owner: Katie Horn kh...@wikimedia.org Gerrit-Reviewer: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Updates to the PayPal IPN listener to bring it up to speed w... - change (wikimedia...PaymentsListeners[master])
Pgehres has uploaded a new change for review. Change subject: Updates to the PayPal IPN listener to bring it up to speed with the SVN version. .. Updates to the PayPal IPN listener to bring it up to speed with the SVN version. I moved a few things around from where they are in the SVN version so that they make a bit more sense. I also fixed a number of typos and style things here and there. Change-Id: I1bdea41ee99edcef05c25c794890cc858bf6a61e --- M paypal/IPN/PaypalIPNListener.php 1 file changed, 207 insertions(+), 48 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/PaymentsListeners refs/changes/30/30730/1 -- To view, visit https://gerrit.wikimedia.org/r/30730 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1bdea41ee99edcef05c25c794890cc858bf6a61e Gerrit-PatchSet: 1 Gerrit-Project: wikimedia/fundraising/PaymentsListeners Gerrit-Branch: master Gerrit-Owner: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Updating LandingCheck and ContributionTracking to master - change (mediawiki/core[wmf/1.21wmf2])
Pgehres has uploaded a new change for review. Change subject: Updating LandingCheck and ContributionTracking to master .. Updating LandingCheck and ContributionTracking to master Change-Id: I34d386bb332d4a7ea80c8b27bf980035836ccf21 --- M extensions/ContributionTracking M extensions/LandingCheck 2 files changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/08/30008/1 -- To view, visit https://gerrit.wikimedia.org/r/30008 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I34d386bb332d4a7ea80c8b27bf980035836ccf21 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf2 Gerrit-Owner: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Updating LandingCheck and ContributionTracking to master - change (mediawiki/core[wmf/1.21wmf2])
Pgehres has submitted this change and it was merged. Change subject: Updating LandingCheck and ContributionTracking to master .. Updating LandingCheck and ContributionTracking to master Change-Id: I34d386bb332d4a7ea80c8b27bf980035836ccf21 --- M extensions/ContributionTracking M extensions/LandingCheck 2 files changed, 0 insertions(+), 0 deletions(-) Approvals: Pgehres: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/30008 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34d386bb332d4a7ea80c8b27bf980035836ccf21 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf2 Gerrit-Owner: Pgehres pgeh...@wikimedia.org Gerrit-Reviewer: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Adding French territories to priority countries list for Lan... - change (operations/mediawiki-config[master])
Pgehres has uploaded a new change for review. Change subject: Adding French territories to priority countries list for LandingCheck. .. Adding French territories to priority countries list for LandingCheck. Change-Id: I5737580ef50cfc4d547e9316ef1e699eac7525a7 --- M wmf-config/CommonSettings.php 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config refs/changes/75/30075/1 -- To view, visit https://gerrit.wikimedia.org/r/30075 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5737580ef50cfc4d547e9316ef1e699eac7525a7 Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Updating ContributionTracking to master (If0661655) - change (mediawiki/core[wmf/1.21wmf2])
Pgehres has uploaded a new change for review. Change subject: Updating ContributionTracking to master (If0661655) .. Updating ContributionTracking to master (If0661655) Change-Id: I93d209d18baf2e751ded0c5f06aad4f064506c97 --- M extensions/ContributionTracking 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/96/30096/1 -- To view, visit https://gerrit.wikimedia.org/r/30096 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I93d209d18baf2e751ded0c5f06aad4f064506c97 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf2 Gerrit-Owner: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Updating ContributionTracking to master (If0661655) - change (mediawiki/core[wmf/1.21wmf2])
Pgehres has submitted this change and it was merged. Change subject: Updating ContributionTracking to master (If0661655) .. Updating ContributionTracking to master (If0661655) Change-Id: I93d209d18baf2e751ded0c5f06aad4f064506c97 --- M extensions/ContributionTracking 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Pgehres: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/30096 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93d209d18baf2e751ded0c5f06aad4f064506c97 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf2 Gerrit-Owner: Pgehres pgeh...@wikimedia.org Gerrit-Reviewer: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Allowing querystring params to be passed through to LandingC... - change (mediawiki...FundraiserLandingPage[master])
Pgehres has uploaded a new change for review. Change subject: Allowing querystring params to be passed through to LandingCheck. .. Allowing querystring params to be passed through to LandingCheck. Change-Id: I4b1dcd380dec79152ba991187d3082c645dd5be1 --- M FundraiserRedirector.body.php 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FundraiserLandingPage refs/changes/01/30101/1 -- To view, visit https://gerrit.wikimedia.org/r/30101 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4b1dcd380dec79152ba991187d3082c645dd5be1 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/FundraiserLandingPage Gerrit-Branch: master Gerrit-Owner: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Updating FundraiserLandingPage to master (I4b1dcd38) - change (mediawiki/core[wmf/1.21wmf2])
Pgehres has uploaded a new change for review. Change subject: Updating FundraiserLandingPage to master (I4b1dcd38) .. Updating FundraiserLandingPage to master (I4b1dcd38) Change-Id: I583d2d4376ab3e9898810907108a9fdf65495f05 --- M extensions/FundraiserLandingPage 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/04/30104/1 -- To view, visit https://gerrit.wikimedia.org/r/30104 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I583d2d4376ab3e9898810907108a9fdf65495f05 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.21wmf2 Gerrit-Owner: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Adding the AUTHENTICATIONINDICATOR node to all GC transactio... - change (mediawiki...DonationInterface[master])
Pgehres has submitted this change and it was merged. Change subject: Adding the AUTHENTICATIONINDICATOR node to all GC transactions, and defaulting to '0' as per their new instructions. .. Adding the AUTHENTICATIONINDICATOR node to all GC transactions, and defaulting to '0' as per their new instructions. Change-Id: I4591259bc3100afa0d38351782fab8f77892b417 --- M globalcollect_gateway/globalcollect.adapter.php 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Pgehres: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/29897 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4591259bc3100afa0d38351782fab8f77892b417 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DonationInterface Gerrit-Branch: master Gerrit-Owner: Katie Horn kh...@wikimedia.org Gerrit-Reviewer: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Adding back URLs for LandingCheck. - change (operations/mediawiki-config[master])
Pgehres has uploaded a new change for review. Change subject: Adding back URLs for LandingCheck. .. Adding back URLs for LandingCheck. This is used to distinguish between chapter landing pages on wmfwiki and Foundation landing pages on donatewiki. Change-Id: Ib255998b9661a0bf8d61c96ef53c720fe7954952 --- M wmf-config/CommonSettings.php 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config refs/changes/02/29702/1 -- To view, visit https://gerrit.wikimedia.org/r/29702 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib255998b9661a0bf8d61c96ef53c720fe7954952 Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Changing the way we do order ID generation, and the ways we ... - change (mediawiki...DonationInterface[master])
Pgehres has submitted this change and it was merged. Change subject: Changing the way we do order ID generation, and the ways we can do it in the future. .. Changing the way we do order ID generation, and the ways we can do it in the future. Change-Id: I9888d00c100687cca195960feb8d6a08ba3d136d --- M gateway_common/DonationData.php 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Pgehres: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/28791 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9888d00c100687cca195960feb8d6a08ba3d136d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DonationInterface Gerrit-Branch: master Gerrit-Owner: Katie Horn kh...@wikimedia.org Gerrit-Reviewer: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Absolute madness. - change (mediawiki...DonationInterface[master])
Pgehres has submitted this change and it was merged. Change subject: Absolute madness. .. Absolute madness. Revert Changing the way we do order ID generation, and the ways we can do it in the future. This reverts commit 40ba59217b8c09bdd6c938045d67039b6b87342f --- M gateway_common/DonationData.php 1 file changed, 3 insertions(+), 5 deletions(-) Approvals: Pgehres: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/28792 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d6d672e2fc2f602c19913f33d37cd13edf722ce Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DonationInterface Gerrit-Branch: master Gerrit-Owner: Katie Horn kh...@wikimedia.org Gerrit-Reviewer: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Changing our not-so-random random number generator to a diff... - change (mediawiki...DonationInterface[master])
Pgehres has submitted this change and it was merged. Change subject: Changing our not-so-random random number generator to a different random, and a minor bug fix. .. Changing our not-so-random random number generator to a different random, and a minor bug fix. Change-Id: Ifd993b115d6b1942813b1eed62155f108c5d14ba --- M gateway_common/DonationData.php M globalcollect_gateway/globalcollect.adapter.php 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Pgehres: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/28793 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifd993b115d6b1942813b1eed62155f108c5d14ba Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DonationInterface Gerrit-Branch: master Gerrit-Owner: Katie Horn kh...@wikimedia.org Gerrit-Reviewer: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixing a typo that was filling up my php error log. - change (mediawiki...DonationInterface[master])
Pgehres has submitted this change and it was merged. Change subject: Fixing a typo that was filling up my php error log. .. Fixing a typo that was filling up my php error log. Change-Id: I0a0e6bfb5c37e7a6c2c4bae69b764d9ff31d55c6 --- M gateway_common/donation.api.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Pgehres: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/28528 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a0e6bfb5c37e7a6c2c4bae69b764d9ff31d55c6 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DonationInterface Gerrit-Branch: master Gerrit-Owner: Katie Horn kh...@wikimedia.org Gerrit-Reviewer: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] A bunch of little updates to ContributionTracking: - removi... - change (mediawiki...ContributionTracking[master])
Pgehres has uploaded a new change for review. Change subject: A bunch of little updates to ContributionTracking: - removing hard coded notify_url - removing some unused functions - refactored OWA out :-) - removing if-blocks around new features since they have been successfully deployed and all dependencies sati .. A bunch of little updates to ContributionTracking: - removing hard coded notify_url - removing some unused functions - refactored OWA out :-) - removing if-blocks around new features since they have been successfully deployed and all dependencies satisfied - updated a few default values - fixed an undefined variable In all, a bunch of long overdue work. Change-Id: I8064ffe2f3b0282b9252a4acb2f5cbde10dab7ae --- M ApiContributionTracking.php M ContributionTracking.php M ContributionTracking.processor.php M ContributionTracking_body.php 4 files changed, 4 insertions(+), 124 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContributionTracking refs/changes/67/28467/1 -- To view, visit https://gerrit.wikimedia.org/r/28467 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8064ffe2f3b0282b9252a4acb2f5cbde10dab7ae Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ContributionTracking Gerrit-Branch: master Gerrit-Owner: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Removing opt-out field. One form only for now. - change (mediawiki...DonationInterface[master])
Pgehres has uploaded a new change for review. Change subject: Removing opt-out field. One form only for now. .. Removing opt-out field. One form only for now. Change-Id: Ie3a50c81fa8e7403ba309b0fadace9b774f10915 --- M globalcollect_gateway/forms/html/cc/cc-vm.html 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface refs/changes/68/28468/1 -- To view, visit https://gerrit.wikimedia.org/r/28468 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie3a50c81fa8e7403ba309b0fadace9b774f10915 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DonationInterface Gerrit-Branch: master Gerrit-Owner: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Removing opt-opt hidden field from the rest of the forms. - change (mediawiki...DonationInterface[master])
Pgehres has uploaded a new change for review. Change subject: Removing opt-opt hidden field from the rest of the forms. .. Removing opt-opt hidden field from the rest of the forms. Change-Id: I956ddf99fe5deb1292fbcc113a19ca4195911cb4 --- M globalcollect_gateway/forms/html/bt/bt-AU.html M globalcollect_gateway/forms/html/bt/bt-CA.html M globalcollect_gateway/forms/html/bt/bt-US.html M globalcollect_gateway/forms/html/bt/bt.html M globalcollect_gateway/forms/html/cc-emailonly/cc-vm.html M globalcollect_gateway/forms/html/cc-emailonly/cc-vma.html M globalcollect_gateway/forms/html/cc-emailonly/cc-vmaj.html M globalcollect_gateway/forms/html/cc/cc-a.html M globalcollect_gateway/forms/html/cc/cc-vma.html M globalcollect_gateway/forms/html/cc/cc-vmad.html M globalcollect_gateway/forms/html/cc/cc-vmaj.html M globalcollect_gateway/forms/html/cc/cc-vmd.html M globalcollect_gateway/forms/html/cc/cc-vmj.html M globalcollect_gateway/forms/html/cc/cc.html M globalcollect_gateway/forms/html/ew/ew-webmoney.html M globalcollect_gateway/forms/html/ew/ew-yandex.html M globalcollect_gateway/forms/html/ew/ew-yandex_email.html M globalcollect_gateway/forms/html/obt/obt-bpay.html M globalcollect_gateway/forms/html/rcc/rcc-vm.html M globalcollect_gateway/forms/html/rcc/rcc-vma.html M globalcollect_gateway/forms/html/rcc/rcc-vmad.html M globalcollect_gateway/forms/html/rcc/rcc-vmaj.html M globalcollect_gateway/forms/html/rcc/rcc-vmd.html M globalcollect_gateway/forms/html/rcc/rcc-vmj.html M globalcollect_gateway/forms/html/rcc/rcc.html M globalcollect_gateway/forms/html/rtbt/rtbt-enets.html M globalcollect_gateway/forms/html/rtbt/rtbt-eps.html M globalcollect_gateway/forms/html/rtbt/rtbt-ideal-noadd.html M globalcollect_gateway/forms/html/rtbt/rtbt-ideal.html M globalcollect_gateway/forms/html/rtbt/rtbt-sofo-GB.html M globalcollect_gateway/forms/html/rtbt/rtbt-sofo.html M globalcollect_gateway/forms/html/webitects2nd-AU.html M globalcollect_gateway/forms/html/webitects2nd-US.html M globalcollect_gateway/forms/html/webitects2nd-amex.html M globalcollect_gateway/forms/html/webitects2nd.html M globalcollect_gateway/forms/html/webitects2nd_green-US.html 36 files changed, 5 insertions(+), 38 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface refs/changes/69/28469/1 -- To view, visit https://gerrit.wikimedia.org/r/28469 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I956ddf99fe5deb1292fbcc113a19ca4195911cb4 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DonationInterface Gerrit-Branch: master Gerrit-Owner: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Adding a final donation status log line, and fixing a couple... - change (mediawiki...DonationInterface[master])
Pgehres has submitted this change and it was merged. Change subject: Adding a final donation status log line, and fixing a couple minor bugs that this surfaced .. Adding a final donation status log line, and fixing a couple minor bugs that this surfaced Change-Id: I6a140113b9ba50c48d3e27ab16f8ae84495d0875 --- M gateway_common/gateway.adapter.php M globalcollect_gateway/globalcollect.adapter.php 2 files changed, 42 insertions(+), 8 deletions(-) Approvals: Pgehres: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/28480 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a140113b9ba50c48d3e27ab16f8ae84495d0875 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DonationInterface Gerrit-Branch: master Gerrit-Owner: Katie Horn kh...@wikimedia.org Gerrit-Reviewer: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] New cache overrirde override for BannerListLoader - change (mediawiki...CentralNotice[master])
Pgehres has submitted this change and it was merged. Change subject: New cache overrirde override for BannerListLoader .. New cache overrirde override for BannerListLoader Change-Id: I18de938b98dfee7d0e691a88a269de3622196eeb --- M modules/ext.centralNotice.bannerController/bannerController.js 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Pgehres: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/27740 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18de938b98dfee7d0e691a88a269de3622196eeb Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/CentralNotice Gerrit-Branch: master Gerrit-Owner: Kaldari rkald...@wikimedia.org Gerrit-Reviewer: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Improve comments and escape variable at output. - change (mediawiki...CentralNotice[master])
Pgehres has submitted this change and it was merged. Change subject: Improve comments and escape variable at output. .. Improve comments and escape variable at output. Change-Id: Ic8cbae6f13d5e788a688e335302ba0eafe3e9ce4 --- M CentralNotice.php 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Pgehres: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/27767 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8cbae6f13d5e788a688e335302ba0eafe3e9ce4 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/CentralNotice Gerrit-Branch: master Gerrit-Owner: Kaldari rkald...@wikimedia.org Gerrit-Reviewer: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Changing the setNormalizedAmount function to be less horribl... - change (mediawiki...DonationInterface[master])
Pgehres has submitted this change and it was merged. Change subject: Changing the setNormalizedAmount function to be less horrible. .. Changing the setNormalizedAmount function to be less horrible. Change-Id: I681c6e5e89ef881992a5d01a68797ddab5fbfa7a --- M gateway_common/DonationData.php 1 file changed, 12 insertions(+), 9 deletions(-) Approvals: Pgehres: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/27619 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I681c6e5e89ef881992a5d01a68797ddab5fbfa7a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DonationInterface Gerrit-Branch: master Gerrit-Owner: Katie Horn kh...@wikimedia.org Gerrit-Reviewer: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Make sure cookie expiration time is in the future - change (mediawiki...CentralNotice[master])
Pgehres has submitted this change and it was merged. Change subject: Make sure cookie expiration time is in the future .. Make sure cookie expiration time is in the future Change-Id: I99c16d76acae8f63dff80eada4d5aea89f8b7e8e --- M special/SpecialHideBanners.php 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Pgehres: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/27659 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99c16d76acae8f63dff80eada4d5aea89f8b7e8e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/CentralNotice Gerrit-Branch: master Gerrit-Owner: Kaldari rkald...@wikimedia.org Gerrit-Reviewer: Mwalker mwal...@wikimedia.org Gerrit-Reviewer: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Unsetting alternate amount fields once we have normalized th... - change (mediawiki...DonationInterface[master])
Pgehres has uploaded a new change for review. Change subject: Unsetting alternate amount fields once we have normalized the amount .. Unsetting alternate amount fields once we have normalized the amount Change-Id: I3f4eadae659795646fd4fc734a868ff12140ac2d --- M gateway_common/DonationData.php 1 file changed, 8 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface refs/changes/32/27432/1 -- To view, visit https://gerrit.wikimedia.org/r/27432 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3f4eadae659795646fd4fc734a868ff12140ac2d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DonationInterface Gerrit-Branch: master Gerrit-Owner: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Bumping the S:FLP cache time to 10 minutes from 5 minutes. - change (mediawiki...FundraiserLandingPage[master])
Pgehres has uploaded a new change for review. Change subject: Bumping the S:FLP cache time to 10 minutes from 5 minutes. .. Bumping the S:FLP cache time to 10 minutes from 5 minutes. Change-Id: I0b2d381e1b1001220e77fd0316da91245aa7dd21 --- M FundraiserLandingPage.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FundraiserLandingPage refs/changes/23/27323/1 -- To view, visit https://gerrit.wikimedia.org/r/27323 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0b2d381e1b1001220e77fd0316da91245aa7dd21 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/FundraiserLandingPage Gerrit-Branch: master Gerrit-Owner: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Disabling redirect for GB per agreement between the WMF and ... - change (mediawiki...FundraiserLandingPage[master])
Pgehres has uploaded a new change for review. Change subject: Disabling redirect for GB per agreement between the WMF and WMUK for the 2012 fundraiser. .. Disabling redirect for GB per agreement between the WMF and WMUK for the 2012 fundraiser. Change-Id: I254c2dff6b0add767696e6ec4e972b37aebef4c9 --- M FundraiserLandingPage.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FundraiserLandingPage refs/changes/26/25726/1 -- To view, visit https://gerrit.wikimedia.org/r/25726 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I254c2dff6b0add767696e6ec4e972b37aebef4c9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/FundraiserLandingPage Gerrit-Branch: master Gerrit-Owner: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Maintenance for FundraiserLandingPage extension. - change (mediawiki...FundraiserLandingPage[master])
Pgehres has submitted this change and it was merged. Change subject: Maintenance for FundraiserLandingPage extension. .. Maintenance for FundraiserLandingPage extension. * Replace deprecated methods. * Deglobalization. * Remove unused local variables. * Use __DIR__ instead of dirname( __FILE__ ). * Remove superfluous newlines and comments. Change-Id: I385ac7fc584221792dd5f8c7da6bfad2fad78d2a --- M FundraiserLandingPage.body.php M FundraiserLandingPage.php M FundraiserRedirector.body.php 3 files changed, 19 insertions(+), 32 deletions(-) Approvals: Pgehres: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/25584 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I385ac7fc584221792dd5f8c7da6bfad2fad78d2a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/FundraiserLandingPage Gerrit-Branch: master Gerrit-Owner: Siebrand siebr...@wikimedia.org Gerrit-Reviewer: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix the problem of close button URLs becoming obsolete. - change (mediawiki...CentralNotice[master])
Pgehres has submitted this change and it was merged. Change subject: Fix the problem of close button URLs becoming obsolete. .. Fix the problem of close button URLs becoming obsolete. You can now specify any URL you like for the default close button by using a config variable. PS2 - Removing the trailing WS for Siebrand Change-Id: If2293db78bfa2a5665887c3122dd2fd45ad85944 --- M CentralNotice.php M modules/ext.centralNotice.interface/centralnotice.js 2 files changed, 11 insertions(+), 5 deletions(-) Approvals: Pgehres: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/25230 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2293db78bfa2a5665887c3122dd2fd45ad85944 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/CentralNotice Gerrit-Branch: master Gerrit-Owner: Kaldari rkald...@wikimedia.org Gerrit-Reviewer: Kaldari rkald...@wikimedia.org Gerrit-Reviewer: Pgehres pgeh...@wikimedia.org Gerrit-Reviewer: Siebrand siebr...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Minor updates to FundraiserUnsubscribe. - change (wikimedia...DonationEmailUnsubscribe[master])
Pgehres has submitted this change and it was merged. Change subject: Minor updates to FundraiserUnsubscribe. .. Minor updates to FundraiserUnsubscribe. Awight had proposed some changes to the last commit but I didn't get around to changing them before the whole thing got merged. So! - We now can control the syslog facility via config param, but by default it's set to LOG_USER - We can control if we want to log outbound XML. This removes a security concern whereby it logged the Silverpop password into the logs. - Fixed a silly IF condition in the Silverpop method. Change-Id: I987e4a0e00ecc18f64b9643a0c62a619e675b27c --- M FundraiserUnsubscribe.php M includes/Logger.php M includes/XmlTransactionProcessor.php M methods/FundraiserUnsubscribeSilverpop.php 4 files changed, 15 insertions(+), 5 deletions(-) Approvals: Pgehres: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/25471 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I987e4a0e00ecc18f64b9643a0c62a619e675b27c Gerrit-PatchSet: 1 Gerrit-Project: wikimedia/fundraising/DonationEmailUnsubscribe Gerrit-Branch: master Gerrit-Owner: Mwalker mwal...@wikimedia.org Gerrit-Reviewer: Adamw awi...@wikimedia.org Gerrit-Reviewer: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Adjusting the default fraud point percentage we give for AVS... - change (mediawiki...DonationInterface[master])
Pgehres has submitted this change and it was merged. Change subject: Adjusting the default fraud point percentage we give for AVS code zero. .. Adjusting the default fraud point percentage we give for AVS code zero. Change-Id: I23c8b2f447d3a371a1272e86ba02ead589b49eeb --- M donationinterface.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Pgehres: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/24953 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I23c8b2f447d3a371a1272e86ba02ead589b49eeb Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DonationInterface Gerrit-Branch: master Gerrit-Owner: Katie Horn kh...@wikimedia.org Gerrit-Reviewer: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Adding support for recently added columns in the contributio... - change (mediawiki...ContributionTracking[master])
Pgehres has uploaded a new change for review. Change subject: Adding support for recently added columns in the contribution_tracking database. .. Adding support for recently added columns in the contribution_tracking database. https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/563 Change-Id: Ia8aa5b606740e7cf624efe1270348c9a08101af7 --- M ApiContributionTracking.php M ContributionTracking.php M ContributionTracking.processor.php M ContributionTracking.sql M ContributionTracking_body.php A patches/20120924.new_columns.sql 6 files changed, 88 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContributionTracking refs/changes/50/25050/1 -- To view, visit https://gerrit.wikimedia.org/r/25050 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia8aa5b606740e7cf624efe1270348c9a08101af7 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ContributionTracking Gerrit-Branch: master Gerrit-Owner: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix call to nonexistent method and escape the language code - change (mediawiki...DonationInterface[master])
Pgehres has submitted this change and it was merged. Change subject: Fix call to nonexistent method and escape the language code .. Fix call to nonexistent method and escape the language code Change-Id: I56ea1fd33f1ce1a2d857bcce3d6e3781e47ef86c --- M gateway_common/GatewayForm.php 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Pgehres: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/24500 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I56ea1fd33f1ce1a2d857bcce3d6e3781e47ef86c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DonationInterface Gerrit-Branch: master Gerrit-Owner: Catrope roan.katt...@gmail.com Gerrit-Reviewer: Katie Horn kh...@wikimedia.org Gerrit-Reviewer: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Warn people not to use jquery.donationInterface.js - change (mediawiki...DonationInterface[master])
Pgehres has submitted this change and it was merged. Change subject: Warn people not to use jquery.donationInterface.js .. Warn people not to use jquery.donationInterface.js Change-Id: Id85d3d64732db7440cf40bc40356a0a8be0a3b65 --- M modules/jquery.donationInterface.js 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Pgehres: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/24516 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id85d3d64732db7440cf40bc40356a0a8be0a3b65 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DonationInterface Gerrit-Branch: master Gerrit-Owner: Catrope roan.katt...@gmail.com Gerrit-Reviewer: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Prevention of double-staging requests inside the stageData f... - change (mediawiki...DonationInterface[master])
Pgehres has submitted this change and it was merged. Change subject: Prevention of double-staging requests inside the stageData function. .. Prevention of double-staging requests inside the stageData function. Change-Id: I1c94b926cb8ce06733cfee8b7755d35cd8ce1759 --- M gateway_common/gateway.adapter.php 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Pgehres: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/24518 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c94b926cb8ce06733cfee8b7755d35cd8ce1759 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DonationInterface Gerrit-Branch: master Gerrit-Owner: Katie Horn kh...@wikimedia.org Gerrit-Reviewer: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Remove obsolete, deprecated and unused GeoIP code - change (mediawiki...DonationInterface[master])
Pgehres has submitted this change and it was merged. Change subject: Remove obsolete, deprecated and unused GeoIP code .. Remove obsolete, deprecated and unused GeoIP code Change-Id: Ic9b7a36f86b8f0e0073f8ba2625ef9788e454298 --- D GeoIP/.bzrignore D GeoIP/AUTHORS.txt D GeoIP/GeoIP.php D GeoIP/GeoIP.sql D GeoIP/GeoIPCountryWhois.csv D GeoIP/LICENSE.txt D GeoIP/README.txt D GeoIP/RebuildGeoIP.php 8 files changed, 0 insertions(+), 109,277 deletions(-) Approvals: Pgehres: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/24519 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9b7a36f86b8f0e0073f8ba2625ef9788e454298 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DonationInterface Gerrit-Branch: master Gerrit-Owner: Catrope roan.katt...@gmail.com Gerrit-Reviewer: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Maintenance for DonationInterface extension. - change (mediawiki...DonationInterface[master])
Pgehres has submitted this change and it was merged. Change subject: Maintenance for DonationInterface extension. .. Maintenance for DonationInterface extension. * Deglobalisation. * Replace deprecated methods. * Remove superfluous newlines and comments. * Remove unneeded semi-colons and redistribute them where needed. * Update documentation. * Remove unnecessary local variable assignments. * Remove commented out code. * Remove unused globals. * Add FIXME where needed, and change TODO to @todo. * Remove duplicate array keys. * Remove redundant units from CSS. * Separate CSS property and value by a space where needed. * Remove unreachable code. * Simplify some JS. * Escape some previously unescaped output. Pretty sure this could use more review. Change-Id: I45ba5bcdb5b0daa0d96c44dd7e35fa0ab869d3cf --- M activemq_stomp/Stomp.php M activemq_stomp/activemq_stomp.php M amazon_gateway/amazon.adapter.php M amazon_gateway/amazon_gateway.body.php M extras/custom_filters/custom_filters.body.php M extras/custom_filters/filters/minfraud/minfraud.body.php M extras/extras.body.php M extras/recaptcha/recaptcha.body.php M extras/session_velocity/session_velocity.body.php M gateway_common/DataValidator.php M gateway_common/DonationData.php M gateway_common/GatewayForm.php M gateway_common/donation.api.php M gateway_common/gateway.adapter.php M gateway_common/interface.i18n.php M gateway_forms/Form.php M gateway_forms/OneStepTwoColumn.php M gateway_forms/RapidHtml.php M gateway_forms/TwoColumnLetter.php M gateway_forms/TwoColumnLetter2.php M gateway_forms/TwoColumnLetter3.php M gateway_forms/TwoColumnLetter4.php M gateway_forms/TwoColumnLetter5.php M gateway_forms/TwoColumnLetter6.php M gateway_forms/TwoColumnLetter7.php M gateway_forms/TwoColumnPayPal.php M gateway_forms/TwoStepTwoColumn.php M gateway_forms/TwoStepTwoColumnLetter.php M gateway_forms/TwoStepTwoColumnLetter3.php M gateway_forms/TwoStepTwoColumnLetterCA.php M gateway_forms/TwoStepTwoColumnPremium.php M gateway_forms/TwoStepTwoColumnPremiumUS.php M gateway_forms/css/TwoColumnLetter.css M gateway_forms/css/TwoColumnLetter4.css M gateway_forms/css/TwoColumnLetter5.css M gateway_forms/css/TwoColumnLetter6.css M gateway_forms/css/TwoColumnLetter7.css M gateway_forms/css/TwoStepTwoColumnLetter.css M gateway_forms/css/TwoStepTwoColumnLetter2.css M gateway_forms/css/TwoStepTwoColumnLetter3.css M gateway_forms/css/TwoStepTwoColumnPremium.css M gateway_forms/css/TwoStepTwoColumnPremiumUS.css M gateway_forms/rapidhtml/css/lp1.css M gateway_forms/rapidhtml/css/webitects.css M gateway_forms/rapidhtml/html/webitects_1.html M gateway_forms/rapidhtml/html/webitects_1a.html M gateway_forms/rapidhtml/html/webitects_2.html M gateway_forms/rapidhtml/js/globalcollect_test_2.js M globalcollect_gateway/forms/css/gc.cc.css M globalcollect_gateway/forms/css/gc.css M globalcollect_gateway/forms/css/lightbox1.css M globalcollect_gateway/forms/html/cc-emailonly/cc-vm.html M globalcollect_gateway/forms/html/cc-emailonly/cc-vma.html M globalcollect_gateway/forms/html/cc-emailonly/cc-vmaj.html M globalcollect_gateway/forms/html/cc/cc-a.html M globalcollect_gateway/forms/html/cc/cc-vm.html M globalcollect_gateway/forms/html/cc/cc-vma.html M globalcollect_gateway/forms/html/cc/cc-vmad.html M globalcollect_gateway/forms/html/cc/cc-vmaj.html M globalcollect_gateway/forms/html/cc/cc-vmd.html M globalcollect_gateway/forms/html/cc/cc-vmj.html M globalcollect_gateway/forms/html/cc/cc.html M globalcollect_gateway/forms/html/ew/ew-yandex.html M globalcollect_gateway/forms/html/ew/ew-yandex_email.html M globalcollect_gateway/forms/html/rcc/rcc-vm.html M globalcollect_gateway/forms/html/rcc/rcc-vma.html M globalcollect_gateway/forms/html/rcc/rcc-vmad.html M globalcollect_gateway/forms/html/rcc/rcc-vmaj.html M globalcollect_gateway/forms/html/rcc/rcc-vmd.html M globalcollect_gateway/forms/html/rcc/rcc-vmj.html M globalcollect_gateway/forms/html/rcc/rcc.html M globalcollect_gateway/forms/js/gc.js M globalcollect_gateway/forms/js/lightbox1.js M globalcollect_gateway/forms/js/webitects.js M globalcollect_gateway/forms/js/webitects2nd-US.js M globalcollect_gateway/forms/js/webitects2nd.js M globalcollect_gateway/forms/js/webitects_2_3step.js M globalcollect_gateway/globalcollect.adapter.php M globalcollect_gateway/globalcollect_gateway.body.php M globalcollect_gateway/globalcollect_resultswitcher.body.php M globalcollect_gateway/modules/js/jquery.validate.additional-methods.js M globalcollect_gateway/modules/js/jquery.validate.js M globalcollect_gateway/modules/js/validate.js M globalcollect_gateway/scripts/orphan_adapter.php M globalcollect_gateway/scripts/orphans.php M modules/jquery.donationInterface.js M modules/validate_input.js M payflowpro_gateway/api_payflowpro_gateway.php M payflowpro_gateway/form_placeholders.js M payflowpro_gateway/forms/css/TwoStepTwoColumnLetter3-orig.css M
[MediaWiki-commits] [Gerrit] Initial commit of Direct Debit form for ES. Lacking JS vali... - change (mediawiki...DonationInterface[master])
Pgehres has uploaded a new change for review. Change subject: Initial commit of Direct Debit form for ES. Lacking JS validation and some CSS but otherwise good for testing .. Initial commit of Direct Debit form for ES. Lacking JS validation and some CSS but otherwise good for testing Change-Id: Ib8de87c094aaf0c0b2a2a216d54d97df5c366d99 --- M gateway_forms/rapidhtml/RapidHtmlResources.php A globalcollect_gateway/forms/html/dd/dd-ES.html 2 files changed, 121 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface refs/changes/69/23369/1 -- To view, visit https://gerrit.wikimedia.org/r/23369 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib8de87c094aaf0c0b2a2a216d54d97df5c366d99 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DonationInterface Gerrit-Branch: master Gerrit-Owner: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Adds email in a second place to GC's INSERT_ORDERWITHPAYMENT... - change (mediawiki...DonationInterface[master])
Pgehres has submitted this change and it was merged. Change subject: Adds email in a second place to GC's INSERT_ORDERWITHPAYMENT api call, and updates the data in contribution_tracking prior to the redirect to amazon. .. Adds email in a second place to GC's INSERT_ORDERWITHPAYMENT api call, and updates the data in contribution_tracking prior to the redirect to amazon. Change-Id: I5bad98c01014cd4750730f46389829619a490951 --- M amazon_gateway/amazon.adapter.php M globalcollect_gateway/globalcollect.adapter.php 2 files changed, 4 insertions(+), 0 deletions(-) Approvals: Pgehres: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/21982 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5bad98c01014cd4750730f46389829619a490951 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DonationInterface Gerrit-Branch: master Gerrit-Owner: Katie Horn kh...@wikimedia.org Gerrit-Reviewer: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixing bug 39345. Forgot a localization string. - change (mediawiki...CentralNotice[master])
Pgehres has submitted this change and it was merged. Change subject: Fixing bug 39345. Forgot a localization string. .. Fixing bug 39345. Forgot a localization string. Now the banner search bar can be properly localized. Change-Id: I1d300e2d880673f734b438c4e40076f485220a0c --- M CentralNotice.i18n.php M special/SpecialCentralNotice.php M special/SpecialNoticeTemplate.php 3 files changed, 6 insertions(+), 2 deletions(-) Approvals: Pgehres: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/19511 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d300e2d880673f734b438c4e40076f485220a0c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/CentralNotice Gerrit-Branch: master Gerrit-Owner: Mwalker mwal...@wikimedia.org Gerrit-Reviewer: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Adding 'problems donating' to the cc forms. Adding currency... - change (mediawiki...DonationInterface[master])
Pgehres has uploaded a new change for review. Change subject: Adding 'problems donating' to the cc forms. Adding currency templates for MXP, ARS, CLP, and EUR .. Adding 'problems donating' to the cc forms. Adding currency templates for MXP, ARS, CLP, and EUR Change-Id: I4ce59c15443ce67cd0e9823a98187cf420673272 --- A globalcollect_gateway/forms/html/_donation-amount/ARS.html A globalcollect_gateway/forms/html/_donation-amount/CLP.html A globalcollect_gateway/forms/html/_donation-amount/EUR.html A globalcollect_gateway/forms/html/_donation-amount/MXP.html M globalcollect_gateway/forms/html/cc-emailonly/cc-vm.html M globalcollect_gateway/forms/html/cc-emailonly/cc-vma.html M globalcollect_gateway/forms/html/cc-emailonly/cc-vmaj.html M globalcollect_gateway/forms/html/cc/cc-a.html M globalcollect_gateway/forms/html/cc/cc-vm.html M globalcollect_gateway/forms/html/cc/cc-vma.html M globalcollect_gateway/forms/html/cc/cc-vmad.html M globalcollect_gateway/forms/html/cc/cc-vmaj.html M globalcollect_gateway/forms/html/cc/cc-vmd.html M globalcollect_gateway/forms/html/cc/cc-vmj.html M globalcollect_gateway/forms/html/cc/cc.html 15 files changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface refs/changes/07/19407/1 -- To view, visit https://gerrit.wikimedia.org/r/19407 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4ce59c15443ce67cd0e9823a98187cf420673272 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DonationInterface Gerrit-Branch: master Gerrit-Owner: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 36798) sort country names in the UI language - change (mediawiki...CentralNotice[master])
Pgehres has submitted this change and it was merged. Change subject: (bug 36798) sort country names in the UI language .. (bug 36798) sort country names in the UI language This might be an incomplete fix, since I've done nothing special to change the collation locale. https://mingle.corp.wikimedia.org/projects/fundraiser_2012/cards/444 Change-Id: I2f7e62192671c2114b93e8ef4d5e92cce4bcebd6 --- M CentralNotice.db.php 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Pgehres: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/18480 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f7e62192671c2114b93e8ef4d5e92cce4bcebd6 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/CentralNotice Gerrit-Branch: master Gerrit-Owner: Adamw awi...@wikimedia.org Gerrit-Reviewer: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Re-enabling credit card forms - change (mediawiki/core[fundraising/1.20])
Pgehres has uploaded a new change for review. Change subject: Re-enabling credit card forms .. Re-enabling credit card forms Change-Id: I56000517eeef69a5327a4d13dbe78b39c7b03ee0 --- M DonationInterfaceFormSettings.php 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/81/18481/1 -- To view, visit https://gerrit.wikimedia.org/r/18481 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I56000517eeef69a5327a4d13dbe78b39c7b03ee0 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: fundraising/1.20 Gerrit-Owner: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Updating the .gitreview in the fundraising branch so that gi... - change (mediawiki/core[fundraising/1.20])
Pgehres has uploaded a new change for review. Change subject: Updating the .gitreview in the fundraising branch so that git review works by default .. Updating the .gitreview in the fundraising branch so that git review works by default Change-Id: I0e49949a46ac1a887e66f1992144865191716427 --- M .gitreview 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/85/18485/1 -- To view, visit https://gerrit.wikimedia.org/r/18485 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0e49949a46ac1a887e66f1992144865191716427 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: fundraising/1.20 Gerrit-Owner: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix for a logic problem suffered by what appears to be all m... - change (mediawiki...DonationInterface[master])
Pgehres has submitted this change and it was merged. Change subject: Fix for a logic problem suffered by what appears to be all major international banking institutions that issue credit cards with AVS data. Apparently, supplying no information (or in some cases, no NUMERIC INFORMATION) in two fields will cause most banks .. Fix for a logic problem suffered by what appears to be all major international banking institutions that issue credit cards with AVS data. Apparently, supplying no information (or in some cases, no NUMERIC INFORMATION) in two fields will cause most banks to short-circuit their own AVS checking systems. Change-Id: Ie5e8fa37aa98fdad97bf3c8fde23245d689cbec9 --- M gateway_common/DataValidator.php M globalcollect_gateway/globalcollect.adapter.php 2 files changed, 57 insertions(+), 1 deletion(-) Approvals: Pgehres: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/18487 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5e8fa37aa98fdad97bf3c8fde23245d689cbec9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DonationInterface Gerrit-Branch: master Gerrit-Owner: Katie Horn kh...@wikimedia.org Gerrit-Reviewer: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Tiny fix to make the example link work for allocations API - change (mediawiki...CentralNotice[master])
Pgehres has uploaded a new change for review. Change subject: Tiny fix to make the example link work for allocations API .. Tiny fix to make the example link work for allocations API Change-Id: I2fad18054ee3d45c6227fcf9eefc24a94b702491 --- M api/ApiCentralNoticeAllocations.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice refs/changes/29/18629/1 -- To view, visit https://gerrit.wikimedia.org/r/18629 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2fad18054ee3d45c6227fcf9eefc24a94b702491 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/CentralNotice Gerrit-Branch: master Gerrit-Owner: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Adding magic words for campaign and banner per Mingle card #... - change (mediawiki...CentralNotice[master])
Pgehres has submitted this change and it was merged. Change subject: Adding magic words for campaign and banner per Mingle card #514 .. Adding magic words for campaign and banner per Mingle card #514 Change-Id: I896dc73b251d8b72e7659dd8b19d48ab5e91edb2 --- M special/SpecialBannerLoader.php M special/SpecialNoticeTemplate.php 2 files changed, 17 insertions(+), 1 deletion(-) Approvals: Pgehres: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/18703 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I896dc73b251d8b72e7659dd8b19d48ab5e91edb2 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/CentralNotice Gerrit-Branch: master Gerrit-Owner: Kaldari rkald...@wikimedia.org Gerrit-Reviewer: Mwalker mwal...@wikimedia.org Gerrit-Reviewer: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Adding basic version of GatewayFormChooser as a gateway-agno... - change (mediawiki...DonationInterface[master])
Pgehres has submitted this change and it was merged. Change subject: Adding basic version of GatewayFormChooser as a gateway-agnostic entry point into DonationInterface. .. Adding basic version of GatewayFormChooser as a gateway-agnostic entry point into DonationInterface. Change-Id: I61aedf95eb9ae51af80cf6f63e61b5dab936d2ee --- M donationinterface.php A special/GatewayFormChooser.php 2 files changed, 147 insertions(+), 0 deletions(-) Approvals: Pgehres: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/18055 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61aedf95eb9ae51af80cf6f63e61b5dab936d2ee Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/DonationInterface Gerrit-Branch: master Gerrit-Owner: Pgehres pgeh...@wikimedia.org Gerrit-Reviewer: Mwalker mwal...@wikimedia.org Gerrit-Reviewer: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Adding $wgDonationInterfaceFormMap for testing and developme... - change (mediawiki/core[fundraising/1.20])
Pgehres has uploaded a new change for review. Change subject: Adding $wgDonationInterfaceFormMap for testing and development of new first-step forms. .. Adding $wgDonationInterfaceFormMap for testing and development of new first-step forms. Change-Id: Ic7bdcd5eb1b8a1a8d4e96023f68281cda7dded4e --- M DonationInterfaceFormSettings.php 1 file changed, 34 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/84/18184/1 -- To view, visit https://gerrit.wikimedia.org/r/18184 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic7bdcd5eb1b8a1a8d4e96023f68281cda7dded4e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: fundraising/1.20 Gerrit-Owner: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Disabling credit card forms - change (mediawiki/core[fundraising/1.20])
Pgehres has uploaded a new change for review. Change subject: Disabling credit card forms .. Disabling credit card forms Change-Id: Ia132ac24ce0abfb5553ce2531a02c6f83c9a03dd --- M DonationInterfaceFormSettings.php 1 file changed, 25 insertions(+), 19 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/04/18204/1 -- To view, visit https://gerrit.wikimedia.org/r/18204 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia132ac24ce0abfb5553ce2531a02c6f83c9a03dd Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: fundraising/1.20 Gerrit-Owner: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Readding CentralNoticeDB::getBannersByTarget() for back-comp... - change (mediawiki...CentralNotice[master])
Pgehres has submitted this change and it was merged. Change subject: Readding CentralNoticeDB::getBannersByTarget() for back-compat during upgrade. .. Readding CentralNoticeDB::getBannersByTarget() for back-compat during upgrade. Change-Id: I4197de4424b503d0fc43044b115a095ffe7b6d49 --- M CentralNotice.db.php 1 file changed, 88 insertions(+), 0 deletions(-) Approvals: Pgehres: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/17664 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4197de4424b503d0fc43044b115a095ffe7b6d49 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/CentralNotice Gerrit-Branch: master Gerrit-Owner: Kaldari rkald...@wikimedia.org Gerrit-Reviewer: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Adding forms that will only ask for the donor's name and ema... - change (mediawiki...DonationInterface[master])
Pgehres has uploaded a new change for review. Change subject: Adding forms that will only ask for the donor's name and email to test whether or not asking for more information than we need hurts the overall conversion rate for the second step forms. .. Adding forms that will only ask for the donor's name and email to test whether or not asking for more information than we need hurts the overall conversion rate for the second step forms. Change-Id: I164c071c6059d139b6815b137ab91c6ca8c48c7c --- A globalcollect_gateway/forms/html/_name-email/default.html A globalcollect_gateway/forms/html/cc-emailonly/cc-vm.html A globalcollect_gateway/forms/html/cc-emailonly/cc-vma.html A globalcollect_gateway/forms/html/cc-emailonly/cc-vmaj.html 4 files changed, 377 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface refs/changes/57/17457/1 -- To view, visit https://gerrit.wikimedia.org/r/17457 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I164c071c6059d139b6815b137ab91c6ca8c48c7c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DonationInterface Gerrit-Branch: master Gerrit-Owner: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Whitelisting new forms for testing. - change (mediawiki/core[fundraising/1.20])
Pgehres has uploaded a new change for review. Change subject: Whitelisting new forms for testing. .. Whitelisting new forms for testing. Change-Id: Iccd24e176753eb96e61e8741c69242fa5bd68ad0 --- M DonationInterfaceFormSettings.php 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/61/17461/1 -- To view, visit https://gerrit.wikimedia.org/r/17461 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iccd24e176753eb96e61e8741c69242fa5bd68ad0 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: fundraising/1.20 Gerrit-Owner: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] [FR2012: #45] Addition of read only API for CN allocations. - change (mediawiki...CentralNotice[master])
Pgehres has submitted this change and it was merged. Change subject: [FR2012: #45] Addition of read only API for CN allocations. .. [FR2012: #45] Addition of read only API for CN allocations. A new action API call has been added 'centralnoticeallocations' which will allow any third party to obtain the banner allocations (via JSON, XML crashes) for a given filter (project, country, language). Change-Id: I8728adcef6b3ff4b4464e7cc80c80f3171dab850 --- M CentralNotice.db.php M CentralNotice.php A api/ApiCentralNoticeAllocations.php M special/SpecialBannerAllocation.php M special/SpecialBannerListLoader.php 5 files changed, 597 insertions(+), 368 deletions(-) Approvals: Pgehres: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/17011 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8728adcef6b3ff4b4464e7cc80c80f3171dab850 Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/CentralNotice Gerrit-Branch: master Gerrit-Owner: Mwalker mwal...@wikimedia.org Gerrit-Reviewer: Kaldari rkald...@wikimedia.org Gerrit-Reviewer: Mwalker mwal...@wikimedia.org Gerrit-Reviewer: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 38805) decodeURI breaks site JS due to a malformed URI - change (mediawiki...CentralNotice[master])
Pgehres has submitted this change and it was merged. Change subject: (bug 38805) decodeURI breaks site JS due to a malformed URI .. (bug 38805) decodeURI breaks site JS due to a malformed URI Wrapping decodeURIComponent in a try ... catch block, because SpecialBannerController.php may crash with a Malformed URI exception Change-Id: Icab22e6e858e95c8197f51f72d958608a87d6fd5 --- M special/SpecialBannerController.php 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Pgehres: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16934 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icab22e6e858e95c8197f51f72d958608a87d6fd5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/CentralNotice Gerrit-Branch: master Gerrit-Owner: Hoo man h...@online.de Gerrit-Reviewer: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Switching to protocol relative URLs. - change (mediawiki...DonationInterface[master])
Pgehres has submitted this change and it was merged. Change subject: Switching to protocol relative URLs. .. Switching to protocol relative URLs. Change-Id: I7c8b8c11c56486eb486096d2628ac40757fe747c --- M gateway_common/interface.i18n.php 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Pgehres: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16710 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c8b8c11c56486eb486096d2628ac40757fe747c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DonationInterface Gerrit-Branch: master Gerrit-Owner: Kaldari rkald...@wikimedia.org Gerrit-Reviewer: Mwalker mwal...@wikimedia.org Gerrit-Reviewer: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 37397) FundraiserRedirector should detect browser langu... - change (mediawiki...FundraiserLandingPage[master])
Pgehres has submitted this change and it was merged. Change subject: (bug 37397) FundraiserRedirector should detect browser language .. (bug 37397) FundraiserRedirector should detect browser language The FundraiserRedirector, used for accessing donate.wikimedia.org, now allows passing a 'uselang' parameter. When not set, it will search through the browser language settings for a language code that is recognised in MediaWiki. Also changed the special page to use local context instead of globals. Change-Id: Ia87817b595473be3d6d858876a929b37463205f7 --- M FundraiserRedirector.body.php 1 file changed, 21 insertions(+), 5 deletions(-) Approvals: Pgehres: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/16465 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia87817b595473be3d6d858876a929b37463205f7 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/FundraiserLandingPage Gerrit-Branch: master Gerrit-Owner: SPQRobin robinp.1...@gmail.com Gerrit-Reviewer: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Changing listToText() to commaList() - listToText doesn't ac... - change (mediawiki...CentralNotice[master])
Pgehres has submitted this change and it was merged. Change subject: Changing listToText() to commaList() - listToText doesn't accept associative arrays or single item arrays :( .. Changing listToText() to commaList() - listToText doesn't accept associative arrays or single item arrays :( Change-Id: I557952014e07c2bd897581e93ba2fb690cfa722a --- M CentralNoticeCampaignLogPager.php 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Pgehres: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/15843 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I557952014e07c2bd897581e93ba2fb690cfa722a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/CentralNotice Gerrit-Branch: master Gerrit-Owner: Kaldari rkald...@wikimedia.org Gerrit-Reviewer: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix direct debit processing. FR card #35 - change (mediawiki...DonationInterface[master])
Pgehres has submitted this change and it was merged. Change subject: Fix direct debit processing. FR card #35 .. Fix direct debit processing. FR card #35 Most importantly, the SET_PAYMENT was not being sent. I've disabled HOSTEDINDICATOR and correctly set field validation. Warnings during DO_BANKVALIDATION are logged but do not fail the transaction. Direct debit has been tested and succeeds on AT, ES, NL, DE, and BE IT should work in theory, but we have no test acct no.s Change-Id: I07b80a1a861c048ea44aae64ec6ab4d99ea04d75 --- M globalcollect_gateway/globalcollect.adapter.php M globalcollect_gateway/globalcollect_gateway.body.php 2 files changed, 66 insertions(+), 69 deletions(-) Approvals: Pgehres: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/15582 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07b80a1a861c048ea44aae64ec6ab4d99ea04d75 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DonationInterface Gerrit-Branch: master Gerrit-Owner: Adamw s...@ludd.net Gerrit-Reviewer: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Removing support for utm_key from CentralNotice. - change (mediawiki...CentralNotice[master])
Pgehres has uploaded a new change for review. Change subject: Removing support for utm_key from CentralNotice. .. Removing support for utm_key from CentralNotice. It was known, but as written it breaks caching on the landing pages. Testing proved that it was not sufficiently helpful to our analytics to justify the loss of caching. Change-Id: Ib5e4b57446e7f0168f321f8854b1892355594032 --- M special/SpecialBannerController.php 1 file changed, 0 insertions(+), 5 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice refs/changes/88/14088/1 -- To view, visit https://gerrit.wikimedia.org/r/14088 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib5e4b57446e7f0168f321f8854b1892355594032 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/CentralNotice Gerrit-Branch: master Gerrit-Owner: Pgehres pgeh...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
