[MediaWiki-commits] [Gerrit] Remove not needed and - change (mediawiki...WikibaseQualityExternalValidation)

2015-10-04 Thread Jeroen De Dauw (Code Review) 
Jeroen De Dauw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/243491

Change subject: Remove not needed and
..

Remove not needed and

Change-Id: I06b99bc77318c03595377614ee75715031a60923
---
M includes/CrossCheck/Comparer/TimeValueComparer.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseQualityExternalValidation
 refs/changes/91/243491/1

diff --git a/includes/CrossCheck/Comparer/TimeValueComparer.php 
b/includes/CrossCheck/Comparer/TimeValueComparer.php
index 2ea130c..d5f231c 100644
--- a/includes/CrossCheck/Comparer/TimeValueComparer.php
+++ b/includes/CrossCheck/Comparer/TimeValueComparer.php
@@ -79,7 +79,7 @@
 
switch ( $precision ) {
case TimeValue::PRECISION_SECOND:
-   $result = $result && $diff->s === 0;
+   $result = $diff->s === 0;
// Fall through with no break/return. This is 
critical for this algorithm.
case TimeValue::PRECISION_MINUTE:
$result = $result && $diff->i === 0;

-- 
To view, visit https://gerrit.wikimedia.org/r/243491
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I06b99bc77318c03595377614ee75715031a60923
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityExternalValidation
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove not needed and - change (mediawiki...WikibaseQualityExternalValidation)

2015-10-04 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Remove not needed and
..


Remove not needed and

Change-Id: I06b99bc77318c03595377614ee75715031a60923
---
M includes/CrossCheck/Comparer/TimeValueComparer.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Thiemo Mättig (WMDE): Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/CrossCheck/Comparer/TimeValueComparer.php 
b/includes/CrossCheck/Comparer/TimeValueComparer.php
index 2ea130c..d5f231c 100644
--- a/includes/CrossCheck/Comparer/TimeValueComparer.php
+++ b/includes/CrossCheck/Comparer/TimeValueComparer.php
@@ -79,7 +79,7 @@
 
switch ( $precision ) {
case TimeValue::PRECISION_SECOND:
-   $result = $result && $diff->s === 0;
+   $result = $diff->s === 0;
// Fall through with no break/return. This is 
critical for this algorithm.
case TimeValue::PRECISION_MINUTE:
$result = $result && $diff->i === 0;

-- 
To view, visit https://gerrit.wikimedia.org/r/243491
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I06b99bc77318c03595377614ee75715031a60923
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/WikibaseQualityExternalValidation
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw 
Gerrit-Reviewer: Thiemo Mättig (WMDE) 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits