[MediaWiki-commits] [Gerrit] Replace the custom dropdown with a native element. - change (wikimedia/portals)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Replace the custom dropdown with a native   element.
..


Replace the custom dropdown with a native 
 element.

 - First implementation for old browsers, and non-JS:
- Styling this native  element as well as we
  can, but it may look a little odd with old browsers.
- Solves mobile user experience issues because the
  device's native selector will be triggered and is
  a lot easier to use.
- Solves non-JS traffic because it's a native 
  now.

- Second implementation requiring JS:
- When JS is enabled, we make the native select
  transparent.
- We add and place a label on top of it containing
  just the language code, so the language picker
  takes less space in the search input.

Bug: T125571
Change-Id: I1c64fa7b3f86eeb4780fa439c37f0f5848848a0b
---
M dev/wikipedia.org/assets/css/style.css
A dev/wikipedia.org/assets/js/search-language-picker.js
M dev/wikipedia.org/assets/js/wikipedia-org-event-logging.js
M dev/wikipedia.org/assets/js/wm-portal.js
M dev/wikipedia.org/assets/postcss/_ie.css
M dev/wikipedia.org/assets/postcss/_pab1.css
A dev/wikipedia.org/assets/postcss/_search-language-picker.css
M dev/wikipedia.org/assets/postcss/style.css
M dev/wikipedia.org/assets/rev-manifest.json
M dev/wikipedia.org/index.handlebars
M dev/wikipedia.org/templates/search.handlebars
A prod/wikipedia.org/assets/js/gt-ie9-c84bf66d33.js
R prod/wikipedia.org/assets/js/index-b335ba9eb0.js
M prod/wikipedia.org/index.html
14 files changed, 465 insertions(+), 196 deletions(-)

Approvals:
  Jdrewniak: Looks good to me, approved
  jenkins-bot: Verified




-- 
To view, visit https://gerrit.wikimedia.org/r/274681
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1c64fa7b3f86eeb4780fa439c37f0f5848848a0b
Gerrit-PatchSet: 3
Gerrit-Project: wikimedia/portals
Gerrit-Branch: search-box
Gerrit-Owner: Jdrewniak 
Gerrit-Reviewer: JGirault 
Gerrit-Reviewer: Jdrewniak 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Replace the custom dropdown with a native element. - change (wikimedia/portals)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Replace the custom dropdown with a native   element.
..


Replace the custom dropdown with a native 
 element.

 - Styling this native  element as well as we can, but it may look a 
little odd with old browsers.
 - Solves mobile user experience issues because the device's native selector 
will be triggered and is a lot easier to use.
 - Solves non-JS traffic because it's a native  now
Though the user experience is a little worse than when JS is enabled. 
(We need JS to make the custom arrow clickable)

Bug: T125571
Change-Id: Ie0f43b46007d7c3a73a566dae16fce2a31e9b8f2
---
M dev/wikipedia.org/assets/css/style.css
M dev/wikipedia.org/assets/js/pab2.js
M dev/wikipedia.org/assets/js/wm-portal.js
M dev/wikipedia.org/assets/postcss/_pab1.css
M dev/wikipedia.org/assets/postcss/_wm-portal.css
M dev/wikipedia.org/assets/rev-manifest.json
M dev/wikipedia.org/index.handlebars
D dev/wikipedia.org/templates/search-pab1.handlebars
D dev/wikipedia.org/templates/search-pab1.option.handlebars
M dev/wikipedia.org/templates/search.handlebars
D prod/wikipedia.org/assets/js/index-7ded0ace2c.js
A prod/wikipedia.org/assets/js/index-8366dee471.js
M prod/wikipedia.org/index.html
13 files changed, 352 insertions(+), 890 deletions(-)

Approvals:
  JGirault: Looks good to me, approved
  jenkins-bot: Verified

Objections:
  Jdrewniak: There's a problem with this change, please improve




-- 
To view, visit https://gerrit.wikimedia.org/r/274332
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0f43b46007d7c3a73a566dae16fce2a31e9b8f2
Gerrit-PatchSet: 2
Gerrit-Project: wikimedia/portals
Gerrit-Branch: search-box
Gerrit-Owner: JGirault 
Gerrit-Reviewer: JGirault 
Gerrit-Reviewer: Jdrewniak 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Replace the custom dropdown with a native element. - change (wikimedia/portals)

[JGirault (Code Review)]

JGirault has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/274332

Change subject: Replace the custom dropdown with a native   element.
..

Replace the custom dropdown with a native 
 element.

 - Styling this native  element as well as we can, but it may look a 
little odd with old browsers.
 - Solves mobile user experience issues because the device's native selector 
will be triggered and is a lot easier to use.
 - Solves non-JS traffic because it's a native  now
Though the user experience is a little worse than when JS is enabled. 
(We need JS to make the custom arrow clickable)

Bug: T125571
Change-Id: Ie0f43b46007d7c3a73a566dae16fce2a31e9b8f2
---
M dev/wikipedia.org/assets/css/style.css
M dev/wikipedia.org/assets/js/pab2.js
M dev/wikipedia.org/assets/js/wm-portal.js
M dev/wikipedia.org/assets/postcss/_pab1.css
M dev/wikipedia.org/assets/postcss/_wm-portal.css
M dev/wikipedia.org/assets/rev-manifest.json
M dev/wikipedia.org/index.handlebars
D dev/wikipedia.org/templates/search-pab1.handlebars
D dev/wikipedia.org/templates/search-pab1.option.handlebars
M dev/wikipedia.org/templates/search.handlebars
D prod/wikipedia.org/assets/js/index-7ded0ace2c.js
A prod/wikipedia.org/assets/js/index-8366dee471.js
M prod/wikipedia.org/index.html
13 files changed, 333 insertions(+), 885 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/portals 
refs/changes/32/274332/1


-- 
To view, visit https://gerrit.wikimedia.org/r/274332
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie0f43b46007d7c3a73a566dae16fce2a31e9b8f2
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/portals
Gerrit-Branch: search-box
Gerrit-Owner: JGirault 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits