[MediaWiki-commits] [Gerrit] Review: Fixed wrong permission error - change (mediawiki...BlueSpiceExtensions)

2015-02-09 Thread Pwirth (Code Review) 
Pwirth has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/189445

Change subject: Review: Fixed wrong permission error
..

Review: Fixed wrong permission error

* Added ! to expression
* I646154023bed3b88042bc8282abf57c1dc34529b

Change-Id: Ib9f9c4830b758df5e318845a3bfe4f88fbb3d391
---
M Review/Review.class.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceExtensions 
refs/changes/45/189445/1

diff --git a/Review/Review.class.php b/Review/Review.class.php
index 972867f..f51947a 100644
--- a/Review/Review.class.php
+++ b/Review/Review.class.php
@@ -1026,7 +1026,7 @@
if ($oTitle === false || !$oTitle-exists() || $oUser === 
false){
return wfMessage('bs-review-review-error')-plain();
}
-   if ($oTitle-userCan(workflowview, $oUser)) {
+   if (!$oTitle-userCan(workflowview, $oUser)) {
return 
wfMessage('bs-review-error-insufficient-permissions', 'workflowview')-text();
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/189445
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib9f9c4830b758df5e318845a3bfe4f88fbb3d391
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: REL1_23
Gerrit-Owner: Pwirth wi...@hallowelt.biz

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Review: Fixed wrong permission error - change (mediawiki...BlueSpiceExtensions)

2015-02-09 Thread Robert Vogel (Code Review) 
Robert Vogel has submitted this change and it was merged.

Change subject: Review: Fixed wrong permission error
..


Review: Fixed wrong permission error

* Added ! to expression
* I646154023bed3b88042bc8282abf57c1dc34529b

Change-Id: Ib9f9c4830b758df5e318845a3bfe4f88fbb3d391
---
M Review/Review.class.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Robert Vogel: Verified; Looks good to me, approved



diff --git a/Review/Review.class.php b/Review/Review.class.php
index 972867f..f51947a 100644
--- a/Review/Review.class.php
+++ b/Review/Review.class.php
@@ -1026,7 +1026,7 @@
if ($oTitle === false || !$oTitle-exists() || $oUser === 
false){
return wfMessage('bs-review-review-error')-plain();
}
-   if ($oTitle-userCan(workflowview, $oUser)) {
+   if (!$oTitle-userCan(workflowview, $oUser)) {
return 
wfMessage('bs-review-error-insufficient-permissions', 'workflowview')-text();
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/189445
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9f9c4830b758df5e318845a3bfe4f88fbb3d391
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: REL1_23
Gerrit-Owner: Pwirth wi...@hallowelt.biz
Gerrit-Reviewer: Mglaser gla...@hallowelt.biz
Gerrit-Reviewer: Pigpen reym...@hallowelt.biz
Gerrit-Reviewer: Robert Vogel vo...@hallowelt.biz
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Review: Fixed wrong permission error - change (mediawiki...BlueSpiceExtensions)

2015-02-06 Thread Pwirth (Code Review) 
Pwirth has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/189008

Change subject: Review: Fixed wrong permission error
..

Review: Fixed wrong permission error

* Added ! to expression

Change-Id: I646154023bed3b88042bc8282abf57c1dc34529b
---
M Review/Review.class.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceExtensions 
refs/changes/08/189008/1

diff --git a/Review/Review.class.php b/Review/Review.class.php
index 3ad0cba..dc387ed 100644
--- a/Review/Review.class.php
+++ b/Review/Review.class.php
@@ -1031,7 +1031,7 @@
if ($oTitle === false || !$oTitle-exists() || $oUser === 
false){
return wfMessage('bs-review-review-error')-plain();
}
-   if ($oTitle-userCan(workflowview, $oUser)) {
+   if (!$oTitle-userCan(workflowview, $oUser)) {
return 
wfMessage('bs-review-error-insufficient-permissions', 'workflowview')-text();
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/189008
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I646154023bed3b88042bc8282abf57c1dc34529b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: master
Gerrit-Owner: Pwirth wi...@hallowelt.biz

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Review: Fixed wrong permission error - change (mediawiki...BlueSpiceExtensions)

2015-02-06 Thread Pigpen (Code Review) 
Pigpen has submitted this change and it was merged.

Change subject: Review: Fixed wrong permission error
..


Review: Fixed wrong permission error

* Added ! to expression

Change-Id: I646154023bed3b88042bc8282abf57c1dc34529b
---
M Review/Review.class.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Pigpen: Verified; Looks good to me, approved



diff --git a/Review/Review.class.php b/Review/Review.class.php
index 3ad0cba..dc387ed 100644
--- a/Review/Review.class.php
+++ b/Review/Review.class.php
@@ -1031,7 +1031,7 @@
if ($oTitle === false || !$oTitle-exists() || $oUser === 
false){
return wfMessage('bs-review-review-error')-plain();
}
-   if ($oTitle-userCan(workflowview, $oUser)) {
+   if (!$oTitle-userCan(workflowview, $oUser)) {
return 
wfMessage('bs-review-error-insufficient-permissions', 'workflowview')-text();
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/189008
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I646154023bed3b88042bc8282abf57c1dc34529b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: master
Gerrit-Owner: Pwirth wi...@hallowelt.biz
Gerrit-Reviewer: Mglaser gla...@hallowelt.biz
Gerrit-Reviewer: Pigpen reym...@hallowelt.biz
Gerrit-Reviewer: Robert Vogel vo...@hallowelt.biz
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits