[MediaWiki-commits] [Gerrit] Use embed the correct way, fix Nokia N95s - change (mediawiki...MobileFrontend)

2013-04-02 Thread awjrichards (Code Review) 
awjrichards has submitted this change and it was merged.

Change subject: Use embed the correct way, fix Nokia N95s
..


Use embed the correct way, fix Nokia N95s

This is producing invalid css which is breaking the mobile
experience for a variety of older phones who cannot handle css parse
errors.

Change-Id: Ie0dadd0773ea1c585083de6eeff04d009442a176
---
M less/common/mainmenu.less
M less/common/mf-navigation.less
M stylesheets/common/mf-navigation.css
M stylesheets/common/ui.css
4 files changed, 25 insertions(+), 16 deletions(-)

Approvals:
  Brion VIBBER: Checked; Looks good to me, but someone else must approve
  awjrichards: Verified; Looks good to me, approved



diff --git a/less/common/mainmenu.less b/less/common/mainmenu.less
index 3b7a918..9442810 100644
--- a/less/common/mainmenu.less
+++ b/less/common/mainmenu.less
@@ -51,31 +51,31 @@
}
 
.icon-home a {
-   background-image: /* @embed */url(images/menu/home.png);
+   /* @embed */background-image: url(images/menu/home.png);
}
 
.icon-random a {
-   background-image: /* @embed 
*/url(images/menu/random.png);
+   /* @embed */background-image: 
url(images/menu/random.png);
}
 
.icon-watchlist a {
-   background-image: /* @embed 
*/url(images/menu/watchlist.png);
+   /* @embed */background-image: 
url(images/menu/watchlist.png);
}
 
.icon-uploads a {
-   background-image: /* @embed 
*/url(images/menu/uploads.png);
+   /* @embed */background-image: 
url(images/menu/uploads.png);
}
 
.icon-nearby a {
-   background-image: /* @embed 
*/url(images/menu/nearby.png);
+   /* @embed */background-image: 
url(images/menu/nearby.png);
}
 
.icon-settings a {
-   background-image: /* @embed 
*/url(images/menu/settings.png);
+   /* @embed */background-image: 
url(images/menu/settings.png);
}
 
.icon-loginout a {
-   background-image: /* @embed 
*/url(images/menu/loginout.png);
+   /* @embed */background-image: 
url(images/menu/loginout.png);
}
}
 }
diff --git a/less/common/mf-navigation.less b/less/common/mf-navigation.less
index e234766..f326ab5 100644
--- a/less/common/mf-navigation.less
+++ b/less/common/mf-navigation.less
@@ -16,7 +16,8 @@
 
 .client-js {
#mw-mf-main-menu-button {
-   background-image: /* @embed */ url(images/menu/main.png);
+   /* @embed */background-image: url(images/menu/main.png);
+
}
 }
 
diff --git a/stylesheets/common/mf-navigation.css 
b/stylesheets/common/mf-navigation.css
index d2f52b0..3fbbb26 100644
--- a/stylesheets/common/mf-navigation.css
+++ b/stylesheets/common/mf-navigation.css
@@ -2,7 +2,8 @@
   right: 0;
 }
 .client-js #mw-mf-main-menu-button {
-  background-image: /* @embed */ url(images/menu/main.png);
+  /* @embed */
+  background-image: url(images/menu/main.png);
 }
 #mw-mf-viewport {
   width: 100%;
diff --git a/stylesheets/common/ui.css b/stylesheets/common/ui.css
index af23f98..cc2c5fc 100644
--- a/stylesheets/common/ui.css
+++ b/stylesheets/common/ui.css
@@ -174,25 +174,32 @@
   text-decoration: none;
 }
 #mw-mf-menu-main li.icon-home a {
-  background-image: /* @embed */ url(images/menu/home.png);
+  /* @embed */
+  background-image: url(images/menu/home.png);
 }
 #mw-mf-menu-main li.icon-random a {
-  background-image: /* @embed */ url(images/menu/random.png);
+  /* @embed */
+  background-image: url(images/menu/random.png);
 }
 #mw-mf-menu-main li.icon-watchlist a {
-  background-image: /* @embed */ url(images/menu/watchlist.png);
+  /* @embed */
+  background-image: url(images/menu/watchlist.png);
 }
 #mw-mf-menu-main li.icon-uploads a {
-  background-image: /* @embed */ url(images/menu/uploads.png);
+  /* @embed */
+  background-image: url(images/menu/uploads.png);
 }
 #mw-mf-menu-main li.icon-nearby a {
-  background-image: /* @embed */ url(images/menu/nearby.png);
+  /* @embed */
+  background-image: url(images/menu/nearby.png);
 }
 #mw-mf-menu-main li.icon-settings a {
-  background-image: /* @embed */ url(images/menu/settings.png);
+  /* @embed */
+  background-image: url(images/menu/settings.png);
 }
 #mw-mf-menu-main li.icon-loginout a {
-  background-image: /* @embed */ url(images/menu/loginout.png);
+  /* @embed */
+  background-image: url(images/menu/loginout.png);
 }
 @media all and (min-width: 700px) {
   .navigationEnabled .alpha #mw-mf-page-left,

-- 
To view, visit https://gerrit.wikimedia.org/r/56956
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

[MediaWiki-commits] [Gerrit] Use embed the correct way, fix Nokia N95s - change (mediawiki...MobileFrontend)

2013-04-01 Thread Jdlrobson (Code Review) 
Jdlrobson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/56956


Change subject: Use embed the correct way, fix Nokia N95s
..

Use embed the correct way, fix Nokia N95s

This is producing invalid css which is breaking the mobile
experience for a variety of older phones who cannot handle css parse
errors.

Change-Id: Ie0dadd0773ea1c585083de6eeff04d009442a176
---
A less/common/embed.less
M less/common/mainmenu.less
M less/common/mf-navigation.less
A stylesheets/common/embed.css
M stylesheets/common/mf-navigation.css
M stylesheets/common/ui.css
6 files changed, 25 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/56/56956/1

diff --git a/less/common/embed.less b/less/common/embed.less
new file mode 100644
index 000..e69de29
--- /dev/null
+++ b/less/common/embed.less
diff --git a/less/common/mainmenu.less b/less/common/mainmenu.less
index 3b7a918..9442810 100644
--- a/less/common/mainmenu.less
+++ b/less/common/mainmenu.less
@@ -51,31 +51,31 @@
}
 
.icon-home a {
-   background-image: /* @embed */url(images/menu/home.png);
+   /* @embed */background-image: url(images/menu/home.png);
}
 
.icon-random a {
-   background-image: /* @embed 
*/url(images/menu/random.png);
+   /* @embed */background-image: 
url(images/menu/random.png);
}
 
.icon-watchlist a {
-   background-image: /* @embed 
*/url(images/menu/watchlist.png);
+   /* @embed */background-image: 
url(images/menu/watchlist.png);
}
 
.icon-uploads a {
-   background-image: /* @embed 
*/url(images/menu/uploads.png);
+   /* @embed */background-image: 
url(images/menu/uploads.png);
}
 
.icon-nearby a {
-   background-image: /* @embed 
*/url(images/menu/nearby.png);
+   /* @embed */background-image: 
url(images/menu/nearby.png);
}
 
.icon-settings a {
-   background-image: /* @embed 
*/url(images/menu/settings.png);
+   /* @embed */background-image: 
url(images/menu/settings.png);
}
 
.icon-loginout a {
-   background-image: /* @embed 
*/url(images/menu/loginout.png);
+   /* @embed */background-image: 
url(images/menu/loginout.png);
}
}
 }
diff --git a/less/common/mf-navigation.less b/less/common/mf-navigation.less
index e234766..f326ab5 100644
--- a/less/common/mf-navigation.less
+++ b/less/common/mf-navigation.less
@@ -16,7 +16,8 @@
 
 .client-js {
#mw-mf-main-menu-button {
-   background-image: /* @embed */ url(images/menu/main.png);
+   /* @embed */background-image: url(images/menu/main.png);
+
}
 }
 
diff --git a/stylesheets/common/embed.css b/stylesheets/common/embed.css
new file mode 100644
index 000..e69de29
--- /dev/null
+++ b/stylesheets/common/embed.css
diff --git a/stylesheets/common/mf-navigation.css 
b/stylesheets/common/mf-navigation.css
index d2f52b0..3fbbb26 100644
--- a/stylesheets/common/mf-navigation.css
+++ b/stylesheets/common/mf-navigation.css
@@ -2,7 +2,8 @@
   right: 0;
 }
 .client-js #mw-mf-main-menu-button {
-  background-image: /* @embed */ url(images/menu/main.png);
+  /* @embed */
+  background-image: url(images/menu/main.png);
 }
 #mw-mf-viewport {
   width: 100%;
diff --git a/stylesheets/common/ui.css b/stylesheets/common/ui.css
index af23f98..cc2c5fc 100644
--- a/stylesheets/common/ui.css
+++ b/stylesheets/common/ui.css
@@ -174,25 +174,32 @@
   text-decoration: none;
 }
 #mw-mf-menu-main li.icon-home a {
-  background-image: /* @embed */ url(images/menu/home.png);
+  /* @embed */
+  background-image: url(images/menu/home.png);
 }
 #mw-mf-menu-main li.icon-random a {
-  background-image: /* @embed */ url(images/menu/random.png);
+  /* @embed */
+  background-image: url(images/menu/random.png);
 }
 #mw-mf-menu-main li.icon-watchlist a {
-  background-image: /* @embed */ url(images/menu/watchlist.png);
+  /* @embed */
+  background-image: url(images/menu/watchlist.png);
 }
 #mw-mf-menu-main li.icon-uploads a {
-  background-image: /* @embed */ url(images/menu/uploads.png);
+  /* @embed */
+  background-image: url(images/menu/uploads.png);
 }
 #mw-mf-menu-main li.icon-nearby a {
-  background-image: /* @embed */ url(images/menu/nearby.png);
+  /* @embed */
+  background-image: url(images/menu/nearby.png);
 }
 #mw-mf-menu-main li.icon-settings a {
-  background-image: /* @embed */ url(images/menu/settings.png);
+  /* @embed */
+  background-image: url(images/menu/settings.png);
 }
 #mw-mf-menu-main