[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Enable jsduck for resources/src/mediawiki.rcfilters and make...

2017-07-27 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/368323 )

Change subject: Enable jsduck for resources/src/mediawiki.rcfilters and make 
pass
..


Enable jsduck for resources/src/mediawiki.rcfilters and make pass

Change-Id: I2a29689e2697108a5c5206cc61b36b5fb838182f
---
M jsduck.json
M maintenance/jsduck/categories.json
M resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js
M resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueriesModel.js
M resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueryItemModel.js
M resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
M resources/src/mediawiki.rcfilters/mw.rcfilters.HighlightColors.js
M resources/src/mediawiki.rcfilters/mw.rcfilters.init.js
M resources/src/mediawiki.rcfilters/mw.rcfilters.js
M 
resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ChangesLimitButtonWidget.js
M resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.DateButtonWidget.js
M 
resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterItemHighlightButton.js
M resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterMenuHeaderWidget.js
M 
resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterMenuSectionOptionWidget.js
M 
resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js
M 
resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListItemWidget.js
M resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListWidget.js
M resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ValuePickerWidget.js
18 files changed, 31 insertions(+), 14 deletions(-)

Approvals:
  Krinkle: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/jsduck.json b/jsduck.json
index f7771d1..cbd4676 100644
--- a/jsduck.json
+++ b/jsduck.json
@@ -16,6 +16,7 @@
"resources/src/mediawiki.action",
"resources/src/mediawiki.language",
"resources/src/mediawiki.messagePoster",
+   "resources/src/mediawiki.rcfilters",
"resources/src/mediawiki.special",
"resources/src/mediawiki.toolbar",
"resources/src/mediawiki.widgets",
diff --git a/maintenance/jsduck/categories.json 
b/maintenance/jsduck/categories.json
index 2c8c8b0..899d80d 100644
--- a/maintenance/jsduck/categories.json
+++ b/maintenance/jsduck/categories.json
@@ -66,7 +66,8 @@
"mw.Upload*",
"mw.ForeignUpload",
"mw.ForeignStructuredUpload*",
-   "mw.GallerySlideshow"
+   "mw.GallerySlideshow",
+   "mw.rcfilters*"
]
},
{
diff --git 
a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js 
b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js
index 3281735..4ea1e03 100644
--- a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js
+++ b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js
@@ -634,7 +634,7 @@
/**
 * Get the highlight parameters based on current filter configuration
 *
-* @return {Object} Object where keys are "_color" and 
values
+* @return {Object} Object where keys are `_color` and 
values
 *  are the selected highlight colors.
 */
mw.rcfilters.dm.FiltersViewModel.prototype.getHighlightParameters = 
function () {
@@ -656,7 +656,7 @@
 *
 * @param {Object} representation Object containing representation of
 *  some or all highlight values
-* @return {Object} Object where keys are "_color" and 
values
+* @return {Object} Object where keys are `_color` and 
values
 *  are the selected highlight colors. The returned 
object
 *  contains all available filters either with a color 
value
 *  or with null.
diff --git 
a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueriesModel.js 
b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueriesModel.js
index 8536570..29134a5 100644
--- a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueriesModel.js
+++ b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueriesModel.js
@@ -2,6 +2,7 @@
/**
 * View model for saved queries
 *
+* @class
 * @mixins OO.EventEmitter
 * @mixins OO.EmitterList
 *
diff --git 
a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueryItemModel.js 
b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueryItemModel.js
index 729aee3..c066a1f 100644
---

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Enable jsduck for resources/src/mediawiki.rcfilters and make...

2017-07-27 Thread Catrope (Code Review) 
Catrope has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/368323 )

Change subject: Enable jsduck for resources/src/mediawiki.rcfilters and make 
pass
..

Enable jsduck for resources/src/mediawiki.rcfilters and make pass

Change-Id: I2a29689e2697108a5c5206cc61b36b5fb838182f
---
M jsduck.json
M maintenance/jsduck/categories.json
M resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js
M resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueriesModel.js
M resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueryItemModel.js
M resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
M resources/src/mediawiki.rcfilters/mw.rcfilters.HighlightColors.js
M resources/src/mediawiki.rcfilters/mw.rcfilters.js
M 
resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ChangesLimitButtonWidget.js
M resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.DateButtonWidget.js
M 
resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterItemHighlightButton.js
M resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterMenuHeaderWidget.js
M 
resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterMenuSectionOptionWidget.js
M 
resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js
M 
resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListItemWidget.js
M resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.SavedLinksListWidget.js
M resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.ValuePickerWidget.js
17 files changed, 23 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/23/368323/1

diff --git a/jsduck.json b/jsduck.json
index f7771d1..cbd4676 100644
--- a/jsduck.json
+++ b/jsduck.json
@@ -16,6 +16,7 @@
"resources/src/mediawiki.action",
"resources/src/mediawiki.language",
"resources/src/mediawiki.messagePoster",
+   "resources/src/mediawiki.rcfilters",
"resources/src/mediawiki.special",
"resources/src/mediawiki.toolbar",
"resources/src/mediawiki.widgets",
diff --git a/maintenance/jsduck/categories.json 
b/maintenance/jsduck/categories.json
index 2c8c8b0..899d80d 100644
--- a/maintenance/jsduck/categories.json
+++ b/maintenance/jsduck/categories.json
@@ -66,7 +66,8 @@
"mw.Upload*",
"mw.ForeignUpload",
"mw.ForeignStructuredUpload*",
-   "mw.GallerySlideshow"
+   "mw.GallerySlideshow",
+   "mw.rcfilters*"
]
},
{
diff --git 
a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js 
b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js
index 3281735..4ea1e03 100644
--- a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js
+++ b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js
@@ -634,7 +634,7 @@
/**
 * Get the highlight parameters based on current filter configuration
 *
-* @return {Object} Object where keys are "_color" and 
values
+* @return {Object} Object where keys are `_color` and 
values
 *  are the selected highlight colors.
 */
mw.rcfilters.dm.FiltersViewModel.prototype.getHighlightParameters = 
function () {
@@ -656,7 +656,7 @@
 *
 * @param {Object} representation Object containing representation of
 *  some or all highlight values
-* @return {Object} Object where keys are "_color" and 
values
+* @return {Object} Object where keys are `_color` and 
values
 *  are the selected highlight colors. The returned 
object
 *  contains all available filters either with a color 
value
 *  or with null.
diff --git 
a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueriesModel.js 
b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueriesModel.js
index 8536570..29134a5 100644
--- a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueriesModel.js
+++ b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueriesModel.js
@@ -2,6 +2,7 @@
/**
 * View model for saved queries
 *
+* @class
 * @mixins OO.EventEmitter
 * @mixins OO.EmitterList
 *
diff --git 
a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueryItemModel.js 
b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueryItemModel.js
index 729aee3..c066a1f 100644
--- 
a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.SavedQueryItemModel.js
+++