[MediaWiki-commits] [Gerrit] mediawiki/core[master]: FauxRequest: Complete code coverage for FauxRequestTest

2017-03-31 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/345952 )

Change subject: FauxRequest: Complete code coverage for FauxRequestTest
..


FauxRequest: Complete code coverage for FauxRequestTest

Follows-up d18d030d57b88.

* Add missing case of session being a Session object.

Change-Id: I7da0c6d4a6483d53bcfd56751cd1cb669bd5023e
---
M tests/phpunit/includes/FauxRequestTest.php
1 file changed, 13 insertions(+), 0 deletions(-)

Approvals:
  Aaron Schulz: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/tests/phpunit/includes/FauxRequestTest.php 
b/tests/phpunit/includes/FauxRequestTest.php
index e3713ab..9fe694d 100644
--- a/tests/phpunit/includes/FauxRequestTest.php
+++ b/tests/phpunit/includes/FauxRequestTest.php
@@ -1,5 +1,7 @@
 getEmptySession( new 
FauxRequest( [] ) );
+   $this->assertInstanceOf(
+   FauxRequest::class,
+   new FauxRequest( [], false, $session )
+   );
+   }
+
+   /**
 * @covers FauxRequest::getText
 */
public function testGetText() {

-- 
To view, visit https://gerrit.wikimedia.org/r/345952
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7da0c6d4a6483d53bcfd56751cd1cb669bd5023e
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle 
Gerrit-Reviewer: Aaron Schulz 
Gerrit-Reviewer: Anomie 
Gerrit-Reviewer: Gergő Tisza 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: FauxRequest: Complete code coverage for FauxRequestTest

2017-03-31 Thread Krinkle (Code Review) 
Krinkle has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/345952 )

Change subject: FauxRequest: Complete code coverage for FauxRequestTest
..

FauxRequest: Complete code coverage for FauxRequestTest

* Add missing case of $session being a Session object.

Change-Id: I7da0c6d4a6483d53bcfd56751cd1cb669bd5023e
---
M tests/phpunit/includes/FauxRequestTest.php
1 file changed, 13 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/52/345952/1

diff --git a/tests/phpunit/includes/FauxRequestTest.php 
b/tests/phpunit/includes/FauxRequestTest.php
index e3713ab..9fe694d 100644
--- a/tests/phpunit/includes/FauxRequestTest.php
+++ b/tests/phpunit/includes/FauxRequestTest.php
@@ -1,5 +1,7 @@
 getEmptySession( new 
FauxRequest( [] ) );
+   $this->assertInstanceOf(
+   FauxRequest::class,
+   new FauxRequest( [], false, $session )
+   );
+   }
+
+   /**
 * @covers FauxRequest::getText
 */
public function testGetText() {

-- 
To view, visit https://gerrit.wikimedia.org/r/345952
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7da0c6d4a6483d53bcfd56751cd1cb669bd5023e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits