[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Soft deprecation of DatabaseMysql

2017-08-22 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/329682 )

Change subject: Soft deprecation of DatabaseMysql
..


Soft deprecation of DatabaseMysql

This class is the driver for MySQL databases corresponding to the PHP
extension 'mysql'. This PHP extension was deprecated in PHP 5.5 and
removed in PHP 7.0. It was replaced by the PHP extension 'mysqli',
which is supported and the default MySQL driver since MediaWiki 1.22.

Bug: T120333
Change-Id: Id1478f73e348cdd1ad1f560b1d8ddefe56c52767
---
M RELEASE-NOTES-1.30
M includes/libs/rdbms/database/Database.php
M includes/libs/rdbms/database/DatabaseMysql.php
3 files changed, 8 insertions(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/RELEASE-NOTES-1.30 b/RELEASE-NOTES-1.30
index 452cb35..38e5f99 100644
--- a/RELEASE-NOTES-1.30
+++ b/RELEASE-NOTES-1.30
@@ -33,6 +33,10 @@
   use $wgFragmentMode to migrate off it to a modern alternative.
 * $wgExternalInterwikiFragmentMode was introduced to control how fragments in
   sinterwikis going outside of current wiki farm are encoded.
+* (T120333) Soft-deprecated the use of PHP extension 'mysql' in favor of 
'mysqli'.
+  This PHP extension was deprecated in PHP 5.5 and removed in PHP 7.0. 
MediaWiki
+  auto-selects the 'mysqli' driver since MediaWiki 1.22, except if explicitly
+  requested through the configuration parameter $wgDBservers.
 
 === New features in 1.30 ===
 * (T37247) Output from Parser::parse() will now be wrapped in a div with
diff --git a/includes/libs/rdbms/database/Database.php 
b/includes/libs/rdbms/database/Database.php
index b8b44e6..a3b4bca 100644
--- a/includes/libs/rdbms/database/Database.php
+++ b/includes/libs/rdbms/database/Database.php
@@ -2078,7 +2078,7 @@
 * Quotes an identifier using `backticks` or "double quotes" depending 
on the database type.
 * MySQL uses `backticks` while basically everything else uses double 
quotes.
 * Since MySQL is the odd one out here the double quotes are our generic
-* and we implement backticks in DatabaseMysql.
+* and we implement backticks in DatabaseMysqlBase.
 *
 * @param string $s
 * @return string
diff --git a/includes/libs/rdbms/database/DatabaseMysql.php 
b/includes/libs/rdbms/database/DatabaseMysql.php
index 77e797d..d81d909 100644
--- a/includes/libs/rdbms/database/DatabaseMysql.php
+++ b/includes/libs/rdbms/database/DatabaseMysql.php
@@ -25,6 +25,9 @@
 /**
  * Database abstraction object for PHP extension mysql.
  *
+ * @deprecated 1.30 PHP extension 'mysql' was deprecated in PHP 5.5 and 
removed in PHP 7.0.
+ * @see PHP extension 'mysqli' and DatabaseMysqli
+ *
  * @ingroup Database
  * @see Database
  */

-- 
To view, visit https://gerrit.wikimedia.org/r/329682
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id1478f73e348cdd1ad1f560b1d8ddefe56c52767
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Seb35 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Seb35 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Soft deprecation of DatabaseMysql

2016-12-30 Thread Seb35 (Code Review) 
Seb35 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/329682 )

Change subject: Soft deprecation of DatabaseMysql
..

Soft deprecation of DatabaseMysql

This class is the driver for MySQL databases corresponding to the PHP
extension 'mysql'. This PHP extension was deprecated in PHP 5.5 and
removed in PHP 7.0. It was replaced by the PHP extension 'mysqli',
which is supported and the default MySQL driver since MediaWiki 1.22.

Bug: T120333
Change-Id: Id1478f73e348cdd1ad1f560b1d8ddefe56c52767
---
M RELEASE-NOTES-1.29
M includes/libs/rdbms/database/Database.php
M includes/libs/rdbms/database/DatabaseMysql.php
3 files changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/82/329682/1

diff --git a/RELEASE-NOTES-1.29 b/RELEASE-NOTES-1.29
index 774254c..c8a809a 100644
--- a/RELEASE-NOTES-1.29
+++ b/RELEASE-NOTES-1.29
@@ -147,6 +147,9 @@
 * User::getTemporaryPassword() (deprecated in 1.27) was removed.
 * User::isPasswordReminderThrottled() (deprecated in 1.27) was removed.
 * FSRepo (deprecated in 1.19) was removed.
+* (T120333) Soft-deprecated the use of PHP extension 'mysql' in favor of 
'mysqli'
+  (this PHP extension was deprecated in PHP 5.5 and removed in PHP 7.0;
+  MediaWiki auto-selects the 'mysqli' driver since MediaWiki 1.22).
 
 == Compatibility ==
 
diff --git a/includes/libs/rdbms/database/Database.php 
b/includes/libs/rdbms/database/Database.php
index 69cf1ac..6b47178 100644
--- a/includes/libs/rdbms/database/Database.php
+++ b/includes/libs/rdbms/database/Database.php
@@ -1975,7 +1975,7 @@
 * Quotes an identifier using `backticks` or "double quotes" depending 
on the database type.
 * MySQL uses `backticks` while basically everything else uses double 
quotes.
 * Since MySQL is the odd one out here the double quotes are our generic
-* and we implement backticks in DatabaseMysql.
+* and we implement backticks in DatabaseMysqlBase.
 *
 * @param string $s
 * @return string
diff --git a/includes/libs/rdbms/database/DatabaseMysql.php 
b/includes/libs/rdbms/database/DatabaseMysql.php
index 9ab7c64..2d70227 100644
--- a/includes/libs/rdbms/database/DatabaseMysql.php
+++ b/includes/libs/rdbms/database/DatabaseMysql.php
@@ -24,6 +24,7 @@
 /**
  * Database abstraction object for PHP extension mysql.
  *
+ * @deprecated 1.29:1.31 The PHP extension 'mysql' was deprecated in PHP 5.5 
and removed in PHP 7.0, it is replaced by the PHP extension 'mysqli'.
  * @ingroup Database
  * @see Database
  */

-- 
To view, visit https://gerrit.wikimedia.org/r/329682
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id1478f73e348cdd1ad1f560b1d8ddefe56c52767
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Seb35 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits