[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Use padding instead of margin to close a gap

2017-11-21 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/392772 )

Change subject: Use padding instead of margin to close a gap
..


Use padding instead of margin to close a gap

Clicking between the radio button and the logo should count as
a click on the thing.

Change-Id: I871fcbdd3a67e44be5a0ab2cec14e2d2ddbabb4c
---
M gateway_forms/mustache/forms.css
M gateway_forms/mustache/payment_method.html.mustache
2 files changed, 4 insertions(+), 8 deletions(-)

Approvals:
  XenoRyet: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/gateway_forms/mustache/forms.css b/gateway_forms/mustache/forms.css
index c74fd0f..cf0dc1e 100644
--- a/gateway_forms/mustache/forms.css
+++ b/gateway_forms/mustache/forms.css
@@ -274,14 +274,12 @@
 
 #cards.three-per-line li {
 width: 32.63%;
-padding: 1em;
 }
 #cards.three-per-line > li:nth-child(3),
 #cards.three-per-line > li:nth-child(6) { margin-right: 0; }
 
 #cards.four-per-line li {
 width: 24.29%;
-padding: 1em 0.5em;
 }
 #cards.four-per-line > li:nth-child(4),
 #cards.four-per-line > li:nth-child(8) { margin-right: 0; }
@@ -300,16 +298,16 @@
 #cards li input {
 display: block;
 width: 100%;
-margin: 0 0 .7em;
+margin: 0;
 box-shadow: none;
 }
 #cards li label {
 cursor: pointer;
-margin-top: .5em;
+padding: 1em;
 display: block;
 }
 #cards li label img {
-margin: 0 auto;
+margin: 0.7em auto 0;
 height: auto;
 }
 #cards li.has_sub_text label {
@@ -484,8 +482,6 @@
 border: 1px solid #ccc;
 }
 #cards li input.cardradio {
-padding: 10px;
-margin: 5px 0;
 display: block;
 width: auto;
 font-size: 13px;
diff --git a/gateway_forms/mustache/payment_method.html.mustache 
b/gateway_forms/mustache/payment_method.html.mustache
index 27e688a..b39a439 100644
--- a/gateway_forms/mustache/payment_method.html.mustache
+++ b/gateway_forms/mustache/payment_method.html.mustache
@@ -6,8 +6,8 @@


 {{# submethods }} {{! TODO: give every submethod a label_key, remove 
conditionals }}
 
-
 
+
 
 {{# sub_text_key }}
 {{ l10n . }}

-- 
To view, visit https://gerrit.wikimedia.org/r/392772
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I871fcbdd3a67e44be5a0ab2cec14e2d2ddbabb4c
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Ejegg 
Gerrit-Reviewer: AndyRussG 
Gerrit-Reviewer: Mepps 
Gerrit-Reviewer: XenoRyet 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Use padding instead of margin to close a gap

2017-11-21 Thread Ejegg (Code Review) 
Ejegg has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/392772 )

Change subject: Use padding instead of margin to close a gap
..

Use padding instead of margin to close a gap

Clicking between the radio button and the logo should count as
a click on the thing.

Change-Id: I871fcbdd3a67e44be5a0ab2cec14e2d2ddbabb4c
---
M gateway_forms/mustache/forms.css
1 file changed, 2 insertions(+), 4 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface 
refs/changes/72/392772/1

diff --git a/gateway_forms/mustache/forms.css b/gateway_forms/mustache/forms.css
index c74fd0f..74c9e6c 100644
--- a/gateway_forms/mustache/forms.css
+++ b/gateway_forms/mustache/forms.css
@@ -300,12 +300,12 @@
 #cards li input {
 display: block;
 width: 100%;
-margin: 0 0 .7em;
+margin: 0;
 box-shadow: none;
 }
 #cards li label {
 cursor: pointer;
-margin-top: .5em;
+padding-top: .7em;
 display: block;
 }
 #cards li label img {
@@ -484,8 +484,6 @@
 border: 1px solid #ccc;
 }
 #cards li input.cardradio {
-padding: 10px;
-margin: 5px 0;
 display: block;
 width: auto;
 font-size: 13px;

-- 
To view, visit https://gerrit.wikimedia.org/r/392772
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I871fcbdd3a67e44be5a0ab2cec14e2d2ddbabb4c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Ejegg 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits