[MediaWiki-commits] [Gerrit] mediawiki...DynamicSidebar[master]: Improve some parameter docs

2017-10-07 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/382849 )

Change subject: Improve some parameter docs
..


Improve some parameter docs

Change-Id: I802e07fb820bb49533f0bddde6e2ecf955752070
---
M DynamicSidebar.body.php
M phpcs.xml
2 files changed, 2 insertions(+), 6 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/DynamicSidebar.body.php b/DynamicSidebar.body.php
index 6a03481..bb5cc1b 100644
--- a/DynamicSidebar.body.php
+++ b/DynamicSidebar.body.php
@@ -5,7 +5,7 @@
 * via callbacks.
 *
 * @param Skin $skin
-* @param array $sidebar
+* @param array &$sidebar
 * @return bool
 */
public static function modifySidebar( $skin, &$sidebar ) {
diff --git a/phpcs.xml b/phpcs.xml
index 75246d0..90e8108 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -2,13 +2,9 @@
 


-   
-   


.

-   
-   vendor
-   node_modules
+   
 

-- 
To view, visit https://gerrit.wikimedia.org/r/382849
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I802e07fb820bb49533f0bddde6e2ecf955752070
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DynamicSidebar
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...DynamicSidebar[master]: Improve some parameter docs

2017-10-06 Thread Umherirrender (Code Review) 
Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/382849 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: I802e07fb820bb49533f0bddde6e2ecf955752070
---
M DynamicSidebar.body.php
M phpcs.xml
2 files changed, 2 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DynamicSidebar 
refs/changes/49/382849/1

diff --git a/DynamicSidebar.body.php b/DynamicSidebar.body.php
index 6a03481..bb5cc1b 100644
--- a/DynamicSidebar.body.php
+++ b/DynamicSidebar.body.php
@@ -5,7 +5,7 @@
 * via callbacks.
 *
 * @param Skin $skin
-* @param array $sidebar
+* @param array &$sidebar
 * @return bool
 */
public static function modifySidebar( $skin, &$sidebar ) {
diff --git a/phpcs.xml b/phpcs.xml
index 75246d0..90e8108 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -2,13 +2,9 @@
 


-   
-   


.

-   
-   vendor
-   node_modules
+   
 

-- 
To view, visit https://gerrit.wikimedia.org/r/382849
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I802e07fb820bb49533f0bddde6e2ecf955752070
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DynamicSidebar
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits