[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: jsduck: Remove custom @source tag

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: jsduck: Remove custom @source tag
..


jsduck: Remove custom @source tag

Only used in external.js to render a simple link. These methods
don't have a regular description and as such the link renders
effectively the same way in the same place without `@source`.

Also:
* Add missing '@static' to jQuery.ajax (matches MediaWiki core).
* Add 'docs/' to .gitignore to avoid a dirty state after
  running 'npm run doc'.

Change-Id: I83cd524b6b53e67c5c2d18258c804ebd49a29b74
---
M .gitignore
M jsduck.external.js
M jsduck_custom_tags.rb
3 files changed, 13 insertions(+), 28 deletions(-)

Approvals:
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/.gitignore b/.gitignore
index 35d2258..f53c5df 100644
--- a/.gitignore
+++ b/.gitignore
@@ -13,3 +13,4 @@
 vendor/autoload.php
 \#*#
 /composer.lock
+/docs
diff --git a/jsduck.external.js b/jsduck.external.js
index 8c5c469..9684cc1 100644
--- a/jsduck.external.js
+++ b/jsduck.external.js
@@ -1,58 +1,59 @@
 /**
+ * Source: 
  * @class jQuery
- * 
  */
 
 /**
+ * Source: 
  * @method ajax
- * @source 
+ * @static
  * @return {jqXHR}
  */
 
 /**
+ * Source: 
  * @class jQuery.Event
- * @source 
  */
 
 /**
+ * Source: 
  * @class jQuery.Promise
- * @source 
  */
 
 /**
+ * Source: 
  * @class jQuery.Deferred
  * @mixins jQuery.Promise
- * @source 
  */
 
 /**
+ * Source: 
  * @class jQuery.jqXHR
- * @source 
  * @alternateClassName jqXHR
  */
 
 /**
+ * Source: 
  * @class mw.Api
- * @source 
  */
 
 /**
+ * Source: 

  * @class mw.Title
- * @source 
  */
 
 /**
+ * Source: 
  * @class Handlebars
- * 
  */
 
 /**
+ * Source: 
  * @class Handlebars.SafeString
- * 
  */
 
diff --git a/jsduck_custom_tags.rb b/jsduck_custom_tags.rb
index 96b1ea6..e6b19ed 100644
--- a/jsduck_custom_tags.rb
+++ b/jsduck_custom_tags.rb
@@ -31,23 +31,6 @@
   end
 end
 
-class SourceTag < CommonTag
-  def initialize
-@tagname = :source
-@pattern = "source"
-super
-  end
-
-  def to_html(context)
-context[@tagname].map do |source|
-  <<-EOHTML
-Source
-#{source[:doc]}
-  EOHTML
-end.join
-  end
-end
-
 class UntilTag < CommonTag
   def initialize
 @tagname = :until

-- 
To view, visit https://gerrit.wikimedia.org/r/311876
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I83cd524b6b53e67c5c2d18258c804ebd49a29b74
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Krinkle 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: jsduck: Remove custom @source tag

[Krinkle (Code Review)]

Krinkle has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/311876

Change subject: jsduck: Remove custom @source tag
..

jsduck: Remove custom @source tag

Only used in external.js to render a simple link. These methods
don't have a regular description and as such the link renders
effectively the same way in the same place without `@source`.

Also:
* Add missing '@static' to jQuery.ajax (matches MediaWiki core).
* Add 'docs/' to .gitignore to avoid a dirty state after
  running 'npm run doc'.

Change-Id: I83cd524b6b53e67c5c2d18258c804ebd49a29b74
---
M .gitignore
M jsduck.external.js
M jsduck_custom_tags.rb
3 files changed, 13 insertions(+), 28 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/76/311876/1

diff --git a/.gitignore b/.gitignore
index 35d2258..f53c5df 100644
--- a/.gitignore
+++ b/.gitignore
@@ -13,3 +13,4 @@
 vendor/autoload.php
 \#*#
 /composer.lock
+/docs
diff --git a/jsduck.external.js b/jsduck.external.js
index 8c5c469..9684cc1 100644
--- a/jsduck.external.js
+++ b/jsduck.external.js
@@ -1,58 +1,59 @@
 /**
+ * Source: 
  * @class jQuery
- * 
  */
 
 /**
+ * Source: 
  * @method ajax
- * @source 
+ * @static
  * @return {jqXHR}
  */
 
 /**
+ * Source: 
  * @class jQuery.Event
- * @source 
  */
 
 /**
+ * Source: 
  * @class jQuery.Promise
- * @source 
  */
 
 /**
+ * Source: 
  * @class jQuery.Deferred
  * @mixins jQuery.Promise
- * @source 
  */
 
 /**
+ * Source: 
  * @class jQuery.jqXHR
- * @source 
  * @alternateClassName jqXHR
  */
 
 /**
+ * Source: 
  * @class mw.Api
- * @source 
  */
 
 /**
+ * Source: 

  * @class mw.Title
- * @source 
  */
 
 /**
+ * Source: 
  * @class Handlebars
- * 
  */
 
 /**
+ * Source: 
  * @class Handlebars.SafeString
- * 
  */
 
diff --git a/jsduck_custom_tags.rb b/jsduck_custom_tags.rb
index 96b1ea6..e6b19ed 100644
--- a/jsduck_custom_tags.rb
+++ b/jsduck_custom_tags.rb
@@ -31,23 +31,6 @@
   end
 end
 
-class SourceTag < CommonTag
-  def initialize
-@tagname = :source
-@pattern = "source"
-super
-  end
-
-  def to_html(context)
-context[@tagname].map do |source|
-  <<-EOHTML
-Source
-#{source[:doc]}
-  EOHTML
-end.join
-  end
-end
-
 class UntilTag < CommonTag
   def initialize
 @tagname = :until

-- 
To view, visit https://gerrit.wikimedia.org/r/311876
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I83cd524b6b53e67c5c2d18258c804ebd49a29b74
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Krinkle 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits