[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Remove unnecessary API call in unit test

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/386030 )

Change subject: Remove unnecessary API call in unit test
..


Remove unnecessary API call in unit test

We do not need to hit the API in this test. It's unnecessary and makes
the test harder to comprehend.

Instead of testing this way, simulate a promise that resolves without
pages.

(npm run test:unit should work without an internet connection)

Change-Id: Iee834114890a64c96ccf255601503a25efd884bc
---
M test/lib/api-util/api-util-test.js
1 file changed, 3 insertions(+), 19 deletions(-)

Approvals:
  BearND: Looks good to me, approved
  jenkins-bot: Verified
  Mholloway: Looks good to me, but someone else must approve



diff --git a/test/lib/api-util/api-util-test.js 
b/test/lib/api-util/api-util-test.js
index 33ef32b..4080c58 100644
--- a/test/lib/api-util/api-util-test.js
+++ b/test/lib/api-util/api-util-test.js
@@ -1,6 +1,5 @@
 'use strict';
 
-const preq   = require('preq');
 const assert = require('../../utils/assert');
 const mwapi = require('../../../lib/mwapi');
 
@@ -11,26 +10,11 @@
 
 logger.log = function(a, b) {};
 
-describe('lib:apiUtil', function() {
-
-this.timeout(2); // eslint-disable-line no-invalid-this
+describe('lib:apiUtil', () => {
 
 it('checkForQueryPagesInResponse should return 504 when query.pages are 
absent', () => {
-return preq.post({
-uri: 'https://commons.wikimedia.org/w/api.php',
-body: {
-action: 'query',
-format: 'json',
-formatversion: 2,
-generator: 'images',
-prop: 'imageinfo|revisions',
-iiextmetadatafilter: 'ImageDescription',
-iiextmetadatamultilang: true,
-iiprop: 'url|extmetadata|dimensions',
-iiurlwidth: 1024,
-rawcontinue: '',
-titles: `Template:Potd/1980-07-06`
-}
+return new Promise((resolve) => {
+return resolve({});
 }).then((response) => {
 assert.throws(() => {
 mwapi.checkForQueryPagesInResponse({ logger }, response);

-- 
To view, visit https://gerrit.wikimedia.org/r/386030
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iee834114890a64c96ccf255601503a25efd884bc
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 
Gerrit-Reviewer: BearND 
Gerrit-Reviewer: Dbrant 
Gerrit-Reviewer: Fjalapeno 
Gerrit-Reviewer: GWicke 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Mholloway 
Gerrit-Reviewer: Mhurd 
Gerrit-Reviewer: Mobrovac 
Gerrit-Reviewer: Ppchelko 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Remove unnecessary API call in unit test

[Jdlrobson (Code Review)]

Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386030 )

Change subject: Remove unnecessary API call in unit test
..

Remove unnecessary API call in unit test

We do not need to hit the API in this test. It's unnecessary and makes
the test harder to comprehend.

Instead of testing this way, simulate a promise that resolves without
pages.

(npm run test:unit should work without an internet connection)

Change-Id: Iee834114890a64c96ccf255601503a25efd884bc
---
M test/lib/api-util/api-util-test.js
1 file changed, 3 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps 
refs/changes/30/386030/1

diff --git a/test/lib/api-util/api-util-test.js 
b/test/lib/api-util/api-util-test.js
index 33ef32b..ee2bc00 100644
--- a/test/lib/api-util/api-util-test.js
+++ b/test/lib/api-util/api-util-test.js
@@ -13,25 +13,10 @@
 
 describe('lib:apiUtil', function() {
 
-this.timeout(2); // eslint-disable-line no-invalid-this
-
 it('checkForQueryPagesInResponse should return 504 when query.pages are 
absent', () => {
-return preq.post({
-uri: 'https://commons.wikimedia.org/w/api.php',
-body: {
-action: 'query',
-format: 'json',
-formatversion: 2,
-generator: 'images',
-prop: 'imageinfo|revisions',
-iiextmetadatafilter: 'ImageDescription',
-iiextmetadatamultilang: true,
-iiprop: 'url|extmetadata|dimensions',
-iiurlwidth: 1024,
-rawcontinue: '',
-titles: `Template:Potd/1980-07-06`
-}
-}).then((response) => {
+return new Promise((resolve) => {
+  return resolve({});
+} ).then((response) => {
 assert.throws(() => {
 mwapi.checkForQueryPagesInResponse({ logger }, response);
 }, /api_error/);

-- 
To view, visit https://gerrit.wikimedia.org/r/386030
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee834114890a64c96ccf255601503a25efd884bc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits