[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: Minor: use msg.meta.topic instead of parsing it out from kaf...

2016-12-15 Thread Mobrovac (Code Review) 
Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/327217 )

Change subject: Minor: use msg.meta.topic instead of parsing it out from 
kafkaMessage
..


Minor: use msg.meta.topic instead of parsing it out from kafkaMessage

Change-Id: I58ceb0de85a1f5fce735104d3c25bbf856dc0f97
---
M lib/edit-stream.js
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/lib/edit-stream.js b/lib/edit-stream.js
index 3a51f13..a90cb24 100644
--- a/lib/edit-stream.js
+++ b/lib/edit-stream.js
@@ -103,8 +103,7 @@
 
 try {
 let msg = JSON.parse(kafkaMessage.value.toString());
-const pureTopic = 
kafkaMessage.topic.substr(kafkaMessage.topic.indexOf('.') + 1);
-const skip = COMMIT_PUSH_SKIP[pureTopic];
+const skip = COMMIT_PUSH_SKIP[msg.meta.topic];
 if (!skip || kafkaMessage.offset % skip === 0) {
 this._commitQueue.push({
 message: kafkaMessage,

-- 
To view, visit https://gerrit.wikimedia.org/r/327217
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I58ceb0de85a1f5fce735104d3c25bbf856dc0f97
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/services/trending-edits
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Mobrovac 
Gerrit-Reviewer: Ppchelko 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: Minor: use msg.meta.topic instead of parsing it out from kaf...

2016-12-14 Thread Mobrovac (Code Review) 
Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/327217 )

Change subject: Minor: use msg.meta.topic instead of parsing it out from 
kafkaMessage
..

Minor: use msg.meta.topic instead of parsing it out from kafkaMessage

Change-Id: I58ceb0de85a1f5fce735104d3c25bbf856dc0f97
---
M lib/edit-stream.js
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/trending-edits 
refs/changes/17/327217/1

diff --git a/lib/edit-stream.js b/lib/edit-stream.js
index 719d9d6..95423e5 100644
--- a/lib/edit-stream.js
+++ b/lib/edit-stream.js
@@ -102,8 +102,7 @@
 return this.emit('error', e);
 }
 
-const pureTopic = 
kafkaMessage.topic.substr(kafkaMessage.topic.indexOf('.') + 1);
-const skip = COMMIT_PUSH_SKIP[pureTopic];
+const skip = COMMIT_PUSH_SKIP[msg.meta.topic];
 if (!skip || kafkaMessage.offset % skip === 0) {
 this._commitQueue.push({
 message: kafkaMessage,

-- 
To view, visit https://gerrit.wikimedia.org/r/327217
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I58ceb0de85a1f5fce735104d3c25bbf856dc0f97
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/trending-edits
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits