[MediaWiki-commits] [Gerrit] operations/puppet[production]: role::jsbench: Restrict to production networks

2016-12-15 Thread Dzahn (Code Review) 
Dzahn has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/320547 )

Change subject: role::jsbench: Restrict to production networks
..


role::jsbench: Restrict to production networks

We're getting rid of $INTERNAL, since it's needlessly broad. xvfb is only
accessed from production hosts for debugging, so restrict it to production
networks.

Change-Id: I0a209f803b21d666c8f378c38aa9501a48952230
---
M modules/role/manifests/jsbench.pp
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/modules/role/manifests/jsbench.pp 
b/modules/role/manifests/jsbench.pp
index b419031..e68021e 100644
--- a/modules/role/manifests/jsbench.pp
+++ b/modules/role/manifests/jsbench.pp
@@ -30,7 +30,7 @@
 ferm::service { 've-xvfb':
 proto  => 'tcp',
 port   => '6099',
-srange => '$INTERNAL',
+srange => '$PRODUCTION_NETWORKS',
 }
 
 user { 'jsbench':

-- 
To view, visit https://gerrit.wikimedia.org/r/320547
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0a209f803b21d666c8f378c38aa9501a48952230
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Muehlenhoff 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: role::jsbench: Restrict to production networks

2016-11-08 Thread Muehlenhoff (Code Review) 
Muehlenhoff has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/320547

Change subject: role::jsbench: Restrict to production networks
..

role::jsbench: Restrict to production networks

We're getting rid of $INTERNAL, since it's needlessly broad. xvfb is only
accessed from production hosts for debugging, so restrict it to production
networks.

Change-Id: I0a209f803b21d666c8f378c38aa9501a48952230
---
M modules/role/manifests/jsbench.pp
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/47/320547/1

diff --git a/modules/role/manifests/jsbench.pp 
b/modules/role/manifests/jsbench.pp
index 5dbd87d..5a67a90 100644
--- a/modules/role/manifests/jsbench.pp
+++ b/modules/role/manifests/jsbench.pp
@@ -30,7 +30,7 @@
 ferm::service { 've-xvfb':
 proto  => 'tcp',
 port   => '6099',
-srange => '$INTERNAL',
+srange => '$PRODUCTION_NETWORKS',
 }
 
 user { 'jsbench':

-- 
To view, visit https://gerrit.wikimedia.org/r/320547
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a209f803b21d666c8f378c38aa9501a48952230
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Muehlenhoff 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits