[MediaWiki-commits] [Gerrit] wikidata...gui[master]: Add SPARQL query as hidden table column to allow filtering
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/339155 )
Change subject: Add SPARQL query as hidden table column to allow filtering
..
Add SPARQL query as hidden table column to allow filtering
Bug:T154768
Change-Id: Ib610e9dde3470df85b005a61cc86ef7dd8eee5ec
---
M wikibase/queryService/ui/QueryExampleDialog.js
1 file changed, 11 insertions(+), 11 deletions(-)
Approvals:
Smalyshev: Looks good to me, approved
jenkins-bot: Verified
diff --git a/wikibase/queryService/ui/QueryExampleDialog.js
b/wikibase/queryService/ui/QueryExampleDialog.js
index 733039f..0d110b5 100644
--- a/wikibase/queryService/ui/QueryExampleDialog.js
+++ b/wikibase/queryService/ui/QueryExampleDialog.js
@@ -117,7 +117,7 @@
if ( example.category !== category ) {
category = example.category;
self._$element.find( '.searchable'
).append( $( '' ).addClass( 'active' )
- .append( $( '' ).text( category ) ) );
+ .append( $( '' ).text( category ) ) );
}
self._addExample( example.title, example.query,
example.href, example.tags );
} );
@@ -235,7 +235,7 @@
self._track( 'edit' );
} ),
- source = $( '' ).addClass( 'glyphicon
glyphicon-eye-open' ).popover(
+ $source = $( '' ).addClass( 'glyphicon
glyphicon-eye-open' ).popover(
{
placement: 'bottom',
trigger: 'hover',
@@ -244,7 +244,7 @@
content: $( '' ).text( query ),
html: true
} ),
- preview = $( '' ).addClass( 'glyphicon
glyphicon-camera' ).clickover(
+ $preview = $( '' ).addClass( 'glyphicon
glyphicon-camera' ).clickover(
{
placement: 'left',
'global_close': true,
@@ -258,19 +258,19 @@
.click( function() {
self._track( 'preview' );
} );
- $( '.exampleTable' ).scroll( function() {
- if ( preview.clickover ) {
- preview.clickover( 'hide' ).removeAttr(
'data-clickover-open' );
+
+ $( '.exampleTable' ).scroll( function() {
+ if ( $preview.clickover ) {
+ $preview.clickover( 'hide' ).removeAttr(
'data-clickover-open' );
}
} );
- tags = $( '' ).text( tags.join( '|' ) ).hide();
-
var example = $( '' );
example.append( $( '' ).append( $link ).append( ' ', $edit
) );
- example.append( $( '' ).append( preview ) );
- example.append( $( '' ).append( source ) );
- example.append( tags );
+ example.append( $( '' ).append( $preview ) );
+ example.append( $( '' ).append( $source ) );
+ example.append( $( '' ).text( tags.join( '|' ) ).hide() );
+ example.append( $( '' ).text( query ).hide() );
this._$element.find( '.searchable' ).append( example );
};
--
To view, visit https://gerrit.wikimedia.org/r/339155
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib610e9dde3470df85b005a61cc86ef7dd8eee5ec
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE)
Gerrit-Reviewer: Smalyshev
Gerrit-Reviewer: jenkins-bot <>
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] wikidata...gui[master]: Add SPARQL query as hidden table column to allow filtering
Jonas Kress (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/339155 )
Change subject: Add SPARQL query as hidden table column to allow filtering
..
Add SPARQL query as hidden table column to allow filtering
Bug:T154768
Change-Id: Ib610e9dde3470df85b005a61cc86ef7dd8eee5ec
---
M wikibase/queryService/ui/QueryExampleDialog.js
1 file changed, 11 insertions(+), 11 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/wikidata/query/gui
refs/changes/55/339155/1
diff --git a/wikibase/queryService/ui/QueryExampleDialog.js
b/wikibase/queryService/ui/QueryExampleDialog.js
index 733039f..0d110b5 100644
--- a/wikibase/queryService/ui/QueryExampleDialog.js
+++ b/wikibase/queryService/ui/QueryExampleDialog.js
@@ -117,7 +117,7 @@
if ( example.category !== category ) {
category = example.category;
self._$element.find( '.searchable'
).append( $( '' ).addClass( 'active' )
- .append( $( '' ).text( category ) ) );
+ .append( $( '' ).text( category ) ) );
}
self._addExample( example.title, example.query,
example.href, example.tags );
} );
@@ -235,7 +235,7 @@
self._track( 'edit' );
} ),
- source = $( '' ).addClass( 'glyphicon
glyphicon-eye-open' ).popover(
+ $source = $( '' ).addClass( 'glyphicon
glyphicon-eye-open' ).popover(
{
placement: 'bottom',
trigger: 'hover',
@@ -244,7 +244,7 @@
content: $( '' ).text( query ),
html: true
} ),
- preview = $( '' ).addClass( 'glyphicon
glyphicon-camera' ).clickover(
+ $preview = $( '' ).addClass( 'glyphicon
glyphicon-camera' ).clickover(
{
placement: 'left',
'global_close': true,
@@ -258,19 +258,19 @@
.click( function() {
self._track( 'preview' );
} );
- $( '.exampleTable' ).scroll( function() {
- if ( preview.clickover ) {
- preview.clickover( 'hide' ).removeAttr(
'data-clickover-open' );
+
+ $( '.exampleTable' ).scroll( function() {
+ if ( $preview.clickover ) {
+ $preview.clickover( 'hide' ).removeAttr(
'data-clickover-open' );
}
} );
- tags = $( '' ).text( tags.join( '|' ) ).hide();
-
var example = $( '' );
example.append( $( '' ).append( $link ).append( ' ', $edit
) );
- example.append( $( '' ).append( preview ) );
- example.append( $( '' ).append( source ) );
- example.append( tags );
+ example.append( $( '' ).append( $preview ) );
+ example.append( $( '' ).append( $source ) );
+ example.append( $( '' ).text( tags.join( '|' ) ).hide() );
+ example.append( $( '' ).text( query ).hide() );
this._$element.find( '.searchable' ).append( example );
};
--
To view, visit https://gerrit.wikimedia.org/r/339155
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib610e9dde3470df85b005a61cc86ef7dd8eee5ec
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE)
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
