[MediaWiki-commits] [Gerrit] wikidata...gui[master]: Hide embed logo after rendering result

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/383323 )

Change subject: Hide embed logo after rendering result
..


Hide embed logo after rendering result

If result view does not use 100% VH Wikidata logo should not be visible
after rendering result.

Change-Id: If6e351867f8d745cfa587bba8abdb9a9d84b1fa7
---
M embed.html
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Smalyshev: Looks good to me, approved
  Jonas Kress (WMDE): Looks good to me, approved
  jenkins-bot: Verified



diff --git a/embed.html b/embed.html
index 840738d..3fc56e8 100644
--- a/embed.html
+++ b/embed.html
@@ -269,7 +269,9 @@
$( 'body' ).i18n();
$( 'html' ).attr( { lang: lang, dir: 
$.uls.data.getDir( lang ) } );
 
-   resultView.draw( query );
+   resultView.draw( query ).done( function() {
+   $( '.logo' ).hide();
+   } );
renderEdit( query, function( q ){
resultView.draw( q );
window.location.hash = '#' + 
encodeURIComponent( q )

-- 
To view, visit https://gerrit.wikimedia.org/r/383323
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If6e351867f8d745cfa587bba8abdb9a9d84b1fa7
Gerrit-PatchSet: 3
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) 
Gerrit-Reviewer: Jonas Kress (WMDE) 
Gerrit-Reviewer: Lucas Werkmeister (WMDE) 
Gerrit-Reviewer: Smalyshev 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikidata...gui[master]: Hide embed logo after rendering result

[Jonas Kress (WMDE) (Code Review)]

Jonas Kress (WMDE) has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/383323 )

Change subject: Hide embed logo after rendering result
..

Hide embed logo after rendering result

If result view does not use 100% VH Wikidata logo should not be visible
after rendering result.

Change-Id: If6e351867f8d745cfa587bba8abdb9a9d84b1fa7
---
M embed.html
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikidata/query/gui 
refs/changes/23/383323/1

diff --git a/embed.html b/embed.html
index 553a14b..c2dd213 100644
--- a/embed.html
+++ b/embed.html
@@ -276,6 +276,7 @@
$( '.edit-link' ).attr( 'href', 
config.location.index + window.location.hash )
} );
 
+   $( '.logo' ).hide();
$( '.edit-link' ).attr( 'href', 
config.location.index + window.location.hash )
} );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/383323
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If6e351867f8d745cfa587bba8abdb9a9d84b1fa7
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits