from:"Reedy $Code Review$"

[MediaWiki-commits] [Gerrit] Non wikipedias to 1.25wmf11 - change (operations/mediawiki-config)

2014-12-09 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/178562

Change subject: Non wikipedias to 1.25wmf11
..

Non wikipedias to 1.25wmf11

Change-Id: I3bd20d3bb40d7a4e31f5426ee50b3696acafd92b
---
M docroot/bits/static-current/extensions
M docroot/bits/static-current/resources
M docroot/bits/static-current/skins
M php
M wikiversions.json
5 files changed, 599 insertions(+), 599 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/62/178562/1

diff --git a/docroot/bits/static-current/extensions 
b/docroot/bits/static-current/extensions
index 2b0b3e1..e1d76f6 12
--- a/docroot/bits/static-current/extensions
+++ b/docroot/bits/static-current/extensions
@@ -1 +1 @@
-/srv/mediawiki/php-1.25wmf10/extensions
\ No newline at end of file
+/srv/mediawiki/php-1.25wmf11/extensions
\ No newline at end of file
diff --git a/docroot/bits/static-current/resources 
b/docroot/bits/static-current/resources
index f622a11..a777ee8 12
--- a/docroot/bits/static-current/resources
+++ b/docroot/bits/static-current/resources
@@ -1 +1 @@
-/srv/mediawiki/php-1.25wmf10/resources
\ No newline at end of file
+/srv/mediawiki/php-1.25wmf11/resources
\ No newline at end of file
diff --git a/docroot/bits/static-current/skins 
b/docroot/bits/static-current/skins
index 64e7f6d..ea282ea 12
--- a/docroot/bits/static-current/skins
+++ b/docroot/bits/static-current/skins
@@ -1 +1 @@
-/srv/mediawiki/php-1.25wmf10/skins
\ No newline at end of file
+/srv/mediawiki/php-1.25wmf11/skins
\ No newline at end of file
diff --git a/php b/php
index af01b61..dd033f1 12
--- a/php
+++ b/php
@@ -1 +1 @@
-php-1.25wmf10
\ No newline at end of file
+php-1.25wmf11
\ No newline at end of file
diff --git a/wikiversions.json b/wikiversions.json
index e2a16b9..72a38e6 100644
--- a/wikiversions.json
+++ b/wikiversions.json
@@ -1,890 +1,890 @@
 {
 aawiki: php-1.25wmf10,
-aawikibooks: php-1.25wmf10,
-aawiktionary: php-1.25wmf10,
+aawikibooks: php-1.25wmf11,
+aawiktionary: php-1.25wmf11,
 abwiki: php-1.25wmf10,
-abwiktionary: php-1.25wmf10,
+abwiktionary: php-1.25wmf11,
 acewiki: php-1.25wmf10,
-advisorywiki: php-1.25wmf10,
+advisorywiki: php-1.25wmf11,
 afwiki: php-1.25wmf10,
-afwikibooks: php-1.25wmf10,
-afwikiquote: php-1.25wmf10,
-afwiktionary: php-1.25wmf10,
+afwikibooks: php-1.25wmf11,
+afwikiquote: php-1.25wmf11,
+afwiktionary: php-1.25wmf11,
 akwiki: php-1.25wmf10,
-akwikibooks: php-1.25wmf10,
-akwiktionary: php-1.25wmf10,
+akwikibooks: php-1.25wmf11,
+akwiktionary: php-1.25wmf11,
 alswiki: php-1.25wmf10,
-alswikibooks: php-1.25wmf10,
-alswikiquote: php-1.25wmf10,
-alswiktionary: php-1.25wmf10,
+alswikibooks: php-1.25wmf11,
+alswikiquote: php-1.25wmf11,
+alswiktionary: php-1.25wmf11,
 amwiki: php-1.25wmf10,
-amwikiquote: php-1.25wmf10,
-amwiktionary: php-1.25wmf10,
+amwikiquote: php-1.25wmf11,
+amwiktionary: php-1.25wmf11,
 angwiki: php-1.25wmf10,
-angwikibooks: php-1.25wmf10,
-angwikiquote: php-1.25wmf10,
-angwikisource: php-1.25wmf10,
-angwiktionary: php-1.25wmf10,
+angwikibooks: php-1.25wmf11,
+angwikiquote: php-1.25wmf11,
+angwikisource: php-1.25wmf11,
+angwiktionary: php-1.25wmf11,
 anwiki: php-1.25wmf10,
-anwiktionary: php-1.25wmf10,
-arbcom_dewiki: php-1.25wmf10,
-arbcom_enwiki: php-1.25wmf10,
-arbcom_fiwiki: php-1.25wmf10,
-arbcom_nlwiki: php-1.25wmf10,
+anwiktionary: php-1.25wmf11,
+arbcom_dewiki: php-1.25wmf11,
+arbcom_enwiki: php-1.25wmf11,
+arbcom_fiwiki: php-1.25wmf11,
+arbcom_nlwiki: php-1.25wmf11,
 arcwiki: php-1.25wmf10,
 arwiki: php-1.25wmf10,
-arwikibooks: php-1.25wmf10,
-arwikimedia: php-1.25wmf10,
-arwikinews: php-1.25wmf10,
-arwikiquote: php-1.25wmf10,
-arwikisource: php-1.25wmf10,
-arwikiversity: php-1.25wmf10,
-arwiktionary: php-1.25wmf10,
+arwikibooks: php-1.25wmf11,
+arwikimedia: php-1.25wmf11,
+arwikinews: php-1.25wmf11,
+arwikiquote: php-1.25wmf11,
+arwikisource: php-1.25wmf11,
+arwikiversity: php-1.25wmf11,
+arwiktionary: php-1.25wmf11,
 arzwiki: php-1.25wmf10,
 astwiki: php-1.25wmf10,
-astwikibooks: php-1.25wmf10,
-astwikiquote: php-1.25wmf10,
-astwiktionary: php-1.25wmf10,
+astwikibooks: php-1.25wmf11,
+astwikiquote: php-1.25wmf11,
+astwiktionary: php-1.25wmf11,
 aswiki: php-1.25wmf10,
-aswikibooks: php-1.25wmf10,
-aswikisource: php-1.25wmf10,
-aswiktionary: php-1.25wmf10,
-auditcomwiki: php-1.25wmf10,
+aswikibooks: php-1.25wmf11,
+aswikisource: php-1.25wmf11,
+aswiktionary: php-1.25wmf11,
+auditcomwiki: php-1.25wmf11,
 avwiki: php-1.25wmf10,
-avwiktionary: php-1.25wmf10,
+avwiktionary: php-1.25wmf11,
 aywiki: php-1.25wmf10,

[MediaWiki-commits] [Gerrit] API: Don't use an empty LinkBatch in ApiOpenSearch - change (mediawiki/core)

2014-12-09 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/178668

Change subject: API: Don't use an empty LinkBatch in ApiOpenSearch
..

API: Don't use an empty LinkBatch in ApiOpenSearch

Bug: T78074
Change-Id: Ie4609b0867d816375f49190ee2860526b8fd8f3e
---
M includes/api/ApiOpenSearch.php
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/68/178668/1

diff --git a/includes/api/ApiOpenSearch.php b/includes/api/ApiOpenSearch.php
index 4a9e216..d48e996 100644
--- a/includes/api/ApiOpenSearch.php
+++ b/includes/api/ApiOpenSearch.php
@@ -124,6 +124,9 @@
// Find matching titles as Title objects
$searcher = new TitlePrefixSearch;
$titles = $searcher-searchWithVariants( $search, $limit, 
$namespaces );
+   if ( !$titles ) {
+   return;
+   }
 
if ( $resolveRedir ) {
// Query for redirects

-- 
To view, visit https://gerrit.wikimedia.org/r/178668
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie4609b0867d816375f49190ee2860526b8fd8f3e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.25wmf11
Gerrit-Owner: Reedy re...@wikimedia.org
Gerrit-Reviewer: Anomie bjor...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] testwiki to 1.25wmf12 - change (operations/mediawiki-config)

2014-12-10 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/178909

Change subject: testwiki to 1.25wmf12
..

testwiki to 1.25wmf12

Change-Id: I8dfa3602e3568b2c4f6ea360f9ce3afd51f49cb3
---
M wikiversions.json
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/09/178909/1

diff --git a/wikiversions.json b/wikiversions.json
index 72a38e6..79d48bc 100644
--- a/wikiversions.json
+++ b/wikiversions.json
@@ -739,7 +739,7 @@
 tawiktionary: php-1.25wmf11,
 tenwiki: php-1.25wmf11,
 test2wiki: php-1.25wmf11,
-testwiki: php-1.25wmf11,
+testwiki: php-1.25wmf12,
 testwikidatawiki: php-1.25wmf11,
 tetwiki: php-1.25wmf10,
 tewiki: php-1.25wmf10,
@@ -887,4 +887,4 @@
 zuwiki: php-1.25wmf10,
 zuwikibooks: php-1.25wmf11,
 zuwiktionary: php-1.25wmf11
-}
\ No newline at end of file
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/178909
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8dfa3602e3568b2c4f6ea360f9ce3afd51f49cb3
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add symlinks - change (operations/mediawiki-config)

2014-12-10 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/178908

Change subject: Add symlinks
..

Add symlinks

Change-Id: Ifbf7f6df68bdb3b67b49738f3bc6f83037350683
---
A docroot/bits/static-1.25wmf12/extensions
A docroot/bits/static-1.25wmf12/resources
A docroot/bits/static-1.25wmf12/skins
A w/static-1.25wmf12/extensions
A w/static-1.25wmf12/resources
A w/static-1.25wmf12/skins
6 files changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/08/178908/1

diff --git a/docroot/bits/static-1.25wmf12/extensions 
b/docroot/bits/static-1.25wmf12/extensions
new file mode 12
index 000..f14d366
--- /dev/null
+++ b/docroot/bits/static-1.25wmf12/extensions
@@ -0,0 +1 @@
+/srv/mediawiki/php-1.25wmf12/extensions
\ No newline at end of file
diff --git a/docroot/bits/static-1.25wmf12/resources 
b/docroot/bits/static-1.25wmf12/resources
new file mode 12
index 000..01f9356
--- /dev/null
+++ b/docroot/bits/static-1.25wmf12/resources
@@ -0,0 +1 @@
+/srv/mediawiki/php-1.25wmf12/resources
\ No newline at end of file
diff --git a/docroot/bits/static-1.25wmf12/skins 
b/docroot/bits/static-1.25wmf12/skins
new file mode 12
index 000..b9b9ad6
--- /dev/null
+++ b/docroot/bits/static-1.25wmf12/skins
@@ -0,0 +1 @@
+/srv/mediawiki/php-1.25wmf12/skins/
\ No newline at end of file
diff --git a/w/static-1.25wmf12/extensions b/w/static-1.25wmf12/extensions
new file mode 12
index 000..f14d366
--- /dev/null
+++ b/w/static-1.25wmf12/extensions
@@ -0,0 +1 @@
+/srv/mediawiki/php-1.25wmf12/extensions
\ No newline at end of file
diff --git a/w/static-1.25wmf12/resources b/w/static-1.25wmf12/resources
new file mode 12
index 000..01f9356
--- /dev/null
+++ b/w/static-1.25wmf12/resources
@@ -0,0 +1 @@
+/srv/mediawiki/php-1.25wmf12/resources
\ No newline at end of file
diff --git a/w/static-1.25wmf12/skins b/w/static-1.25wmf12/skins
new file mode 12
index 000..be98555
--- /dev/null
+++ b/w/static-1.25wmf12/skins
@@ -0,0 +1 @@
+/srv/mediawiki/php-1.25wmf12/skins
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/178908
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifbf7f6df68bdb3b67b49738f3bc6f83037350683
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] group0 to 1.25wmf12 - change (operations/mediawiki-config)

2014-12-10 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/178911

Change subject: group0 to 1.25wmf12
..

group0 to 1.25wmf12

Change-Id: Ifd9658760cd1e485355dcf6fb43b77a9fc93d5ac
---
M wikiversions.json
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/11/178911/1

diff --git a/wikiversions.json b/wikiversions.json
index 2bbe20c..1e3c75d 100644
--- a/wikiversions.json
+++ b/wikiversions.json
@@ -471,7 +471,7 @@
 maiwiki: php-1.25wmf11,
 map_bmswiki: php-1.25wmf11,
 mdfwiki: php-1.25wmf11,
-mediawikiwiki: php-1.25wmf11,
+mediawikiwiki: php-1.25wmf12,
 metawiki: php-1.25wmf11,
 mgwiki: php-1.25wmf11,
 mgwikibooks: php-1.25wmf11,
@@ -738,9 +738,9 @@
 tawikisource: php-1.25wmf11,
 tawiktionary: php-1.25wmf11,
 tenwiki: php-1.25wmf11,
-test2wiki: php-1.25wmf11,
+test2wiki: php-1.25wmf12,
 testwiki: php-1.25wmf12,
-testwikidatawiki: php-1.25wmf11,
+testwikidatawiki: php-1.25wmf12,
 tetwiki: php-1.25wmf11,
 tewiki: php-1.25wmf11,
 tewikibooks: php-1.25wmf11,
@@ -869,7 +869,7 @@
 zawikiquote: php-1.25wmf11,
 zawiktionary: php-1.25wmf11,
 zeawiki: php-1.25wmf11,
-zerowiki: php-1.25wmf11,
+zerowiki: php-1.25wmf12,
 zh_classicalwiki: php-1.25wmf11,
 zh_min_nanwiki: php-1.25wmf11,
 zh_min_nanwikibooks: php-1.25wmf11,

-- 
To view, visit https://gerrit.wikimedia.org/r/178911
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifd9658760cd1e485355dcf6fb43b77a9fc93d5ac
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikipedias to 1.25wmf11 - change (operations/mediawiki-config)

2014-12-10 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/178910

Change subject: wikipedias to 1.25wmf11
..

wikipedias to 1.25wmf11

Change-Id: I5edbfbabc21a2ca98bb73ff41567e49081275533
---
M wikiversions.json
1 file changed, 289 insertions(+), 289 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/10/178910/1

diff --git a/wikiversions.json b/wikiversions.json
index 79d48bc..2bbe20c 100644
--- a/wikiversions.json
+++ b/wikiversions.json
@@ -1,38 +1,38 @@
 {
-aawiki: php-1.25wmf10,
+aawiki: php-1.25wmf11,
 aawikibooks: php-1.25wmf11,
 aawiktionary: php-1.25wmf11,
-abwiki: php-1.25wmf10,
+abwiki: php-1.25wmf11,
 abwiktionary: php-1.25wmf11,
-acewiki: php-1.25wmf10,
+acewiki: php-1.25wmf11,
 advisorywiki: php-1.25wmf11,
-afwiki: php-1.25wmf10,
+afwiki: php-1.25wmf11,
 afwikibooks: php-1.25wmf11,
 afwikiquote: php-1.25wmf11,
 afwiktionary: php-1.25wmf11,
-akwiki: php-1.25wmf10,
+akwiki: php-1.25wmf11,
 akwikibooks: php-1.25wmf11,
 akwiktionary: php-1.25wmf11,
-alswiki: php-1.25wmf10,
+alswiki: php-1.25wmf11,
 alswikibooks: php-1.25wmf11,
 alswikiquote: php-1.25wmf11,
 alswiktionary: php-1.25wmf11,
-amwiki: php-1.25wmf10,
+amwiki: php-1.25wmf11,
 amwikiquote: php-1.25wmf11,
 amwiktionary: php-1.25wmf11,
-angwiki: php-1.25wmf10,
+angwiki: php-1.25wmf11,
 angwikibooks: php-1.25wmf11,
 angwikiquote: php-1.25wmf11,
 angwikisource: php-1.25wmf11,
 angwiktionary: php-1.25wmf11,
-anwiki: php-1.25wmf10,
+anwiki: php-1.25wmf11,
 anwiktionary: php-1.25wmf11,
 arbcom_dewiki: php-1.25wmf11,
 arbcom_enwiki: php-1.25wmf11,
 arbcom_fiwiki: php-1.25wmf11,
 arbcom_nlwiki: php-1.25wmf11,
-arcwiki: php-1.25wmf10,
-arwiki: php-1.25wmf10,
+arcwiki: php-1.25wmf11,
+arwiki: php-1.25wmf11,
 arwikibooks: php-1.25wmf11,
 arwikimedia: php-1.25wmf11,
 arwikinews: php-1.25wmf11,
@@ -40,135 +40,135 @@
 arwikisource: php-1.25wmf11,
 arwikiversity: php-1.25wmf11,
 arwiktionary: php-1.25wmf11,
-arzwiki: php-1.25wmf10,
-astwiki: php-1.25wmf10,
+arzwiki: php-1.25wmf11,
+astwiki: php-1.25wmf11,
 astwikibooks: php-1.25wmf11,
 astwikiquote: php-1.25wmf11,
 astwiktionary: php-1.25wmf11,
-aswiki: php-1.25wmf10,
+aswiki: php-1.25wmf11,
 aswikibooks: php-1.25wmf11,
 aswikisource: php-1.25wmf11,
 aswiktionary: php-1.25wmf11,
 auditcomwiki: php-1.25wmf11,
-avwiki: php-1.25wmf10,
+avwiki: php-1.25wmf11,
 avwiktionary: php-1.25wmf11,
-aywiki: php-1.25wmf10,
+aywiki: php-1.25wmf11,
 aywikibooks: php-1.25wmf11,
 aywiktionary: php-1.25wmf11,
-azwiki: php-1.25wmf10,
+azwiki: php-1.25wmf11,
 azwikibooks: php-1.25wmf11,
 azwikiquote: php-1.25wmf11,
 azwikisource: php-1.25wmf11,
 azwiktionary: php-1.25wmf11,
-barwiki: php-1.25wmf10,
-bat_smgwiki: php-1.25wmf10,
-bawiki: php-1.25wmf10,
+barwiki: php-1.25wmf11,
+bat_smgwiki: php-1.25wmf11,
+bawiki: php-1.25wmf11,
 bawikibooks: php-1.25wmf11,
-bclwiki: php-1.25wmf10,
+bclwiki: php-1.25wmf11,
 bdwikimedia: php-1.25wmf11,
-be_x_oldwiki: php-1.25wmf10,
+be_x_oldwiki: php-1.25wmf11,
 betawikiversity: php-1.25wmf11,
-bewiki: php-1.25wmf10,
+bewiki: php-1.25wmf11,
 bewikibooks: php-1.25wmf11,
 bewikimedia: php-1.25wmf11,
 bewikiquote: php-1.25wmf11,
 bewikisource: php-1.25wmf11,
 bewiktionary: php-1.25wmf11,
-bgwiki: php-1.25wmf10,
+bgwiki: php-1.25wmf11,
 bgwikibooks: php-1.25wmf11,
 bgwikinews: php-1.25wmf11,
 bgwikiquote: php-1.25wmf11,
 bgwikisource: php-1.25wmf11,
 bgwiktionary: php-1.25wmf11,
-bhwiki: php-1.25wmf10,
+bhwiki: php-1.25wmf11,
 bhwiktionary: php-1.25wmf11,
-biwiki: php-1.25wmf10,
+biwiki: php-1.25wmf11,
 biwikibooks: php-1.25wmf11,
 biwiktionary: php-1.25wmf11,
-bjnwiki: php-1.25wmf10,
-bmwiki: php-1.25wmf10,
+bjnwiki: php-1.25wmf11,
+bmwiki: php-1.25wmf11,
 bmwikibooks: php-1.25wmf11,
 bmwikiquote: php-1.25wmf11,
 bmwiktionary: php-1.25wmf11,
-bnwiki: php-1.25wmf10,
+bnwiki: php-1.25wmf11,
 bnwikibooks: php-1.25wmf11,
 bnwikisource: php-1.25wmf11,
 bnwiktionary: php-1.25wmf11,
 boardgovcomwiki: php-1.25wmf11,
 boardwiki: php-1.25wmf11,
-bowiki: php-1.25wmf10,
+bowiki: php-1.25wmf11,
 bowikibooks: php-1.25wmf11,
 bowiktionary: php-1.25wmf11,
-bpywiki: php-1.25wmf10,
-brwiki: php-1.25wmf10,
+bpywiki: php-1.25wmf11,
+brwiki: php-1.25wmf11,
 brwikimedia: php-1.25wmf11,
 brwikiquote: php-1.25wmf11,
 brwikisource: php-1.25wmf11,
 brwiktionary: php-1.25wmf11,
-bswiki: php-1.25wmf10,
+bswiki: php-1.25wmf11,
 bswikibooks:

[MediaWiki-commits] [Gerrit] Adjust shop link to protorel shop.wikimedia - change (operations/mediawiki-config[master])

2012-07-02 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: Adjust shop link to protorel shop.wikimedia
..


Adjust shop link to protorel shop.wikimedia

Change-Id: Ib025ea787e70ef1d4f73a2b6dccf80d65f2ba305
---
M wmf-config/CommonSettings.php
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/13551
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib025ea787e70ef1d4f73a2b6dccf80d65f2ba305
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Jalexander jalexan...@wikimedia.org
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] US only for shop link - change (operations/mediawiki-config[master])

2012-07-02 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: US only for shop link
..


US only for shop link

Change-Id: I22a36c4c9911b6a2a87d5ffbde55524c3f0dc316
---
M wmf-config/CommonSettings.php
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/13900
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I22a36c4c9911b6a2a87d5ffbde55524c3f0dc316
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Jalexander jalexan...@wikimedia.org
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Bug 38120 - Collection: Invalid argument supplied for foreac... - change (mediawiki...Collection[master])

2012-07-02 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

Change subject: Bug 38120 - Collection: Invalid argument supplied for foreach
..

Bug 38120 - Collection: Invalid argument supplied for foreach

Change-Id: I574a77bb81ea38fa5bea22ea59ba811c78bf3291
---
M Collection.suggest.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Collection 
refs/changes/09/13909/1
--
To view, visit https://gerrit.wikimedia.org/r/13909
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I574a77bb81ea38fa5bea22ea59ba811c78bf3291
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Collection
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove some unused code - change (mediawiki...ZeroRatedMobileAccess[master])

2012-07-02 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

Change subject: Remove some unused code
..

Remove some unused code

Add some method parameter documentation

Reduce some nesting

Change-Id: Iee56d0ce68dc87a7cf1d372260e3552486460039
---
M ZeroRatedMobileAccess.body.php
1 file changed, 71 insertions(+), 43 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ZeroRatedMobileAccess 
refs/changes/34/13934/1
--
To view, visit https://gerrit.wikimedia.org/r/13934
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee56d0ce68dc87a7cf1d372260e3552486460039
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ZeroRatedMobileAccess
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] minor edit, expanding tabs from 4 spaces to tab. - change (mediawiki...Variables[master])

2012-07-03 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: minor edit, expanding tabs from 4 spaces to tab.
..


minor edit, expanding tabs from 4 spaces to tab.

Change-Id: Ia59b9a31a8cacc8bf84405fd12f277558599c066
---
M Variables.php
1 file changed, 23 insertions(+), 23 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/13488
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia59b9a31a8cacc8bf84405fd12f277558599c066
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Variables
Gerrit-Branch: master
Gerrit-Owner: Guillaume Beaudoin mediaw...@soli.ca
Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de
Gerrit-Reviewer: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] (bug 37674) Adding standard logo for na.wikipedia - change (operations/mediawiki-config[master])

2012-07-03 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: (bug 37674) Adding standard logo for na.wikipedia
..


(bug 37674) Adding standard logo for na.wikipedia

Logo: [[File:Wiki.png]] (local)

Change-Id: Ib75962b056815f8cb9506189b96bb0b08b066573
---
M wmf-config/InitialiseSettings.php
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/13301
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib75962b056815f8cb9506189b96bb0b08b066573
Gerrit-PatchSet: 2
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Dereckson dereck...@espace-win.org
Gerrit-Reviewer: Dereckson dereck...@espace-win.org
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] (bug 38023) Add new namespaces/extensions to frrwiki. - change (operations/mediawiki-config[master])

2012-07-03 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: (bug 38023) Add new namespaces/extensions to frrwiki.
..


(bug 38023) Add new namespaces/extensions to frrwiki.

Add new namespaces and extensions for Wikisource integration.

Change-Id: I3173790ed13d10a1b06f0680085c901a8878a715
---
M wmf-config/InitialiseSettings.php
1 file changed, 20 insertions(+), 1 deletion(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  Amire80: Looks good to me, but someone else must approve
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/13347
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3173790ed13d10a1b06f0680085c901a8878a715
Gerrit-PatchSet: 2
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Alex Monk kren...@gmail.com
Gerrit-Reviewer: Alex Monk kren...@gmail.com
Gerrit-Reviewer: Amire80 amir.ahar...@mail.huji.ac.il
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove some old debugging code - change (mediawiki/core[master])

2012-07-04 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

Change subject: Remove some old debugging code
..

Remove some old debugging code

Add a couple more bits of function parameter documentation

Change-Id: If355978801b2bfc8a51f642f53f2cea6f87fc351
---
M includes/cache/SquidUpdate.php
1 file changed, 5 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/97/14197/1
--
To view, visit https://gerrit.wikimedia.org/r/14197
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If355978801b2bfc8a51f642f53f2cea6f87fc351
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Bug 38159: Add import source for dewikiversity - change (operations/mediawiki-config[master])

2012-07-04 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: Bug 38159: Add import source for dewikiversity
..


Bug 38159: Add import source for dewikiversity

Change-Id: I4f65458578f8e4a8d5a2465f8d0b5ae2db536825
---
M wmf-config/InitialiseSettings.php
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/14180
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4f65458578f8e4a8d5a2465f8d0b5ae2db536825
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Raimond Spekking raimond.spekk...@gmail.com
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] *(bug 30976) Add maintenance script to remove preferences fr... - change (mediawiki/core[master])

2012-07-04 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: *(bug 30976) Add maintenance script to remove preferences from 
$wgHiddenPrefs
..


*(bug 30976) Add maintenance script to remove preferences from $wgHiddenPrefs

Change-Id: Ie74fab1edeac2c6b275c51e6af3a7924b3aac46b
---
A maintenance/cleanupPreferences.php
1 file changed, 29 insertions(+), 0 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/9358
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie74fab1edeac2c6b275c51e6af3a7924b3aac46b
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: TyA tya.w...@gmail.com
Gerrit-Reviewer: Anomie anomie.wikipe...@gmail.com
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: TyA tya.w...@gmail.com
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add some explicit member variable definitions - change (mediawiki/core[master])

2012-07-04 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

Change subject: Add some explicit member variable definitions
..

Add some explicit member variable definitions

Bits of parameter documentation

Change-Id: If99a344222900a6715114fa61eadcd4dd3e13db6
---
M includes/SquidPurgeClient.php
1 file changed, 18 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/72/14272/1
--
To view, visit https://gerrit.wikimedia.org/r/14272
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If99a344222900a6715114fa61eadcd4dd3e13db6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Sync DeviceDetection with MF - change (mediawiki/core[master])

2012-07-04 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: Sync DeviceDetection with MF
..


Sync DeviceDetection with MF

Change-Id: I7f15c44f31dacdf208ca159a7b5756884245a494
---
M includes/mobile/DeviceDetection.php
1 file changed, 6 insertions(+), 6 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/9806
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7f15c44f31dacdf208ca159a7b5756884245a494
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: MaxSem maxsem.w...@gmail.com
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Allow API meta=siteinfo to return list of know variable IDs - change (mediawiki/core[master])

2012-07-04 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: Allow API meta=siteinfo to return list of know variable IDs
..


Allow API meta=siteinfo to return list of know variable IDs

To know whether something like {{foo}} is a template, variable, or
function, you have to first check if it's a magic word, and then look up
the magic word ID in the list of variables and the list of function
hooks. The API already can return the list of known magic word mappings
(siprop=magicwords) and function hooks (siprop=functionhooks), this
completes the set by allowing siprop=variables.

Change-Id: If13df9c3796ea6815393d847a3c6f70380bba58a
---
M RELEASE-NOTES-1.20
M includes/api/ApiQuerySiteinfo.php
2 files changed, 13 insertions(+), 1 deletion(-)

Approvals:
  Reedy: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/9866
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If13df9c3796ea6815393d847a3c6f70380bba58a
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Anomie anomie.wikipe...@gmail.com
Gerrit-Reviewer: Anomie anomie.wikipe...@gmail.com
Gerrit-Reviewer: Catrope roan.katt...@gmail.com
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Reimplement CORS properly, addressing Tim's concerns - change (mediawiki/core[master])

2012-07-05 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: Reimplement CORS properly, addressing Tim's concerns
..


Reimplement CORS properly, addressing Tim's concerns

Tim's concerns (listed at
https://bugzilla.wikimedia.org/show_bug.cgi?id=20814#c6) were:
* Lack of Vary: Origin breaks Squid caching
* Vary: Origin on everything would be disastrous, so add an origin param
* Origin header is space-separated list, wasn't treated as such

This commit:
* Remove CORS code from api.php and reimplement it in ApiMain.php
* Add 'origin' parameter to ApiMain
* If 'origin' parameter doesn't match Origin header, send a 403
* If origin is whitelisted, set CORS headers and set Vary: Origin
* Add https?:// to wildcard matching logic, wasn't there but is needed

CORS now works :) you can test it locally as follows:
Set $wgCrossSiteAJAXdomains[] = '*.wikipedia.org';
Log into MediaWiki on localhost
Go to Wikipedia, open a JS console, and run:
$.ajax( {
'url': 'http://localhost/w/api.php',
'data': {
'action': 'query',
'meta': 'userinfo',
'format': 'json',
'origin': 'https://en.wikipedia.org'
// or whichever domain you're on; must be correct!
},
'xhrFields': {
'withCredentials': true
},
'success': function( data ) {
alert( 'Foreign user ' + data.query.userinfo.name +
' (ID ' + data.query.userinfo.id + ')' );
}
} );

Change-Id: I725ce176866d7c81dd9ad6d7bc4a86b7160f2458
---
M api.php
M includes/api/ApiMain.php
2 files changed, 93 insertions(+), 37 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/9624
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I725ce176866d7c81dd9ad6d7bc4a86b7160f2458
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Catrope roan.katt...@gmail.com
Gerrit-Reviewer: Catrope roan.katt...@gmail.com
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: Tim Starling tstarl...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Redo Change-Id: Ie74e5a43ec11de2187fdaa7e3638ebed1fac85c6 - change (mediawiki...WikimediaMessages[master])

2012-07-05 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

Change subject: Redo Change-Id: Ie74e5a43ec11de2187fdaa7e3638ebed1fac85c6
..

Redo Change-Id: Ie74e5a43ec11de2187fdaa7e3638ebed1fac85c6

Change-Id: I6546c9ca0be16da7924401fe629d3b7f4b32668e
---
M WikimediaLabsMessages.i18n.php
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaMessages 
refs/changes/18/14418/1
--
To view, visit https://gerrit.wikimedia.org/r/14418
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6546c9ca0be16da7924401fe629d3b7f4b32668e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaMessages
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Minor stylize, add some braces - change (mediawiki/core[master])

2012-07-05 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

Change subject: Minor stylize, add some braces
..

Minor stylize, add some braces

Couple of bits of member variable docs

Change-Id: Iccf861b1b93543f21f43c50864107ec6bb233bd1
---
M includes/SiteConfiguration.php
1 file changed, 22 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/28/14428/1
--
To view, visit https://gerrit.wikimedia.org/r/14428
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iccf861b1b93543f21f43c50864107ec6bb233bd1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix for https://gerrit.wikimedia.org/r/#/c/14180/ - change (operations/mediawiki-config[master])

2012-07-06 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: Fix for https://gerrit.wikimedia.org/r/#/c/14180/
..


Fix for https://gerrit.wikimedia.org/r/#/c/14180/

I was not aware of the generic entry for wikiversity at the end of the section
therefore dewikiversity is missing the previous sources now.

Change-Id: I2a3d3300e44c0a2c1550eeacf5e855ce99376df3
---
M wmf-config/InitialiseSettings.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/14277
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2a3d3300e44c0a2c1550eeacf5e855ce99376df3
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Raimond Spekking raimond.spekk...@gmail.com
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Move generic wikisource/wikiversitry entries to top of the s... - change (operations/mediawiki-config[master])

2012-07-06 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: Move generic wikisource/wikiversitry entries to top of the 
section
..


Move generic wikisource/wikiversitry entries to top of the section

Add a note about a possible configuration trap
Sort test2wiki by ABC

Change-Id: I1ccba42139020f7d8ff6e8f60780dd4b263aed62
---
M wmf-config/InitialiseSettings.php
1 file changed, 9 insertions(+), 4 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/14448
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1ccba42139020f7d8ff6e8f60780dd4b263aed62
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Raimond Spekking raimond.spekk...@gmail.com
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Use estimateRowPage if wiki is using wgMiserMode - change (mediawiki/core[master])

2012-07-06 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

Change subject: Use estimateRowPage if wiki is using wgMiserMode
..

Use estimateRowPage if wiki is using wgMiserMode

Change-Id: I59404e9514a87f65faf3eb865fafe358d9f01079
---
M maintenance/updateCollation.php
1 file changed, 12 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/07/14507/1
--
To view, visit https://gerrit.wikimedia.org/r/14507
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I59404e9514a87f65faf3eb865fafe358d9f01079
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Pass the full context to the ApiMain instance from api.php. - change (mediawiki/core[master])

2012-07-06 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: Pass the full context to the ApiMain instance from api.php.
..


Pass the full context to the ApiMain instance from api.php.

Passing only the WebRequest instance is not the best
thing when it accepts a complete context.

Change-Id: If02148c850b395a2382f87cbeafbc25887ce8728
---
M api.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/14508
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If02148c850b395a2382f87cbeafbc25887ce8728
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: IAlex ialex.w...@gmail.com
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Added METHOD to db calls - change (mediawiki...Wikibase[master])

2012-07-06 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: Added __METHOD__ to db calls
..


Added __METHOD__ to db calls

Change-Id: Iecc77faf70a1bc487c9dc329878c7833c3e74623
---
M lib/includes/ChangeNotifier.php
M lib/includes/Utils.php
M repo/Wikibase.hooks.php
3 files changed, 12 insertions(+), 7 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/14461
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iecc77faf70a1bc487c9dc329878c7833c3e74623
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] * (bug 38231) Add xml parse tree to action=parse. - change (mediawiki/core[master])

2012-07-07 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

Change subject: * (bug 38231) Add xml parse tree to action=parse.
..

* (bug 38231) Add xml parse tree to action=parse.

Change-Id: I4db3950c937e6299c6f3adc9b90137ac642c607c
---
M RELEASE-NOTES-1.20
M includes/api/ApiParse.php
2 files changed, 15 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/20/14620/1
--
To view, visit https://gerrit.wikimedia.org/r/14620
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4db3950c937e6299c6f3adc9b90137ac642c607c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove BOM from cleanupPreferences - change (mediawiki/core[master])

2012-07-07 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

Change subject: Remove BOM from cleanupPreferences
..

Remove BOM from cleanupPreferences

Change-Id: I3c049c0229bb9ed1365f2781baa44b4c8e1e1e18
---
M maintenance/cleanupPreferences.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/22/14622/1
--
To view, visit https://gerrit.wikimedia.org/r/14622
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3c049c0229bb9ed1365f2781baa44b4c8e1e1e18
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove BOM from cleanupPreferences - change (mediawiki/core[master])

2012-07-07 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: Remove BOM from cleanupPreferences
..


Remove BOM from cleanupPreferences

Change-Id: I3c049c0229bb9ed1365f2781baa44b4c8e1e1e18
---
M maintenance/cleanupPreferences.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Reedy: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/14622
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3c049c0229bb9ed1365f2781baa44b4c8e1e1e18
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org
Gerrit-Reviewer: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove BOM - change (mediawiki...SemanticResultFormats[master])

2012-07-07 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

Change subject: Remove BOM
..

Remove BOM

Change-Id: I035bdefc2ae76fa6da5657f8e09686a74fe3bb12
---
M Exhibit/ajax/simile-ajax-bundle-debug.js
M Exhibit/ajax/simile-ajax-bundle.js
M Exhibit/exhibit/exhibit-bundle-debug.js
M Exhibit/exhibit/exhibit-bundle.js
M Exhibit/exhibit/extensions/calendar/calendar-extension-bundle-debug.js
M Exhibit/exhibit/extensions/calendar/calendar-extension-bundle.js
M Exhibit/exhibit/extensions/chart/chart-extension-bundle-debug.js
M Exhibit/exhibit/extensions/chart/chart-extension-bundle.js
M Exhibit/exhibit/extensions/chart/locales/fr/chart-locale.js
M Exhibit/exhibit/extensions/curate/curate-extension-bundle-debug.js
M Exhibit/exhibit/extensions/curate/curate-extension-bundle.js
M Exhibit/exhibit/extensions/editing/editing-extension-bundle-debug.js
M Exhibit/exhibit/extensions/editing/editing-extension-bundle.js
M Exhibit/exhibit/extensions/freebase/freebase-extension-bundle-debug.js
M Exhibit/exhibit/extensions/freebase/freebase-extension-bundle.js
M Exhibit/exhibit/extensions/map/locales/es/map-locale.js
M Exhibit/exhibit/extensions/map/locales/fr/map-locale.js
M Exhibit/exhibit/extensions/map/locales/sv/map-locale.js
M Exhibit/exhibit/extensions/map/map-extension-bundle-debug.js
M Exhibit/exhibit/extensions/map/map-extension-bundle.js
M Exhibit/exhibit/extensions/time/locales/es/time-locale.js
M Exhibit/exhibit/extensions/time/locales/fr/time-locale.js
M Exhibit/exhibit/extensions/time/locales/sv/time-locale.js
M Exhibit/exhibit/extensions/time/time-extension-bundle-debug.js
M Exhibit/exhibit/extensions/time/time-extension-bundle.js
M Exhibit/exhibit/extensions/timeplot/timeplot-extension-bundle-debug.js
M Exhibit/exhibit/extensions/timeplot/timeplot-extension-bundle.js
M Exhibit/exhibit/locales/de/exhibit-de-bundle.js
M Exhibit/exhibit/locales/de/scripts/ui/formatter-l10n.js
M Exhibit/exhibit/locales/en/exhibit-en-bundle.js
M Exhibit/exhibit/locales/en/scripts/exhibit-l10n.js
M Exhibit/exhibit/locales/es/exhibit-es-bundle.js
M Exhibit/exhibit/locales/es/scripts/data/database-l10n.js
M Exhibit/exhibit/locales/es/scripts/exhibit-l10n.js
M Exhibit/exhibit/locales/es/scripts/ui/lens-l10n.js
M Exhibit/exhibit/locales/es/scripts/ui/views/ordered-view-frame-l10n.js
M Exhibit/exhibit/locales/es/scripts/ui/views/tabular-view-l10n.js
M Exhibit/exhibit/locales/es/scripts/ui/views/thumbnail-view-l10n.js
M Exhibit/exhibit/locales/es/scripts/ui/views/tile-view-l10n.js
M Exhibit/exhibit/locales/es/scripts/ui/views/view-panel-l10n.js
M Exhibit/exhibit/locales/fr/exhibit-fr-bundle.js
M Exhibit/exhibit/locales/fr/scripts/data/database-l10n.js
M Exhibit/exhibit/locales/fr/scripts/exhibit-l10n.js
M Exhibit/exhibit/locales/fr/scripts/ui/formatter-l10n.js
M Exhibit/exhibit/locales/fr/scripts/ui/views/ordered-view-frame-l10n.js
M Exhibit/exhibit/locales/fr/scripts/ui/views/tabular-view-l10n.js
M Exhibit/exhibit/locales/fr/scripts/ui/views/thumbnail-view-l10n.js
M Exhibit/exhibit/locales/fr/scripts/ui/views/tile-view-l10n.js
M Exhibit/exhibit/locales/fr/scripts/ui/views/view-panel-l10n.js
M 
Exhibit/exhibit/locales/fr/scripts/ui/widgets/collection-summary-widget-l10n.js
M Exhibit/exhibit/locales/fr/scripts/util/facets-l10n.js
M Exhibit/exhibit/locales/fr/scripts/util/views-l10n.js
M Exhibit/exhibit/locales/nl/exhibit-nl-bundle.js
M Exhibit/exhibit/locales/sv/exhibit-sv-bundle.js
M Exhibit/exhibit/locales/sv/scripts/data/database-l10n.js
M Exhibit/exhibit/locales/sv/scripts/exhibit-l10n.js
M Exhibit/exhibit/locales/sv/scripts/ui/views/ordered-view-frame-l10n.js
M Exhibit/exhibit/locales/sv/scripts/ui/views/tabular-view-l10n.js
M Exhibit/exhibit/locales/sv/scripts/ui/views/view-panel-l10n.js
M Exhibit/exhibit/locales/zh/exhibit-zh-bundle.js
M Exhibit/exhibit/locales/zh/scripts/data/database-l10n.js
M Exhibit/exhibit/locales/zh/scripts/exhibit-l10n.js
M Exhibit/timeline/api/compilations/timeline-en-compilation-debug.js
M Exhibit/timeline/api/compilations/timeline-en-compilation.js
M Exhibit/timeline/api/ext/geochrono/scripts/ether-painters.js
M Exhibit/timeline/api/scripts/ext/japanese-eras.js
M Exhibit/timeline/api/scripts/l10n/ru/labellers.js
M Exhibit/timeline/api/scripts/l10n/ru/timeline.js
M Exhibit/timeline/api/scripts/l10n/se/labellers.js
M Exhibit/timeline/api/scripts/l10n/vi/timeline.js
M Exhibit/timeline/api/scripts/l10n/zh/labellers.js
M Exhibit/timeline/api/scripts/l10n/zh/timeline.js
M Exhibit/timeline/api/timeline-bundle-debug.js
M Exhibit/timeline/api/timeline-bundle.js
M SRF_Messages.php
M Timeline/SimileTimeline/ext/geochrono/scripts/ether-painters.js
M Timeline/SimileTimeline/scripts/ext/japanese-eras.js
M Timeline/SimileTimeline/scripts/l10n/ru/labellers.js
M Timeline/SimileTimeline/scripts/l10n/ru/timeline.js
M Timeline/SimileTimeline/scripts/l10n/se/labellers.js
M Timeline/SimileTimeline/scripts/l10n/vi/timeline.js
M

[MediaWiki-commits] [Gerrit] Remove BOM - change (mediawiki...SemanticResultFormats[master])

2012-07-07 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: Remove BOM
..


Remove BOM

Change-Id: I035bdefc2ae76fa6da5657f8e09686a74fe3bb12
---
M Exhibit/ajax/simile-ajax-bundle-debug.js
M Exhibit/ajax/simile-ajax-bundle.js
M Exhibit/exhibit/exhibit-bundle-debug.js
M Exhibit/exhibit/exhibit-bundle.js
M Exhibit/exhibit/extensions/calendar/calendar-extension-bundle-debug.js
M Exhibit/exhibit/extensions/calendar/calendar-extension-bundle.js
M Exhibit/exhibit/extensions/chart/chart-extension-bundle-debug.js
M Exhibit/exhibit/extensions/chart/chart-extension-bundle.js
M Exhibit/exhibit/extensions/chart/locales/fr/chart-locale.js
M Exhibit/exhibit/extensions/curate/curate-extension-bundle-debug.js
M Exhibit/exhibit/extensions/curate/curate-extension-bundle.js
M Exhibit/exhibit/extensions/editing/editing-extension-bundle-debug.js
M Exhibit/exhibit/extensions/editing/editing-extension-bundle.js
M Exhibit/exhibit/extensions/freebase/freebase-extension-bundle-debug.js
M Exhibit/exhibit/extensions/freebase/freebase-extension-bundle.js
M Exhibit/exhibit/extensions/map/locales/es/map-locale.js
M Exhibit/exhibit/extensions/map/locales/fr/map-locale.js
M Exhibit/exhibit/extensions/map/locales/sv/map-locale.js
M Exhibit/exhibit/extensions/map/map-extension-bundle-debug.js
M Exhibit/exhibit/extensions/map/map-extension-bundle.js
M Exhibit/exhibit/extensions/time/locales/es/time-locale.js
M Exhibit/exhibit/extensions/time/locales/fr/time-locale.js
M Exhibit/exhibit/extensions/time/locales/sv/time-locale.js
M Exhibit/exhibit/extensions/time/time-extension-bundle-debug.js
M Exhibit/exhibit/extensions/time/time-extension-bundle.js
M Exhibit/exhibit/extensions/timeplot/timeplot-extension-bundle-debug.js
M Exhibit/exhibit/extensions/timeplot/timeplot-extension-bundle.js
M Exhibit/exhibit/locales/de/exhibit-de-bundle.js
M Exhibit/exhibit/locales/de/scripts/ui/formatter-l10n.js
M Exhibit/exhibit/locales/en/exhibit-en-bundle.js
M Exhibit/exhibit/locales/en/scripts/exhibit-l10n.js
M Exhibit/exhibit/locales/es/exhibit-es-bundle.js
M Exhibit/exhibit/locales/es/scripts/data/database-l10n.js
M Exhibit/exhibit/locales/es/scripts/exhibit-l10n.js
M Exhibit/exhibit/locales/es/scripts/ui/lens-l10n.js
M Exhibit/exhibit/locales/es/scripts/ui/views/ordered-view-frame-l10n.js
M Exhibit/exhibit/locales/es/scripts/ui/views/tabular-view-l10n.js
M Exhibit/exhibit/locales/es/scripts/ui/views/thumbnail-view-l10n.js
M Exhibit/exhibit/locales/es/scripts/ui/views/tile-view-l10n.js
M Exhibit/exhibit/locales/es/scripts/ui/views/view-panel-l10n.js
M Exhibit/exhibit/locales/fr/exhibit-fr-bundle.js
M Exhibit/exhibit/locales/fr/scripts/data/database-l10n.js
M Exhibit/exhibit/locales/fr/scripts/exhibit-l10n.js
M Exhibit/exhibit/locales/fr/scripts/ui/formatter-l10n.js
M Exhibit/exhibit/locales/fr/scripts/ui/views/ordered-view-frame-l10n.js
M Exhibit/exhibit/locales/fr/scripts/ui/views/tabular-view-l10n.js
M Exhibit/exhibit/locales/fr/scripts/ui/views/thumbnail-view-l10n.js
M Exhibit/exhibit/locales/fr/scripts/ui/views/tile-view-l10n.js
M Exhibit/exhibit/locales/fr/scripts/ui/views/view-panel-l10n.js
M 
Exhibit/exhibit/locales/fr/scripts/ui/widgets/collection-summary-widget-l10n.js
M Exhibit/exhibit/locales/fr/scripts/util/facets-l10n.js
M Exhibit/exhibit/locales/fr/scripts/util/views-l10n.js
M Exhibit/exhibit/locales/nl/exhibit-nl-bundle.js
M Exhibit/exhibit/locales/sv/exhibit-sv-bundle.js
M Exhibit/exhibit/locales/sv/scripts/data/database-l10n.js
M Exhibit/exhibit/locales/sv/scripts/exhibit-l10n.js
M Exhibit/exhibit/locales/sv/scripts/ui/views/ordered-view-frame-l10n.js
M Exhibit/exhibit/locales/sv/scripts/ui/views/tabular-view-l10n.js
M Exhibit/exhibit/locales/sv/scripts/ui/views/view-panel-l10n.js
M Exhibit/exhibit/locales/zh/exhibit-zh-bundle.js
M Exhibit/exhibit/locales/zh/scripts/data/database-l10n.js
M Exhibit/exhibit/locales/zh/scripts/exhibit-l10n.js
M Exhibit/timeline/api/compilations/timeline-en-compilation-debug.js
M Exhibit/timeline/api/compilations/timeline-en-compilation.js
M Exhibit/timeline/api/ext/geochrono/scripts/ether-painters.js
M Exhibit/timeline/api/scripts/ext/japanese-eras.js
M Exhibit/timeline/api/scripts/l10n/ru/labellers.js
M Exhibit/timeline/api/scripts/l10n/ru/timeline.js
M Exhibit/timeline/api/scripts/l10n/se/labellers.js
M Exhibit/timeline/api/scripts/l10n/vi/timeline.js
M Exhibit/timeline/api/scripts/l10n/zh/labellers.js
M Exhibit/timeline/api/scripts/l10n/zh/timeline.js
M Exhibit/timeline/api/timeline-bundle-debug.js
M Exhibit/timeline/api/timeline-bundle.js
M SRF_Messages.php
M Timeline/SimileTimeline/ext/geochrono/scripts/ether-painters.js
M Timeline/SimileTimeline/scripts/ext/japanese-eras.js
M Timeline/SimileTimeline/scripts/l10n/ru/labellers.js
M Timeline/SimileTimeline/scripts/l10n/ru/timeline.js
M Timeline/SimileTimeline/scripts/l10n/se/labellers.js
M Timeline/SimileTimeline/scripts/l10n/vi/timeline.js
M

[MediaWiki-commits] [Gerrit] Remove 2 more BOM - change (mediawiki...SemanticResultFormats[master])

2012-07-07 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

Change subject: Remove 2 more BOM
..

Remove 2 more BOM

Change-Id: Ie2d93735e05fa77613d8069ef9b670a757ad63d6
---
M RELEASE-NOTES
M TagCloud/SRF_TagCloud.php
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticResultFormats 
refs/changes/24/14624/1
--
To view, visit https://gerrit.wikimedia.org/r/14624
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie2d93735e05fa77613d8069ef9b670a757ad63d6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticResultFormats
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove 2 more BOM - change (mediawiki...SemanticResultFormats[master])

2012-07-07 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: Remove 2 more BOM
..


Remove 2 more BOM

Change-Id: Ie2d93735e05fa77613d8069ef9b670a757ad63d6
---
M RELEASE-NOTES
M TagCloud/SRF_TagCloud.php
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/14624
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2d93735e05fa77613d8069ef9b670a757ad63d6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticResultFormats
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org
Gerrit-Reviewer: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove BOM - change (mediawiki...SemanticMediaWiki[master])

2012-07-07 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

Change subject: Remove BOM
..

Remove BOM

Change-Id: Ida5ed950f8f2d5beab21671800ad42b99914a646
---
M RELEASE-NOTES
M includes/queryprinters/SMW_QP_List.php
M languages/SMW_Messages.php
3 files changed, 3 insertions(+), 3 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki 
refs/changes/29/14629/1
--
To view, visit https://gerrit.wikimedia.org/r/14629
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ida5ed950f8f2d5beab21671800ad42b99914a646
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove BOM - change (mediawiki...FlaggedRevs[master])

2012-07-07 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: Remove BOM
..


Remove BOM

Change-Id: I765dea4f32519c33114cacf647252158e3f50dd0
---
M README.txt
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Reedy: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/14625
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I765dea4f32519c33114cacf647252158e3f50dd0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FlaggedRevs
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org
Gerrit-Reviewer: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] cldr to master - change (mediawiki/core[wmf/1.20wmf6])

2012-07-07 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: cldr to master
..


cldr to master

Change-Id: I38088b337de2dfe6f6115258164e367bfb6e2de6
---
M extensions/cldr
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/14630
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I38088b337de2dfe6f6115258164e367bfb6e2de6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.20wmf6
Gerrit-Owner: Reedy re...@wikimedia.org
Gerrit-Reviewer: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add Christian, Rob and Subbu to the extension authors list - change (mediawiki...VisualEditor[master])

2012-07-07 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: Add Christian, Rob and Subbu to the extension authors list
..


Add Christian, Rob and Subbu to the extension authors list

Change-Id: Ifc2d683e510b3f6e76037ac67a559586fc971dc5
---
M VisualEditor.php
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/14602
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc2d683e510b3f6e76037ac67a559586fc971dc5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope roan.katt...@gmail.com
Gerrit-Reviewer: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] (bug 31313) Clarify watchlist preference messages - change (mediawiki/core[master])

2012-07-07 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: (bug 31313) Clarify watchlist preference messages
..


(bug 31313) Clarify watchlist preference messages

Bug 31313 can be closed, at least in part, by better explaining
the existing preference for watching created pages--users might
not easily understand that pages also includes uploaded files,
so this patch clarifies where necessary.

Change-Id: I26cd0d7a0de76b0b4c8aeb30c1599411b5fb4b07
---
M languages/messages/MessagesEn.php
M languages/messages/MessagesQqq.php
2 files changed, 10 insertions(+), 10 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/11054
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I26cd0d7a0de76b0b4c8aeb30c1599411b5fb4b07
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: MarkTraceur mtrac...@member.fsf.org
Gerrit-Reviewer: MarkTraceur mtrac...@member.fsf.org
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: Siebrand s.mazel...@xs4all.nl
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Improve documentation of maintenance scripts. - change (mediawiki/core[master])

2012-07-07 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: Improve documentation of maintenance scripts.
..


Improve documentation of maintenance scripts.

Change-Id: I1c911eb0fd6108fdee0b4e96363d87b926aba396
---
M maintenance/cleanupAncientTables.php
M maintenance/cleanupCaps.php
M maintenance/cleanupImages.php
M maintenance/cleanupRemovedModules.php
M maintenance/cleanupSpam.php
M maintenance/cleanupTable.inc
M maintenance/cleanupTitles.php
M maintenance/cleanupUploadStash.php
M maintenance/cleanupWatchlist.php
M maintenance/clear_interwiki_cache.php
M maintenance/clear_stats.php
M maintenance/compareParsers.php
12 files changed, 95 insertions(+), 32 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/12913
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1c911eb0fd6108fdee0b4e96363d87b926aba396
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: IAlex ialex.w...@gmail.com
Gerrit-Reviewer: Bhartshorne b...@wikimedia.org
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: Varnent ad...@wikiqueer.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Added SpecialPageAfterExecute and SpecialPageBeforeExecute h... - change (mediawiki/core[master])

2012-07-07 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: Added SpecialPageAfterExecute and SpecialPageBeforeExecute hooks
..


Added SpecialPageAfterExecute and SpecialPageBeforeExecute hooks

Danwe apparently needs them :)

Change-Id: Ic74c7ba7f4168d2b0cfbd3c4e551218f6cb2693a
---
M RELEASE-NOTES-1.20
M docs/hooks.txt
M includes/SpecialPage.php
3 files changed, 30 insertions(+), 0 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  Daniel Werner: Looks good to me, but someone else must approve
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/14458
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic74c7ba7f4168d2b0cfbd3c4e551218f6cb2693a
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Aaron Schulz asch...@wikimedia.org
Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de
Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: MaxSem maxsem.w...@gmail.com
Gerrit-Reviewer: Platonides platoni...@gmail.com
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] CLI install exited with 0 status code - change (mediawiki/core[master])

2012-07-07 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: CLI install exited with 0 status code
..


CLI install exited with 0 status code

The CliInstaller used the '0' exit code whenever the status was not OK.
That makes third party script assuming the install actually ran fine
since a 0 exit code is mostly considered as a success. By sending an
error code  0 (here 1), our automatic installers will be able to catch
the failure and stop proceeding.

I had that issue with a Jenkins job which ran the CLI installer and kept
continuing although there was an error about LocalSettings.php already
existing.

Change-Id: I4f4727df85c09c0a04e4630df91c6213dfce6e9a
---
M includes/installer/CliInstaller.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/14632
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4f4727df85c09c0a04e4630df91c6213dfce6e9a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Hashar has...@free.fr
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Method parameter documentation - change (mediawiki...LabeledSectionTransclusion[master])

2012-07-07 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

Change subject: Method parameter documentation
..

Method parameter documentation

Removed compat.php as it's not used anywhere

Change-Id: I14469e5d7cccf81d3278a83819b2cf3ef5e26fbe
---
D compat.php
M lst.php
M lsth.php
3 files changed, 54 insertions(+), 37 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/LabeledSectionTransclusion
 refs/changes/64/14664/1
--
To view, visit https://gerrit.wikimedia.org/r/14664
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I14469e5d7cccf81d3278a83819b2cf3ef5e26fbe
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LabeledSectionTransclusion
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Improve documentation of maintenance scripts. - change (mediawiki/core[master])

2012-07-08 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: Improve documentation of maintenance scripts.
..


Improve documentation of maintenance scripts.

Change-Id: I2433d23544e808e16f28805f93183b1af2409c94
---
M maintenance/cleanupPreferences.php
M maintenance/deleteArchivedRevisions.inc
M maintenance/deleteBatch.php
M maintenance/deleteDefaultMessages.php
M maintenance/deleteImageMemcached.php
M maintenance/deleteOldRevisions.php
M maintenance/deleteOrphanedRevisions.php
M maintenance/deleteRevision.php
M maintenance/deleteSelfExternals.php
M maintenance/dumpIterator.php
M maintenance/dumpLinks.php
M maintenance/dumpSisterSites.php
12 files changed, 108 insertions(+), 19 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/14745
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2433d23544e808e16f28805f93183b1af2409c94
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: IAlex ialex.w...@gmail.com
Gerrit-Reviewer: IAlex ialex.w...@gmail.com
Gerrit-Reviewer: Krinkle ttij...@wikimedia.org
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Seems I didn't fix all the skin-foobar calls - change (mediawiki...CodeReview[master])

2012-07-09 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

Change subject: Seems I didn't fix all the skin-foobar calls
..

Seems I didn't fix all the skin-foobar calls

Fixes, among others:

PHP Fatal error:  Call to a member function link() on a non-object in 
/usr/local/apache/common-local/php-1.20wmf7/extensions/CodeReview/ui/CodeRevisionListView.
php on line 395

Change-Id: Ic0f8594cff9f8b2092ce0971271d9070f02e6221
---
M ui/CodeCommentsListView.php
M ui/CodeRevisionListView.php
M ui/CodeStatusChangeListView.php
3 files changed, 11 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CodeReview 
refs/changes/77/14777/1
--
To view, visit https://gerrit.wikimedia.org/r/14777
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic0f8594cff9f8b2092ce0971271d9070f02e6221
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CodeReview
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Seems I didn't fix all the skin-foobar calls - change (mediawiki...CodeReview[master])

2012-07-09 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: Seems I didn't fix all the skin-foobar calls
..


Seems I didn't fix all the skin-foobar calls

Fixes, among others:

PHP Fatal error:  Call to a member function link() on a non-object in 
/usr/local/apache/common-local/php-1.20wmf7/extensions/CodeReview/ui/CodeRevisionListView.
php on line 395

Change-Id: Ic0f8594cff9f8b2092ce0971271d9070f02e6221
---
M ui/CodeCommentsListView.php
M ui/CodeRevisionListView.php
M ui/CodeStatusChangeListView.php
3 files changed, 11 insertions(+), 11 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/14777
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic0f8594cff9f8b2092ce0971271d9070f02e6221
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CodeReview
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org
Gerrit-Reviewer: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Update CR to trunk to fix fatals - change (mediawiki/core[wmf/1.20wmf7])

2012-07-09 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

Change subject: Update CR to trunk to fix fatals
..

Update CR to trunk to fix fatals

Change-Id: Iefb11aceafef940c1a0ab76dbd16d46cf9c8a366
---
M extensions/CodeReview
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/78/14778/1
--
To view, visit https://gerrit.wikimedia.org/r/14778
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iefb11aceafef940c1a0ab76dbd16d46cf9c8a366
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.20wmf7
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Update CR to trunk to fix fatals - change (mediawiki/core[wmf/1.20wmf7])

2012-07-09 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: Update CR to trunk to fix fatals
..


Update CR to trunk to fix fatals

Change-Id: Iefb11aceafef940c1a0ab76dbd16d46cf9c8a366
---
M extensions/CodeReview
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/14778
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iefb11aceafef940c1a0ab76dbd16d46cf9c8a366
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.20wmf7
Gerrit-Owner: Reedy re...@wikimedia.org
Gerrit-Reviewer: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fixed Language::isValidBuiltInCode exception. - change (mediawiki/core[wmf/1.20wmf6])

2012-07-09 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

Change subject: Fixed Language::isValidBuiltInCode exception.
..

Fixed Language::isValidBuiltInCode exception.

Change-Id: Ib7c7c0f3ed9382beea5fb0a9b2aa1809f75a8e1c
---
M includes/media/FormatMetadata.php
1 file changed, 9 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/47/14847/1
--
To view, visit https://gerrit.wikimedia.org/r/14847
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib7c7c0f3ed9382beea5fb0a9b2aa1809f75a8e1c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.20wmf6
Gerrit-Owner: Reedy re...@wikimedia.org
Gerrit-Reviewer: Aaron Schulz asch...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fixed Language::isValidBuiltInCode exception. - change (mediawiki/core[wmf/1.20wmf7])

2012-07-09 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

Change subject: Fixed Language::isValidBuiltInCode exception.
..

Fixed Language::isValidBuiltInCode exception.

Change-Id: Ib7c7c0f3ed9382beea5fb0a9b2aa1809f75a8e1c
---
M includes/media/FormatMetadata.php
1 file changed, 9 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/48/14848/1
--
To view, visit https://gerrit.wikimedia.org/r/14848
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib7c7c0f3ed9382beea5fb0a9b2aa1809f75a8e1c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.20wmf7
Gerrit-Owner: Reedy re...@wikimedia.org
Gerrit-Reviewer: Aaron Schulz asch...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fixed Language::isValidBuiltInCode exception. - change (mediawiki/core[wmf/1.20wmf7])

2012-07-09 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: Fixed Language::isValidBuiltInCode exception.
..


Fixed Language::isValidBuiltInCode exception.

Change-Id: Ib7c7c0f3ed9382beea5fb0a9b2aa1809f75a8e1c
---
M includes/media/FormatMetadata.php
1 file changed, 9 insertions(+), 9 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/14848
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib7c7c0f3ed9382beea5fb0a9b2aa1809f75a8e1c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.20wmf7
Gerrit-Owner: Reedy re...@wikimedia.org
Gerrit-Reviewer: Aaron Schulz asch...@wikimedia.org
Gerrit-Reviewer: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fixed Language::isValidBuiltInCode exception. - change (mediawiki/core[wmf/1.20wmf6])

2012-07-09 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: Fixed Language::isValidBuiltInCode exception.
..


Fixed Language::isValidBuiltInCode exception.

Change-Id: Ib7c7c0f3ed9382beea5fb0a9b2aa1809f75a8e1c
---
M includes/media/FormatMetadata.php
1 file changed, 9 insertions(+), 9 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/14847
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib7c7c0f3ed9382beea5fb0a9b2aa1809f75a8e1c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.20wmf6
Gerrit-Owner: Reedy re...@wikimedia.org
Gerrit-Reviewer: Aaron Schulz asch...@wikimedia.org
Gerrit-Reviewer: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Minor documentation tweaks - change (mediawiki/core[master])

2012-07-09 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

Change subject: Minor documentation tweaks
..

Minor documentation tweaks

Explicitly define array variable, rather than possible conditional assignment 
if no iteration takes place

Change-Id: Ic1cdec163e2cf9cb5d160209596962fc985d22bd
---
M includes/media/FormatMetadata.php
1 file changed, 27 insertions(+), 24 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/51/14851/1
--
To view, visit https://gerrit.wikimedia.org/r/14851
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic1cdec163e2cf9cb5d160209596962fc985d22bd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] (bug 34370) Remove chwikimedia from SiteMatrix - change (operations/mediawiki-config[master])

2012-07-10 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: (bug 34370) Remove chwikimedia from SiteMatrix
..


(bug 34370) Remove chwikimedia from SiteMatrix

* The entries are currently causing issues in script that iterate
  over wikis in the site matrix and expect basic things like
  /w/api.php to exist and, that any entries not explicitly
  specified as private/fishbowl/closed to be in CentralAuth.

* Note: It is already in deleted.dblist

* Note: Leaving it in todo.dblist as I have no clue what that
  list is used for. Not to mention what the criteria for inclusion
  would be..

Change-Id: I6b446ffbde0679651c2719a281c013898717727e
---
M all.dblist
M wikimedia.dblist
M wmf-config/InitialiseSettings.php
3 files changed, 0 insertions(+), 9 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/14746
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6b446ffbde0679651c2719a281c013898717727e
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Krinkle ttij...@wikimedia.org
Gerrit-Reviewer: Demon ch...@wikimedia.org
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove broken docroot/foundation/extract.php - change (operations/mediawiki-config[master])

2012-07-10 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: Remove broken docroot/foundation/extract.php
..


Remove broken docroot/foundation/extract.php

* Broken:
 - http://wikimediafoundation.org/extract.php?title=index
PHP fatal error in 
/usr/local/apache/common-local/docroot/foundation/extract.php line 54: Class 
'Title' not found

* index, fundraising and GNU_FDL (which is what extract.php
  handled) all have backwards compatible redirects in place in
  apache-config.

* 
https://gerrit.wikimedia.org/r/gitweb?p=operations/apache-config.git;a=blob;f=foundation.conf;h=baa5726bfdec59985e9e5a793f8c22d1686c1d08;hb=HEAD#l13:

  # extract.php pages redirected to new pages
  RewriteRule ^/fundraising(\.html)?$ /wiki/Fundraising [R=301,L]
  RewriteRule ^/index(\.html)?$ /wiki/Home [R=301,L]
  RewriteRule ^/GNU_FDL(\.html)?$ /wiki/GNU_Free_Documentation_License [R=301,L]

Change-Id: I9546d0bf1fbf4a758bd7399f6c6ca60acf8b05be
---
D docroot/foundation/extract.php
1 file changed, 0 insertions(+), 70 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/14747
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9546d0bf1fbf4a758bd7399f6c6ca60acf8b05be
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Krinkle ttij...@wikimedia.org
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] (bug 38247) Add WP and WT namespace aliases to ilowiki - change (operations/mediawiki-config[master])

2012-07-10 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: (bug 38247) Add WP and WT namespace aliases to ilowiki
..


(bug 38247) Add WP and WT namespace aliases to ilowiki

Change-Id: Ie677346e3ca97fe7e56de03a6e7df0bca7f424dd
---
M wmf-config/InitialiseSettings.php
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/14678
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie677346e3ca97fe7e56de03a6e7df0bca7f424dd
Gerrit-PatchSet: 2
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Alex Monk kren...@gmail.com
Gerrit-Reviewer: Alex Monk kren...@gmail.com
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] remove unneeded @abstract - change (mediawiki/core[master])

2012-07-10 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: remove unneeded @abstract
..


remove unneeded @abstract

Doxygen does recognize abstract methods when it is properly marked as
abstracted. That keyword is a left.

Change-Id: I7df790058edf0eefb07eb4c37a2586b5c16898e3
---
M includes/Feed.php
M includes/resourceloader/ResourceLoaderWikiModule.php
2 files changed, 0 insertions(+), 6 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/14913
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7df790058edf0eefb07eb4c37a2586b5c16898e3
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Hashar has...@free.fr
Gerrit-Reviewer: Hashar has...@free.fr
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] ChannelFeed now marked as an abstract class - change (mediawiki/core[master])

2012-07-10 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: ChannelFeed now marked as an abstract class
..


ChannelFeed now marked as an abstract class

The ChannelFeed class has always been considered as an abstract class.
Looks like we forgot to update its definition since PHP switched to
support class abstractions.

Also marked abstract the three inner methods that must be extended:

 ChannelFeed::outHeader()
 ChannelFeed::outItem()
 ChannelFeed::outFooter()

Change-Id: Ie0111786af37531d53ee3fc845e0125136ca298f
---
M includes/Feed.php
1 file changed, 17 insertions(+), 11 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/14877
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0111786af37531d53ee3fc845e0125136ca298f
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Hashar has...@free.fr
Gerrit-Reviewer: Hashar has...@free.fr
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] converts '@fixme' to '@todo FIXME' - change (mediawiki/core[master])

2012-07-10 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: converts '@fixme' to '@todo FIXME'
..


converts '@fixme' to '@todo FIXME'

@fixme is simply not recognized by doxygen whereas @todo is used to
generate a nice ... todo list!!

Change-Id: If956c0a164373126ce48b791d45c56962034eecd
---
M includes/Cookie.php
M includes/HttpFunctions.php
M includes/Preferences.php
M includes/Skin.php
M includes/logging/LogEventsList.php
M includes/media/Bitmap.php
M includes/media/ExifBitmap.php
M languages/Language.php
M maintenance/jsparse.php
M maintenance/rebuildImages.php
M tests/phpunit/includes/WikiPageTest.php
M tests/phpunit/includes/parser/NewParserTest.php
12 files changed, 14 insertions(+), 13 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/14918
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If956c0a164373126ce48b791d45c56962034eecd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Hashar has...@free.fr
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] update @param @return doc in several files - change (mediawiki/core[master])

2012-07-10 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: update @param @return doc in several files
..


update @param @return doc in several files

Change-Id: I0e23227330f90dc4121fd2a313d2e9a33c3c97a7
---
M includes/ChangesList.php
M includes/EditPage.php
M includes/Export.php
M includes/Linker.php
M includes/LinksUpdate.php
M includes/OutputPage.php
M includes/RecentChange.php
M includes/StringUtils.php
M includes/logging/LogEventsList.php
M includes/logging/PatrolLog.php
M includes/media/Generic.php
M includes/objectcache/MemcachedBagOStuff.php
M includes/parser/LinkHolderArray.php
M includes/parser/Parser.php
M includes/parser/ParserCache.php
M includes/specials/SpecialProtectedpages.php
M includes/specials/SpecialRevisiondelete.php
M includes/specials/SpecialUploadStash.php
M includes/specials/SpecialUserlogin.php
M includes/upload/UploadBase.php
M includes/upload/UploadStash.php
21 files changed, 56 insertions(+), 34 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/14917
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0e23227330f90dc4121fd2a313d2e9a33c3c97a7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Hashar has...@free.fr
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] move parameter doc under @param - change (mediawiki/core[master])

2012-07-10 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: move parameter doc under @param
..


move parameter doc under @param

The description of an array of parameter really belong under @param,
makes doxygen HTML documentation nicer.

Change-Id: If2c01a11b8dbf02b272b7ccce591a92293346731
---
M includes/filerepo/backend/FileBackend.php
1 file changed, 25 insertions(+), 43 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/14914
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If2c01a11b8dbf02b272b7ccce591a92293346731
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Hashar has...@free.fr
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] prettify SkinTemplate:makeLink documentation - change (mediawiki/core[master])

2012-07-10 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: prettify SkinTemplate:makeLink documentation
..


prettify SkinTemplate:makeLink documentation

Change-Id: Ib70e00460c8e01ec810a4123b7eec52c3632b99d
---
M includes/SkinTemplate.php
1 file changed, 31 insertions(+), 18 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/14915
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib70e00460c8e01ec810a4123b7eec52c3632b99d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Hashar has...@free.fr
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] prettify documentation - change (mediawiki/core[master])

2012-07-10 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: prettify documentation
..


prettify documentation

Change-Id: Icfd267a94ac981b4c15e51add18c6d8ceb68454e
---
M includes/Defines.php
M includes/api/ApiFormatXml.php
M includes/parser/Parser.php
M includes/upload/UploadBase.php
4 files changed, 51 insertions(+), 25 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/14919
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icfd267a94ac981b4c15e51add18c6d8ceb68454e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Hashar has...@free.fr
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] escape tags and entity in doxygen comments - change (mediawiki/core[master])

2012-07-10 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: escape tags and entity in doxygen comments
..


escape tags and entity in doxygen comments

When inserting XML elements inline such as this one, doxygen chokes
about it not being known. Simply enclosing the tag in double quotes
prevents doxygen from emitting a warning.

Also enclosed a few invalid functions calls such as \. and double quoted
the HTML entities such as foobar;

Change-Id: I4019637145e683c2bec3d17b2fd98b0c50a932f1
---
M includes/ChangesList.php
M includes/DefaultSettings.php
M includes/EditPage.php
M includes/Export.php
M includes/GlobalFunctions.php
M includes/HTMLForm.php
M includes/Html.php
M includes/Import.php
M includes/MagicWord.php
M includes/OutputPage.php
M includes/Pager.php
M includes/Preferences.php
M includes/RevisionList.php
M includes/Sanitizer.php
M includes/Skin.php
M includes/SkinLegacy.php
M includes/SkinTemplate.php
M includes/User.php
M includes/WebRequest.php
M includes/api/ApiBase.php
M includes/api/ApiPageSet.php
M includes/api/ApiQueryCategoryInfo.php
M includes/api/ApiQueryImages.php
M includes/api/ApiResult.php
M includes/db/Database.php
M includes/filerepo/backend/FileBackend.php
M includes/filerepo/backend/lockmanager/MemcLockManager.php
M includes/filerepo/file/File.php
M includes/installer/WebInstallerOutput.php
M includes/installer/WebInstallerPage.php
M includes/job/DoubleRedirectJob.php
M includes/json/FormatJson.php
M includes/media/MediaTransformOutput.php
M includes/media/SVGMetadataExtractor.php
M includes/media/XMP.php
M includes/objectcache/MemcachedClient.php
M includes/parser/Parser.php
M includes/parser/ParserOutput.php
M includes/parser/Preprocessor.php
M includes/parser/Preprocessor_DOM.php
M includes/parser/Preprocessor_Hash.php
M includes/resourceloader/ResourceLoader.php
M includes/resourceloader/ResourceLoaderModule.php
43 files changed, 190 insertions(+), 175 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/14880
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4019637145e683c2bec3d17b2fd98b0c50a932f1
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Hashar has...@free.fr
Gerrit-Reviewer: Hashar has...@free.fr
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Improve documentation of maintenance scripts. - change (mediawiki/core[master])

2012-07-10 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: Improve documentation of maintenance scripts.
..


Improve documentation of maintenance scripts.

Change-Id: I0e2869970c46f4fd14b792f2978cc1ba9d8550be
---
M maintenance/dumpUploads.php
M maintenance/edit.php
M maintenance/fetchText.php
M maintenance/fileOpPerfTest.php
M maintenance/findHooks.php
M maintenance/fixDoubleRedirects.php
M maintenance/fixExtLinksProtocolRelative.php
M maintenance/fixSlaveDesync.php
M maintenance/fixTimestamps.php
M maintenance/fixUserRegistration.php
M maintenance/formatInstallDoc.php
11 files changed, 80 insertions(+), 12 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/14924
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0e2869970c46f4fd14b792f2978cc1ba9d8550be
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: IAlex ialex.w...@gmail.com
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] (bug 38111) rm space from mlwikiquote sitename - change (operations/mediawiki-config[master])

2012-07-10 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: (bug 38111) rm space from mlwikiquote sitename
..


(bug 38111) rm space from mlwikiquote sitename

also from Project namespace

Change-Id: If8d9d29307ee15e8dd2a2bfcc9ccc0aed2ed944a
---
M wmf-config/InitialiseSettings.php
1 file changed, 6 insertions(+), 2 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  Hashar: Looks good to me, but someone else must approve
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/14506
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If8d9d29307ee15e8dd2a2bfcc9ccc0aed2ed944a
Gerrit-PatchSet: 2
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Jeremyb jer...@tuxmachine.com
Gerrit-Reviewer: Hashar has...@free.fr
Gerrit-Reviewer: Jeremyb jer...@tuxmachine.com
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] (bug 38287) Install LST extension on itwikibooks - change (operations/mediawiki-config[master])

2012-07-10 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: (bug 38287) Install LST extension on itwikibooks
..


(bug 38287) Install LST extension on itwikibooks

Before deploying this you should check the bugzilla comments.

Change-Id: I5ec6c798c98fc2735afb8ab8880038c4cb4fb91c
---
M wmf-config/InitialiseSettings.php
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/15236
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5ec6c798c98fc2735afb8ab8880038c4cb4fb91c
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Alex Monk kren...@gmail.com
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove a couple of unused globals, add a missing global or 2 - change (mediawiki...CentralNotice[master])

2012-07-11 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

Change subject: Remove a couple of unused globals, add a missing global or 2
..

Remove a couple of unused globals, add a missing global or 2

Fix some indenting issues

Swap some skin usages to Linker

Change-Id: I571c8eb760854a4bf0ddb48605de498985d40dd4
---
M CentralNotice.db.php
M CentralNoticeBannerLogPager.php
M CentralNoticeCampaignLogPager.php
M CentralNoticePageLogPager.php
M CentralNoticePager.php
M TemplatePager.php
M special/SpecialBannerAllocation.php
M special/SpecialBannerController.php
M special/SpecialBannerLoader.php
M special/SpecialCentralNotice.php
M special/SpecialNoticeTemplate.php
11 files changed, 108 insertions(+), 84 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice 
refs/changes/67/15467/1
--
To view, visit https://gerrit.wikimedia.org/r/15467
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I571c8eb760854a4bf0ddb48605de498985d40dd4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove a couple of unused globals, add a missing global or 2 - change (mediawiki...CentralNotice[master])

2012-07-11 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: Remove a couple of unused globals, add a missing global or 2
..


Remove a couple of unused globals, add a missing global or 2

Fix some indenting issues

Swap some skin usages to Linker

Change-Id: I571c8eb760854a4bf0ddb48605de498985d40dd4
---
M CentralNotice.db.php
M CentralNoticeBannerLogPager.php
M CentralNoticeCampaignLogPager.php
M CentralNoticePageLogPager.php
M CentralNoticePager.php
M TemplatePager.php
M special/SpecialBannerAllocation.php
M special/SpecialBannerController.php
M special/SpecialBannerLoader.php
M special/SpecialCentralNotice.php
M special/SpecialNoticeTemplate.php
11 files changed, 108 insertions(+), 84 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/15467
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I571c8eb760854a4bf0ddb48605de498985d40dd4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org
Gerrit-Reviewer: Kaldari rkald...@wikimedia.org
Gerrit-Reviewer: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] CentralNotice to master to fix fatal - change (mediawiki/core[wmf/1.20wmf7])

2012-07-11 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

Change subject: CentralNotice to master to fix fatal
..

CentralNotice to master to fix fatal

Change-Id: Ic7b9fcfde4b4c03014a909814c09e6bdb836df7a
---
M extensions/CentralNotice
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/98/15498/1
--
To view, visit https://gerrit.wikimedia.org/r/15498
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic7b9fcfde4b4c03014a909814c09e6bdb836df7a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.20wmf7
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Deglobali[sz]ation! - change (mediawiki...CentralNotice[master])

2012-07-11 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

Change subject: Deglobali[sz]ation!
..

Deglobali[sz]ation!

Change-Id: Iab8935e15bb1b27d8ebe091150679440e4bb1357
---
M special/SpecialBannerAllocation.php
M special/SpecialBannerController.php
M special/SpecialBannerListLoader.php
M special/SpecialBannerLoader.php
M special/SpecialCentralNotice.php
M special/SpecialCentralNoticeLogs.php
M special/SpecialHideBanners.php
M special/SpecialNoticeTemplate.php
8 files changed, 207 insertions(+), 214 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice 
refs/changes/06/15506/1
--
To view, visit https://gerrit.wikimedia.org/r/15506
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iab8935e15bb1b27d8ebe091150679440e4bb1357
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] $cluster was not always defined in IS.php - change (operations/mediawiki-config[master])

2012-07-11 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: $cluster was not always defined in IS.php
..


$cluster was not always defined in IS.php

InitialiseSettings.php is required in wmfLoadInitialiseSettings()
function thus the $cluster variable is not properly defined.

Change-Id: I18a9f349e683f6b84bd4409ffb0ab0598b892481
---
M wmf-config/InitialiseSettings.php
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/15508
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I18a9f349e683f6b84bd4409ffb0ab0598b892481
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Hashar has...@free.fr
Gerrit-Reviewer: Hashar has...@free.fr
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add getCanonicalServer to WikiMap - change (mediawiki/core[master])

2012-07-11 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

Change subject: Add getCanonicalServer to WikiMap
..

Add getCanonicalServer to WikiMap

Change-Id: I9473034ced524ea3d0b3ea9e4166b173653f58c4
---
M includes/WikiMap.php
1 file changed, 16 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/09/15509/1
--
To view, visit https://gerrit.wikimedia.org/r/15509
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9473034ced524ea3d0b3ea9e4166b173653f58c4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Die globals, die! - change (mediawiki...Gadgets[master])

2012-07-11 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

Change subject: Die globals, die!
..

Die globals, die!

Change-Id: I43f525d860034e844a8ef7caee589e9dca6d4dbe
---
M SpecialGadgets.php
1 file changed, 29 insertions(+), 24 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Gadgets 
refs/changes/13/15513/1
--
To view, visit https://gerrit.wikimedia.org/r/15513
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I43f525d860034e844a8ef7caee589e9dca6d4dbe
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Gadgets
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove some unused variables - change (mediawiki/core[master])

2012-07-11 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

Change subject: Remove some unused variables
..

Remove some unused variables

Add some comments

Change-Id: I84c050b6baf8ef8d21735c1ba56b7782b3c54855
---
M includes/specials/SpecialListusers.php
1 file changed, 20 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/17/15517/1
--
To view, visit https://gerrit.wikimedia.org/r/15517
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I84c050b6baf8ef8d21735c1ba56b7782b3c54855
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Updated readme with updated url. - change (mediawiki...UniversalLanguageSelector[master])

2012-07-11 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: Updated readme with updated url.
..


Updated readme with updated url.

Change-Id: I098eae824c705840d9e2dc01eb2c1fc16286052c
---
M README
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Reedy: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/15511
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I098eae824c705840d9e2dc01eb2c1fc16286052c
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Alolita alolita.sha...@gmail.com
Gerrit-Reviewer: Alolita alolita.sha...@gmail.com
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: Santhosh santhosh.thottin...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add Canada to Shop Link targets - change (operations/mediawiki-config[master])

2012-07-12 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: Add Canada to Shop Link targets
..


Add Canada to Shop Link targets

Change-Id: I0b935a0a29ed7cefbcce97e706b228ece3254616
---
M wmf-config/CommonSettings.php
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/15519
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0b935a0a29ed7cefbcce97e706b228ece3254616
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Jalexander jalexan...@wikimedia.org
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Move FeaturedFeedsWMF.php from extension directory - change (operations/mediawiki-config[master])

2012-07-12 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: Move FeaturedFeedsWMF.php from extension directory
..


Move FeaturedFeedsWMF.php from extension directory

Change-Id: I592a7b969f28e232255bc7e3528c35f4a9f22642
---
M wmf-config/CommonSettings.php
A wmf-config/FeaturedFeedsWMF.php
2 files changed, 95 insertions(+), 1 deletion(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/14874
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I592a7b969f28e232255bc7e3528c35f4a9f22642
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: MaxSem maxsem.w...@gmail.com
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Bug 38362 - Transclude Special:Listuser - change (mediawiki/core[master])

2012-07-12 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

Change subject: Bug 38362 - Transclude Special:Listuser
..

Bug 38362 - Transclude Special:Listuser

Change-Id: Ia0efbfbd6300db5ad67840667c1cb12ab5e003c3
---
M CREDITS
M RELEASE-NOTES-1.20
M includes/specials/SpecialListusers.php
3 files changed, 15 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/44/15544/1
--
To view, visit https://gerrit.wikimedia.org/r/15544
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia0efbfbd6300db5ad67840667c1cb12ab5e003c3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Api method documentation tweaks - change (mediawiki/core[master])

2012-07-12 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

Change subject: Api method documentation tweaks
..

Api method documentation tweaks

Change-Id: I43398b6016f64accf86921c72a6dac5e71e11c34
---
M includes/api/ApiBase.php
M includes/api/ApiMain.php
M includes/api/ApiPageSet.php
M includes/api/ApiQuery.php
M includes/api/ApiQueryBase.php
5 files changed, 34 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/49/15549/1
--
To view, visit https://gerrit.wikimedia.org/r/15549
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I43398b6016f64accf86921c72a6dac5e71e11c34
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Little point throwing an exception like that to just catch i... - change (mediawiki...Quiz[master])

2012-07-12 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

Change subject: Little point throwing an exception like that to just catch it 
again a few lines down
..

Little point throwing an exception like that to just catch it again a few lines 
down

Change-Id: I668c1cf1564401daeabc12988bd6b60c6d81a5d9
---
M Quiz.class.php
1 file changed, 5 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Quiz 
refs/changes/73/15573/1
--
To view, visit https://gerrit.wikimedia.org/r/15573
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I668c1cf1564401daeabc12988bd6b60c6d81a5d9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Quiz
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove 2 large unused functions - change (mediawiki...Quiz[master])

2012-07-12 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

Change subject: Remove 2 large unused functions
..

Remove 2 large unused functions

Change-Id: Iabb89afc8bc356072f4583ac508dc22747693f2f
---
M Quiz.class.php
1 file changed, 1 insertion(+), 132 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Quiz 
refs/changes/74/15574/1
--
To view, visit https://gerrit.wikimedia.org/r/15574
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iabb89afc8bc356072f4583ac508dc22747693f2f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Quiz
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Resource loader-ify js - change (mediawiki...Quiz[master])

2012-07-12 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: Resource loader-ify js
..


Resource loader-ify js

Some bits of documentation additions

Change-Id: I0c17e8605a9e24b01be0adbeb6415524f55812a0
---
M Quiz.class.php
M Quiz.php
R modules/ext.quiz.js
3 files changed, 32 insertions(+), 20 deletions(-)

Approvals:
  Reedy: Verified
  Nikerabbit: Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/15572
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0c17e8605a9e24b01be0adbeb6415524f55812a0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Quiz
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org
Gerrit-Reviewer: Nikerabbit niklas.laxst...@gmail.com
Gerrit-Reviewer: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Move hard coded CSS lines to css file to be loaded by RL - change (mediawiki...Quiz[master])

2012-07-12 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

Change subject: Move hard coded CSS lines to css file to be loaded by RL
..

Move hard coded CSS lines to css file to be loaded by RL

Change-Id: I7a378841aa93afd19cb9cf8616c41effde5f6c21
---
M Quiz.class.php
M Quiz.php
A modules/ext.quiz.css
3 files changed, 13 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Quiz 
refs/changes/76/15576/1
--
To view, visit https://gerrit.wikimedia.org/r/15576
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7a378841aa93afd19cb9cf8616c41effde5f6c21
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Quiz
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fixup method parameter documentation - change (mediawiki...Quiz[master])

2012-07-12 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

Change subject: Fixup method parameter documentation
..

Fixup method parameter documentation

Change-Id: I47ebe446c6d7ca817204f6de1e5122782a882616
---
M Quiz.class.php
1 file changed, 19 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Quiz 
refs/changes/78/15578/1
--
To view, visit https://gerrit.wikimedia.org/r/15578
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I47ebe446c6d7ca817204f6de1e5122782a882616
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Quiz
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] dbErrorLog can now be forced to UTC - change (mediawiki/core[wmf/1.20wmf7])

2012-07-13 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

Change subject: dbErrorLog can now be forced to UTC
..

dbErrorLog can now be forced to UTC

$wgDBerrorLog is used to log database error. It is using
$wgLocalTimezone to format the date which might not always be wanted in
a multi Timezone cluster of wiki.

wgDBerrorLogInUTC , when true, will override the Wiki timezone to uses
UTC whenever a database error is logged.

Change-Id: I091d6029272b69db0aefdebfc37896d0a8e8770e
---
M RELEASE-NOTES-1.20
M includes/DefaultSettings.php
M includes/GlobalFunctions.php
3 files changed, 20 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/07/15607/1
--
To view, visit https://gerrit.wikimedia.org/r/15607
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I091d6029272b69db0aefdebfc37896d0a8e8770e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.20wmf7
Gerrit-Owner: Reedy re...@wikimedia.org
Gerrit-Reviewer: Hashar has...@free.fr

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] dbErrorLog can now be forced to UTC - change (mediawiki/core[wmf/1.20wmf6])

2012-07-13 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

Change subject: dbErrorLog can now be forced to UTC
..

dbErrorLog can now be forced to UTC

$wgDBerrorLog is used to log database error. It is using
$wgLocalTimezone to format the date which might not always be wanted in
a multi Timezone cluster of wiki.

wgDBerrorLogInUTC , when true, will override the Wiki timezone to uses
UTC whenever a database error is logged.

Change-Id: I091d6029272b69db0aefdebfc37896d0a8e8770e
---
M RELEASE-NOTES-1.20
M includes/DefaultSettings.php
M includes/GlobalFunctions.php
3 files changed, 20 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/08/15608/1
--
To view, visit https://gerrit.wikimedia.org/r/15608
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I091d6029272b69db0aefdebfc37896d0a8e8770e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.20wmf6
Gerrit-Owner: Reedy re...@wikimedia.org
Gerrit-Reviewer: Hashar has...@free.fr

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] dbErrorLog can now be forced to UTC - change (mediawiki/core[wmf/1.20wmf6])

2012-07-13 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: dbErrorLog can now be forced to UTC
..


dbErrorLog can now be forced to UTC

$wgDBerrorLog is used to log database error. It is using
$wgLocalTimezone to format the date which might not always be wanted in
a multi Timezone cluster of wiki.

wgDBerrorLogInUTC , when true, will override the Wiki timezone to uses
UTC whenever a database error is logged.

Change-Id: I091d6029272b69db0aefdebfc37896d0a8e8770e
---
M RELEASE-NOTES-1.20
M includes/DefaultSettings.php
M includes/GlobalFunctions.php
3 files changed, 20 insertions(+), 2 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/15608
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I091d6029272b69db0aefdebfc37896d0a8e8770e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.20wmf6
Gerrit-Owner: Reedy re...@wikimedia.org
Gerrit-Reviewer: Hashar has...@free.fr
Gerrit-Reviewer: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] dbErrorLog can now be forced to UTC - change (mediawiki/core[wmf/1.20wmf7])

2012-07-13 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: dbErrorLog can now be forced to UTC
..


dbErrorLog can now be forced to UTC

$wgDBerrorLog is used to log database error. It is using
$wgLocalTimezone to format the date which might not always be wanted in
a multi Timezone cluster of wiki.

wgDBerrorLogInUTC , when true, will override the Wiki timezone to uses
UTC whenever a database error is logged.

Change-Id: I091d6029272b69db0aefdebfc37896d0a8e8770e
---
M RELEASE-NOTES-1.20
M includes/DefaultSettings.php
M includes/GlobalFunctions.php
3 files changed, 20 insertions(+), 2 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/15607
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I091d6029272b69db0aefdebfc37896d0a8e8770e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.20wmf7
Gerrit-Owner: Reedy re...@wikimedia.org
Gerrit-Reviewer: Hashar has...@free.fr
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix casing of wgDBerrorLogInUtc - change (mediawiki/core[master])

2012-07-13 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

Change subject: Fix casing of wgDBerrorLogInUtc
..

Fix casing of wgDBerrorLogInUtc

Change-Id: I644ea64b1a40160f3468ec35836ee9aa003c03de
---
M includes/GlobalFunctions.php
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/19/15619/1
--
To view, visit https://gerrit.wikimedia.org/r/15619
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I644ea64b1a40160f3468ec35836ee9aa003c03de
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix casing of wgDBerrorLogInUtc - change (mediawiki/core[master])

2012-07-13 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: Fix casing of wgDBerrorLogInUtc
..


Fix casing of wgDBerrorLogInUtc

Change-Id: I644ea64b1a40160f3468ec35836ee9aa003c03de
---
M includes/GlobalFunctions.php
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/15619
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I644ea64b1a40160f3468ec35836ee9aa003c03de
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org
Gerrit-Reviewer: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix casing of wgDBerrorLogInUtc - change (mediawiki/core[wmf/1.20wmf7])

2012-07-13 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

Change subject: Fix casing of wgDBerrorLogInUtc
..

Fix casing of wgDBerrorLogInUtc

Change-Id: I644ea64b1a40160f3468ec35836ee9aa003c03de
---
M includes/GlobalFunctions.php
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/21/15621/1
--
To view, visit https://gerrit.wikimedia.org/r/15621
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I644ea64b1a40160f3468ec35836ee9aa003c03de
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.20wmf7
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix casing of wgDBerrorLogInUtc - change (mediawiki/core[wmf/1.20wmf6])

2012-07-13 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: Fix casing of wgDBerrorLogInUtc
..


Fix casing of wgDBerrorLogInUtc

Change-Id: I644ea64b1a40160f3468ec35836ee9aa003c03de
---
M includes/GlobalFunctions.php
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/15620
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I644ea64b1a40160f3468ec35836ee9aa003c03de
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.20wmf6
Gerrit-Owner: Reedy re...@wikimedia.org
Gerrit-Reviewer: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix casing of wgDBerrorLogInUtc - change (mediawiki/core[wmf/1.20wmf7])

2012-07-13 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: Fix casing of wgDBerrorLogInUtc
..


Fix casing of wgDBerrorLogInUtc

Change-Id: I644ea64b1a40160f3468ec35836ee9aa003c03de
---
M includes/GlobalFunctions.php
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/15621
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I644ea64b1a40160f3468ec35836ee9aa003c03de
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.20wmf7
Gerrit-Owner: Reedy re...@wikimedia.org
Gerrit-Reviewer: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Add keys for Sam Reed and Brion Vibber - change (operations/mediawiki-config[master])

2012-07-13 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: Add keys for Sam Reed and Brion Vibber
..


Add keys for Sam Reed and Brion Vibber

Change-Id: I53235b05f3a98c61560327cdbc72e531c5c99491
---
M docroot/secure/keys.txt
1 file changed, 70 insertions(+), 0 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/15636
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I53235b05f3a98c61560327cdbc72e531c5c99491
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Bug 38369 - Auth_remoteuser: PHP Strict Standards errors - change (mediawiki...Auth_remoteuser[master])

2012-07-13 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

Change subject: Bug 38369 - Auth_remoteuser: PHP Strict Standards errors
..

Bug 38369 - Auth_remoteuser: PHP Strict Standards errors

Patch by Scott Shambarger

Change-Id: Ie031bac1f09f9c2457e61a965b35c4732d12f130
---
M Auth_remoteuser.php
1 file changed, 19 insertions(+), 26 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Auth_remoteuser 
refs/changes/40/15640/1
--
To view, visit https://gerrit.wikimedia.org/r/15640
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie031bac1f09f9c2457e61a965b35c4732d12f130
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Auth_remoteuser
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] $sk is undefined. Swap for Linker:: - change (mediawiki...AbuseFilter[master])

2012-07-13 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

Change subject: $sk is undefined. Swap for Linker::
..

$sk is undefined. Swap for Linker::

Change-Id: I79e19484ffa8ab0d1f3be838a3186e7499b907c1
---
M special/SpecialAbuseLog.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/AbuseFilter 
refs/changes/46/15646/1
--
To view, visit https://gerrit.wikimedia.org/r/15646
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I79e19484ffa8ab0d1f3be838a3186e7499b907c1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/AbuseFilter
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix for: Fatal error: Call to undefined method ApiDelete::g... - change (mediawiki/core[master])

2012-07-13 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

Change subject: Fix for: Fatal error:  Call to undefined method 
ApiDelete::getErrorsArray()
..

Fix for: Fatal error:  Call to undefined method ApiDelete::getErrorsArray()

Fatal error:  Call to undefined method ApiDelete::getErrorsArray() in 
/usr/local/apache/common-local/php-1.20wmf7/includes/api/ApiDelete.php on line 
65

Caused by https://gerrit.wikimedia.org/r/#/c/7572/

Change-Id: Ib86fab94667ed50d172eb7ea3e82c99ecb3e52b0
---
M includes/api/ApiDelete.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/47/15647/1
--
To view, visit https://gerrit.wikimedia.org/r/15647
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib86fab94667ed50d172eb7ea3e82c99ecb3e52b0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix for: Fatal error: Call to undefined method ApiDelete::g... - change (mediawiki/core[wmf/1.20wmf7])

2012-07-13 Thread Reedy (Code Review)

Reedy has uploaded a new change for review.

Change subject: Fix for: Fatal error:  Call to undefined method 
ApiDelete::getErrorsArray()
..

Fix for: Fatal error:  Call to undefined method ApiDelete::getErrorsArray()

Fatal error:  Call to undefined method ApiDelete::getErrorsArray() in 
/usr/local/apache/common-local/php-1.20wmf7/includes/api/ApiDelete.php on line 
65

Caused by https://gerrit.wikimedia.org/r/#/c/7572/

Change-Id: Ib86fab94667ed50d172eb7ea3e82c99ecb3e52b0
---
M includes/api/ApiDelete.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/48/15648/1
--
To view, visit https://gerrit.wikimedia.org/r/15648
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib86fab94667ed50d172eb7ea3e82c99ecb3e52b0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.20wmf7
Gerrit-Owner: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix for: Fatal error: Call to undefined method ApiDelete::g... - change (mediawiki/core[wmf/1.20wmf7])

2012-07-13 Thread Reedy (Code Review)

Reedy has submitted this change and it was merged.

Change subject: Fix for: Fatal error:  Call to undefined method 
ApiDelete::getErrorsArray()
..


Fix for: Fatal error:  Call to undefined method ApiDelete::getErrorsArray()

Fatal error:  Call to undefined method ApiDelete::getErrorsArray() in 
/usr/local/apache/common-local/php-1.20wmf7/includes/api/ApiDelete.php on line 
65

Caused by https://gerrit.wikimedia.org/r/#/c/7572/

Change-Id: Ib86fab94667ed50d172eb7ea3e82c99ecb3e52b0
---
M includes/api/ApiDelete.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Reedy: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/15648
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib86fab94667ed50d172eb7ea3e82c99ecb3e52b0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.20wmf7
Gerrit-Owner: Reedy re...@wikimedia.org
Gerrit-Reviewer: Reedy re...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

< 1 2 3 4 5 6 7 8 9 10 >

201 - 300 of 8199 matches

Mail list logo