[Meego-handset] Dialer Project meeting - Minutes for Tuesday 8/2
#meego-meeting: MeeGo Dialer Project Meeting Meeting started by sabotage at 14:54:56 UTC. Meeting summary available at: http://irclogs.meego.com/meetbot/meego-meeting/2011/meego-meeting.2011-08-02-14.54.html The full logs are available at: http://irclogs.meego.com/meetbot/meego-meeting/2011/meego-meeting.2011-08-02-14.54.log.html Meeting summary --- * General information/business (sabotage, 14:55:11) * The MTF gut work from Steven has been merged (sabotage, 15:00:50) * ACTION: remove libseaside deps from dialer (sabotage, 15:03:02) * ACTION: replace meegobluetooth Qt lib with QtMobility QBluetooth* (sabotage, 15:03:32) * Bug, patch and merge-request status (sabotage, 15:05:42) * Any Other Business (sabotage, 15:11:07) * Sabotage out on Vacation last 1/2 of August (8/16 - 8/30), no meetings (sabotage, 15:11:21) * Dialer Project Meetings are held every Tuesday (unless otherwise noted) on #meego-meeting at 15:00 UTC (sabotage, 15:14:39) * Dialer meeting archives can be found at http://wiki.meego.com/Project/Dialer/Meetings#Archive (sabotage, 15:14:46) * Dialer online discussion happens in real time on IRC at #meego-handset @freenode (sabotage, 15:14:58) Meeting ended at 15:15:09 UTC. Action Items * remove libseaside deps from dialer * replace meegobluetooth Qt lib with QtMobility QBluetooth* Action Items, by person --- * **UNASSIGNED** * remove libseaside deps from dialer * replace meegobluetooth Qt lib with QtMobility QBluetooth* People Present (lines said) --- * sabotage (43) * Stskeeps (9) * MeeGoMeetBot` (2) Generated by `MeetBot`_ 0.1.4 .. _`MeetBot`: http://wiki.debian.org/MeetBot -- Shane... ___ MeeGo-handset mailing list MeeGo-handset@lists.meego.com http://lists.meego.com/listinfo/meego-handset
Re: [Meego-handset] Changes in the MeeGo Bugzilla for Handset User Experience
On Tue, Jul 12, 2011 at 09:08:00AM +, ext-iekku.huttu...@nokia.com wrote: Hi all, There's going to be some changes in the MeeGo Bugzilla Handset User Experience. Thanks for the heads up and letting a broader audience be informed BEFORE the action was taken. It's nice to see the process improving. I'm going to wait 2 workdays to get the feedback before doing the changes, any comments and ideas are welcome. Also, again thanks for the time to react/respond. Bugzilla components, and the coming changes: Dialer: stays as it is Correct, and thanks for noticing libseaside: is in use. Default assignee: ??, QA contact: ?? IIRC, this is still maintained by either Connie or Kaitlin About the current bugs: - All NOT ARM related bugs are going to be directly WONTFIX, cause no official support / maintenance currently for IA. This is the only item I take some issue with. There is know way for you, or anyone else, to know if there is or is not still any device that is IA based still being worked on, or tested against. And, even though there may not appear to be a official support-ed IA device, the nice thing about IA devices are that they are often quite similar to each other, so any current IA bug will most certainly still apply to any future IA device. So, I kindly request that you do not take the above action, or only do so on those components that do end up being identified as unmaintained and unused in N900 CE. Or, mark them as needing review somehow, and add a comment to them as such, triggering those that do still have a maintainer (like dialer) to take action to review them themselves. Regards, -- Shane... ___ MeeGo-handset mailing list MeeGo-handset@lists.meego.com http://lists.meego.com/listinfo/meego-handset
Re: [Meego-handset] [CE] releases during the summer time
On Sat, Jul 02, 2011 at 12:13:29AM +0300, Marko Saukko wrote: Ps. If someone knows how to prioritize zypper repositories so that packages from repo A are installed even when same package is newer in repo B would be nice if you would ping me at IRC (Sage, #meego-arm @ Freenode) so we can make the update functionality even better from the CE point of view. As a general, per-repoi, manual solution: $ sudo zypper mr -p priority repo where, according to man, priority setting is described as follows: -p, --priority positive-integer Set priority of the repository. Priority of 1 is the highest, the higher the number the lower the priority. Default priority is 99. Packages from repositories with higher priority will be preferred even in case there is a higher installable version available in the repository with a lower priority. so, to set repo A as higher than repo B (where the repo files /etc/zypp/repos.d/A.repo and /etc/zypp/repos.d/B.repo exist and use the names name=A and name=B respectively: $ sudo zypper mr -p 80 A Using 80 just as an example, since it's less than the default of 99. All this is best managed by the user, but if you want to change the defaults in the image to suit your needs at install time, just have the .ks file add priority=80 (or whatever value makes sense) to the relevant .repo files in /etc/zypp/repos.d/ This, I'm guessing, is more likely what you want to do, from a CE image team point of view. Regards, -- Shane... ___ MeeGo-handset mailing list MeeGo-handset@lists.meego.com http://lists.meego.com/listinfo/meego-handset
[Meego-handset] Dialer Project meeting - CANCELED for Tuesday 7/5
Just a heads up that the Dialer Project meeting for next week is being canceled as I will be out on holiday Meetings will resume again on 7/12/2011 Regards, -- Shane... ___ MeeGo-handset mailing list MeeGo-handset@lists.meego.com http://lists.meego.com/listinfo/meego-handset
Re: [Meego-handset] Dialer Project meeting - Minutes for Tuesday 6/28
#meego-meeting: MeeGo Dialer Project meeting Meeting started by sabotage at 14:57:45 UTC. Meeting summary available at: http://irclogs.meego.com/meetbot/meego-meeting/2011/meego-meeting.2011-06-28-14.57.html The full logs are available at: http://irclogs.meego.com/meetbot/meego-meeting/2011/meego-meeting.2011-06-28-14.57.log.html Meeting summary --- * General information/business - Action Items status (sabotage, 14:58:01) * discuss l10n durion AOB topic... (sabotage, 15:01:50) * General information/business - MTF removal and Migration to MeeGo UX Components (sabotage, 15:03:16) * General information/business - HFP Merge status (sabotage, 15:05:58) * LINK: https://meego.gitorious.org/meego-handset-ux/meego-handset-dialer/merge_requests/5 (sabotage, 15:07:38) * General information/business - MTF removal and Migration to MeeGo UX Components (sabotage, 15:10:14) * rolandl has been working on making the QML dialer as a standalone application (90%) (sabotage, 15:11:27) * rolandl has started on further removing MTF dependencies on the QML side: replacing MApplication, ... with the meego-qml-launcher way of doing things (10%) (sabotage, 15:12:02) * LINK: https://meego.gitorious.org/meego-handset-ux/rolands-qml-meego-handset-dialer (rolandl, 15:17:41) * ACTION: rolandl will publish the list of identified deltas between MTF and QML versions of dialer at a subpage of http://wiki.meego.com/Project/Dialer (sabotage, 15:18:25) * , rolandl's work will be pushed to his gitorious clone at https://meego.gitorious.org/meego-handset-ux/rolands-qml-meego-handset-dialer (sabotage, 15:19:03) * Bug, patch and merge-request status (sabotage, 15:23:03) * Last (?) HFP MR: https://meego.gitorious.org/meego-handset-ux/meego-handset-dialer/merge_requests/5 (sabotage, 15:23:43) * LINK: Open Dialer bug list: http://tinyurl.com/meego-open-dialer-bugs (sabotage, 15:26:05) * LINK: https://bugs.meego.com/show_bug.cgi?id=16916 (sabotage, 15:26:44) * bug 16916 - No Alert Dialog shown for incoming call in lock screen (sabotage, 15:27:28) * LINK: https://bugs.meego.com/buglist.cgi?query_format=advancedfield0-0-0=flagtypes.namebug_status=NEWbug_status=NEEDINFObug_status=ASSIGNEDbug_status=WAITING%20FOR%20UPSTREAMbug_status=REOPENEDtype0-0-0=anyexactvalue0-0-0=MeeGo_N900CE_Release_Blocker%2B (sabotage, 15:38:57) * LINK: https://bugs.meego.com/buglist.cgi?query_format=advancedfield0-0-0=flagtypes.namebug_status=NEWbug_status=NEEDINFObug_status=ASSIGNEDbug_status=WAITING%20FOR%20UPSTREAMbug_status=REOPENEDtype0-0-0=anyexactvalue0-0-0=MeeGo_N900CE_Release_Blocker%2Bcomponent=Dialer (sabotage, 15:39:47) * Any Other Business - L10N/T9N of dialer and handset (sabotage, 15:49:52) * localization ML is at http://lists.meego.com/listinfo/meego-il10n (sabotage, 15:52:36) Meeting ended at 15:56:34 UTC. Action Items * rolandl will publish the list of identified deltas between MTF and QML versions of dialer at a subpage of http://wiki.meego.com/Project/Dialer Action Items, by person --- * rolandl * rolandl will publish the list of identified deltas between MTF and QML versions of dialer at a subpage of http://wiki.meego.com/Project/Dialer * **UNASSIGNED** * (none) People Present (lines said) --- * sabotage (133) * alterego (35) * rolandl (8) * w00t (2) * MeeGoMeetBot (2) * Stskeeps|holiday (1) * crevetor (1) Generated by `MeetBot`_ 0.1.4 .. _`MeetBot`: http://wiki.debian.org/MeetBot -- Shane... ___ MeeGo-handset mailing list MeeGo-handset@lists.meego.com http://lists.meego.com/listinfo/meego-handset
[Meego-handset] Dialer Project meeting - Minutes for Tuesday 6/21
Sorry for the tardyness of these minutes. Seems I forgot not only to send out the meeting agenda, but also the minutes... so, better late than never... Shane... #meego-meeting: MeeGo Dialer Project Meeting Meeting started by sabotage at 14:57:13 UTC. Meeting summary available at: http://irclogs.meego.com/meetbot/meego-meeting/2011/meego-meeting.2011-06-21-14.57.html The full logs are available at http://irclogs.meego.com/meetbot/meego-meeting/2011/meego-meeting.2011-06-21-14.57.log.html Meeting summary --- * General status updates (sabotage, 15:00:32) * LINK: https://bugs.meego.com/show_bug.cgi?id=19586 (sabotage, 15:03:36) * QML version still needs Multiparty call handling, DTMF tone handling and Audio output control buttons (sabotage, 15:06:55) * LINK: http://swipe.nokia.com/features/ their dialer (crevetor, 15:10:33) * Bugs, MR's and patches (sabotage, 15:12:18) * Jimmy has a large MR for HFP merge that he plans to send me today or tomorrow (sabotage, 15:17:00) * Any Other Business (sabotage, 15:22:13) * LINK: https://meego.com/community/device-program (Stskeeps, 15:23:27) Meeting ended at 15:28:07 UTC. Action Items Action Items, by person --- * **UNASSIGNED** * (none) People Present (lines said) --- * sabotage (84) * alterego (37) * crevetor (6) * Stskeeps (5) * MeeGoMeetBot (2) * aruravi (1) Generated by `MeetBot`_ 0.1.4 .. _`MeetBot`: http://wiki.debian.org/MeetBot -- Shane... ___ MeeGo-handset mailing list MeeGo-handset@lists.meego.com http://lists.meego.com/listinfo/meego-handset
[Meego-handset] Dialer Project meeting - Agenda for Tuesday 6/7
Agenda for the Dialer Project meeting - Tuesday, June 7th, 2011 * General information/business (Shane) - Action Items status: * sabotage to update the Dialer TODO file - IN PROGRESS * someone try to see if we can pull it inline into wiki via git url - NOT STARTED * alterego and sabotage to do a feature/capability comparison between existing MTF and emerging QML dialers - NOT STARTED * sabotage add Clean up and re-work current debug output model in dialer to the TODO list - NOT STARTED * alterego to add test dir to dialer that will hold CLI tools for setting various settings in the abscence of settings UI - NOT STARTED - libofono-qt migration - Bluetooth library migration - HFP merge * Bug, patch and merge-request status (Shane) * Any Other Business -- Shane... ___ MeeGo-handset mailing list MeeGo-handset@lists.meego.com http://lists.meego.com/listinfo/meego-handset
Re: [Meego-handset] Dialer Project meeting - Minutes for Tuesday 5/31
#meego-meeting: MeeGo Dialer Project meeting Meeting started by sabotage at 15:03:09 UTC. Online minutes: http://irclogs.meego.com/meetbot/meego-meeting/2011/meego-meeting.2011-05-31-15.03.html Full IRC meeting log: http://irclogs.meego.com/meetbot/meego-meeting/2011/meego-meeting.2011-05-31-15.03.log.html Meeting summary --- * General information/business - MeeGo Conference wrap-up/summary (sabotage, 15:03:36) * General information/business - TODO list cleanup (sabotage, 15:10:56) * ACTION: sabotage to update the Dialer TODO file (sabotage, 15:11:50) * AGREED: We'll keep TODO list in git (sabotage, 15:19:38) * ACTION: someone try to see if we can pull it inline into wiki via git url (sabotage, 15:20:05) * ACTION: everyone needs to do better about updating the TODO file when submitting patches or merge requests (sabotage, 15:20:41) * Bug, patch and merge-request status - How to disposition MTF vs. QML bugs (sabotage, 15:23:25) * ACTION: alterego and sabotage to do a feature/capability comparison between existing MTF and emerging QML dialers (sabotage, 15:28:27) * LINK: http://sf2011.meego.com/sites/all/files/slides/state_of_the_meego_dialer-sf2011.pdf (sabotage, 15:34:32) * AGREED: no change to current process of marking N900 DE bugs with [DE] in summary (sabotage, 15:37:14) * AGREED: sabotage will begin marking MTF bugs as WONTFIX as appropriate (sabotage, 15:37:39) * Bug, patch and merge-request status - Specific bug discussions (sabotage, 15:38:09) * ACTION: add Clean up and re-work current debug output model in dialer to the TODO list (sabotage, 15:44:36) * Any Other Business (sabotage, 15:49:01) * ACTION: alterego to add test dir to dialer that will hold CLI tools for setting various settings in the abscence of settings UI (sabotage, 16:01:01) Meeting ended at 16:05:46 UTC. Action Items * sabotage to update the Dialer TODO file * someone try to see if we can pull it inline into wiki via git url * everyone needs to do better about updating the TODO file when submitting patches or merge requests * alterego and sabotage to do a feature/capability comparison between existing MTF and emerging QML dialers * add Clean up and re-work current debug output model in dialer to the TODO list * alterego to add test dir to dialer that will hold CLI tools for setting various settings in the abscence of settings UI Action Items, by person --- * alterego * alterego and sabotage to do a feature/capability comparison between existing MTF and emerging QML dialers * alterego to add test dir to dialer that will hold CLI tools for setting various settings in the abscence of settings UI * sabotage * sabotage to update the Dialer TODO file * alterego and sabotage to do a feature/capability comparison between existing MTF and emerging QML dialers * **UNASSIGNED** * someone try to see if we can pull it inline into wiki via git url * everyone needs to do better about updating the TODO file when submitting patches or merge requests * add Clean up and re-work current debug output model in dialer to the TODO list People Present (lines said) --- * sabotage (146) * alterego (105) * aruravi_ (16) * apaila__ (13) * vnayani_ (11) * w00t (6) * lcuk (3) * MeeGoMeetBot (2) Generated by `MeetBot`_ 0.1.4 .. _`MeetBot`: http://wiki.debian.org/MeetBot ___ MeeGo-handset mailing list MeeGo-handset@lists.meego.com http://lists.meego.com/listinfo/meego-handset
[Meego-handset] ANNOUNCING: Dialer 'qml' branch has been merged into master
On Thu, 19 May 2011 14:28:25 -0700 Shane Bryan shane.br...@linux.intel.com wrote: A lot of good progress has been happening on the qml branch recently and it's drawing close to feature equivalence with the current, MTF, version on master. Since the bulk of the work is now happening on the QML version of the UI, and MTF is on the path towards removal from MeeGo for 1.3, I think it is now time to make the QML version the official one going forward. To this end, I will be merging qml into master by EOD today (20110519, PST). Done. I've laid and pushed a new version tag, version-0.2.3, to mark this release as well. I will delete the qml branch in the next day or two, baring any catastrophes I may have introduced in the merge process. All QML related merge-requests or patches should now be based off master. I will no longer accept any based off the previous 'qml' branch. So, again, be sure to rebase and/or reclone your versions. Regards, Shane... ___ MeeGo-handset mailing list MeeGo-handset@lists.meego.com http://lists.meego.com/listinfo/meego-handset
[Meego-handset] Dialer Project meeting - Agenda for Tuesday 5/17
Agenda for the Dialer Project meeting - Tuesday, May 17th, 2011 Shorter meeting today... * General information/business (Shane) - QML Dialer status (Tom) * Bug, patch and merge-request status (Shane) Bugs: - We'll review what folks want to review. Send me hot ones you want to discuss, or have them ready when we get to this topic * Any Other Business Shane... ___ MeeGo-handset mailing list MeeGo-handset@lists.meego.com http://lists.meego.com/listinfo/meego-handset
Re: [Meego-handset] [PATCH] Fixed: BMC#17327, Unable to end the hold conference call if still exist an active call in Dialer app Signed-off-by: Arun Ravindran arun...@gmail.com
On Mon, 16 May 2011 14:03:37 +0300 Arun Ravindran arun...@gmail.com wrote: The root cause of this issue was an improper button update. where DialerApplication::handleCallsChanged() calls, m_mainWindow-activateWindow(), but button update happens only if the dialer was not visible previously by the function void MainWindow::onDisplayEntered(). With this patch the update buttons is called from DialerApplication::handleCallsChanged() if the application is not inprestarted state, so that the keypad buttons are updated properly. Thanks. Applied and merged into qml branch as well. Shane... ___ MeeGo-handset mailing list MeeGo-handset@lists.meego.com http://lists.meego.com/listinfo/meego-handset
Re: [Meego-handset] Dialer Project meeting - Agenda for Tuesday 5/17
#meego-meeting: MeeGo Dialer Project meeting Meeting started by sabotage at 15:02:17 UTC. Online minutes: http://irclogs.meego.com/meetbot/meego-meeting/2011/meego-meeting.2011-05-17-15.02.html Full IRC meeting log: http://irclogs.meego.com/meetbot/meego-meeting/2011/meego-meeting.2011-05-17-15.02.log.html Meeting summary --- * General information/business - QML Dialer status (sabotage, 15:03:45) * LINK: http://repo.pub.meego.com/home:/tswindell:/branches:/Project:/DE:/Trunk:/Testing/standard/ (alterego, 15:04:07) * LINK: https://meego.gitorious.org/meego-handset-ux/meego-handset-dialer/commits/qml (sabotage, 15:10:23) * Bug, patch and merge-request status (sabotage, 15:17:35) * LINK: https://bugs.meego.com/show_bug.cgi?id=9978 (msugano, 15:19:06) * LINK: https://bugs.meego.com/show_bug.cgi?id=9282 (sabotage, 15:23:24) * LINK: https://bugs.meego.com/show_bug.cgi?id=17403 (aruravi, 15:24:55) * LINK: https://bugs.meego.com/show_bug.cgi?id=17403 (sabotage, 15:25:33) * LINK: https://bugs.meego.com/show_bug.cgi?id=17403#c5 (msugano, 15:26:00) * LINK: https://bugs.meego.com/buglist.cgi?quicksearch=3241%2C+8326%2C+9282%2C+10107%2C+15121%2C+17403 (sabotage, 15:32:45) * LINK: https://bugs.meego.com/show_bug.cgi?id=3241 (msugano, 15:33:18) * LINK: https://bugs.meego.com/show_bug.cgi?id=10107 (sabotage, 15:38:20) * LINK: https://bugs.meego.com/show_bug.cgi?id=15121 (sabotage, 15:38:56) * LINK: https://bugs.meego.com/show_bug.cgi?id=17403 (sabotage, 15:39:42) * Any Other Business (sabotage, 15:42:37) * Informal meetup at Hyatt lobby bar Saturday evening before the Conference (sabotage, 15:47:40) * ACTION: jukkaeklund to look up sabotage for SIM during his session if needed (sabotage, 15:48:10) * ACTION: sabotage to get his session slides written and published o_O (sabotage, 15:50:05) * No IRC meeting next week due to SF2011 conference! (sabotage, 15:51:26) Meeting ended at 15:52:36 UTC. Action Items * jukkaeklund to look up sabotage for SIM during his session if needed * sabotage to get his session slides written and published o_O Action Items, by person --- * jukkaeklund * jukkaeklund to look up sabotage for SIM during his session if needed * sabotage * jukkaeklund to look up sabotage for SIM during his session if needed * sabotage to get his session slides written and published o_O * **UNASSIGNED** * (none) People Present (lines said) --- * sabotage (105) * alterego (71) * aruravi (34) * jukkaeklund (24) * msugano (24) * crevetor (18) * iekku (4) * lcuk (2) * MeeGoMeetBot (2) Generated by `MeetBot`_ 0.1.4 .. _`MeetBot`: http://wiki.debian.org/MeetBot ___ MeeGo-handset mailing list MeeGo-handset@lists.meego.com http://lists.meego.com/listinfo/meego-handset
Re: [Meego-handset] Dialer Project meeting - Agenda for Tuesday 5/10
#meego-meeting: MeeGo Dialer Project meeting Meeting started by sabotage at 14:59:31 UTC. Online minutes: http://irclogs.meego.com/meetbot/meego-meeting/2011/meego-meeting.2011-05-10-14.59.html Full IRC meeting log: http://irclogs.meego.com/meetbot/meego-meeting/2011/meego-meeting.2011-05-10-14.59.log.html Meeting summary --- * General information/business - QML Dialer status (sabotage, 14:59:43) * dialer will have a compile/run time option for using qml or mtf ui until all existing features are working in qml (sabotage, 15:02:37) * LINK: http://wiki.meego.com/ARM/N900/Status (jukkaeklund, 15:06:47) * LINK: DE image status http://wiki.meego.com/ARM/N900/Status (sabotage, 15:07:29) * AGREED: wrapp dialer xdg autostart in a script to ensure that if it dies, it gets restarted (sabotage, 15:13:08) * Which dialer in N900 DE image for MeeGo SF2011? (sabotage, 15:21:54) * AGREED: : alterego will continue to use his OBS project can as packaging portal for qml version until we merge into master (sabotage, 15:30:49) * Bug, patch and merge-request status (sabotage, 15:33:03) * LINK: https://bugs.meego.com/show_bug.cgi?id=17327 (msugano, 15:34:30) * ACTION: : sabotage to fix dialer l10n to drop engineering english (sabotage, 15:47:54) * ACTION: : msugano to check what can be done for the green background fix (low priority, though) (msugano, 15:48:58) * ACTION: sabotage to look into call button update bug newly introduced (sabotage, 15:50:04) * Any Other Business (sabotage, 15:52:29) * ACTION: sabotage will send email to meego-handset to summarize the arch issues and get discussion started (sabotage, 15:53:34) * HELP: (sabotage, 15:55:02) * ACTION: sabotage to create wrapper script to keep dialer running from xdg autostart .desktop file (sabotage, 15:56:51) Meeting ended at 15:57:49 UTC. Action Items * : sabotage to fix dialer l10n to drop engineering english * : msugano to check what can be done for the green background fix (low priority, though) * sabotage to look into call button update bug newly introduced * sabotage will send email to meego-handset to summarize the arch issues and get discussion started * sabotage to create wrapper script to keep dialer running from xdg autostart .desktop file Action Items, by person --- * msugano * : msugano to check what can be done for the green background fix (low priority, though) * sabotage * : sabotage to fix dialer l10n to drop engineering english * sabotage to look into call button update bug newly introduced * sabotage will send email to meego-handset to summarize the arch issues and get discussion started * sabotage to create wrapper script to keep dialer running from xdg autostart .desktop file * **UNASSIGNED** * (none) People Present (lines said) --- * sabotage (150) * alterego (78) * jukkaeklund (58) * msugano (26) * aruravi (11) * Sage (5) * lcuk (2) * MeeGoMeetBot (2) * crevetor (2) * kallam (1) Generated by `MeetBot`_ 0.1.4 .. _`MeetBot`: http://wiki.debian.org/MeetBot ___ MeeGo-handset mailing list MeeGo-handset@lists.meego.com http://lists.meego.com/listinfo/meego-handset
[Meego-handset] Dialer Project meeting - Agenda for Tuesday 5/10
Agenda for the Dialer Project meeting - Tuesday, May 10th, 2011 * General information/business (Shane) - QML Dialer status (Shane/Tom) * Which dialer in N900 DE image for MeeGo SF2011? (DE Team rep.) * Bug, patch and merge-request status (Shane) Bugs: - We'll review what folks want to review. Send me hot ones you want to discuss, or have them ready when we get to this topic * Any Other Business -- Shane... ___ MeeGo-handset mailing list MeeGo-handset@lists.meego.com http://lists.meego.com/listinfo/meego-handset
Re: [Meego-handset] [PATCH] Fixed:BMC#16916, No alert dialog for incoming calls Signed-off-by: Arun Ravindran ext-arun.1.ravind...@nokia.com
On Thu, 5 May 2011 12:46:24 +0300 ext-arun.1.ravind...@nokia.com wrote: From: Arun Ravindran ext-arun.1.ravind...@nokia.com With this patch,UI is released from prestart, if not alrteady to handle incoming calls. The call manager is modified to emit the calls changed signal before the incoming calls, so that the ui can be released from prestart. Applied and pushed (some minor commit message edits) to master. Thanks for the patch, Shane... ___ MeeGo-handset mailing list MeeGo-handset@lists.meego.com http://lists.meego.com/listinfo/meego-handset
[Meego-handset] Dialer Project meeting - minutes for Tuesday 5/3
#meego-meeting: MeeGo Dialer Project meeting Meeting started by sabotage at 15:00:54 UTC. Online minutes: http://irclogs.meego.com/meetbot/meego-meeting/2011/meego-meeting.2011-05-03-15.00.html Full IRC meeting log: http://irclogs.meego.com/meetbot/meego-meeting/2011/meego-meeting.2011-05-03-15.00.log.html Meeting summary --- * General information/business (sabotage, 15:01:37) * applifed vs. xdg-autostart? (sabotage, 15:16:04) * LINK: http://www.freedesktop.org/wiki/Software/systemd (alterego, 15:18:56) * AGREED: dialer to move away from applifed for 1.3+ (sabotage, 15:20:00) * ACTION: sabotage to tag dialer git with 1.2 branch (sabotage, 15:20:47) * QML Dialer architecture discussion (sabotage, 15:21:31) * ACTION: sabotage will send email to meego-handset to summarize the arch issues and get discussion started (sabotage, 15:36:18) * bugs... (sabotage, 15:37:41) * LINK: https://bugs.meego.com/show_bug.cgi?id=16916 (msugano, 15:38:58) * LINK: https://bugs.meego.com/show_bug.cgi?id=16814 (alterego, 15:46:50) * AGREED: sabotage to fix .desktop file as per BMC# 16814 (sabotage, 15:48:42) * Any Other Business (sabotage, 15:53:37) Meeting ended at 15:59:52 UTC. Action Items * sabotage to tag dialer git with 1.2 branch * sabotage will send email to meego-handset to summarize the arch issues and get discussion started Action Items, by person --- * sabotage * sabotage to tag dialer git with 1.2 branch * sabotage will send email to meego-handset to summarize the arch issues and get discussion started * **UNASSIGNED** * (none) People Present (lines said) --- * sabotage (155) * alterego (90) * Stskeeps (34) * aruravi_home (28) * msugano (12) * lcuk (7) * akiniemi_ (3) * MeeGoMeetBot (2) * lbt (1) * w00t (1) * andre__ (1) * tripzero (1) * crevetor (1) Generated by `MeetBot`_ 0.1.4 .. _`MeetBot`: http://wiki.debian.org/MeetBot -- Shane... ___ MeeGo-handset mailing list MeeGo-handset@lists.meego.com http://lists.meego.com/listinfo/meego-handset
[Meego-handset] [ANNOUNCE] MeeGo 1.2 branch created for Dialer
As agreed in the MeeGo Dialer Project meeting[1], I have branched the git tree for MeeGo 1.2. I also tagged the tree for 1.2, but that is now redundant. The MeeGo 1.2 branch is based on the same commit as the latest released and tagged version (0.2.1), which is also in the MeeGo core OBS branch for 1.2 as well. Dialer patches targeted for the MeeGo 1.2 release must now be based off the MeeGo-1.2 branch. Changes intended to go only to Trunk (MeeGo 1.3+) should be based off master, or other branches as appropriate. For those wondering about the QML port, especially in light of Tom's announcement earlier today, the QML porting work will occur, initialy, on it's own branch (to be created still) until we can work out some fundamental architectural changes. Once we have these worked out, it will merge into master. Shane... [1]http://irclogs.meego.com/meetbot/meego-meeting/2011/meego-meeting.2011-05-03-15.00.html ___ MeeGo-handset mailing list MeeGo-handset@lists.meego.com http://lists.meego.com/listinfo/meego-handset
[Meego-handset] [RFC] Removal of Dialer headless branch...
Now that the topic/headless branch of dialer is now fully merged into master, I would like to purge this from the git refs. My reasonings are: 1) It's obsolete 2) Remove any confusion about what is in master 3) Basic house cleaning on the git repo If I hear no reasonable objections (and I can't think of any good ones off the top of my head) by next Tuesdays MeeGo Dialer Project meeting, I will go ahead and delete the topic/headless branch Regards, Shane... ___ MeeGo-handset mailing list MeeGo-handset@lists.meego.com http://lists.meego.com/listinfo/meego-handset
Re: [Meego-handset] [PATCH] Patch:Fix for unable to see alert dialog for MT call Signed-off-by: Arun Ravindran ext-arun.1.ravind...@nokia.com
On Mon, 2 May 2011 13:37:15 +0300
ext-arun.1.ravind...@nokia.com wrote:
From: Arun Ravindran ext-arun.1.ravind...@nokia.com
This patch emits a signal from callmanager, when a call is added to
prepare the UI. The signal is handled in dialer application to
release the ui from prestart state. ---
src/callmanager.cpp |3 +++
src/callmanager.h |1 +
src/dialerapplication.cpp | 11 +++
src/dialerapplication.h |1 +
4 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/src/callmanager.cpp b/src/callmanager.cpp
index 8ff4c8c..37431ec 100644
--- a/src/callmanager.cpp
+++ b/src/callmanager.cpp
@@ -600,6 +600,9 @@ void CallManager::callAdded(const QDBusObjectPath
in0,const QVariantMap in1) Q_UNUSED(in1)
TRACE
+//prepare ui to handle the added call
+emit prepareViews();
I really don't want to start re-introducing UI logic back into non-UI
classes. So even though this signal doesn't make CallManager handle
UIs, it does make it implicitly UI aware.
We already have the callsChanged signal, that is only emitted based on
acquiring the incoming call resource (proceedIncomingCall()). If we
don't get the permission from libresource to continue with the incoming
call, we should not be emitting any signals about incoming calls.
diff --git a/src/dialerapplication.cpp b/src/dialerapplication.cpp
index bfe2f7e..c789eb3 100644
--- a/src/dialerapplication.cpp
+++ b/src/dialerapplication.cpp
@@ -116,6 +116,13 @@ void DialerApplication::connectAll()
SLOT(messagesWaitingChanged()));
}
+void DialerApplication::releasePreStart()
+{
+TRACE
+if(isPrestarted())
+setPrestarted(false);
+}
+
We already have this defined in master[1]... why are you adding another?
bool DialerApplication::isConnected()
{
TRACE
@@ -260,6 +267,10 @@ void DialerApplication::callManagerConnected()
qDebug() QString(Connect resource unavailable);
connect(m_callManager, SIGNAL(callResourceLost(const QString)),
m_mainWindow, SLOT(handleResourceUnavailability(const
QString)));
+
+qDebug() QString(Connect ensure UI prepared);
+connect(m_callManager, SIGNAL(prepareViews()),this,
SLOT(releasePreStart()));
+
I think we'd be better off handling this in
DialerApplication::handleCallsChanged(), checking for incoming call
being defined in the CallManager.
Shane...
[1]http://mxr.meego.com/meego.gitorious.org/source/meego-handset-dialer/src/dialerapplication.cpp#60
___
MeeGo-handset mailing list
MeeGo-handset@lists.meego.com
http://lists.meego.com/listinfo/meego-handset
[Meego-handset] Dialer Project meeting - Agenda for Tuesday 5/3
Agenda for the Dialer Project meeting - Tuesday, May 3rd, 2011 * General information/business (Shane) - applifed vs. xdg-autostart? - QML Dialer architecture discussion: * meego-qml-launcher vs. libmeegoqmllauncher vs. QApplication w/ QDeclarativeView(s)? * Bug, patch and merge-request status (Shane) Bugs: - We'll review what folks want to review. Send me hot ones you want to discuss, or have them ready when we get to this topic * Any Other Business -- Shane... ___ MeeGo-handset mailing list MeeGo-handset@lists.meego.com http://lists.meego.com/listinfo/meego-handset
Re: [Meego-handset] [PATCH] Changed: Usage of QSettings. Signed-off-by: Arun Ravindran ext-arun.1.ravind...@nokia.com
On Mon, 18 Apr 2011 18:35:27 +0300 ext-arun.1.ravind...@nokia.com wrote: From: Arun Ravindran ext-arun.1.ravind...@nokia.com This patch fixes the following issue: 1) A fresh device, with no call history. 2) Start dialer and receive and incoming call 3) Complete the call by disconnecting it. 4) See the call history (everything is fine) 5) close dialer and restart it again. 6) See call history, Shows the unix epoch or a time close to that. This is because of wrong usage of QSettings. When the dialer restarted the values of QSetting @ /home/meego/.config/com.meego.conf is [CallHistory] CallHistory\1302858505\LineID=+358403445507 CallHistory\1302858505\Type=1 CallHistory\1302858505\Start=1302858505 CallHistory\1302858505\End=1302858516 This is actually not what I wanted/expected to be happening. What I expected was more like the following: [CallHistory] 1302858505\LineID=+358403445507 1302858505\Type=1 1302858505\Start=1302858505 1302858505\End=1302858516 Where CallHistory is not repeated every time. I did some slight reworking of the patch to apply to the new headless master (some changes in historytablemodel.cpp prevented it from applying) and see that, while the entries now appear consistent, now they *all* prefix with CallHistory\. This is redundant since we already define a top level group. I really don't think we should be using the childGroups() at all. After a closer look, it seems the real reason we have any issue (see BMC# 2043[1]) at all here is that when I originally created this hack, I failed to call endGroup() when the the QSettings cache is initially empty. Adding a simple cache-endGroup() before the return when (events.size() == 0) seems to have solved the problem. Shane... [1]https://bugs.meego.com/show_bug.cgi?id=2043 ___ MeeGo-handset mailing list MeeGo-handset@lists.meego.com http://lists.meego.com/listinfo/meego-handset
Re: [Meego-handset] Dialer Project meeting - minutes for Tuesday 4/19
On Tue, 19 Apr 2011 09:00:53 -0700 Shane Bryan shane.br...@linux.intel.com wrote: Action Items Additional meeting follow ups: * sabotage to get libseaside maintainers to look into BMC# 16197 This was marked as a duplication of BMC# 15947 and is still being root caused. Looks like some API changes in qtcontacts-tracker that are still being investigated. At one point last week we had it working with pushing the async version of libseaside, but a subsequent version change/mis-match between tracker, qtcontacts-tracker and libsparql has reintroduced a similar problem for *ANY* call to QtMobility::QContactManager::selfContactId() when tracker is the active engine. ___ MeeGo-handset mailing list MeeGo-handset@lists.meego.com http://lists.meego.com/listinfo/meego-handset
Re: [Meego-handset] [PATCH] Changed: Usage of QSettings. Signed-off-by: Arun Ravindran ext-arun.1.ravind...@nokia.com
On Mon, 18 Apr 2011 18:35:27 +0300
ext-arun.1.ravind...@nokia.com wrote:
From: Arun Ravindran ext-arun.1.ravind...@nokia.com
This patch fixes the following issue:
1) A fresh device, with no call history.
2) Start dialer and receive and incoming call
3) Complete the call by disconnecting it.
4) See the call history (everything is fine)
5) close dialer and restart it again.
6) See call history, Shows the unix epoch or a time close to that.
Generally, the patch is ok, but I have a few concerns in appendRows and
getHistoryFinished, as noted below.
Also one variable spelling error.
Shane...
This is because of wrong usage of QSettings.
When the dialer restarted the values of QSetting
@ /home/meego/.config/com.meego.conf is
[CallHistory]
CallHistory\1302858505\LineID=+358403445507
CallHistory\1302858505\Type=1
CallHistory\1302858505\Start=1302858505
CallHistory\1302858505\End=1302858516
The code in HistoryTableModel::insertRows() will fail to read such a
call history.
1) beginGroup() @ [CallHistory]
2) childGroups() @ CallHistory.
3) max = events.size(); is 1 so gets in to the loop.
4) all values returned are 0.
The appendRows called from the getHistoryFinished also needed change
as it works on the sub group and not the main group.
---
src/historytablemodel.cpp | 68
+++-
src/managerproxy.cpp |8 + 2 files changed, 50
insertions(+), 26 deletions(-)
diff --git a/src/historytablemodel.cpp b/src/historytablemodel.cpp
index 25bb122..efd7140 100644
--- a/src/historytablemodel.cpp
+++ b/src/historytablemodel.cpp
@@ -113,43 +113,50 @@ bool HistoryTableModel::insertRows(int row, int
count, QSettings *cache = historyProxy-cache();
cache-beginGroup(CallHistory);
-QStringList events = cache-childGroups();
+QStringList groups = cache-childGroups();
-if (events.size() == 0) {
+if (groups.size() == 0) {
qWarning() QString([HistoryTableModel] Empty call
history log!); return true;
}
+foreach (QString group, groups) {
-// Special case to just load all data from cache
-if (max 0)
-max = events.size();
+cache-beginGroup(group);
-beginInsertRows(parent, row, row + max - 1);
-foreach (QString key, events) {
+QStringList events = cache-childGroups();
-// Stop before end of cache if we hit count
-if (i max) break;
+// Special case to just load all data from cache
+if (max 0)
+max = events.size();
-cache-beginGroup(key);
+beginInsertRows(parent, row, row + max - 1);
+foreach (QString key, events) {
-uint start = cache-value(Start).toUInt(); // Call start
time
-uint end = cache-value(End).toUInt(); // Call end time
+// Stop before end of cache if we hit count
+if (i max) break;
-// add the column data to a new row
-newRow.clear();
-newRow cache-value(LineID).toString(); // Phone Number
-newRow cache-value(Type).toString(); // Call
direction type
-newRow toOfonoString(start); // Call start
time
-newRow toOfonoString(end);// Call end time
+cache-beginGroup(key);
+
+uint start = cache-value(Start).toUInt(); // Call
start time
+uint end = cache-value(End).toUInt(); // Call end
time +
+// add the column data to a new row
+newRow.clear();
+newRow cache-value(LineID).toString(); // Phone
Number
+newRow cache-value(Type).toString(); // Call
direction type
+newRow toOfonoString(start); // Call
start time
+newRow toOfonoString(end);// Call end
time
#ifdef WANT_DEBUG
-qDebug() QString([HistoryTableModel] Appending row: %1)
+qDebug() QString([HistoryTableModel] Appending row:
%1) .arg(newRow.join(\t));
#endif
-// add the row data to the vector
-m_data.append(newRow);
-cache-endGroup();
-i++;
+// add the row data to the vector
+m_data.append(newRow);
+cache-endGroup();
+i++;
+}
+ cache-endGroup();
}
cache-endGroup();
endInsertRows();
@@ -159,7 +166,7 @@ bool HistoryTableModel::insertRows(int row, int
count, void HistoryTableModel::appendRows(QStringList keys)
{
TRACE
-
+bool subgroup = false;
int max = 0;
int i = 0;
QStringList newRow = QStringList();
@@ -167,12 +174,19 @@ void HistoryTableModel::appendRows(QStringList
keys) QSettings *cache = mp-history()-cache();
cache-beginGroup(CallHistory);
-QStringList events = cache-childGroups();
+QStringList grpups = cache-childGroups();
I think you mean groups here, not grpups ;)
-if
[Meego-handset] Dialer Project meeting - minutes for Tuesday 4/19
#meego-meeting: MeeGo Dialer Project meeting Meeting started by sabotage at 15:00:25 UTC. Online minutes: http://trac.tspre.org/meetbot/meego-meeting/2011/meego-meeting.2011-04-19-15.00.html Full IRC meeting log: http://trac.tspre.org/meetbot/meego-meeting/2011/meego-meeting.2011-04-19-15.00.log.html Meeting summary --- * General information/business - Action Items review from last meeting (sabotage, 15:00:53) * ACTION: sabotage discuss on meego-handset ML nominations for additional chairs to the Dialer Project meetings (sabotage, 15:02:42) * LINK: http://wiki.meego.com/Project/Dialer/Headless_Dialer (sabotage, 15:09:18) * Bug, patch and merge-request status (sabotage, 15:11:32) * ACTION: sabotage to get libseaside maintainers to look into BMC# 16197 (sabotage, 15:15:51) * New features discussion - Headless (sabotage, 15:22:39) * ACTION: crevetor to look at merging master into topic/headless since his changes are the main area of overlap with headless (sabotage, 15:34:24) * QML UI (sabotage, 15:40:36) * ACTION: alterego to add thoughts to Dialer QML port wiki page (sabotage, 15:44:07) * AGREED: sabotage and alterego agree that we will leverage meego-ux-components for dialer QML work (sabotage, 15:44:45) * ACTION: sabotage to start thread on QML architecture changes for dialer (sabotage, 15:46:23) * Any other business (sabotage, 15:53:19) * LINK: http://trac.tspre.org/meetbot/meego-meeting/2011/meego-meeting.2011-04-19-11.00.html (msugano_, 15:53:38) * USSD is on the horizon for integration into dialer (sabotage, 15:54:23) Meeting ended at 15:59:48 UTC. Action Items * sabotage discuss on meego-handset ML nominations for additional chairs to the Dialer Project meetings * sabotage to get libseaside maintainers to look into BMC# 16197 * crevetor to look at merging master into topic/headless since his changes are the main area of overlap with headless * alterego to add thoughts to Dialer QML port wiki page * sabotage to start thread on QML architecture changes for dialer Action Items, by person --- * alterego * alterego to add thoughts to Dialer QML port wiki page * crevetor * crevetor to look at merging master into topic/headless since his changes are the main area of overlap with headless * sabotage * sabotage discuss on meego-handset ML nominations for additional chairs to the Dialer Project meetings * sabotage to get libseaside maintainers to look into BMC# 16197 * sabotage to start thread on QML architecture changes for dialer * **UNASSIGNED** * (none) People Present (lines said) --- * sabotage (164) * alterego (94) * msugano_ (24) * aruravi (18) * crevetor (16) * w00t (2) * MeeGoMeetBot (2) * akiniemi_ (2) * sirpa (1) * apaila (1) Generated by `MeetBot`_ 0.1.4 .. _`MeetBot`: http://wiki.debian.org/MeetBot ___ MeeGo-handset mailing list MeeGo-handset@lists.meego.com http://lists.meego.com/listinfo/meego-handset
Re: [Meego-handset] Dialer Project meeting - minutes for Tuesday 4/19
On Tue, 19 Apr 2011 09:00:53 -0700 Shane Bryan shane.br...@linux.intel.com wrote: * Bug, patch and merge-request status (sabotage, 15:11:32) * ACTION: sabotage to get libseaside maintainers to look into BMC# 16197 (sabotage, 15:15:51) Just a followup on this. Looks like BMC# 16197[1] was a duplicate of BMC# 15947[2], which has a fix on it's way into the build (SR# 16375[3])[4]. Here's the relevant comment from the bug assignee[5]: Yes, this is the everything locks if qct and qsparql are not at the right versions bug. We had fun time with it in harmattan, now it's back in meego :) It'll disappear (hopefully) when I update qct, which I hope to do this afternoon. [1]https://bugs.meego.com/show_bug.cgi?id=16197 [2]https://bugs.meego.com/show_bug.cgi?id=15947 [3]http://build.meego.com/request/show/16506 [4]http://lists.meego.com/pipermail/meego-commits/2011-April/021250.html [5]https://bugs.meego.com/show_bug.cgi?id=15947#c4 ___ MeeGo-handset mailing list MeeGo-handset@lists.meego.com http://lists.meego.com/listinfo/meego-handset
[Meego-handset] Dialer Project meeting minutes for Tuesday 4/12
#meego-meeting: MeeGo Dialer Project Meeting started by sabotage at 15:00:31 UTC. Online minutes: http://trac.tspre.org/meetbot/meego-meeting/2011/meego-meeting.2011-04-12-15.00.html Full IRC meeting log: http://trac.tspre.org/meetbot/meego-meeting/2011/meego-meeting.2011-04-12-15.00.log.html Meeting summary --- * VoiceSMS meetings and Dialer meetings (sabotage, 15:02:45) * msugano can manage coordination of VoiceSMS DE team activities with Dialer team (sabotage, 15:06:38) * LINK: http://lists.meego.com/pipermail/meego-handset/2011-April/000321.html comment from msugano (on the 2 projects) (msugano, 15:10:10) * AGREED: Dialer and DE VoiceSMS teams will combine meetings (sabotage, 15:13:31) * ACTION: discuss on meego-handset ML nominations for additional chairs to the Dialer Project meetings (sabotage, 15:15:12) * Sirpa has been working on a QML PIN query UI (akiniemi_, 15:17:26) * AGREED: discuss PIN query UI in this meeting forum (sabotage, 15:20:13) * Wireframes (sabotage, 15:20:33) * ACTION: sabotage to ping Intel again for details on wireframe availability (sabotage, 15:22:14) * bugs, merge-requests and patch status (sabotage, 15:26:14) * QML porting (sabotage, 15:29:56) * ACTION: add thoughts to Dialer QML port wiki page (sabotage, 15:40:22) * LINK: http://wiki.meego.com/Project/Dialer/QMLMigration (sabotage, 15:41:23) * Headless dialer (sabotage, 15:41:48) * ACTION: aruravi to start a wiki page to detail plans and status of Dialer Headless branch (sabotage, 15:48:31) * Any Other Business (sabotage, 15:49:25) * Next meeting is Tuesday, April 19th at 14:00 UTC (sabotage, 15:52:52) * LINK: http://summit.meegonetwork.fi/live (timoph, 15:54:34) * LINK: http://summit.meegonetwork.fi/live (sabotage, 15:54:54) * Sabotage submitted a session proposal for SF2011 conference (sabotage, 15:56:46) * LINK: http://sf2011.meego.com/program/sessions/mr-bell-meet-mr-goldberg-state-meego-dialer (sabotage, 15:56:53) Meeting ended at 15:59:41 UTC. Action Items * discuss on meego-handset ML nominations for additional chairs to the Dialer Project meetings * sabotage to ping Intel again for details on wireframe availability * add thoughts to Dialer QML port wiki page * aruravi to start a wiki page to detail plans and status of Dialer Headless branch Action Items, by person --- * aruravi * aruravi to start a wiki page to detail plans and status of Dialer Headless branch * sabotage * sabotage to ping Intel again for details on wireframe availability * **UNASSIGNED** * discuss on meego-handset ML nominations for additional chairs to the Dialer Project meetings * add thoughts to Dialer QML port wiki page People Present (lines said) --- * sabotage (152) * alterego (51) * msugano (38) * aruravi (15) * crevetor (14) * akiniemi_ (14) * essi (8) * timoph (4) * Stskeeps (3) * w00t (2) * MeeGoMeetBot (2) * apaila (1) Generated by `MeetBot`_ 0.1.4 .. _`MeetBot`: http://wiki.debian.org/MeetBot ___ MeeGo-handset mailing list MeeGo-handset@lists.meego.com http://lists.meego.com/listinfo/meego-handset
Re: [Meego-handset] [Patch] Fixed: BMC# 8559 - Non-emergency call (Was: Dialer: Emergency Call Support Patches Try 1)
On Tue, 5 Apr 2011 11:38:29 +0300 Arun Ravindran ext-arun.1.ravind...@nokia.com wrote: Hi Shane, This fixes the behavior where the user is able to make normal call even if there is no SIM. As you know the emergency call support is non existent in oFono, at least we filter the call attempt here. Arun, OK, I've re-worked your patch for BMC#8559, making changes per my previous comments. If you approve of my revisions, I'll apply this to master. I am fine with your modifications, please push this to master. One observation I have though is that this is really quite un-testable (at least AFAICS) on the master branch because the only way right now to put the modem into flight mode is to offline it, but this will cause the CallManager instance to become invalid since oFono will remove the VoiceCallManager interface in this mode. The VoiceCallManager interface is created pre_sim, and remains as long as the modem is powered on. Hmm... that does not seem to be what I actually see happening... I'll need to take a closer look then. When I run the offline-modem script from the ofono test suite, all further attempts to work with the modem are failing, including onlining it. I don't have an invalid SIM or one with FDN/BDN enabled either. Do you have other suggestions on how to test this on the master branch? Testing the dialer when the modem is offline is the best way. We are only interested in the user getting a note about what type of calls he can make, because making emergency call is not yet a functionality in oFono. Understood, just hoping you had found a better or different way of testing. Shane... ___ MeeGo-handset mailing list MeeGo-handset@lists.meego.com http://lists.meego.com/listinfo/meego-handset
[Meego-handset] Dialer Project meeting minutes for Tuesday 4/5
== #meego-meeting: Dialer Project meeting == Meeting started by sabotage at 15:00:05 UTC. Online minutes: http://trac.tspre.org/meetbot/meego-meeting/2011/meego-meeting.2011-04-05-15.00.html Full IRC meeting log: http://trac.tspre.org/meetbot/meego-meeting/2011/meego-meeting.2011-04-05-15.00.log.html Meeting summary --- * Meeting info at http://wiki.meego.com/Project/Dialer/Meetings (sabotage, 15:00:46) * sabotage is author maintainer of meego-handset-dialer (sabotage, 15:01:58) * crevetor is Antoine Reversat, helping hand, wants to work on the QML version of the dialer (sabotage, 15:02:06) * introductions (sabotage, 15:02:38) * More about who's who in the project is at http://wiki.meego.com/Project/Dialer/Meetings#Preface (sabotage, 15:04:17) * aruravi part of N900 hardware adaptation and DE Voice/SMS team (sabotage, 15:04:26) * jukkaeklund, N900 DE product manager and very interested in the topic :) (sabotage, 15:05:17) * essi is the Team lead for VoiceSMS project on the N900 Developer Edition (sabotage, 15:06:43) * zolkis: I am architect for RTCom in Harmattan, including a dialer too, so naturally interested on the MeeGo dialer (sabotage, 15:07:33) * kallam has provided a bunck of Resource Policy Manager additions to Dialer (sabotage, 15:08:40) * kallam: Kalle Lampila member of N900 hardware adatation team (sabotage, 15:08:56) * Two Meetings (Dialer and VoiceSMS) (sabotage, 15:09:17) * GCF == Global Certification Forum (sabotage, 15:18:53) * LINK: http://www.globalcertificationforum.org/WebSite/public/home_public.aspx (sabotage, 15:18:56) * ACTION: sabotage to discuss project goals and meeting combination with essi (sabotage, 15:19:26) * AGREED: (sabotage, 15:19:34) * Wire frames (sabotage, 15:21:12) * Dialer wireframes to be released any day now (sabotage, 15:30:50) * ACTION: sabotage to find out more detail and make it available ASAP (sabotage, 15:31:12) * bugs and features (sabotage, 15:32:20) * LINK: https://bugs.meego.com/buglist.cgi?query_format=advancedfield0-0-0=flagtypes.nametype0-0-0=equalsvalue0-0-0=MeeGo_N900DE_Release_Blocker%2Bcomponent=Dialerproduct=Handset%20User%20Experienceclassification=MeeGo%20Platform (sabotage, 15:34:05) * Dialer history is not changing right now until the tracker vs. EDS issues have settled out (sabotage, 15:42:46) * Bug owner volunteers (sabotage, 15:46:19) * LINK: Open dialer bugs https://bugs.meego.com/buglist.cgi?cmdtype=runnamednamedcmd=Open%20Dialer%20Bugs (sabotage, 15:48:09) * LINK: Open dialer bugs http://wiki.meego.com/Project/Dialer#Bugs (sabotage, 15:49:38) * LINK: Open dialer bugs alternate link (sabotage, 15:50:28) * LINK: https://bugs.meego.com/buglist.cgi?query_format=advancedbug_status=UNCONFIRMEDbug_status=NEWbug_status=NEEDINFObug_status=ASSIGNEDbug_status=WAITING%20FOR%20UPSTREAMbug_status=REOPENEDcolumnlist=bug_severity%2Cpriority%2Cassigned_to%2Ccomponent%2Cbug_status%2Cresolution%2Cshort_desccomponent=Dialerclassification=MeeGo%20Platformknown_name=Open%20Dialer%20Bugsquery_based_on=Open%20Diale (sabotage, 15:50:30) * LINK:(sabotage, 15:50:42) * LINK: https://bugs.meego.com/buglist.cgi?query_format=advancedbug_status=UNCONFIRMEDbug_status=NEWbug_status=NEEDINFObug_status=ASSIGNEDbug_status=WAITING%20FOR%20UPSTREAMbug_status=REOPENEDcolumnlist=bug_severity%2Cpriority%2Cassigned_to%2Ccomponent%2Cbug_status%2Cresolution%2Cshort_desccomponent=Dialerclassification=MeeGo%20Platformknown_name=Open%20Dialer%20Bugsquery_based_on=Open%20Diale (sabotage, 15:50:44) * ACTION: anyone who wants to own a bug, please set the assigned to to yourself (sabotage, 15:53:14) * Headless Dialer (sabotage, 15:53:54) * assuming highlander and aruravi agree that it's working, and I can test it successfully, I want to move headless branch to master ASAP (sabotage, 15:56:35) * QML dialer (sabotage, 15:57:09) * ACTION: alterego please provide URL to your QML dialer source (sabotage, 16:00:16) * LINK: http://gitorious.org/qml-meego-dialer (alterego, 16:00:31) * sabotage set up a Wiki page to start tracking this http://wiki.meego.com/Project/Dialer/QMLMigration (sabotage, 16:00:51) * LINK: http://wiki.meego.com/Project/Dialer/QMLMigration (sabotage, 16:00:54) Meeting ended at 16:01:12 UTC. Action Items * sabotage to discuss project goals and meeting combination with essi * sabotage to find out more details [wireframe release] and make it available ASAP * anyone who wants to own a bug, please set the assigned to to yourself * alterego please provide URL to your QML dialer source Action Items, by person --- * alterego * alterego please provide URL to your QML dialer source * sabotage * sabotage to discuss project goals and
Re: [Meego-handset] [PATCH] Fixed: BNC#14618 Not support end whole conference call by pressing end button one time Signed-off-by: Arun Ravindran ext-arun.1.ravind...@nokia.com
On Tue, 5 Apr 2011 10:16:44 +0300 Arun Ravindran ext-arun.1.ravind...@nokia.com wrote: Hi Shane, We can do this one of two ways: 1) I apply these as is (with the only caveat being to please make the commit message more concise and to the point) I saw your patch, and it looks better. The key merge key handling is more robust now, please apply this as is. Done, pushed to master. Shane... ___ MeeGo-handset mailing list MeeGo-handset@lists.meego.com http://lists.meego.com/listinfo/meego-handset
Re: [Meego-handset] [PATCH] Fixed: BNC#14618 Not support end whole conference call by pressing end button one time Signed-off-by: Arun Ravindran ext-arun.1.ravind...@nokia.com
On Mon, 4 Apr 2011 11:47:49 +0300
Arun Ravindran ext-arun.1.ravind...@nokia.com wrote:
Hi Shane,
On Mon, 28 Mar 2011 14:34:42 +0300
ext-arun.1.ravind...@nokia.com wrote:
Just a note that I have been reviewing this, but found a logic
error in existing code this touches, trying to sort out the right
solution. Hope to have it done early next week.
Could you share some info on this issue?. Will the patch i mailed
need changes after this is fixed?
Sorry, it was late on Friday and I didn't have time to do justice to an
proper explanation.
The crux of the issue was that I needed to re-think (and do a
little re-work) how we kept track of the Merge button state and when
we can and can not perform a merge.
I am attaching (yes, breaking my own rule...) two patch sets.
The first should be your original one, with only a few modifications to
the commit message. The second patch set is my changes on top of yours.
We can do this one of two ways:
1) I apply these as is (with the only caveat being to please make the
commit message more concise and to the point)
2) You resubmit the patch, taking into account the changes I made to
yours in my add on patch. Principally, I want to be sure you capture
the renaming of all instances of [Mm]ultiParty* to [Mm]ultiparty* and
the change from bool based multipartyCalls() to int returning
multipartyCallCount(), as described in my commit message.
Regards,
Shane...
From 06e6d0b1723a5b990e79c309f4ba341fac256f8c Mon Sep 17 00:00:00 2001
From: Shane Bryan shane.br...@linux.intel.com
Date: Mon, 4 Apr 2011 13:37:47 -0700
Subject: [PATCH 2/2] Changed: Namespace and code cleanups to complete fix for BMC# 14618
- Renamed all instances of [Mm]ultiParty* to [Mm]ultiparty*
- Convert bool multipartyCalls() to int multipartyCallCount() since we
need to compare the number of participants to total number of calls under
certain conditions
- Removed unnecessary disconnect() calls when deleting objects
- Removed unused CallManager::multipartyCallsAsStrings() method
- Reworked Merge button state and handling
- Some minor code clean ups
Signed-off-by: Shane Bryan shane.br...@linux.intel.com
---
src/callitem.cpp |6 +++---
src/callitem.h |4 ++--
src/callmanager.cpp | 46 +-
src/callmanager.h|9 +++--
src/callproxy.cpp|2 +-
src/callproxy.h |2 +-
src/dialerkeypad.cpp | 42 +-
7 files changed, 48 insertions(+), 63 deletions(-)
diff --git a/src/callitem.cpp b/src/callitem.cpp
index ff056dd..b975345 100644
--- a/src/callitem.cpp
+++ b/src/callitem.cpp
@@ -80,7 +80,7 @@ void CallItem::init()
model()-setCall(call);
connect(call,SIGNAL(stateChanged()),this,SLOT(callStateChanged()));
connect(call,SIGNAL(dataChanged()),this,SLOT(callDataChanged()));
-connect(call,SIGNAL(multiPartyChanged()),this,SLOT(callMultiPartyChanged()));
+connect(call,SIGNAL(multipartyChanged()),this,SLOT(callMultipartyChanged()));
} else
qCritical(Invalid CallProxy instance!);
} else
@@ -339,8 +339,8 @@ bool CallItem::multiparty()
return (isValid())?model()-multiparty():false;
}
-void CallItem::callMultiPartyChanged()
+void CallItem::callMultipartyChanged()
{
TRACE
-emit multiPartyChanged();
+emit multipartyChanged();
}
diff --git a/src/callitem.h b/src/callitem.h
index e0b79c9..f52576b 100644
--- a/src/callitem.h
+++ b/src/callitem.h
@@ -68,14 +68,14 @@ Q_SIGNALS:
void clicked();
void stateChanged();
void dataChanged();
-void multiPartyChanged();
+void multipartyChanged();
private Q_SLOTS:
void callStateChanged();
void callDataChanged();
void callDisconnected(const QString reason);
void ringtoneStatusChanged(QMediaPlayer::MediaStatus status);
-void callMultiPartyChanged();
+void callMultipartyChanged();
private:
QVariant itemChange(GraphicsItemChange change, const QVariant val);
diff --git a/src/callmanager.cpp b/src/callmanager.cpp
index ac8e4ab..b73c3f6 100644
--- a/src/callmanager.cpp
+++ b/src/callmanager.cpp
@@ -88,22 +88,16 @@ QListQString CallManager::callsAsStrings() const
return m_calls;
}
-bool CallManager::multipartyCalls() const
+int CallManager::multipartyCallCount() const
{
TRACE
-int call_count =0;
+int call_count = 0;
foreach (CallItem *c, m_callItems) {
-if(c-multiparty())
+if(c-multiparty()) {
call_count++;
}
-qDebug()Call Count: call_count;
-return call_count=2?true:false;
-}
-
-QListQString CallManager::multipartyCallsAsStrings() const
-{
-TRACE
-return m_multipartyCalls;
+}
+return call_count;
}
CallItem *CallManager::activeCall() const
@@ -412,11 +406,8 @@ void CallManager::updateCallItems()
// If ofono call list is empty (no calls), empty our CallItem list too
[Meego-handset] [Dialer] Topic/headless branch synced with master
Just an FYI to those using/watching the headless branch in dialer, I've merged master into this branch to keep it up to date with changes/fixes occuring on master. Please be sure to pull again to ensure you're working on the latest and greatest. Regards, Shane... ___ MeeGo-handset mailing list MeeGo-handset@lists.meego.com http://lists.meego.com/listinfo/meego-handset
[Meego-handset] [Patch] Fixed: BMC# 8559 - Non-emergency call (Was: Dialer: Emergency Call Support Patches Try 1)
On Wed, 23 Mar 2011 08:47:38 +0200
Arun Ravindran ext-arun.1.ravind...@nokia.com wrote:
Hi Shane,
On Tue, 15 Mar 2011 14:37:15 +0200
Arun Ravindranext-arun.1.ravind...@nokia.com wrote:
Hi Shane/Michael,
We had some time back this discussion while working on BMC#8559.
Not sure how this relates to bug 8559 Normal phone call can be
started from UI even without SIM card?
Did you mean bug 14320 Unable to make emergency call whether SIM
card inserted or not?
This fixes the behavior where the user is able to make normal call
even if there is no SIM.
As you know the emergency call support is non existent in oFono, at
least we filter the call attempt here.
Arun,
OK, I've re-worked your patch for BMC#8559, making changes per my
previous comments.
If you approve of my revisions, I'll apply this to master.
One observation I have though is that this is really quite un-testable
(at least AFAICS) on the master branch because the only way right now
to put the modem into flight mode is to offline it, but this will
cause the CallManager instance to become invalid since oFono will
remove the VoiceCallManager interface in this mode.
I don't have an invalid SIM or one with FDN/BDN enabled either.
Do you have other suggestions on how to test this on the master branch?
One solution might be to make it part of the headless branch for now.
Thoughts or comments?
Shane...
From fb8a96b97af049dc891d63b794efd61faa7d4185 Mon Sep 17 00:00:00 2001
From: Arun Ravindran ext-arun.1.ravind...@nokia.com
Date: Mon, 4 Apr 2011 16:33:58 -0700
Subject: [PATCH] Fixed: BMC# 8559 - Non-emergency call can be made without
SIM card
- Implimented missing online modem property
- Check if modem is both Powered and Online before attempting to dial,
if not, then requested number must be in the list of allowed
EmergencyNumbers from oFono
- Exposed new showErrorDialog() method that allows message to be set
- Added notification message when non-emergency call is requested and
current state prohibits it.
Signed-off-by: Shane Bryan shane.br...@linux.intel.com
---
src/callmanager.cpp | 20 +++-
src/callmanager.h |1 +
src/dialerapplication.cpp |6 ++
src/dialerapplication.h |1 +
src/dialerpage.cpp| 13 -
src/dialerpage.h |1 +
src/modemproxy.cpp| 15 +++
src/modemproxy.h |6 ++
8 files changed, 61 insertions(+), 2 deletions(-)
diff --git a/src/callmanager.cpp b/src/callmanager.cpp
index 0a92068..1006d3e 100644
--- a/src/callmanager.cpp
+++ b/src/callmanager.cpp
@@ -174,6 +174,24 @@ void CallManager::dial(const PeopleItem *person)
void CallManager::dial(const QString number)
{
TRACE
+ModemProxy* p = ManagerProxy::instance()-modem();
+
+// Nothing to do if the modem is not powered up
+if(!p-powered()) {
+emit callsChanged();
+return;
+}
+
+// If not online (flight mode?), check if the requested number is
+// one of the allowed EmergencyNumbers, in which case, continue.
+// Otherwise, notify that only Emergency calls are permitted.
+if(!p-online()) {
+if(p-powered() !m_emergencyNumbers.contains(number)) {
+emit callsChanged();
+emit onlyEmergencyCalls();
+return;
+}
+}
ResourceProxy *resource = ManagerProxy::instance()-resource();
@@ -823,7 +841,7 @@ void CallManager::propertyChanged(const QString in0, const
QDBusVariant in1)
calls = qdbus_castQListQDBusObjectPath (in1.variant());
setMultipartyCalls(calls);
} else if (in0 == EmergencyNumbers) {
-qDebug() QString(TODO: Handle EmergencyNumber...);
+m_emergencyNumbers = qdbus_castQStringList(in1.variant());
} else
qDebug() QString(Unexpected property changed...);
}
diff --git a/src/callmanager.h b/src/callmanager.h
index 86ee1f6..11f3301 100644
--- a/src/callmanager.h
+++ b/src/callmanager.h
@@ -92,6 +92,7 @@ Q_SIGNALS:
void callResourceLost(const QString);
void connected();
void disconnected();
+void onlyEmergencyCalls();
private Q_SLOTS:
void updateCallItems();
diff --git a/src/dialerapplication.cpp b/src/dialerapplication.cpp
index da44fff..e781e28 100644
--- a/src/dialerapplication.cpp
+++ b/src/dialerapplication.cpp
@@ -264,6 +264,12 @@ void DialerApplication::messagesWaitingChanged()
vmail-publish();
}
+int DialerApplication::showErrorDialog(const QString msg)
+{
+setError(msg);
+return showErrorDialog();
+}
+
int DialerApplication::showErrorDialog()
{
TRACE
diff --git a/src/dialerapplication.h b/src/dialerapplication.h
index 02bde70..6dfe627 100644
--- a/src/dialerapplication.h
+++ b/src/dialerapplication.h
@@ -39,6 +39,7 @@ public:
bool isConnected();
QString lastError();
int showErrorDialog();
+int showErrorDialog(const QString msg);
static DialerApplication *instance
Re: [Meego-handset] [PATCH] Fixed: BMC#14948 The system time is displayed before the call is actived in caller info bar Signed-off-by: Arun Ravindran ext-arun.1.ravind...@nokia.com
On Tue, 29 Mar 2011 16:26:21 +0300 ext-arun.1.ravind...@nokia.com wrote: From: Arun Ravindran ext-arun.1.ravind...@nokia.com The m_updateTimer, updates the call duration read from the Callproxy to the callitemview. When the call is dialing, or alerting and if the timer is elapsed it reads the starttime property (which is NULL), and gets the elapsed value from it, even if it is not valid, which results in wrong time string (which is not the actual duration of the call) updated to the callitem. Fixed by checking the validity of the m_startTime, before returning a duration and also checking it before updating the duration test in Arun, First, thanks for this patch... as we discussed on IRC, it is really just part of a larger fix to overall elapsed time calculations. I spent the day looking into this and ended up doing a bunch of changes, including a portion of this patch, though it needed to be modified due to my additional fixes. So, I believe the entire problem (including the elapsed time computations and more robust and centralized time/string conversion throughout) is now resolved with commit d7e1749c0afb18 [1]. Regards, Shane... [1]https://meego.gitorious.org/meego-handset-ux/meego-handset-dialer/commit/d7e1749c0afb18 ___ MeeGo-handset mailing list MeeGo-handset@lists.meego.com http://lists.meego.com/listinfo/meego-handset
Re: [Meego-handset] [dialer] New branch pushed for headless work
On Tue, 22 Mar 2011 17:04:04 +0200 Arun Ravindran ext-arun.1.ravind...@nokia.com wrote: Hi Shane, Michael and Arun, others who care... I have pushed Michaels patchset to a new public branch called topic/headless, and am requesting that you guys coordinate your respective work towards the eventual merge into master on this branch. For others that have been waiting (alterego for one) this is where you can start basing future new features, espcially UI related changes, as this branch will be the most likely place what Views will begin to be teased apart from the models and controller. Depending on how drastic or dynamic any new UI work turns out to be, I *may* start a new topic branch for UI changes, stay tuned. Regards, The latest code is using applifed, and not launcher (applauncherd). Any reasons? Hard to know which one is the right one since they are both running on meego images and the MTF docs refer to applifed as the control mechanism for pre-start apps. Can you please explain the difference, or point to documentation that describes them both and under what conditions we would want to use one over the other? IIRC, older sample configs for applifed had a call entry for starting the Nokia call manager app, so I figured that was the Right Thing (TM) to do ;) I took the branch, but had to make a few changes to make make it work in N900. 1) the dialer.desktop file changes as described in the README.txt are not working. I had to comment X-Osso-Service=com.meego.dialer, to make it work from the application launcher (desk/home screen) Micheal, ideas on this? I thought you showed it was working, but maybe I didn't get all the patches merged? 2) /etc/prestart/nokia.conf needed the following to start the dialer automatically. application name=dialer service=com.meego.dialer priority=5 / Yes, this was known, but since applifed does not read additional config files and is hard coded to read the nokia.conf file, we can't really add our own. Likewise, it would be bad form to modify this file as part of a post-install script. So do you have suggestions on solving it? Ideally we should file a bug with applifed to make this config dir based or at least able to do something like #include /etc/prestart/services.d/*.conf. That is if we continue to use applifed. 3) With pre-started dialer, i could never receive incoming call, as no alert dialog is shown. I am still investigating to see what is the issue. Michael, any comments on this one too? Anyway, all of this is why it's still a branch ;) Shane.. ___ MeeGo-handset mailing list MeeGo-handset@lists.meego.com http://lists.meego.com/listinfo/meego-handset
[Meego-handset] [dialer] New branch pushed for headless work
Michael and Arun, others who care... I have pushed Michaels patchset to a new public branch called topic/headless, and am requesting that you guys coordinate your respective work towards the eventual merge into master on this branch. For others that have been waiting (alterego for one) this is where you can start basing future new features, espcially UI related changes, as this branch will be the most likely place what Views will begin to be teased apart from the models and controller. Depending on how drastic or dynamic any new UI work turns out to be, I *may* start a new topic branch for UI changes, stay tuned. Regards, Shane... (aka sabotage) ___ MeeGo-handset mailing list MeeGo-handset@lists.meego.com http://lists.meego.com/listinfo/meego-handset
