D1336: remove: print message for each file in verbose mode only while using `-A`

[mitrandir (Mateusz Jakub Kwapich)]

mitrandir added a comment.


  @durin42: I think it should be as good as possible BC-wise. What do you think?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1336

To: pavanpc, #hg-reviewers, lothiraldan, yuja
Cc: yuja, durin42, lothiraldan, mitrandir, mharbison72, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

D1336: remove: print message for each file in verbose mode only while using `-A`

[mitrandir (Mateusz Jakub Kwapich)]

mitrandir added a comment.


  I think that the cases mentioned by you are right :) In case of directory I'd 
prefer so suppress warns. What do you think @yuja ?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1336

To: pavanpc, #hg-reviewers, lothiraldan, yuja
Cc: yuja, durin42, lothiraldan, mitrandir, mharbison72, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

D1336: remove: print message for each file in verbose mode only while using `-A`

[mitrandir (Mateusz Jakub Kwapich)]

mitrandir added a comment.


  @durin42: I'd say that listing *all the files in the repo* when you run `hg 
rm -A` should be considered a bug. This can't possibly be the intended 
behavior. Also: running `hg rm -A` without a `file` argument is not even 
covered by any testcase.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1336

To: pavanpc, #hg-reviewers, lothiraldan
Cc: durin42, lothiraldan, mitrandir, mharbison72, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

D1336: HG: hg rm -A option prints the message of every file in the repo

[mitrandir (Mateusz Jakub Kwapich)]

mitrandir added a comment.


  @mharbison72: the problem is that `hg rm -A` prints a line for every file in 
the repo even if you didn't touch anything. With a clean working directory in a 
repo with 10k files, 10k lines will be printed. The lines look like:
  
not removing : file still exists

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1336

To: pavanpc, #hg-reviewers
Cc: mitrandir, mharbison72, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

D1000: contrib: add check-code rule banning use of readlink

[mitrandir (Mateusz Jakub Kwapich)]

mitrandir added a comment.


  Wow, it's https://phab.mercurial-scm.org/D1000 :D
  partysnake 


REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1000

To: durin42, #hg-reviewers, quark, ryanmce
Cc: mitrandir, ryanmce, quark, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: D122: phabricator: add --amend option to phabsend

[mitrandir (Mateusz Jakub Kwapich)]

mitrandir accepted this revision.
mitrandir added inline comments.

INLINE COMMENTS

> phabricator.py:413
> +drev = [d for d in drevs if int(d[r'id']) == drevid][0]
> +newdesc = getdescfromdrev(drev)
> +# Make sure commit message contain "Differential Revision"

I think it would be better to use differential.getcommitmessage for this. For 
example "reviewed by" field is a really nice thing to have in the commit 
message.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D122

EMAIL PREFERENCES
  https://phab.mercurial-scm.org/settings/panel/emailpreferences/

To: quark, #hg-reviewers, mitrandir
Cc: mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel