[Mesa-dev] [Bug 109204] [regression, bisected] retroarch's crt-royale shader crash radv
https://bugs.freedesktop.org/show_bug.cgi?id=109204 Bas Nieuwenhuizen changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #15 from Bas Nieuwenhuizen --- https://gitlab.freedesktop.org/mesa/mesa/commit/70ed049cc6a682fba084cf57e06728fa5934881b -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 109204] [regression, bisected] retroarch's crt-royale shader crash radv
https://bugs.freedesktop.org/show_bug.cgi?id=109204 --- Comment #14 from Brandon Wright --- (In reply to oschowa from comment #13) > With this patch applied it works correctly again, thanks! Also confirmed here. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 109204] [regression, bisected] retroarch's crt-royale shader crash radv
https://bugs.freedesktop.org/show_bug.cgi?id=109204 --- Comment #13 from osch...@web.de --- (In reply to Bas Nieuwenhuizen from comment #12) > https://gitlab.freedesktop.org/mesa/mesa/merge_requests/67 > > fixes the crash parsing the fragment shader for me. With this patch applied it works correctly again, thanks! -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 109204] [regression, bisected] retroarch's crt-royale shader crash radv
https://bugs.freedesktop.org/show_bug.cgi?id=109204 --- Comment #12 from Bas Nieuwenhuizen --- https://gitlab.freedesktop.org/mesa/mesa/merge_requests/67 fixes the crash parsing the fragment shader for me. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 109204] [regression, bisected] retroarch's crt-royale shader crash radv
https://bugs.freedesktop.org/show_bug.cgi?id=109204 --- Comment #11 from Bas Nieuwenhuizen --- I think the issue is that a matrix being passed to a function is not handled correctly in vtn_ssa_value_add_to_call_params . I'll continue debugging later. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 109204] [regression, bisected] retroarch's crt-royale shader crash radv
https://bugs.freedesktop.org/show_bug.cgi?id=109204 --- Comment #10 from Bas Nieuwenhuizen --- Thanks, was able to reproduce with src/compiler/spirv2nir on the fragment shader. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 109204] [regression, bisected] retroarch's crt-royale shader crash radv
https://bugs.freedesktop.org/show_bug.cgi?id=109204 --- Comment #9 from Brandon Wright --- I added the full generated GLSL for the vertex and fragment shaders and the SPV produced. The glsl is in the form it's passed to the glslang compiler, and it compiles with the command-line compiler. I believe it's the vertex shader that's causing the crash, but since it occurs on pipeline creation I don't really know. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 109204] [regression, bisected] retroarch's crt-royale shader crash radv
https://bugs.freedesktop.org/show_bug.cgi?id=109204 --- Comment #8 from Brandon Wright --- Created attachment 142945 --> https://bugs.freedesktop.org/attachment.cgi?id=142945=edit Vertex shader SPV -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 109204] [regression, bisected] retroarch's crt-royale shader crash radv
https://bugs.freedesktop.org/show_bug.cgi?id=109204 --- Comment #7 from Brandon Wright --- Created attachment 142944 --> https://bugs.freedesktop.org/attachment.cgi?id=142944=edit Vertex shader GLSL -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 109204] [regression, bisected] retroarch's crt-royale shader crash radv
https://bugs.freedesktop.org/show_bug.cgi?id=109204 --- Comment #5 from Brandon Wright --- Created attachment 142942 --> https://bugs.freedesktop.org/attachment.cgi?id=142942=edit Fragment shader GLSL -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 109204] [regression, bisected] retroarch's crt-royale shader crash radv
https://bugs.freedesktop.org/show_bug.cgi?id=109204 --- Comment #6 from Brandon Wright --- Created attachment 142943 --> https://bugs.freedesktop.org/attachment.cgi?id=142943=edit Fragment shader SPV -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 109204] [regression, bisected] retroarch's crt-royale shader crash radv
https://bugs.freedesktop.org/show_bug.cgi?id=109204 --- Comment #4 from osch...@web.de --- Created attachment 142941 --> https://bugs.freedesktop.org/attachment.cgi?id=142941=edit crt-royale-geometry-aa-last-pass.spirv It seems to be indeed the shader mentioned in #2 which causes the crash. I believe i managed to get a dump of the spirv via RADV_DEBUG=spirv. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 109204] [regression, bisected] retroarch's crt-royale shader crash radv
https://bugs.freedesktop.org/show_bug.cgi?id=109204 Caio Marcelo de Oliveira Filho changed: What|Removed |Added CC||caio.olive...@intel.com -- You are receiving this mail because: You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 109204] [regression, bisected] retroarch's crt-royale shader crash radv
https://bugs.freedesktop.org/show_bug.cgi?id=109204 --- Comment #3 from Bas Nieuwenhuizen --- It would be appreciated if someone could get me the SPIR-V for a failing shader, instead of me having to figure out how to get the retroarch build system to spit one out myself. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 109204] [regression, bisected] retroarch's crt-royale shader crash radv
https://bugs.freedesktop.org/show_bug.cgi?id=109204 --- Comment #2 from Brandon Wright --- I was just about to post this as well. Seems to be caused by the last pass: https://github.com/libretro/slang-shaders/blob/master/crt/shaders/crt-royale/src/crt-royale-geometry-aa-last-pass.h I can't pinpoint an exact cause. It might just be crashing because the number of constants is overflowing something. Swapping out the last stage for the no-geom version works fine. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 109204] [regression, bisected] retroarch's crt-royale shader crash radv
https://bugs.freedesktop.org/show_bug.cgi?id=109204 --- Comment #1 from osch...@web.de --- Created attachment 142934 --> https://bugs.freedesktop.org/attachment.cgi?id=142934=edit backtrace -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 109204] [regression, bisected] retroarch's crt-royale shader crash radv
https://bugs.freedesktop.org/show_bug.cgi?id=109204 Bug ID: 109204 Summary: [regression, bisected] retroarch's crt-royale shader crash radv Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: Drivers/Vulkan/radeon Assignee: mesa-dev@lists.freedesktop.org Reporter: osch...@web.de QA Contact: mesa-dev@lists.freedesktop.org Created attachment 142933 --> https://bugs.freedesktop.org/attachment.cgi?id=142933=edit bisect log When running retroarch with any of the crt-royale shaders applied, it crashed within libvulkan_radeon.so. This affects Mesa 18.3.1 and current -git 8c93ef5de98a90a93, 18.2.8 works fine. LLVM version doesn't seem to make a difference. AMDVLK also works as expected. Bisecting produced the first bad commit as: commit a45b6fb45246f6b8e2b4a06977f199cc77452289 Author: Jason Ekstrand Date: Sat Sep 22 09:46:26 2018 -0500 spirv: Pass SSA values through functions Previously, we would create temporary variables and fill them out. Instead, we create as many function parameters as we need and pass them through as SSA defs. Reviewed-by: Iago Toral Quiroga The crt-royale slang shader can be found here: https://github.com/libretro/slang-shaders/tree/master/crt I'll attach the bisect log, a gdb backtrace, and a coredump. coredump: https://drive.google.com/open?id=13weXQtqouPYlJeER0kYXDJHDJGK7AZl9 -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
