Re: [Mesa-dev] [PATCH] llvmpipe: make remove_shader_variant static.

2019-06-20 Thread Roland Scheidegger 
Reviewed-by: Roland Scheidegger 

Am 19.06.19 um 22:47 schrieb Dave Airlie:
> From: Dave Airlie 
> 
> this isn't used outside this file.
> ---
>  src/gallium/drivers/llvmpipe/lp_state_fs.c | 2 +-
>  src/gallium/drivers/llvmpipe/lp_state_fs.h | 4 
>  2 files changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/src/gallium/drivers/llvmpipe/lp_state_fs.c 
> b/src/gallium/drivers/llvmpipe/lp_state_fs.c
> index ab285bed1ca..b05997a3aab 100644
> --- a/src/gallium/drivers/llvmpipe/lp_state_fs.c
> +++ b/src/gallium/drivers/llvmpipe/lp_state_fs.c
> @@ -3023,7 +3023,7 @@ llvmpipe_bind_fs_state(struct pipe_context *pipe, void 
> *fs)
>   * Remove shader variant from two lists: the shader's variant list
>   * and the context's variant list.
>   */
> -void
> +static void
>  llvmpipe_remove_shader_variant(struct llvmpipe_context *lp,
> struct lp_fragment_shader_variant *variant)
>  {
> diff --git a/src/gallium/drivers/llvmpipe/lp_state_fs.h 
> b/src/gallium/drivers/llvmpipe/lp_state_fs.h
> index 28eccde17f8..dc04df8bd94 100644
> --- a/src/gallium/drivers/llvmpipe/lp_state_fs.h
> +++ b/src/gallium/drivers/llvmpipe/lp_state_fs.h
> @@ -145,8 +145,4 @@ struct lp_fragment_shader
>  void
>  lp_debug_fs_variant(const struct lp_fragment_shader_variant *variant);
>  
> -void
> -llvmpipe_remove_shader_variant(struct llvmpipe_context *lp,
> -   struct lp_fragment_shader_variant *variant);
> -
>  #endif /* LP_STATE_FS_H_ */
> 

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] llvmpipe: make remove_shader_variant static.

2019-06-19 Thread Caio Marcelo de Oliveira Filho 
On Thu, Jun 20, 2019 at 06:47:25AM +1000, Dave Airlie wrote:
> From: Dave Airlie 
> 
> this isn't used outside this file.
> ---
>  src/gallium/drivers/llvmpipe/lp_state_fs.c | 2 +-
>  src/gallium/drivers/llvmpipe/lp_state_fs.h | 4 
>  2 files changed, 1 insertion(+), 5 deletions(-)

This patch is

`Reviewed-by: Caio Marcelo de Oliveira Filho `


Caio
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] llvmpipe: make remove_shader_variant static.

2019-06-19 Thread Dave Airlie 
From: Dave Airlie 

this isn't used outside this file.
---
 src/gallium/drivers/llvmpipe/lp_state_fs.c | 2 +-
 src/gallium/drivers/llvmpipe/lp_state_fs.h | 4 
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/src/gallium/drivers/llvmpipe/lp_state_fs.c 
b/src/gallium/drivers/llvmpipe/lp_state_fs.c
index ab285bed1ca..b05997a3aab 100644
--- a/src/gallium/drivers/llvmpipe/lp_state_fs.c
+++ b/src/gallium/drivers/llvmpipe/lp_state_fs.c
@@ -3023,7 +3023,7 @@ llvmpipe_bind_fs_state(struct pipe_context *pipe, void 
*fs)
  * Remove shader variant from two lists: the shader's variant list
  * and the context's variant list.
  */
-void
+static void
 llvmpipe_remove_shader_variant(struct llvmpipe_context *lp,
struct lp_fragment_shader_variant *variant)
 {
diff --git a/src/gallium/drivers/llvmpipe/lp_state_fs.h 
b/src/gallium/drivers/llvmpipe/lp_state_fs.h
index 28eccde17f8..dc04df8bd94 100644
--- a/src/gallium/drivers/llvmpipe/lp_state_fs.h
+++ b/src/gallium/drivers/llvmpipe/lp_state_fs.h
@@ -145,8 +145,4 @@ struct lp_fragment_shader
 void
 lp_debug_fs_variant(const struct lp_fragment_shader_variant *variant);
 
-void
-llvmpipe_remove_shader_variant(struct llvmpipe_context *lp,
-   struct lp_fragment_shader_variant *variant);
-
 #endif /* LP_STATE_FS_H_ */
-- 
2.21.0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev