Re: [Mesa-dev] [PATCH] meson: drop the xcb-xrandr version requirement
I'm a bit confused by this patch It's in a section called xlib_lease, for leases to work I think the newer version is required, but I think the underlying code was changed to build without the newer headers Do leases work with the old code, or should this section be renamed? On Sun, 3 Feb 2019 at 11:52, Erik Faye-Lund wrote: > > On Sat, 2019-02-02 at 12:58 -0500, Marek Olšák wrote: > > > > > > On Sat, Feb 2, 2019, 12:41 PM Eric Engestrom < > > eric.engest...@intel.com wrote: > > > On Saturday, 2019-02-02 10:32:15 -0500, Marek Olšák wrote: > > > > On Sat, Feb 2, 2019, 7:17 AM Eric Engestrom < > > > eric.engest...@intel.com wrote: > > > > > > > > > On Friday, 2019-02-01 15:42:17 -0500, Marek Olšák wrote: > > > > > > If there is no feedback soon, I'll push this. > > > > > > > > > > Have you tested that xcb-randr < 1.12 works? > > > > > Probably shouldn't remove a restriction unless you're sure it > > > isn't > > > > > needed :) > > > > > > > > > > > > > Is this a joke? I'm just mirroring autotools. Supporting the same > > > linux > > > > distributions as autotools is a requirement for meson's general > > > acceptance. > > > > > > No, I'm being serious: just because a restriction didn't exist on > > > autotools doesn't mean that code path was exercised by people > > > running > > > an old xcb-randr, hence the need to test it :) > > > > > > I didn't mean to offend you, I was just asking the question to make > > > sure > > > this was tested before we claim to support xcb-randr < 1.12, as it > > > might > > > be that autotools was simply missing the version check. > > > > Ok. I use old xcb-xrandr on some of my systems, one of them used to > > be my main system. Not being able to use meson on those systems > > without this patch is a big deal for me. > > This sounds like you have indeed tested on xcb-randr < 1.12, so I > suppose the answer to the question is "yes"? If so, I think it's all > good, no? > > Anyway, I think this seems like the right move, and since Keith has't > responded, feel free to add: > > Reviewed-by: Erik Faye-Lund > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] meson: drop the xcb-xrandr version requirement
On Sat, 2019-02-02 at 12:58 -0500, Marek Olšák wrote: > > > On Sat, Feb 2, 2019, 12:41 PM Eric Engestrom < > eric.engest...@intel.com wrote: > > On Saturday, 2019-02-02 10:32:15 -0500, Marek Olšák wrote: > > > On Sat, Feb 2, 2019, 7:17 AM Eric Engestrom < > > eric.engest...@intel.com wrote: > > > > > > > On Friday, 2019-02-01 15:42:17 -0500, Marek Olšák wrote: > > > > > If there is no feedback soon, I'll push this. > > > > > > > > Have you tested that xcb-randr < 1.12 works? > > > > Probably shouldn't remove a restriction unless you're sure it > > isn't > > > > needed :) > > > > > > > > > > Is this a joke? I'm just mirroring autotools. Supporting the same > > linux > > > distributions as autotools is a requirement for meson's general > > acceptance. > > > > No, I'm being serious: just because a restriction didn't exist on > > autotools doesn't mean that code path was exercised by people > > running > > an old xcb-randr, hence the need to test it :) > > > > I didn't mean to offend you, I was just asking the question to make > > sure > > this was tested before we claim to support xcb-randr < 1.12, as it > > might > > be that autotools was simply missing the version check. > > Ok. I use old xcb-xrandr on some of my systems, one of them used to > be my main system. Not being able to use meson on those systems > without this patch is a big deal for me. This sounds like you have indeed tested on xcb-randr < 1.12, so I suppose the answer to the question is "yes"? If so, I think it's all good, no? Anyway, I think this seems like the right move, and since Keith has't responded, feel free to add: Reviewed-by: Erik Faye-Lund ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] meson: drop the xcb-xrandr version requirement
On Sat, Feb 2, 2019, 12:41 PM Eric Engestrom On Saturday, 2019-02-02 10:32:15 -0500, Marek Olšák wrote:
> > On Sat, Feb 2, 2019, 7:17 AM Eric Engestrom wrote:
> >
> > > On Friday, 2019-02-01 15:42:17 -0500, Marek Olšák wrote:
> > > > If there is no feedback soon, I'll push this.
> > >
> > > Have you tested that xcb-randr < 1.12 works?
> > > Probably shouldn't remove a restriction unless you're sure it isn't
> > > needed :)
> > >
> >
> > Is this a joke? I'm just mirroring autotools. Supporting the same linux
> > distributions as autotools is a requirement for meson's general
> acceptance.
>
> No, I'm being serious: just because a restriction didn't exist on
> autotools doesn't mean that code path was exercised by people running
> an old xcb-randr, hence the need to test it :)
>
> I didn't mean to offend you, I was just asking the question to make sure
> this was tested before we claim to support xcb-randr < 1.12, as it might
> be that autotools was simply missing the version check.
>
Ok. I use old xcb-xrandr on some of my systems, one of them used to be my
main system. Not being able to use meson on those systems without this
patch is a big deal for me.
Marek
> >
> > Marek
> >
> >
> > > >
> > > > Marek
> > > >
> > > > On Wed, Jan 30, 2019 at 12:44 PM Erik Faye-Lund <
> > > > erik.faye-l...@collabora.com> wrote:
> > > >
> > > > > On Wed, 2019-01-30 at 12:32 -0500, Marek Olšák wrote:
> > > > > > ping
> > > > > >
> > > > >
> > > > > Probably worth including Keith, who added this line...
> > >
> > > Added him.
> > >
> > > > >
> > > > > But yeah, I tend to think that this makes sense. The
> autotools-build
> > > > > doesn't seem to tie this to a specific version, and seems to have
> been
> > > > > used without problems for almost a year. But let's hear what Keith
> > > > > things first...
> > > > >
> > > > > > On Fri, Jan 25, 2019 at 5:48 PM Marek Olšák
> > > wrote:
> > > > > > > From: Marek Olšák
> > > > > > >
> > > > > > > autotools doesn't have any requirement. This fixes meson on
> Ubuntu
> > > > > > > 16.04.
> > > > > > > ---
> > > > > > > meson.build | 2 +-
> > > > > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > > > >
> > > > > > > diff --git a/meson.build b/meson.build
> > > > > > > index 34e2a032548..7f16c3070fe 100644
> > > > > > > --- a/meson.build
> > > > > > > +++ b/meson.build
> > > > > > > @@ -1389,21 +1389,21 @@ if with_platform_x11
> > > > > > >dep_xxf86vm = dependency('xxf86vm')
> > > > > > > endif
> > > > > > > dep_glproto = dependency('glproto', version : '>= 1.4.14')
> > > > > > >endif
> > > > > > >if (with_egl or (
> > > > > > >with_gallium_vdpau or with_gallium_xvmc or
> with_gallium_xa
> > > > > > > or
> > > > > > >with_gallium_omx != 'disabled'))
> > > > > > > dep_xcb_xfixes = dependency('xcb-xfixes')
> > > > > > >endif
> > > > > > >if with_xlib_lease
> > > > > > > -dep_xcb_xrandr = dependency('xcb-randr', version : '>=
> 1.12')
> > > > > > > +dep_xcb_xrandr = dependency('xcb-randr')
> > > > > > > dep_xlib_xrandr = dependency('xrandr', version : '>= 1.3')
> > > > > > >endif
> > > > > > > endif
> > > > > > >
> > > > > > > if get_option('gallium-extra-hud')
> > > > > > >pre_args += '-DHAVE_GALLIUM_EXTRA_HUD=1'
> > > > > > > endif
> > > > > > >
> > > > > > > _sensors = get_option('lmsensors')
> > > > > > > if _sensors != 'false'
> > > > > > > ___
> > > > > > > mesa-dev mailing list
> > > > > > > mesa-dev@lists.freedesktop.org
> > > > > > > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> > > > >
> > > > >
> > >
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] meson: drop the xcb-xrandr version requirement
On Saturday, 2019-02-02 10:32:15 -0500, Marek Olšák wrote:
> On Sat, Feb 2, 2019, 7:17 AM Eric Engestrom
> > On Friday, 2019-02-01 15:42:17 -0500, Marek Olšák wrote:
> > > If there is no feedback soon, I'll push this.
> >
> > Have you tested that xcb-randr < 1.12 works?
> > Probably shouldn't remove a restriction unless you're sure it isn't
> > needed :)
> >
>
> Is this a joke? I'm just mirroring autotools. Supporting the same linux
> distributions as autotools is a requirement for meson's general acceptance.
No, I'm being serious: just because a restriction didn't exist on
autotools doesn't mean that code path was exercised by people running
an old xcb-randr, hence the need to test it :)
I didn't mean to offend you, I was just asking the question to make sure
this was tested before we claim to support xcb-randr < 1.12, as it might
be that autotools was simply missing the version check.
>
> Marek
>
>
> > >
> > > Marek
> > >
> > > On Wed, Jan 30, 2019 at 12:44 PM Erik Faye-Lund <
> > > erik.faye-l...@collabora.com> wrote:
> > >
> > > > On Wed, 2019-01-30 at 12:32 -0500, Marek Olšák wrote:
> > > > > ping
> > > > >
> > > >
> > > > Probably worth including Keith, who added this line...
> >
> > Added him.
> >
> > > >
> > > > But yeah, I tend to think that this makes sense. The autotools-build
> > > > doesn't seem to tie this to a specific version, and seems to have been
> > > > used without problems for almost a year. But let's hear what Keith
> > > > things first...
> > > >
> > > > > On Fri, Jan 25, 2019 at 5:48 PM Marek Olšák
> > wrote:
> > > > > > From: Marek Olšák
> > > > > >
> > > > > > autotools doesn't have any requirement. This fixes meson on Ubuntu
> > > > > > 16.04.
> > > > > > ---
> > > > > > meson.build | 2 +-
> > > > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > > >
> > > > > > diff --git a/meson.build b/meson.build
> > > > > > index 34e2a032548..7f16c3070fe 100644
> > > > > > --- a/meson.build
> > > > > > +++ b/meson.build
> > > > > > @@ -1389,21 +1389,21 @@ if with_platform_x11
> > > > > >dep_xxf86vm = dependency('xxf86vm')
> > > > > > endif
> > > > > > dep_glproto = dependency('glproto', version : '>= 1.4.14')
> > > > > >endif
> > > > > >if (with_egl or (
> > > > > >with_gallium_vdpau or with_gallium_xvmc or with_gallium_xa
> > > > > > or
> > > > > >with_gallium_omx != 'disabled'))
> > > > > > dep_xcb_xfixes = dependency('xcb-xfixes')
> > > > > >endif
> > > > > >if with_xlib_lease
> > > > > > -dep_xcb_xrandr = dependency('xcb-randr', version : '>= 1.12')
> > > > > > +dep_xcb_xrandr = dependency('xcb-randr')
> > > > > > dep_xlib_xrandr = dependency('xrandr', version : '>= 1.3')
> > > > > >endif
> > > > > > endif
> > > > > >
> > > > > > if get_option('gallium-extra-hud')
> > > > > >pre_args += '-DHAVE_GALLIUM_EXTRA_HUD=1'
> > > > > > endif
> > > > > >
> > > > > > _sensors = get_option('lmsensors')
> > > > > > if _sensors != 'false'
> > > > > > ___
> > > > > > mesa-dev mailing list
> > > > > > mesa-dev@lists.freedesktop.org
> > > > > > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> > > >
> > > >
> >
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] meson: drop the xcb-xrandr version requirement
On Sat, Feb 2, 2019, 7:17 AM Eric Engestrom On Friday, 2019-02-01 15:42:17 -0500, Marek Olšák wrote:
> > If there is no feedback soon, I'll push this.
>
> Have you tested that xcb-randr < 1.12 works?
> Probably shouldn't remove a restriction unless you're sure it isn't
> needed :)
>
Is this a joke? I'm just mirroring autotools. Supporting the same linux
distributions as autotools is a requirement for meson's general acceptance.
Marek
> >
> > Marek
> >
> > On Wed, Jan 30, 2019 at 12:44 PM Erik Faye-Lund <
> > erik.faye-l...@collabora.com> wrote:
> >
> > > On Wed, 2019-01-30 at 12:32 -0500, Marek Olšák wrote:
> > > > ping
> > > >
> > >
> > > Probably worth including Keith, who added this line...
>
> Added him.
>
> > >
> > > But yeah, I tend to think that this makes sense. The autotools-build
> > > doesn't seem to tie this to a specific version, and seems to have been
> > > used without problems for almost a year. But let's hear what Keith
> > > things first...
> > >
> > > > On Fri, Jan 25, 2019 at 5:48 PM Marek Olšák
> wrote:
> > > > > From: Marek Olšák
> > > > >
> > > > > autotools doesn't have any requirement. This fixes meson on Ubuntu
> > > > > 16.04.
> > > > > ---
> > > > > meson.build | 2 +-
> > > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/meson.build b/meson.build
> > > > > index 34e2a032548..7f16c3070fe 100644
> > > > > --- a/meson.build
> > > > > +++ b/meson.build
> > > > > @@ -1389,21 +1389,21 @@ if with_platform_x11
> > > > >dep_xxf86vm = dependency('xxf86vm')
> > > > > endif
> > > > > dep_glproto = dependency('glproto', version : '>= 1.4.14')
> > > > >endif
> > > > >if (with_egl or (
> > > > >with_gallium_vdpau or with_gallium_xvmc or with_gallium_xa
> > > > > or
> > > > >with_gallium_omx != 'disabled'))
> > > > > dep_xcb_xfixes = dependency('xcb-xfixes')
> > > > >endif
> > > > >if with_xlib_lease
> > > > > -dep_xcb_xrandr = dependency('xcb-randr', version : '>= 1.12')
> > > > > +dep_xcb_xrandr = dependency('xcb-randr')
> > > > > dep_xlib_xrandr = dependency('xrandr', version : '>= 1.3')
> > > > >endif
> > > > > endif
> > > > >
> > > > > if get_option('gallium-extra-hud')
> > > > >pre_args += '-DHAVE_GALLIUM_EXTRA_HUD=1'
> > > > > endif
> > > > >
> > > > > _sensors = get_option('lmsensors')
> > > > > if _sensors != 'false'
> > > > > ___
> > > > > mesa-dev mailing list
> > > > > mesa-dev@lists.freedesktop.org
> > > > > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> > >
> > >
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] meson: drop the xcb-xrandr version requirement
On Friday, 2019-02-01 15:42:17 -0500, Marek Olšák wrote:
> If there is no feedback soon, I'll push this.
Have you tested that xcb-randr < 1.12 works?
Probably shouldn't remove a restriction unless you're sure it isn't
needed :)
>
> Marek
>
> On Wed, Jan 30, 2019 at 12:44 PM Erik Faye-Lund <
> erik.faye-l...@collabora.com> wrote:
>
> > On Wed, 2019-01-30 at 12:32 -0500, Marek Olšák wrote:
> > > ping
> > >
> >
> > Probably worth including Keith, who added this line...
Added him.
> >
> > But yeah, I tend to think that this makes sense. The autotools-build
> > doesn't seem to tie this to a specific version, and seems to have been
> > used without problems for almost a year. But let's hear what Keith
> > things first...
> >
> > > On Fri, Jan 25, 2019 at 5:48 PM Marek Olšák wrote:
> > > > From: Marek Olšák
> > > >
> > > > autotools doesn't have any requirement. This fixes meson on Ubuntu
> > > > 16.04.
> > > > ---
> > > > meson.build | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/meson.build b/meson.build
> > > > index 34e2a032548..7f16c3070fe 100644
> > > > --- a/meson.build
> > > > +++ b/meson.build
> > > > @@ -1389,21 +1389,21 @@ if with_platform_x11
> > > >dep_xxf86vm = dependency('xxf86vm')
> > > > endif
> > > > dep_glproto = dependency('glproto', version : '>= 1.4.14')
> > > >endif
> > > >if (with_egl or (
> > > >with_gallium_vdpau or with_gallium_xvmc or with_gallium_xa
> > > > or
> > > >with_gallium_omx != 'disabled'))
> > > > dep_xcb_xfixes = dependency('xcb-xfixes')
> > > >endif
> > > >if with_xlib_lease
> > > > -dep_xcb_xrandr = dependency('xcb-randr', version : '>= 1.12')
> > > > +dep_xcb_xrandr = dependency('xcb-randr')
> > > > dep_xlib_xrandr = dependency('xrandr', version : '>= 1.3')
> > > >endif
> > > > endif
> > > >
> > > > if get_option('gallium-extra-hud')
> > > >pre_args += '-DHAVE_GALLIUM_EXTRA_HUD=1'
> > > > endif
> > > >
> > > > _sensors = get_option('lmsensors')
> > > > if _sensors != 'false'
> > > > ___
> > > > mesa-dev mailing list
> > > > mesa-dev@lists.freedesktop.org
> > > > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> >
> >
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] meson: drop the xcb-xrandr version requirement
If there is no feedback soon, I'll push this.
Marek
On Wed, Jan 30, 2019 at 12:44 PM Erik Faye-Lund <
erik.faye-l...@collabora.com> wrote:
> On Wed, 2019-01-30 at 12:32 -0500, Marek Olšák wrote:
> > ping
> >
>
> Probably worth including Keith, who added this line...
>
> But yeah, I tend to think that this makes sense. The autotools-build
> doesn't seem to tie this to a specific version, and seems to have been
> used without problems for almost a year. But let's hear what Keith
> things first...
>
> > On Fri, Jan 25, 2019 at 5:48 PM Marek Olšák wrote:
> > > From: Marek Olšák
> > >
> > > autotools doesn't have any requirement. This fixes meson on Ubuntu
> > > 16.04.
> > > ---
> > > meson.build | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/meson.build b/meson.build
> > > index 34e2a032548..7f16c3070fe 100644
> > > --- a/meson.build
> > > +++ b/meson.build
> > > @@ -1389,21 +1389,21 @@ if with_platform_x11
> > >dep_xxf86vm = dependency('xxf86vm')
> > > endif
> > > dep_glproto = dependency('glproto', version : '>= 1.4.14')
> > >endif
> > >if (with_egl or (
> > >with_gallium_vdpau or with_gallium_xvmc or with_gallium_xa
> > > or
> > >with_gallium_omx != 'disabled'))
> > > dep_xcb_xfixes = dependency('xcb-xfixes')
> > >endif
> > >if with_xlib_lease
> > > -dep_xcb_xrandr = dependency('xcb-randr', version : '>= 1.12')
> > > +dep_xcb_xrandr = dependency('xcb-randr')
> > > dep_xlib_xrandr = dependency('xrandr', version : '>= 1.3')
> > >endif
> > > endif
> > >
> > > if get_option('gallium-extra-hud')
> > >pre_args += '-DHAVE_GALLIUM_EXTRA_HUD=1'
> > > endif
> > >
> > > _sensors = get_option('lmsensors')
> > > if _sensors != 'false'
> > > ___
> > > mesa-dev mailing list
> > > mesa-dev@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] meson: drop the xcb-xrandr version requirement
On Wed, 2019-01-30 at 12:32 -0500, Marek Olšák wrote:
> ping
>
Probably worth including Keith, who added this line...
But yeah, I tend to think that this makes sense. The autotools-build
doesn't seem to tie this to a specific version, and seems to have been
used without problems for almost a year. But let's hear what Keith
things first...
> On Fri, Jan 25, 2019 at 5:48 PM Marek Olšák wrote:
> > From: Marek Olšák
> >
> > autotools doesn't have any requirement. This fixes meson on Ubuntu
> > 16.04.
> > ---
> > meson.build | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meson.build b/meson.build
> > index 34e2a032548..7f16c3070fe 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -1389,21 +1389,21 @@ if with_platform_x11
> >dep_xxf86vm = dependency('xxf86vm')
> > endif
> > dep_glproto = dependency('glproto', version : '>= 1.4.14')
> >endif
> >if (with_egl or (
> >with_gallium_vdpau or with_gallium_xvmc or with_gallium_xa
> > or
> >with_gallium_omx != 'disabled'))
> > dep_xcb_xfixes = dependency('xcb-xfixes')
> >endif
> >if with_xlib_lease
> > -dep_xcb_xrandr = dependency('xcb-randr', version : '>= 1.12')
> > +dep_xcb_xrandr = dependency('xcb-randr')
> > dep_xlib_xrandr = dependency('xrandr', version : '>= 1.3')
> >endif
> > endif
> >
> > if get_option('gallium-extra-hud')
> >pre_args += '-DHAVE_GALLIUM_EXTRA_HUD=1'
> > endif
> >
> > _sensors = get_option('lmsensors')
> > if _sensors != 'false'
> > ___
> > mesa-dev mailing list
> > mesa-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] meson: drop the xcb-xrandr version requirement
ping
On Fri, Jan 25, 2019 at 5:48 PM Marek Olšák wrote:
> From: Marek Olšák
>
> autotools doesn't have any requirement. This fixes meson on Ubuntu 16.04.
> ---
> meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index 34e2a032548..7f16c3070fe 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -1389,21 +1389,21 @@ if with_platform_x11
>dep_xxf86vm = dependency('xxf86vm')
> endif
> dep_glproto = dependency('glproto', version : '>= 1.4.14')
>endif
>if (with_egl or (
>with_gallium_vdpau or with_gallium_xvmc or with_gallium_xa or
>with_gallium_omx != 'disabled'))
> dep_xcb_xfixes = dependency('xcb-xfixes')
>endif
>if with_xlib_lease
> -dep_xcb_xrandr = dependency('xcb-randr', version : '>= 1.12')
> +dep_xcb_xrandr = dependency('xcb-randr')
> dep_xlib_xrandr = dependency('xrandr', version : '>= 1.3')
>endif
> endif
>
> if get_option('gallium-extra-hud')
>pre_args += '-DHAVE_GALLIUM_EXTRA_HUD=1'
> endif
>
> _sensors = get_option('lmsensors')
> if _sensors != 'false'
> --
> 2.17.1
>
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH] meson: drop the xcb-xrandr version requirement
From: Marek Olšák
autotools doesn't have any requirement. This fixes meson on Ubuntu 16.04.
---
meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index 34e2a032548..7f16c3070fe 100644
--- a/meson.build
+++ b/meson.build
@@ -1389,21 +1389,21 @@ if with_platform_x11
dep_xxf86vm = dependency('xxf86vm')
endif
dep_glproto = dependency('glproto', version : '>= 1.4.14')
endif
if (with_egl or (
with_gallium_vdpau or with_gallium_xvmc or with_gallium_xa or
with_gallium_omx != 'disabled'))
dep_xcb_xfixes = dependency('xcb-xfixes')
endif
if with_xlib_lease
-dep_xcb_xrandr = dependency('xcb-randr', version : '>= 1.12')
+dep_xcb_xrandr = dependency('xcb-randr')
dep_xlib_xrandr = dependency('xrandr', version : '>= 1.3')
endif
endif
if get_option('gallium-extra-hud')
pre_args += '-DHAVE_GALLIUM_EXTRA_HUD=1'
endif
_sensors = get_option('lmsensors')
if _sensors != 'false'
--
2.17.1
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
