Re: [Mesa-dev] [PATCH] radv: don't crash on null swapchain destroy.

2016-11-15 Thread Bas Nieuwenhuizen
r-b

On 15 Nov 2016 9:12 PM, "Dave Airlie"  wrote:

> From: Dave Airlie 
>
> Just return if the passed in swapchain is NULL.
>
> Fixes: dEQP-VK.wsi.xlib.swapchain.destroy.null_handle
>
> Signed-off-by: Dave Airlie 
> ---
>  src/amd/vulkan/radv_wsi.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/src/amd/vulkan/radv_wsi.c b/src/amd/vulkan/radv_wsi.c
> index a946bd4..1f1ab1c 100644
> --- a/src/amd/vulkan/radv_wsi.c
> +++ b/src/amd/vulkan/radv_wsi.c
> @@ -288,6 +288,9 @@ void radv_DestroySwapchainKHR(
> RADV_FROM_HANDLE(wsi_swapchain, swapchain, _swapchain);
> const VkAllocationCallbacks *alloc;
>
> +   if (!_swapchain)
> +   return;
> +
> if (pAllocator)
> alloc = pAllocator;
> else
> --
> 2.7.4
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH] radv: don't crash on null swapchain destroy.

2016-11-15 Thread Dave Airlie
From: Dave Airlie 

Just return if the passed in swapchain is NULL.

Fixes: dEQP-VK.wsi.xlib.swapchain.destroy.null_handle

Signed-off-by: Dave Airlie 
---
 src/amd/vulkan/radv_wsi.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/amd/vulkan/radv_wsi.c b/src/amd/vulkan/radv_wsi.c
index a946bd4..1f1ab1c 100644
--- a/src/amd/vulkan/radv_wsi.c
+++ b/src/amd/vulkan/radv_wsi.c
@@ -288,6 +288,9 @@ void radv_DestroySwapchainKHR(
RADV_FROM_HANDLE(wsi_swapchain, swapchain, _swapchain);
const VkAllocationCallbacks *alloc;
 
+   if (!_swapchain)
+   return;
+
if (pAllocator)
alloc = pAllocator;
else
-- 
2.7.4

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev