Re: [Mesa-dev] [PATCH] softpipe: fix another stencil-as-float issue

2015-04-27 Thread Brian Paul 

On 04/25/2015 02:17 PM, srol...@vmware.com wrote:

From: Roland Scheidegger srol...@vmware.com

Hopefully this is the last one now (for texture X32_S8X24_UINT views).
+4 piglits.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90167
---
  src/gallium/auxiliary/util/u_tile.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/gallium/auxiliary/util/u_tile.c 
b/src/gallium/auxiliary/util/u_tile.c
index 8e19920..b91bb41 100644
--- a/src/gallium/auxiliary/util/u_tile.c
+++ b/src/gallium/auxiliary/util/u_tile.c
@@ -341,13 +341,13 @@ x32_s8_get_tile_rgba(const unsigned *src,
 unsigned i, j;

 for (i = 0; i  h; i++) {
-  float *pRow = p;
+  uint32_t *pRow = (uint32_t *)p;
for (j = 0; j  w; j++, pRow += 4) {
   src++;
   pRow[0] =
   pRow[1] =
   pRow[2] =
- pRow[3] = (float)(*src++  0xff);
+ pRow[3] = (*src++  0xff);
}
p += dst_stride;
 }



Reviewed-by: Brian Paul bri...@vmware.com

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] softpipe: fix another stencil-as-float issue

2015-04-27 Thread Dave Airlie 
On 26 April 2015 at 06:17,  srol...@vmware.com wrote:
 From: Roland Scheidegger srol...@vmware.com

Oh indeed,

thanks,
Reviewed-by: Dave Airlie airl...@redhat.com


 Hopefully this is the last one now (for texture X32_S8X24_UINT views).
 +4 piglits.

 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90167
 ---
  src/gallium/auxiliary/util/u_tile.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

 diff --git a/src/gallium/auxiliary/util/u_tile.c 
 b/src/gallium/auxiliary/util/u_tile.c
 index 8e19920..b91bb41 100644
 --- a/src/gallium/auxiliary/util/u_tile.c
 +++ b/src/gallium/auxiliary/util/u_tile.c
 @@ -341,13 +341,13 @@ x32_s8_get_tile_rgba(const unsigned *src,
 unsigned i, j;

 for (i = 0; i  h; i++) {
 -  float *pRow = p;
 +  uint32_t *pRow = (uint32_t *)p;
for (j = 0; j  w; j++, pRow += 4) {
   src++;
   pRow[0] =
   pRow[1] =
   pRow[2] =
 - pRow[3] = (float)(*src++  0xff);
 + pRow[3] = (*src++  0xff);
}
p += dst_stride;
 }
 --
 1.9.1

 ___
 mesa-dev mailing list
 mesa-dev@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] softpipe: fix another stencil-as-float issue

2015-04-25 Thread sroland 
From: Roland Scheidegger srol...@vmware.com

Hopefully this is the last one now (for texture X32_S8X24_UINT views).
+4 piglits.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90167
---
 src/gallium/auxiliary/util/u_tile.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/gallium/auxiliary/util/u_tile.c 
b/src/gallium/auxiliary/util/u_tile.c
index 8e19920..b91bb41 100644
--- a/src/gallium/auxiliary/util/u_tile.c
+++ b/src/gallium/auxiliary/util/u_tile.c
@@ -341,13 +341,13 @@ x32_s8_get_tile_rgba(const unsigned *src,
unsigned i, j;
 
for (i = 0; i  h; i++) {
-  float *pRow = p;
+  uint32_t *pRow = (uint32_t *)p;
   for (j = 0; j  w; j++, pRow += 4) {
  src++;
  pRow[0] =
  pRow[1] =
  pRow[2] =
- pRow[3] = (float)(*src++  0xff);
+ pRow[3] = (*src++  0xff);
   }
   p += dst_stride;
}
-- 
1.9.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev