Re: [Mesa-dev] [PATCH] st/va: hardlink driver instances to gallium_drv_video.so

[Emil Velikov]

On 14 June 2016 at 09:10, Julien Isorce  wrote:
> Hi,
>
> It seems this patch has been pushed recently. This is causing me problems on
> a multi gpu configuration.
> It is a laptop with intel and nvidia, graphic hardwares.
>
> 1: intel vaapi driver:
> vainfo
>
> 2: st/va,nouveau:
> DRI_PRIME=1 LIBVA_DRIVER_NAME=gallium vainfo
>
> with that patch 0c0f841e5de27d01312f8857641668ca439b1ab1 " st/va: hardlink
> driver instances to gallium_drv_video.so"
> the case 2 does not work anymore. Ah I just realized that it does work by
> setting:  LIBVA_DRIVER_NAME=nouveau
>
LIBVA_DRIVER_NAME explicitly overrides any logic that is used to
determine the name. DRI_PRIME machine being one.
Thus in theory one could have used $ LIBVA_DRIVER_NAME=gallium vainfo

On the other hand dropping the explicit name and using DRI_PRIME alone
should work just fine (with current master).
In other words the following should list/use nouveau.

$ DRI_PRIME=1 vainfo

> Is it the expected behavior ?
>
Ssort of.

As you can guess, I wasn't too excited on the patch. Sadly your fix
for libva exposed annoying bug(s) in said library. Namely its mapping
table, is used only for VA_DISPLAY_DRM* and not for
VA_DISPLAY_{GLX,X11} and others (wayland, android ?) There is more
info about bugs, bad coding practises etc. on the libva ML ;-)

TL;DR: Don't set LIBVA_DRIVER_NAME and everything should work as expected.

Regards,
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] st/va: hardlink driver instances to gallium_drv_video.so

[Julien Isorce]

Hi,

It seems this patch has been pushed recently. This is causing me problems
on a multi gpu configuration.
It is a laptop with intel and nvidia, graphic hardwares.

1: intel vaapi driver:
vainfo

2: st/va,nouveau:
DRI_PRIME=1 LIBVA_DRIVER_NAME=gallium vainfo

with that patch 0c0f841e5de27d01312f8857641668ca439b1ab1 " st/va: hardlink
driver instances to gallium_drv_video.so"
the case 2 does not work anymore. Ah I just realized that it does work by
setting:  LIBVA_DRIVER_NAME=nouveau

Is it the expected behavior ?

Cheers
Julien




On 21 April 2016 at 14:20, Emil Velikov  wrote:

> Hi Stefan,
>
> On 21 April 2016 at 14:05, Stefan Dirsch  wrote:
> > From: Jimmy Berry 
> >
> > Removes the need to set LIBVA_DRIVER_NAME=gallium for supported targets
> and is
> > consistent with vdpau and general gallium drivers.
> There are two options here afaict:
>  - Use an updated libva which already handles "gallium_drv.so"
>  - Chip-in on the following topic [1] and working from there.
>
> Personally I'd opt for the former, because (as you know) hardlinking
> things is a bit nasty.
>
> Speaking of which you guys are the only ones building multiple drivers
> at once (thus a megablob is created) yet still shiping the identical
> file as separate drivers.
>
> Suggestion - you can merge the separate packages into one or build
> mesa separate times to produce binaries similar to before megadriver.
>
> Emil
>
> [1] https://patchwork.freedesktop.org/patch/58540/
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] st/va: hardlink driver instances to gallium_drv_video.so

[Emil Velikov]

Hi Stefan,

On 21 April 2016 at 14:05, Stefan Dirsch  wrote:
> From: Jimmy Berry 
>
> Removes the need to set LIBVA_DRIVER_NAME=gallium for supported targets and is
> consistent with vdpau and general gallium drivers.
There are two options here afaict:
 - Use an updated libva which already handles "gallium_drv.so"
 - Chip-in on the following topic [1] and working from there.

Personally I'd opt for the former, because (as you know) hardlinking
things is a bit nasty.

Speaking of which you guys are the only ones building multiple drivers
at once (thus a megablob is created) yet still shiping the identical
file as separate drivers.

Suggestion - you can merge the separate packages into one or build
mesa separate times to produce binaries similar to before megadriver.

Emil

[1] https://patchwork.freedesktop.org/patch/58540/
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] st/va: hardlink driver instances to gallium_drv_video.so

[Stefan Dirsch]

From: Jimmy Berry 

Removes the need to set LIBVA_DRIVER_NAME=gallium for supported targets and is
consistent with vdpau and general gallium drivers.
---
 src/gallium/targets/va/Makefile.am | 14 ++
 1 file changed, 14 insertions(+)

diff --git a/src/gallium/targets/va/Makefile.am 
b/src/gallium/targets/va/Makefile.am
index 1edd5c2..df825b7 100644
--- a/src/gallium/targets/va/Makefile.am
+++ b/src/gallium/targets/va/Makefile.am
@@ -66,3 +66,17 @@ if HAVE_MESA_LLVM
 gallium_drv_video_la_LIBADD += $(LLVM_LIBS)
 gallium_drv_video_la_LDFLAGS += $(LLVM_LDFLAGS)
 endif
+
+# hardlink each megadriver instance, but don't actually have
+# gallium_drv_video.so in the set of final installed files.
+install-data-hook:
+   for i in $(TARGET_DRIVERS); do  \
+   ln -f $(DESTDIR)$(vadir)/gallium_drv_video.so\
+ $(DESTDIR)$(vadir)/$${i}_drv_video.so; \
+   done;   \
+   $(RM) $(DESTDIR)$(vadir)/gallium_drv_video.*
+
+uninstall-hook:
+   for i in $(TARGET_DRIVERS); do  \
+   $(RM) $(DESTDIR)$(vadir)/$${i}_drv_video.so; \
+   done;
-- 
2.6.2

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] st/va: hardlink driver instances to gallium_drv_video.so

[Stefan Dirsch]

Removes the need to set LIBVA_DRIVER_NAME=gallium for supported targets and is
consistent with vdpau and general gallium drivers.

Author: Jimmy Berry 

Signed-off-by: Jimmy Berry 
---
 src/gallium/targets/va/Makefile.am | 14 ++
 1 file changed, 14 insertions(+)

diff --git a/src/gallium/targets/va/Makefile.am 
b/src/gallium/targets/va/Makefile.am
index 1edd5c2..df825b7 100644
--- a/src/gallium/targets/va/Makefile.am
+++ b/src/gallium/targets/va/Makefile.am
@@ -66,3 +66,17 @@ if HAVE_MESA_LLVM
 gallium_drv_video_la_LIBADD += $(LLVM_LIBS)
 gallium_drv_video_la_LDFLAGS += $(LLVM_LDFLAGS)
 endif
+
+# hardlink each megadriver instance, but don't actually have
+# gallium_drv_video.so in the set of final installed files.
+install-data-hook:
+   for i in $(TARGET_DRIVERS); do  \
+   ln -f $(DESTDIR)$(vadir)/gallium_drv_video.so\
+ $(DESTDIR)$(vadir)/$${i}_drv_video.so; \
+   done;   \
+   $(RM) $(DESTDIR)$(vadir)/gallium_drv_video.*
+
+uninstall-hook:
+   for i in $(TARGET_DRIVERS); do  \
+   $(RM) $(DESTDIR)$(vadir)/$${i}_drv_video.so; \
+   done;
-- 
2.6.2

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] st/va: hardlink driver instances to gallium_drv_video.so

[Ilia Mirkin]

On Tue, Apr 19, 2016 at 9:11 AM, Stefan Dirsch  wrote:
> Dear gentlemen,
>
> unfortunately the patch by Jimmy Berry didn't get too much attention, when he
> posted it first. Maybe this time it's different. Find it attached.

FYI, you're limiting the audience of the patch by not sending it
properly. As a rough guideline, same rules as the linux kernel apply
here. http://mesa3d.org/devinfo.html#submitting

Cheers,

  -ilia
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] st/va: hardlink driver instances to gallium_drv_video.so

[Stefan Dirsch]

Dear gentlemen,

unfortunately the patch by Jimmy Berry didn't get too much attention, when he
posted it first. Maybe this time it's different. Find it attached.

Thanks,
Stefan

Public Key available
--
Stefan Dirsch (Res. & Dev.)   SUSE LINUX GmbH
Tel: 0911-740 53 0Maxfeldstraße 5
FAX: 0911-740 53 479  D-90409 Nürnberg
http://www.suse.deGermany 
---
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham
Norton, HRB 21284 (AG Nürnberg)
---
>From 8974248c4147e57552dc21c6d16e4d1817d34fad Mon Sep 17 00:00:00 2001
From: Jimmy Berry <ji...@boombatower.com>
Date: Sat, 19 Dec 2015 22:49:10 -0600
Subject: [Mesa-dev] [PATCH] st/va: hardlink driver instances to gallium_drv_video.so

Removes the need to set LIBVA_DRIVER_NAME=gallium for supported targets and is
consistent with vdpau and general gallium drivers.

Signed-off-by: Jimmy Berry <ji...@boombatower.com>
---
 src/gallium/targets/va/Makefile.am | 14 ++
 1 file changed, 14 insertions(+)

diff --git a/src/gallium/targets/va/Makefile.am b/src/gallium/targets/va/Makefile.am
index 733e7ac..2cab898 100644
--- a/src/gallium/targets/va/Makefile.am
+++ b/src/gallium/targets/va/Makefile.am
@@ -64,3 +64,17 @@ if HAVE_MESA_LLVM
 gallium_drv_video_la_LIBADD += $(LLVM_LIBS)
 gallium_drv_video_la_LDFLAGS += $(LLVM_LDFLAGS)
 endif
+
+# hardlink each megadriver instance, but don't actually have
+# gallium_drv_video.so in the set of final installed files.
+install-data-hook:
+	for i in $(TARGET_DRIVERS); do  \
+		ln -f $(DESTDIR)$(vadir)/gallium_drv_video.so\
+		  $(DESTDIR)$(vadir)/$${i}_drv_video.so; \
+	done;   \
+	$(RM) $(DESTDIR)$(vadir)/gallium_drv_video.*
+
+uninstall-hook:
+	for i in $(TARGET_DRIVERS); do  \
+		$(RM) $(DESTDIR)$(vadir)/$${i}_drv_video.so; \
+	done;
-- 
2.6.3

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] st/va: hardlink driver instances to gallium_drv_video.so

[Jimmy Berry]

I have been holding off v2 with correct spacing before \ (seemingly
missed the first time) waiting for a review to confirm that this is
the right approach as agreed in IRC.

Let me know if anything else.

--
Jimmy


On Sat, Dec 19, 2015 at 10:57 PM, Jimmy Berry  wrote:
> Removes the need to set LIBVA_DRIVER_NAME=gallium for supported targets and is
> consistent with vdpau and general gallium drivers.
>
> Signed-off-by: Jimmy Berry 
> ---
>  src/gallium/targets/va/Makefile.am | 14 ++
>  1 file changed, 14 insertions(+)
>
> diff --git a/src/gallium/targets/va/Makefile.am 
> b/src/gallium/targets/va/Makefile.am
> index 733e7ac..2cab898 100644
> --- a/src/gallium/targets/va/Makefile.am
> +++ b/src/gallium/targets/va/Makefile.am
> @@ -64,3 +64,17 @@ if HAVE_MESA_LLVM
>  gallium_drv_video_la_LIBADD += $(LLVM_LIBS)
>  gallium_drv_video_la_LDFLAGS += $(LLVM_LDFLAGS)
>  endif
> +
> +# hardlink each megadriver instance, but don't actually have
> +# gallium_drv_video.so in the set of final installed files.
> +install-data-hook:
> +   for i in $(TARGET_DRIVERS); do  \
> +   ln -f $(DESTDIR)$(vadir)/gallium_drv_video.so\
> + $(DESTDIR)$(vadir)/$${i}_drv_video.so; \
> +   done;   \
> +   $(RM) $(DESTDIR)$(vadir)/gallium_drv_video.*
> +
> +uninstall-hook:
> +   for i in $(TARGET_DRIVERS); do  \
> +   $(RM) $(DESTDIR)$(vadir)/$${i}_drv_video.so; \
> +   done;
> --
> 2.6.3
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] st/va: hardlink driver instances to gallium_drv_video.so

[Jimmy Berry]

Removes the need to set LIBVA_DRIVER_NAME=gallium for supported targets and is
consistent with vdpau and general gallium drivers.

Signed-off-by: Jimmy Berry 
---
 src/gallium/targets/va/Makefile.am | 14 ++
 1 file changed, 14 insertions(+)

diff --git a/src/gallium/targets/va/Makefile.am 
b/src/gallium/targets/va/Makefile.am
index 733e7ac..2cab898 100644
--- a/src/gallium/targets/va/Makefile.am
+++ b/src/gallium/targets/va/Makefile.am
@@ -64,3 +64,17 @@ if HAVE_MESA_LLVM
 gallium_drv_video_la_LIBADD += $(LLVM_LIBS)
 gallium_drv_video_la_LDFLAGS += $(LLVM_LDFLAGS)
 endif
+
+# hardlink each megadriver instance, but don't actually have
+# gallium_drv_video.so in the set of final installed files.
+install-data-hook:
+   for i in $(TARGET_DRIVERS); do  \
+   ln -f $(DESTDIR)$(vadir)/gallium_drv_video.so\
+ $(DESTDIR)$(vadir)/$${i}_drv_video.so; \
+   done;   \
+   $(RM) $(DESTDIR)$(vadir)/gallium_drv_video.*
+
+uninstall-hook:
+   for i in $(TARGET_DRIVERS); do  \
+   $(RM) $(DESTDIR)$(vadir)/$${i}_drv_video.so; \
+   done;
-- 
2.6.3

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev