Re: [Mesa-dev] [PATCH 03/11] mesa: add mesa_type_is_double helper function

2014-08-22 Thread Ian Romanick 
On 08/14/2014 03:52 AM, Dave Airlie wrote:
 This is a helper to return if a type is based on a double.
 
 Signed-off-by: Dave Airlie airl...@redhat.com
 ---
  src/mesa/program/prog_parameter.h | 22 ++
  1 file changed, 22 insertions(+)
 
 diff --git a/src/mesa/program/prog_parameter.h 
 b/src/mesa/program/prog_parameter.h
 index 6b3b3c2..9ee0f5e 100644
 --- a/src/mesa/program/prog_parameter.h
 +++ b/src/mesa/program/prog_parameter.h
 @@ -151,6 +151,28 @@ _mesa_lookup_parameter_constant(const struct 
 gl_program_parameter_list *list,
  const gl_constant_value v[], GLuint vSize,
  GLint *posOut, GLuint *swizzleOut);
  
 +static INLINE GLboolean mesa_type_is_double(int dataType)

s/GLboolean/bool/ and

Reviewed-by: Ian Romanick ian.d.roman...@intel.com

 +{
 +   switch (dataType) {
 +   case GL_DOUBLE:
 +   case GL_DOUBLE_VEC2:
 +   case GL_DOUBLE_VEC3:
 +   case GL_DOUBLE_VEC4:
 +   case GL_DOUBLE_MAT2:
 +   case GL_DOUBLE_MAT2x3:
 +   case GL_DOUBLE_MAT2x4:
 +   case GL_DOUBLE_MAT3:
 +   case GL_DOUBLE_MAT3x2:
 +   case GL_DOUBLE_MAT3x4:
 +   case GL_DOUBLE_MAT4:
 +   case GL_DOUBLE_MAT4x2:
 +   case GL_DOUBLE_MAT4x3:
 +  return GL_TRUE;
 +   default:
 +  return GL_FALSE;
 +   }
 +}
 +
  #ifdef __cplusplus
  }
  #endif
 

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 03/11] mesa: add mesa_type_is_double helper function

2014-08-14 Thread Dave Airlie 
This is a helper to return if a type is based on a double.

Signed-off-by: Dave Airlie airl...@redhat.com
---
 src/mesa/program/prog_parameter.h | 22 ++
 1 file changed, 22 insertions(+)

diff --git a/src/mesa/program/prog_parameter.h 
b/src/mesa/program/prog_parameter.h
index 6b3b3c2..9ee0f5e 100644
--- a/src/mesa/program/prog_parameter.h
+++ b/src/mesa/program/prog_parameter.h
@@ -151,6 +151,28 @@ _mesa_lookup_parameter_constant(const struct 
gl_program_parameter_list *list,
 const gl_constant_value v[], GLuint vSize,
 GLint *posOut, GLuint *swizzleOut);
 
+static INLINE GLboolean mesa_type_is_double(int dataType)
+{
+   switch (dataType) {
+   case GL_DOUBLE:
+   case GL_DOUBLE_VEC2:
+   case GL_DOUBLE_VEC3:
+   case GL_DOUBLE_VEC4:
+   case GL_DOUBLE_MAT2:
+   case GL_DOUBLE_MAT2x3:
+   case GL_DOUBLE_MAT2x4:
+   case GL_DOUBLE_MAT3:
+   case GL_DOUBLE_MAT3x2:
+   case GL_DOUBLE_MAT3x4:
+   case GL_DOUBLE_MAT4:
+   case GL_DOUBLE_MAT4x2:
+   case GL_DOUBLE_MAT4x3:
+  return GL_TRUE;
+   default:
+  return GL_FALSE;
+   }
+}
+
 #ifdef __cplusplus
 }
 #endif
-- 
1.9.3

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev