Re: [Mesa-dev] [PATCH 1/2] ac: add comments to chip enums
On Tue, May 14, 2019 at 10:17 PM Marek Olšák wrote: > > From: Marek Olšák > > --- > src/amd/common/amd_family.h | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/src/amd/common/amd_family.h b/src/amd/common/amd_family.h > index 185ba029763..eed6553d44b 100644 > --- a/src/amd/common/amd_family.h > +++ b/src/amd/common/amd_family.h > @@ -50,5 +50,5 @@ enum radeon_family { > CHIP_RV560, > CHIP_RV570, > -CHIP_R600, > +CHIP_R600, /* R6xx */ Could also make this /* GFX3 (R6xx) */ > CHIP_RV610, > CHIP_RV630, > @@ -58,9 +58,9 @@ enum radeon_family { > CHIP_RS780, > CHIP_RS880, > -CHIP_RV770, > +CHIP_RV770,/* R7xx */ Could also make this /* GFX3 (R7xx) */ > CHIP_RV730, > CHIP_RV710, > CHIP_RV740, > -CHIP_CEDAR, > +CHIP_CEDAR,/* Evergreen */ Could also make this /* GFX4 (Evergreen) */ > CHIP_REDWOOD, > CHIP_JUNIPER, > @@ -73,17 +73,17 @@ enum radeon_family { > CHIP_TURKS, > CHIP_CAICOS, > -CHIP_CAYMAN, > +CHIP_CAYMAN, /* Northern Islands */ Could also make this /* GFX5 (Northern Islands) */ Either way: Reviewed-by: Alex Deucher > CHIP_ARUBA, > -CHIP_TAHITI, > +CHIP_TAHITI, /* GFX6 (Southern Islands) */ > CHIP_PITCAIRN, > CHIP_VERDE, > CHIP_OLAND, > CHIP_HAINAN, > -CHIP_BONAIRE, > +CHIP_BONAIRE, /* GFX7 (Sea Islands) */ > CHIP_KAVERI, > CHIP_KABINI, > CHIP_HAWAII, > CHIP_MULLINS, > -CHIP_TONGA, > +CHIP_TONGA,/* GFX8 (Volcanic Islands & Polaris) */ > CHIP_ICELAND, > CHIP_CARRIZO, > @@ -94,5 +94,5 @@ enum radeon_family { > CHIP_POLARIS12, > CHIP_VEGAM, > -CHIP_VEGA10, > +CHIP_VEGA10, /* GFX9 (Vega) */ > CHIP_VEGA12, > CHIP_VEGA20, > -- > 2.17.1 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 1/2] ac: add comments to chip enums
Reviewed-by: Dave Airlie On Wed, 15 May 2019 at 12:17, Marek Olšák wrote: > > From: Marek Olšák > > --- > src/amd/common/amd_family.h | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/src/amd/common/amd_family.h b/src/amd/common/amd_family.h > index 185ba029763..eed6553d44b 100644 > --- a/src/amd/common/amd_family.h > +++ b/src/amd/common/amd_family.h > @@ -50,5 +50,5 @@ enum radeon_family { > CHIP_RV560, > CHIP_RV570, > -CHIP_R600, > +CHIP_R600, /* R6xx */ > CHIP_RV610, > CHIP_RV630, > @@ -58,9 +58,9 @@ enum radeon_family { > CHIP_RS780, > CHIP_RS880, > -CHIP_RV770, > +CHIP_RV770,/* R7xx */ > CHIP_RV730, > CHIP_RV710, > CHIP_RV740, > -CHIP_CEDAR, > +CHIP_CEDAR,/* Evergreen */ > CHIP_REDWOOD, > CHIP_JUNIPER, > @@ -73,17 +73,17 @@ enum radeon_family { > CHIP_TURKS, > CHIP_CAICOS, > -CHIP_CAYMAN, > +CHIP_CAYMAN, /* Northern Islands */ > CHIP_ARUBA, > -CHIP_TAHITI, > +CHIP_TAHITI, /* GFX6 (Southern Islands) */ > CHIP_PITCAIRN, > CHIP_VERDE, > CHIP_OLAND, > CHIP_HAINAN, > -CHIP_BONAIRE, > +CHIP_BONAIRE, /* GFX7 (Sea Islands) */ > CHIP_KAVERI, > CHIP_KABINI, > CHIP_HAWAII, > CHIP_MULLINS, > -CHIP_TONGA, > +CHIP_TONGA,/* GFX8 (Volcanic Islands & Polaris) */ > CHIP_ICELAND, > CHIP_CARRIZO, > @@ -94,5 +94,5 @@ enum radeon_family { > CHIP_POLARIS12, > CHIP_VEGAM, > -CHIP_VEGA10, > +CHIP_VEGA10, /* GFX9 (Vega) */ > CHIP_VEGA12, > CHIP_VEGA20, > -- > 2.17.1 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH 1/2] ac: add comments to chip enums
From: Marek Olšák --- src/amd/common/amd_family.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/amd/common/amd_family.h b/src/amd/common/amd_family.h index 185ba029763..eed6553d44b 100644 --- a/src/amd/common/amd_family.h +++ b/src/amd/common/amd_family.h @@ -50,5 +50,5 @@ enum radeon_family { CHIP_RV560, CHIP_RV570, -CHIP_R600, +CHIP_R600, /* R6xx */ CHIP_RV610, CHIP_RV630, @@ -58,9 +58,9 @@ enum radeon_family { CHIP_RS780, CHIP_RS880, -CHIP_RV770, +CHIP_RV770,/* R7xx */ CHIP_RV730, CHIP_RV710, CHIP_RV740, -CHIP_CEDAR, +CHIP_CEDAR,/* Evergreen */ CHIP_REDWOOD, CHIP_JUNIPER, @@ -73,17 +73,17 @@ enum radeon_family { CHIP_TURKS, CHIP_CAICOS, -CHIP_CAYMAN, +CHIP_CAYMAN, /* Northern Islands */ CHIP_ARUBA, -CHIP_TAHITI, +CHIP_TAHITI, /* GFX6 (Southern Islands) */ CHIP_PITCAIRN, CHIP_VERDE, CHIP_OLAND, CHIP_HAINAN, -CHIP_BONAIRE, +CHIP_BONAIRE, /* GFX7 (Sea Islands) */ CHIP_KAVERI, CHIP_KABINI, CHIP_HAWAII, CHIP_MULLINS, -CHIP_TONGA, +CHIP_TONGA,/* GFX8 (Volcanic Islands & Polaris) */ CHIP_ICELAND, CHIP_CARRIZO, @@ -94,5 +94,5 @@ enum radeon_family { CHIP_POLARIS12, CHIP_VEGAM, -CHIP_VEGA10, +CHIP_VEGA10, /* GFX9 (Vega) */ CHIP_VEGA12, CHIP_VEGA20, -- 2.17.1 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev