Re: [Mesa-dev] [PATCH 1/8] nir: silence implicit conversion to 64bit

2017-01-26 Thread Jason Ekstrand 
On Thu, Jan 26, 2017 at 10:23 AM, Ian Romanick  wrote:

> I keep seeing patches like this... is it time to move BITFIELD64_* from
> mtypes.h to somewhere in util for more general use?
>

It may be time


> On 01/26/2017 05:18 AM, Emil Velikov wrote:
> > From: Emil Velikov 
> >
> > MSVC warns about implicit conversion as below. Annotate the literal
> > appropriately to silence the warning.
> >
> > nir_gather_info.c(249) : warning C4334: '<<' : result of 32-bit shift
> > implicitly converted to 64 bits (was 64-bit shift intended?)
> >
> > Signed-off-by: Emil Velikov 
> > ---
> >  src/compiler/nir/nir_gather_info.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/compiler/nir/nir_gather_info.c
> b/src/compiler/nir/nir_gather_info.c
> > index 35a1ce4dec..0c70787252 100644
> > --- a/src/compiler/nir/nir_gather_info.c
> > +++ b/src/compiler/nir/nir_gather_info.c
> > @@ -246,7 +246,7 @@ gather_intrinsic_info(nir_intrinsic_instr *instr,
> nir_shader *shader)
> > case nir_intrinsic_load_tess_level_outer:
> > case nir_intrinsic_load_tess_level_inner:
> >shader->info->system_values_read |=
> > - (1 << nir_system_value_from_intrinsic(instr->intrinsic));
> > + (1ull << nir_system_value_from_intrinsic(instr->intrinsic));
> >break;
> >
> > case nir_intrinsic_end_primitive:
> >
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/8] nir: silence implicit conversion to 64bit

2017-01-26 Thread Matt Turner 
On Thu, Jan 26, 2017 at 10:22 AM, Jason Ekstrand  wrote:
> Ugh... windows defines long to be 32-bit on 32-bit platforms  Yeah.

long is 32-bit on 32-bit x86/Linux too...

I think you mean they define long to be 32-bits on 64-bit platforms.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/8] nir: silence implicit conversion to 64bit

2017-01-26 Thread Ian Romanick 
I keep seeing patches like this... is it time to move BITFIELD64_* from
mtypes.h to somewhere in util for more general use?

On 01/26/2017 05:18 AM, Emil Velikov wrote:
> From: Emil Velikov 
> 
> MSVC warns about implicit conversion as below. Annotate the literal
> appropriately to silence the warning.
> 
> nir_gather_info.c(249) : warning C4334: '<<' : result of 32-bit shift
> implicitly converted to 64 bits (was 64-bit shift intended?)
> 
> Signed-off-by: Emil Velikov 
> ---
>  src/compiler/nir/nir_gather_info.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/compiler/nir/nir_gather_info.c 
> b/src/compiler/nir/nir_gather_info.c
> index 35a1ce4dec..0c70787252 100644
> --- a/src/compiler/nir/nir_gather_info.c
> +++ b/src/compiler/nir/nir_gather_info.c
> @@ -246,7 +246,7 @@ gather_intrinsic_info(nir_intrinsic_instr *instr, 
> nir_shader *shader)
> case nir_intrinsic_load_tess_level_outer:
> case nir_intrinsic_load_tess_level_inner:
>shader->info->system_values_read |=
> - (1 << nir_system_value_from_intrinsic(instr->intrinsic));
> + (1ull << nir_system_value_from_intrinsic(instr->intrinsic));
>break;
>  
> case nir_intrinsic_end_primitive:
> 

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/8] nir: silence implicit conversion to 64bit

2017-01-26 Thread Jason Ekstrand 
Ugh... windows defines long to be 32-bit on 32-bit platforms  Yeah.

Reviewed-by: Jason Ekstrand 

On Thu, Jan 26, 2017 at 6:05 AM, Lionel Landwerlin <
lionel.g.landwer...@intel.com> wrote:

> Reviewed-by: Lionel Landwerlin 
>
> On 26/01/17 13:18, Emil Velikov wrote:
>
>> From: Emil Velikov 
>>
>> MSVC warns about implicit conversion as below. Annotate the literal
>> appropriately to silence the warning.
>>
>> nir_gather_info.c(249) : warning C4334: '<<' : result of 32-bit shift
>> implicitly converted to 64 bits (was 64-bit shift intended?)
>>
>> Signed-off-by: Emil Velikov 
>> ---
>>   src/compiler/nir/nir_gather_info.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/compiler/nir/nir_gather_info.c
>> b/src/compiler/nir/nir_gather_info.c
>> index 35a1ce4dec..0c70787252 100644
>> --- a/src/compiler/nir/nir_gather_info.c
>> +++ b/src/compiler/nir/nir_gather_info.c
>> @@ -246,7 +246,7 @@ gather_intrinsic_info(nir_intrinsic_instr *instr,
>> nir_shader *shader)
>>  case nir_intrinsic_load_tess_level_outer:
>>  case nir_intrinsic_load_tess_level_inner:
>> shader->info->system_values_read |=
>> - (1 << nir_system_value_from_intrinsic(instr->intrinsic));
>> + (1ull << nir_system_value_from_intrinsic(instr->intrinsic));
>> break;
>>case nir_intrinsic_end_primitive:
>>
>
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/8] nir: silence implicit conversion to 64bit

2017-01-26 Thread Lionel Landwerlin 

Reviewed-by: Lionel Landwerlin 

On 26/01/17 13:18, Emil Velikov wrote:

From: Emil Velikov 

MSVC warns about implicit conversion as below. Annotate the literal
appropriately to silence the warning.

nir_gather_info.c(249) : warning C4334: '<<' : result of 32-bit shift
implicitly converted to 64 bits (was 64-bit shift intended?)

Signed-off-by: Emil Velikov 
---
  src/compiler/nir/nir_gather_info.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/compiler/nir/nir_gather_info.c 
b/src/compiler/nir/nir_gather_info.c
index 35a1ce4dec..0c70787252 100644
--- a/src/compiler/nir/nir_gather_info.c
+++ b/src/compiler/nir/nir_gather_info.c
@@ -246,7 +246,7 @@ gather_intrinsic_info(nir_intrinsic_instr *instr, 
nir_shader *shader)
 case nir_intrinsic_load_tess_level_outer:
 case nir_intrinsic_load_tess_level_inner:
shader->info->system_values_read |=
- (1 << nir_system_value_from_intrinsic(instr->intrinsic));
+ (1ull << nir_system_value_from_intrinsic(instr->intrinsic));
break;
  
 case nir_intrinsic_end_primitive:



___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 1/8] nir: silence implicit conversion to 64bit

2017-01-26 Thread Emil Velikov 
From: Emil Velikov 

MSVC warns about implicit conversion as below. Annotate the literal
appropriately to silence the warning.

nir_gather_info.c(249) : warning C4334: '<<' : result of 32-bit shift
implicitly converted to 64 bits (was 64-bit shift intended?)

Signed-off-by: Emil Velikov 
---
 src/compiler/nir/nir_gather_info.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/compiler/nir/nir_gather_info.c 
b/src/compiler/nir/nir_gather_info.c
index 35a1ce4dec..0c70787252 100644
--- a/src/compiler/nir/nir_gather_info.c
+++ b/src/compiler/nir/nir_gather_info.c
@@ -246,7 +246,7 @@ gather_intrinsic_info(nir_intrinsic_instr *instr, 
nir_shader *shader)
case nir_intrinsic_load_tess_level_outer:
case nir_intrinsic_load_tess_level_inner:
   shader->info->system_values_read |=
- (1 << nir_system_value_from_intrinsic(instr->intrinsic));
+ (1ull << nir_system_value_from_intrinsic(instr->intrinsic));
   break;
 
case nir_intrinsic_end_primitive:
-- 
2.11.0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev