want to cc to 19.2?
r-b for both
On Tue, Aug 20, 2019 at 4:47 PM Samuel Pitoiset
wrote:
>
> This gives a nice boost, +20% at this time on my Vega 56. Shader
> ballot should be enabled by default at some point but it reduces
> performance a bit (-6%) with Wolfeinstein II. Enable it only for
> Youngblood at the moment, like what we did for Talos in the past.
>
> As a bonus point, it gets rid of some minor artifacts that only
> happens when ballot is disabled for some reasons.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_device.c | 8
> 1 file changed, 8 insertions(+)
>
> diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
> index 49518d43218..c04f6a27e82 100644
> --- a/src/amd/vulkan/radv_device.c
> +++ b/src/amd/vulkan/radv_device.c
> @@ -554,6 +554,14 @@ radv_handle_per_app_options(struct radv_instance
> *instance,
> */
> if (HAVE_LLVM < 0x900)
> instance->debug_flags |= RADV_DEBUG_NO_LOAD_STORE_OPT;
> + } else if (!strcmp(name, "Wolfenstein: Youngblood")) {
> + if (!(instance->debug_flags & RADV_DEBUG_NO_SHADER_BALLOT)) {
> + /* Force enable VK_AMD_shader_ballot because it looks
> +* safe and it gives a nice boost (+20% on Vega 56 at
> +* this time).
> +*/
> + instance->perftest_flags |=
> RADV_PERFTEST_SHADER_BALLOT;
> + }
> }
> }
>
> --
> 2.22.1
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
