Re: [Mesa-dev] [PATCH 5/5] radeonsi: use common gs_table_depth code

[Nicolai Hähnle]

Patches 2, 3, 5:

Reviewed-by: Nicolai Hähnle 

On 23.04.2018 01:59, Dave Airlie wrote:

From: Dave Airlie 

---
  src/gallium/drivers/radeonsi/si_pipe.c | 33 ++---
  1 file changed, 2 insertions(+), 31 deletions(-)

diff --git a/src/gallium/drivers/radeonsi/si_pipe.c 
b/src/gallium/drivers/radeonsi/si_pipe.c
index b3ef098b8ea..327dd7c4242 100644
--- a/src/gallium/drivers/radeonsi/si_pipe.c
+++ b/src/gallium/drivers/radeonsi/si_pipe.c
@@ -661,37 +661,8 @@ static void si_destroy_screen(struct pipe_screen* pscreen)
  
  static void si_init_gs_info(struct si_screen *sscreen)

  {
-   /* gs_table_depth is not used by GFX9 */
-   if (sscreen->info.chip_class >= GFX9)
-   return;
-
-   switch (sscreen->info.family) {
-   case CHIP_OLAND:
-   case CHIP_HAINAN:
-   case CHIP_KAVERI:
-   case CHIP_KABINI:
-   case CHIP_MULLINS:
-   case CHIP_ICELAND:
-   case CHIP_CARRIZO:
-   case CHIP_STONEY:
-   sscreen->gs_table_depth = 16;
-   return;
-   case CHIP_TAHITI:
-   case CHIP_PITCAIRN:
-   case CHIP_VERDE:
-   case CHIP_BONAIRE:
-   case CHIP_HAWAII:
-   case CHIP_TONGA:
-   case CHIP_FIJI:
-   case CHIP_POLARIS10:
-   case CHIP_POLARIS11:
-   case CHIP_POLARIS12:
-   case CHIP_VEGAM:
-   sscreen->gs_table_depth = 32;
-   return;
-   default:
-   unreachable("unknown GPU");
-   }
+   sscreen->gs_table_depth = 
ac_get_gs_table_depth(sscreen->info.chip_class,
+   sscreen->info.family);
  }
  
  static void si_handle_env_var_force_family(struct si_screen *sscreen)





--
Lerne, wie die Welt wirklich ist,
Aber vergiss niemals, wie sie sein sollte.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 5/5] radeonsi: use common gs_table_depth code

[Bas Nieuwenhuizen]

Reviewed-by: Bas Nieuwenhuizen 

for the series.

On Mon, Apr 23, 2018 at 1:59 AM, Dave Airlie  wrote:
> From: Dave Airlie 
>
> ---
>  src/gallium/drivers/radeonsi/si_pipe.c | 33 ++---
>  1 file changed, 2 insertions(+), 31 deletions(-)
>
> diff --git a/src/gallium/drivers/radeonsi/si_pipe.c 
> b/src/gallium/drivers/radeonsi/si_pipe.c
> index b3ef098b8ea..327dd7c4242 100644
> --- a/src/gallium/drivers/radeonsi/si_pipe.c
> +++ b/src/gallium/drivers/radeonsi/si_pipe.c
> @@ -661,37 +661,8 @@ static void si_destroy_screen(struct pipe_screen* 
> pscreen)
>
>  static void si_init_gs_info(struct si_screen *sscreen)
>  {
> -   /* gs_table_depth is not used by GFX9 */
> -   if (sscreen->info.chip_class >= GFX9)
> -   return;
> -
> -   switch (sscreen->info.family) {
> -   case CHIP_OLAND:
> -   case CHIP_HAINAN:
> -   case CHIP_KAVERI:
> -   case CHIP_KABINI:
> -   case CHIP_MULLINS:
> -   case CHIP_ICELAND:
> -   case CHIP_CARRIZO:
> -   case CHIP_STONEY:
> -   sscreen->gs_table_depth = 16;
> -   return;
> -   case CHIP_TAHITI:
> -   case CHIP_PITCAIRN:
> -   case CHIP_VERDE:
> -   case CHIP_BONAIRE:
> -   case CHIP_HAWAII:
> -   case CHIP_TONGA:
> -   case CHIP_FIJI:
> -   case CHIP_POLARIS10:
> -   case CHIP_POLARIS11:
> -   case CHIP_POLARIS12:
> -   case CHIP_VEGAM:
> -   sscreen->gs_table_depth = 32;
> -   return;
> -   default:
> -   unreachable("unknown GPU");
> -   }
> +   sscreen->gs_table_depth = 
> ac_get_gs_table_depth(sscreen->info.chip_class,
> +   sscreen->info.family);
>  }
>
>  static void si_handle_env_var_force_family(struct si_screen *sscreen)
> --
> 2.14.3
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 5/5] radeonsi: use common gs_table_depth code

[Dave Airlie]

From: Dave Airlie 

---
 src/gallium/drivers/radeonsi/si_pipe.c | 33 ++---
 1 file changed, 2 insertions(+), 31 deletions(-)

diff --git a/src/gallium/drivers/radeonsi/si_pipe.c 
b/src/gallium/drivers/radeonsi/si_pipe.c
index b3ef098b8ea..327dd7c4242 100644
--- a/src/gallium/drivers/radeonsi/si_pipe.c
+++ b/src/gallium/drivers/radeonsi/si_pipe.c
@@ -661,37 +661,8 @@ static void si_destroy_screen(struct pipe_screen* pscreen)
 
 static void si_init_gs_info(struct si_screen *sscreen)
 {
-   /* gs_table_depth is not used by GFX9 */
-   if (sscreen->info.chip_class >= GFX9)
-   return;
-
-   switch (sscreen->info.family) {
-   case CHIP_OLAND:
-   case CHIP_HAINAN:
-   case CHIP_KAVERI:
-   case CHIP_KABINI:
-   case CHIP_MULLINS:
-   case CHIP_ICELAND:
-   case CHIP_CARRIZO:
-   case CHIP_STONEY:
-   sscreen->gs_table_depth = 16;
-   return;
-   case CHIP_TAHITI:
-   case CHIP_PITCAIRN:
-   case CHIP_VERDE:
-   case CHIP_BONAIRE:
-   case CHIP_HAWAII:
-   case CHIP_TONGA:
-   case CHIP_FIJI:
-   case CHIP_POLARIS10:
-   case CHIP_POLARIS11:
-   case CHIP_POLARIS12:
-   case CHIP_VEGAM:
-   sscreen->gs_table_depth = 32;
-   return;
-   default:
-   unreachable("unknown GPU");
-   }
+   sscreen->gs_table_depth = 
ac_get_gs_table_depth(sscreen->info.chip_class,
+   sscreen->info.family);
 }
 
 static void si_handle_env_var_force_family(struct si_screen *sscreen)
-- 
2.14.3

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev