Re: [Mesa-dev] [PATCH 5/5] softpipe: add support for vertex streams

2019-03-29 Thread Roland Scheidegger
As long as there's no regressions in llvmpipe, looks great to me.

Am 29.03.19 um 06:48 schrieb Dave Airlie:
> This enables the ARB_gpu_shader5 vertex streams on softpipe.
> 
> Signed-off-by: Dave Airlie 
> ---
>  src/gallium/drivers/softpipe/sp_screen.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/gallium/drivers/softpipe/sp_screen.c 
> b/src/gallium/drivers/softpipe/sp_screen.c
> index 438557e146a..d2c31b8935d 100644
> --- a/src/gallium/drivers/softpipe/sp_screen.c
> +++ b/src/gallium/drivers/softpipe/sp_screen.c
> @@ -122,7 +122,7 @@ softpipe_get_param(struct pipe_screen *screen, enum 
> pipe_cap param)
> case PIPE_CAP_MAX_GEOMETRY_TOTAL_OUTPUT_COMPONENTS:
>return 1024;
> case PIPE_CAP_MAX_VERTEX_STREAMS:
> -  return 1;
> +  return PIPE_MAX_VERTEX_STREAMS;
I think technically you should make this dependent on
!sp_screen->use_llvm (unless you want to fix the llvm paths :-)).

For the series:
Reviewed-by: Roland Scheidegger 



> case PIPE_CAP_MAX_VERTEX_ATTRIB_STRIDE:
>return 2048;
> case PIPE_CAP_PRIMITIVE_RESTART:
> 

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 5/5] softpipe: add support for vertex streams

2019-03-28 Thread Dave Airlie
This enables the ARB_gpu_shader5 vertex streams on softpipe.

Signed-off-by: Dave Airlie 
---
 src/gallium/drivers/softpipe/sp_screen.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/drivers/softpipe/sp_screen.c 
b/src/gallium/drivers/softpipe/sp_screen.c
index 438557e146a..d2c31b8935d 100644
--- a/src/gallium/drivers/softpipe/sp_screen.c
+++ b/src/gallium/drivers/softpipe/sp_screen.c
@@ -122,7 +122,7 @@ softpipe_get_param(struct pipe_screen *screen, enum 
pipe_cap param)
case PIPE_CAP_MAX_GEOMETRY_TOTAL_OUTPUT_COMPONENTS:
   return 1024;
case PIPE_CAP_MAX_VERTEX_STREAMS:
-  return 1;
+  return PIPE_MAX_VERTEX_STREAMS;
case PIPE_CAP_MAX_VERTEX_ATTRIB_STRIDE:
   return 2048;
case PIPE_CAP_PRIMITIVE_RESTART:
-- 
2.20.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev