Re: [Mesa-dev] [PATCH 2/5] amd/common: round cube array slice in ac_prepare_cube_coords

2017-09-13 Thread Nicolai Hähnle 

On 13.09.2017 22:20, Dave Airlie wrote:

On 14 September 2017 at 03:04, Nicolai Hähnle  wrote:

From: Nicolai Hähnle 

The NIR-to-LLVM pass already does this; now the same fix covers
radeonsi as well.

Fixes various tests of
dEQP-GLES31.functional.texture.filtering.cube_array.combinations.*


Nice to see you guys catch up, I think I asked about a lot of these workarounds
when I wrote them and didn't get much response :-), other than radeonsi doesn't
need them, looks like it did after all.


Indeed. In our defense, the only documentation I could find about a lot 
of these things is that they were fixed in gfx9 :)




Reviewed-by: Dave Airlie 


Thanks!





___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/5] amd/common: round cube array slice in ac_prepare_cube_coords

2017-09-13 Thread Dave Airlie 
On 14 September 2017 at 03:04, Nicolai Hähnle  wrote:
> From: Nicolai Hähnle 
>
> The NIR-to-LLVM pass already does this; now the same fix covers
> radeonsi as well.
>
> Fixes various tests of
> dEQP-GLES31.functional.texture.filtering.cube_array.combinations.*

Nice to see you guys catch up, I think I asked about a lot of these workarounds
when I wrote them and didn't get much response :-), other than radeonsi doesn't
need them, looks like it did after all.

Reviewed-by: Dave Airlie 
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev