Re: [Mesa-dev] uvd code break with C99 compile
- Original Message - Building on RHEL6 tinderbox, we get -std=c99, and the radeon uvd code uses anonymous unions which this disables. It doesn't look too difficult to fix, just wondering if there was a reason for using anon unions in the first place? FWIW, anonymous unions are a de-facto standard supported by all compilers (including MSVC). And are part of C11. Jose ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] uvd code break with C99 compile
Am 26.04.2013 08:48, schrieb Jose Fonseca: - Original Message - Building on RHEL6 tinderbox, we get -std=c99, and the radeon uvd code uses anonymous unions which this disables. It doesn't look too difficult to fix, just wondering if there was a reason for using anon unions in the first place? FWIW, anonymous unions are a de-facto standard supported by all compilers (including MSVC). And are part of C11. That's just the interface specification as I got it from the UVD team. Should be pretty easy to fix, and since I reworked the indention it doesn't looks like the original anyway. Christian. Jose ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] uvd code break with C99 compile
On Fri, Apr 26, 2013 at 4:48 PM, Jose Fonseca jfons...@vmware.com wrote: - Original Message - Building on RHEL6 tinderbox, we get -std=c99, and the radeon uvd code uses anonymous unions which this disables. It doesn't look too difficult to fix, just wondering if there was a reason for using anon unions in the first place? FWIW, anonymous unions are a de-facto standard supported by all compilers (including MSVC). And are part of C11. Jose Yeah I've no idea why I'm building in the tinderbox with -std=c99 it must be from the jhbuild setup, I was just wondering we were okay with using them in Mesa at this point. Dave. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] uvd code break with C99 compile
- Original Message - On Fri, Apr 26, 2013 at 4:48 PM, Jose Fonseca jfons...@vmware.com wrote: - Original Message - Building on RHEL6 tinderbox, we get -std=c99, and the radeon uvd code uses anonymous unions which this disables. It doesn't look too difficult to fix, just wondering if there was a reason for using anon unions in the first place? FWIW, anonymous unions are a de-facto standard supported by all compilers (including MSVC). And are part of C11. Jose Yeah I've no idea why I'm building in the tinderbox with -std=c99 it must be from the jhbuild setup, I was just wondering we were okay with using them in Mesa at this point. Yeah, I'm pretty sure we have a bunch of anonymous structs/unions already. e.g. src/gallium/drivers/svga/include/svga3d_reg.h Jose ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] uvd code break with C99 compile
Am 26.04.2013 10:56, schrieb Jose Fonseca: - Original Message - On Fri, Apr 26, 2013 at 4:48 PM, Jose Fonseca jfons...@vmware.com wrote: - Original Message - Building on RHEL6 tinderbox, we get -std=c99, and the radeon uvd code uses anonymous unions which this disables. It doesn't look too difficult to fix, just wondering if there was a reason for using anon unions in the first place? FWIW, anonymous unions are a de-facto standard supported by all compilers (including MSVC). And are part of C11. Jose Yeah I've no idea why I'm building in the tinderbox with -std=c99 it must be from the jhbuild setup, I was just wondering we were okay with using them in Mesa at this point. Yeah, I'm pretty sure we have a bunch of anonymous structs/unions already. e.g. src/gallium/drivers/svga/include/svga3d_reg.h I've submitted a patch to the list to get ride of the anonymous unions. But I'm unsure if we really want to do so, because other code in mesa seems to be using them quite fine. Christian. Jose ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
