Re: [meta-intel] [MinnowBoard][PATCH] systemd: Conditionally add network file for systemd

2014-11-19 Thread Darren Hart
On 11/19/14 12:17, Burton, Ross wrote:
 
 On 19 November 2014 19:40, Darren Hart dvh...@linux.intel.com
 mailto:dvh...@linux.intel.com wrote:
 
 Also, I'm not seeing similar tests elsewhere, is there a more standard
 way to handle such things for systemd/networkd? Ross?
 
 
 I'm mainly wondering why basic networkd configuration belongs in
 meta-minnow.  This is nothing to do with BSP enabling and everything to
 do with distro policy.
 

It seems to be a tricky one as the network interfaces are BSP-specific.
This is a follow-on to:

$ git show e3718d2
commit e3718d24e9d2bbdac00d6f1ebd8cbe2894981e4e
Author: Sujith H sujith_harida...@mentor.com
Date:   2014-07-30

systemd: Network configuration for minnow board

Adding network configuration for minnow board.

Which adds:

+++ b/recipes-core/systemd/systemd/10-dhcp.network
@@ -0,0 +1,5 @@
+[Match]
+Name=en*
+
+[Network]
+DHCP=yes

This is specific to Minnow having an en0 interface, while other boards
might have eth0, or some other name. The DHCP bit is arguably a DISTRO
policy however.

Perhaps a more generic version which matches a host of common names
would be better and we could drop this rather basic one from meta-minnow
all together.

-- 
Darren Hart
Intel Open Source Technology Center
-- 
___
meta-intel mailing list
meta-intel@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-intel


Re: [meta-intel] [MinnowBoard][PATCH] systemd: Conditionally add network file for systemd

2014-11-19 Thread Burton, Ross
On 19 November 2014 22:00, Darren Hart dvh...@linux.intel.com wrote:

 It seems to be a tricky one as the network interfaces are BSP-specific.
 This is a follow-on to:

 $ git show e3718d2
 commit e3718d24e9d2bbdac00d6f1ebd8cbe2894981e4e
 Author: Sujith H sujith_harida...@mentor.com
 Date:   2014-07-30

 systemd: Network configuration for minnow board

 Adding network configuration for minnow board.

 Which adds:

 +++ b/recipes-core/systemd/systemd/10-dhcp.network
 @@ -0,0 +1,5 @@
 +[Match]
 +Name=en*
 +
 +[Network]
 +DHCP=yes

 This is specific to Minnow having an en0 interface, while other boards
 might have eth0, or some other name. The DHCP bit is arguably a DISTRO
 policy however.

 Perhaps a more generic version which matches a host of common names
 would be better and we could drop this rather basic one from meta-minnow
 all together.


Considering that oe-core disables networkd, this can still be considered a
distro-specific tweak. And isn't en* the standard name for ethernet devices
on all hardware when systemd is renaming network devices, so this isn't
BSP-specific?

(
http://cgit.freedesktop.org/systemd/systemd/tree/src/udev/udev-builtin-net_id.c#n20
)

Ross
-- 
___
meta-intel mailing list
meta-intel@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-intel